Skip to content

Remove support for obsolete devkit-disks automount inhibitor

Mike Fleetwood requested to merge mfleetwo/gparted:remove-devkit-disks-v1 into master

Hi Curtis,

(Can you review and let me know if this is OK or not. When you are happy can you let me do the merge. I want to try it out and see what is possible.)

This is merge request contains a single commit to remove the use of obsolete devkit-disks inhibitor.

I tested this by running sh -x /usr/bin/gparted as root on a range of desktops and confirmed GParted still starts, and that it is executed with the same command line it was before. (With or without the found automount inhibitor command, such as udisks2-inhibit).

Confirmed working on:

  1. [OK] Debian 8 gparted shell wrapper fails before and after this. Runs /usr/lib/udisks2/udisks2-inhibit /usr/local/sbin/gpartedbin but produces this error:

    mount: bad option. Note that moving a mount residing under a shared mount is unsupported.

    The result is the same before and after this patch. I also found that this is a known bug with udisks2-inhibit on Debian.

  2. [PASS] Ubuntu 14.04 LTS gparted shell wrapper works before and after and calls:

    /usr/lib/udisks2/udisks2-inhibit /usr/local/sbin/gpartedbin

  3. [PASS] Ubuntu 18.04 LTS gparted shell wrapper works before and after and calls:

    /usr/lib/udisks2/udisks2-inhibit /usr/local/sbin/gpartedbin

  4. [PASS] CentOS 6 gparted shell wrapper works before and after and calls:

    udisks --inhibit -- hal-lock --interface org.freedesktop.Hal.Device.Storage --exclusive --run '/usr/sbin/gpartedbin '

  5. [PASS] CentOS 7 gparted shell wrapper works before and after. No udisk2-inhibit found so just calls:

    /usr/local/sbin/gpartedbin

  6. [PASS] Fedora 28 gparted shell wrapper works before and after. No udisk2-inhibit found so just calls:

    /usr/local/sbin/gpartedbin

Thanks, Mike

Edited by Mike Fleetwood

Merge request reports