1. 24 Nov, 2013 3 commits
  2. 31 Oct, 2013 2 commits
  3. 22 Oct, 2013 1 commit
    • Mike Fleetwood's avatar
      Make Partition Information dialog warnings selectable (#705596) · 98cd6938
      Mike Fleetwood authored
      Allow all partition warning messages to be selectable and copied.  Merge
      all the messages into a single Gtk::Label widget so that they can be
      selected together.
      
      Use a blank line between individual messages so that each message can be
      distinguished. Therefore each message should be formatted as one or more
      non-blank lines, with an optional trailing new line.  This is true of
      GParted internal messages and probably all external messages and errors
      from libparted and executed commands too.
      
      Bug #705596 - Partition Information Dialog - let user copy warnings
      98cd6938
  4. 21 Oct, 2013 1 commit
  5. 19 Oct, 2013 4 commits
    • Mike Fleetwood's avatar
      Remove unused function declarations for *_mtoolsrc_file() · 7ae05b72
      Mike Fleetwood authored
      Remove left behind function declarations create_mtoolsrc_file() and
      delete_mtoolsrc_file() after commit:
      
          2706f017
          Remove mtoolsrc file
      7ae05b72
    • Mike Fleetwood's avatar
      Prevent GParted starting stopped Linux Software RAID arrays (#709640) · a255abf3
      Mike Fleetwood authored
      Applying operations or just scanning the partitions in GParted was
      causing all stopped Linux Software RAID arrays to be automatically
      started.  This is not new with this patch set, but as a result of the
      following behaviour which has existed for a long time.  Chain of events
      goes likes this:
      
       1) Gparted calls commit_to_os() to update the kernel with the new
          partition table;
       2) Libparted calls ioctl() BLKPG_DEL_PARTITION on every partition to
          delete every partition from the kernel.  Succeeds on non-busy
          partitions only;
       3) Kernel emits udev partition remove event on every removed partition;
       4) Libparted calls ioctl() BLKPG_ADD_PARTITION on every non-busy
          partition to re-add the partition to the kernel;
       5) Kernel emits udev partition add event on every added partition;
       6) Udev rule:
            SUBSYSTEM=="block", ACTION=="add", ENV{ID_FS_TYPE}=="linux_raid_member", \
                    RUN+="/sbin/mdadm -I $tempnode"
          from either /lib/udef/rules.d/64-md-raid.rules or
          .../65-md-incremental.rules incrementally starts the member in a
          Linux Software RAID array.
      
      Fix by temporarily adding blank override rules files which does nothing,
      so that when the udev add and remove events for Linux Software RAID
      array member partitions fire nothing is done; but only when required.
      Note that really old versions of udev don't have rules to incrementally
      start array members and some distributions comment out such rules.
      
      Bug #709640 - Linux Swap Suspend and Software RAID partitions not
                    recognised
      a255abf3
    • Mike Fleetwood's avatar
      Detect busy status of Linux Software RAID members (#709640) · d2e1130a
      Mike Fleetwood authored
      Read the contents of /proc/mdstat file to determine if a device is a
      member of of an active RAID array.
      
          $ cat /proc/mdstat
          Personalities : [raid1]
          md1 : active raid1 sda1[2] sdb1[3]
                524224 blocks super 1.0 [2/2] [UU]
      
          md2 : active raid1 sdb2[2] sda2[3](F)
                5238720 blocks super 1.1 [2/1] [U_]
      
          md3 : active raid1 sdb3[1]
                10477440 blocks super 1.1 [2/1] [_U]
                bitmap: 1/1 pages [4KB], 65536KB chunk
      
          md4 : inactive sda4[0](S)
                1048564 blocks super 1.2
      
          unused devices: <none>
      
      There are 5 example Linux Software RAID arrays, md1 to md5.  All are
      RAID1 mirrors with 2 members, in various states.
      
          Array  Members     Status
          md1    sda1, sdb2  Fully operational.
          md2    sda2, sdb2  Member sda2 marked as faulty.  (Device sda2 is
                             still in use).
          md3    sda3, sdb3  Member sda3 has been removed.  (Device sda3 is
                             not in use).
          md4    sda4, sdb4  Incremental start of member sda4 only.  (Neither
                             member devices is in use).
          md5    sda5, sdb5  Array stopped.  (Neither member device is in
                             use).
      
      Also disable "Unmount" in the partition menu for active RAID array
      members.
      
      Bug #709640 - Linux Swap Suspend and Software RAID partitions not
                    recognised
      d2e1130a
    • Mike Fleetwood's avatar
      Recognise Linux Swap Suspend and Software RAID partitions (#709640) · fac3f5b8
      Mike Fleetwood authored
      Recognise in kernel, Linux Swap Suspend partitions.  (When hibernated
      the kernel write the RAM out to swap space and changes the magic string
      from swap space to suspend).  Recognition required either
      libparted >= 1.8.8.1 or blkid from util-linux >= 2.15 or before that
      blkid from e2fsprogs >= 1.39.
      
      Recognise Linux Software RAID partitions.  Recognition requires blkid
      from util-linux >= 2.15.
      
      Example:
      
          # blkid /dev/sda10 /dev/sda11
          /dev/sda10: ... TYPE="swsuspend"
          /dev/sda11: ... TYPE="linux_raid_member"
      
          # parted /dev/sda print
          Model: ATA SAMSUNG HM500JI (scsi)
          Disk /dev/sda: 500GB
          Sector size (logical/physical): 512B/512B
          Partition Table: msdos
      
          Number  Start   End     Size    Type      File system     Flags
          ...
          10      361GB   362GB   1074MB  logical   swsusp
          11      362GB   363GB   1074MB  logical                   raid
      
      Bug #709640 - Linux Swap Suspend and Software RAID partitions not
                    recognised
      fac3f5b8
  6. 18 Oct, 2013 3 commits
    • Mike Fleetwood's avatar
      Stop using deprecated widget alignment enumerators (#652044) · be2689ad
      Mike Fleetwood authored
      Step 3 of 3:
      
      Now that all label widgets are created with ALIGN_LEFT and ALIGN_CENTER
      alignment remove the x_align and y_align parameters from mk_label() and
      always use this alignment.  Also specify this alignment via floats
      rather than enumerators, one of which was deprecated.
      
      Bug #652044 - uses deprecated APIs
      be2689ad
    • Mike Fleetwood's avatar
      Replace widget alignment ALIGN_RIGHT with ALIGN_LEFT (#652044) · 18e2eb86
      Mike Fleetwood authored
      Step 2 of 3:
      
      ALIGN_RIGHT was only used for the size figures in the GParted > Devices
      device selector with radio buttons.  Change to ALIGN_LEFT and adjust the
      widget packing to maintain appearance.
      
      Bug #652044 - uses deprecated APIs
      18e2eb86
    • Mike Fleetwood's avatar
      Replace widget alignment ALIGN_TOP with ALIGN_CENTER (#652044) · 8b57278f
      Mike Fleetwood authored
      Gtkmm release 2.24 in February 2011 deprecated the use of these
      alignment enumerators superseding them with:
      
          Deprecated enumerator    Use instead
          Gtk::ALIGN_LEFT          Gtk::ALIGN_START
          Gtk::ALIGN_RIGHT         Gtk::ALIGN_END
          Gtk::ALIGN_TOP           Gtk::ALIGN_START
          Gtk::ALIGN_BOTTOM        Gtk::ALIGN_END
      
          gtkmm: gtkmm Enums and Flags [2.24]
          https://developer.gnome.org/gtkmm/2.24/group__gtkmmEnums.html
      
      The deprecated alignment enumerators were only used in the creation of
      Gtk::Label widgets by method Utils::mk_label().  In all but three cases
      the alignment was left, center.  So make all labels with alignment left,
      center and then stop using the deprecated enumerators.
      
      Step 1 of 3:
      
      ALIGN_TOP was only used for these 2 labels:
      
          "Path:" text in View > Device Information;
          "Path:" text in Partition > Information.
      
      Use of ALIGN_TOP makes no difference to these labels so just change to
      ALIGN_CENTER.
      
      Bug #652044 - uses deprecated APIs
      8b57278f
  7. 15 Oct, 2013 1 commit
  8. 08 Oct, 2013 3 commits
    • Curtis Gedak's avatar
    • Curtis Gedak's avatar
      Do not mask virtual file systems when using systemctl (#708378) · 43de8e32
      Curtis Gedak authored
      This enhancement removes the virtual file systems from the list of file
      systems (shown below) to be masked.
      
      The following output was captured using Fedora 19:
      
      $ systemctl list-units --full --all -t mount
      UNIT                          LOAD   ACTIVE   SUB     DESCRIPTION
      -.mount                       loaded active   mounted /
      boot.mount                    loaded active   mounted /boot
      dev-hugepages.mount           loaded active   mounted Huge Pages File System
      dev-mqueue.mount              loaded active   mounted POSIX Message Queue File System
      proc-sys-fs-binfmt_misc.mount loaded inactive dead    Arbitrary Executable File Formats File System
      run-user-1000-gvfs.mount      loaded active   mounted /run/user/1000/gvfs
      sys-fs-fuse-connections.mount loaded active   mounted FUSE Control File System
      sys-kernel-config.mount       loaded active   mounted Configuration File System
      sys-kernel-debug.mount        loaded active   mounted Debug File System
      tmp.mount                     loaded active   mounted Temporary Directory
      
      LOAD   = Reflects whether the unit definition was properly loaded.
      ACTIVE = The high-level unit activation state, i.e. generalization of SUB.
      SUB    = The low-level unit activation state, values depend on unit type.
      
      10 loaded units listed.
      To show all installed unit files use 'systemctl list-unit-files'.
      
      Bug #708378 - Advertised new feature: Use systemctl runtime mask to
                    prevent automounting (#701676) doesn't work
      43de8e32
    • Curtis Gedak's avatar
      Change systemctl to also mask /etc/fstab mount entries (#708378) · 1562994c
      Curtis Gedak authored
      A mistake was made in the following commit:
      
      Use systemctl runtime mask to prevent automounting (#701676)
      4c109df9
      
      The intention was to use 'systemctl list-units' rather than
      'systemctl list-unit-files' so that auto-generated mount files would
      also be masked and hence prevented from auto-mounting.
      
      Now 'systemctl list-units' is used.
      
      Bug #708378 - Advertised new feature: Use systemctl runtime mask to
                    prevent automounting (#701676) doesn't work
      1562994c
  9. 05 Oct, 2013 1 commit
  10. 03 Oct, 2013 2 commits
    • Mike Fleetwood's avatar
      Turn on resize2fs text progress bar (#709276) · 21e166c9
      Mike Fleetwood authored
      Turn on the text progress bar for the resize2fs command.  Looks like:
      
          # resize2fs -p /dev/sda13 262144
          resize2fs 1.41.12 (17-May-2010)
          Resizing the filesystem on /dev/sda13 to 262144 (4k) blocks.
          Begin pass 2 (max = 97177)
          Relocating blocks             XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
          Begin pass 3 (max = 80)
          Scanning inode table          XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
          Begin pass 4 (max = 5597)
          Updating inode references     XXXXXXXXX-------------------------------
      
      Bug #709276 - Percentage indicator for subcommand
      21e166c9
    • Mike Fleetwood's avatar
      Enhance line discipline in PipeCapture::OnReadable() (#709276) · 1b541235
      Mike Fleetwood authored
      Add concept of cursor position within the current line, separate from
      the end of the buffer.  This is so that programs which output a text
      progress bar using backspace, such as resize2fs -p, are displayed
      correctly.
      
      Bug #709276 - Percentage indicator for subcommand
      1b541235
  11. 24 Sep, 2013 3 commits
    • Mike Fleetwood's avatar
      Allow GParted to read the UUID from older btrfs-show command · 21aa90b8
      Mike Fleetwood authored
      All the code was there in btrfs::read_uuid() to read the UUID from the
      btrfs-show command.  It just needed enabling.
      
      This is only relevant when: (1) the blkid command is unavailable as
      GParted primarily reads the UUID through the FS_Info cache using the
      blkid command, and (2) the btrfs command is unavailable and the btrfs
      module uses the older btrfs-show command instead.
      21aa90b8
    • Mike Fleetwood's avatar
      Actually display error message from statvfs() failure · 293c8929
      Mike Fleetwood authored
      Pass error_message parameter by reference to
      get_mounted_filesystem_usage() so that the caller can access the
      modified error message when required.
      293c8929
    • Mike Fleetwood's avatar
      Add reporting of linux-swap usage (#708107) · 387b391d
      Mike Fleetwood authored
      For active swap space read the usage from /proc/swaps.  (Linux kernel
      uses units of 1 KiB).  By definition inactive swap space is 100% free.
      
          $ cat /proc/swaps
          Filename                                Type            Size    Used    Priority
          /dev/sda2                               partition       5242876 430552  -1
      
      Always set fs.read = FS::EXTERNAL even if /proc/swaps doesn't exist so
      that an attempt is made to open the file generating a specific error, in
      addition to the generic error.
      
          open("/proc/swaps", O_RDONLY): No such file or directory
      
          Unable to read the contents of this file system!
          Because of this some operations may be unavailable.
      
          The cause might be a missing software package.
          The following list of software packages is required for linux-
          swap file system support: util-linux.
      
      Closes Bug #708107 - Usage of swap space is not reported
      387b391d
  12. 19 Sep, 2013 1 commit
  13. 18 Sep, 2013 3 commits
  14. 17 Sep, 2013 2 commits
  15. 14 Sep, 2013 2 commits
  16. 11 Sep, 2013 7 commits
  17. 10 Sep, 2013 1 commit