1. 07 Apr, 2000 4 commits
    • Jody Goldberg's avatar
      Fix thinko. · f4bd1b61
      Jody Goldberg authored
      
      2000-04-06  Jody Goldberg <jgoldberg@home.com>
      
      	* src/expr.c (eval_expr) : Fix thinko.
      f4bd1b61
    • Jody Goldberg's avatar
      A small stabilization patch. Hopefully this will not conflict. · 0edb562f
      Jody Goldberg authored
      2000-04-06  Jody Goldberg <jgoldberg@home.com>
      
      	* graph.c (graph_compute_scatter_dimensions) : Minor patch to avoid
      	  crashing on empty selection.
      	* graph-view-scatter.c (graph_view_scatter_plot) : Ditto.
      	(graph_view_line_plot) : Ditto.
      0edb562f
    • Jody Goldberg's avatar
      Fix http://bugs.gnome.org/db/85/8506.html · 18e5debc
      Jody Goldberg authored
      Mixed mode references are evil.
      
      A bit of interface improvement for gtk-combo-text
      
      2000-04-06  Jody Goldberg <jgoldberg@home.com>
      
      	* src/functions/fn-string.c : Add func 'expression' to return text of
      	  formula.
      
      	* src/parser.y : It is illegal to write A1:Sheet2!A3.
      
      	* src/value.c (value_new_cellrange) : Take the eval pos so that we can
      	  correctly invert mixed mode references when necessary.
      
      	* src/expr.c (cell_ref_make_abs) : New routine.
      	(expr_relocate) : Handle changes in value_new_cellrange.
      	* src/func.c (function_marshal_arg) : Ditto.
      	* src/ranges.c (range_parse) : Ditto.
      
      	* src/corba-sheet.c (Sheet_cell_set_value) : No need to check these
      	  references.  They seem to be hard coded to be relative.
      
      	* src/functions/fn-lookup.c (gnumeric_offset) : Begin to handle
      	  relative references.
      
      	* src/sheet.c (cellref_get) : Simplify the logic a smidge.
      
      	* src/workbook.c (workbook_finish_editing) : Restore the edit area
      	  manually for now.  We may need to make the update flags finer grain.
      18e5debc
    • Miguel de Icaza's avatar
      Rename graph component name · 237ff618
      Miguel de Icaza authored
      237ff618
  2. 06 Apr, 2000 11 commits
    • Jody Goldberg's avatar
      Restore the edit area manually for now. We may need to make the update · 8ce52a88
      Jody Goldberg authored
      
      2000-04-06  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook.c (workbook_finish_editing) : Restore the edit area
      	  manually for now.  We may need to make the update flags finer grain.
      8ce52a88
    • Jody Goldberg's avatar
      update · 1e90d26f
      Jody Goldberg authored
      1e90d26f
    • Jody Goldberg's avatar
      unref the tooltip too. · 0404880a
      Jody Goldberg authored
      0404880a
    • Jody Goldberg's avatar
      Minor patch · c985018c
      Jody Goldberg authored
      c985018c
    • Morten Welinder's avatar
      I think we got it this time. · f0b3f683
      Morten Welinder authored
      f0b3f683
    • Jody Goldberg's avatar
      Init oldsplitpositions. Init format_run_parseoptions. · 7d3bc444
      Jody Goldberg authored
      
      2000-04-05  Jody Goldberg <jgoldberg@home.com>
      
      	* src/stf-parse.c (stf_parse_options_new) : Init oldsplitpositions.
      	* src/dialogs/dialog-stf-format-page.c (stf_dialog_format_page_init) :
      	  Init format_run_parseoptions.
      7d3bc444
    • Jody Goldberg's avatar
      New routine. (gtk_combo_test_finalize) : Ditto. · ba109cf0
      Jody Goldberg authored
      
      2000-04-05  Jody Goldberg <jgoldberg@home.com>
      
      	* gtk-combo-text.c (elements_free) : New routine.
      	(gtk_combo_test_finalize) : Ditto.
      	(gtk_combo_text_class_init) : Install a destructor.
      ba109cf0
    • Jody Goldberg's avatar
      Cache the Sheet* before freeing the closure. · a84d5411
      Jody Goldberg authored
      
      2000-04-05  Jody Goldberg <jgoldberg@home.com>
      
      	* src/clipboard.c (x_selection_received) : Cache the Sheet* before
      	  freeing the closure.
      
      	* src/workbook-format-toolbar.c (workbook_feedback_set) : Disable
      	  callbacks when setting the font status.  This avoids applying a
      	  spurious format.
      a84d5411
    • Morten Welinder's avatar
      Leak. · 9aac13d3
      Morten Welinder authored
      9aac13d3
    • Jody Goldberg's avatar
      merge eval_expr, eval_expr_nonempty, eval_expr_empty. · 8a1a4e5a
      Jody Goldberg authored
      
      2000-04-05  Jody Goldberg <jgoldberg@home.com>
      
      	* (*.[ch]) : merge eval_expr, eval_expr_nonempty, eval_expr_empty.
      
      	* src/xml-io.c (xml_write_attributes) : remove unused variable.
      	(xml_read_attribute) : Fix warning.
      8a1a4e5a
    • Miguel de Icaza's avatar
      Fix #8326 · 0b2c14fb
      Miguel de Icaza authored
      2000-04-05  Miguel de Icaza  <miguel@gnu.org>
      
      	Fix #8326
      
      	* src/print-info.c (print_info_new): Test was reversed here, so we
      	were actually flipping the orientation for printing.
      
      	* src/print.c (print_sheet_range): Now the routine returns the
      	number of pages printed, and can be directed not to generate
      	actual output.
      	(print_sheet_range): Do column/row fitting for the other printing
      	order as well.
      	(compute_sheet_pages): Support both empty-page printing, and non
      	empty-page printing.
      	(print_page): Can now print and detect if there is anything to
      	print.
      0b2c14fb
  3. 05 Apr, 2000 6 commits
    • Jody Goldberg's avatar
      Continue slow progress towards correctly updating the status region. · ac07ca90
      Jody Goldberg authored
      2000-04-05  Jody Goldberg <jgoldberg@home.com>
      
      	* src/commands.c (cmd_paste_cut_undo) : Use sheet_update and force a
      	  status update.
      	(cmd_paste_cut_redo) : Ditto. Change the selection here.
      
      	* src/sheet.c (sheet_flag_status_update_range) : Handle NULL ranges.
      
      	* src/selection.c (sheet_selection_add_range) : Use
      	  sheet_flag_status_update_range rather than an immediate call
      	  to selection_changed_hook (that is deprecated).
      	(sheet_selection_move) : Delete.
      	(sheet_selection_paste) : Use sheet_update.
      
      	* src/clipboard.c (clipboard_paste_region) : Remove unnecessary and
      	  incorrect code to do status updates.  The selection mechanism
      	  handles it already.
      	(x_selection_received) : Use sheet_update.
      
      	* src/about.c (dialog_about) : Add Almer.
      ac07ca90
    • Michael Meeks's avatar
      stupid typo. · 75737e98
      Michael Meeks authored
      75737e98
    • Michael Meeks's avatar
      kill leak. (sheet_destroy_styles): destroy hash. · c843f8c1
      Michael Meeks authored
      2000-04-05  Michael Meeks  <michael@helixcode.com>
      
      	* src/sheet-style.c (sheet_style_compute): kill leak.
      	(sheet_destroy_styles): destroy hash.
      
      2000-03-25  Michael Meeks  <michael@helixcode.com>
      
      	* src/sheet-object-bonobo.c (sheet_object_bonobo_load): Add
      	warnings and fixup.
      c843f8c1
    • Morten Welinder's avatar
      Sort. · f6082a64
      Morten Welinder authored
      f6082a64
    • Jody Goldberg's avatar
      Fix some updates. Be more paranoid when printing. Big speedup for implicit · a447415c
      Jody Goldberg authored
      Fix some updates.
      Be more paranoid when printing.
      Big speedup for implicit intersection.
      
      2000-04-05  Jody Goldberg <jgoldberg@home.com>
      
      	* src/functions/fn-logical.c (gnumeric_if) : Use eval_expr_nonempty
      	  and permit non-scalars.
      	* src/functions/fn-lookup.c (gnumeric_choose) : Ditto.
      	* src/functions/fn-math.c (gnumeric_sumproduct) : Ditto.
      
      	* src/functions/fn-information.c (get_value_class) : Use
      	  eval_expr_empty, and permit non-scalars.
      
      	* src/func.c (function_iterate_argument_values) : Permit non-scalar
      	  values.
      	(function_marshal_arg) : Be more specific about what types of argument
      	  must be scalar.
      
      2000-04-04  Jody Goldberg <jgoldberg@home.com>
      
      	* src/functions/fn-math.c (gnumeric_sumproduct) : eval_expr_nonempty
      	  and permit non-scalars.
      	* src/functions/fn-lookup.c (gnumeric_choose) : Ditto.
      
      	* src/expr-name.c (eval_expr_name) : Accept 'as_scalar' as an
      	  argument use eval_expr_empty.
      
      	* src/expr.c (eval_expr_real) : Push the common cases for implicit
      	  intersection further down for a big speed improvement.
      	(eval_expr_nonempty) : New routine.
      	(eval_expr_empty) : Accept as_scalar.
      
      2000-04-04  Jody Goldberg <jgoldberg@home.com>
      
      	* src/item-grid.c (item_grid_button_1) : sheet_update after button
      	  press that changes selection.
      
      2000-04-04  Jody Goldberg <jgoldberg@home.com>
      
      	* src/print.c (print_hf) : Add precautions in an attempt to address
      	  http://bugs.gnome.org/db/82/8200.html
      	  I can not replicate it, but it can't hurt to be more careful just in
      	  case.
      a447415c
    • Miguel de Icaza's avatar
      Flush the canvas updates · ddebc71f
      Miguel de Icaza authored
      2000-04-04  Miguel de Icaza  <miguel@gnu.org>
      
      	* src/item-cursor.c (item_cursor_autofill_event): Flush the canvas updates
      ddebc71f
  4. 04 Apr, 2000 4 commits
    • Kjartan Maraas's avatar
      Updated Norwegian translation. · 90d8ed64
      Kjartan Maraas authored
      2000-04-04  Kjartan Maraas  <kmaraas@online.no>
      
      	* no.po: Updated Norwegian translation.
      90d8ed64
    • Jody Goldberg's avatar
      Improve status update. · 56a9e1f0
      Jody Goldberg authored
      Simplify a few command paths in preparation for registration.
      Hopefully fix bug 3961
      
      2000-04-04  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook.c (workbook_class_init) : Remove CELL_CHANGED.
      	(workbook_finish_editing) : At LAST! cmd_set_text is responsible for
      	  setting the text directly :-)
      
      	* src/workbook-format-toolbar.c (change_font_size_in_selection_cmd) :
      	  cmd_format takes care of the height adjustments.
      	* src/dialogs/dialog-cell-format.c (cb_fmt_dialog_dialog_apply) : Ditto.
      
      	* src/sheet.c (Sheet): Add flags edit_pos_changed, selection_content_changed.
      	(sheet_new) : init them.
      	(sheet_flag_status_update_cell) : New function that sets the flags.
      	(sheet_flag_status_update_range) : Ditto.
      	(sheet_update) : Fix typo. Add support for new flags.
      	(sheet_update_auto_expr) : Const correctness.
      	(sheet_update_controls) : Ditto.
      	(sheet_load_cell_val) : Ditto. Delete unused signal.
      	(sheet_set_text) : Use sheet_flag_status_update_range.
      	(sheet_set_edit_pos) : New routine.
      	(sheet_cursor_move) : Delete.
      	(sheet_fill_selection_with) : Remove.
      
      	* src/selection.c (sheet_selection_changed_hook) : const correctness.
      	(sheet_selection_change) : merge into sheet_selection_set.
      	(sheet_selection_extend_to) : Use sheet_selection_set.
      	(sheet_selection_set) : Merge with sheet_selection_change and use the
      	  sheet_cursor accessors rather than changing things directly.
      	(sheet_selection_walk_step) : Use sheet_selection_set, and sheet_set_edit_pos.
      
      	(sheet_is_all_selected) : const correctness.
      	(sheet_is_cell_selected) : New routine.
      	(sheet_is_range_selected) : New routine.
      
      	* src/item-grid.c (item_grid_draw_background) : Adjust to rename of
      	* sheet_selection_is_cell_selected -> sheet_is_cell_selected.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) : Cleanup the
      	  logic for creating fills and arrays so that it can have undo
      	  support.
      	  - Change the heuristic for selecting what type of characters can start
      	    an edit session.  Rather than using fixed Latin1 centric codes,
      	    guess that the 'length' field of the event is >0 if the character is
      	    printable.  Be more careful NOT to forward characters to the entry
      	    if we are not editing.
      	  - Use sheet_update.
      
      	* src/commands.c (command_pop_list_top) : Delete.
      	(cmd_format_redo) : Apply the height adjustment here.
      	(cmd_set_area_*) : Implement.
      	(*) : Use sheet_update.
      
      	* src/colrow.c (rows_height_update) : Moved here and generalized from
      	  sheet_selection_height_update.
      
      	* src/clipboard.c (sheet_paste_selection) : No need to call
      	  sheet_cursor_set.  sheet_selection_add_range already does that.
      	(clipboard_paste_region) : Flag updates to the status display if
      	  something changes.
      56a9e1f0
    • Jon K Hellan's avatar
      Call gnumeric_sheet_make_visible only if sheet widget is realized. · affafc8a
      Jon K Hellan authored
      2000-04-04  Jon K Hellan  <hellan@acm.org>
      
      	* src/sheet-view.c (sheet_view_set_zoom_factor): Call
      	gnumeric_sheet_make_visible only if sheet widget is realized.
      	(sheet_view_make_edit_pos_visible): New function: Make cell at
      	edit position visible.
      	(sheet_view_size_allocate): Add call to
      	sheet_view_make_edit_pos_visible.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_make_cell_visible): Add
      	comment.
      
      	* src/xml-io.c (xml_sheet_read): Read zoom into a local variable
      	before calling sheet_set_zoom_factor. Otherwise,
      	sheet_set_zoom_factor would assume that it had already initialized
      	this factor.
      
      	* src/workbook.c (change_zoom_in_current_sheet_cb): No longer call
      	change_displayed_zoom_cb, sheet_set_zoom_factor will call it
      	indirectly.
      
      	* src/workbook.[ch] (workbook_class_init,
      	workbook_focus_current_sheet, workbook_create_standard_toobar):
      	Rename "sheet_changed" signal to "sheet_entered".  Remove
      	"cell_changed" signal.
      	(workbook_focus_current_sheet): Rename "sheet_changed" signal to
      	"sheet_entered".
      	(workbook_zoom_feedback_set): New function: Update zoom combo in
      	toolbar when zoom changes.
      
      	* src/sheet.c (sheet_update_zoom_controls): New function: Update
      	zoom controls when zoom changes.
      	(sheet_set_zoom_factor): Use it.
      	(sheet_load_cell_val): Do not emit "cell_changed".
      
      	* src/dialogs/dialog-cell-format.c (cb_fmt_dialog_dialog_apply):
      	Call sheet_update_controls to update toolbar controls.
      
      	* src/history.c (file_history_cmd): Remove pristine workbook when
      	a new one is read in. For consistency with File/Open, File/Import
      	and Bonobo File/History.
      
      	* src/dialogs/dialog-workbook-attr.c
      	(cb_attr_dialog_dialog_apply): Include workbook-view.h to get
      	prototype for workbook_view_pref_visibility.
      
      	* src/border.h (style_border_print): Remove bogus const in  prototype.
      	Reported by Aron Griffis.
      affafc8a
    • Jody Goldberg's avatar
      Bug 8315 · b7c58c38
      Jody Goldberg authored
      2000-04-04  Jody Goldberg <jgoldberg@home.com>
      
      	* ms-obj.c (ms_obj_read_biff8_obj) : Be more careful about when to
      	  dump debug info when the stated record size disagrees with the
      	  actual.
      b7c58c38
  5. 03 Apr, 2000 1 commit
  6. 02 Apr, 2000 7 commits
    • Jody Goldberg's avatar
      update · d04d91e7
      Jody Goldberg authored
      d04d91e7
    • Jody Goldberg's avatar
      Chris is 'Da Man' (tm) ! · 7fad990a
      Jody Goldberg authored
      After much wasted thought effort and hair pulling the problem boiled
      down to me not realizing that it was bad to request and update for a
      canvas item from an update routine even for a different canvas item.
      
      2000-04-02  Jody Goldberg <jgoldberg@home.com>
      
      	* src/item-edit.c (entry_changed) : Call scan_for_range here.
      	(item_edit_set_arg) : And here.
      	(recalc_spans) : But NOT here.  Calling request_update while updating
      	  any other canvas item is bad.
      
      	* src/item-cursor.c (item_cursor_set_bounds) : remove ugly hack.
      7fad990a
    • Jody Goldberg's avatar
      Add description of double quote handling. Init indicator_2x_is_single and · 527ca0cf
      Jody Goldberg authored
      
      2000-04-02  Jody Goldberg <jgoldberg@home.com>
      
      	* doc/stf-parser.txt : Add description of double quote handling.
              * src/stf-parse.c (stf_parse_options_new) : Init
      	  indicator_2x_is_single and duplicates.
      	(stf_parse_options_csv_set_indicator_2x_is_single) : New function.
      	(stf_parse_csv_cell) : Add logic to optionaly treat double quotes as a
      	  single escaped quote.
      	* src/dialogs/dialog-stf-csv-page.c : Add the double quote checkbox.
      	* src/dialogs/dialog-stf.glade : Ditto.
      527ca0cf
    • Jody Goldberg's avatar
      update · a257e631
      Jody Goldberg authored
      a257e631
    • Jody Goldberg's avatar
      ICK! Hack around the unmoving cursor problem. It seems that once the · 62df15a7
      Jody Goldberg authored
      ICK!
      Hack around the unmoving cursor problem.
      It seems that once the coloured range marker is displayed the canvas looses
      track of the need to update the item-cursor when it requests an update.
      The parent is marker as needing an update but the canvas never gets to it.
      
      2000-04-02  Jody Goldberg <jgoldberg@home.com>
      
      	* src/gnumeric-sheet.[ch] (gnumeric_sheet_get_cell_bounds) : Delete.
      
      	* src/item-edit.c (item_edit_init) : Init the feedback_cursor to NULL.
      
      	* src/item-cursor.c (item_cursor_set_bounds) : HACK to force the
      	  canvas to honour update requests.
      62df15a7
    • Jody Goldberg's avatar
      We still need the cvs export capabilities. · 602e1060
      Jody Goldberg authored
      #ifdef out the import.
      602e1060
    • Arturo Tena's avatar
      Commiting missing documentation files. · 063904a3
      Arturo Tena authored
      2000-04-01  Arturo Tena  <arturo@directmail.org>
      
      	* doc/tmpl/ms-ole-stream.sgml, doc/tmpl/ms-ole-common.sgml: Added.
      063904a3
  7. 01 Apr, 2000 7 commits
    • Michael Meeks's avatar
      Fixes to release ver 0.1.0 · 1dcf789c
      Michael Meeks authored
      1dcf789c
    • Miguel de Icaza's avatar
      updated · a609247d
      Miguel de Icaza authored
      a609247d
    • Jody Goldberg's avatar
    • Almer. S. Tigelaar's avatar
      Made sure no-one will _ever_ compile/use the old ff-stf plugin anymore. It · 15b079e9
      Almer. S. Tigelaar authored
      2000-04-01  Almer. S. Tigelaar <almer1@dds.nl>
      
      	Made sure no-one will _ever_ compile/use the old
      	ff-stf plugin anymore.
      	It is totally obsolete! We don't want bug reports
      	about it.
      15b079e9
    • Jody Goldberg's avatar
      update · dcb163ab
      Jody Goldberg authored
      dcb163ab
    • Jody Goldberg's avatar
      Regenerate. · e6add3d7
      Jody Goldberg authored
      
      2000-04-01  Jody Goldberg <jgoldberg@home.com>
      
      	* docs/C/func.defs, docs/C/functions.sgml : Regenerate.
      
      	* src/functions/*.c : Adjust some 'See Also' tags to point to existing
      	  functions.
      
      	* src/workbook.c (workbook_menu_format_sheet) : Do not use
      	  GNOMEUIINFO_TOGGLEITEM as it requires an xpm, and bonobo crashes
      	  when fed a NULL xpm.
      e6add3d7
    • Jody Goldberg's avatar
      Fix the silly edit bug tha was being reported. · fce11703
      Jody Goldberg authored
      Some major work on item-edit.
      
      2000-03-31  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook.c : Switch over to useing GNOMEUIINFO_ITEM_ where
      	  possible.
      	(cb_editline_focus_in) : Do not start editing if we are already
      	  editing.
      
      	* src/utils.c (parse_cell_name) : constness.
      
      	* src/style.c (style_font_gdk_font) : constness.
      	(style_font_gdk_font) : ditto.
      	(style_font_gnome_font) : ditto.
      	(style_font_get_height) : ditto.
      
      	* src/sheet.c (sheet_set_zoom_factor) : redimension all cells, rather
      	  than the sparse sheet region.  Do not auto-resize.
      	(sheet_cell_add) :  Adjust to new calling convention for
      	  cell_calc_dimensions.
      	(sheet_stop_editing) : Rename from sheet_destroy_edit_cursor.
      
      	* src/sheet-view.c (sheet_view_get_style_font) : constness.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_create_editing_cursor) :
      	  No need to set all those arguments.
      	(destroy_item_editor) : Merge into gnumeric_sheet_stop_editing.
      	(gnumeric_sheet_stop_editing) : Renamed from
      	  gnumeric_sheet_destroy_editing_cursor.
      
      	* src/cell.[ch] (cell_set_rendered_text) : Adjust to new calling
      	  convention for cell_calc_dimensions.
      	(cell_calc_dimensions) : Adjust calling convetion to make auto
      	  resizing optional.
      	(calc_text_dimensions) : Adjust calling convention to directly set size.
      
      	* src/sheet-style.c (re_dimension_cells_cb) :  Adjust to new calling
      	  convention for cell_calc_dimensions.
      
      	* src/item-edit.c : Major rework to behave better at margins,
      	  correctly handle cells whose display contents span differently than
      	  their displayed values, multi-line display mechanics, and a blinking
      	  cursor :-)
      fce11703