1. 19 Mar, 2006 2 commits
    • Jody Goldberg's avatar
      init valid to false in case value_coerce_to_number fails and does not set · d4b73077
      Jody Goldberg authored
      
      2006-03-18  Jody Goldberg <jody@gnome.org>
      
      	* src/graph.c (gnm_go_data_vector_get_value) : init valid to false
      	  in case value_coerce_to_number fails and does not set it.
      
      	* src/gnumeric-pane.c (cb_sheet_object_view_destroyed) : handle life
      	  cycle change.
      
      2005-12-28  Jody Goldberg <jody@gnome.org>
      
      	* src/workbook.c : Move to GsfDocMetaData
      
      	* src/commands.c (cmd_change_meta_data*) : re-work for new metadata
      	  structure.
      
      	* src/Makefile.am : remove the defunct summary.[ch]
      
      	* src/GNOME_Gnumeric-gtk.xml.in : enable the new dialog in place of
      	  the old one.
      	* src/wbcg-actions.c : ditto.
      d4b73077
    • Morten Welinder's avatar
      Fix crash exposed by foocanvas fixes. [#335052] · 9781157f
      Morten Welinder authored
      2006-03-18  Morten Welinder  <terra@gnome.org>
      
      	* src/gnumeric-pane.c (cb_sheet_object_view_destroyed): Fix crash
      	exposed by foocanvas fixes.  [#335052]
      9781157f
  2. 18 Mar, 2006 2 commits
    • Morten Welinder's avatar
      Changed parameter types to gnm_float. · ce2d05dc
      Morten Welinder authored
      2006-03-18  Morten Welinder  <terra@gnome.org>
      
      	* src/mathfunc.c (combin, permut): Changed parameter types to
      	gnm_float.
      
      2006-03-18  Morten Welinder  <terra@gnome.org>
      
      	* functions.c (gnumeric_roman): Fix error cases.
      	(gnumeric_combin): Ditto.
      ce2d05dc
    • Morten Welinder's avatar
      Take reference wb in case a URI is relative. All callers changed. · f09dc013
      Morten Welinder authored
      2006-03-18  Morten Welinder  <terra@gnome.org>
      
      	* src/parse-util.c (wbref_parse): Take reference wb in case a URI
      	is relative.  All callers changed.
      
      	* src/application.c (cb_workbook_uri): Renamed from
      	cb_workbook_name.
      	(gnm_app_workbook_get_by_uri): Renamed from
      	gnm_app_workbook_get_by_name.
      	(gnm_app_workbook_get_by_name): New function that tries URI,
      	absolute filename, and relative URI.
      f09dc013
  3. 17 Mar, 2006 1 commit
    • Morten Welinder's avatar
      s/close/closure/. (The former is reserved by libc.) (cb_workbook_index): · 04b8968f
      Morten Welinder authored
      2006-03-17  Morten Welinder  <terra@gnome.org>
      
      	* src/application.c (gnm_app_workbook_get_by_index,
      	gnm_app_workbook_get_by_name): s/close/closure/.  (The former is
      	reserved by libc.)
      	(cb_workbook_index): Actually set a result.
      
      	* src/item-edit.c (item_edit_dispose): Rename from
      	item_edit_finalize and hook up as such.  Otherwise it may not get
      	run.
      	* src/item-bar.c (item_bar_dispose): Ditto.
      
      	* src/preview-grid.c (preview_grid_dispose): Rename from
      	preview_grid_destroy and hook up as such.
      
      2006-03-17  Morten Welinder  <terra@gnome.org>
      
      	* functions.c (gnumeric_effect, gnumeric_nominal): Improve for
      	weird nper.
      	(gnumeric_dollarde, gnumeric_dollarfr): Fix for negative amounts.
      	Improve Excel compatibility.
      04b8968f
  4. 16 Mar, 2006 4 commits
    • Morten Welinder's avatar
      Even though the third argument of style_border_fetch isn't used yet, get · 3c0ea2d6
      Morten Welinder authored
      2006-03-16  Morten Welinder  <terra@gnome.org>
      
      	* ms-excel-read.c (excel_get_style_from_xf): Even though the third
      	argument of style_border_fetch isn't used yet, get it right.
      
      2006-03-16  Morten Welinder  <terra@gnome.org>
      
      	* src/style-border.h (STYLE_BORDER_LOCATION_TO_STYLE_ELEMENT): New
      	translation macro that produces a value of the right type.
      
      2006-03-16  Morten Welinder  <terra@gnome.org>
      
      	* dialog-cell-format.c (border_get_mstyle): Don't add a bogus
      	MSTYLE_BORDER_TOP to the location.
      3c0ea2d6
    • Morten Welinder's avatar
      Use STYLE_BORDER_LEFT, not MSTYLE_BORDER_LEFT, for argument to · 3161f1c8
      Morten Welinder authored
      2006-03-16  Morten Welinder  <terra@gnome.org>
      
      	* src/wbc-gtk.c (cb_border_activated): Use STYLE_BORDER_LEFT, not
      	MSTYLE_BORDER_LEFT, for argument to style_border_get_orientation!
      	Ditto for _RIGHT.
      3161f1c8
    • Morten Welinder's avatar
      Silence a "sparse" warning. · 7602497f
      Morten Welinder authored
      2006-03-16  Morten Welinder  <terra@gnome.org>
      
      	* src/cell.c (cell_copy): Silence a "sparse" warning.
      
      2006-03-16  Morten Welinder  <terra@gnome.org>
      
      	* ms-excel-read.c (excel_read_EXTERNNAME): Use NULL, not 0.
      	* ms-biff.c (ms_biff_query_next): Ditto.
      	(ms_biff_query_destroy): Ditto.
      	(ms_biff_put_new): Ditto.
      	(ms_biff_put_len_next): Ditto.
      	(ms_biff_put_len_commit): Ditto.
      7602497f
    • Morten Welinder's avatar
      Compare valign with the result of gnm_style_get_align_v, not · ab09a55e
      Morten Welinder authored
      2006-03-16  Morten Welinder  <terra@gnome.org>
      
      	* src/wbcg-actions.c (wbcg_set_selection_valign): Compare valign
      	with the result of gnm_style_get_align_v, not
      	gnm_style_get_align_h.
      
      	* src/cell.h (cell_eval): Fix "sparse" warning and add "do { }
      	while(0)" wrapper.
      
      	* src/auto-format.c (do_af_suggest): Don't compare value types
      	against GNM_EXPR_OP_ARRAY_CORNER and GNM_EXPR_OP_ARRAY_ELEM.
      
      	* src/gnm-style-impl.h (GnmStyle): The v_align is not of type
      	GnmHAlign. Really.
      
      	* src/xml-sax-read.c (xml_sax_object_start): Use NULL, not FALSE.
      	* src/xml-io.c (xml_read_sheet_object): Ditto.
      	* src/expr.c (gnm_expr_top_is_err): Ditto.
      
      2006-03-16  Morten Welinder  <terra@gnome.org>
      
      	* openoffice-read.c (od_chart_grid): Use GOG_AXIS_UNKNOWN (== -1),
      	not UNKNOWN (== 10).
      ab09a55e
  5. 15 Mar, 2006 4 commits
  6. 14 Mar, 2006 3 commits
  7. 13 Mar, 2006 1 commit
  8. 12 Mar, 2006 1 commit
  9. 11 Mar, 2006 2 commits
    • Jody Goldberg's avatar
      minor warning suppression. · b5cf3dd1
      Jody Goldberg authored
      
      2006-03-10  Jody Goldberg <jody@gnome.org>
      
      	* src/workbook-view.c (wb_view_sendto) : minor warning suppression.
      b5cf3dd1
    • Morten Welinder's avatar
      New type for top-level expressions. Use a top-level expression here. · ed91f989
      Morten Welinder authored
      2006-03-10  Morten Welinder  <terra@gnome.org>
      
      	* src/expr.h (GnmExprTop): New type for top-level expressions.
      	* src/clipboard.h (GnmCellCopy): Use a top-level expression here.
      	Rename it to "texpr" to make sure we catch all users.  All users
      	changed.
      	* src/dependent.h (GnmDependent): Ditto.
      	* src/expr-name.h (GnmNamedExpr): Ditto.
      	* src/style-conditions.h (GnmStyleCond): Ditto.
      	* src/validation.h (GnmValidation): Ditto.
      
      	* src/expr.c (gnm_expr_top_new, gnm_expr_top_new_constant,
      	gnm_expr_top_ref, gnm_expr_top_unref, gnm_expr_top_unwrap,
      	gnm_expr_top_is_shared, gnm_expr_top_is_err,
      	gnm_expr_top_is_rangeref, gnm_expr_top_get_constant,
      	gnm_expr_top_contains_subtotal, gnm_expr_top_referenced_sheets,
      	gnm_expr_top_first_funcall, gnm_expr_top_get_boundingbox,
      	gnm_expr_top_rewrite, gnm_expr_top_get_ranges, gnm_expr_top_equal,
      	gnm_expr_top_as_string, gnm_expr_top_as_gstring,
      	gnm_expr_top_eval, gnm_expr_top_get_ranges): New functions.  Many
      	non-top versions made static.
      	(gnm_expr_copy): New function replacing gnm_expr_ref.  (Still
      	simply refs, but not for long.)
      
      	*/*.c: Massive changes adapting to the above.
      ed91f989
  10. 10 Mar, 2006 1 commit
  11. 09 Mar, 2006 1 commit
    • Morten Welinder's avatar
      Take GnmCell instead of its value for target. Use formatted value in !src · 3a834dc4
      Morten Welinder authored
      2006-03-09  Morten Welinder  <terra@gnome.org>
      
      	* src/sheet-filter.c (filter_expr_eval): Take GnmCell instead of
      	its value for target.  Use formatted value in !src case.
      	(filter_expr_init): String EQ and NE should not coerce to number.
      	(collect_unique_elements): Limit menu text length.  Change hash
      	key to formatted value instead of value.  Store formatted value,
      	not GnmValue, in model.
      	All this fixes #333809.
      3a834dc4
  12. 08 Mar, 2006 1 commit
  13. 07 Mar, 2006 2 commits
  14. 06 Mar, 2006 1 commit
    • Morten Welinder's avatar
      Rename COLLECT_DATES flags to COLLECT_COERCE_STRINGS and make it make all · c64bebba
      Morten Welinder authored
      2006-03-06  Morten Welinder  <terra@gnome.org>
      
      	* src/collect.c (callback_function_collect): Rename COLLECT_DATES
      	flags to COLLECT_COERCE_STRINGS and make it make all kinds of
      	strings.  All callers changed.
      
      2006-03-06  Morten Welinder  <terra@gnome.org>
      
      	* functions.c (gnumeric_xnpv): Fix handling of bools and strings.
      	(gnumeric_xirr): Fix handling of strings.  [#333620]
      	(gnumeric_xirr): Handle failing Newton search.  [#333631]
      c64bebba
  15. 05 Mar, 2006 1 commit
  16. 04 Mar, 2006 1 commit
    • Eduardo Lima's avatar
      delete. All callers changed to dialog_doc_metadata_set_label_text. · d6edd5c2
      Eduardo Lima authored
      2006-03-04  Eduardo Lima  <eduardo.lima@indt.org.br>
      	* dialog-doc-metadata.c:
      	(dialog_doc_metadata_set_label_text_with_gsf_prop_value): delete.
      	All callers changed to dialog_doc_metadata_set_label_text.
      	(dialog_doc_metadata_get_gsf_prop_value): delete.
      	(dialog_doc_metadata_get_gsf_prop_value_as_str): delete.
      	(dialog_doc_metadata_get_value_as_str): renamed to
      	dialog_doc_metadata_get_prop_value_as_str. All callers changed.
      d6edd5c2
  17. 03 Mar, 2006 1 commit
    • Eduardo Lima's avatar
      Code reformulation. Adjusted some properties. defined · c7178e7d
      Eduardo Lima authored
      2006-03-03  Eduardo Lima  <eduardo.lima@indt.org.br>
      
      	* src/dialogs/dialog-doc-metadata.c: Code reformulation.
      	* src/dialogs/doc-meta-data.glade: Adjusted some properties.
      	* src/dialogs/help.h: defined GNUMERIC_HELP_LINK_METADATA.
      c7178e7d
  18. 02 Mar, 2006 1 commit
  19. 01 Mar, 2006 1 commit
  20. 28 Feb, 2006 1 commit
  21. 27 Feb, 2006 1 commit
    • Morten Welinder's avatar
      Plug leaks. · 4ca25bed
      Morten Welinder authored
      2006-02-27  Morten Welinder  <terra@gnome.org>
      
      	* src/expr.c (do_gnm_expr_unref): Plug leaks.
      4ca25bed
  22. 26 Feb, 2006 1 commit
    • Morten Welinder's avatar
      Attach to notify::uri and notify::dirty in order to control window title. · df465250
      Morten Welinder authored
      2006-02-26  Morten Welinder  <terra@gnome.org>
      
      	* src/workbook-control-gui.c (wbcg_create): Attach to notify::uri
      	and notify::dirty in order to control window title.
      
      	* src/workbook-control.c (wb_control_update_title): Remove.
      
      	* src/workbook-control-priv.h (WorkbookControl): Remove
      	"set_title" member.
      
      	* src/commands.c (GnmCommand): Add "workbook_modified_before_do"
      	member.
      	(command_undo): If !workbook_modified_before_do, mark the workbook
      	not modified after undo.
      	(command_push_undo, command_redo): Setup
      	workbook_modified_before_do.
      
      	* src/workbook-priv.h: Add "pristine" member.
      
      	* src/sheet.h (Sheet): Remove "modified" and "pristine" members.
      
      	* src/sheet.c (sheet_mark_dirty): Renamed from sheet_set_dirty.
      	Always mark dirty, so kill last argument.  All callers changed.
      
      	* src/workbook.c (workbook_get_property, workbook_set_property):
      	New functions.
      	(workbook_class_init): Install workbook_get_property and
      	workbook_set_property.  Install new properties "uri" and "dirty".
      	Remove FILENAME_CHANGED signal and fix callers to use notify::uri.
      	(workbook_sheet_add): Drop dirty argument.  Adding a sheet always
      	dirties the workbook.  All callers changed.
      	(workbook_mark_not_modified): New function.
      	(workbook_set_dirty, workbook_is_dirty): Maintain a simply
      	"modified" flag.
      	(workbook_is_pristine): Maintain a simple workbook-level
      	"pristine" flag.
      	(workbook_set_placeholder, workbook_is_placeholder): Remove.
      	(workbook_new_with_sheets): After adding sheets, mark workbook not
      	modified and pristine.
      	(workbook_sheet_attach_at_pos): Mark workbook dirty.
      	(workbook_sheet_delete): Except during workbook destruction, mark
      	workbook dirty.
      df465250
  23. 25 Feb, 2006 1 commit
    • Morten Welinder's avatar
      Simplify. (wbcg_get_scg): Rename from wbcg_sheet_to_page_index and changed · d5b88432
      Morten Welinder authored
      2006-02-24  Morten Welinder  <terra@gnome.org>
      
      	* src/workbook-control-gui.c (wbcg_sheet_remove): Simplify.
      	(wbcg_get_scg): Rename from wbcg_sheet_to_page_index and changed
      	to return the scg only.  Make static.  All callers changed.
      
      	* src/workbook.c (workbook_sheet_remove_controls): Renamed from
      	workbook_sheet_hide_controls.
      	(cb_sheet_visibility_change): Remove.  The workbook doesn't care
      	about sheet visibility.
      
      	* src/workbook-control-gui.c (wbcg_sheet_add): Set
      	SHEET_CONTROL_GUI here.  Do everything here for invisible sheets
      	too, but hide the table widget.  Attach signals for visibility
      	[new] and sheet tabs here, not in wbcg_sheet_focus.
      	(disconnect_sheet_signals): Take an extra argument to control
      	whether to clear all signals or just those for the active sheet.
      	All callers changed.
      	(cb_sheet_label_button_press): Use the scg for data and simplify.
      	(wbcg_sheet_remove_all): Disconnect signals for all sheets.  Use
      	gtk_widget_destroy to get rid of the page.
      	(wbcg_page_index_to_sheet): Remove.  Expand left-over bits to
      	callers.
      	(wbcg_sheet_to_page_index): Simplify now that sheets are 1-1 with
      	tabs.
      
      	* src/sheet-control-gui.c (sheet_control_gui_new): Don't set
      	SHEET_CONTROL_KEY here.
      
      	* src/workbook-control-gui.c (SHEET_CONTROL_KEY): Move to here.
      	* src/sheet-control-gui.h (SHEET_CONTROL_KEY): From here.
      d5b88432
  24. 24 Feb, 2006 1 commit
  25. 23 Feb, 2006 2 commits
  26. 22 Feb, 2006 2 commits