1. 24 Dec, 2001 1 commit
    • Jody Goldberg's avatar
      mark as needing a recalc, don't just assert it. · 208fc52c
      Jody Goldberg authored
      2001-12-24  Jody Goldberg <jody@gnome.org>
      	* src/style-condition.c (style_condition_expr_eval) : mark as needing
      	  a recalc, don't just assert it.
      	* src/workbook-edit.c (wbcg_edit_validate) : handle accept/reject/reedit
      	  Generate the title and msg here.  The goal is to move the gui
      	  specific aspects out of here.
      	(wbcg_edit_finish) : ditto.
      	* src/gui-validation.c (validation_generate_msg) : disable for now.
      	  It is a nice idea, but the implementation is in the wrong place
      	  and blows goats.
  2. 21 Dec, 2001 1 commit
  3. 18 Dec, 2001 1 commit
    • Jody Goldberg's avatar
      style_condition_new_expr change. (xml_sax_merge) : parse_range change. · 3e586c5e
      Jody Goldberg authored
      2001-12-18  Jody Goldberg <jody@gnome.org>
      	* xml-sax-read.c (xml_sax_style_condition_expr) :
      	  style_condition_new_expr change.
      	(xml_sax_merge) : parse_range change.
      2001-12-18  Jody Goldberg <jody@gnome.org>
      	* dialog-consolidate.c (construct_consolidate) : parse_range change.
      	* dialog-printer-setup.c (do_fetch_page_info) : ditto.
      	* dialog-cell-format.c (validation_rebuild_validation) : no need
      	  to pass sheets to create the style conditions.
      	* dialog-advanced-filter.c (dialog_advanced_filter) : Use Range.
      2001-12-18  Jody Goldberg <jody@gnome.org>
      	* src/gui-clipboard.c (x_selection_handler) :  tweak the
      	  interface for serializing a CellRegion.
      	(x_selection_received) : rework the handling of gnumeric -> gnumeric
      	  operations, change the atom to be the mime type, and add hooks to
      	  prepare for html parsing.
      	* src/xml-io.c (cell_copy_new) : new.
      	(xml_read_cell_copy) : new.
      	(xml_cellregion_read) : new.
      	(xml_cellregion_write) : new.
      2001-12-18  Jody Goldberg <jody@gnome.org>
      	* src/parse-util.c (cellref_name) : avoid temporaries.
      	* src/validation.c (validation_link) : new.
      	(validation_unlink) : new.
      	* src/ranges.c (parse_range) : clean the interface to actually take a
      	* src/print-info.c (load_range) : parse_range change.
      	* src/sheet-object.c (sheet_object_read_xml) : ditto.
      	* gnumeric.mime : Add Applix.
      	* src/style-condition.c (style_condition_new_expr) : do not link in
      	  on creation, there is no need for a sheet here.
      	(style_condition_constraint_eval) : ignore SCC_IS_CUSTOM.
      	(style_condition_link) : new.
      	(style_condition_unlink) : new.
      	* src/mstyle.c (mstyle_link_sheet) : link validation elements.
      	(mstyle_unlink_sheet) : unlink validation elements.
  4. 04 Nov, 2001 1 commit
    • Jody Goldberg's avatar
      support new 'boolean expression' · 585950e1
      Jody Goldberg authored
      2001-11-04  Jody Goldberg <jgoldberg@home.com>
      	* src/gui-validation.c (validation_generate_msg) : support new
      	'boolean expression'
      	* src/style-condition.c (style_condition_expr_eval) : ditto.
  5. 30 Oct, 2001 1 commit
  6. 27 Oct, 2001 1 commit
    • Almer S. Tigelaar's avatar
      Enable validate menu item. · eb66eee8
      Almer S. Tigelaar authored
      2001-10-27  Almer S. Tigelaar  <almer@gnome.org>
      	* src/GNOME_Gnumeric.xml: Enable validate menu item.
      	* src/validation.[ch]: New, defines a container for
      	validation settings.
      	* src/Makefile.am: Add new validation.[ch]
      	* src/gnumeric.h: Add validation declaration.
      	* src/gui-validation.[ch] (validation_mstyle_get_title): Burn.
      	(validation_generate_msg): Rework slightly to accept a stylecondition
      	instead of an mstyle.
      	(validation_mstyle_get_msg): Burn.
      	(validation_mstyle_get_msg_subst): Burn.
      	(validation_mstyle_set_title_msg): Burn.
      	(validation_get_accept): Request a validation instead of
      	an mstyle. Actually free the automatically generated message.
      	* src/mstyle.[ch]: Adjust mstyle_names to include hidden/locked.
      	(mstyle_hash): Remove validation style hashing.
      	(mstyle_element_dump): Don't dump validation message, dump validation
      	refcount instead.
      	(mstyle_element_equal): Remove comparing of style and message.
      	(mstyle_elements_equal): Don't give a mismatched types warning if
      	one of the elements is not set.
      	(mstyle_element_ref): Ref validation, remove reffing of msg.
      	(mstyle_element_unref): Idem for unref.
      	(mstyle_new_default): Don't initialize any validation related
      	(mstyle_set_validation): Set a Validation instead of a StyleCondition.
      	(mstyle_get_validation): Idem for get.
      	(mstyle_set_validation_style): Burn.
      	(mstyle_get_validation_style): Burn.
      	(mstyle_set_validation_msg): Burn.
      	(mstyle_get_validation_msg): Burn.
      	* src/style-condition.c (style_condition_new_constraint): Initialize
      	from passed parameter!
      	* src/style-condition.h: Remove validation enum.
      	* src/workbook-control-gui.c (cb_data_validate): Enable.
      	(workbook_control_gui_init): Change index of consolidate
      	menu item.
      	* src/workbook-edit.c (wbcg_edit_validate) : Get the StyleCondition
      	from the validation. The validation element must be set on the mstyle.
      	Pass validation, not mstyle, to validation_get_accept.
      	(wbcg_edit_finish): Only call wbcg_edit_validate if the validation
      	element is set on the mstyle.
      	* src/xml-io.c (xml_write_style_condition_chain): Generates a
      	StyleConditionChain in XML format.
      	(xml_read_style_condition_chain): Turns an XML description of a
      	StyleConditionChain into a real StyleConditionChain.
      	(xml_write_style): Add validation support.
      	(xml_read_style): Idem.
      2001-10-27  Almer S. Tigelaar  <almer@gnome.org>
      	* dialog-cell-format.c (validation_style_condition_chain_rebuild): Rename
      	to validation_rebuild_validation.
      	(validation_rebuild_validation): Also set error style, title and message
      	on validation.
      	(cb_validation_error_action_deactivate): Don't set error style on
      	mstyle directly.
      	(cb_validation_operator_deactivate): Adjust for name change.
      	(cb_validation_constraint_type_deactivate): Don't rebuild chain from
      	here, cb_validation_error_action_deactivate will do this.
      	(cb_validation_bounds_changed): Adjust for name change.
      	(cb_validation_flags_changed): Idem.
      	(cb_validation_error_title_msg): Don't set title and message directly
      	on mstyle. Call validation_rebuild_validation instead.
      	(fmt_dialog_init_from_style_condition): Rename to
      	(fmt_dialog_init_validation_from_style_condition): Use passed
      	stylecondition instead of re-fetching it from the mstyle.
      	(fmt_dialog_init_validation_page): Correctly initialize everything
      	from the new, single mstyle_validation element.
  7. 25 Oct, 2001 1 commit
    • Wayne Schuller's avatar
      New canvas based header and footer preview widget. The customize · f0770524
      Wayne Schuller authored
      2001-10-21  Wayne Schuller <k_wayne@linuxpower.org>
      	* dialog-printer-setup.c : New canvas based header and footer preview
      	  widget. The customize header/footer widget now also uses a
      	  GnomePropertyBox for UI consistency.
      	* print.glade : Updated.
      	* hf-config.glade : Updated.
      2001-10-25  Jody Goldberg <jgoldberg@home.com>
      	* src/ranges.c (range_trim) : decrease lobotomization factor.
      2001-10-23  Jody Goldberg <jgoldberg@home.com>
      	* src/expr-name.c (named_expr_new) : renamed from add_real, simplified
      	(expr_name_add) : take and store a parse position.
      	(expr_name_create) : ditto.
      	(expr_name_destroy) : adjust to stored parsepos.
      	(expr_name_unlink) : ditto.
      	(expr_name_sheet2wb) : ditto.
      	(expr_name_init) : ditto.
      	(expr_name_as_string) : renamed from expr_name_value.
      	(expr_name_eval) : renamed from eval_expr_name.
      	* src/expr.c (do_expr_tree_to_string) : Use value_as_string in most
      	* src/value-sheet.c (value_cellrange_get_as_string) : delete bogus
      	  useless arg.
      	(encode_cellref) : delete redundant.
      	* src/parse-util.c (cellref_name) : ICK!  XL wraps relative references
      	  that are out of bounds.
  8. 22 Oct, 2001 2 commits
    • Almer S. Tigelaar's avatar
      Remove debug message. · cd74f39f
      Almer S. Tigelaar authored
      2001-10-23  Almer S. Tigelaar  <almer@gnome.org>
      	* src/style-condition.c (style_condition_flags_eval): Remove
      	debug message.
    • Almer S. Tigelaar's avatar
      Re-Order validation Enum and define new StyleCondition types. · 1f870795
      Almer S. Tigelaar authored
      2001-10-22  Almer S. Tigelaar  <almer@gnome.org>
      	* src/style-condition.h :
      	Re-Order validation Enum and define new StyleCondition
      	* src/style-condition.c (style_condition_expr_dep_eval) :
      	Renamed from style_condition_dep_eval.
      	(style_condition_expr_set_expr) :
      	Renamed from style_condition_set_expr.
      	(style_condition_expr_dep_debug_name) :
      	Renamed from style_condition_dep_debug_name.
      	(style_condition_new_expr): Renamed from
      	(style_condition_new_constraint): New, creates a
      	stylecondition of type constraint.
      	(style_condition_new_flags): New, creates a stylecondition
      	of type flags.
      	(style_condition_unref): Deal with changes in stylecondition
      	(style_condition_chain): Add operator parameter.
      	(style_condition_expr_eval): Split out from style_condition_eval.
      	(style_condition_constraint_eval): Idem.
      	(style_condition_flags_eval): New, handles allow blank.
      	(style_condition_dump): New, dumps a style condition chain to the
      	screen. For debugging purposes.
      	(style_condition_eval): Handle the new chain operators and use
      	the *_eval functions.
  9. 09 Oct, 2001 1 commit
    • Jody Goldberg's avatar
      Disable embeddable grid, it is broken. · 19c0553b
      Jody Goldberg authored
      2001-10-09  Jody Goldberg <jgoldberg@home.com>
      	* GNOME_Gnumeric.oaf.in : Disable embeddable grid, it is broken.
      2001-10-09  Jody Goldberg <jgoldberg@home.com>
      	* src/eval.c (dependent_set_expr) : Make a default handler to merge
      	  all the different states that have croppedup into one place.
      	* src/gnumeric-graph.c (gnm_graph_vector_set_expr) : Use the default.
      	* src/sheet-object-widget.c (checkbox_set_expr) : ditto.
      	* src/style-condition.c (style_condition_dep_set_expr) : The default
      	  handles most of the work.
      	* src/style-condition.c : Use DEPENDENT_MAKE_TYPE.
  10. 08 Oct, 2001 1 commit
    • Almer S. Tigelaar's avatar
      Add StyleFormat parameter and support for new non-value conditions. · 33d1a985
      Almer S. Tigelaar authored
      2001-10-08  Almer S. Tigelaar  <almer@gnome.org>
      	* src/style-condition.[ch] (style_condition_eval):
      	Add StyleFormat parameter and support for new non-value
      	(style_condition_new): Don't demand expression for
      	non-value restrictions.
      	(style_condition_chain): Fix typo preventing chaining.
      	* src/workbook-edit.c (wbcg_edit_validate): Pass
      	StyleFormat parameter to style_condition_eval if
      	the cell has one.
  11. 06 Sep, 2001 1 commit
  12. 03 Sep, 2001 1 commit
    • Jody Goldberg's avatar
      Do some guessing about how they store the format information. · 7d9c8739
      Jody Goldberg authored
      2001-09-03  Jody Goldberg <jgoldberg@home.com>
      	* ms-excel-read.c (ms_excel_read_cf) : Do some guessing about how they
      	  store the format information.
      	(ms_excel_read_sheet) : merge in ms_excel_read_cell, and reorder the
      	  records to match their biff order.  call ms_excel_read_cf.
      2001-09-02  Jody Goldberg <jgoldberg@home.com>
      	* biff-types.h : Add CONDFMT
      2001-09-02  Jody Goldberg <jgoldberg@home.com>
      	* src/style-condition.h : Qualify the namespace better.
  13. 02 Sep, 2001 2 commits
    • Jody Goldberg's avatar
      For Wayne Schuller <k_wayne@linuxpower.org> · bb833c86
      Jody Goldberg authored
      2001-09-02  Jody Goldberg <jgoldberg@home.com>
      	For Wayne Schuller <k_wayne@linuxpower.org>
      	* src/pattern.c (gnumeric_background_set_pc) : Support gray scale
      	  patterns when printing.
      2001-09-02  Jody Goldberg <jgoldberg@home.com>
      	* src/style-condition.c (style_condition_eval) : Use dependent_eval
      	  and add an invariant that ensures that val is only NULL if we have
      	  been queued for recalc.
      	* src/eval.c (dependent_eval) : split from workbook_recalc.
      	(cell_eval) : change return type.  no one was using it.
      	(dependent_needs_recalc) : new macro.
    • Almer S. Tigelaar's avatar
      Implementation of conditionals. · 5ff37265
      Almer S. Tigelaar authored
      2001-09-02  Almer S. Tigelaar  <almer@gnome.org>
      	* src/style-condition.[ch]: Implementation of conditionals.
      	* src/gnumeric.h: Add StyleCondition here.
      	* src/mstyle.c (mstyle_hash): Hash validation style.
      	(mstyle_element_dump): Dump validation message.
      	(mstyle_element_equal): Add support for validation elements.
      	(mstyle_element_ref): Ref validation message and style condition.
      	(mstyle_element_unref): Idem.
      	(mstyle_new_default): Initialize validation elements.
      	(mstyle_set_validation): Sets validation style condition.
      	(mstyle_get_validation): Gets ....
      	(mstyle_set_validation_style): Sets validation style.
      	(mstyle_get_validation_style): Gets ....
      	(mstyle_set_validation_msg): Sets validation message.
      	(mstyle_get_validation_msg): Gets ....
      	* src/mstyle.h: Add the new elements.
      	* src/workbook-edit.c (wbcg_edit_validate): Do the validation
      	and handle the consequences if it fails.
      	(wbcg_edit_finish): Use wbcg_edit_validate and discard the input
      	if needed.