1. 24 Dec, 2001 1 commit
    • Jody Goldberg's avatar
      define G_OBJECT_GET_CLASS to simplify porting to 2.0 · 89aa026e
      Jody Goldberg authored
      2001-12-24  Jody Goldberg <jody@gnome.org>
      
      	* src/gnumeric.h : define G_OBJECT_GET_CLASS to simplify porting to 2.0
      
      	For Yukihiro Nakai  <nakai@gnome.gr.jp>
      	* src/stf-parse.c (stf_parse_is_valid_data) : check for multi-byte
      	  before using locale specific isprint.
      89aa026e
  2. 21 Dec, 2001 1 commit
  3. 13 Dec, 2001 1 commit
    • Andreas J. Guelzow's avatar
      first split is not the end of a column (Bug #66433) alphabetize · f6ee7614
      Andreas J. Guelzow authored
      2001-12-13  Andreas J. Guelzow  <aguelzow@taliesin.ca>
      
      	* dialog-stf-fixed-page.c (fixed_page_autodiscover) :
      	  first split is not the end of a column (Bug #66433)
      	* dialogs/dialog-analysis-tools.c : alphabetize
      	(dialog_ftest_tool_init) : fix typo (Bug #66880)
      
      2001-12-13  Andreas J. Guelzow  <aguelzow@taliesin.ca>
      
      	* src/stf-parse.c (stf_parse_options_fixed_autodiscover) :
      	  Only delete one split for each empty column (Bug #66433)
      f6ee7614
  4. 10 Oct, 2001 1 commit
  5. 16 Jul, 2001 3 commits
    • Morten Welinder's avatar
      Don't reverse the fields in case there are too many. · b047272b
      Morten Welinder authored
      2001-07-16  Morten Welinder  <terra@diku.dk>
      
      	* src/stf-parse.c (stf_parse_csv_line): Don't reverse the fields
       	in case there are too many.
      	(stf_parse_fixed_line): Ditto.
      	(stf_parse_general): Plug leak.
      b047272b
    • Almer S. Tigelaar's avatar
      Use g_list_append and g_list_reverse. (stf_parse_fixed_line): Idem. · 3dd0345b
      Almer S. Tigelaar authored
      2001-07-16  Almer S. Tigelaar  <almer@gnome.org>
      
      	* src/stf-parse.c (stf_parse_csv_line): Use g_list_append and
      	g_list_reverse.
      	(stf_parse_fixed_line): Idem.
      	(stf_parse_general): Idem.
      
       	* src/item-cursor.c (item_cursor_selection_event): Fix horizontal
      	double-click filling and add extra bound check for vertical
      	double-click filling.
      3dd0345b
    • Almer S. Tigelaar's avatar
      Fix leakage. · 623fa04b
      Almer S. Tigelaar authored
      2001-07-16  Almer S. Tigelaar  <almer@gnome.org>
      
      	* stf-parse.c (stf_parse_general): Fix leakage.
      623fa04b
  6. 15 Jul, 2001 1 commit
    • Almer S. Tigelaar's avatar
      Honor lines to parse. · 90c07a3d
      Almer S. Tigelaar authored
      2001-07-15  Almer S. Tigelaar  <almer@gnome.org>
      
      	* stf.c (stf_read_workbook): Honor lines to parse.
      
      	* gui-clipboard.c (x_selection_to_cell_region): Idem.
      
      	* stf-parse.c (stf_parse_options_set_lines_to_parse): Don't
      	convert to index it's not an index.
      
      2001-07-15  Almer S. Tigelaar  <almer@gnome.org>
      
      	* dialog-stf.[ch] (stf_dialog): Add and set lines member on
      	dialogresult.
      
      	* dialog-stf-csv-page.c (stf_dialog_csv_page_prepare): Use
      	the importlines for the scrollbar adjustment.
      
      	* dialog-stf-fixed-page.c (stf_dialog_fixed_page_prepare): Idem.
      90c07a3d
  7. 09 Jul, 2001 2 commits
  8. 05 Jul, 2001 1 commit
    • Jody Goldberg's avatar
      Initial support for frozen panes. · 99073bd9
      Jody Goldberg authored
      2001-07-04  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet-merge.c (sheet_merge_add) : Use sheet_redraw_range.
      
      	* src/sheet-control.c (sc_set_panes) : new virtual.
      	(sc_set_sheet) : renamed from sc_invalidate_sheet.
      
      	* src/sheet-control-gui.c (scg_primary_pane) : new function. Be very
      	  careful when using this.  It should not be necessary in most cases.
      	(scg_get_wbcg) : convenience routine.
      	(scg_redraw_all) : frozen panes.
      	(scg_redraw_region) : renamed from scg_redraw_cell_region, and frozen
      	  pane support.
      	(scg_redraw_headers) : merge in the code from gnumeric-sheet.
      	(scg_update_cursor_pos) : pane support.
      	(scg_resize) : ditto.
      	(scg_set_zoom_factor) : ditto.  Broken. needs to resize the panes.
      	(scg_scrollbar_config) : adjust to panes.
      	(scg_make_edit_pos_visible) : use scg_make_cell_visible.
      	(scg_colrow_select) : reorg a bit.
      	(vertical_scroll_offset_changed) : adjust to panes.
      	(horizontal_scroll_offset_changed) : ditto.
      	(cb_table_destroy) : ditto.
      	(scg_init) : init the top here.
      	(bar_set_left_col) : from gnumeric-sheet. Still needs work for panes.
      	(bar_set_top_row) : ditto.
      	(gnumeric_sheet_set_left_col) : ditto.
      	(gnumeric_sheet_set_top_row) : ditto.
      	(scg_set_left_col) : TODO.
      	(scg_set_top_row) : ditto.
      	(gnumeric_sheet_set_top_left) : new function split from.
      	(gnumeric_sheet_make_cell_visible) : here.
      	(scg_make_cell_visible) : adjsut to panes and do the real work here.
      	(scg_make_cell_visible_virt : wrapper for use as virtual.
      	(gnumeric_pane_new) : new function.
      	(gnumeric_pane_delete) : ditto.
      	(scg_set_panes) : ditto.
      	(scg_construct) : move the table attachments around and move the
      	  canvas groups into the panes.
      	(sheet_control_gui_new) : beef this up.
      	(scg_unant) : adjust to panes.
      	(scg_ant) : ditto.
      	(scg_cursor_visible) : ditto.
      	(scg_cursor_bound) : ditto.
      	(scg_adjust_preferences) : ditto.
      	(scg_compute_visible_region) : ditto.
      	(scg_create_editor) : ditto.
      	(scg_stop_editing) : ditto.
      	(scg_take_focus) : ditto.
      	(scg_sliding_callback) : adjust top panes, but is still much too
      	  stupid.
      	(scg_start_sliding) : ditto.
      	(cb_slide_handler) : ditto.
      	(cb_control_point_event) : ditto.
      	(new_control_point) : ditto.
      	(set_item_x_y) : ditto.
      	(set_acetate_coords) : ditto.
      	(scg_object_calc_position) : ditto.
      	(scg_object_view_position) : ditto.
      	(scg_rangesel_changed) : ditto.
      	(scg_rangesel_start) : ditto.
      	(scg_rangesel_stop) : ditto.
      	(scg_rangesel_move) : ditto.
      	(scg_rangesel_extend) : ditto.
      
      	* src/item-grid.c (sheet_object_begin_creation) : Use the group
      	  associated with the gsheet, not the scg, and use GNUMERIC_IS_SHEET
      	  in preference to != NULL.
      
      	* src/item-bar.c : Store the gnumeric-sheet rather than the scg so
      	  that we can get to the Pane.
      
      	* src/embeddable-grid.c (grid_view_activate) : Use scg_take_focus.
      	(grid_view_new) : Use sheet_control_gui_new in place of sheet_new_scg.
      
      	* convert to E_MAKE_TYPE
      	* Use IS_SHEET in preference to sheet != NULL
      	* sheet_range_calc_spans signature change
      
      	* src/clipboard.c (clipboard_paste_region) : special handling when
      	  pasting into a selection that consists of a single merged cell.
      
      	* src/application.c (application_set_selected_sheet) : Use IS_SHEET.
      	(application_clipboard_copy) : ditto.
      	(application_clipboard_cut) : ditto.
      
      	* src/Makefile.am :
      	    command-context-corba -> workbook-control-corba
      
      	* src/sheet.c : convert to using IS_SHEET in place of sheet != NULL in
      	  several places.
      	(sheet_is_frozen) : new function.
      	(sheet_freeze_panes) : implement.
      	(sheet_new) : init frozen pane data.
      	(sheet_range_calc_spans) : pass a pointer rather than copy of the range.
      	  and use sheet_redraw_range.
      	(sheet_apply_style) : use sheet_redraw_range.
      	(cb_sheet_get_extent) : premature optimization is evil.
      	(sheet_redraw_region) : rename from sheet_redraw_cell_region.
      	(sheet_set_edit_pos) : use sheet_redraw_range.
      	(sheet_move_range) : ditto.
      	(sheet_init_sc) : new routine.
      	(sheet_attach_control) : rename and task from sheet_new_scg.
      	(sheet_redraw_region) : renamed from sheet_redraw_cell_region.
      
      	* src/item-cursor.c (item_cursor_update) : increase the spacing for
      	  the autohandle.
      
      	* src/GNOME_Gnumeric.xml :
      	  - Use Control*colon and Control*semicolon
      	  - desensitize the graph guru for now.
      	  - Add freeze/thaw
      
      	* src/item-bar.c (item_bar_unrealize) : no need to double unref the
      	  fonts.
      
      	* src/print-cell.c (print_merged_range) : This is not being drawn on
      	  the screen, no need for all the fancy calcs to only draw the visible
      	  bits.  We will just clip it.
      	* src/print-cell.c (print_cell) : Use the calulated width, not the col
      	  width for splitting.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) : Use the scg_
      	  versions of things in preference to the gnumeric_sheet_ versions.
      	(gnumeric_sheet_new) : Store the Pane that this is associated with.
      	(gnumeric_sheet_bar_set_top_row) : moved to sheet-control-gui.c
      	(gnumeric_sheet_set_top_row) : ditto.
      	(gnumeric_sheet_bar_set_left_col) : ditto.
      	(gnumeric_sheet_set_left_col) : ditto.
      	(gnumeric_sheet_make_cell_visible) : ditto.
      	(gsheet_compute_visible_region) : handle panes.
      99073bd9
  9. 04 Jun, 2001 1 commit
    • Almer S. Tigelaar's avatar
      Burn useless comments. (stf_parse_options_csv_set_separators): Change · 3b6bb3ea
      Almer S. Tigelaar authored
      2001-06-04  Almer S. Tigelaar  <almer@gnome.org>
      
      	* src/stf-parse.[ch] : Burn useless comments.
      	(stf_parse_options_csv_set_separators): Change interface.
      	(stf_parse_csv_is_separator): Adjust for interface change.
      	(stf_parse_options_new): Burn modified and old splitpositions.
      	(stf_parse_options_set_type): Constify.
      	(stf_parse_options_set_line_terminator): Idem.
      	(stf_parse_options_set_lines_to_parse): Idem.
      	(stf_parse_options_set_trim_spaces): Idem.
      	(stf_parse_options_csv_set_customfieldseparator): Burn.
      	(stf_parse_options_csv_set_stringindicator): Constify.
      	(stf_parse_options_csv_set_indicator_2x_is_single): Idem.
      	(stf_parse_options_csv_set_duplicates): Idem.
      	(stf_parse_options_fixed_splitpositions_add): Idem.
      	(stf_parse_csv_cell): Cosmetic changes and adjust for
      	change to stf_parse_csv_is_separator, plus use GList.
      	(stf_parse_fixed_cell): Cosmetic changes.
      	(stf_parse_fixed_line): Idem and use GList.
      	(stf_parse_general): Optimize loop and use GList's.
      	(stf_parse_get_rowcount): Cosmetic changes.
      	(stf_parse_get_colcount): Idem.
      	(stf_parse_get_longest_row_width): Idem and fix.
      	(stf_parse_get_colwidth): Idem and fix.
      	(stf_parse_convert_to_unix): Rewrite.
      	(stf_parse_is_valid_data): Idem and constify.
      	(stf_parse_options_fixed_autodiscover): Constify.
      	(stf_parse_sheet): Rewrite.
      	(stf_parse_region): Idem.
      
      	* src/gui-clipboard.c (x_selection_to_cell_region):
      	Constify return variable from stf_parse_is_valid_data.
      
      2001-06-04  Almer S. Tigelaar  <almer@gnome.org>
      
      	* dialog-stf-csv-page.c (csv_page_global_change): Cope for
      	changes to csv_set_separators and stf_parse_general.
      
      	* dialog-stf-format-page.c (format_page_update_preview): Idem.
      
      	* dialog-stf-fixed-page.c (fixed_page_update_preview): Idem.
      
      	* dialog-stf-preview.[ch] (stf_preview_render_row): Idem.
      	(stf_preview_format_recalc_colwidths): Idem.
      	(stf_preview_format_line): Idem.
      	(stf_preview_render): Idem.
      3b6bb3ea
  10. 03 Jun, 2001 3 commits
    • Almer S. Tigelaar's avatar
      Add support for escaped newlines and clean-up. · a1f8bb83
      Almer S. Tigelaar authored
      2001-06-03  Almer S. Tigelaar  <almer@gnome.org>
      
      	* src/stf.c
      	(stf_parse_csv_cell): Add support for escaped newlines and
      	clean-up.
      	(stf_parse_options_csv_set_customfieldseparator): Support
      	string separator.
      	(stf_parse_options_new): Initialize customfieldseparator.
      	(stf_parse_options_free): Free custom field separator.
      	(stf_parse_csv_is_separator): Handle new string customfield separator.
      	(stf_parse_csv_cell): Idem.
      	(stf_parse_get_colcount): Idem.
      	(stf_parse_get_colwidth): Idem.
      
      2001-06-03  Almer S. Tigelaar  <almer@gnome.org>
      
      	* dialog-stf.glade: Make length of customfield
      	separator infinite.
      
      	* dialog-stf-csv-page.c (csv_page_global_change):
      	Set string customseparator instead of char.
      a1f8bb83
    • Almer S. Tigelaar's avatar
      Fix. · bf4852dc
      Almer S. Tigelaar authored
      2001-06-03  Almer S. Tigelaar  <almer@gnome.org>
      
      	* src/stf-parse.c (stf_parse_get_longest_row_width): Fix.
      
      2001-06-03  Almer S. Tigelaar  <almer@gnome.org>
      
      	* dialog-stf.h: Define X overflow limit.
      
      	* dialog-stf-preview.c (stf_preview_render_row): Really
      	truncate strings if they are too long.
      
      	* dialog-stf-main-page.c (stf_dialog_main_page_init): Protect
      	against overly large text.
      bf4852dc
    • Almer S. Tigelaar's avatar
      Burn. (stf_cache_options_free): Burn. (stf_cache_options_set_data): Burn. · fc1912f7
      Almer S. Tigelaar authored
      2001-06-03  Almer S. Tigelaar  <almer@gnome.org>
      
      	* src/stf-parse.[ch] (stf_cache_options_new): Burn.
      	(stf_cache_options_free): Burn.
      	(stf_cache_options_set_data): Burn.
      	(stf_cache_options_set_range): Burn.
      	(stf_cache_options_invalidate): Burn.
      	(stf_parse_general_cached): Burn.
      	(stf_parse_options_before_modification): Burn.
      	(stf_parse_options_after_modification): Burn.
      	(stf_parse_options_set_type): Don't set modified.
      	(stf_parse_options_set_line_terminator): Idem.
      	(stf_parse_options_set_lines_to_parse): Idem.
      	(stf_parse_options_set_trim_spaces): Idem.
      	(stf_parse_options_csv_set_separators): Idem.
      	(stf_parse_options_csv_set_customfieldseparator): Idem.
      	(stf_parse_options_csv_set_stringindicator): Idem.
      	(stf_parse_options_csv_set_indicator_2x_is_single): Idem.
      	(stf_parse_options_csv_set_duplicates): Idem.
      	(stf_parse_options_valid): Remove modificationmode.
      	(stf_parse_options_new): Idem.
      	(trim_spaces_inplace): Make inline.
      	(stf_parse_csv_is_separator): Idem and move things around
      	a for some more speed.
      	(stf_parse_csv_cell): Make inline.
      	(stf_parse_fixed_cell): Idem.
      
      	* src/stf.c (stf_read_workbook): Set maximum number of
      	lines to parse to infinite.
      	(x_selection_to_cell_region): Idem.
      
      2001-06-03  Almer S. Tigelaar  <almer@gnome.org>
      
      	* dialog-stf.c (stf_dialog_druid_page_next): Remove cacheoptions.
      
      	* dialog-stf-preview.c (stf_preview_merge_with_hash): Remove.
      	(stf_preview_hash_item_remove): Idem.
      	(stf_preview_free_row): Idem.
      	(stf_preview_free): Remove hashtable.
      	(stf_preview_new): Idem.
      	(stf_preview_render): Free the list that is passed.
      	(stf_preview_render_row): Truncate strings if they are too long.
      
      	* dialog-stf-csv-page.c (csv_page_global_change): Use
      	stf_parse_general.
      	(stf_dialog_csv_page_prepare): Remove cacheoptions.
      	(stf_dialog_csv_page_init): Idem.
      	(stf_dialog_csv_page_cleanup): Idem.
      
      	* dialog-stf-fixed-page.c (fixed_page_update_preview): Use
      	stf_parse_general.
      	(stf_dialog_fixed_page_prepare): Remove cacheoptions.
      	(stf_dialog_fixed_page_cleanup): Idem.
      	(stf_dialog_fixed_page_init): Idem.
      
      	* dialog-stf-format-page.c (format_page_update_preview): Use
      	stf_parse_general.
      	(format_page_scroll_value_changed ): Don't use cacheoptions.
      	(format_page_format_changed): Idem.
      	(stf_dialog_format_page_prepare): Idem.
      	(stf_dialog_format_page_cleanup): Remove cacheoptions.
      	(stf_dialog_format_page_init): Idem.
      fc1912f7
  11. 04 May, 2001 1 commit
    • Jody Goldberg's avatar
      s/clipboard_release/cellregion_free/ s/range_copy/range_dup/ · 32bde6ee
      Jody Goldberg authored
      
      2001-05-04  Jody Goldberg <jgoldberg@home.com>
      
      	s/clipboard_release/cellregion_free/
      	s/range_copy/range_dup/
      	s/cell_region_render_ascii/cellregion_to_string/
      	s/clipboard_release/cellregion_free/
      
      	* src/commands.c (cmd_autofill) : Use sheet_range_contains_region.
      	(cmd_autofill_redo) : no need to test here.
      	(cmd_paste_cut) : test destination for validity and ensure that it
      	  does not slice up any merged regions or arrays.  Make the descriptor
      	  an argument so that other commands can use this one.
      	(cmd_ins_del_colrow_redo) : use colrow_max.
      	(cmd_area_set_text_redo) : use sheet_ranges_split_region.
      	(cmd_colrow_outline_change) : suppress warning.
      
      	* src/gui-clipboard.c (x_selection_to_cell_region) : simplify by using
      	  some of the convenience routines.
      
      	* src/gutils.c (gnumeric_sys_data_dir) : warning suppression.
      	(gnumeric_sys_lib_dir) : ditto.
      
      	* src/item-bar.c (item_bar_draw) : add missing warning.
      
      	* src/item-cursor.c (item_cursor_drag_event) : Don't assume the
      	  release came from the button that started the grab (think about
      	  multiple simultaneous button downs.
      	(item_cursor_selection_event) : ditto.
      	(item_cursor_do_drop) : changes to selection_first_range.
      
      	* src/parse-util.c (col_name_internal) : new routine split from
      	  col_name with better buffer handling.
      	(col_name) : used here.
      	(cols_name) : and in this new function.
      
      	* src/print.c (sheet_print_selection) : changes to
      	  selection_first_range.
      
      	* src/print-info.c (print_info_new) : default even_if_only_styles to
      	  false.  This is probably what most people want.
      
      	* src/ranges.c (range_translate) : don't invert.
      	(range_height) : new util.  could probably be #define.
      	(range_width) : new util.  could probably be #define.
      	(range_is_infinite) : use range_is_full.
      	(range_is_full) : new util.
      
      	* src/search.c (calculate_replacement) : warning suppression.
      
      	* src/selection.c (sheet_selection_cut) : Use
      	  sheet_range_splits_region and selection_first_range.
      	(sheet_selection_copy) : Use selection_first_range and remove TODO
      	  about supporting not paste by content for partial arrays.
      	(selection_first_range) : Add optional error reporting if there are
      	  multiple selection ranges.
      
      	* src/format.c (format_get_currency) : diddle the logic to get
      	  undefined to work the way people expect for locale C.
      
      	* src/sheet-merge.c (sheet_merge_relocate) : remove some dead code.
      	(sheet_merge_add) : changes to sheet_range_splits_array.
      
      	* src/sheet-object-widget.c (sheet_widget_checkbox_construct) :
      	  changes to selection_first_range.
      
      	* src/sheet.c (sheet_delete_{cols,rows}) : changes to
      	  sheet_range_splits_array.
      	(sheet_insert_{cols,rows}) : use sheet_range_splits_array.
      	(avoid_dividing_array_vertical) : delete.
      	(avoid_dividing_array_horizontal) : delete.
      	(sheet_is_pristine) : constness.
      	(sheet_mark_clean) : delete.
      	(sheet_clear_region) : changes to sheet_range_splits_array.
      	(sheet_ranges_split_region) : renamed from selection_check_for_array.
      	(sheet_range_splits_region) : new routine to check arrays and merged
      	  regions.
      	(sheet_range_splits_array) : improve and add hooks to be used for
      	  overlapping checks.
      	(cb_check_array_vertical) : report the array being split.
      	(cb_check_array_horizontal) : report the array being split.
      
      	* src/stf-parse.c (stf_parse_region) : use cellregion_new.
      	(stf_parse_is_valid_data) : simplify.
      
      	* src/value-sheet.c (value_area_get_width) : warning suppression.
      	(value_area_get_height) : warning suppression.
      	(value_area_fetch_x_y : signedness.
      	(value_area_get_x_y) : signedness.
      
      	* src/value.c (value_array_resize) : signedness.
      	(value_array_set) : signedness.
      
      	* src/workbook-control-gui.c (wbcg_error_splits_array) : signature
      	  change.
      	(cb_insert_rows) : use selection_first_range
      	(cb_insert_cols) : ditto.
      	(sort_cmd) : ditto.
      	(cb_workbook_debug_info) : clean out some deadwood.
      
      	* src/workbook-edit.c (auto_complete_matches) : warning suppression.
      
      	* src/workbook.c (workbook_sheet_detach) : warning suppression.
      	(g_ptr_array_insert) : warning suppression, moved to gutils.
      
      	* src/xml-io.c (xml_write_attributes) : warning suppression.
      	(xml_read_selection_clipboard) : use cellregion_new and tidyup.
      
      	* src/clipboard.c (paste_link) : Only make the link sheet specific if
      	  we need to.
      	(clipboard_paste_region) : constness, support being able to paste
      	  content only as link or value.
      	(clipboard_prepend_cell) : check for arrays.
      	(clipboard_copy_range) : use cellregion_new
      	(cellregion_new) : new function
      	(cellregion_free) : renamed from clipboard_release.
      	(cellregion_to_string) : moved here from render-ascii.
      
      	src/cmd-edit.c (cmd_paste) : more protection. Merge in
      	  application_paste.
      	(cmd_paste_to_selection) : handle changes to selection_is_simple and
      	  use selection_first_range
      	(cmd_shift_rows) : changes to cmd_paste_cut.
      	(cmd_shift_cols) : ditto.
      
      	* src/command-context-priv.h : change signature of splits array.
      	* src/command-context.h : ditto.
      	* src/command-context.c (gnumeric_error_splits_array) : ditto.
      
      	* src/application.c (application_clipboard_clear) :
      	(application_set_selected_sheet) : remove #warning, it is not portable.
      
      	* src/commands.c
      	* src/Makefile.am : remove render-ascii.[ch]  Move their content into
      	  clipboard.
      
      2001-05-01  Jody Goldberg <jgoldberg@home.com>
      
      	* src/clipboard.c (clipboard_prepend_cell) : remove ugly
      	  implementation.
      
      	* src/workbook-edit.c (auto_complete_matches) : remove warning.
      
      	* src/xml-io.c (xml_write_attributes) : remove warning.
      32bde6ee
  12. 26 Apr, 2001 2 commits
  13. 25 Apr, 2001 1 commit
    • Almer S. Tigelaar's avatar
      Fix ugly discovering error that can cause a non-existant column to be · 950b7766
      Almer S. Tigelaar authored
      2001-04-25  Almer S. Tigelaar  <almer@gnome.org>
      
      	* src/stf-parse.c (stf_parse_options_fixed_autodiscover):
      	Fix ugly discovering error that can cause a non-existant column
      	to be discovered if there are leading spaces and avoid skipping
      	over columns that should be checked for emptyness. Fixes Bug #53499
      950b7766
  14. 02 Feb, 2001 1 commit
    • Jody Goldberg's avatar
      Init CellRegion::merged. Ditto. Ditto. · 96291ef4
      Jody Goldberg authored
      
      2001-02-02  Jody Goldberg <jgoldberg@home.com>
      
      	* src/gui-clipboard.c (x_selection_to_cell_region) : Init
      	  CellRegion::merged.
      	* src/stf-parse.c (stf_parse_region) : Ditto.
      	* src/xml-io.c (xml_read_selection_clipboard) : Ditto.
      96291ef4
  15. 21 Nov, 2000 1 commit
    • Morten Welinder's avatar
      Don't overrun buffer. · e1943f59
      Morten Welinder authored
      2000-11-21  Morten Welinder  <terra@diku.dk>
      
      	* src/stf-parse.c (stf_parse_get_colwidth): Don't overrun buffer.
      e1943f59
  16. 15 Nov, 2000 1 commit
    • Morten Welinder's avatar
      Remove trailing white-space from files that have it. · 5570aef3
      Morten Welinder authored
      (The following command was done in src/ and plugins/.  Note, that the
      grep has a space and a tab.)
      
      for i in `find . -name '*.[ch]' -print`; do if grep '[         ]$' $i >/dev/null; then echo $i; perl -pi -e 's/[ \t]+$//' $i; fi; done
      5570aef3
  17. 23 Sep, 2000 1 commit
    • Almer S. Tigelaar's avatar
      return invalid character or NULL if the data is valid. · 8aad5f3a
      Almer S. Tigelaar authored
      2000-09-23  Almer S. Tigelaar  <almer1@dds.nl>
      
      	* src/stf-parse.c, src/stf-parse.h:
      	(stf_parse_is_valid_data): return invalid character
      	or NULL if the data is valid.
      
      	* src/clipboard.c:
      	(stf_read_workbook): Adjust to cope with the new
      	stf_parse_is_valid_data.
      
      	* src/stf.c:
      	(x_selection_to_cell_region): Idem.
      8aad5f3a
  18. 20 Sep, 2000 1 commit
  19. 10 Sep, 2000 1 commit
    • Almer S. Tigelaar's avatar
      Limit the number of lines displayed in the preview. This is a temporary · d473b0ae
      Almer S. Tigelaar authored
      2000-09-10  Almer S. Tigelaar  <almer1@dds.nl>
      
      	* src/dialogs/dialog-stf.h: Limit the number of lines
      	displayed in the preview. This is a temporary solution for
      	bug #23426.
      
      	* src/dialogs/dialog-stf-csv-page.c:
      	(stf_dialog_csv_page_prepare): Ditto.
      
      	* src/dialogs/dialog-stf-fixed-page.c:
      	(stf_dialog_fixed_page_prepare): Ditto.
      
      	* src/dialogs/dialog-stf-format-page.c:
      	(stf_dialog_format_page_prepare): Ditto.
      	(format_page_format_changed): Kill memory
      	leak.
      
      	* src/stf-parse.c:
      	(stf_parse_csv_line): Change to still return
      	something if the maximum number of columns is
      	exceeded.
      	(stf_parse_fixed_line): Ditto.
      
      	* src/dialogs/dialog-stf-preview.c:
      	(stf_preview_render): Adjust to only render SHEET_MAX_COLS
      	columns.
      	(stf_preview_get_table_pixel_width): Ditto.
      d473b0ae
  20. 10 Jul, 2000 1 commit
    • Jody Goldberg's avatar
      Bug 16860 A few portability problems. · 7b8afaf0
      Jody Goldberg authored
      Bug 16860
      A few portability problems.
      
      2000-07-09  Jody Goldberg <jgoldberg@home.com>
      
      	* src/history.c (history_menu_item_create) : Fix.
      
      	* src/stf-parse.c (stf_parse_options_before_modification) : Simplify
      	  for irix compiler.
      
      	* src/print-info.c (print_info_new) : cellrange is a ValueRange.
      	(save_range) : Ditto.
      	* src/dialogs/dialog-printer-setup.c (do_setup_page_info) : Ditto.
      	(do_fetch_page_info) : Ditto.
      7b8afaf0
  21. 06 Jul, 2000 1 commit
  22. 05 Jul, 2000 2 commits
    • Morten Welinder's avatar
      const issues. · ff44e061
      Morten Welinder authored
      2000-07-05  Morten Welinder  <terra@diku.dk>
      
      	* src/clipboard.c (x_selection_to_cell_region): Copy data and zero
       	terminate it.
      
      	* src/stf-parse.c (stf_parse_fixed_line): Kill unneeded cast.
      	(stf_parse_convert_to_unix): Unconstify.  Don't bother keeping
       	track of len.  Handle form-feeds better.
      ff44e061
    • Almer. S. Tigelaar's avatar
      When a column has right and left aligned text split and has 2 or more · 01b8664a
      Almer. S. Tigelaar authored
      2000-07-05  Almer. S. Tigelaar.  <almer1@dds.nl>
      
      	* src/stf-parse.c:
      	(stf_parse_options_fixed_autodiscover): When a column has right
      	and left aligned text split and has 2 or more spaces in the
      	middle split the column in two. (Suggested by Morten)
      01b8664a
  23. 04 Jul, 2000 1 commit
    • Almer. S. Tigelaar's avatar
      Fix column mangling in fixed width import. · f1ab3f8d
      Almer. S. Tigelaar authored
      2000-07-04  Almer. S. Tigelaar.  <almer1@dds.nl>
      
      	* src/dialogs/dialog-stf.c, src/dialogs/dialog-stf-fixed-page.c :
      	Fix column mangling in fixed width import.
      
      	* src/dialogs/dialog-stf-format-page.c :
      	Fix USB (==Ugly Selection Bug).
      
      	* src/stf-parse.c, src/stf-parse.h :
      	(stf_parse_options_fixed_autodiscover) : New!
      	Column autodiscovery for fixed width.
      
      	* src/dialogs/dialog-stf.glade :
      	Add clear and autodiscovery buttons
      
      	* src/dialogs/dialog-stf-fixed-page.c :
      	(fixed_page_autodiscover) : Autodiscovery routine.
      	(fixed_page_clear_clicked) : Clear click handler
      	(fixed_page_auto_clicked) : Autodiscovery click handler
      f1ab3f8d
  24. 03 Jul, 2000 1 commit
    • Morten Welinder's avatar
      Don't add one to the number of lines if the last line is empty. · 332034ff
      Morten Welinder authored
      2000-07-03  Morten Welinder  <terra@diku.dk>
      
      	* src/stf-parse.c (stf_parse_get_rowcount): Don't add one to the
       	number of lines if the last line is empty.
      
      	* src/sheet.c (sheet_cell_set_text): Plug leak.
      
      	* src/workbook-format-toolbar.c
       	(do_sheet_selection_apply_number_format): Avoid double translation
       	of format.
      
      	* src/mstyle.c (mstyle_set_format_text): Renamed from
       	mstyle_set_format.
      	(mstyle_set_format): New function taking a StyleFormat *.
      332034ff
  25. 14 Jun, 2000 2 commits
    • Morten Welinder's avatar
      Partially fix space stripping. Fields must still be selected · accb8d3d
      Morten Welinder authored
      right-to-left, :-(
      
      
      
      
      2000-06-13  Morten Welinder  <terra@diku.dk>
      
      	* src/stf-parse.c (trim_spaces_inplace): New function.
      	(stf_parse_fixed_cell): Don't trim spaces here.
      	(stf_parse_fixed_line): Trim here.
      	(stf_parse_csv_cell): Don't trim spaces here.
      	(stf_parse_csv_line): Trim here.
      
      
      2000-06-13  Morten Welinder  <terra@diku.dk>
      
      	* dialog-stf-format-page.c (format_page_format_changed): Plug
       	leak.
      accb8d3d
    • Jody Goldberg's avatar
      Patch a leak. fix a typo. · 634456bb
      Jody Goldberg authored
      Patch a leak.
      fix a typo.
      634456bb
  26. 27 May, 2000 1 commit
    • Almer. S. Tigelaar's avatar
      New function. (stf_parse_csv_cell): Modified so it can trim spaces in · c20793a2
      Almer. S. Tigelaar authored
      2000-05-27  Almer. S. Tigelaar.  <almer1@dds.nl>
      
      	* src/dialogs/stf-parse.c:
      	(stf_parse_options_set_trim_spaces): New function.
      	(stf_parse_csv_cell): Modified so it can trim spaces in
      	several ways
      	(stf_parse_fixed_cell): Ditto.
      	(stf_parse_get_longest_row_width) : Fixed small bug which
      	caused incorrect width to be returned.
      
      	* src/dialogs/dialog-stf.glade:
      	Added trim spaces option and did some general polishing.
      
      	* src/dialogs/dialog-stf.h:
      	Added new member to DruidPageData_t which indicates weather
      	the user wants to trim spaces and in which way.
      
      	* src/dialogs/dialog-stf-main-page.c:
      	(stf_dialog_main_page_init): Modified so it loads the trim optionmenu.
      	(main_page_trim_menu_deactivate): New.
      
      	* src/dialogs/dialog-stf-csv-page.c:
      	(stf_dialog_csv_page_prepare): Now sets the trim member of the parse
      	options struct.
      
      	* src/dialogs/dialog-stf-fixed-page.c:
      	(stf_dialog_fixed_page_prepare): Now sets the trim member of the
      	parse options struct.
      	(stf_dialog_fixed_page_prepare): Did not honor the from/to line
      	settings.
      	(fixed_page_remove_clicked): Added gnumeric_clist_moveto to make
      	selection visible.
      	(fixed_page_add_clicked): Ditto.
      
      	* src/dialogs/dialog-stf-format-page.c:
      	(format_page_canvas_button_press_event): Modified to use
      	gnumeric_clist_moveto
      	(format_page_collist_select_row): Ditto.
      	(format_page_format_changed): Ditto.
      	(stf_dialog_format_page_prepare): Ditto.
      
      	* src/gnumeric-util.c, src/gnumeric-util.h:
      	(gnumeric_option_menu_get_selected_index): New function, Returns
      	the selected index of a GtkOptionMenu. (Originally from
      	dialog-stf-export-format-page.c)
      
      	* src/dialogs/dialog-stf-export-format-page.c:
      	(stf_export_dialog_option_menu_index): Removed.
      	(sheet_page_separator_menu_deactivate): Modified to use the new
      	gnumeric_option_menu_get_selected_index.
      	(stf_export_dialog_format_page_result): Ditto.
      
      	* doc/stf-parser.txt:
      	Update documentation.
      c20793a2
  27. 08 May, 2000 1 commit
  28. 06 May, 2000 1 commit
    • Almer. S. Tigelaar's avatar
      Add the form feed character (\f) as valid text character. · 9f058999
      Almer. S. Tigelaar authored
      2000-05-06  Almer. S. Tigelaar.  <almer1@dds.nl>
      
      	* src/stf-parse.c (stf_parse_is_valid_data) : Add
      	the form feed character (\f) as valid text character.
      	(stf_parse_convert_to_unix) : In addition to CRLF and CR,
      	remove form feeds (\f) from data.
      
      	* src/stf.c (stf_read_workbook) : Add a workbook_recalc just
      	to be sure.
      9f058999
  29. 20 Apr, 2000 1 commit
    • Jody Goldberg's avatar
      Reorg cell contents and assignment. · bedb925b
      Jody Goldberg authored
      Fixs lots of usability details.
      
      2000-04-20  Jody Goldberg <jgoldberg@home.com>
      
      	* src/dialogs/dialog-cell-format.c : Use the edit_pos as the example
      	  not the top left corner.
      
      	* src/functions/fn-stat.c (gnumeric_ftest) : Use eval_pos_cellref
      	  to help localize the strangeness.
      	(gnumeric_ttest) : Ditto.
      
      	* src/xml-io.c (xml_write_cell_and_position) : If this is an array
      	  expression and we are the top left then add attributes to indicate
      	  size of array.  Ignore the rest of the array.
      	(xml_not_used_old_array_spec) : New routinr to handle the old array format.
      	(xml_cell_set_array_expr) : store an array.
      	(xml_read_cell) : Handle the old and the new array formats.
      
      	* src/workbook.c (workbook_close_if_user_permits) : Accept input
      	  first.
      	(wb_edit_key_pressed) : Handle array formulas here.
      	(workbook_detach_sheet) : Do not recalc all if we are exiting.
      	(workbook_start_editing_at_cursor) : When we start editing an
      	  array formula display just the formula not all the extra {}()[][] crap.
      
      	* src/sheet.c (SheetPrivate) : Add a recompute_spans flag.
      	(sheet_calc_spans) : New routine.
      	(sheet_cell_calc_span) : New routine.
      	(sheet_range_calc_spans) : Renamed and extended from
      	  sheet_cells_update.
      	(sheet_update) : Use sheet_calc_spans when necessary.
      	  Update the location region when the edit_pos changes.
      	(cb_recalc_spans_in_col) : Renamed from cb_collect_cells_in_col.
      	  Recalcs spans directly, no need to collect first.
      	(cb_set_cell_content) : New routine to set expr, or expr_and_value.
      	(sheet_range_set_text) : Use cb_set_cell_content, and remember
      	  chosen format with the cell rather than overriding the assigned
      	  format.
      	(sheet_cell_set_text) : Renamed from sheet_set_text.  Be more specific
      	  about how spans, rendering and the rest are handled.
      	(sheet_cell_set_expr) : New routine.
      	(sheet_cell_set_value) : Ditto.
      	(sheet_load_cell_val) : When displaying an array formula add {%s}()[][].
      	(sheet_redraw_cell_region) : Honour spans when redrawing.
      	(sheet_redraw_partial_row) : New routine.
      	(sheet_redraw_cell) : Ditto.
      	(sheet_is_cell_array) : Use cell_is_array.
      	(sheet_range_splits_array) : Renamed from sheet_check_for_partial_array.
      	(sheet_cell_add_to_hash) :  Do not touch spans at this point.
      	(sheet_cell_insert) : Rename from sheet_cell_add made recalc span
      	  optional.
      	(sheet_cell_new) : New routine that does not touch spans.
      	(sheet_cell_remove) : Made redraw optional.
      	(cb_clear_cell_comments) : Remove the cell if there is no comment.
      	(sheet_clear_region) : Remove the cell if there are no comments or
      	  contents.  Flag an update of the status region.
      
      	* src/sheet-view.c (cb_colrow_resize) : New function.
      	(sheet_view_col_size_changed) : Resize all rows, irrespective of
      	(sheet_view_row_size_changed) : existing cells.
      	(sheet_view_redraw_cell_region) : This no longer honours spans.
      
      	* src/sheet-style.c (sheet_style_attach) : Removed call to redraw.
      	sheet_cells_update : rename to sheet_range_calc_spans and move to
      	  sheet.c.
      
      	* src/sheet-autofill.c (autofill_cell) : Use sheet_cell_set_value
      	  rather than set_text.
      
      	* src/selection.c (sheet_selection_changed_hook) : Delete.
      	(sheet_selection_extend_to) : Update the status region to display the
      	  new size.
      	(sheet_selection_cut) : Use sheet_range_splits_array.
      	(selection_check_for_array) : New routine.
      
      	* src/parser.y : Remove icky array formula parsing that conflicted
      	  with array entries.
      
      	* src/number-match.c (format_match) : Return a Value * rather than a
      	  double.
      
      	* src/mstyle.c (mstyle_set_font_size) : Do not allow font sizes < 1.
      
      	* src/main.c (gnumeric_main) : Do NOT create an empty workbook
      	  then delete it if things are successfully loaded.  This causes
      	  a global recalc.  Instead add a flag to disable exit when the
      	  number of workbooks go to zero.  Then only enable the flag AFTER
      	  we have attempted to load the initial workbooks.
      
      	* src/item-grid.c (item_grid_event) : Update the status_region when
      	  button-1 is release.  It should display the edit_pos.
      
      	* src/gutils.c : Move cell_name, col_name, col_from_name,
      	  parse_cell_name, parse_cell_name_or_range and parse_cell_name_list,
      	  to parse-util.c.
      
      	* src/gnumeric.h  : Add RenderedValue.
      
      	* src/gnumeric-util.c (gnumeric_char_start_expr_p) : Move
      	  to parse-util.c
      
      	* src/file.c (workbook_read) : Remove freese thaw usage.
      	  Move call to update AFTER mark clean.
      
      	* src/expr.c (eval_pos_init) : Take a cellpos.
      	(parse_pos_evalpos) : New routine.
      	(eval_pos_cellref) : There is some questionable code scattered in the
      	  functions.  This routing localizes the odd bits for correction.
      
      	* src/eval.c (cell_eval_content) : Use sheet_redraw_cell,
      	  and rendered_value_calc_size.
      	(cell_get_dependencies) : Improve constness.
      
      	* src/corba-sheet.c : Remove the freeze thaw operations.
      	(Sheet_cell_set_formula) : Deleted.
      	(Sheet_range_set_formula) : Delete.
      
      	* src/commands.c : Adjust so that registration of command auto
      	  calls redo.  Add misc checks for splitting arrays.
      
      	* src/clipboard.h : Move the CellCopy types here from cell.h
      
      	* src/clipboard.c (paste_cell) : Use cell_has_expr.
      	  Don't insert the new cell till after its contents are assigned.
      
      	* src/cellspan.c (cell_register_span) : Improve constness.
      	(cell_unregister_span) : Ditto.
      	(row_cell_get_displayed_at) : Delete.
      	(cell_calc_span) : Moved here from cell.c
      
      	* src/dialogs/dialog-stf.glade : Adjust the header background colour
      	  to match the purdy new icon.  Add the icon.
      
      	* src/cell-draw.c : Use the rendered_value routines.
      	  Improve constness.
      
      	* src/analysis-tools.c (set_cell) : Use sheet_cell_fetch.
      
      	*.*
      	    cell_set_* -> sheet_cell_set_
      	    cell_set_*_simple -> cell_set_
      	    Cell::{row,col} -> Cell::{row,col}_info
      	    cell_get_text -> cell_get_entered_text
      	    cell_get_content -> cell_get_entered_text
      	    cell_name -> cell_coord_name
      	    cell_get_formatted_val -> cell_get_rendered_text
      	    cell_get_content -> cell_get_entered_text
      
      	* src/cell.c :
      	(cell_dirty) : Renamed from cell_modified.  Use
      	  sheet_set_dirty.
      	(cell_formula_changed) : Make the queuing of the recalc optional.
      	(cell_cleanout) : Handle union of expression and entered_text,
      	  and remove the rendered value.
      	(cell_copy) : Ditto.
      	(cell_destroy) : handle cell_modified -> cell_dirty.
      	(cell_set_text) : Use parse_text_value_or_expr and store the prefered
      	  format.
      	(cell_set_text_and_value) : New routine.
      	(cell_assign_value) : New routine.
      	(cell_set_value) : Support formats.
      	(cell_set_expr_and_value) : New routine.
      	(cell_set_expr_internal) : Split from cell_set_expr.
      	(cell_set_expr) : Divide to allow for not queuing a recalc.
      	(cell_set_array_formula) : Use cell_set_expr_internal.
      	(cell_is_array) : New utility.
      	(cell_is_partial_array) : New utility.
      	(cell_has_expr) : New utility.
      	(cell_render_value) : Use rendered_value_*.
      	Move all comment routines into cell-comment.[ch].
      
      	* idl/Gnumeric.idl : Remove cell_set_formula, and range_set_formula.
      	  These were identical to set_text.  Made Workbook embeddable.
      bedb925b
  30. 08 Apr, 2000 1 commit
    • Almer. S. Tigelaar's avatar
      Result of gtk_editable_get_chars was not freed. (2x) · 41906667
      Almer. S. Tigelaar authored
      2000-04-08  Almer. S. Tigelaar.  <almer1@dds.nl>
      
      	* src/dialogs/dialog-stf-csv-page.c
      	(csv_page_global_change) : Result of gtk_editable_get_chars was not
      	freed. (2x)
      
      	* src/stf-parse.c
      	(stf_parse_region) : Only the last item of the GSList's would be
      	freed
      	(stf_parse_sheet) : ditto
      41906667
  31. 06 Apr, 2000 1 commit
  32. 02 Apr, 2000 1 commit
    • Jody Goldberg's avatar
      Add description of double quote handling. Init indicator_2x_is_single and · 527ca0cf
      Jody Goldberg authored
      
      2000-04-02  Jody Goldberg <jgoldberg@home.com>
      
      	* doc/stf-parser.txt : Add description of double quote handling.
              * src/stf-parse.c (stf_parse_options_new) : Init
      	  indicator_2x_is_single and duplicates.
      	(stf_parse_options_csv_set_indicator_2x_is_single) : New function.
      	(stf_parse_csv_cell) : Add logic to optionaly treat double quotes as a
      	  single escaped quote.
      	* src/dialogs/dialog-stf-csv-page.c : Add the double quote checkbox.
      	* src/dialogs/dialog-stf.glade : Ditto.
      527ca0cf