1. 10 Dec, 2001 1 commit
    • Jody Goldberg's avatar
      burn ancient kruft and use the newly exposed format engine. · 22ad1db5
      Jody Goldberg authored
      2001-12-10  Jody Goldberg <jody@gnome.org>
      	* fn-string.c (gnumeric_fixed) : burn ancient kruft and use the newly
      	  exposed format engine.
      2001-12-10  Jody Goldberg <jody@gnome.org>
      	* src/value.c (value_new_string_str) : absorb the ref.
      	(value_duplicate) : manually add a ref here.
      	* src/format.c (render_number) : make public.
      	(do_render_number) : remove pointless args.
      	(format_number) : localize more of the scientific handling.
  2. 14 Sep, 2001 1 commit
    • Jody Goldberg's avatar
      if we are displaying the parse fmt because the assigned fmt is General · 1dbce43d
      Jody Goldberg authored
      2001-09-14  Jody Goldberg <jgoldberg@home.com>
      	* dialog-cell-format.c (fmt_dialog_init_format_page) : if we are
      	  displaying the parse fmt because the assigned fmt is General
      	  then select the parse fmt in the dialog.
      2001-09-14  Jody Goldberg <jgoldberg@home.com>
      	* ms-chart.c (excel_chart_series_write_xml) : Use the gal routines for
      	  symetry with the guppi implementation.
      2001-09-14  Jody Goldberg <jgoldberg@home.com>
      	* src/style-color.c (style_color_new_name) : new utility.
      	* src/gnumeric-graph.c : cleanup the debug info.
      	(gnm_graph_get_spec) : make public and add some protection.
      	* src/number-match.c : remove format_parse_t and merge it with
      	(format_match_release) : new routine split from format_match_finish.
      	(format_match_finish) : just unref the StyleFont.
      	(format_match_create) : tweaking the calling convention and rename
      	(format_match_init) : manage the format_match_list here.
      	(format_match) : Match against the currently assigned format first
      	* src/format.c : clean the includes.
      	Make _StyleFormat public for sharing with number-match.c
      	(format_compile) : call format_match_create.
      	(format_destroy) : call format_match_release.
      	(format_color_init) : use style_color_new_name.
      	(style_format_new_XL) : init the new regexp elements to NULL.
      	* src/bonobo-io.c (gnumeric_bonobo_io_init) : name this better.
      	* src/sheet-control-gui.c (scg_object_update_bbox) : add some
  3. 24 Feb, 2001 1 commit
    • Jody Goldberg's avatar
      reorder to handle unmerging directly. (cmd_merge_cells_undo) : ditto. · ab441bef
      Jody Goldberg authored
      2001-02-23  Jody Goldberg <jgoldberg@home.com>
       	* src/commands.c (cmd_merge_cells_redo) : reorder to handle unmerging
       	(cmd_merge_cells_undo) : ditto.
       	(CmdMergeCells) : no need to inherit from CmdUnmergeCells.
       	(cmd_unmerge_cells_redo) : merge the 'internal' versions.
       	(cmd_unmerge_cells_undo) : merge the 'internal' versions.
      2001-02-22  Jody Goldberg <jgoldberg@home.com>
      	* src/style-border.c (style_border_vmargins) : remove unnecessary
      	  reference to next_sr.  sr.bottom == next_sr.top
      	  For normal borders horizontal always dominates vertical.
      	(style_border_hmargins) : Only cut corners for doubles if the corner
      	  is a double.
      	* src/sheet.c (sheet_cursor_set_full) : new function.
      	* src/selection.c (sheet_selection_set_internal) : Use it here.
      	  The trick is that when extending a selection to include merged cells
      	  it is possible that the edit cell is neither the base nor the move
      	  col/row.  When you then shrink the selection to the pre-extended
      	  state, without the merged region, you have lost track of the corner
      	  and can easily loose the edit_position.
      	* src/workbook-format-toolbar.c (toggled_from_toolbar) : delete this
      	  ugliness.  We don't need it anymore.
      2001-02-20  Jody Goldberg <jgoldberg@home.com>
      	* src/workbook-control-gui.c (wbcg_ui_update_begin) : new utility
      	(wbcg_ui_update_end) : new utility
      	* src/workbook-format-toolbar.c (workbook_feedback_set) : Use them
      	(workbook_format_halign_feedback_set) : update center-across-selection
      	  in the bonobo case.
      	(do_modify_format) : rewrite to use the format from the edit cell and
      	  to support undo.
      	* src/format.c (format_toggle_thousands) : delete.
      2001-02-23  Jody Goldberg <jgoldberg@home.com>
      	* configure.in : post release version bump to 0.64.
  4. 15 Dec, 2000 1 commit
    • Jody Goldberg's avatar
      Move the span handling here. from here. · 17fb06d4
      Jody Goldberg authored
      2000-12-14  Jody Goldberg <jgoldberg@home.com>
      	* src/item-grid.c (item_grid_draw) : Move the span handling here.
      	* src/cell-draw.c (cell_draw) : from here.
      	* src/print-cell.c (print_cell_range) : Move the span handling here.
      	(print_cell) : rather than here.
      	* src/sheet-control-gui.c (scg_get_distance) : merge
      	  sheet_{row,col}_distance_get_pixels and make the result sheet
      	  control specific.
      2000-12-14  Jody Goldberg <jgoldberg@home.com>
      	* src/cell.c (cell_convert_expr_to_value) : rename from cell_make_value.
      	* src/format.c (format_number) : adjust signature to take the
      	  colwidth in preparation for supporting
      	(format_value) : pass in the width.
      2000-12-14  Jody Goldberg <jgoldberg@home.com>
      	* src/formats.c (currency_date_format_init) : correctly place currency
      	  before or after the value, and optionally include a space.
      	* src/format.c (format_get_currency) : include info on currency
      2000-12-14  Jody Goldberg <jgoldberg@home.com>
      	* src/workbook.c (workbook_sheet_rename) : Handle renames that only
      	  change case more smoothly.
  5. 10 Dec, 2000 1 commit
    • Jody Goldberg's avatar
      comment out the warning. These the life cycles of names are too fluid to · e605d42e
      Jody Goldberg authored
      2000-12-10  Jody Goldberg <jgoldberg@home.com>
      	* src/expr-name.c (expr_name_invalidate_refs_sheet) : comment out the
      	  warning.  These the life cycles of names are too fluid to scare
      	  users yet.
      	(expr_name_invalidate_refs_wb) : Ditto.
      2000-12-10  Jody Goldberg <jgoldberg@home.com>
      	* src/cell.c (cell_set_text) : send the current format to the
      	  number matcher..
      	* src/sheet.c (sheet_cell_set_text) : Ditto.
      	* src/parse-util.c (parse_text_value_or_expr) : send the curent
      	  format to the number matcher.
      	* src/number-match.c (format_match) : take the current format as a
      	  parameter.  Begin using it to handle cells formated as text.
      	* src/format.c (style_format_is_text)  utility routine.
      2000-12-09  Jody Goldberg <jgoldberg@home.com>
      	* src/selection.c (sheet_selection_set_internal) : rename from
      	  sheet_selection_set and add the 'just_add_it' flag to indicate that
      	  we don't need to do anything fancy.
  6. 15 Nov, 2000 1 commit
    • Morten Welinder's avatar
      Remove trailing white-space from files that have it. · 5570aef3
      Morten Welinder authored
      (The following command was done in src/ and plugins/.  Note, that the
      grep has a space and a tab.)
      for i in `find . -name '*.[ch]' -print`; do if grep '[         ]$' $i >/dev/null; then echo $i; perl -pi -e 's/[ \t]+$//' $i; fi; done
  7. 06 Nov, 2000 1 commit
    • Jody Goldberg's avatar
      Remove 'entered_text' foolishness. · 629daef1
      Jody Goldberg authored
      2000-11-05  Jody Goldberg <jgoldberg@home.com>
      	* src/sheet.c (cb_set_cell_content) : Use cell_set_value.
      	(sheet_range_set_text) : remove need for entered_text.
      	* src/xml-io.c (xml_read_cell) : Remove 'General' hack.
      	* src/dialogs/dialog-cell-format.c (draw_format_preview) : remove
      	* src/rendered-value.c (rendered_value_new_ext) : No need for
      	  entered_text.  Use format_value in place of value_as_string.
      	* src/format.c (format_value) : No need for entered_text.
      	  Be careful to always set the colour.  This may need to be tuned
      	  if we enter '$10' and use a display format of @ what should be
      	  displayed ?  10 or $10 ?  We may need to pass in the parse format.
      	* src/cell.c (cell_cleanout) : Remove entered_text.
      	(cell_copy) : Ditto.
      	(cell_set_text) : Ditto.
      	(cell_set_value) : Ditto, do not render value here.
      	(cell_set_text_and_value) : Delete.
      	(cell_set_expr_and_value) : Remove entered_text, and add format
      	(cell_set_expr_internal) : No need to manually unref the old expr.
      	  That was already done in cleanout.
      	(cell_make_value) : remove entered_text.
      	* src/rendered-value.c (cell_get_entered_text) : Use the stored parse
      	  format and format_value to regenerate the entered text from a value.
  8. 16 Oct, 2000 2 commits
    • Jody Goldberg's avatar
      no need to clear the formats. We are going to be pasting over them later. · bdcf8088
      Jody Goldberg authored
      2000-10-15  Jody Goldberg <jgoldberg@home.com>
      	* src/clipboard.c (clipboard_paste_region) : no need to clear the
      	  formats.  We are going to be pasting over them later.  This means
      	  that we don't rerender everything in the region then replace it.
      	* src/rendered-value.c (rendered_value_new_ext) : Pass colwidth as a
      	  float to get beter resolution.
      	* src/format.c (format_value) : Ditto.
      	* src/format.c (fmt_general_float) : More tuning.
    • Jody Goldberg's avatar
      RE_RENDER when a span clac is forced. This is a bit brute force for now, · bad302a3
      Jody Goldberg authored
      2000-10-15  Jody Goldberg <jgoldberg@home.com>
      	* src/sheet.c (sheet_update) : RE_RENDER when a span clac is forced.
      	  This is a bit brute force for now, but is necessary to force the
      	  re-rendering of values that may have width dependent formats.
      	  I've noted a possible future enhancement that would remove this req
      	  at the cost of some complexity.
      	* src/format.c (fmt_general_float) : new function.
      	(fmt_general_int) : new function.
      	(format_value) : Use the new routines.
      2000-10-15  Jody Goldberg <jgoldberg@home.com>
      	* src/cell.c (cell_set_value) : Re-render the entered text to handle
      	  width dependent formats.
      2000-10-14  Jody Goldberg <jgoldberg@home.com>
      	* src/print-cell.c (print_overflow) : improve drawing of hash marks.
      	* src/cell-draw.c (draw_overflow) : to always draw at least one hash.
      	* src/rendered-value.c (rendered_value_new_ext) : pass in approx
      	  column width in characters for use by general.
  9. 21 Sep, 2000 1 commit
    • Jody Goldberg's avatar
      no need to translate the money format. We generate it elsewhere. · cec33cc8
      Jody Goldberg authored
      2000-09-21  Jody Goldberg <jgoldberg@home.com>
      	* src/workbook-format-toolbar.c (workbook_cmd_format_as_money) :
      	  no need to translate the money format.  We generate it elsewhere.
      	(workbook_cmd_format_as_percent) : ditto.
      	* src/formats.c : Most format strings are NOT required to be
      	  translated anymore.  We store them internaly in the C locale.
      	(currency_date_format_init) : customize the currency symbol, and the
      	  day/month order.
      	* src/format.c (format_get_currency) : new function.
      	(format_month_before_day) : New stub.  How to do this portably.
      	(lookup_color_by_name) : new routine.
      	(lookup_color) : that was split from here.
      	(format_remove_decimal) : Fix a bit.  still broken for fmts with
      	  multiple cases.
      	(format_value) : no need to translate the format.
      	(translate_format_color) : new routine.
      	(style_format_delocalize) : new routine.  Add colour support.
      	(style_format_new_XL) : split from here.
      	(style_format_str_as_XL) : new routine.  Add colour support.
      	(style_format_as_XL) : split from here.
      2000-09-20  Jody Goldberg <jgoldberg@home.com>
      	* src/sheet-object.c (sheet_object_destroy) : If the current object is
      	  destroyed switch back to edit mode.
  10. 19 Sep, 2000 1 commit
    • Jody Goldberg's avatar
      Woohoo! The last of the release critical bugs are done. · b121e5da
      Jody Goldberg authored
      2000-09-18  Jody Goldberg <jgoldberg@home.com>
      	* src/sheet.c (sheet_row_size_fit_pixels) : PUTRID KLUDGE.
      	  Avoid the ugly row size changes when fitting the size.
      	* src/format.c (style_format_new_XL) : Implement translation.
      	(style_format_as_XL) : Ditto.
      	* src/number-match.c (format_match_init) : No need to compare to
      	  translated General.
      	* src/sheet.c (sheet_flag_status_update_cell) : Adjust signature.
  11. 21 Aug, 2000 1 commit
    • Jody Goldberg's avatar
      Improve regexps. · 9ad38a63
      Jody Goldberg authored
      2000-08-21  Jody Goldberg <jgoldberg@home.com>
      	* src/number-match.c (format_create_regexp) : Improve regexps.
      	* src/formats.c (cell_format_is_number) : Format always uses standard
      	  decimal chars.
      	* src/format.c (gnumeric_setlocale) : New routine that clears cached
      	  locale info.
      	(format_get_decimal) : Improve use mon_decimal.
      	(format_get_thousand) : Improve use mon_thousands_sep.
      	(format_get_arg_sep) : New func.
      	(format_get_col_sep) : New func.
      	(format_destroy) : Use GPtrArray.
      	(render_number) : Improve localization.
      	(format_add_thousand) : rename format_toggle_thousands. De-localize.
      	(find_decimal_char) : De-localize.
      	(format_remove_decimal) : Ditto.
      	(format_add_decimal) : Ditto.
      	(format_number) : Ditto.
      	* src/expr.c (do_expr_tree_to_string) : Use format_get_arg_sep.
      	* src/cell.c (cell_get_format) : Update for the changes to StyleFormat.
      	* src/auto-format.c (auto_style_format_suggest) :
      	  style_format_new -> style_format_new_XL
      	* src/mstyle.c (mstyle_element_dump) : There is no direct access to
      	  the format string anymore.
      	(mstyle_set_format_text) : Add a warning.
      	* src/gutils.[ch] (float_get_from_range) : Delete.
      	(int_get_from_range) : Ditto.
      	* src/parser.y : Revamp lexer to use strtol, and strtod for number
      	  parsing.  Begin hooks for supporting row & col selection. (3:4 or A:B)
      	* src/print-info.c (render_value_with_format) : Changes to StyleFormat.
      	* src/sheet.h : Move SpanCalcFlags.
      	* src/gnumeric.h : here.
      	* src/style.[ch] : Privatize StyleFormat, move it to format.[ch]
      	* src/value.c (value_get_as_string) : Correctly localize things for
      	* src/workbook-format-toolbar.c (modify_cell_format) : format
      	  modification callback modifies the StyleFormat.
      	* src/workbook.c (workbook_set_auto_expr) : Use gnumeric_setlocale.
      	* src/xml-io.c (xml_workbook_read) : Use gnumeric_setlocale.
      	(xml_workbook_write) : Ditto.
      	(xml_read_cell) : Use style_format_new_XL.
      	(xml_write_cell_and_position) : Store the number formats in non localized XL form.
      	(xml_write_style) : Ditto.
      	* src/dialogs/dialog-cell-format.c (fmt_dialog_init_format_page) :
      	  Display localized number formats.
      	(fillin_negative_samples) : Not need to localize generated number
      	* src/dialogs/dialog-function-wizard.c (formula_guru_set_expr) : Use
      	* src/dialogs/dialog-stf-format-page.c
      	  (stf_dialog_format_page_prepare) : StyleFormats are now explicitly
      	  stored in a locale neutral format.
      	* src/functions/fn-string.c (gnumeric_text) : changes to
      	* src/functions/fn-financial.c (coupdayb) : Silence some warnings.
      	* src/functions/fn-information.c (translate_cell_format) : This should
      	  now work for different locales.
      2000-08-18  Jody Goldberg <jgoldberg@home.com>
      	* src/number-match.c (compute_value) : Extend the match algorithms to
      	  handle the new regexps.
      	* src/format.c (format_get_thousand) : provide a better default for
      	  countries using ',' as a decimal point.
  12. 10 Mar, 2000 1 commit
    • Jody Goldberg's avatar
      Constness. · c2af08a9
      Jody Goldberg authored
      2000-03-10  Jody Goldberg <jgoldberg@home.com>
      	* src/func.c (tokenized_help_new) : Constness.
      	* src/widgets/gtk-combo-box.c (cb_state_change) : New function to keep
      	  the state of the combo display button and the combo arrow in sync.
      	(gtk_combo_box_init) : Connect cb_state_change to the arrow.
      	(gtk_combo_box_set_display) : Ditto for the display widget.
      	* src/sheet.c (sheet_set_zoom_factor) : Bound the factor at 10% and 500%
      	* src/workbook.c (change_zoom_in_current_sheet_cb) :
      	  call change_displayed_zoom_cb to adjust the combo to contain the
      	(workbook_focus_current_sheet) : Only emit signal if the sheet
      2000-03-08  Jody Goldberg <jgoldberg@home.com>
      	* src/collect.c (callback_function_collect) : Treat arrays and ranges
      	  as errors.
      	* src/format.c (format_value) : formating a range returns a
      	  #VALUE! message.
      	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) :
      	  Use the workbook flags, and delete the icky globals.
      	(start_cell_selection_at) : Hide the std cursor when a cell selection
      	  cursor is created.
      	(gnumeric_sheet_stop_cell_selection) : Restore the std cursor.
      2000-03-07  Jody Goldberg <jgoldberg@home.com>
      	* src/workbook.c (accept_input) : Use workbook_finish_editing.
      	(cancel_input) : Ditto.
      	(do_focus_sheet) : Support range selection across spreadsheets.
      	(workbook_get_sheet_position) : Fix and document.
      	(workbook_move_sheet) : Fix.
      	(workbook_focus_sheet) : Handle errors cleanly.
      	(wb_edit_key_pressed) : Improve F4 handling.
      	(wizard_input) : Begin non-modal function wizard.  NOT FINSIHED.
      	(workbook_start_editing_at_cursor) : transfered from
      	(workbook_finish_editing) : Distilled from sheet_{accept,cancel}_pending_input.
      	(Workbook) : Add editing_cell, editing_sheet, editing.
      	* src/sheet.c (sheet_stop_editing) : Delete.
      	(sheet_accept_pending_input) : Merge into workbook_finish_editing.
      	(sheet_cancel_pending_input) : Ditto.
      	(sheet_start_editing_at_cursor) :
      	(sheet_create_edit_cursor) : New function.
      	(sheet_destroy_edit_cursor) : New function.
      	(sheet_destroy_cell_select_cursor) :  New function.
      	(Sheet) : Delete editing and editing_cell.
      	* src/selection.c (sheet_selection_changed_hook) : Make public.  This
      	  should eventually move but I'm not sure where.  It is used for more
      	  than just changes in the selection in the current sheet.  It must
      	  also be called when the sheet changes.  What it REALLY does it to
      	  sync the shared workbook state with the current sheet's selection.
      	* src/item-cursor.c (item_cursor_init) : Handle change from
      	  sheet_accept_pending_input -> workbook_finish_editing.
      	* src/item-grid.c (item_grid_button_1) : Ditto.
      	* src/gnumeric-sheet.c (gnumeric_sheet_can_move_cursor) : Edit moved
      	  from sheet -> workbook.
      	(selection_insert_selection_string) : Extend to support
      	  abs/rel refs and intersheet-refs.
      	(gnumeric_sheet_stop_cell_selection) : Add clear_string argument
      	  to optionally remove the selection range.
      	(gnumeric_sheet_key_mode_sheet) : Adjust to movement of editing flag
      	  from sheet -> workbook.  Be careful to use the original sheet when
      	  moving rather than the current sheet.  Support F4 while editing.
      	* src/cell-draw.c (cell_draw) : editing_cell has moved from sheet to
      	  workbook.  Fix font ref leak when drawing the edit cell.
      	* src/dialogs/dialog-function-wizard.c : Begin transition to being
      	  non-modal.  NOT FINISHED.
  13. 07 Nov, 1999 1 commit
  14. 19 Sep, 1999 1 commit
    • Miguel de Icaza's avatar
      use dialog_run_and_close here. (dialog_get_number): ditto. · 5e2e700b
      Miguel de Icaza authored
      1999-09-18  Miguel de Icaza  <miguel@gnu.org>
      	* src/dialogs/dialog-simple-input.c (dialog_get_sheet_name): use
      	dialog_run_and_close here.
      	(dialog_get_number): ditto.
      	* src/format.c (format_add_thousand, format_remove_decimal,
      	format_add_decimal): New routines.
      	(format_number): Fixed bug in 'E', 'e' handler (format was
      	incremented twice).
      	* src/workbook-cmd-format.c: Hook up the add/remove decimal and
      	add thousand actions.
      	* src/sheet.c (range_is_homogeneous): Do not value_release a value
      	* src/workbook-cmd-format.c (do_apply_style_to_selection): set
      	shett dirty.
      	(workbook_cmd_format_column_auto_fit): ditto.
      	(workbook_cmd_format_column_width): ditto.
      	(workbook_cmd_format_row_auto_fit): ditto.
      	(workbook_cmd_format_row_height): ditto.
      	* src/workbook.c (workbook_rename_sheet): dirty sheet.
  15. 22 May, 1999 1 commit
  16. 30 Apr, 1999 1 commit
  17. 30 Sep, 1998 1 commit
  18. 14 Sep, 1998 1 commit
    • Arturo Espinosa's avatar
      Color attributes in formats work (ie, you can get colored cells now); · 4ec6073e
      Arturo Espinosa authored
      Color attributes in formats work (ie, you can get colored cells now);
      My first -futile attempts- at getting various different cursors working on the
      spreadsheet (we need a cross and various other cursors for a better emulation
      of Excel).
      The beginning of autofill, but I really need to see Excel live before implementing
  19. 20 Aug, 1998 1 commit
    • Miguel de Icaza's avatar
      New value format framework installed. · e32cdefe
      Miguel de Icaza authored
      New value format framework installed.
      The idea is that we will precompile formats to avoid parsing the
      format everytime a cell is repainted.
      1998-08-19  Miguel de Icaza  <miguel@nuclecu.unam.mx>
      	* src/format.c (format_value): The new entry point for formating
      	values.  This takes a Value instead of a float.
      	NULL is never returned from format_value now: if there is a format
      	error, then value_string is used to display it.
      	(format_compile): This routine should always return, it cant fail,
      	in the worst * case it should just downgrade to simplistic formatting.
      	(format_destroy): This routine is invoked when the last user of
      	the format is gone (ie, refcount has reached zero) just before the
      	StyleFormat structure is actually released.  resources allocated
      	in format_compile should be disposed here
  20. 17 Aug, 1998 1 commit