1. 07 Jan, 2003 1 commit
    • Morten Welinder's avatar
      don't take a user pointer, but the conventions instead. · 97ab95f0
      Morten Welinder authored
      2003-01-07  Morten Welinder  <terra@diku.dk>
      
      	* src/parse-util.h (GnmParseFunctionHandler): don't take a user
      	pointer, but the conventions instead.
      
      	* src/parser.y: Supply convs to handlers.  Look up functions in
      	rewriter hash and act accordingly.
      
      
      2003-01-07  Morten Welinder  <terra@diku.dk>
      
      	* applix-read.c (function_renamer): New function.
      	(applix_conventions): Initialize the function rewriter.
      97ab95f0
  2. 03 Jan, 2003 1 commit
    • Jody Goldberg's avatar
      Support XL's 1904 date convention · c1db9cc7
      Jody Goldberg authored
      2003-01-02  Jody Goldberg <jody@gnome.org>
      
      	* ms-excel-read.c (excel_read_1904) : Enable 1904 support.
      	* ms-excel-write.c (write_workbook) : Set 1904 flag as necessary.
      
      2003-01-02  Jody Goldberg <jody@gnome.org>
      
      	* openoffice-read.c (oo_date_convention) : support 1904 date
      	  convention.
      
      2003-01-02  Jody Goldberg <jody@gnome.org>
      
      	* applix-read.c (applix_parse_cellref) : warning.
      
      2003-01-02  Jody Goldberg <jody@gnome.org>
      
      	* src/xml-io.c (xml_workbook_write) : export quick hack for 1904 date
      	  convention.  The positioning is silly.
      	(xml_workbook_read) : read it back.
      
      2003-01-01  Jody Goldberg <jody@gnome.org>
      
      	* gnumeric.desktop.in : Add StartupNotify=true
      c1db9cc7
  3. 30 Dec, 2002 1 commit
  4. 27 Dec, 2002 1 commit
  5. 19 Dec, 2002 2 commits
    • Morten Welinder's avatar
      Add cell_ref_handler and range_ref_handler members. · 63aa6058
      Morten Welinder authored
      2002-12-19  Morten Welinder  <terra@diku.dk>
      
      	* src/parse-util.h (GnmExprConventions): Add cell_ref_handler
      	and range_ref_handler members.
      
      	* src/expr.c (do_expr_as_string): Call cell_ref_handler and
      	range_ref_handler.
      
      	* src/parse-util.c (gnm_expr_conventions_new): Set default
      	cell_ref_handler and range_ref_handler.
      	(col_name_internal): Change to take an accumulator GString.  All
      	callers changed.
      	(row_name_internal): Ditto.
      	(rangeref_as_string): Ditto.
      	(cellref_as_string): Ditto.
      63aa6058
    • Morten Welinder's avatar
      Delete. (parse_util_init): Don't set up gnm_expr_conventions_default_1_0. · 988e54c2
      Morten Welinder authored
      2002-12-19  Morten Welinder  <terra@diku.dk>
      
      	* src/parse-util.c (gnm_expr_conventions_default_1_0): Delete.
      	(parse_util_init): Don't set up gnm_expr_conventions_default_1_0.
      	(parse_util_shutdown): Don't free it.
      988e54c2
  6. 15 Dec, 2002 1 commit
    • Morten Welinder's avatar
      New function. · b169366d
      Morten Welinder authored
      2002-12-15  Morten Welinder  <terra@diku.dk>
      
      	* src/expr.c (gnm_expr_as_gstring): New function.
      
      	* src/rendered-value.c (rendered_value_new): Use
      	gnm_expr_as_gstring to avoid extra copy of result.  Use
      	string_get_nocopy to avoid yet another copy.
      	(cell_get_entered_text): Use gnm_expr_as_gstring to avoid extra
      	copy of result.
      
      
      plus parts of this one:
      
      2002-12-13  Morten Welinder  <terra@diku.dk>
      
      	* src/value.c (value_get_as_gstring): New function.
      	(value_get_as_string): Use that.
      
      	* src/expr.c (do_expr_as_string): Use value_get_as_gstring.
      
      	* src/xml-io.c (gnumeric_xml_read_workbook): Grammar fix.
      
      	* src/parse-util.h (struct _GnmExprConventions): New members
       	expr_name_handler, output_sheet_name_sep, output_argument_sep,
       	output_array_col_sep, and output_translated.  Eliminate
       	use_locale_C.
      
      	* src/expr.c (do_expr_as_string): Use new expr_name_handler in
      	conventions.
      
      	* src/parse-util.c (def_expr_name_handler): New function, mostly
      	extracted from do_expr_as_string.
      	(gnm_expr_conventions_new): Attach def_expr_name_handler.
      b169366d
  7. 13 Dec, 2002 2 commits
    • Morten Welinder's avatar
      Grammar fix. · bc8e816d
      Morten Welinder authored
      2002-12-13  Morten Welinder  <terra@diku.dk>
      
      	* src/xml-io.c (gnumeric_xml_read_workbook): Grammar fix.
      
      	* src/parse-util.h (struct _GnmExprConventions): New members
      	expr_name_handler, output_sheet_name_sep, and output_argument_sep.
      bc8e816d
    • Morten Welinder's avatar
      New members expr_name_handler and output_sheet_name_sep. · 0f79c414
      Morten Welinder authored
      2002-12-13  Morten Welinder  <terra@diku.dk>
      
      	* src/parse-util.h (struct _GnmExprConventions): New members
      	expr_name_handler and output_sheet_name_sep.
      
      	* src/expr.c (do_expr_as_string): Use new expr_name_handler is
      	conventions.
      
      	* src/parse-util.c (def_expr_name_handler): New function, mostly
      	extracted from do_expr_as_string.
      	(gnm_expr_conventions_new): Attach def_expr_name_handler.
      0f79c414
  8. 26 Nov, 2002 1 commit
    • Morten Welinder's avatar
      Take GnmExprConventions, not a ref_parser. All callers changed. (yylex): · 07c10be7
      Morten Welinder authored
      2002-11-26  Morten Welinder  <terra@diku.dk>
      
      	* src/parser.y (gnm_expr_parse_str): Take GnmExprConventions, not
      	a ref_parser.  All callers changed.
      	(yylex): Flatten structure and use GnmExprConventions options.
      
      	* src/parse-util.h (struct _GnmExprConventions): New structure for
      	parsing info.
      	(GnmExprParseFlags): Prune lots of flags.
      
      	* src/parse-util.c (parse_util_init, parse_util_shutdown,
      	gnm_expr_conventions_new, gnm_expr_conventions_free): New
      	functions.
      	(gnm_expr_parse_str_simple): New function (was macro).
      
      	* src/libgnumeric.c (gnm_shutdown): Shut down parse_util.
      	(gnm_common_init): Init parse_util.
      
      	* src/func.c (gnm_func_placeholder_factory): New function.
      07c10be7
  9. 02 Nov, 2002 1 commit
  10. 17 Oct, 2002 1 commit
    • Jody Goldberg's avatar
      It looks like some builtinnames are just names, no definitions. eg · c10301fe
      Jody Goldberg authored
      2002-10-17  Jody Goldberg <jody@gnome.org>
      
      	* ms-excel-read.c (ms_excel_parse_NAME) : It looks like some
      	  builtinnames are just names, no definitions. eg 'Database'
      	  It also looks like these sheet_indexes apply to externsheet records
      	  for <= biff7 (see pivot.xls) rather than boundsheets.
      
      2002-10-17  Jody Goldberg <jody@gnome.org>
      
      	* src/workbook-edit.c (wbcg_edit_finish) : adjust to changes in
      	  ParseError and tweak focus handling when user decides to re-edit so
      	  that we actually select what we want to.
      
      	* src/parse-util.c (parse_error_init) : Use a GError for the error
      	  message to clarify life cycle.
      	(parse_error_free) : ditto.
      
      	* src/item-edit.c (item_edit_cursor_blink_start) : simple support for
      	  xsettings.
      
      	* src/expr.c (do_expr_as_string) : sync the precedence with the parser.
      	(do_expr_as_string) : Always qualify a sheet local name from another
      	  sheet.
      
      2002-10-16  Jody Goldberg <jody@gnome.org>
      
      	* src/parser.y : Fix precedences and associativity
      	Revamp error reporting to make sense.
      	Tify up the code a bit.
      	(sheetref) : remove the 3d productions.  We no longer need them
      	(workbookref) : add a new production to simplify error reporting.
      c10301fe
  11. 15 Oct, 2002 1 commit
    • Jody Goldberg's avatar
      support for recalc and iteration attributes. · b24361f0
      Jody Goldberg authored
      2002-10-14  Jody Goldberg <jody@gnome.org>
      
      	* dialog-workbook-attr.c : support for recalc and iteration
      	  attributes.
      
      
      2002-10-14  Jody Goldberg <jody@gnome.org>
      
      	* src/commands.c (update_after_action) : quick and dirty support for
      	  manual recalc.
      	(cmd_paste_cut_update_origin) : ditto.
      b24361f0
  12. 29 Sep, 2002 1 commit
    • Jody Goldberg's avatar
      document and fix a bit. still untested. (rangeref_parse) : touch up a bit. · 6d31c1c7
      Jody Goldberg authored
      
      2002-09-29  Jody Goldberg <jody@gnome.org>
      
      	* src/parse-util.c (wbref_parse) : document and fix a bit.  still
      	  untested.
      	(rangeref_parse) : touch up a bit.
      	(gnm_1_0_rangeref_parse) : new, untested.
      
      	* src/parser.y (gnm_expr_parse_str) : add
      	  GNM_EXPR_PARSE_USE_OPENCALC_CONVENTIONS.  To hard code the
      	  seperators rather than extracting them from the locale.  Its quick
      	  and dirty, but will do the job for now.  Later it would be nice to
      	  abstract the parse state a bit more so that we don't need to
      	  re-initialize every time.
      	(yylex) : handle xml escaping for opencalc.
      
      	* src/parse-util.c (row_parse) : fix.
      
      2002-09-27  Jody Goldberg <jody@gnome.org>
      
      	* src/expr-name.c (expr_name_create) : delete because it was hard
      	  coding which rangeref parser to use.
      
      2002-09-27  Jody Goldberg <jody@gnome.org>
      
      	* src/parser.y : remove bogus error message and fix the other message
      	  to be correct when faced with the wrong type of array seperator.
      6d31c1c7
  13. 26 Sep, 2002 1 commit
    • Jody Goldberg's avatar
      Make the error handling more consistent. · 045863cb
      Jody Goldberg authored
      
      2002-09-26  Jody Goldberg <jody@gnome.org>
      
      	* src/parser.y : Make the error handling more consistent.
      
      	* src/expr.c (gnm_expr_list_as_string) : optimize.
      
      	* src/dependent.c (link_expr_dep) : place holder for intersection.  I
      	  think it is ok to palm all of this off until eval time (asusming we get
      	  eval time depends working)
      
      2002-09-26  Jody Goldberg <jody@gnome.org>
      
      	* configure.in : add openoffice
      	* plugins/Makefile.am (SUBDIRS) : add openoffice
      
      2002-09-26  Jody Goldberg <jody@gnome.org>
      
      	* src/workbook-control-gui.c (cb_realize) : grab focus for current
      	sheet.
      
      2002-09-25  Jody Goldberg <jody@gnome.org>
      
      	* src/expr.c (gnm_expr_is_rangeref) : new.
      
      	* src/parser.y (yylex) : support space as the intersection operator.
      045863cb
  14. 25 Sep, 2002 1 commit
    • Jody Goldberg's avatar
      begin support for intersection and sets, still needs lots of work, but I · 2821f0c8
      Jody Goldberg authored
      
      2002-09-25  Jody Goldberg <jody@gnome.org>
      
      	* src/parser.y : begin support for intersection and sets, still needs
      	  lots of work, but I don't want to get too out of sync.
      
      	* src/expr.c : handle intersection and sets.
      	* src/expr-name.c (name_refer_circular) : ditto.
      
      	* src/workbook.c (post_sheet_index_change) : don't emit the signal
      	  during destruction.
      
      2002-09-24  Lutz Müller <lutz@users.sourceforge.net>
      
      	* src/dialogs/dialog-sheet-order.c: Be aware of changes in the
      	  sheet order.
      	* src/workbook.[c,h]: Provide a "sheet_order_changed" signal.
      	* src/workbook-control-gui.c: Remove debugging messages. Allow
      	  dropping the sheet anywhere in the workbook - reordering will still
      	  be done.
      2821f0c8
  15. 24 Sep, 2002 1 commit
    • Jody Goldberg's avatar
      remove the rest of the CELLREF based productions. · 519f4b04
      Jody Goldberg authored
      
      2002-09-24  Jody Goldberg <jody@gnome.org>
      
      	* src/parser.y : remove the rest of the CELLREF based productions.
      
      	* src/parse-util.h : do a bit of tidying
      	(col_parse) : make public.
      	(row_parse) : make public.
      	(cellpos_as_string) : rename from cell_pos_name.
      	(cellpos_parse) : renamed from parse_cell_name
      	(cellref_as_string) : rename from cellref_name
      	(cellref_parse) : rename from cellref_get
      	(parse_col_name) : delete duplicate
      	(gnm_expr_char_start_p) : renamed from gnumeric_char_start_expr_p.
      
      	* src/parse-util.c (rangeref_parse) : fix handling of non-3d
      	  inter-sheet refs.
      	(col_parse) : check for overflow.
      
      	* src/parser.y : remove sheet_ref RANGEREF production. RANGEREF
      	  already handles sheet references internally.
      
      	* src/expr.c (gnm_expr_eval) : handle empties when implicit
      	  intersection is valid but accesses an empty cell.
      519f4b04
  16. 06 Sep, 2002 1 commit
    • Jody Goldberg's avatar
      convert to using RangeRef and rangeref_parse and rangeref_as_string. · 7d300c8c
      Jody Goldberg authored
      2002-09-06  Jody Goldberg <jody@gnome.org>
      
      	* gnumeric-expr-entry.c : convert to using RangeRef and rangeref_parse
      	  and rangeref_as_string.
      
      2002-09-06  Jody Goldberg <jody@gnome.org>
      
      	* src/sheet-control-gui.c (scg_colrow_select) : don't do a start and a
      	  change.  Do a start or a change.  do not sheet_update for rangesel.
      
      	* src/parser.y : some utf8 fixes for escaped characters
      
      	* src/expr.c (do_expr_as_string) : rangeref_name -> rangeref_as_string
      	* src/parse-util.c (rangeref_parse) : new.
      	(parse_surrounding_ranges) : delete.
      7d300c8c
  17. 04 Sep, 2002 1 commit
    • Jody Goldberg's avatar
      fix handling of multiline text. fix position of cursor line. · 401cb7da
      Jody Goldberg authored
      
      2002-09-04  Jody Goldberg <jody@gnome.org>
      
      	* src/cell-draw.c (cell_draw) : fix handling of multiline text.
      	* src/item-edit.c (item_edit_draw) : fix position of cursor line.
      
      2002-09-03  Jody Goldberg <jody@gnome.org>
      
      	* src/position.c (rangeref_name) : new.
      
      	* src/expr.c (do_expr_as_string) : Use rangeref_name.
      
      	* src/parser.y (sheetref) : support XL style 3d references
      	(cellref) : accept XL style 3d references in addition to applix format.
      	  Produce an error if an invalid combination is used.
      	    eg sheet1:sheet2!a1:sheet3!a1
      	  Prepare to support row only or col only references (A:C or 1:5)
      401cb7da
  18. 21 Jun, 2002 1 commit
    • Jody Goldberg's avatar
      take a cellpos * · 89274950
      Jody Goldberg authored
      
      2002-06-21  Jody Goldberg <jody@gnome.org>
      
      	* src/parse-util.c (parse_cell_name) : take a cellpos *
      
      	* src/func-builtin.c (gnumeric_selection) : dummy out for now until a
      	  different approach is available.
      
      	* src/commands.c : convert to sheetview.
      	  s/parent/cmd/ to make things more readable
      	(cmd_selection_clear) : rename from cmd_clear_selection so that we can
      	  start to group the operations that currently operate on selections.
      	(cmd_selection_format) : rename from cmd_format.
      	(cmd_selection_colrow_hide) : rename from cmd_colrow_hide_selection.
      	(cmd_selection_outline_change) : rename from cmd_colrow_outline_change.
      	(cmd_selection_group) : rename from cmd_group.
      	(cmd_selection_autoformat) : rename from cmd_autoformat.
      	(cmd_colrow_hide_correct_selection) : take a control.
      
      	* src/colrow.c (cb_colrow_visibility) : selections are now part of
      	  sheetview.
      	(colrow_get_visiblity_toggle) : ditto.
      
      	* src/cmd-edit.c (cmd_select_cur_row) : convert to sheetview.
      	(cmd_select_cur_col) : ditto.
      	(cmd_select_cur_array) : ditto.
      	(cmd_select_cur_depends) : ditto.
      	(cmd_select_cur_inputs) : ditto.
      	(cmd_paste_to_selection) : ditto.
      
      	* src/bonobo-io.c (deserialize_wb_from_xml_stream) : pass the wbv into
      	  the context directly.
      	(gnumeric_bonobo_write_workbook) : ditto.
      	(gnumeric_bonobo_read_workbook) : ditto.
      
      	* src/consolidate.c (redraw_respan_and_select) : set selection only
      	  for the calling view.
      	(row_consolidate) : pass in the view.
      	(col_consolidate) : ditto.
      	(colrow_consolidate) : ditto.
      	(consolidate_apply) : Take a control so that we can extract the view.
      
      	* src/commands.c (cmd_consolidate_redo) : Pass the control.
      
      2002-06-20  Jody Goldberg <jody@gnome.org>
      
      	* src/sheet-view.c (sheet_view_init) : init the selection.
      
      	* src/workbook-view.c (workbook_view_new) : init current_sheet_view.
      	(wb_view_format_feedback) : operate on the sheetview.
      	(wb_view_selection_desc) : ditto.
      	(wb_view_edit_line_set) : ditto.
      
      2002-06-20  Jody Goldberg <jody@gnome.org>
      
      	* src/workbook-view.c (wb_view_sheet_add) : Use sheet_get_view.
      	(wb_view_sheet_focus) : ditto.
      	* src/xml-io.c (xml_write_selection_info) : ditto.
      	(xml_read_selection_info): ditto.
      	(xml_workbook_write) : now that the view is in the context don't
      	  bother passing it.
      	(xml_write_wbv_attributes) : ditto.
      	(xml_read_wbv_attributes) : ditto.
      89274950
  19. 16 Jun, 2002 1 commit
  20. 29 May, 2002 1 commit
    • Jody Goldberg's avatar
      do not initialize this to single range. (gnm_expr_entry_parse) : fill in · e812a184
      Jody Goldberg authored
      
      2002-05-29  Jody Goldberg <jody@gnome.org>
      
      	* gnumeric-expr-entry.c (gnumeric_expr_entry_new) : do not initialize
      	  this to single range.
      	(gnm_expr_entry_parse) : fill in the parse error if it is supplied.
      
      2002-05-29  Jody Goldberg <jody@gnome.org>
      
      	* dialog-define-names.c (name_guru_add) : init the parse error.
      
      2002-05-29  Jody Goldberg <jody@gnome.org>
      
      	* src/parse-util.h : Add PERR_SINGLE_RANGE.
      e812a184
  21. 04 Apr, 2002 1 commit
    • Andreas J. Guelzow's avatar
      new, code extracted from src/widgets/gnumeric-expr-entry.c new deleted · 4c29b0b6
      Andreas J. Guelzow authored
      2002-04-04  Andreas J. Guelzow <aguelzow@taliesin.ca>
      
      	* src/parse-util.c (parse_surrounding_ranges) : new, code extracted
      	  from src/widgets/gnumeric-expr-entry.c
      	* src/parse-util.h (parse_surrounding_ranges) : new
      	* src/item-edit.c (scan_at) : deleted
      	(point_is_inside_range) : use arse_surrounding_ranges
      	* src/position.c (value_to_rangeref) : new
      	(rangeref_normalize) : new
      	* src/position.h (value_to_rangeref, rangeref_normalize) : new
      	* src/ranges.c (setup_range_from_value) : use setup_range_from_range_ref
      	(setup_range_from_range_ref) : new
      	* src/ranges.h (setup_range_from_range_ref) : new
      	* src/value-sheet.c (value_cellrange_normalize) : use rangeref_normalize
      
      2002-04-04  Andreas J. Guelzow <aguelzow@taliesin.ca>
      
      	* gnumeric-expr-entry.c (gnm_expr_entry_rangesel_start) extract
      	  parsing into src/parse-util.c
      4c29b0b6
  22. 22 Mar, 2002 1 commit
    • Jody Goldberg's avatar
      Massive rename ExprTree -> GnmExpr · 0ac8fbbf
      Jody Goldberg authored
      
      2002-03-21  Jody Goldberg <jody@gnome.org>
      
      	* Massive rename
      	ExprTree -> GnmExpr
      
      	* src/print-info.c (load_formats) : suppress some warnings.
      
      	* src/func.c (function_def_call_with_values) : use g_alloca.
      0ac8fbbf
  23. 15 Feb, 2002 1 commit
    • Jody Goldberg's avatar
      We can now make distcheck · f84a08c5
      Jody Goldberg authored
      Requires a GAL update, and a gtk+ update
      
      2002-02-15  Jody Goldberg <jody@gnome.org>
      
      	* src/item-cursor.c (item_cursor_tip_setlabel) : enable now that the
      	  canvas bug is fixed.
      
      	* src/sheet-control-gui.c (cb_hscrollbar_adjust_bounds) : new.
      	(cb_vscrollbar_adjust_bounds) : new.
      
      	* src/gui-util.c (gtk_button_stock_alignment_set) : new.
      	(gnumeric_init_help_button) : new.
      
      	* src/gnumeric-canvas.h : Move declaration of
      	  GnumericCanvasSlideHandler here.
      
      	* src/gnumeric-canvas.c (gnm_canvas_guru_key) : forward to the entry,
      	  not the GnumericExprEntry wrapper.
      	(gnm_canvas_key_mode_sheet) : ditto.
      
      	* src/formats.c (cell_format_classify) : handle general.
      
      	* src/file-priv.h : Inherit from GObject.
      
      	* src/complete-sheet.c (complete_sheet_finalize) : call class_peek
      	  here to avoid potential reference problems.
      
      	* src/commands.c (cmd_set_text) : doh!  fix multi-line text.
      	(cmd_autoformat) : const.
      
      	* src/cell.c (cell_relocate) : const.
      	* src/clipboard.c (paste_cell_with_operation) : const.
      	(paste_cell) : ditto.
      
      	* src/application.c (application_init) : add jimmac's expr-entry icon.
      
      	* src/Makefile.am : distribute the marshaller.list
      
      	s/GtkType/GType/
      	s/GtkSignalFunc/GCallback/
      	s/gtk_signal_connect/g_signal_connect/  + reformating.
      	s/GTK_CHECK_CAST/G_TYPE_CHECK_INSTANCE_CAST/
      	s/GTK_CHECK_TYPE/G_TYPE_CHECK_CLASS_CAST/
      	s/GTK_CHECK_CLASS_CAST/G_TYPE_CHECK_INSTANCE_TYPE/
      	s/GTK_CHECK_CLASS_TYPE/G_TYPE_CHECK_CLASS_TYPE/
      
      2002-02-11  Jody Goldberg <jody@gnome.org>
      
      	* src/stf.c (stf_init) : Make the names of the text import/export
      	  clearer.
      f84a08c5
  24. 04 Feb, 2002 1 commit
    • Jody Goldberg's avatar
      don't actually store the value, just start editing with it. · 167c36d3
      Jody Goldberg authored
      2002-02-03  Jody Goldberg <jody@gnome.org>
      
      	* src/workbook-control-gui.c (cb_insert_current_date) : don't actually
      	  store the value, just start editing with it.
      	(cb_insert_current_time) : ditto.
      
      2002-02-03  Jody Goldberg <jody@gnome.org>
      
      	* src/value.c (value_new_*) : init Value*::fmt
      	(value_duplicate) : ref the fmt too.
      	(value_set_fmt) : new.
      
      	* src/cell.c (cell_cleanout) : no more format.
      	(cell_copy) : ditto.
      	(cell_set_text) : ditto.
      	(cell_set_expr_internal) : ditto.
      	(cell_set_expr_unsafe) : ditto.
      	(cell_get_format) : ditto.
      
      	Change all callers.
      	* src/sheet.c (sheet_cell_set_value) : remove format assingment.
      	* src/cell.c (cell_set_expr_and_value) : remove format assignment.
      	(cell_assign_value) : ditto.
      	(cell_set_value) : ditto.
      	(cell_set_expr) : ditto.
      	* src/parser.y (expr_parse_str) : remove arg to return the suggested
      	  format.  That will be handled at run time.
      	* src/number-match.c (format_match) : remove arg to return the parse
      	  formula.  Store it in the value instead.
      167c36d3
  25. 30 Dec, 2001 1 commit
  26. 07 Dec, 2001 1 commit
    • Jody Goldberg's avatar
      don't destroy the dialog until we are done with it. · 3c033871
      Jody Goldberg authored
      2001-12-07  Jody Goldberg <jody@gnome.org>
      
      	* dialog-advanced-filter.c (dialog_advanced_filter) : don't destroy
      	  the dialog until we are done with it.
      
      2001-12-07  Jody Goldberg <jody@gnome.org>
      
      	* src/parse-util.c (parse_cell_name_or_range) : delete unused.
      	(parse_cell_name_list) : ditto.
      3c033871
  27. 26 Nov, 2001 1 commit
    • Jody Goldberg's avatar
      add OPER_SET. ditto. ditto. (expr_tree_equal) : ditto. (expr_eval_real) : · 217a63bd
      Jody Goldberg authored
      2001-11-25  Jody Goldberg <jody@gnome.org>
      
      	* src/eval.c (handle_tree_deps) : add OPER_SET.
      	* src/expr-name.c (name_refer_circular) :  ditto.
      	* src/expr.c (do_expr_tree_unref) : ditto.
      	(expr_tree_equal) : ditto.
      	(expr_eval_real) : ditto.
      	(expr_rewrite) : ditto.
      	(do_expr_tree_as_string) : ditto.
      	(expr_tree_new_funcall) : use ExprList.
      	(expr_parse_string) : delete.
      	(expr_tree_new_set) : new.
      	(expr_list_unref) : new.
      	(expr_list_equal) : new.
      	(expr_list_as_string) : new.
      
      	* src/gnumeric.h : Add ExprList and ExprSet
      
      	* src/parser.y (expr_parse_str) : renamed from gnumeric_expr_parser.
      	  Add support for multiple expressions.
      	(line) : add support for multiple expressions.
      
      	* src/ranges.c (global_range_parse) : Use expr_parse_str
      	(global_range_list_parse) : rewrite to use expr_parse_str and use the
      	  new multi-expression support in the parser.
      
      	* src/commands.c (cmd_area_set_text_redo) : Use expr_parse_str.
      	* src/xml-io.c (xml_read_style_condition_chain) : ditto.
      	(xml_cell_set_array_expr) : ditto.
      	* src/workbook-view.c (wb_view_auto_expr) : ditto.
      	* src/workbook-edit.c (wbcg_edit_finish) : ditto.
      	* src/sheet-object-widget.c (sheet_widget_checkbox_read_xml) : ditto.
      	* src/parse-util.c (parse_text_value_or_expr) : ditto.
      
      	* src/auto-format.c (do_af_suggest) : Use ExprList instead of GList
      	(do_af_suggest_list) : ditto.
      	* src/collect.c (collect_floats) : ditto.
      	(collect_floats_value) : ditto.
      	(float_range_function) : ditto.
      	* src/consolidate.c (simple_consolidate) : ditto.
      	(colrow_formula_args_build) : ditto.
      	(consolidate_apply) : ditto.
      217a63bd
  28. 09 Nov, 2001 1 commit
    • Jody Goldberg's avatar
      begin parsing the sheet name. Still need to support starting in the · c1005d28
      Jody Goldberg authored
      2001-11-09  Jody Goldberg <jgoldberg@home.com>
      
      	* gnumeric-expr-entry.c (gnumeric_expr_entry_rangesel_start) : begin
      	parsing the sheet name.  Still need to support starting in the
      	sheetname, and to actually use the name.
      	(gnumeric_expr_entry_parse) : new utility.
      
      2001-11-09  Jody Goldberg <jgoldberg@home.com>
      
      	* dialog-graph-guru.c (vector_state_apply_changes) : Use
      	  gnumeric_expr_entry_parse.
      
      2001-11-09  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet-object-widget.c (sheet_widget_checkbox_toggled) : Use
      	  expr_tree_get_range.
      	(cb_checkbox_set_focus) : rework to use dialog::set-focus.
      	(cb_checkbox_config_clicked) : use gnumeric_expr_entry_parse.
      	(sheet_widget_checkbox_user_config) : set up the new focus handler.
      
      	* src/sheet-control-gui.c (scg_object_nudge) : new.
      	(scg_object_update_bbox) : no need to pass the view.
      	(scg_object_move) : ditto.
      	(cb_slide_handler) : ditto.
      
      	* src/parser.y (force_explicit_sheet_references) : new.
      	(parse_ref_or_string) : Support forcing an absolute ref.
      	(gnumeric_expr_parser) : remove the individual flags and send in a bit
      	mask.
      
      	* src/item-grid.c (item_grid_draw_merged_range) : filted invisble
      	  ranges.
      	(item_grid_draw) : handle merges hidden by row, and support sliced
      	  merges in the future.
      
      	* src/sheet.c (sheet_col_row_fit_gutter) : New max_outline semantics
      	  remove need for special case.
      	(sheet_colrow_get) : new utility.
      
      	* src/item-bar.c (ib_compute_pixels_from_indent) : Adjust to new
      	  outline_level semantics.  We now implicitly add 1 when needed.
      	  rather than tweaking it at startup.
      	(item_bar_draw) : ditto.
      	(outline_button_press) : ditto.
      
      	* src/gnumeric-pane.c (gnm_pane_release) : Clean out cursors and
      	  such.
      
      	* src/gnumeric-graph.h : do not include idl header publicly.
      	  Damn automake.
      
      	* src/gnumeric-canvas.c (gnm_canvas_key_mode_object) : support moving
      	  objects with the keyboard.
      
      	http://bugzilla.gnome.org/show_bug.cgi?id=64023
      	* src/colrow.c (colrow_visibility) : visible collapse marks at lower
      	  levels should also be collapsed.
      
      	* src/analysis-tools.c (get_data) : handle blanks better.
      c1005d28
  29. 06 Nov, 2001 1 commit
    • Jody Goldberg's avatar
      don't use the flags, store the ab/srel info in the selector. · a3bacc8a
      Jody Goldberg authored
      2001-11-05  Jody Goldberg <jgoldberg@home.com>
      
      	* gnumeric-expr-entry.c (make_rangesel_text) : don't use the flags,
      	  store the ab/srel info in the selector.
      	(update_rangesel_text) : use the pos from the entry.
      	(gnumeric_expr_entry_rangesel_start) : new routine to find the start
      	  of a range.  Still needs work to support intra-{sheet,book}
      	  references.
      	(gnumeric_expr_entry_key_press_event) : move F4 handling here.
      
      2001-11-05  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet-control-gui.c (scg_select_all) : rangesel_bound will call
      	  start if necessary.
      	(scg_colrow_select) : ditto.
      	(scg_rangesel_changed) : improve comments,
      	(scg_rangesel_start) : take a range, and call
      	  gnumeric_expr_entry_rangesel_start.
      	(scg_rangesel_extend_to) : call start if necessary.
      	(scg_rangesel_bound) : ditto.
      
      	* src/parse-util.c (cellref_a1_get) : return a point to 1 past the
      	  last character, or NULL instead of boolean.
      	(cellref_r1c1_get) : ditto.
      	(cellref_get) : ditto.
      
      	* src/parser.y (parse_ref_or_string) : adjust to changes in cellref_get.
      	* src/xml-io.c (xml_read_names) : ditto.
      
      	* Makefile.am : Add BEVERAGES file.
      
      	* src/item-grid.c (item_grid_button_1) : scg_rangesel_start now
      	  supports selecting a range.
      
      	* src/gnumeric-pane.c (gnm_pane_rangesel_start) : just take a range,
      	  it is simplier.
      
      	* src/workbook-edit.c (wbcg_edit_toggle_absolute) : delete.
      
      	* src/gnumeric-canvas.c (gnm_canvas_key_mode_sheet) : just forward the
      	  F4 to the expr-entry it knows what to do.
      a3bacc8a
  30. 26 Oct, 2001 1 commit
    • Jody Goldberg's avatar
      remove the loops, and recursions. match against formatted values before · fea69d08
      Jody Goldberg authored
      2001-10-26  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook-edit.c (wbcg_edit_finish) : remove the loops, and
      	  recursions.  match against formatted values before expressions, then
      	  fall back to strings.
      
      	* src/parse-util.c (parse_text_value_or_expr) : match against
      	  formatted values before expressions, then fall back to strings.
      
      	* src/cell.c (cell_set_text) : parse_text_value_or_expr takes a ParsePos.
      	* src/sheet.c (sheet_cell_set_text) : ditto.
      	* src/widgets/gnumeric-expr-entry.c
      	  (gnumeric_expr_entry_key_press_event) : ditto.
      	* src/commands.c (cmd_area_set_text_redo) : ditto.
      	(cmd_area_set_text) : ditto.
      	(cmd_search_replace_do_cell) : create a tmp EvalPos to avoid changing
      	  the search data structures.
      
      	* src/expr.c (expr_tree_get_range) : renamed from range_from_expr_tree.
      	  add support for singletons.
      
      	* src/ranges.c (global_range_parse) : tweak slightly.
      
      2001-10-26  Jody Goldberg <jgoldberg@home.com>
      
      	* src/number-match.c (format_match_init) : don't include text in the
      	  stock set of formats they should only match numbers.
      fea69d08
  31. 14 Sep, 2001 1 commit
    • Jody Goldberg's avatar
      if we are displaying the parse fmt because the assigned fmt is General · 1dbce43d
      Jody Goldberg authored
      2001-09-14  Jody Goldberg <jgoldberg@home.com>
      
      	* dialog-cell-format.c (fmt_dialog_init_format_page) : if we are
      	  displaying the parse fmt because the assigned fmt is General
      	  then select the parse fmt in the dialog.
      
      2001-09-14  Jody Goldberg <jgoldberg@home.com>
      
      	* ms-chart.c (excel_chart_series_write_xml) : Use the gal routines for
      	  symetry with the guppi implementation.
      
      2001-09-14  Jody Goldberg <jgoldberg@home.com>
      
      	* src/style-color.c (style_color_new_name) : new utility.
      
      	* src/gnumeric-graph.c : cleanup the debug info.
      	(gnm_graph_get_spec) : make public and add some protection.
      
      	* src/number-match.c : remove format_parse_t and merge it with
      	  StyleFormat.
      	(format_match_release) : new routine split from format_match_finish.
      	(format_match_finish) : just unref the StyleFont.
      	(format_match_create) : tweaking the calling convention and rename
      	  format_match_define.
      	(format_match_init) : manage the format_match_list here.
      	(format_match) : Match against the currently assigned format first
      
      	* src/format.c : clean the includes.
      	Make _StyleFormat public for sharing with number-match.c
      	(format_compile) : call format_match_create.
      	(format_destroy) : call format_match_release.
      	(format_color_init) : use style_color_new_name.
      	(style_format_new_XL) : init the new regexp elements to NULL.
      
      	* src/bonobo-io.c (gnumeric_bonobo_io_init) : name this better.
      
      	* src/sheet-control-gui.c (scg_object_update_bbox) : add some
      	  protection.
      1dbce43d
  32. 11 Jul, 2001 1 commit
    • Almer S. Tigelaar's avatar
      Add error ID's. (gnumeric_parse_error): Accept ID and set ID on error · c44451ea
      Almer S. Tigelaar authored
      2001-07-11  Almer S. Tigelaar  <almer@gnome.org>
      
      	* src/parser.y : Add error ID's.
      	(gnumeric_parse_error): Accept ID and set ID on error struct.
      
      	* src/parse-util.[ch]
      	(parse_error_init): Initialize the error id.
      
      	* src/workbook-edit.c (wbcg_edit_finish): When there's a missing
      	closing paren, try appending one and see if it helps.
      
      	* src/stf-parse.c (stf_preparse): New, default preparsing of a file.
      	(stf_read_workbook): Use stf_preparse.
      	(stf_read_default_probe): Prober for reading.
      	(stf_read_workbook_csv_default): New, read a csv file in default formatting.
      	(stf_init): Register stf_read_workbook_csv_default.
      c44451ea
  33. 03 Jun, 2001 1 commit
    • Almer S. Tigelaar's avatar
      New, converts a row number to a string. (rows_name): Idem, but for a · 77cadcab
      Almer S. Tigelaar authored
      2001-06-03  Almer S. Tigelaar  <almer@gnome.org>
      
       	* src/parse-util.[ch] (row_name): New, converts
       	a row number to a string.
       	(rows_name): Idem, but for a start/end range.
       	(row_name_internal): Utility routine.
      
       	* src/colrow.c (colrow_string_build): Remove.
       	(colrow_index_list_to_string): Use rows_name
       	and cols_name.
      
       	* src/cmd-edit.c (cmd_shift_rows): Use rows_name.
      
       	* src/commands.c (cmd_insert_rows): Idem.
       	(cmd_delete_cols): Beautify.
       	(cmd_delete_rows): Beautify and use rows_name.
      
       	* src/eval.c (dump_range_dep): Use row_name.
      
       	* src/item-bar.c (get_row_name): Deprecated, remove.
       	(item_bar_draw): Use row_name.
      
       	* src/item-cursor.c (item_cursor_tip_setlabel): Idem.
      
       	* src/item-grid.c (item_grid_draw): Idem.
      
       	* src/ranges.c (range_name): Idem.
       	(range_dump): Idem.
      
       	* src/selection.c (reference_append): Idem.
       	(selection_get_ranges): Idem.
       	(cb_range_to_string): Idem.
      
       	* src/sheet-control-gui.c (scg_redraw_cell_region): Idem.
       	(vertical_scroll_offset_changed): Idem.
      
       	* src/value-sheet.c (value_dump): Idem.
       	(encode_cellref): Idem.
      
      2001-06-03  Almer S. Tigelaar  <almer@gnome.org>
      
       	* dialog-cell-sort.c (col_row_name):
       	Use row_name.
      77cadcab
  34. 04 May, 2001 1 commit
    • Jody Goldberg's avatar
      s/clipboard_release/cellregion_free/ s/range_copy/range_dup/ · 32bde6ee
      Jody Goldberg authored
      
      2001-05-04  Jody Goldberg <jgoldberg@home.com>
      
      	s/clipboard_release/cellregion_free/
      	s/range_copy/range_dup/
      	s/cell_region_render_ascii/cellregion_to_string/
      	s/clipboard_release/cellregion_free/
      
      	* src/commands.c (cmd_autofill) : Use sheet_range_contains_region.
      	(cmd_autofill_redo) : no need to test here.
      	(cmd_paste_cut) : test destination for validity and ensure that it
      	  does not slice up any merged regions or arrays.  Make the descriptor
      	  an argument so that other commands can use this one.
      	(cmd_ins_del_colrow_redo) : use colrow_max.
      	(cmd_area_set_text_redo) : use sheet_ranges_split_region.
      	(cmd_colrow_outline_change) : suppress warning.
      
      	* src/gui-clipboard.c (x_selection_to_cell_region) : simplify by using
      	  some of the convenience routines.
      
      	* src/gutils.c (gnumeric_sys_data_dir) : warning suppression.
      	(gnumeric_sys_lib_dir) : ditto.
      
      	* src/item-bar.c (item_bar_draw) : add missing warning.
      
      	* src/item-cursor.c (item_cursor_drag_event) : Don't assume the
      	  release came from the button that started the grab (think about
      	  multiple simultaneous button downs.
      	(item_cursor_selection_event) : ditto.
      	(item_cursor_do_drop) : changes to selection_first_range.
      
      	* src/parse-util.c (col_name_internal) : new routine split from
      	  col_name with better buffer handling.
      	(col_name) : used here.
      	(cols_name) : and in this new function.
      
      	* src/print.c (sheet_print_selection) : changes to
      	  selection_first_range.
      
      	* src/print-info.c (print_info_new) : default even_if_only_styles to
      	  false.  This is probably what most people want.
      
      	* src/ranges.c (range_translate) : don't invert.
      	(range_height) : new util.  could probably be #define.
      	(range_width) : new util.  could probably be #define.
      	(range_is_infinite) : use range_is_full.
      	(range_is_full) : new util.
      
      	* src/search.c (calculate_replacement) : warning suppression.
      
      	* src/selection.c (sheet_selection_cut) : Use
      	  sheet_range_splits_region and selection_first_range.
      	(sheet_selection_copy) : Use selection_first_range and remove TODO
      	  about supporting not paste by content for partial arrays.
      	(selection_first_range) : Add optional error reporting if there are
      	  multiple selection ranges.
      
      	* src/format.c (format_get_currency) : diddle the logic to get
      	  undefined to work the way people expect for locale C.
      
      	* src/sheet-merge.c (sheet_merge_relocate) : remove some dead code.
      	(sheet_merge_add) : changes to sheet_range_splits_array.
      
      	* src/sheet-object-widget.c (sheet_widget_checkbox_construct) :
      	  changes to selection_first_range.
      
      	* src/sheet.c (sheet_delete_{cols,rows}) : changes to
      	  sheet_range_splits_array.
      	(sheet_insert_{cols,rows}) : use sheet_range_splits_array.
      	(avoid_dividing_array_vertical) : delete.
      	(avoid_dividing_array_horizontal) : delete.
      	(sheet_is_pristine) : constness.
      	(sheet_mark_clean) : delete.
      	(sheet_clear_region) : changes to sheet_range_splits_array.
      	(sheet_ranges_split_region) : renamed from selection_check_for_array.
      	(sheet_range_splits_region) : new routine to check arrays and merged
      	  regions.
      	(sheet_range_splits_array) : improve and add hooks to be used for
      	  overlapping checks.
      	(cb_check_array_vertical) : report the array being split.
      	(cb_check_array_horizontal) : report the array being split.
      
      	* src/stf-parse.c (stf_parse_region) : use cellregion_new.
      	(stf_parse_is_valid_data) : simplify.
      
      	* src/value-sheet.c (value_area_get_width) : warning suppression.
      	(value_area_get_height) : warning suppression.
      	(value_area_fetch_x_y : signedness.
      	(value_area_get_x_y) : signedness.
      
      	* src/value.c (value_array_resize) : signedness.
      	(value_array_set) : signedness.
      
      	* src/workbook-control-gui.c (wbcg_error_splits_array) : signature
      	  change.
      	(cb_insert_rows) : use selection_first_range
      	(cb_insert_cols) : ditto.
      	(sort_cmd) : ditto.
      	(cb_workbook_debug_info) : clean out some deadwood.
      
      	* src/workbook-edit.c (auto_complete_matches) : warning suppression.
      
      	* src/workbook.c (workbook_sheet_detach) : warning suppression.
      	(g_ptr_array_insert) : warning suppression, moved to gutils.
      
      	* src/xml-io.c (xml_write_attributes) : warning suppression.
      	(xml_read_selection_clipboard) : use cellregion_new and tidyup.
      
      	* src/clipboard.c (paste_link) : Only make the link sheet specific if
      	  we need to.
      	(clipboard_paste_region) : constness, support being able to paste
      	  content only as link or value.
      	(clipboard_prepend_cell) : check for arrays.
      	(clipboard_copy_range) : use cellregion_new
      	(cellregion_new) : new function
      	(cellregion_free) : renamed from clipboard_release.
      	(cellregion_to_string) : moved here from render-ascii.
      
      	src/cmd-edit.c (cmd_paste) : more protection. Merge in
      	  application_paste.
      	(cmd_paste_to_selection) : handle changes to selection_is_simple and
      	  use selection_first_range
      	(cmd_shift_rows) : changes to cmd_paste_cut.
      	(cmd_shift_cols) : ditto.
      
      	* src/command-context-priv.h : change signature of splits array.
      	* src/command-context.h : ditto.
      	* src/command-context.c (gnumeric_error_splits_array) : ditto.
      
      	* src/application.c (application_clipboard_clear) :
      	(application_set_selected_sheet) : remove #warning, it is not portable.
      
      	* src/commands.c
      	* src/Makefile.am : remove render-ascii.[ch]  Move their content into
      	  clipboard.
      
      2001-05-01  Jody Goldberg <jgoldberg@home.com>
      
      	* src/clipboard.c (clipboard_prepend_cell) : remove ugly
      	  implementation.
      
      	* src/workbook-edit.c (auto_complete_matches) : remove warning.
      
      	* src/xml-io.c (xml_write_attributes) : remove warning.
      32bde6ee
  35. 15 Apr, 2001 1 commit
    • Almer S. Tigelaar's avatar
      Add detailed parser error messages. · fa7e253a
      Almer S. Tigelaar authored
      2001-04-15  Almer S. Tigelaar  <almer@gnome.org>
      
      	* src/parser.y : Add detailed parser error messages.
      
      	* src/workbook-edit.c (workbook_finish_editing) : Abort
      	if the expression is invalid and return a boolean indicating
      	success or failure.
      
      	* src/expr.c (expr_parse_string): Set error message to the
      	result of gnumeric_expr_parser.
      
      	* src/parse-util.c (parse_error_init) : Properly initialize
      	begin and end character.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet): Don't
      	change the cursor position if workbook_finish_editing failed.
      	(move_cursor): Idem.
      
      	* src/item-grid.c (item_grid_button_1): Idem.
      fa7e253a
  36. 11 Feb, 2001 1 commit
  37. 10 Dec, 2000 1 commit
    • Jody Goldberg's avatar
      comment out the warning. These the life cycles of names are too fluid to · e605d42e
      Jody Goldberg authored
      
      2000-12-10  Jody Goldberg <jgoldberg@home.com>
      
      	* src/expr-name.c (expr_name_invalidate_refs_sheet) : comment out the
      	  warning.  These the life cycles of names are too fluid to scare
      	  users yet.
      	(expr_name_invalidate_refs_wb) : Ditto.
      
      2000-12-10  Jody Goldberg <jgoldberg@home.com>
      
      	* src/cell.c (cell_set_text) : send the current format to the
      	  number matcher..
      	* src/sheet.c (sheet_cell_set_text) : Ditto.
      
      	* src/parse-util.c (parse_text_value_or_expr) : send the curent
      	  format to the number matcher.
      
      	* src/number-match.c (format_match) : take the current format as a
      	  parameter.  Begin using it to handle cells formated as text.
      
      	* src/format.c (style_format_is_text)  utility routine.
      
      2000-12-09  Jody Goldberg <jgoldberg@home.com>
      
      	* src/selection.c (sheet_selection_set_internal) : rename from
      	  sheet_selection_set and add the 'just_add_it' flag to indicate that
      	  we don't need to do anything fancy.
      e605d42e
  38. 09 Jul, 2000 1 commit
    • Jody Goldberg's avatar
      Take units in pixels or points. (sheet_{col,row}_set_default_size_pixels) · b519fbd3
      Jody Goldberg authored
      
      2000-07-09  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_col_row_default_init) : Take units in pixels or
      	  points.
      	(sheet_{col,row}_set_default_size_pixels) : new functions.  This
      	  interface sucks.  Clean it up.
      
      	* src/parser.y : Optionally insert a place holder when an
      	  unknown function is found.
      
      	* src/func.c (function_add_placeholder) : New function, moved from the
      	  XL import code.
      
      	* src/expr.c (expr_parse_string) : gnumeric_expr_parser signature
      	  change.
      	* src/workbook.c (workbook_set_auto_expr) : Ditto.
      
      	* src/application.c (application_dpi_to_pixels) : New function.
      	* src/item-bar.c (item_bar_fonts_init) : Use it here.
      	* src/sheet-view.c (sheet_view_get_style_font) : And here.
      	* src/style.c (font_init) : and here.
      
      2000-07-08  Jody Goldberg <jgoldberg@home.com>
      
      	* src/parse-util.c (cellref_r1c1_get) : Make stricter.
      	(r1c1_get_item) : Ditto.
      
      2000-07-08  Jody Goldberg <jgoldberg@home.com>
      
      	* plugins/Makefile.am (SUBDIRS) : Enable applix.
      
      2000-07-08  Jody Goldberg <jgoldberg@home.com>
      
      	* src/parse-util.c (col_from_name) : Add optional arg to indicate
      	  where parsing stoped.  Similar to strtod.
      
      2000-07-07  Jody Goldberg <jgoldberg@home.com>
      
      	* src/xml-io.c (xml_write_style_border) : Trivial optimization.  No
      	  need to save colour for STYLE_BORDER_NONE.
      	(xml_read_style_border) : Ditto.
      b519fbd3