1. 02 Apr, 2001 1 commit
  2. 31 Mar, 2001 1 commit
  3. 30 Mar, 2001 1 commit
    • Jody Goldberg's avatar
      A bunch of little fixes that get us closer to parsing the XL2k expense report · 221a65d2
      Jody Goldberg authored
      template.  There is a still a nagging problem with odd continue records in
      escher streams but they seem rare enough that we can ignore until a more
      illuminating test case shows up.
      2001-03-30  Jody Goldberg <jgoldberg@home.com>
      	* boot.c (excel_save) : clarify message.
      2001-03-29  Jody Goldberg <jgoldberg@home.com>
      	* ms-escher.c (ms_escher_read_Blip) : Fix leak plug.
      2001-03-29  Jody Goldberg <jgoldberg@home.com>
      	* ms-obj.c (ms_obj_read_biff8_obj) : It seems certain that the MS docs
      	  are wrong about list boxes.  I hope they don't do the same thing for
      	  other records too.
      	* ms-escher.c : s/ms_excel_read_debug/ms_excel_escher_debug/
      	(ms_escher_read_OPT) : Add missing OPT records and cleanup docs.
      	(ms_escher_read_BSE) : Document the record size and don't attempt to
      	  treat this as a container if its content is of size 0.
      2001-03-28  Jody Goldberg <jgoldberg@home.com>
      	* ms-obj.c (ms_read_TXO) : Fix the minor memory overrun morton found.
      2001-03-18  Jody Goldberg <jgoldberg@home.com>
      	* ms-excel-util.c (init_xl_font_widths) : recalculate the size of Geneva
      	  for the default case of Geneva not being available.
  4. 20 Mar, 2001 1 commit
    • Chyla Zbigniew's avatar
      Building excel plugin as shared library, added plugin.xml. · 098d1f56
      Chyla Zbigniew authored
      * Makefile.am:
      Building excel plugin as shared library, added plugin.xml.
      * boot.[ch]:
      xxx_debug variables from src/main.c moved here.
      Converted to real plugin with file_opener and file_saver services.
      * plugin.xml: New file.
      * gnumeric/plugins/excel/excel.h, plugins/excel/ms-chart.c,
      plugins/excel/ms-escher.c, plugins/excel/ms-excel-read.c,
      plugins/excel/ms-excel-read.h, plugins/excel/ms-excel-util.c,
      plugins/excel/ms-excel-write.c, plugins/excel/ms-excel-write.h,
      plugins/excel/ms-formula-read.c, plugins/excel/ms-formula-write.c,
      Adjusted function signatures, don't return TRUE/FALSE if using
      IOContext (we don't need boolean value as IOContext now sets
      "error_occurred" flag).
  5. 17 Mar, 2001 1 commit
    • Jody Goldberg's avatar
      Handle outline mode. (ms_excel_read_colinfo) : ditto. (ms_excel_read_guts) · e1a87d5f
      Jody Goldberg authored
      2001-03-15  Jody Goldberg <jgoldberg@home.com>
      	* ms-excel-read.c (ms_excel_read_row) : Handle outline mode.
      	(ms_excel_read_colinfo) : ditto.
      	(ms_excel_read_guts) : ditto.
      2001-03-16  Jody Goldberg <jgoldberg@home.com>
      	* src/item-bar.c (item_bar_calc_size) : rename from
      	* src/sheet-control-gui.c (scg_set_zoom_factor) : prepare for panes by
      	  zooming the col/row header canvases.  We need this as we transition
      	  to using gnumeric-sheets instead of canvases to hold the item-bars.
      2001-03-15  Jody Goldberg <jgoldberg@home.com>
      	* src/colrow.c (colrow_equal) : handle outline&collapse.
      	(colrow_copy) : ditto.
      	* src/item-bar.c (outline_button_press) : new function.
      	(item_bar_event) : used here.
      2001-03-15  Jody Goldberg <jgoldberg@home.com>
      	* src/item-bar.c (compute_pixels_from_pts) : new function.
      	(item_bar_fonts_init) : resize the indent gutters based on the zoom.
      	(item_bar_realize) : add another gc for outline drawing.
      	(item_bar_unrealize) : ditto.
      	(item_bar_draw) : implement drawing for groupings.
      	(set_cursor) : handle cursor in the presence of groupings.
      2001-03-14  Jody Goldberg <jgoldberg@home.com>
      	* Makefile.am : update the handling of the oaf file.
      	* src/sheet.c (sheet_col_row_default_calc) : rename from
      2001-03-13  Jody Goldberg <jgoldberg@home.com>
      	* src/xml-io.c (xml_write_print_repeat_range) : PrintRepeatRange now
      	  uses a simple Range.
      	(xml_read_print_repeat_range) : ditto.
      	* src/print-info.c (print_info_new) : ditto.
      	(save_range) : Ditto.
      	* src/dialogs/dialog-printer-setup.c (do_fetch_page_info) : ditto.
      	* src/print.c (print_range_used_units) : ditto.
      	(print_range_right_then_down) : ditto.
      	(print_range_down_then_right) : ditto.
      	(print_page_repeated_intersect) : ditto.
      	(print_page_repeated_cols) : ditto.
      	(print_page_repeated_rows) : ditto.
      	(print_page) : ditto.
      	* src/sheet-control-gui.c (scg_set_zoom_factor) : The sizing has moved
      	  into the itembar.
      	* src/item-bar.c : s/orientation/is_col_header/
      	(item_bar_fonts_init) : Init the ideal cell size.
      	(item_bar_update) : Begin to support grouping.
      	(item_bar_draw) : ditto.
      	(item_bar_init) : init the new members.
      	* src/print-cell.c (print_cell) : re-enable halign FILL.
      	* src/cell-draw.c (cell_draw) : ditto.
  6. 10 Feb, 2001 1 commit
    • Jody Goldberg's avatar
      don't free the object on failure. · 6b5d495b
      Jody Goldberg authored
      2001-02-09  Jody Goldberg <jgoldberg@home.com>
      	* ms-excel-read.c (ms_sheet_obj_create) : don't free the object on
      	* ms-obj.c (ms_read_OBJ) : free it here on failure.
      	* ms-container.c (ms_container_finalize) : fix leak.
  7. 01 Dec, 2000 1 commit
    • Jody Goldberg's avatar
      new function. (sheet_object_position_pixels) : new function. · f4cc38b8
      Jody Goldberg authored
      2000-12-01  Jody Goldberg <jgoldberg@home.com>
      	* src/sheet-object.c (sheet_object_position_pts) : new function.
      	(sheet_object_position_pixels) : new function.
      2000-11-30  Jody Goldberg <jgoldberg@home.com>
      	* src/xml-io.c : Begin moving the sheet object xml io into virtuals.
      2000-11-30  Jody Goldberg <jgoldberg@home.com>
      	* src/sheet.c : Add SHEET_FOREACH_CONTROL to help abstract the
      	  implementation of controls and simplify changes later.
      	(sheet_set_zoom_factor) : reposition objects not just comments.
      	(sheet_get_objects) : New function.
      2000-11-30  Jody Goldberg <jgoldberg@home.com>
      	* src/sheet-object.c : Move most (not yet all) of the GUI aspects into
      	  the sheet control.  Revamp the semantics of the sheet-object
      	new_view : now handles the sizing and realizing of objects.
      	Add support for persistance here.
      	Delete get/set bound.
      	* src/sheet-object-container.c : convert to new object management design
      	* src/sheet-object-graphic.c : Ditto.
      	* src/sheet-object-item.c : Ditto.
      	* src/sheet-object-widget.c : Ditto.
      	* src/sheet-object-bonobo.c (sheet_object_bonobo_construct) :
      	  sheet_object_construct now takes a default size.
      2000-11-30  Jody Goldberg <jgoldberg@home.com>
      	* src/sheet-control-gui.c : Move cell comment and sheet object
      	  placement routines here.  Rather than scattering them in non-gui
      2000-11-30  Jody Goldberg <jgoldberg@home.com>
      	* src/print.c (print_object_view_position) : Convert object position
      	  to points.
      	* src/selection.c (sheet_selection_redraw) : simplify.
      2000-11-30  Jody Goldberg <jgoldberg@home.com>
      	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_object) : SheetObject
      	  editing is now specific to the SheetControl.
      	(gnumeric_sheet_key_press) : Ditto.
      	(gnumeric_sheet_key_release) : Ditto.
      	* src/selection.c (sheet_is_cell_selected) : Ditto.
      	(sheet_col_selection_type) : Ditto.
      	(sheet_row_selection_type) : Ditto.
      	* src/item-bar.c (item_bar_draw) : Ditto.
      	* src/item-grid.c (item_grid_draw_background) : Ditto.
      	(item_grid_button_1) : Ditto.
      	(item_grid_event) : Ditto.
      	(cb_obj_create_motion) : Move the object creation GUI here.
      	(cb_obj_create_button_release) : and add partial support for
      	(sheet_object_begin_creation) : Ditto.
      2000-11-30  Jody Goldberg <jgoldberg@home.com>
      	* src/cell.c (cell_copy) : Comments are no longer associated directly
      	  with cells.
      	* src/clipboard.c (paste_cell) : Ditto.
      	(clipboard_release) : Ditto.
      	* src/bonobo-io.c (gnumeric_bonobo_obj_read) : No need to set bounds
      	  or realize the object here.  That is handed at a higher level.
      2000-11-30  Jody Goldberg <jgoldberg@home.com>
      	* src/number-match.c (compute_value) : Use strtol to simplify things.
      	* src/func.c (tokenized_help_new) : translate the help text.
      2000-11-27  Jody Goldberg <jgoldberg@home.com>
      	* src/formats.c (currency_date_format_init) : quote the currency
  8. 15 Nov, 2000 1 commit
    • Morten Welinder's avatar
      Remove trailing white-space from files that have it. · 5570aef3
      Morten Welinder authored
      (The following command was done in src/ and plugins/.  Note, that the
      grep has a space and a tab.)
      for i in `find . -name '*.[ch]' -print`; do if grep '[         ]$' $i >/dev/null; then echo $i; perl -pi -e 's/[ \t]+$//' $i; fi; done
  9. 21 Aug, 2000 1 commit
    • Jody Goldberg's avatar
      The format table nows stores pointers to StyleFormats rather than their · e83b0fd6
      Jody Goldberg authored
      2000-08-21  Jody Goldberg <jgoldberg@home.com>
      	* ms-excel-write.c (formats_init) : The format table nows stores
      	  pointers to StyleFormats rather than their strings.
      	(formats_get_format) : Ditto.
      	(formats_free) : Ditto.
      	(formats_get_index) : Ditto.
      	(put_format) : Ditto.
      	(write_format) : Ditto.
      	* ms-excel-read.c (biff_format_data_lookup) : Number formats are
      	  stored in XLS using the 'C' locale. eg a french user who sees
      	  '# ##0,00' will actually save '#,##0.00'.
      	(ms_excel_get_style_from_xf) : Kludge.  We need to actually set
      	  non-borders so that things get over ridden.  The core model needs
      	  improving before this can happen correctly.
      	(ms_excel_get_style_from_xf) : Ditto.
      	* ms-escher.c (ms_escher_read_Blip) : Remove gnorba.
      	* ms-chart.c (ai) : Changes to the interface for StyleFormats.
      	(ifmt) : Ditto.
      	(ms_excel_chart) : Init the sheet.  Ignore BIFF_DIMENSION records for
      	  now.  I have no idea what they represenent.
      2000-08-20  Jody Goldberg <jgoldberg@home.com>
      	* ms-excel-read.c (ms_excel_get_style_from_xf) : No need to use
      	  set_text.  Set the StyleFormat directly.
      2000-08-16  Jody Goldberg <jgoldberg@home.com>
      	* ms-excel-util.c (init_xl_font_widths) : Tweak Times New Roman
      	  to match observations.  It seems as if the size is non-linear :-(
      	  We'll need another round of measurements to account for this.
      2000-08-15  Jody Goldberg <jgoldberg@home.com>
      	* ms-chart.c (ms_excel_chart) : conditionalize debug info.
  10. 15 Jul, 2000 1 commit
    • Jody Goldberg's avatar
      Beginings of a some support for workbooks, and charts holding objects. · 8eaf2ce4
      Jody Goldberg authored
      2000-07-13  Jody Goldberg <jgoldberg@home.com>
      	* ms-container.c : Beginings of a some support for workbooks, and charts holding objects.
      	  Blips should become objects.
      	* *.c : adjust to using the container abstraction.
      2000-07-08  Jody Goldberg <jgoldberg@home.com>
      	* ms-formula-read.c (make_function) : Move the place holder handling
      	  into the core.
  11. 06 Jul, 2000 1 commit
    • Jody Goldberg's avatar
      Get the range selectors parsed correctly. · 2154ace1
      Jody Goldberg authored
      2000-07-06  Jody Goldberg <jgoldberg@home.com>
      	* ms-obj.c (ms_read_OBJ) : Take an ExcelSheet.
      	* ms-escher.c (ms_escher_read_ClientData) : ms_read_OBJ takes a sheet.
      	* ms-excel-read.c (ms_excel_read_sheet) : Ditto.
      	(ms_excel_read_workbook) : Ditto.
      	* ms-chart.c (3dbarshape) : A bit of research into probable values of
      	  the enum.
      	(ai) : After some thought this makes more sense.  We should only see
      	  an expression if we are linked to the workbook.  Similarly we should
      	  only see a format if one is specified.  We really need to avoid this
      	  kludge of needing a dummy sheet.
      	(areaformat) : Ignore colour index, use the stored colour.  Add some
      	  more debug info.
      	(lineformat) : Ditto.
      	(markerformat) : Ditto.
      	(ms_excel_chart) : Take an optional ExcelSheet.
      	  Parse BIFF_NUMBER records when they appear.
      	(ms_excel_read_chart) : Take an optional ExcelSheet.
  12. 05 Jul, 2000 1 commit
    • Michael Meeks's avatar
      implement. (write_mem_to_storage): implement. (create_xml_bonobo_stream): · ed8df623
      Michael Meeks authored
      2000-07-05  Michael Meeks  <michael@helixcode.com>
      	* src/bonobo-io.c (write_stream_to_storage): implement.
      	(write_mem_to_storage): implement.
      	(create_xml_bonobo_stream): create.
      	(hack_xmlSAXParseFile): copy from libxml.
      	* src/sheet-object.c (sheet_object_drop_file): update; this should
      	be totaly re-written.
      	* src/sheet-object-bonobo.c (sheet_object_bonobo_load): clean up.
      	* src/sheet-object-item.c (sheet_object_item_new): remove,
      	redundant; re-tool calls to sheet_object_container_new_object.
      	* src/sheet-object.c (create_object): rename the one use.
      	* src/sheet-object-container.c (sheet_object_container_new_from_object_id):
      	remove activation logic.
      	* src/sheet-object-bonobo.c (sheet_object_bonobo_destroy): free
      	object_id. (sheet_object_bonobo_construct): do activation in here.
      	(sheet_object_bonobo_get_object_iid): implement.
      	* src/sheet-object-container.c (sheet_object_container_new_from_goadid):
      	rename to (sheet_object_container_new_object): this.
      	* src/xml-io.c (xml_write_sheet_object): add bonobo io.
      	(xml_read_sheet_object): add bonobo and re-scope vars.
      	(xml_parse_ctx_new_full): implement.
      	* src/main.c (gnumeric_main): add bonobo_io_init.
      	* src/xml-io.c (xml_parse_ctx_init): implement,
      	(xml_parse_ctx_shutdown): ditto.
      	(xml_workbook_write): moved
      	(gnumeric_xml_write_workbook): s/parse_xml_context_t/XmlParseContext/
      	* src/xml-io.c (xml_workbook_read): publicise.
      	(xml_workbook_write): ditto.
      2000-07-04  Michael Meeks  <michael@helixcode.com>
      	* src/about.c (dialog_about): sort alphabeticaly.
  13. 05 Jun, 2000 1 commit
  14. 03 Jun, 2000 1 commit
    • Michael Meeks's avatar
      fix memory corruption bug with continue. · 2fff297d
      Michael Meeks authored
      2000-06-03  Michael Meeks  <michael@helixcode.com>
      	* ms-obj.c (ms_read_TXO): fix memory corruption bug with continue.
      	* ms-escher.c (ms_escher_read_Blip): update for Oaf.
      	* ms-biff.c (ms_biff_query_new): kill merging.
      	(ms_biff_merge_continues): kill forever.
      	(ms_biff_query_next_merge): rename to (ms_biff_query_next): and
      	clean. (ms_biff_query_unmerge): kill.
      2000-06-02  Michael Meeks  <michael@helixcode.com>
      	* ms-excel-read.c (biff_get_text): hack nasty auto-header
      	detection. (read_sst): split from (ms_excel_read_workbook).
      	(get_xtn_lens): split from (biff_get_text).
      	(get_utf8_chars, get_string, sst_boundcheck): implement.
      2000-01-31  Michael Meeks  <mmeeks@gnu.org>
      	* ms-obj.c (ms_read_TXO): re-implement to swallow CONTINUEs &
      	make safer.
      	* ms-biff.c (ms_biff_query_next_merge): hack do_merge = FALSE
      	for now; big clean possible later.
      	* ms-escher.c (ms_escher_read_Blip): always use image-generic;
      	it works, disable writing image files unless debugging.
      	(write_file): conditional compile out.
      	(ms_escher_get_data): add BIFF_CONTINUE.
      2000-01-30  Michael Meeks  <michael@mejm2.dow.cam.ac.uk>
      	* ms-excel-read.c (ms_excel_read_sheet): kill blank_sheet_pos.
  15. 20 Apr, 2000 1 commit
    • Jody Goldberg's avatar
      Reorg cell contents and assignment. · bedb925b
      Jody Goldberg authored
      Fixs lots of usability details.
      2000-04-20  Jody Goldberg <jgoldberg@home.com>
      	* src/dialogs/dialog-cell-format.c : Use the edit_pos as the example
      	  not the top left corner.
      	* src/functions/fn-stat.c (gnumeric_ftest) : Use eval_pos_cellref
      	  to help localize the strangeness.
      	(gnumeric_ttest) : Ditto.
      	* src/xml-io.c (xml_write_cell_and_position) : If this is an array
      	  expression and we are the top left then add attributes to indicate
      	  size of array.  Ignore the rest of the array.
      	(xml_not_used_old_array_spec) : New routinr to handle the old array format.
      	(xml_cell_set_array_expr) : store an array.
      	(xml_read_cell) : Handle the old and the new array formats.
      	* src/workbook.c (workbook_close_if_user_permits) : Accept input
      	(wb_edit_key_pressed) : Handle array formulas here.
      	(workbook_detach_sheet) : Do not recalc all if we are exiting.
      	(workbook_start_editing_at_cursor) : When we start editing an
      	  array formula display just the formula not all the extra {}()[][] crap.
      	* src/sheet.c (SheetPrivate) : Add a recompute_spans flag.
      	(sheet_calc_spans) : New routine.
      	(sheet_cell_calc_span) : New routine.
      	(sheet_range_calc_spans) : Renamed and extended from
      	(sheet_update) : Use sheet_calc_spans when necessary.
      	  Update the location region when the edit_pos changes.
      	(cb_recalc_spans_in_col) : Renamed from cb_collect_cells_in_col.
      	  Recalcs spans directly, no need to collect first.
      	(cb_set_cell_content) : New routine to set expr, or expr_and_value.
      	(sheet_range_set_text) : Use cb_set_cell_content, and remember
      	  chosen format with the cell rather than overriding the assigned
      	(sheet_cell_set_text) : Renamed from sheet_set_text.  Be more specific
      	  about how spans, rendering and the rest are handled.
      	(sheet_cell_set_expr) : New routine.
      	(sheet_cell_set_value) : Ditto.
      	(sheet_load_cell_val) : When displaying an array formula add {%s}()[][].
      	(sheet_redraw_cell_region) : Honour spans when redrawing.
      	(sheet_redraw_partial_row) : New routine.
      	(sheet_redraw_cell) : Ditto.
      	(sheet_is_cell_array) : Use cell_is_array.
      	(sheet_range_splits_array) : Renamed from sheet_check_for_partial_array.
      	(sheet_cell_add_to_hash) :  Do not touch spans at this point.
      	(sheet_cell_insert) : Rename from sheet_cell_add made recalc span
      	(sheet_cell_new) : New routine that does not touch spans.
      	(sheet_cell_remove) : Made redraw optional.
      	(cb_clear_cell_comments) : Remove the cell if there is no comment.
      	(sheet_clear_region) : Remove the cell if there are no comments or
      	  contents.  Flag an update of the status region.
      	* src/sheet-view.c (cb_colrow_resize) : New function.
      	(sheet_view_col_size_changed) : Resize all rows, irrespective of
      	(sheet_view_row_size_changed) : existing cells.
      	(sheet_view_redraw_cell_region) : This no longer honours spans.
      	* src/sheet-style.c (sheet_style_attach) : Removed call to redraw.
      	sheet_cells_update : rename to sheet_range_calc_spans and move to
      	* src/sheet-autofill.c (autofill_cell) : Use sheet_cell_set_value
      	  rather than set_text.
      	* src/selection.c (sheet_selection_changed_hook) : Delete.
      	(sheet_selection_extend_to) : Update the status region to display the
      	  new size.
      	(sheet_selection_cut) : Use sheet_range_splits_array.
      	(selection_check_for_array) : New routine.
      	* src/parser.y : Remove icky array formula parsing that conflicted
      	  with array entries.
      	* src/number-match.c (format_match) : Return a Value * rather than a
      	* src/mstyle.c (mstyle_set_font_size) : Do not allow font sizes < 1.
      	* src/main.c (gnumeric_main) : Do NOT create an empty workbook
      	  then delete it if things are successfully loaded.  This causes
      	  a global recalc.  Instead add a flag to disable exit when the
      	  number of workbooks go to zero.  Then only enable the flag AFTER
      	  we have attempted to load the initial workbooks.
      	* src/item-grid.c (item_grid_event) : Update the status_region when
      	  button-1 is release.  It should display the edit_pos.
      	* src/gutils.c : Move cell_name, col_name, col_from_name,
      	  parse_cell_name, parse_cell_name_or_range and parse_cell_name_list,
      	  to parse-util.c.
      	* src/gnumeric.h  : Add RenderedValue.
      	* src/gnumeric-util.c (gnumeric_char_start_expr_p) : Move
      	  to parse-util.c
      	* src/file.c (workbook_read) : Remove freese thaw usage.
      	  Move call to update AFTER mark clean.
      	* src/expr.c (eval_pos_init) : Take a cellpos.
      	(parse_pos_evalpos) : New routine.
      	(eval_pos_cellref) : There is some questionable code scattered in the
      	  functions.  This routing localizes the odd bits for correction.
      	* src/eval.c (cell_eval_content) : Use sheet_redraw_cell,
      	  and rendered_value_calc_size.
      	(cell_get_dependencies) : Improve constness.
      	* src/corba-sheet.c : Remove the freeze thaw operations.
      	(Sheet_cell_set_formula) : Deleted.
      	(Sheet_range_set_formula) : Delete.
      	* src/commands.c : Adjust so that registration of command auto
      	  calls redo.  Add misc checks for splitting arrays.
      	* src/clipboard.h : Move the CellCopy types here from cell.h
      	* src/clipboard.c (paste_cell) : Use cell_has_expr.
      	  Don't insert the new cell till after its contents are assigned.
      	* src/cellspan.c (cell_register_span) : Improve constness.
      	(cell_unregister_span) : Ditto.
      	(row_cell_get_displayed_at) : Delete.
      	(cell_calc_span) : Moved here from cell.c
      	* src/dialogs/dialog-stf.glade : Adjust the header background colour
      	  to match the purdy new icon.  Add the icon.
      	* src/cell-draw.c : Use the rendered_value routines.
      	  Improve constness.
      	* src/analysis-tools.c (set_cell) : Use sheet_cell_fetch.
      	    cell_set_* -> sheet_cell_set_
      	    cell_set_*_simple -> cell_set_
      	    Cell::{row,col} -> Cell::{row,col}_info
      	    cell_get_text -> cell_get_entered_text
      	    cell_get_content -> cell_get_entered_text
      	    cell_name -> cell_coord_name
      	    cell_get_formatted_val -> cell_get_rendered_text
      	    cell_get_content -> cell_get_entered_text
      	* src/cell.c :
      	(cell_dirty) : Renamed from cell_modified.  Use
      	(cell_formula_changed) : Make the queuing of the recalc optional.
      	(cell_cleanout) : Handle union of expression and entered_text,
      	  and remove the rendered value.
      	(cell_copy) : Ditto.
      	(cell_destroy) : handle cell_modified -> cell_dirty.
      	(cell_set_text) : Use parse_text_value_or_expr and store the prefered
      	(cell_set_text_and_value) : New routine.
      	(cell_assign_value) : New routine.
      	(cell_set_value) : Support formats.
      	(cell_set_expr_and_value) : New routine.
      	(cell_set_expr_internal) : Split from cell_set_expr.
      	(cell_set_expr) : Divide to allow for not queuing a recalc.
      	(cell_set_array_formula) : Use cell_set_expr_internal.
      	(cell_is_array) : New utility.
      	(cell_is_partial_array) : New utility.
      	(cell_has_expr) : New utility.
      	(cell_render_value) : Use rendered_value_*.
      	Move all comment routines into cell-comment.[ch].
      	* idl/Gnumeric.idl : Remove cell_set_formula, and range_set_formula.
      	  These were identical to set_text.  Made Workbook embeddable.
  16. 10 Apr, 2000 1 commit
    • Miguel de Icaza's avatar
      Do not destroy the context here, as it is dereferenced later in the · 30aba440
      Miguel de Icaza authored
      2000-04-07  Miguel de Icaza  <miguel@gnu.org>
      	* main.c (button_cancel): Do not destroy the context here, as it
      	is dereferenced later in the mainloop.
      2000-04-10  Miguel de Icaza  <miguel@gnu.org>
      	* Lots of files: replaces utils.h for gutils.h
      	* renamed utils.h to gutils.h to avoid the compilation problem on
      	some Unices (yes, fixing the Makefile would have done it, but
      	utils.h was still a lame name;  Of course gutils.h is not any
      	better, but it is now done).
      2000-04-07  Miguel de Icaza  <miguel@gnu.org>
      	* src/cellspan.c (span_remove): Pretify code.
  17. 07 Apr, 2000 1 commit
    • Jon K Hellan's avatar
      Replace member name with name_quoted and name_unquoted. In name_quoted, · 699e8bf7
      Jon K Hellan authored
      2000-04-08  Jon K Hellan  <hellan@acm.org>
              * src/sheet.h (struct _Sheet): Replace member name with
      	name_quoted and name_unquoted. In name_quoted, names with spaces
      	or quote characters are protected with quotes.
      	* src/analysis-tools.c (prepare_output): Use
      	workbook_sheet_get_free_name to ensure that we don't create more
      	than one sheet with the same name.
      	* src/eval.c (dump_cell_list, sheet_dump_dependencies): Dump
      	sheet->name_unquoted instead of sheet->name.
      	* src/expr-name.c (name_sheet_title): Make value from
      	sheet->name_quoted instead of sheet->name. FIXME: Is this correct?
      	* src/gnumeric-sheet.c (selection_insert_selection_string): Make
      	selection string from sheet->name_quoted instead of quoting
      	sheet->name here.
      	* src/print-info.c (render_tab): Render sheet->name_unquoted
      	instead of sheet->name.
      	* src/print-preview.c (create_toplevel): Use sheet->name_unquoted
      	instead of sheet->name in window title.
      	* src/selection.c (sheet_selection_to_string, range_to_string):
      	Make reference string from sheet->name_quoted instead of quoting
      	sheet->name here.
      	* src/sheet.[ch] (sheet_quote_name): Rename to
      	sheet_name_quote. Take name_unquoted parameter, not a sheet.
      	* src/sheet.c (sheet_rename, sheet_new): Set both
      	sheet->name_quoted and sheet->name_unquoted.
      	(sheet_destroy): Free both sheet->name_quoted and
      	(cellref_name): Make reference from sheet->name_quoted instead of
      	quoting sheet->name here.
      	* src/test.c (thrash_sheet): Use sheet->name_unquoted instead of
      	sheet->name in debug output.
      	* src/value-sheet.c (value_dump): Dump sheet->name_quoted instead
      	of quoting sheet->name here.
      	(encode_cellref): Use sheet->name_quoted instead of quoting
      	sheet->name here.
      	* src/workbook.[ch] (workbook_sheet_get_free_name): Make it more
      	generally useful: Add "base" and "always_suffix" parameters. The
      	caller should now select the base to make the name from
      	(e.g. "Sheet"), and specify whether or not a suffix should be
      	added when the name "base" is not in use.
      	* src/workbook.c (insert_sheet_cmd): Use new signature of
      	(workbook_rename_sheet): Insert unquoted name in hash table.
      	(sheet_label_text_changed_signal): Remove test for quote
      	characters in sheet name.
      	(sheet_action_delete_sheet): Prompt with name_unquoted instead of
      	(sheet_action_rename_sheet, workbook_attach_sheet): Use
      	name_unquoted instead on name.
      	(workbook_detach_sheet): Use sheet->name_unquoted as hash key
      	instead of sheet->name.
      	* src/workbook-cmd-format.c
      	(workbook_cmd_format_sheet_change_name): Use name_unquoted instead
      	on name.
      	* src/xml-io.c (xml_sheet_write): Output sheet->name_unquoted
      	instead of sheet->name.
      	* src/dialogs/dialog-sheet-order.c (dialog_sheet_order_impl): Make
      	list header passive.
      	(add_to_sheet_clist, delete_cb): Substitute sheet->name_unquoted
      	for sheet->name.
      	* src/dialogs/dialog-zoom.c (dialog_zoom_impl): Ditto.
      2000-04-08  Jon K Hellan  <hellan@acm.org>
      	* graphic-context.c (graphic_wizard_guess_series): Substitute
      	sheet->name_quoted for sheet->name.
      2000-04-08  Jon K Hellan  <hellan@acm.org>
      	* ms-excel-read.c (ms_excel_set_xf, ms_excel_read_formula,
      	ms_excel_read_sheet):  Use
      	gnum_sheet->name_unquoted instead of gnum_sheet->name in debug
      	(ms_excel_read_workbook): Remove unused variable to silence
      	* ms-excel-write.c (write_externsheets): Output
      	gnum_sheet->name_quoted instead of gnum_sheet->name. FIXME: Is
      	this correct?
      	(write_sheet): Use gnum_sheet->name_unquoted instead of
      	gnum_sheet->name in debug output.
      	(write_workbook): Output gnum_sheet->name_unquoted instead of
      	* ms-formula-read.c (ms_excel_parse_formula): Use
      	gnum_sheet->name_unquoted instead of gnum_sheet->name in debug
      	* ms-obj.c (object_anchor_to_position): Ditto.
      2000-04-08  Jon K Hellan  <hellan@acm.org>
      	* html.c (html_write_wb_html32, html_write_wb_html40): Output
      	sheet->name_unquoted instead of sheet->name.
      	(html_read): Gettextize sheet name template.
      	* latex.c (html_write_wb_latex, html_write_wb_latex2e):  Output
      	sheet->name_unquoted instead of sheet->name.
      	* roff.c (write_wb_roff): Ditto
      2000-04-08  Jon K Hellan  <hellan@acm.org>
      	* lotus.c (attach_sheet): Remove \n from sheet name. Gettextize
      	sheet name template.
      2000-04-08  Jon K Hellan  <hellan@acm.org>
      	* oleo.c (attach_sheet): Remove \n from sheet name. Gettextize
      	sheet name template.
      2000-04-08  Jon K Hellan  <hellan@acm.org>
      	* pln.c (pln_read_workbook): Use workbook_set_saveinfo instead of
      2000-04-08  Jon K Hellan  <hellan@acm.org>
      	* text-io.c (writeTextSheet): Output sheet->name_unquoted instead of
      	(readTextWorkbook): Ungettextize name of sheet to
      	create. text_parse_file is supposed to rename it.
  18. 04 Apr, 2000 1 commit
    • Jody Goldberg's avatar
      Bug 8315 · b7c58c38
      Jody Goldberg authored
      2000-04-04  Jody Goldberg <jgoldberg@home.com>
      	* ms-obj.c (ms_obj_read_biff8_obj) : Be more careful about when to
      	  dump debug info when the stated record size disagrees with the
  19. 24 Mar, 2000 1 commit
    • Jody Goldberg's avatar
      Update copywrite years. · 302aced7
      Jody Goldberg authored
      2000-03-24  Jody Goldberg <jgoldberg@home.com>
      	* *.[ch] : Update copywrite years.
      	* ms-obj.c (ms_read_OBJ) : improve debug output.
      	(ms_obj_read_biff8_obj) : Try a new heuristic for dealing with trailing IMDATA.
  20. 23 Mar, 2000 1 commit
  21. 22 Mar, 2000 1 commit
    • Jody Goldberg's avatar
      Fix span bugs. · 99ec14fe
      Jody Goldberg authored
      2000-03-22  Jody Goldberg <jgoldberg@home.com>
      	* src/sheet.c (sheet_reposition_comments) : Merged from
      	  sheet_reposition_comments_from_row and
      	(sheet_update) : New function.  Use the new update flags from
      	  SheetPrivate that are set in the col/row resize functions
      	  to do delayed resizing and updates.  This allows the resizing to be
      	  batched for an entire logical operation.
      	(sheet_{col,row}_set_size_pixels) : Set the update flags.
      	* src/workbook-cmd-format.c (workbook_cmd_format_{row,column}_auto_fit) : No need to
      	  worry about redraws.  Use sheet_update.
      	(workbook_cmd_format_{row_height,column_width}) : Ditto.
      	* src/sheet-view.c (sheet_view_redraw_cell_region) : No need to
      	  recalculate the spans,  Use the pre-calculated versions.
      	(sheet_view_col_size_changed) : Use sheet_update.
      	(sheet_view_row_size_changed) : Ditto.
      	* src/sheet-style.c (re_dimension_cells_cb) : Use cell_calc_dimensions.
      	(sheet_cells_update) : No need to redraw per cell and guess the bound.
      	  It is simpler and more correct to calc dimension per cell, and
      	  redraw the region BEFORE and AFTER to handle spans.
      	* src/cell.[ch] (cell_style_changed) : Delete.
      	* src/cell-draw.c (cell_draw) : continue syncing with print code.
      	  Be even more careful in the possible presence of style bugs.
      	* src/item-grid.c (item_grid_draw) : Ditto.
      	* src/print-cell.c (print_cell) : Ditto.
      	* src/analysis-tools.c (correlation_tool) : Use sheet_update.
      	(covariance_tool) : Ditto.
      	(ttest_paired_tool) : Ditto.
      	(ttest_eq_var_tool) : Ditto.
      	(ttest_neq_var_tool) : Ditto.
      	(ftest_tool) : Ditto.
      2000-03-21  Jody Goldberg <jgoldberg@home.com>
      	* src/sheet-private.h : Add status flags to accumulate state changes
      	  for later redraw.
      	* src/commands.c (cmd_format_redo) : Use sheet_update
      	  in case the row/col sizes changed due to font size changes.
      	(cmd_format_undo) : Ditto.
      	* src/widgets/gtk-combo-box.c (cb_state_change) : Only pseudo-prelight
      	  the display when over the arrow, not vice versa.
      	(gtk_combo_box_init) : Ditto.
      	(gtk_combo_box_set_display) : Ditto.
      	* src/sheet.c (sheet_row_get_distance_pts) : Enable reversed indicies.
      	(sheet_col_get_distance_pts) : Ditto.
      	* src/plugin.c (plugin_load) : Add more version checking to ensure
      	  that very old plugins that do not check their versions can not be
      2000-03-20  Jody Goldberg <jgoldberg@home.com>
      	* src/gnumeric-sheet.c (gnumeric_sheet_make_cell_visible) : When
      	  forcing a scroll do a hard reset of the visible ranges.
      	(gnumeric_sheet_compute_visible_ranges) : Ditto.
      	(gnumeric_sheet_set_top_row) : Remove extraneous scroll.
      	(gnumeric_sheet_set_left_col) : Remove extraneous scroll.
  22. 17 Mar, 2000 1 commit
    • Miguel de Icaza's avatar
      Change NULL to CORBA_OBJECT_NIL · 684c9df2
      Miguel de Icaza authored
      2000-03-13  Miguel de Icaza  <miguel@helixcode.com>
      	* src/sheet-vector.c (sheet_vectors_cell_changed): Change NULL to
      	* src/sheet-object-bonobo.c (sheet_object_bonobo_load_from_file):
      	Use the new IDL:Bonobo interface name, not the IDL:GNOME one
      	(sheet_object_bonobo_load_from_file): ditto.
      	(sheet_object_bonobo_load): ditto.
      	* src/sheet-object.c (sheet_set_mode_type): Temporary hack to get
      	the graphics working under 1:20 hours when my battery runs out of
      	* src/sheet-object-container.c
      	(sheet_object_container_new_from_goadid): Renamed from
      	(sheet_object_container_new): Now takes a BonoboObjectClient as an
      2000-03-12  Miguel de Icaza  <miguel@helixcode.com>
      	* src/sheet-vector.c (impl_vector_get_numbers): Increment idx
      	(impl_vector_get_vec_values): ditto.
      	(impl_vector_get_numbers): Use the proper values for the columns
      	(impl_vector_get_vec_values): ditto.
      	* src/clipboard.c (x_clipboard_bind_workbook): Fix memory leak.
      	The problem is worse, because the warning comment there was
      	completely bogus.
      2000-03-12  Miguel de Icaza  <miguel@helixcode.com>
      	* graphic-type.c (graphic_type_show_page): On page switch, set the
      	graphics type to the first one in there.
      	* graphic-context.c (data_range_new): Assing this guy.
  23. 14 Mar, 2000 1 commit
    • Jody Goldberg's avatar
      Still no time to research WHY the escher parsing is finding an unexpected · e61be055
      Jody Goldberg authored
      IMDATA record buried in the stream, but at least the code will be more
      resistant to parse errors.
      2000-03-14  Jody Goldberg <jgoldberg@home.com>
      	* ms-excel-read.c (biff_xf_data_new) : Remove warning about parent
      	  styles not == 0.  I finally understand what the semantics of this
      	  are.  Style 0 is 'Normal' this test was doing nothing accept
      	  discriminating agains 'Comma' and its friends.  We need to extend
      	  the gnumeric notion of styles to include the limited form of
      	  inheritance embodied by XL.
      	* ms-obj.c (object_anchor_to_position) : Be VERY careful.
  24. 13 Mar, 2000 3 commits
  25. 16 Feb, 2000 2 commits
  26. 13 Feb, 2000 1 commit
    • Jody Goldberg's avatar
      Major rationalization of pts vs pixels and the use of margins. · b6d04cff
      Jody Goldberg authored
      Some redraw speedups and the addition of XL2000 style alpha bended selections.
      2000-02-13  Jody Goldberg <jgoldberg@home.com>
      	* ./src/sheet-view.c (sheet_view_redraw_cell_region) : redraw the
      	  bounding grid lines too.
      	* src/item-cursor.c (item_cursor_get_pixel_coords) : Clip the cursor
      	  region to the visible range.  The layout still needs cleaning to
      	  match the 'correct' way of implementing canvas-items, but this
      	  heuristic saves us lots of iterations through the accumulator for
      	  the size of the entire sheet.
      2000-02-12  Jody Goldberg <jgoldberg@home.com>
      	* src/gnumeric-sheet.c : Use visible flag and adjust to naming and
      	  margin changes.
      	* src/item-bar.c (colrow_tip_setlabel) : Use the format provided by
      	  XL2000.  Things are correct for rows, colwidth are quoted in pts
      	  rather than char widths.
      	(get_col_from_pos) : Use visible flag.
      	(item_bar_start_resize) : Function renaming.
      	(is_pointer_on_division) : Ditto.
      	(item_bar_draw) : Changes to margins.
      	* src/item-edit.c : Function renaming.
      	* src/item-cursor.c : Ditto.  decrease spacing for auto handle.
      	* src/item-grid.c (item_grid_draw) : Remove inversion process for the
      	  selection.  Instead have the cells draw their background
      	  differently.  Use the visible flag.
      	(item_grid_paint_empty_cell) : Ditto.
      	(item_grid_paint_cell) : Ditto.
      	* src/mstyle.c (mstyle_new_default) : The default vert alignment is BOTTOM.
      	* src/pattern.c (gnumeric_background_set_gc) : Draw the background of
      	  a selected cell differently.
      	* src/print-cell.c (DIM) : margins are already included.
      	(print_cell_text) : Adjust argument order to more closely match
      	  cell_draw.  Add support for vertical alignment of 1 line cells.
      	  Invert control of single vs multiple lines.
      	(print_cell) : Adjust to changes in the arguments.
      	(print_cell_range) : Use the visible flag.
      	  Draw line at the boundary rather than pretending there were
      	  additional rows/cols.
      	* src/print.c (compute_groups) : size_pts INCLUDES margins.  Use 'visible' flag.
      	(print_page) : Adjust to function renaming.
      	(print_range_used_units) : Ditto.
      	* src/selection.c : Include sheet-view directly for now.
      	(cb_set_row_height) : Adjust to function renaming.
      	* src/sheet-view.c (sheet_view_redraw_cell_region) : Adjust to function
      	(sheet_view_redraw_headers) : Ditto.
      	(sheet_view_set_zoom_factor) : Ditto.
      	(sheet_view_col_size_changed) : Ditto.
      	(sheet_view_row_size_changed) : Ditto.
      	(sheet_view_comment_get_points) : Ditto.
      	* src/sheet.[ch] : Rationalize function names, and add glossary.
      	Make the use of margins and sizes (in points and pixels) consistant.
      	(sheet_col_get_external_width : Delete.
      	(sheet_row_get_external_height : Delete.
      	(sheet_col_get_distance : Rename sheet_col_get_distance_pixels.
      	(sheet_row_get_distance : Rename sheet_row_get_distance_pixels.
      	(sheet_row_get_unit_distance : Rename sheet_row_get_distance_pts.
      	(sheet_col_get_unit_distance : Rename sheet_col_get_distance_pts.
      	(sheet_col_set_width : Rename sheet_col_set_size_pixels.
      	(sheet_col_set_width_units : Rename sheet_col_set_size_pts.
      	(sheet_row_set_height : Rename sheet_row_set_size_pixels.
      	(sheet_row_set_height_units) : Rename sheet_row_set_size_pts.
      	(sheet_get_default_external_col_width) : Rename sheet_col_get_default_size_pts.
      	(sheet_get_default_external_row_height): Rename sheet_row_get_default_size_pts.
      	(sheet_col_set_internal_width) : sheet_col_set_internal_size_pts.
      	(sheet_row_set_internal_height): sheet_row_set_internal_size_pts.
      	(sheet_{row,col}_set_default_size_pts) : New functions.
      	(sheet_init_default_styles) : Tune to match XL defaults.
      	* src/sort.c : Use g_strcasecmp, and include <stdlib.h>
      	* src/style.c (style_color_new) : Init the selection colour as a 50%
      	  alpha blend with lavender.
      	* src/style.h : Change default font to be Helvetica 9 because it will
      	  scale better when the standard 96 dpi resolution is assumed.
      	  Add a selected_color to StyleColor.
      	* src/value-sheet.c : Include <gnome.h> to get the
      	  internationalization support.
      	* src/workbook-cmd-format.c (workbook_cmd_format_column_auto_fit) :
      	  sheet_col_set_width -> sheet_col_set_size_pixels.
      	(workbook_cmd_format_column_width) :
      	  sheet_col_set_width_units -> sheet_col_set_size_pts.
      	(workbook_cmd_format_row_auto_fit) :
                sheet_row_set_height -> sheet_row_set_size_pixels
      	(workbook_cmd_format_row_height) :
      	  sheet_row_set_height_units -> sheet_row_set_size_pts.
      	* src/xml-io.c (xml_read_rows_info) : Rename
      	  sheet_row_set_height_units -> sheet_row_set_size_pts.
      	(xml_read_cols_info) : Rename
      	  sheet_col_set_height_units -> sheet_col_set_size_pts.
      	(xml_read_colrow_info) : Remove hack with negative pixels.
      	  Use 'visible' flag instead.
      	(xml_write_colrow_info) : Ditto.
  27. 10 Feb, 2000 1 commit
    • Jody Goldberg's avatar
      Remove inclusion of cell.h. Adjust includes to loosen things a bit more. · f6b62c13
      Jody Goldberg authored
      2000-02-10  Jody Goldberg <jgoldberg@home.com>
      	* src/sheet.h : Remove inclusion of cell.h.  Adjust includes to loosen
      	  things a bit more.
      	* src/colrow.h : Remove margin_a_pt margin_b_pt.  Margins are NOT
      	  scaled by resolution or zoom.
      	  Rename units -> size_pts and store as float rather than double.
      	  Rename pixels-> size_pixels
      	  hard_size -> use gboolean rather than a 1 element bitfield
      	* src/style.h : Move the typedefs from here.
      	* src/gnumeric.h : to here.
      	*.[ch] : Catch up with the renames and include changes.
  28. 11 Jan, 2000 1 commit
    • Jody Goldberg's avatar
      - Fake scale the sheet to make it les ugly until we figure out the real scale · 31007466
      Jody Goldberg authored
        factors MS uses.
      - Size the window better.
      - Explicitly leak the memory associated with the comments in XL97.  Hopefully,
        someone will fix it.
      2000-01-10  Jody Goldberg <jgoldberg@home.com>
      	* ms-obj.c (ms_read_TXO) : Return the string generated rather than
      	  leaking it.
      	(ms_read_OBJ) : Don't warn about comments, they are not sheet objects
      	  which breaks the whole function of this routine but they are not
      	  unexpected.  If we can figur eout how to store the string associated
      	  with the TXO nearby with this object and get that cleaned up on
      	  time and referencable by obj-ID then we can fix comment import.
      	* ms-excel-read.c (ms_excel_read_sheet) : Improve handling for
      	  WINDOW1 and warn about more unsupported cases.  Tweak zoom factor
      	  by 1.4 to be less ugly. (ICK !  HACK!)
      	(ms_excel_read_workbook) : WINDOW2 is a sheet level
      	  descriptor.  Add handle for WINDOW1.
      	(ms_excel_sheet_new) : ICK!  hard code a scale
      	  factor of 1.4 to get things to be less ugly.
  29. 29 Dec, 1999 1 commit
    • Jody Goldberg's avatar
      - Initial usage of the new exception mechanisms. · f8206c57
      Jody Goldberg authored
      - Improve versioning of the plugins.
      - Some bug fixes.
      1999-12-29  Jody Goldberg <jgoldberg@home.com>
      	* src/workbook-view.c (command_context_gui,
      				command_context_gui_cast) : New functions.
      	* src/workbook.c (workbook_new) : Switch to using the workbook_view
      	  routines to manipulate the undo/redo and paste/paste_special menu
      	* src/func.c (function_iterate_argument_values) : Return an error
      	  for empty/missing arguments.
      	* plugins/*/Makefile.am : Define GNUMERIC_VERSION.
      	* plugins/*/*.c (init_plugin): Take a CmdContext for error reporting.
      	  Call plugin_version_mismatch to do some minimal version matching for
      	  plugins and the running application.
      	* src/Gnumeric.idl : Add PluginProblem.
      	* src/command-context.[ch] (gnumeric_error_splits_array,
      				    command_context_vtbl_init) : New functions.
      	* src/plugin.c (plugin_version_mismatch) : New function.
      	  (plugin_load) : Hard code a GUI context for now.
      	                  Switch to using gnumeric_error_ routines.
      			  Pass a CmdContext to the init_plugin routines.
      			  Only produce an error if the plugin returns -1.
      			  Store the plugin filename.
      	  (plugin_unload) : Free the filename on exit.
      	* *.c : command_context_gui now takes a Workbook argument.
      	      : Switch from gnumeric_no_modify_array_notice
      	                 to gnumeric_error_splits_array in most places.
  30. 15 Dec, 1999 1 commit
  31. 26 Nov, 1999 1 commit
  32. 19 Nov, 1999 2 commits
  33. 08 Oct, 1999 3 commits
  34. 03 Oct, 1999 1 commit