Commit d75d6949 authored by Jody Goldberg's avatar Jody Goldberg Committed by Jody Goldberg

a null string is not a missing arg.


2001-04-11  Jody Goldberg <jgoldberg@home.com>

	* ms-formula-write.c (write_string) : a null string is not a missing
	  arg.
parent 034b1949
2001-04-11 Jody Goldberg <jgoldberg@home.com>
* ms-formula-write.c (write_string) : a null string is not a missing
arg.
2001-04-04 Jody Goldberg <jgoldberg@home.com>
* ms-excel-read.c (ms_excel_externsheet) : new function split from
......
......@@ -1275,11 +1275,15 @@ ms_excel_parse_formula (ExcelWorkbook *wb, ExcelSheet *sheet, guint8 const *mem,
{
str = biff_get_text (cur+2, MS_OLE_GET_GUINT16(cur), &len) ;
ptg_length = 2 + len ;
/* printf ("v8+ PTG_STR '%s'\n", str) ; */
#if 0
printf ("v8+ PTG_STR '%s'\n", str) ;
#endif
} else {
str = biff_get_text (cur+1, MS_OLE_GET_GUINT8(cur), &len) ;
ptg_length = 1 + len ;
/* printf ("<v7 PTG_STR '%s' len %d ptglen %d\n", str, len, ptg_length) ; */
#if 0
printf ("<v7 PTG_STR '%s' len %d ptglen %d\n", str, len, ptg_length);
#endif
}
if (!str) str = g_strdup("");
parse_list_push_raw (&stack, value_new_string (str));
......
......@@ -341,7 +341,8 @@ write_cellref_v8 (PolishData *pd, const CellRef *ref,
static void
write_string (PolishData *pd, const gchar *txt)
{
if (!txt || txt[0] == '\0')
/* FIXME : Check this logic. Why would we pass a NULL ? */
if (txt == NULL)
push_guint8 (pd, FORMULA_PTG_MISSARG);
else {
push_guint8 (pd, FORMULA_PTG_STR);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment