Commit c48ba606 authored by Jody Goldberg's avatar Jody Goldberg

Revert BUGS and regess.gnumeric entries

INT and FLOOR are correct.

Document a more serious problem.  Names appear to be written in
the wrong locale.
parent 94951885
......@@ -4,7 +4,9 @@ and longer term bugs.
Release Critical
----------------
- Delete sheet does not clear cells from recalc queue.
- Delete sheet does not properly clear deleted cells from the depend lists of
the remainder.
- FALSE is written in a locale specific format. Apparently so are number formats.
Long term breakage
------------------
......@@ -56,7 +58,6 @@ Dialogs
Function Breakage
-----------------
- Index : does not support 0,0 or reference syntax.
- INT and FLOOR : INT seems to be FLOOR and vise versa.
Printing
--------
......
2000-05-15 Jody Goldberg <jgoldberg@home.com>
* src/functions/fn-math.c (gnumeric_floor) : Add some examples for
negatives.
2000-05-15 Karl Eichwalder <ke@suse.de>
* NEWS (Translations): Add de, no, and sv.
......
2000-05-15 Jody Goldberg <jgoldberg@home.com>
* src/functions/fn-math.c (gnumeric_floor) : Add some examples for
negatives.
2000-05-15 Karl Eichwalder <ke@suse.de>
* NEWS (Translations): Add de, no, and sv.
......
2000-05-15 Jody Goldberg <jgoldberg@home.com>
* src/functions/fn-math.c (gnumeric_floor) : Add some examples for
negatives.
2000-05-15 Karl Eichwalder <ke@suse.de>
* NEWS (Translations): Add de, no, and sv.
......
2000-05-15 Jody Goldberg <jgoldberg@home.com>
* src/functions/fn-math.c (gnumeric_floor) : Add some examples for
negatives.
2000-05-15 Karl Eichwalder <ke@suse.de>
* NEWS (Translations): Add de, no, and sv.
......
2000-05-15 Jody Goldberg <jgoldberg@home.com>
* src/functions/fn-math.c (gnumeric_floor) : Add some examples for
negatives.
2000-05-15 Karl Eichwalder <ke@suse.de>
* NEWS (Translations): Add de, no, and sv.
......
2000-05-15 Jody Goldberg <jgoldberg@home.com>
* src/functions/fn-math.c (gnumeric_floor) : Add some examples for
negatives.
2000-05-15 Karl Eichwalder <ke@suse.de>
* NEWS (Translations): Add de, no, and sv.
......
2000-05-15 Jody Goldberg <jgoldberg@home.com>
* src/functions/fn-math.c (gnumeric_floor) : Add some examples for
negatives.
2000-05-15 Karl Eichwalder <ke@suse.de>
* NEWS (Translations): Add de, no, and sv.
......
......@@ -963,6 +963,8 @@ static char *help_floor = {
"@EXAMPLES=\n"
"FLOOR(0.5) equals 0.\n"
"FLOOR(5,2) equals 4.\n"
"FLOOR(-5,-2) equals -4.\n"
"FLOOR(-5,2) equals #NUM!.\n"
"\n"
"@SEEALSO=CEIL, ABS, INT")
};
......@@ -975,11 +977,10 @@ gnumeric_floor (FunctionEvalInfo *ei, Value **argv)
number = value_get_as_float (argv[0]);
if (argv[1] == NULL)
s = (number >= 0) ? 1.0 : -1.0;
else {
else
s = value_get_as_float (argv[1]);
}
if (s == 0 || number / s < 0)
if (s == 0 || (number / s) < 0)
return value_new_error (ei->pos, gnumeric_err_NUM);
return value_new_float (floor (number / s) * s);
......
No preview for this file type
......@@ -963,6 +963,8 @@ static char *help_floor = {
"@EXAMPLES=\n"
"FLOOR(0.5) equals 0.\n"
"FLOOR(5,2) equals 4.\n"
"FLOOR(-5,-2) equals -4.\n"
"FLOOR(-5,2) equals #NUM!.\n"
"\n"
"@SEEALSO=CEIL, ABS, INT")
};
......@@ -975,11 +977,10 @@ gnumeric_floor (FunctionEvalInfo *ei, Value **argv)
number = value_get_as_float (argv[0]);
if (argv[1] == NULL)
s = (number >= 0) ? 1.0 : -1.0;
else {
else
s = value_get_as_float (argv[1]);
}
if (s == 0 || number / s < 0)
if (s == 0 || (number / s) < 0)
return value_new_error (ei->pos, gnumeric_err_NUM);
return value_new_float (floor (number / s) * s);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment