Commit c2af08a9 authored by Jody Goldberg's avatar Jody Goldberg Committed by Jody Goldberg

Constness.

2000-03-10  Jody Goldberg <jgoldberg@home.com>

	* src/func.c (tokenized_help_new) : Constness.

	* src/widgets/gtk-combo-box.c (cb_state_change) : New function to keep
	  the state of the combo display button and the combo arrow in sync.
	(gtk_combo_box_init) : Connect cb_state_change to the arrow.
	(gtk_combo_box_set_display) : Ditto for the display widget.

	* src/sheet.c (sheet_set_zoom_factor) : Bound the factor at 10% and 500%

	* src/workbook.c (change_zoom_in_current_sheet_cb) :
	  call change_displayed_zoom_cb to adjust the combo to contain the
	(workbook_focus_current_sheet) : Only emit signal if the sheet
	  changed.

2000-03-08  Jody Goldberg <jgoldberg@home.com>

	* src/collect.c (callback_function_collect) : Treat arrays and ranges
	  as errors.

	* src/format.c (format_value) : formating a range returns a
	  #VALUE! message.

	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) :
	  Use the workbook flags, and delete the icky globals.
	(start_cell_selection_at) : Hide the std cursor when a cell selection
	  cursor is created.
	(gnumeric_sheet_stop_cell_selection) : Restore the std cursor.

2000-03-07  Jody Goldberg <jgoldberg@home.com>

	* src/workbook.c (accept_input) : Use workbook_finish_editing.
	(cancel_input) : Ditto.
	(do_focus_sheet) : Support range selection across spreadsheets.
	(workbook_get_sheet_position) : Fix and document.
	(workbook_move_sheet) : Fix.
	(workbook_focus_sheet) : Handle errors cleanly.
	(wb_edit_key_pressed) : Improve F4 handling.
	(wizard_input) : Begin non-modal function wizard.  NOT FINSIHED.
	(workbook_start_editing_at_cursor) : transfered from
	  sheet_start_editing_at_cursor.
	(workbook_finish_editing) : Distilled from sheet_{accept,cancel}_pending_input.
	(Workbook) : Add editing_cell, editing_sheet, editing.

	* src/sheet.c (sheet_stop_editing) : Delete.
	(sheet_accept_pending_input) : Merge into workbook_finish_editing.
	(sheet_cancel_pending_input) : Ditto.
	(sheet_start_editing_at_cursor) :
	(sheet_create_edit_cursor) : New function.
	(sheet_destroy_edit_cursor) : New function.
	(sheet_destroy_cell_select_cursor) :  New function.
	(Sheet) : Delete editing and editing_cell.

	* src/selection.c (sheet_selection_changed_hook) : Make public.  This
	  should eventually move but I'm not sure where.  It is used for more
	  than just changes in the selection in the current sheet.  It must
	  also be called when the sheet changes.  What it REALLY does it to
	  sync the shared workbook state with the current sheet's selection.

	* src/item-cursor.c (item_cursor_init) : Handle change from
	  sheet_accept_pending_input -> workbook_finish_editing.
	* src/item-grid.c (item_grid_button_1) : Ditto.

	* src/gnumeric-sheet.c (gnumeric_sheet_can_move_cursor) : Edit moved
	  from sheet -> workbook.
	(selection_insert_selection_string) : Extend to support
	  abs/rel refs and intersheet-refs.
	(gnumeric_sheet_stop_cell_selection) : Add clear_string argument
	  to optionally remove the selection range.
	(gnumeric_sheet_key_mode_sheet) : Adjust to movement of editing flag
	  from sheet -> workbook.  Be careful to use the original sheet when
	  moving rather than the current sheet.  Support F4 while editing.

	* src/cell-draw.c (cell_draw) : editing_cell has moved from sheet to
	  workbook.  Fix font ref leak when drawing the edit cell.

	* src/dialogs/dialog-function-wizard.c : Begin transition to being
	  non-modal.  NOT FINISHED.
parent 48d3fa02
......@@ -12,3 +12,5 @@ Long term breakage
------------------
- border style double_line does handle all of the different intersection cases.
- 'General' numbers need to be formated based on the width of the cell.
- Need to ensure that selecting cell ranges for formulas keep extension visible
and restores it when done.
2000-03-10 Jody Goldberg <jgoldberg@home.com>
* src/func.c (tokenized_help_new) : Constness.
* src/widgets/gtk-combo-box.c (cb_state_change) : New function to keep
the state of the combo display button and the combo arrow in sync.
(gtk_combo_box_init) : Connect cb_state_change to the arrow.
(gtk_combo_box_set_display) : Ditto for the display widget.
* src/sheet.c (sheet_set_zoom_factor) : Bound the factor at 10% and 500%
* src/workbook.c (change_zoom_in_current_sheet_cb) :
call change_displayed_zoom_cb to adjust the combo to contain the
(workbook_focus_current_sheet) : Only emit signal if the sheet
changed.
2000-03-08 Jody Goldberg <jgoldberg@home.com>
* src/collect.c (callback_function_collect) : Treat arrays and ranges
as errors.
* src/format.c (format_value) : formating a range returns a
#VALUE! message.
* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) :
Use the workbook flags, and delete the icky globals.
(start_cell_selection_at) : Hide the std cursor when a cell selection
cursor is created.
(gnumeric_sheet_stop_cell_selection) : Restore the std cursor.
2000-03-07 Jody Goldberg <jgoldberg@home.com>
* src/workbook.c (accept_input) : Use workbook_finish_editing.
(cancel_input) : Ditto.
(do_focus_sheet) : Support range selection across spreadsheets.
(workbook_get_sheet_position) : Fix and document.
(workbook_move_sheet) : Fix.
(workbook_focus_sheet) : Handle errors cleanly.
(wb_edit_key_pressed) : Improve F4 handling.
(wizard_input) : Begin non-modal function wizard. NOT FINSIHED.
(workbook_start_editing_at_cursor) : transfered from
sheet_start_editing_at_cursor.
(workbook_finish_editing) : Distilled from sheet_{accept,cancel}_pending_input.
(Workbook) : Add editing_cell, editing_sheet, editing.
* src/sheet.c (sheet_stop_editing) : Delete.
(sheet_accept_pending_input) : Merge into workbook_finish_editing.
(sheet_cancel_pending_input) : Ditto.
(sheet_start_editing_at_cursor) :
(sheet_create_edit_cursor) : New function.
(sheet_destroy_edit_cursor) : New function.
(sheet_destroy_cell_select_cursor) : New function.
(Sheet) : Delete editing and editing_cell.
* src/selection.c (sheet_selection_changed_hook) : Make public. This
should eventually move but I'm not sure where. It is used for more
than just changes in the selection in the current sheet. It must
also be called when the sheet changes. What it REALLY does it to
sync the shared workbook state with the current sheet's selection.
* src/item-cursor.c (item_cursor_init) : Handle change from
sheet_accept_pending_input -> workbook_finish_editing.
* src/item-grid.c (item_grid_button_1) : Ditto.
* src/gnumeric-sheet.c (gnumeric_sheet_can_move_cursor) : Edit moved
from sheet -> workbook.
(selection_insert_selection_string) : Extend to support
abs/rel refs and intersheet-refs.
(gnumeric_sheet_stop_cell_selection) : Add clear_string argument
to optionally remove the selection range.
(gnumeric_sheet_key_mode_sheet) : Adjust to movement of editing flag
from sheet -> workbook. Be careful to use the original sheet when
moving rather than the current sheet. Support F4 while editing.
* src/cell-draw.c (cell_draw) : editing_cell has moved from sheet to
workbook. Fix font ref leak when drawing the edit cell.
* src/dialogs/dialog-function-wizard.c : Begin transition to being
non-modal. NOT FINISHED.
2000-03-10 Michael Meeks <michael@helixcode.com>
* src/Makefile.am (sheet-vector.h): make it depend on Gnumeric.h
......
2000-03-10 Jody Goldberg <jgoldberg@home.com>
* src/func.c (tokenized_help_new) : Constness.
* src/widgets/gtk-combo-box.c (cb_state_change) : New function to keep
the state of the combo display button and the combo arrow in sync.
(gtk_combo_box_init) : Connect cb_state_change to the arrow.
(gtk_combo_box_set_display) : Ditto for the display widget.
* src/sheet.c (sheet_set_zoom_factor) : Bound the factor at 10% and 500%
* src/workbook.c (change_zoom_in_current_sheet_cb) :
call change_displayed_zoom_cb to adjust the combo to contain the
(workbook_focus_current_sheet) : Only emit signal if the sheet
changed.
2000-03-08 Jody Goldberg <jgoldberg@home.com>
* src/collect.c (callback_function_collect) : Treat arrays and ranges
as errors.
* src/format.c (format_value) : formating a range returns a
#VALUE! message.
* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) :
Use the workbook flags, and delete the icky globals.
(start_cell_selection_at) : Hide the std cursor when a cell selection
cursor is created.
(gnumeric_sheet_stop_cell_selection) : Restore the std cursor.
2000-03-07 Jody Goldberg <jgoldberg@home.com>
* src/workbook.c (accept_input) : Use workbook_finish_editing.
(cancel_input) : Ditto.
(do_focus_sheet) : Support range selection across spreadsheets.
(workbook_get_sheet_position) : Fix and document.
(workbook_move_sheet) : Fix.
(workbook_focus_sheet) : Handle errors cleanly.
(wb_edit_key_pressed) : Improve F4 handling.
(wizard_input) : Begin non-modal function wizard. NOT FINSIHED.
(workbook_start_editing_at_cursor) : transfered from
sheet_start_editing_at_cursor.
(workbook_finish_editing) : Distilled from sheet_{accept,cancel}_pending_input.
(Workbook) : Add editing_cell, editing_sheet, editing.
* src/sheet.c (sheet_stop_editing) : Delete.
(sheet_accept_pending_input) : Merge into workbook_finish_editing.
(sheet_cancel_pending_input) : Ditto.
(sheet_start_editing_at_cursor) :
(sheet_create_edit_cursor) : New function.
(sheet_destroy_edit_cursor) : New function.
(sheet_destroy_cell_select_cursor) : New function.
(Sheet) : Delete editing and editing_cell.
* src/selection.c (sheet_selection_changed_hook) : Make public. This
should eventually move but I'm not sure where. It is used for more
than just changes in the selection in the current sheet. It must
also be called when the sheet changes. What it REALLY does it to
sync the shared workbook state with the current sheet's selection.
* src/item-cursor.c (item_cursor_init) : Handle change from
sheet_accept_pending_input -> workbook_finish_editing.
* src/item-grid.c (item_grid_button_1) : Ditto.
* src/gnumeric-sheet.c (gnumeric_sheet_can_move_cursor) : Edit moved
from sheet -> workbook.
(selection_insert_selection_string) : Extend to support
abs/rel refs and intersheet-refs.
(gnumeric_sheet_stop_cell_selection) : Add clear_string argument
to optionally remove the selection range.
(gnumeric_sheet_key_mode_sheet) : Adjust to movement of editing flag
from sheet -> workbook. Be careful to use the original sheet when
moving rather than the current sheet. Support F4 while editing.
* src/cell-draw.c (cell_draw) : editing_cell has moved from sheet to
workbook. Fix font ref leak when drawing the edit cell.
* src/dialogs/dialog-function-wizard.c : Begin transition to being
non-modal. NOT FINISHED.
2000-03-10 Michael Meeks <michael@helixcode.com>
* src/Makefile.am (sheet-vector.h): make it depend on Gnumeric.h
......
2000-03-10 Jody Goldberg <jgoldberg@home.com>
* src/func.c (tokenized_help_new) : Constness.
* src/widgets/gtk-combo-box.c (cb_state_change) : New function to keep
the state of the combo display button and the combo arrow in sync.
(gtk_combo_box_init) : Connect cb_state_change to the arrow.
(gtk_combo_box_set_display) : Ditto for the display widget.
* src/sheet.c (sheet_set_zoom_factor) : Bound the factor at 10% and 500%
* src/workbook.c (change_zoom_in_current_sheet_cb) :
call change_displayed_zoom_cb to adjust the combo to contain the
(workbook_focus_current_sheet) : Only emit signal if the sheet
changed.
2000-03-08 Jody Goldberg <jgoldberg@home.com>
* src/collect.c (callback_function_collect) : Treat arrays and ranges
as errors.
* src/format.c (format_value) : formating a range returns a
#VALUE! message.
* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) :
Use the workbook flags, and delete the icky globals.
(start_cell_selection_at) : Hide the std cursor when a cell selection
cursor is created.
(gnumeric_sheet_stop_cell_selection) : Restore the std cursor.
2000-03-07 Jody Goldberg <jgoldberg@home.com>
* src/workbook.c (accept_input) : Use workbook_finish_editing.
(cancel_input) : Ditto.
(do_focus_sheet) : Support range selection across spreadsheets.
(workbook_get_sheet_position) : Fix and document.
(workbook_move_sheet) : Fix.
(workbook_focus_sheet) : Handle errors cleanly.
(wb_edit_key_pressed) : Improve F4 handling.
(wizard_input) : Begin non-modal function wizard. NOT FINSIHED.
(workbook_start_editing_at_cursor) : transfered from
sheet_start_editing_at_cursor.
(workbook_finish_editing) : Distilled from sheet_{accept,cancel}_pending_input.
(Workbook) : Add editing_cell, editing_sheet, editing.
* src/sheet.c (sheet_stop_editing) : Delete.
(sheet_accept_pending_input) : Merge into workbook_finish_editing.
(sheet_cancel_pending_input) : Ditto.
(sheet_start_editing_at_cursor) :
(sheet_create_edit_cursor) : New function.
(sheet_destroy_edit_cursor) : New function.
(sheet_destroy_cell_select_cursor) : New function.
(Sheet) : Delete editing and editing_cell.
* src/selection.c (sheet_selection_changed_hook) : Make public. This
should eventually move but I'm not sure where. It is used for more
than just changes in the selection in the current sheet. It must
also be called when the sheet changes. What it REALLY does it to
sync the shared workbook state with the current sheet's selection.
* src/item-cursor.c (item_cursor_init) : Handle change from
sheet_accept_pending_input -> workbook_finish_editing.
* src/item-grid.c (item_grid_button_1) : Ditto.
* src/gnumeric-sheet.c (gnumeric_sheet_can_move_cursor) : Edit moved
from sheet -> workbook.
(selection_insert_selection_string) : Extend to support
abs/rel refs and intersheet-refs.
(gnumeric_sheet_stop_cell_selection) : Add clear_string argument
to optionally remove the selection range.
(gnumeric_sheet_key_mode_sheet) : Adjust to movement of editing flag
from sheet -> workbook. Be careful to use the original sheet when
moving rather than the current sheet. Support F4 while editing.
* src/cell-draw.c (cell_draw) : editing_cell has moved from sheet to
workbook. Fix font ref leak when drawing the edit cell.
* src/dialogs/dialog-function-wizard.c : Begin transition to being
non-modal. NOT FINISHED.
2000-03-10 Michael Meeks <michael@helixcode.com>
* src/Makefile.am (sheet-vector.h): make it depend on Gnumeric.h
......
2000-03-10 Jody Goldberg <jgoldberg@home.com>
* src/func.c (tokenized_help_new) : Constness.
* src/widgets/gtk-combo-box.c (cb_state_change) : New function to keep
the state of the combo display button and the combo arrow in sync.
(gtk_combo_box_init) : Connect cb_state_change to the arrow.
(gtk_combo_box_set_display) : Ditto for the display widget.
* src/sheet.c (sheet_set_zoom_factor) : Bound the factor at 10% and 500%
* src/workbook.c (change_zoom_in_current_sheet_cb) :
call change_displayed_zoom_cb to adjust the combo to contain the
(workbook_focus_current_sheet) : Only emit signal if the sheet
changed.
2000-03-08 Jody Goldberg <jgoldberg@home.com>
* src/collect.c (callback_function_collect) : Treat arrays and ranges
as errors.
* src/format.c (format_value) : formating a range returns a
#VALUE! message.
* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) :
Use the workbook flags, and delete the icky globals.
(start_cell_selection_at) : Hide the std cursor when a cell selection
cursor is created.
(gnumeric_sheet_stop_cell_selection) : Restore the std cursor.
2000-03-07 Jody Goldberg <jgoldberg@home.com>
* src/workbook.c (accept_input) : Use workbook_finish_editing.
(cancel_input) : Ditto.
(do_focus_sheet) : Support range selection across spreadsheets.
(workbook_get_sheet_position) : Fix and document.
(workbook_move_sheet) : Fix.
(workbook_focus_sheet) : Handle errors cleanly.
(wb_edit_key_pressed) : Improve F4 handling.
(wizard_input) : Begin non-modal function wizard. NOT FINSIHED.
(workbook_start_editing_at_cursor) : transfered from
sheet_start_editing_at_cursor.
(workbook_finish_editing) : Distilled from sheet_{accept,cancel}_pending_input.
(Workbook) : Add editing_cell, editing_sheet, editing.
* src/sheet.c (sheet_stop_editing) : Delete.
(sheet_accept_pending_input) : Merge into workbook_finish_editing.
(sheet_cancel_pending_input) : Ditto.
(sheet_start_editing_at_cursor) :
(sheet_create_edit_cursor) : New function.
(sheet_destroy_edit_cursor) : New function.
(sheet_destroy_cell_select_cursor) : New function.
(Sheet) : Delete editing and editing_cell.
* src/selection.c (sheet_selection_changed_hook) : Make public. This
should eventually move but I'm not sure where. It is used for more
than just changes in the selection in the current sheet. It must
also be called when the sheet changes. What it REALLY does it to
sync the shared workbook state with the current sheet's selection.
* src/item-cursor.c (item_cursor_init) : Handle change from
sheet_accept_pending_input -> workbook_finish_editing.
* src/item-grid.c (item_grid_button_1) : Ditto.
* src/gnumeric-sheet.c (gnumeric_sheet_can_move_cursor) : Edit moved
from sheet -> workbook.
(selection_insert_selection_string) : Extend to support
abs/rel refs and intersheet-refs.
(gnumeric_sheet_stop_cell_selection) : Add clear_string argument
to optionally remove the selection range.
(gnumeric_sheet_key_mode_sheet) : Adjust to movement of editing flag
from sheet -> workbook. Be careful to use the original sheet when
moving rather than the current sheet. Support F4 while editing.
* src/cell-draw.c (cell_draw) : editing_cell has moved from sheet to
workbook. Fix font ref leak when drawing the edit cell.
* src/dialogs/dialog-function-wizard.c : Begin transition to being
non-modal. NOT FINISHED.
2000-03-10 Michael Meeks <michael@helixcode.com>
* src/Makefile.am (sheet-vector.h): make it depend on Gnumeric.h
......
2000-03-10 Jody Goldberg <jgoldberg@home.com>
* src/func.c (tokenized_help_new) : Constness.
* src/widgets/gtk-combo-box.c (cb_state_change) : New function to keep
the state of the combo display button and the combo arrow in sync.
(gtk_combo_box_init) : Connect cb_state_change to the arrow.
(gtk_combo_box_set_display) : Ditto for the display widget.
* src/sheet.c (sheet_set_zoom_factor) : Bound the factor at 10% and 500%
* src/workbook.c (change_zoom_in_current_sheet_cb) :
call change_displayed_zoom_cb to adjust the combo to contain the
(workbook_focus_current_sheet) : Only emit signal if the sheet
changed.
2000-03-08 Jody Goldberg <jgoldberg@home.com>
* src/collect.c (callback_function_collect) : Treat arrays and ranges
as errors.
* src/format.c (format_value) : formating a range returns a
#VALUE! message.
* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) :
Use the workbook flags, and delete the icky globals.
(start_cell_selection_at) : Hide the std cursor when a cell selection
cursor is created.
(gnumeric_sheet_stop_cell_selection) : Restore the std cursor.
2000-03-07 Jody Goldberg <jgoldberg@home.com>
* src/workbook.c (accept_input) : Use workbook_finish_editing.
(cancel_input) : Ditto.
(do_focus_sheet) : Support range selection across spreadsheets.
(workbook_get_sheet_position) : Fix and document.
(workbook_move_sheet) : Fix.
(workbook_focus_sheet) : Handle errors cleanly.
(wb_edit_key_pressed) : Improve F4 handling.
(wizard_input) : Begin non-modal function wizard. NOT FINSIHED.
(workbook_start_editing_at_cursor) : transfered from
sheet_start_editing_at_cursor.
(workbook_finish_editing) : Distilled from sheet_{accept,cancel}_pending_input.
(Workbook) : Add editing_cell, editing_sheet, editing.
* src/sheet.c (sheet_stop_editing) : Delete.
(sheet_accept_pending_input) : Merge into workbook_finish_editing.
(sheet_cancel_pending_input) : Ditto.
(sheet_start_editing_at_cursor) :
(sheet_create_edit_cursor) : New function.
(sheet_destroy_edit_cursor) : New function.
(sheet_destroy_cell_select_cursor) : New function.
(Sheet) : Delete editing and editing_cell.
* src/selection.c (sheet_selection_changed_hook) : Make public. This
should eventually move but I'm not sure where. It is used for more
than just changes in the selection in the current sheet. It must
also be called when the sheet changes. What it REALLY does it to
sync the shared workbook state with the current sheet's selection.
* src/item-cursor.c (item_cursor_init) : Handle change from
sheet_accept_pending_input -> workbook_finish_editing.
* src/item-grid.c (item_grid_button_1) : Ditto.
* src/gnumeric-sheet.c (gnumeric_sheet_can_move_cursor) : Edit moved
from sheet -> workbook.
(selection_insert_selection_string) : Extend to support
abs/rel refs and intersheet-refs.
(gnumeric_sheet_stop_cell_selection) : Add clear_string argument
to optionally remove the selection range.
(gnumeric_sheet_key_mode_sheet) : Adjust to movement of editing flag
from sheet -> workbook. Be careful to use the original sheet when
moving rather than the current sheet. Support F4 while editing.
* src/cell-draw.c (cell_draw) : editing_cell has moved from sheet to
workbook. Fix font ref leak when drawing the edit cell.
* src/dialogs/dialog-function-wizard.c : Begin transition to being
non-modal. NOT FINISHED.
2000-03-10 Michael Meeks <michael@helixcode.com>
* src/Makefile.am (sheet-vector.h): make it depend on Gnumeric.h
......
2000-03-10 Jody Goldberg <jgoldberg@home.com>
* src/func.c (tokenized_help_new) : Constness.
* src/widgets/gtk-combo-box.c (cb_state_change) : New function to keep
the state of the combo display button and the combo arrow in sync.
(gtk_combo_box_init) : Connect cb_state_change to the arrow.
(gtk_combo_box_set_display) : Ditto for the display widget.
* src/sheet.c (sheet_set_zoom_factor) : Bound the factor at 10% and 500%
* src/workbook.c (change_zoom_in_current_sheet_cb) :
call change_displayed_zoom_cb to adjust the combo to contain the
(workbook_focus_current_sheet) : Only emit signal if the sheet
changed.
2000-03-08 Jody Goldberg <jgoldberg@home.com>
* src/collect.c (callback_function_collect) : Treat arrays and ranges
as errors.
* src/format.c (format_value) : formating a range returns a
#VALUE! message.
* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) :
Use the workbook flags, and delete the icky globals.
(start_cell_selection_at) : Hide the std cursor when a cell selection
cursor is created.
(gnumeric_sheet_stop_cell_selection) : Restore the std cursor.
2000-03-07 Jody Goldberg <jgoldberg@home.com>
* src/workbook.c (accept_input) : Use workbook_finish_editing.
(cancel_input) : Ditto.
(do_focus_sheet) : Support range selection across spreadsheets.
(workbook_get_sheet_position) : Fix and document.
(workbook_move_sheet) : Fix.
(workbook_focus_sheet) : Handle errors cleanly.
(wb_edit_key_pressed) : Improve F4 handling.
(wizard_input) : Begin non-modal function wizard. NOT FINSIHED.
(workbook_start_editing_at_cursor) : transfered from
sheet_start_editing_at_cursor.
(workbook_finish_editing) : Distilled from sheet_{accept,cancel}_pending_input.
(Workbook) : Add editing_cell, editing_sheet, editing.
* src/sheet.c (sheet_stop_editing) : Delete.
(sheet_accept_pending_input) : Merge into workbook_finish_editing.
(sheet_cancel_pending_input) : Ditto.
(sheet_start_editing_at_cursor) :
(sheet_create_edit_cursor) : New function.
(sheet_destroy_edit_cursor) : New function.
(sheet_destroy_cell_select_cursor) : New function.
(Sheet) : Delete editing and editing_cell.
* src/selection.c (sheet_selection_changed_hook) : Make public. This
should eventually move but I'm not sure where. It is used for more
than just changes in the selection in the current sheet. It must
also be called when the sheet changes. What it REALLY does it to
sync the shared workbook state with the current sheet's selection.
* src/item-cursor.c (item_cursor_init) : Handle change from
sheet_accept_pending_input -> workbook_finish_editing.
* src/item-grid.c (item_grid_button_1) : Ditto.
* src/gnumeric-sheet.c (gnumeric_sheet_can_move_cursor) : Edit moved
from sheet -> workbook.
(selection_insert_selection_string) : Extend to support
abs/rel refs and intersheet-refs.
(gnumeric_sheet_stop_cell_selection) : Add clear_string argument
to optionally remove the selection range.
(gnumeric_sheet_key_mode_sheet) : Adjust to movement of editing flag
from sheet -> workbook. Be careful to use the original sheet when
moving rather than the current sheet. Support F4 while editing.
* src/cell-draw.c (cell_draw) : editing_cell has moved from sheet to
workbook. Fix font ref leak when drawing the edit cell.
* src/dialogs/dialog-function-wizard.c : Begin transition to being
non-modal. NOT FINISHED.
2000-03-10 Michael Meeks <michael@helixcode.com>
* src/Makefile.am (sheet-vector.h): make it depend on Gnumeric.h
......
2000-03-10 Jody Goldberg <jgoldberg@home.com>
* src/func.c (tokenized_help_new) : Constness.
* src/widgets/gtk-combo-box.c (cb_state_change) : New function to keep
the state of the combo display button and the combo arrow in sync.
(gtk_combo_box_init) : Connect cb_state_change to the arrow.
(gtk_combo_box_set_display) : Ditto for the display widget.
* src/sheet.c (sheet_set_zoom_factor) : Bound the factor at 10% and 500%
* src/workbook.c (change_zoom_in_current_sheet_cb) :
call change_displayed_zoom_cb to adjust the combo to contain the
(workbook_focus_current_sheet) : Only emit signal if the sheet
changed.
2000-03-08 Jody Goldberg <jgoldberg@home.com>
* src/collect.c (callback_function_collect) : Treat arrays and ranges
as errors.
* src/format.c (format_value) : formating a range returns a
#VALUE! message.
* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) :
Use the workbook flags, and delete the icky globals.
(start_cell_selection_at) : Hide the std cursor when a cell selection
cursor is created.
(gnumeric_sheet_stop_cell_selection) : Restore the std cursor.
2000-03-07 Jody Goldberg <jgoldberg@home.com>
* src/workbook.c (accept_input) : Use workbook_finish_editing.
(cancel_input) : Ditto.
(do_focus_sheet) : Support range selection across spreadsheets.
(workbook_get_sheet_position) : Fix and document.
(workbook_move_sheet) : Fix.
(workbook_focus_sheet) : Handle errors cleanly.
(wb_edit_key_pressed) : Improve F4 handling.
(wizard_input) : Begin non-modal function wizard. NOT FINSIHED.
(workbook_start_editing_at_cursor) : transfered from
sheet_start_editing_at_cursor.
(workbook_finish_editing) : Distilled from sheet_{accept,cancel}_pending_input.
(Workbook) : Add editing_cell, editing_sheet, editing.
* src/sheet.c (sheet_stop_editing) : Delete.
(sheet_accept_pending_input) : Merge into workbook_finish_editing.
(sheet_cancel_pending_input) : Ditto.
(sheet_start_editing_at_cursor) :
(sheet_create_edit_cursor) : New function.
(sheet_destroy_edit_cursor) : New function.
(sheet_destroy_cell_select_cursor) : New function.
(Sheet) : Delete editing and editing_cell.
* src/selection.c (sheet_selection_changed_hook) : Make public. This
should eventually move but I'm not sure where. It is used for more
than just changes in the selection in the current sheet. It must
also be called when the sheet changes. What it REALLY does it to
sync the shared workbook state with the current sheet's selection.
* src/item-cursor.c (item_cursor_init) : Handle change from
sheet_accept_pending_input -> workbook_finish_editing.
* src/item-grid.c (item_grid_button_1) : Ditto.
* src/gnumeric-sheet.c (gnumeric_sheet_can_move_cursor) : Edit moved
from sheet -> workbook.
(selection_insert_selection_string) : Extend to support
abs/rel refs and intersheet-refs.
(gnumeric_sheet_stop_cell_selection) : Add clear_string argument
to optionally remove the selection range.
(gnumeric_sheet_key_mode_sheet) : Adjust to movement of editing flag
from sheet -> workbook. Be careful to use the original sheet when
moving rather than the current sheet. Support F4 while editing.
* src/cell-draw.c (cell_draw) : editing_cell has moved from sheet to
workbook. Fix font ref leak when drawing the edit cell.
* src/dialogs/dialog-function-wizard.c : Begin transition to being
non-modal. NOT FINISHED.
2000-03-10 Michael Meeks <michael@helixcode.com>
* src/Makefile.am (sheet-vector.h): make it depend on Gnumeric.h
......
......@@ -24,6 +24,16 @@ Description Difficulty Integration
rows/cols. We should change the default,
not set the size of every ColInfo.
- Have the pattern buttons in the format dialog Medium Low
reflect colour changes.
- Add MS excel like format->autoformat. A dialog Low Low
that will display some canned styles and apply them
to the selection.
- Audit the help text for all the functions. Some are Low Low
missing or do not conform to the style guides,
Difficulty: an estimate of how hard the task would be for the average hacker.
(This is not an estimate of project size; a project can be very big, but
easy at the same time.)
......
......@@ -58,7 +58,7 @@ Gnumeric Spread Sheet task list
* Display printing status (pages to go).
* Add column/row title printing
* Add color printing support.
* Borders & patterns.
* patterns.
* Font dialog
......@@ -74,7 +74,6 @@ Gnumeric Spread Sheet task list
account to render the number as well as possible given the space so
that for small regions, numbers in scientific notation are displayed.
- '@' does not work
- '*' does not work
- 'General' is rather stupid. It needs to take the size of the cell into account.
......@@ -127,14 +126,6 @@ Gnumeric Spread Sheet task list
Interesting side effect: min_points == max_points means "fixed".
** Queueing redraws as we are doing it now is broken.
Currently I queue the entire changed region for redraw, I should
only queue the difference and possibly the borders (after a cell
border has changed).
This causes the slowdown when selecting large sheets.
* Auditing
Write the sheet auditing code.
......@@ -167,6 +158,8 @@ Gnumeric Spread Sheet task list
I have the specs for the XS3 format. SC should be
trivial to support as well (from the guile sources)
* Applix, star office, kspread ?
* Add "hints" to the file save routine based on the registered
formats.
......@@ -175,6 +168,10 @@ Gnumeric Spread Sheet task list
* Add ability to send warnings, and progress while loading.
* Display Engine
* drawing double line borders is broken
* merged cells.
* Continue cleaning cursor code.
* Rework borders to agregate the lines and draw them after backgrounds
* Unicode support throughout
......@@ -190,16 +187,12 @@ Gnumeric Spread Sheet task list
insert (DONE)
delete (DONE)
rename (DONE)
reorder/copy *(TODO)
reorder (DONE)
copy *(TODO)
- Decrease flicker when paging between sheets.
- Enable capability to select multiple sheets.
- Allow range selection to work when switching between sheets.
ie Use the arrows to select a different cell while entering a
formula. Then use the ctrl-Pg{Up,Down} to select a cell on
a different sheet.
* Sheet Objects
* Load / save, print of all objects + Bonobo objects.
......@@ -215,7 +208,7 @@ Office 2000 and 'explorer' compatibility.
* Internals
Our current setup is *slow*. In many areas, but still *slow*.
Our current setup is *slow*.
When filling large regions (ie, select, enter data, control-enter),
we are taking ages. In those cases, we could probably:
......@@ -264,9 +257,6 @@ Office 2000 and 'explorer' compatibility.
which takes a range as a scalar argument, apply the expression to each element
of the input range.
* Drawing
* Rework borders to agregate the lines and draw them after backgrounds
* Undo
* Commands to do
- paste_cut
......@@ -300,4 +290,4 @@ Office 2000 and 'explorer' compatibility.
be notified of changes.
Needs to be optimized.
\ No newline at end of file
2000-03-09 Jody Goldberg <jgoldberg@home.com>
* ms-excel-read.c (ms_excel_get_style_from_xf) : Tweak colour
selection for contrasting colours. FIXME : We really need to find
something more definative than this guess work.
* ms-excel-read.c (ms_excel_read_selection) : Do not reset the
edit cursor. It needs more work to be correct.
2000-03-09 Jody Goldberg <jgoldberg@home.com>
* ms-excel-util.[ch] (lookup_font_base_char_width) : Delete.
* ms-excel-read.c (ms_excel_get_style_from_xf) : Adjust bottom and
right borders to be top & left of neighbouring cells.
(ms_excel_set_xf) : Ditto.
(ms_excel_set_xf_segment) : Ditto.
2000-03-05 Jon K Hellan <hellan@acm.org>
* ms-excel-write.c (lookup_base_char_width_for_write): Rename to
......
......@@ -1047,7 +1047,7 @@ style_optimize (ExcelSheet *sheet, int col, int row)
}
}
static MStyle *
static MStyle * const *
ms_excel_get_style_from_xf (ExcelSheet *sheet, guint16 xfidx)
{
BiffXFData const *xf = ms_excel_get_xf (sheet, xfidx);
......@@ -1067,8 +1067,12 @@ ms_excel_get_style_from_xf (ExcelSheet *sheet, guint16 xfidx)
g_return_val_if_fail (xf != NULL, NULL);
/* If we've already done the conversion use the cached style */
if (xf->mstyle != NULL) {
mstyle_ref (xf->mstyle);
if (xf->mstyle[0] != NULL) {
mstyle_ref (xf->mstyle[0]);
if (xf->mstyle[1] != NULL)
mstyle_ref (xf->mstyle[1]);
if (xf->mstyle[2] != NULL)
mstyle_ref (xf->mstyle[2]);
return xf->mstyle;
}
......@@ -1156,6 +1160,7 @@ ms_excel_get_style_from_xf (ExcelSheet *sheet, guint16 xfidx)
if (back_index == 64 || back_index == 65 || back_index == 0)
{
/* Everything is auto default to black text/pattern on white */
/* FIXME : This should use the 'Normal' Style */
if (pattern_index == 64 || pattern_index == 65 || pattern_index == 0)
{
back_color = style_color_white ();
......@@ -1167,7 +1172,10 @@ ms_excel_get_style_from_xf (ExcelSheet *sheet, guint16 xfidx)
pattern_index);
/* Contrast back to pattern, and font to back */
back_color = black_or_white_contrast (pattern_color);