Commit b3f070c4 authored by Chyla Zbigniew's avatar Chyla Zbigniew

Making Gnumeric -Werror friendly (well, almost).


Making Gnumeric -Werror friendly (well, almost).

* plugins/excel/ms-chart.c: Added "#if 0/#endif" around declarations
of unused variables.

* plugins/gda/plugin-gda.c (display_recordset): Removed unused
variable, fixed some errors (that's why I use -Werror).

* plugins/xml2/xml2.c (init_plugin): Used xml2_probe function.

* src/search.c: Included "ranges.h".

* src/style.c: Included "sheet.h"
parent 17361383
2001-01-27 Zbigniew Chyla <cyba@gnome.pl>
Making Gnumeric -Werror friendly (well, almost).
* plugins/excel/ms-chart.c: Added "#if 0/#endif" around declarations
of unused variables.
* plugins/gda/plugin-gda.c (display_recordset): Removed unused
variable, fixed some errors (that's why I use -Werror).
* plugins/xml2/xml2.c (init_plugin): Used xml2_probe function.
* src/search.c: Included "ranges.h".
* src/style.c: Included "sheet.h"
2001-01-27 Zbigniew Chyla <cyba@gnome.pl>
* src/dialogs/plugin-manager.glade: Set policy to AUTOMATIC for some
......
2001-01-27 Zbigniew Chyla <cyba@gnome.pl>
Making Gnumeric -Werror friendly (well, almost).
* plugins/excel/ms-chart.c: Added "#if 0/#endif" around declarations
of unused variables.
* plugins/gda/plugin-gda.c (display_recordset): Removed unused
variable, fixed some errors (that's why I use -Werror).
* plugins/xml2/xml2.c (init_plugin): Used xml2_probe function.
* src/search.c: Included "ranges.h".
* src/style.c: Included "sheet.h"
2001-01-27 Zbigniew Chyla <cyba@gnome.pl>
* src/dialogs/plugin-manager.glade: Set policy to AUTOMATIC for some
......
2001-01-27 Zbigniew Chyla <cyba@gnome.pl>
Making Gnumeric -Werror friendly (well, almost).
* plugins/excel/ms-chart.c: Added "#if 0/#endif" around declarations
of unused variables.
* plugins/gda/plugin-gda.c (display_recordset): Removed unused
variable, fixed some errors (that's why I use -Werror).
* plugins/xml2/xml2.c (init_plugin): Used xml2_probe function.
* src/search.c: Included "ranges.h".
* src/style.c: Included "sheet.h"
2001-01-27 Zbigniew Chyla <cyba@gnome.pl>
* src/dialogs/plugin-manager.glade: Set policy to AUTOMATIC for some
......
2001-01-27 Zbigniew Chyla <cyba@gnome.pl>
Making Gnumeric -Werror friendly (well, almost).
* plugins/excel/ms-chart.c: Added "#if 0/#endif" around declarations
of unused variables.
* plugins/gda/plugin-gda.c (display_recordset): Removed unused
variable, fixed some errors (that's why I use -Werror).
* plugins/xml2/xml2.c (init_plugin): Used xml2_probe function.
* src/search.c: Included "ranges.h".
* src/style.c: Included "sheet.h"
2001-01-27 Zbigniew Chyla <cyba@gnome.pl>
* src/dialogs/plugin-manager.glade: Set policy to AUTOMATIC for some
......
2001-01-27 Zbigniew Chyla <cyba@gnome.pl>
Making Gnumeric -Werror friendly (well, almost).
* plugins/excel/ms-chart.c: Added "#if 0/#endif" around declarations
of unused variables.
* plugins/gda/plugin-gda.c (display_recordset): Removed unused
variable, fixed some errors (that's why I use -Werror).
* plugins/xml2/xml2.c (init_plugin): Used xml2_probe function.
* src/search.c: Included "ranges.h".
* src/style.c: Included "sheet.h"
2001-01-27 Zbigniew Chyla <cyba@gnome.pl>
* src/dialogs/plugin-manager.glade: Set policy to AUTOMATIC for some
......
......@@ -283,8 +283,10 @@ static gboolean
BC_R(areaformat)(ExcelChartHandler const *handle,
ExcelChart *s, BiffQuery *q)
{
#if 0
StyleColor *fore = BC_R(color) (q->data, "Area Fore");
StyleColor *back = BC_R(color) (q->data+4, "Area Back");
#endif
guint16 const pattern = MS_OLE_GET_GUINT16 (q->data+8);
guint16 const flags = MS_OLE_GET_GUINT16 (q->data+10);
gboolean const auto_format = (flags & 0x01) ? TRUE : FALSE;
......@@ -720,11 +722,13 @@ static gboolean
BC_R(dat)(ExcelChartHandler const *handle,
ExcelChart *s, BiffQuery *q)
{
#if 0
gint16 const flags = MS_OLE_GET_GUINT16 (q->data);
gboolean const horiz_border = (flags&0x01) ? TRUE : FALSE;
gboolean const vert_border = (flags&0x02) ? TRUE : FALSE;
gboolean const border = (flags&0x04) ? TRUE : FALSE;
gboolean const series_keys = (flags&0x08) ? TRUE : FALSE;
#endif
return FALSE;
}
static gboolean
......@@ -742,8 +746,10 @@ BC_R(dataformat)(ExcelChartHandler const *handle,
{
guint16 const pt_num = MS_OLE_GET_GUINT16 (q->data);
guint16 const series_index = MS_OLE_GET_GUINT16 (q->data+2);
#if 0
guint16 const series_index_for_label = MS_OLE_GET_GUINT16 (q->data+4);
guint16 const excel4_auto_color = MS_OLE_GET_GUINT16 (q->data+6) & 0x01;
#endif
if (pt_num == 0xffff)
printf ("All points");
......@@ -838,8 +844,10 @@ static gboolean
BC_R(fontx)(ExcelChartHandler const *handle,
ExcelChart *s, BiffQuery *q)
{
#if 0
/* Child of TEXT, index into FONT table */
guint16 const font = MS_OLE_GET_GUINT16 (q->data);
#endif
return FALSE;
}
......@@ -949,8 +957,10 @@ BC_R(legend)(ExcelChartHandler const *handle,
guint32 const width = MS_OLE_GET_GUINT32 (q->data+8);
guint32 const height = MS_OLE_GET_GUINT32 (q->data+12);
guint8 const tmp = MS_OLE_GET_GUINT8 (q->data+16);
#if 0
guint8 const spacing = MS_OLE_GET_GUINT8 (q->data+17);
guint16 const flags = MS_OLE_GET_GUINT16 (q->data+18);
#endif
MS_LEGEND_LOCATION location;
g_return_val_if_fail (tmp < MS_LEGEND_LOCATION_MAX &&
......
......@@ -36,7 +36,6 @@ display_recordset (Gda_Recordset *recset)
{
gint position;
Value* array = NULL;
Value* tmp;
gint col;
gint cnt;
gint fieldcount = 0;
......@@ -134,18 +133,18 @@ gnumeric_execSQL (FunctionEvalInfo *ei, Value **args)
password = value_get_as_string(args[2]);
sql = value_get_as_string(args[3]);
if (!dsn_name || !sql)
return value_new_error(&ei->pos, _("Format: execSQL(dsn,user,password,sql)"));
return value_new_error(ei->pos, _("Format: execSQL(dsn,user,password,sql)"));
/* initialize connection pool if first time */
if (!IS_GDA_CONNECTION_POOL(connection_pool)) {
connection_pool = gda_connection_pool_new();
if (!connection_pool) {
return value_new_error(&ei->pos, _("Error: could not initialize connection pool"));
return value_new_error(ei->pos, _("Error: could not initialize connection pool"));
}
}
cnc = gda_connection_pool_open_connection(connection_pool, dsn_name, user_name, password);
if (!IS_GDA_CONNECTION(cnc)) {
return value_new_error(&ei->pos, _("Error: could not open connection to %s"));
return value_new_error(ei->pos, _("Error: could not open connection to %s"));
}
/* execute command */
......
......@@ -1570,7 +1570,7 @@ init_plugin (PluginInfo *pinfo, ErrorInfo **ret_error)
/* low priority for now */
xml2_opener_id = file_format_register_open (
1, _("EXPERIMENTAL Gnumeric (*.gnumeric) XML based file format"),
NULL, &xml2_open, NULL);
&xml2_probe, &xml2_open, NULL);
#if 0
xml2_saver_id = file_format_register_save (
......
......@@ -1570,7 +1570,7 @@ init_plugin (PluginInfo *pinfo, ErrorInfo **ret_error)
/* low priority for now */
xml2_opener_id = file_format_register_open (
1, _("EXPERIMENTAL Gnumeric (*.gnumeric) XML based file format"),
NULL, &xml2_open, NULL);
&xml2_probe, &xml2_open, NULL);
#if 0
xml2_saver_id = file_format_register_save (
......
......@@ -9,6 +9,7 @@
#include <config.h>
#include <gnome.h>
#include <ctype.h>
#include "ranges.h"
#include "search.h"
/* ------------------------------------------------------------------------- */
......
......@@ -14,6 +14,7 @@
#include "style-color.h"
#include "application.h"
#include "gnumeric-util.h"
#include "sheet.h"
#include <gal/widgets/e-colors.h>
......
......@@ -1570,7 +1570,7 @@ init_plugin (PluginInfo *pinfo, ErrorInfo **ret_error)
/* low priority for now */
xml2_opener_id = file_format_register_open (
1, _("EXPERIMENTAL Gnumeric (*.gnumeric) XML based file format"),
NULL, &xml2_open, NULL);
&xml2_probe, &xml2_open, NULL);
#if 0
xml2_saver_id = file_format_register_save (
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment