Commit aa133206 authored by Miguel de Icaza's avatar Miguel de Icaza Committed by Miguel de Icaza

This adds autocompletion.

It is missing one forced repaint that makes the stuff look slower
than it is.

2000-06-05  Miguel de Icaza  <miguel@helixcode.com>

	* src/gnumeric-util.c (gtk_radio_button_select): Add
	precondition.  Chema found this, but we should add the proper
	check at an upper layer.

2000-06-04  Miguel de Icaza  <miguel@helixcode.com>

	* src/gnumeric-util.c (gnumeric_entry_at_subexpr_boundary_p):
	Change prototype to use GtkEntry instead of GtkWidget.

	* src/workbook-edit.c (workbook_finish_editing): Changed direct access to
	workbook->private_entry to workbook_get_entry.
	(entry_changed): ditto.
	(workbook_start_editing_at_cursor): ditto.
	(workbook_editing_expr): ditto.
	(workbook_edit_get_display_text): ditto.

	* src/workbook.c (autosum_cmd): Changed direct access to
	workbook->private_entry to workbook_get_entry.
	(do_focus_sheet): ditto.
	(wb_edit_key_pressed): ditto.
	(workbook_setup_edit_area): ditto.

	* src/workbook.c (cb_autofunction): ditto.

	* src/workbook-private.h: Make edit_line a structure to keep track
	of the entry and its signal changed.  Also take a chance to change
	this to the self descriptive GtkEntry instead of GtkWidget.

	* src/commands.c (cmd_set_text): Added const here.

	* src/workbook.c (workbook_do_destroy): Add destroy notification
	for the editing facilities

	* src/item-edit.c (item_edit_set_arg): removed auto complete code
	from here.

2000-06-03  Miguel de Icaza  <miguel@helixcode.com>

	* src/workbook-edit.c, src/workbook-edit.h: New files.  Moved
	workbook_start_editing_at_cursor, workbook_finish_editing,
	workbook_get_entry, workbook_editing_expr here.  Killed
	workbook_set_entry prototype.

	* src/workbook.c (workbook_start_editing_at_cursor): Moved
	autocomplete here.

	* src/workbook.h: Removed warning.  #include <config.h> is a
	mandatory header file in every C file.  A correct approach is to
	use something like Nautilus' perl script that verifies the
	presence of config.h as the first include.

	* src/workbook.c (close_cmd): Removed ulgy (void)
	(quit_cmd): More.
	(sheet_action_rename_sheet): more.
	(workbook_finish_editing): Fixed more ugly.

	* src/gutils.c (gnumeric_sys_glade_dir): Fixed ugly indentation.
	(gnumeric_usr_plugin_dir): More ugly stuff fixed.
	(gnumeric_usr_dir): Removed ugly const.

2000-05-02  Miguel de Icaza  <miguel@helixcode.com>

	* src/item-edit.h: New ::entry member, auto_max_size, auto_complete_text

	* src/item-edit.c (item_edit_draw_text): Take an ItemEdit as a
	first argument, and reduce the cluttered arguments we were
	passing.
	(item_edit_draw): Cursor_pos is now only the position, it is not
	overloaded with show/hide cursor as well.
	(item_edit_draw_text): Update acoordingly.
	(item_edit_draw_cursor): This new routine paints the cursor only.
	(item_edit_set_arg): Add a new signal handler for "activated" on
	the entry
	(cb_item_edit_cursor_blink): Removed FIXME.
	(item_edit_set_arg): Init item_edit->entry.  I am pretty sure this
	existed in the past.

2000-05-01  Miguel de Icaza  <miguel@helixcode.com>

	* src/item-edit.c (item_edit_draw): Pass auto-completing flag.
	(item_edit_draw_text): Invert auto-complete region.
	(item_edit_set_arg): Init auto_completing here.
	(item_edit_complete_notify): Set the entry from the
	auto-completing data here.


2000-06-04  Miguel de Icaza  <miguel@helixcode.com>

	* dialog-function-wizard.c (dialog_function_druid): Use
	workbook_get_entry here.

	* dialog-printer-setup.c (spin_button_adapt_to_unit): Added
	g_assert_not_reached ();
parent 7f94ba9e
2000-06-05 Miguel de Icaza <miguel@helixcode.com>
* src/gnumeric-util.c (gtk_radio_button_select): Add
precondition. Chema found this, but we should add the proper
check at an upper layer.
2000-06-04 Miguel de Icaza <miguel@helixcode.com>
* src/gnumeric-util.c (gnumeric_entry_at_subexpr_boundary_p):
Change prototype to use GtkEntry instead of GtkWidget.
* src/workbook-edit.c (workbook_finish_editing): Changed direct access to
workbook->private_entry to workbook_get_entry.
(entry_changed): ditto.
(workbook_start_editing_at_cursor): ditto.
(workbook_editing_expr): ditto.
(workbook_edit_get_display_text): ditto.
* src/workbook.c (autosum_cmd): Changed direct access to
workbook->private_entry to workbook_get_entry.
(do_focus_sheet): ditto.
(wb_edit_key_pressed): ditto.
(workbook_setup_edit_area): ditto.
* src/workbook.c (cb_autofunction): ditto.
* src/workbook-private.h: Make edit_line a structure to keep track
of the entry and its signal changed. Also take a chance to change
this to the self descriptive GtkEntry instead of GtkWidget.
* src/commands.c (cmd_set_text): Added const here.
* src/workbook.c (workbook_do_destroy): Add destroy notification
for the editing facilities
* src/item-edit.c (item_edit_set_arg): removed auto complete code
from here.
2000-06-03 Miguel de Icaza <miguel@helixcode.com>
* src/workbook-edit.c, src/workbook-edit.h: New files. Moved
workbook_start_editing_at_cursor, workbook_finish_editing,
workbook_get_entry, workbook_editing_expr here. Killed
workbook_set_entry prototype.
* src/workbook.c (workbook_start_editing_at_cursor): Moved
autocomplete here.
* src/workbook.h: Removed warning. #include <config.h> is a
mandatory header file in every C file. A correct approach is to
use something like Nautilus' perl script that verifies the
presence of config.h as the first include.
* src/workbook.c (close_cmd): Removed ulgy (void)
(quit_cmd): More.
(sheet_action_rename_sheet): more.
(workbook_finish_editing): Fixed more ugly.
* src/gutils.c (gnumeric_sys_glade_dir): Fixed ugly indentation.
(gnumeric_usr_plugin_dir): More ugly stuff fixed.
(gnumeric_usr_dir): Removed ugly const.
2000-05-02 Miguel de Icaza <miguel@helixcode.com>
* src/item-edit.h: New ::entry member, auto_max_size, auto_complete_text
* src/item-edit.c (item_edit_draw_text): Take an ItemEdit as a
first argument, and reduce the cluttered arguments we were
passing.
(item_edit_draw): Cursor_pos is now only the position, it is not
overloaded with show/hide cursor as well.
(item_edit_draw_text): Update acoordingly.
(item_edit_draw_cursor): This new routine paints the cursor only.
(item_edit_set_arg): Add a new signal handler for "activated" on
the entry
(cb_item_edit_cursor_blink): Removed FIXME.
(item_edit_set_arg): Init item_edit->entry. I am pretty sure this
existed in the past.
2000-05-01 Miguel de Icaza <miguel@helixcode.com>
* src/item-edit.c (item_edit_draw): Pass auto-completing flag.
(item_edit_draw_text): Invert auto-complete region.
(item_edit_set_arg): Init auto_completing here.
(item_edit_complete_notify): Set the entry from the
auto-completing data here.
2000-06-05 Jody Goldberg <jgoldberg@home.com>
* src/sheet.c (sheet_cell_expr_{link,unlink}) : renamed from
......
2000-06-05 Miguel de Icaza <miguel@helixcode.com>
* src/gnumeric-util.c (gtk_radio_button_select): Add
precondition. Chema found this, but we should add the proper
check at an upper layer.
2000-06-04 Miguel de Icaza <miguel@helixcode.com>
* src/gnumeric-util.c (gnumeric_entry_at_subexpr_boundary_p):
Change prototype to use GtkEntry instead of GtkWidget.
* src/workbook-edit.c (workbook_finish_editing): Changed direct access to
workbook->private_entry to workbook_get_entry.
(entry_changed): ditto.
(workbook_start_editing_at_cursor): ditto.
(workbook_editing_expr): ditto.
(workbook_edit_get_display_text): ditto.
* src/workbook.c (autosum_cmd): Changed direct access to
workbook->private_entry to workbook_get_entry.
(do_focus_sheet): ditto.
(wb_edit_key_pressed): ditto.
(workbook_setup_edit_area): ditto.
* src/workbook.c (cb_autofunction): ditto.
* src/workbook-private.h: Make edit_line a structure to keep track
of the entry and its signal changed. Also take a chance to change
this to the self descriptive GtkEntry instead of GtkWidget.
* src/commands.c (cmd_set_text): Added const here.
* src/workbook.c (workbook_do_destroy): Add destroy notification
for the editing facilities
* src/item-edit.c (item_edit_set_arg): removed auto complete code
from here.
2000-06-03 Miguel de Icaza <miguel@helixcode.com>
* src/workbook-edit.c, src/workbook-edit.h: New files. Moved
workbook_start_editing_at_cursor, workbook_finish_editing,
workbook_get_entry, workbook_editing_expr here. Killed
workbook_set_entry prototype.
* src/workbook.c (workbook_start_editing_at_cursor): Moved
autocomplete here.
* src/workbook.h: Removed warning. #include <config.h> is a
mandatory header file in every C file. A correct approach is to
use something like Nautilus' perl script that verifies the
presence of config.h as the first include.
* src/workbook.c (close_cmd): Removed ulgy (void)
(quit_cmd): More.
(sheet_action_rename_sheet): more.
(workbook_finish_editing): Fixed more ugly.
* src/gutils.c (gnumeric_sys_glade_dir): Fixed ugly indentation.
(gnumeric_usr_plugin_dir): More ugly stuff fixed.
(gnumeric_usr_dir): Removed ugly const.
2000-05-02 Miguel de Icaza <miguel@helixcode.com>
* src/item-edit.h: New ::entry member, auto_max_size, auto_complete_text
* src/item-edit.c (item_edit_draw_text): Take an ItemEdit as a
first argument, and reduce the cluttered arguments we were
passing.
(item_edit_draw): Cursor_pos is now only the position, it is not
overloaded with show/hide cursor as well.
(item_edit_draw_text): Update acoordingly.
(item_edit_draw_cursor): This new routine paints the cursor only.
(item_edit_set_arg): Add a new signal handler for "activated" on
the entry
(cb_item_edit_cursor_blink): Removed FIXME.
(item_edit_set_arg): Init item_edit->entry. I am pretty sure this
existed in the past.
2000-05-01 Miguel de Icaza <miguel@helixcode.com>
* src/item-edit.c (item_edit_draw): Pass auto-completing flag.
(item_edit_draw_text): Invert auto-complete region.
(item_edit_set_arg): Init auto_completing here.
(item_edit_complete_notify): Set the entry from the
auto-completing data here.
2000-06-05 Jody Goldberg <jgoldberg@home.com>
* src/sheet.c (sheet_cell_expr_{link,unlink}) : renamed from
......
2000-06-05 Miguel de Icaza <miguel@helixcode.com>
* src/gnumeric-util.c (gtk_radio_button_select): Add
precondition. Chema found this, but we should add the proper
check at an upper layer.
2000-06-04 Miguel de Icaza <miguel@helixcode.com>
* src/gnumeric-util.c (gnumeric_entry_at_subexpr_boundary_p):
Change prototype to use GtkEntry instead of GtkWidget.
* src/workbook-edit.c (workbook_finish_editing): Changed direct access to
workbook->private_entry to workbook_get_entry.
(entry_changed): ditto.
(workbook_start_editing_at_cursor): ditto.
(workbook_editing_expr): ditto.
(workbook_edit_get_display_text): ditto.
* src/workbook.c (autosum_cmd): Changed direct access to
workbook->private_entry to workbook_get_entry.
(do_focus_sheet): ditto.
(wb_edit_key_pressed): ditto.
(workbook_setup_edit_area): ditto.
* src/workbook.c (cb_autofunction): ditto.
* src/workbook-private.h: Make edit_line a structure to keep track
of the entry and its signal changed. Also take a chance to change
this to the self descriptive GtkEntry instead of GtkWidget.
* src/commands.c (cmd_set_text): Added const here.
* src/workbook.c (workbook_do_destroy): Add destroy notification
for the editing facilities
* src/item-edit.c (item_edit_set_arg): removed auto complete code
from here.
2000-06-03 Miguel de Icaza <miguel@helixcode.com>
* src/workbook-edit.c, src/workbook-edit.h: New files. Moved
workbook_start_editing_at_cursor, workbook_finish_editing,
workbook_get_entry, workbook_editing_expr here. Killed
workbook_set_entry prototype.
* src/workbook.c (workbook_start_editing_at_cursor): Moved
autocomplete here.
* src/workbook.h: Removed warning. #include <config.h> is a
mandatory header file in every C file. A correct approach is to
use something like Nautilus' perl script that verifies the
presence of config.h as the first include.
* src/workbook.c (close_cmd): Removed ulgy (void)
(quit_cmd): More.
(sheet_action_rename_sheet): more.
(workbook_finish_editing): Fixed more ugly.
* src/gutils.c (gnumeric_sys_glade_dir): Fixed ugly indentation.
(gnumeric_usr_plugin_dir): More ugly stuff fixed.
(gnumeric_usr_dir): Removed ugly const.
2000-05-02 Miguel de Icaza <miguel@helixcode.com>
* src/item-edit.h: New ::entry member, auto_max_size, auto_complete_text
* src/item-edit.c (item_edit_draw_text): Take an ItemEdit as a
first argument, and reduce the cluttered arguments we were
passing.
(item_edit_draw): Cursor_pos is now only the position, it is not
overloaded with show/hide cursor as well.
(item_edit_draw_text): Update acoordingly.
(item_edit_draw_cursor): This new routine paints the cursor only.
(item_edit_set_arg): Add a new signal handler for "activated" on
the entry
(cb_item_edit_cursor_blink): Removed FIXME.
(item_edit_set_arg): Init item_edit->entry. I am pretty sure this
existed in the past.
2000-05-01 Miguel de Icaza <miguel@helixcode.com>
* src/item-edit.c (item_edit_draw): Pass auto-completing flag.
(item_edit_draw_text): Invert auto-complete region.
(item_edit_set_arg): Init auto_completing here.
(item_edit_complete_notify): Set the entry from the
auto-completing data here.
2000-06-05 Jody Goldberg <jgoldberg@home.com>
* src/sheet.c (sheet_cell_expr_{link,unlink}) : renamed from
......
2000-06-05 Miguel de Icaza <miguel@helixcode.com>
* src/gnumeric-util.c (gtk_radio_button_select): Add
precondition. Chema found this, but we should add the proper
check at an upper layer.
2000-06-04 Miguel de Icaza <miguel@helixcode.com>
* src/gnumeric-util.c (gnumeric_entry_at_subexpr_boundary_p):
Change prototype to use GtkEntry instead of GtkWidget.
* src/workbook-edit.c (workbook_finish_editing): Changed direct access to
workbook->private_entry to workbook_get_entry.
(entry_changed): ditto.
(workbook_start_editing_at_cursor): ditto.
(workbook_editing_expr): ditto.
(workbook_edit_get_display_text): ditto.
* src/workbook.c (autosum_cmd): Changed direct access to
workbook->private_entry to workbook_get_entry.
(do_focus_sheet): ditto.
(wb_edit_key_pressed): ditto.
(workbook_setup_edit_area): ditto.
* src/workbook.c (cb_autofunction): ditto.
* src/workbook-private.h: Make edit_line a structure to keep track
of the entry and its signal changed. Also take a chance to change
this to the self descriptive GtkEntry instead of GtkWidget.
* src/commands.c (cmd_set_text): Added const here.
* src/workbook.c (workbook_do_destroy): Add destroy notification
for the editing facilities
* src/item-edit.c (item_edit_set_arg): removed auto complete code
from here.
2000-06-03 Miguel de Icaza <miguel@helixcode.com>
* src/workbook-edit.c, src/workbook-edit.h: New files. Moved
workbook_start_editing_at_cursor, workbook_finish_editing,
workbook_get_entry, workbook_editing_expr here. Killed
workbook_set_entry prototype.
* src/workbook.c (workbook_start_editing_at_cursor): Moved
autocomplete here.
* src/workbook.h: Removed warning. #include <config.h> is a
mandatory header file in every C file. A correct approach is to
use something like Nautilus' perl script that verifies the
presence of config.h as the first include.
* src/workbook.c (close_cmd): Removed ulgy (void)
(quit_cmd): More.
(sheet_action_rename_sheet): more.
(workbook_finish_editing): Fixed more ugly.
* src/gutils.c (gnumeric_sys_glade_dir): Fixed ugly indentation.
(gnumeric_usr_plugin_dir): More ugly stuff fixed.
(gnumeric_usr_dir): Removed ugly const.
2000-05-02 Miguel de Icaza <miguel@helixcode.com>
* src/item-edit.h: New ::entry member, auto_max_size, auto_complete_text
* src/item-edit.c (item_edit_draw_text): Take an ItemEdit as a
first argument, and reduce the cluttered arguments we were
passing.
(item_edit_draw): Cursor_pos is now only the position, it is not
overloaded with show/hide cursor as well.
(item_edit_draw_text): Update acoordingly.
(item_edit_draw_cursor): This new routine paints the cursor only.
(item_edit_set_arg): Add a new signal handler for "activated" on
the entry
(cb_item_edit_cursor_blink): Removed FIXME.
(item_edit_set_arg): Init item_edit->entry. I am pretty sure this
existed in the past.
2000-05-01 Miguel de Icaza <miguel@helixcode.com>
* src/item-edit.c (item_edit_draw): Pass auto-completing flag.
(item_edit_draw_text): Invert auto-complete region.
(item_edit_set_arg): Init auto_completing here.
(item_edit_complete_notify): Set the entry from the
auto-completing data here.
2000-06-05 Jody Goldberg <jgoldberg@home.com>
* src/sheet.c (sheet_cell_expr_{link,unlink}) : renamed from
......
2000-06-05 Miguel de Icaza <miguel@helixcode.com>
* src/gnumeric-util.c (gtk_radio_button_select): Add
precondition. Chema found this, but we should add the proper
check at an upper layer.
2000-06-04 Miguel de Icaza <miguel@helixcode.com>
* src/gnumeric-util.c (gnumeric_entry_at_subexpr_boundary_p):
Change prototype to use GtkEntry instead of GtkWidget.
* src/workbook-edit.c (workbook_finish_editing): Changed direct access to
workbook->private_entry to workbook_get_entry.
(entry_changed): ditto.
(workbook_start_editing_at_cursor): ditto.
(workbook_editing_expr): ditto.
(workbook_edit_get_display_text): ditto.
* src/workbook.c (autosum_cmd): Changed direct access to
workbook->private_entry to workbook_get_entry.
(do_focus_sheet): ditto.
(wb_edit_key_pressed): ditto.
(workbook_setup_edit_area): ditto.
* src/workbook.c (cb_autofunction): ditto.
* src/workbook-private.h: Make edit_line a structure to keep track
of the entry and its signal changed. Also take a chance to change
this to the self descriptive GtkEntry instead of GtkWidget.
* src/commands.c (cmd_set_text): Added const here.
* src/workbook.c (workbook_do_destroy): Add destroy notification
for the editing facilities
* src/item-edit.c (item_edit_set_arg): removed auto complete code
from here.
2000-06-03 Miguel de Icaza <miguel@helixcode.com>
* src/workbook-edit.c, src/workbook-edit.h: New files. Moved
workbook_start_editing_at_cursor, workbook_finish_editing,
workbook_get_entry, workbook_editing_expr here. Killed
workbook_set_entry prototype.
* src/workbook.c (workbook_start_editing_at_cursor): Moved
autocomplete here.
* src/workbook.h: Removed warning. #include <config.h> is a
mandatory header file in every C file. A correct approach is to
use something like Nautilus' perl script that verifies the
presence of config.h as the first include.
* src/workbook.c (close_cmd): Removed ulgy (void)
(quit_cmd): More.
(sheet_action_rename_sheet): more.
(workbook_finish_editing): Fixed more ugly.
* src/gutils.c (gnumeric_sys_glade_dir): Fixed ugly indentation.
(gnumeric_usr_plugin_dir): More ugly stuff fixed.
(gnumeric_usr_dir): Removed ugly const.
2000-05-02 Miguel de Icaza <miguel@helixcode.com>
* src/item-edit.h: New ::entry member, auto_max_size, auto_complete_text
* src/item-edit.c (item_edit_draw_text): Take an ItemEdit as a
first argument, and reduce the cluttered arguments we were
passing.
(item_edit_draw): Cursor_pos is now only the position, it is not
overloaded with show/hide cursor as well.
(item_edit_draw_text): Update acoordingly.
(item_edit_draw_cursor): This new routine paints the cursor only.
(item_edit_set_arg): Add a new signal handler for "activated" on
the entry
(cb_item_edit_cursor_blink): Removed FIXME.
(item_edit_set_arg): Init item_edit->entry. I am pretty sure this
existed in the past.
2000-05-01 Miguel de Icaza <miguel@helixcode.com>
* src/item-edit.c (item_edit_draw): Pass auto-completing flag.
(item_edit_draw_text): Invert auto-complete region.
(item_edit_set_arg): Init auto_completing here.
(item_edit_complete_notify): Set the entry from the
auto-completing data here.
2000-06-05 Jody Goldberg <jgoldberg@home.com>
* src/sheet.c (sheet_cell_expr_{link,unlink}) : renamed from
......
2000-06-05 Miguel de Icaza <miguel@helixcode.com>
* src/gnumeric-util.c (gtk_radio_button_select): Add
precondition. Chema found this, but we should add the proper
check at an upper layer.
2000-06-04 Miguel de Icaza <miguel@helixcode.com>
* src/gnumeric-util.c (gnumeric_entry_at_subexpr_boundary_p):
Change prototype to use GtkEntry instead of GtkWidget.
* src/workbook-edit.c (workbook_finish_editing): Changed direct access to
workbook->private_entry to workbook_get_entry.
(entry_changed): ditto.
(workbook_start_editing_at_cursor): ditto.
(workbook_editing_expr): ditto.
(workbook_edit_get_display_text): ditto.
* src/workbook.c (autosum_cmd): Changed direct access to
workbook->private_entry to workbook_get_entry.
(do_focus_sheet): ditto.
(wb_edit_key_pressed): ditto.
(workbook_setup_edit_area): ditto.
* src/workbook.c (cb_autofunction): ditto.
* src/workbook-private.h: Make edit_line a structure to keep track
of the entry and its signal changed. Also take a chance to change
this to the self descriptive GtkEntry instead of GtkWidget.
* src/commands.c (cmd_set_text): Added const here.
* src/workbook.c (workbook_do_destroy): Add destroy notification
for the editing facilities
* src/item-edit.c (item_edit_set_arg): removed auto complete code
from here.
2000-06-03 Miguel de Icaza <miguel@helixcode.com>
* src/workbook-edit.c, src/workbook-edit.h: New files. Moved
workbook_start_editing_at_cursor, workbook_finish_editing,
workbook_get_entry, workbook_editing_expr here. Killed
workbook_set_entry prototype.
* src/workbook.c (workbook_start_editing_at_cursor): Moved
autocomplete here.
* src/workbook.h: Removed warning. #include <config.h> is a
mandatory header file in every C file. A correct approach is to
use something like Nautilus' perl script that verifies the
presence of config.h as the first include.
* src/workbook.c (close_cmd): Removed ulgy (void)
(quit_cmd): More.
(sheet_action_rename_sheet): more.
(workbook_finish_editing): Fixed more ugly.
* src/gutils.c (gnumeric_sys_glade_dir): Fixed ugly indentation.
(gnumeric_usr_plugin_dir): More ugly stuff fixed.
(gnumeric_usr_dir): Removed ugly const.
2000-05-02 Miguel de Icaza <miguel@helixcode.com>
* src/item-edit.h: New ::entry member, auto_max_size, auto_complete_text
* src/item-edit.c (item_edit_draw_text): Take an ItemEdit as a
first argument, and reduce the cluttered arguments we were
passing.
(item_edit_draw): Cursor_pos is now only the position, it is not
overloaded with show/hide cursor as well.
(item_edit_draw_text): Update acoordingly.
(item_edit_draw_cursor): This new routine paints the cursor only.
(item_edit_set_arg): Add a new signal handler for "activated" on
the entry
(cb_item_edit_cursor_blink): Removed FIXME.
(item_edit_set_arg): Init item_edit->entry. I am pretty sure this
existed in the past.
2000-05-01 Miguel de Icaza <miguel@helixcode.com>
* src/item-edit.c (item_edit_draw): Pass auto-completing flag.
(item_edit_draw_text): Invert auto-complete region.
(item_edit_set_arg): Init auto_completing here.
(item_edit_complete_notify): Set the entry from the
auto-completing data here.
2000-06-05 Jody Goldberg <jgoldberg@home.com>
* src/sheet.c (sheet_cell_expr_{link,unlink}) : renamed from
......
2000-06-05 Miguel de Icaza <miguel@helixcode.com>
* src/gnumeric-util.c (gtk_radio_button_select): Add
precondition. Chema found this, but we should add the proper
check at an upper layer.
2000-06-04 Miguel de Icaza <miguel@helixcode.com>
* src/gnumeric-util.c (gnumeric_entry_at_subexpr_boundary_p):
Change prototype to use GtkEntry instead of GtkWidget.
* src/workbook-edit.c (workbook_finish_editing): Changed direct access to
workbook->private_entry to workbook_get_entry.
(entry_changed): ditto.
(workbook_start_editing_at_cursor): ditto.
(workbook_editing_expr): ditto.
(workbook_edit_get_display_text): ditto.
* src/workbook.c (autosum_cmd): Changed direct access to
workbook->private_entry to workbook_get_entry.
(do_focus_sheet): ditto.
(wb_edit_key_pressed): ditto.
(workbook_setup_edit_area): ditto.
* src/workbook.c (cb_autofunction): ditto.
* src/workbook-private.h: Make edit_line a structure to keep track
of the entry and its signal changed. Also take a chance to change
this to the self descriptive GtkEntry instead of GtkWidget.
* src/commands.c (cmd_set_text): Added const here.
* src/workbook.c (workbook_do_destroy): Add destroy notification
for the editing facilities
* src/item-edit.c (item_edit_set_arg): removed auto complete code
from here.
2000-06-03 Miguel de Icaza <miguel@helixcode.com>
* src/workbook-edit.c, src/workbook-edit.h: New files. Moved
workbook_start_editing_at_cursor, workbook_finish_editing,
workbook_get_entry, workbook_editing_expr here. Killed
workbook_set_entry prototype.
* src/workbook.c (workbook_start_editing_at_cursor): Moved
autocomplete here.
* src/workbook.h: Removed warning. #include <config.h> is a
mandatory header file in every C file. A correct approach is to
use something like Nautilus' perl script that verifies the
presence of config.h as the first include.
* src/workbook.c (close_cmd): Removed ulgy (void)
(quit_cmd): More.
(sheet_action_rename_sheet): more.
(workbook_finish_editing): Fixed more ugly.
* src/gutils.c (gnumeric_sys_glade_dir): Fixed ugly indentation.
(gnumeric_usr_plugin_dir): More ugly stuff fixed.
(gnumeric_usr_dir): Removed ugly const.
2000-05-02 Miguel de Icaza <miguel@helixcode.com>
* src/item-edit.h: New ::entry member, auto_max_size, auto_complete_text
* src/item-edit.c (item_edit_draw_text): Take an ItemEdit as a
first argument, and reduce the cluttered arguments we were
passing.
(item_edit_draw): Cursor_pos is now only the position, it is not
overloaded with show/hide cursor as well.
(item_edit_draw_text): Update acoordingly.
(item_edit_draw_cursor): This new routine paints the cursor only.
(item_edit_set_arg): Add a new signal handler for "activated" on
the entry
(cb_item_edit_cursor_blink): Removed FIXME.
(item_edit_set_arg): Init item_edit->entry. I am pretty sure this
existed in the past.
2000-05-01 Miguel de Icaza <miguel@helixcode.com>
* src/item-edit.c (item_edit_draw): Pass auto-completing flag.
(item_edit_draw_text): Invert auto-complete region.
(item_edit_set_arg): Init auto_completing here.
(item_edit_complete_notify): Set the entry from the
auto-completing data here.
2000-06-05 Jody Goldberg <jgoldberg@home.com>
* src/sheet.c (sheet_cell_expr_{link,unlink}) : renamed from
......
......@@ -204,6 +204,8 @@ GNUMERIC_BASE_SOURCES = \
workbook.h \
workbook-cmd-format.c \
workbook-cmd-format.h \
workbook-edit.c \
workbook-edit.h \
workbook-format-toolbar.c \
workbook-format-toolbar.h \
workbook-private.h \
......
......@@ -86,9 +86,9 @@ application_clipboard_clear (void)
app.clipboard_sheet = NULL;
/* Release the selection */
(void) gtk_selection_owner_set (NULL,
GDK_SELECTION_PRIMARY,
GDK_CURRENT_TIME);
gtk_selection_owner_set (NULL,
GDK_SELECTION_PRIMARY,
GDK_CURRENT_TIME);
}
}
......
......@@ -11,8 +11,8 @@
#include "color.h"
struct LineDotPattern {
gint const elements;
unsigned char * const pattern;
gint const elements;
const unsigned char * const pattern;
double * const pattern_d;
};
......@@ -200,6 +200,7 @@ style_border_set_gc_dash (GdkGC *gc, StyleBorderType const line_type)
if (style_border_data[i].pattern != NULL) {
struct LineDotPattern const * const pat =
style_border_data[i].pattern;
gdk_gc_set_dashes (gc, style_border_data[i].offset,
pat->pattern, pat->elements);
}
......
......@@ -309,7 +309,7 @@ cmd_paste (CommandContext *context, PasteTarget const *pt, guint32 time)
} else if ((dst.end.col - dst.start.col) != cols ||
(dst.end.row - dst.start.row) != rows) {
char * msg = g_strdup_printf (
char *msg = g_strdup_printf (
_("destination has a different shape (%dRx%dC) than the original (%dRx%dC)\n\n"
"Try selecting a single cell or an area of the same shape and size."),
(dst.end.row - dst.start.row)+1,
......
......@@ -393,7 +393,7 @@ cmd_set_text_destroy (GtkObject *cmd)
gboolean
cmd_set_text (CommandContext *context,
Sheet *sheet, CellPos const *pos,
char *new_text)
const char *new_text)
{
static int const max_descriptor_width = 15;
......@@ -680,9 +680,9 @@ cmd_ins_del_row_col_undo (GnumericCommand *cmd, CommandContext *context)
/* restore row/col contents */
if (me->is_cols)
(void) range_init (&r, index, 0, index, SHEET_MAX_ROWS-1);
range_init (&r, index, 0, index, SHEET_MAX_ROWS-1);
else
(void) range_init (&r, 0, index, SHEET_MAX_COLS-1, index);
range_init (&r, 0, index, SHEET_MAX_COLS-1, index);
clipboard_paste_region (context,
paste_target_init (&pt, me->sheet, &r, PASTE_ALL_TYPES),
......
......@@ -10,13 +10,13 @@ void command_redo (CommandContext *context, Workbook *wb);
void command_list_release (GSList *cmds);
gboolean cmd_set_text (CommandContext *context, Sheet *sheet,
CellPos const *pos, char *new_text);
CellPos const *pos, const char *new_text);
gboolean cmd_area_set_text (CommandContext *context, EvalPos const *pos,
char const *text, gboolean as_array);
const char *text, gboolean as_array);
gboolean cmd_set_date_time (CommandContext *context, Sheet *sheet,
CellPos const *pos, gboolean is_date);
const CellPos *pos, gboolean is_date);
gboolean cmd_insert_cols (CommandContext *context, Sheet *sheet,
int start_col, int count);
......@@ -31,12 +31,12 @@ gboolean cmd_resize_row_col (CommandContext *context, Sheet *sheet,
int index, gboolean is_col);
gboolean cmd_paste_cut (CommandContext *context,
ExprRelocateInfo const *info);
const ExprRelocateInfo *info);
gboolean cmd_paste_copy (CommandContext *context,
PasteTarget const *pt, CellRegion *content);
const PasteTarget *pt, CellRegion *content);
gboolean cmd_rename_sheet (CommandContext *context, Workbook *wb,
char const *old_name, char const *new_name);
const char *old_name, const char *new_name);
gboolean cmd_sort (CommandContext *context, Sheet *sheet,
Range *range, SortClause *clauses,
......
......@@ -65,9 +65,8 @@ complete_idle (gpointer data)
abort ();
}
if (ACC(complete)->search_iteration (complete)){
if (ACC(complete)->search_iteration (complete))
return TRUE;
}
complete->idle_tag = 0;
......
......@@ -415,7 +415,7 @@ Sheet_cell_get_value (PortableServer_Servant servant,
static void
Sheet_cell_set_text (PortableServer_Servant servant,
const CORBA_long col, const CORBA_long row,
const CORBA_char * text, CORBA_Environment *ev)