Commit 98b56f53 authored by Morten Welinder's avatar Morten Welinder

xls: don't write hyperlinks to biff7

The records are meant for biff8 only and need to be written with unicode
which we end up doing wrong.
parent d45358be
......@@ -8,6 +8,7 @@ Morten:
* Fix xlsx import with missing header/footer. [#778292]
* Minor xlsx import improvements with alias colors.
* Test suite improvements.
* Improve Excel handling of hyperlinks.
--------------------------------------------------------------------------
Gnumeric 1.12.33
......
2017-02-18 Morten Welinder <terra@gnome.org>
* ms-excel-write.c (excel_write_sheet): Don't write hyperlinks to
biff7 and before. The strings come out wrong.
* xlsx-write.c (xlsx_write_hlinks): Impose an ordering on links.
2017-02-16 Jean Brefort <jean.brefort@normalesup.org>
......
......@@ -5712,7 +5712,10 @@ excel_write_sheet (ExcelWriteState *ewb, ExcelWriteSheet *esheet)
* things will just ignore them */
excel_write_MERGECELLs (ewb->bp, esheet);
excel_write_conditions (ewb->bp, esheet);
excel_write_HLINKs (ewb->bp, esheet);
if (ewb->bp->version >= MS_BIFF_V8) {
// We won't write these right pre-v8
excel_write_HLINKs (ewb->bp, esheet);
}
excel_write_DVALs (ewb->bp, esheet);
excel_write_SHEETPROTECTION (ewb->bp, esheet->gnum_sheet);
......
......@@ -4,6 +4,7 @@
use strict;
use lib ($0 =~ m|^(.*/)| ? $1 : ".");
use GnumericTest;
$GnumericTest::default_subtests = '*,-biff7';
my $file = "$samples/hlink-tests.gnumeric";
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment