Commit 8e1c25c3 authored by Morten Welinder's avatar Morten Welinder Committed by Morten Welinder

isdigit takes unsigned chars, not chars.

2000-09-19  Morten Welinder  <terra@diku.dk>

	* src/workbook.c (workbook_sheet_name_strip_number): isdigit takes
 	unsigned chars, not chars.

	* src/functions/fn-lookup.c (find_index_linear): Quiet warnings.


2000-09-19  Morten Welinder <terra@diku.dk>

	* applix-read.c (applix_read_colormap): isdigit takes unsigned
 	chars, not chars.
	(applix_parse_style): Ditto.
	(applix_read_impl): Ditto.
parent c1c9fb44
......@@ -10,8 +10,6 @@ Release Critical
- Evaluate (i.e., eliminate) all instances of "foo == TRUE" in the code.
They're too error prone for comfort.
- Re-check all isdigit/isalpha/toupper/... calls. Arguments must be
unsigned chars, not chars. (Will do this using gcc -- MW.)
Post 0.57 Changes
-----------------
......
2000-09-19 Morten Welinder <terra@diku.dk>
* src/workbook.c (workbook_sheet_name_strip_number): isdigit takes
unsigned chars, not chars.
* src/functions/fn-lookup.c (find_index_linear): Quiet warnings.
2000-09-18 Michael Meeks <michael@helixcode.com>
* src/Makefile.am (INCLUDES): add GNOME_DATADIR
......
2000-09-19 Morten Welinder <terra@diku.dk>
* src/workbook.c (workbook_sheet_name_strip_number): isdigit takes
unsigned chars, not chars.
* src/functions/fn-lookup.c (find_index_linear): Quiet warnings.
2000-09-18 Michael Meeks <michael@helixcode.com>
* src/Makefile.am (INCLUDES): add GNOME_DATADIR
......
2000-09-19 Morten Welinder <terra@diku.dk>
* src/workbook.c (workbook_sheet_name_strip_number): isdigit takes
unsigned chars, not chars.
* src/functions/fn-lookup.c (find_index_linear): Quiet warnings.
2000-09-18 Michael Meeks <michael@helixcode.com>
* src/Makefile.am (INCLUDES): add GNOME_DATADIR
......
2000-09-19 Morten Welinder <terra@diku.dk>
* src/workbook.c (workbook_sheet_name_strip_number): isdigit takes
unsigned chars, not chars.
* src/functions/fn-lookup.c (find_index_linear): Quiet warnings.
2000-09-18 Michael Meeks <michael@helixcode.com>
* src/Makefile.am (INCLUDES): add GNOME_DATADIR
......
2000-09-19 Morten Welinder <terra@diku.dk>
* src/workbook.c (workbook_sheet_name_strip_number): isdigit takes
unsigned chars, not chars.
* src/functions/fn-lookup.c (find_index_linear): Quiet warnings.
2000-09-18 Michael Meeks <michael@helixcode.com>
* src/Makefile.am (INCLUDES): add GNOME_DATADIR
......
2000-09-19 Morten Welinder <terra@diku.dk>
* src/workbook.c (workbook_sheet_name_strip_number): isdigit takes
unsigned chars, not chars.
* src/functions/fn-lookup.c (find_index_linear): Quiet warnings.
2000-09-18 Michael Meeks <michael@helixcode.com>
* src/Makefile.am (INCLUDES): add GNOME_DATADIR
......
2000-09-19 Morten Welinder <terra@diku.dk>
* src/workbook.c (workbook_sheet_name_strip_number): isdigit takes
unsigned chars, not chars.
* src/functions/fn-lookup.c (find_index_linear): Quiet warnings.
2000-09-18 Michael Meeks <michael@helixcode.com>
* src/Makefile.am (INCLUDES): add GNOME_DATADIR
......
......@@ -36,6 +36,7 @@ You need:
gtk+ >= 1.2.7 (gnome-libs 1.3 is not supported)
gnome-xml == 1.8.7 (gnome-xml 2.x not supported yet)
NOTE : gnome-xml is also known as libxml
gal >= 0.0.1
Optionally:
bonobo == 0.17
......
......@@ -20,6 +20,7 @@ Requires: gnome-print >= 0.21
Requires: libglade >= 0.13
Requires: libxml >= 1.8.5
Requires: libole2 >= 0.1.4
Requires: gal >= 0.0.1
%description
GNOME (GNU Network Object Model Environment) is a user-friendly set of
......
2000-09-19 Morten Welinder <terra@diku.dk>
* applix-read.c (applix_read_colormap): isdigit takes unsigned
chars, not chars.
(applix_parse_style): Ditto.
(applix_read_impl): Ditto.
2000-09-06 Jody Goldberg <jgoldberg@home.com>
* applix-read.c (applix_get_sheet) : changes to signature of
......
......@@ -153,7 +153,7 @@ applix_read_colormap (ApplixReadState *state)
iter = pos;
for (count = 6; --count >= 0; pos = iter) {
char *end;
while (--iter > buffer && isdigit (*iter))
while (--iter > buffer && isdigit ((unsigned char)*iter))
;
if (iter <= buffer || *iter != ' ')
......@@ -311,7 +311,7 @@ applix_parse_style (ApplixReadState *state, char **buffer)
/* Formating and alignment */
for (; *sep && *sep != '|' && *sep != ')' ; ) {
if (isdigit (*sep)) {
if (isdigit ((unsigned char)*sep)) {
StyleHAlignFlags a;
switch (*sep) {
case '1' : a = HALIGN_LEFT; break;
......@@ -369,7 +369,7 @@ applix_parse_style (ApplixReadState *state, char **buffer)
break;
}
if (!isdigit (sep[1]) ||
if (!isdigit ((unsigned char)sep[1]) ||
(0 == (id = strtol (sep+1, &end, 10))) ||
sep+1 == end ||
id < 1 || id > 15)
......@@ -1278,7 +1278,7 @@ applix_read_impl (ApplixReadState *state)
return applix_parse_error (state, "Invalid row format attr index");
/* Just for kicks they added a trailing space */
} while (tmp[0] && isdigit (tmp[1]));
} while (tmp[0] && isdigit ((unsigned char)tmp[1]));
}
/* FIXME : Can we really just ignore all of this ? */
......
......@@ -135,7 +135,7 @@ find_index_linear (FunctionEvalInfo *ei, Value *find, Value *data,
comp = value_compare (find, v, FALSE);
if (type >= 1 && comp == IS_GREATER) {
ValueCompare comp;
ValueCompare comp = TYPE_MISMATCH;
if (index >= 0) {
comp = value_compare (v, index_val, FALSE);
......@@ -147,7 +147,7 @@ find_index_linear (FunctionEvalInfo *ei, Value *find, Value *data,
index_val = v;
}
} else if (type <= -1 && comp == IS_LESS) {
ValueCompare comp;
ValueCompare comp = TYPE_MISMATCH;
if (index >= 0) {
comp = value_compare (v, index_val, FALSE);
......
......@@ -135,7 +135,7 @@ find_index_linear (FunctionEvalInfo *ei, Value *find, Value *data,
comp = value_compare (find, v, FALSE);
if (type >= 1 && comp == IS_GREATER) {
ValueCompare comp;
ValueCompare comp = TYPE_MISMATCH;
if (index >= 0) {
comp = value_compare (v, index_val, FALSE);
......@@ -147,7 +147,7 @@ find_index_linear (FunctionEvalInfo *ei, Value *find, Value *data,
index_val = v;
}
} else if (type <= -1 && comp == IS_LESS) {
ValueCompare comp;
ValueCompare comp = TYPE_MISMATCH;
if (index >= 0) {
comp = value_compare (v, index_val, FALSE);
......
......@@ -3440,7 +3440,7 @@ static void
workbook_sheet_name_strip_number (char *name, int* number)
{
char *end;
*number = 1;
end = strrchr (name, ')');
......@@ -3449,11 +3449,11 @@ workbook_sheet_name_strip_number (char *name, int* number)
while (--end >= name) {
if (*end == '(') {
*number = atoi (end+1);
*number = atoi (end + 1);
*end = '\0';
return;
}
if (!isdigit(*end))
if (!isdigit ((unsigned char)*end))
return;
}
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment