Commit 89615ea4 authored by Jody Goldberg's avatar Jody Goldberg Committed by Jody Goldberg

Do not do anything if we have not moved.


2000-07-06  Jody Goldberg <jgoldberg@home.com>

	* src/item-cursor.c (item_cursor_do_action) : Do not do anything if we
	  have not moved.
parent 2154ace1
......@@ -4,15 +4,14 @@ and longer term bugs.
Release Critical
----------------
- Changing an expression name that is in use causes a crash.
- Changing the size of all rows/cols creates big xml files.
- Click-and-release on the border of a selection causes an empty "moving
cells" undo record.
- Saving xml should not rely on changing the textdomain to disable translation
of TRUE/FALSE.
Long term breakage
------------------
- Changing an expression name that is in use does not recalc, or regen depends
correctly.
- The max row/col canvas scroll size is still hard coded.
- Increase/Decrease precision toolbar buttons should look at the displayed
......
2000-07-06 Jody Goldberg <jgoldberg@home.com>
* src/item-cursor.c (item_cursor_do_action) : Do not do anything if we
have not moved.
* src/sheet-style.c (sheet_style_compute_from_list) : Make public.
and rename from sheet_mstyle_compute_from_list. Changed all
callers.
......
2000-07-06 Jody Goldberg <jgoldberg@home.com>
* src/item-cursor.c (item_cursor_do_action) : Do not do anything if we
have not moved.
* src/sheet-style.c (sheet_style_compute_from_list) : Make public.
and rename from sheet_mstyle_compute_from_list. Changed all
callers.
......
2000-07-06 Jody Goldberg <jgoldberg@home.com>
* src/item-cursor.c (item_cursor_do_action) : Do not do anything if we
have not moved.
* src/sheet-style.c (sheet_style_compute_from_list) : Make public.
and rename from sheet_mstyle_compute_from_list. Changed all
callers.
......
2000-07-06 Jody Goldberg <jgoldberg@home.com>
* src/item-cursor.c (item_cursor_do_action) : Do not do anything if we
have not moved.
* src/sheet-style.c (sheet_style_compute_from_list) : Make public.
and rename from sheet_mstyle_compute_from_list. Changed all
callers.
......
2000-07-06 Jody Goldberg <jgoldberg@home.com>
* src/item-cursor.c (item_cursor_do_action) : Do not do anything if we
have not moved.
* src/sheet-style.c (sheet_style_compute_from_list) : Make public.
and rename from sheet_mstyle_compute_from_list. Changed all
callers.
......
2000-07-06 Jody Goldberg <jgoldberg@home.com>
* src/item-cursor.c (item_cursor_do_action) : Do not do anything if we
have not moved.
* src/sheet-style.c (sheet_style_compute_from_list) : Make public.
and rename from sheet_mstyle_compute_from_list. Changed all
callers.
......
2000-07-06 Jody Goldberg <jgoldberg@home.com>
* src/item-cursor.c (item_cursor_do_action) : Do not do anything if we
have not moved.
* src/sheet-style.c (sheet_style_compute_from_list) : Make public.
and rename from sheet_mstyle_compute_from_list. Changed all
callers.
......
......@@ -19,6 +19,7 @@
#include "gnumeric-util.h"
#include "cmd-edit.h"
#include "commands.h"
#include "ranges.h"
static GnomeCanvasItem *item_cursor_parent_class;
......@@ -701,6 +702,10 @@ item_cursor_do_action (ItemCursor *item_cursor, ActionType action, guint32 time)
Sheet *sheet = item_cursor->sheet_view->sheet;
Workbook *wb = sheet->workbook;
PasteTarget pt;
Range const *target = selection_first_range (sheet, FALSE);
if (target != NULL && range_equal (target, &item_cursor->pos))
return;
switch (action){
case ACTION_NONE:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment