Commit 6d53c227 authored by Almer S. Tigelaar's avatar Almer S. Tigelaar Committed by Almer S. Tigelaar

Properly initialize the selection_rect. (preview_grid_controller_free) :

2001-02-15  Almer S. Tigelaar  <almer1@dds.nl>

	* preview-grid-controller.c
	(preview_grid_controller_new) : Properly initialize the selection_rect.
	(preview_grid_controller_free) : Remove rect and selection_rect from canvas.

	* templates/autoformat/autoformat.General.advanced.xml : Correct wrongly
	set border.
parent 34d9ed4b
......@@ -5,8 +5,6 @@ and longer term bugs.
Release Critical
----------------
- Fix problem drawing the red selection box for the autoformat preview
Long term breakage
------------------
......
2001-02-15 Almer S. Tigelaar <almer1@dds.nl>
* preview-grid-controller.c
(preview_grid_controller_new) : Properly initialize the selection_rect.
(preview_grid_controller_free) : Remove rect and selection_rect from canvas.
* templates/autoformat/autoformat.General.advanced.xml : Correct wrongly
set border.
2001-02-15 Jody Goldberg <jgoldberg@home.com>
* src/mstyle.c (mstyle_visible_in_blank) : off by one error.
......
2001-02-15 Almer S. Tigelaar <almer1@dds.nl>
* preview-grid-controller.c
(preview_grid_controller_new) : Properly initialize the selection_rect.
(preview_grid_controller_free) : Remove rect and selection_rect from canvas.
* templates/autoformat/autoformat.General.advanced.xml : Correct wrongly
set border.
2001-02-15 Jody Goldberg <jgoldberg@home.com>
* src/mstyle.c (mstyle_visible_in_blank) : off by one error.
......
2001-02-15 Almer S. Tigelaar <almer1@dds.nl>
* preview-grid-controller.c
(preview_grid_controller_new) : Properly initialize the selection_rect.
(preview_grid_controller_free) : Remove rect and selection_rect from canvas.
* templates/autoformat/autoformat.General.advanced.xml : Correct wrongly
set border.
2001-02-15 Jody Goldberg <jgoldberg@home.com>
* src/mstyle.c (mstyle_visible_in_blank) : off by one error.
......
2001-02-15 Almer S. Tigelaar <almer1@dds.nl>
* preview-grid-controller.c
(preview_grid_controller_new) : Properly initialize the selection_rect.
(preview_grid_controller_free) : Remove rect and selection_rect from canvas.
* templates/autoformat/autoformat.General.advanced.xml : Correct wrongly
set border.
2001-02-15 Jody Goldberg <jgoldberg@home.com>
* src/mstyle.c (mstyle_visible_in_blank) : off by one error.
......
2001-02-15 Almer S. Tigelaar <almer1@dds.nl>
* preview-grid-controller.c
(preview_grid_controller_new) : Properly initialize the selection_rect.
(preview_grid_controller_free) : Remove rect and selection_rect from canvas.
* templates/autoformat/autoformat.General.advanced.xml : Correct wrongly
set border.
2001-02-15 Jody Goldberg <jgoldberg@home.com>
* src/mstyle.c (mstyle_visible_in_blank) : off by one error.
......
......@@ -445,7 +445,7 @@ preview_grid_controller_new (GnomeCanvas *canvas,
* The numbers used here are a little less then the ones used for the centering
* rect above. This rect is only drawn when the grid is 'selected'
*/
if (selected)
if (selected) {
controller->selection_rect = GNOME_CANVAS_RECT (gnome_canvas_item_new (gnome_canvas_root (canvas),
gnome_canvas_rect_get_type (),
"x1", -7.0, "y1", -2.5,
......@@ -454,6 +454,9 @@ preview_grid_controller_new (GnomeCanvas *canvas,
"outline_color", "red",
"fill_color", NULL,
NULL));
} else
controller->selection_rect = NULL;
/*
* Set the scroll region to a nice value
*/
......@@ -489,7 +492,10 @@ preview_grid_controller_free (PreviewGridController *controller)
g_free (cell);
}
gtk_object_destroy (GTK_OBJECT (controller->rect));
gtk_object_destroy (GTK_OBJECT (controller->grid));
if (controller->selection_rect)
gtk_object_destroy (GTK_OBJECT (controller->selection_rect));
gnome_canvas_set_scroll_region (controller->canvas, 0, 0, 0, 0);
......
......@@ -20,8 +20,8 @@
<gmr:Bottom Style="2" Color="0:0:0"/>
<gmr:Left Style="0"/>
<gmr:Right Style="0"/>
<gmr:Diagonal Style="2" Color="0:0:0"/>
<gmr:Rev-Diagonal Style="0"/>
<gmr:Diagonal Style="0"/>
<gmr:Rev-Diagonal Style="2" Color="0:0:0"/>
</gmr:StyleBorder>
</gmr:Style>
</gmr:Member>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment