Commit 4fc24a01 authored by Jody Goldberg's avatar Jody Goldberg Committed by Jody Goldberg

handle err == NULL


2005-06-12  Jody Goldberg <jody@gnome.org>

	* src/value.c (value_get_as_bool) : handle err == NULL
parent a4edbf5c
......@@ -8,11 +8,6 @@ release, and longer term bugs.
Release Critical
----------------
: tie the custom ui into action sensitivity pools
: support array evaluation for =LARGE and friends
: TRIMEAN is a list function ?
: ISREF is a list function ?
: http://bugzilla.gnome.org/show_bug.cgi?id=159581
: http://bugzilla.gnome.org/show_bug.cgi?id=162951 : trivial
: Add a note to the SUMPRODUCT docs that
......@@ -60,6 +55,11 @@ Worries
** (gnumeric:3193): WARNING **: Unexpected element 'style:tab-stops' in state properties.
{catch all)} -> {catch all)} -> styles ->
: tie the custom ui into action sensitivity pools
: support array evaluation for =LARGE and friends
: TRIMEAN is a list function ?
: ISREF is a list function ?
-------------------------------------------------------------------------------
Blocked Patches
---------------
......@@ -642,6 +642,11 @@ Short Term Goals
34.8) Track changes to 3d deps during sheet detach for undo. (DONE)
34.9) Rework sheet reorganize dialog to new scheme.
35) Accessibility
We can use
http://bugzilla.gnome.org/attachment.cgi?id=47315&action=view
as a template
Misc stuff that should be fixed
-------------------------------
......
2005-06-12 Jody Goldberg <jody@gnome.org>
* src/value.c (value_get_as_bool) : handle err == NULL
2005-06-12 Morten Welinder <terra@gnome.org>
* src/workbook.c (workbook_detach_view): Just dispose of the view.
......@@ -199,6 +203,10 @@
* tools/gconf-schemas-to-win32-reg.c (convert_schemalist):
Use REGEDIT4 so that Win9x knows.
2005-06-03 Jody Goldberg <jody@gnome.org>
* src/gnumeric.h : s/GnmRow/GnmStyleRow/ That is clearer
2005-06-03 Jody Goldberg <jody@gnome.org>
* configure.in : bump gsf req to 1.12.1 for the new GSF_DYNAMIC_CLASS
......
2005-06-12 Jody Goldberg <jody@gnome.org>
* src/value.c (value_get_as_bool) : handle err == NULL
2005-06-12 Morten Welinder <terra@gnome.org>
* src/workbook.c (workbook_detach_view): Just dispose of the view.
......@@ -199,6 +203,10 @@
* tools/gconf-schemas-to-win32-reg.c (convert_schemalist):
Use REGEDIT4 so that Win9x knows.
2005-06-03 Jody Goldberg <jody@gnome.org>
* src/gnumeric.h : s/GnmRow/GnmStyleRow/ That is clearer
2005-06-03 Jody Goldberg <jody@gnome.org>
* configure.in : bump gsf req to 1.12.1 for the new GSF_DYNAMIC_CLASS
......
......@@ -791,7 +791,8 @@ value_hash (GnmValue const *v)
gboolean
value_get_as_bool (GnmValue const *v, gboolean *err)
{
*err = FALSE;
if (err)
*err = FALSE;
if (v == NULL)
return FALSE;
......@@ -818,7 +819,8 @@ value_get_as_bool (GnmValue const *v, gboolean *err)
case VALUE_CELLRANGE:
case VALUE_ARRAY:
case VALUE_ERROR:
*err = TRUE;
if (err)
*err = TRUE;
}
return FALSE;
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment