Commit 1be76cfa authored by Jody Goldberg's avatar Jody Goldberg Committed by Jody Goldberg

set the expr entry flags for a new series too.

2002-01-05  Jody Goldberg <jody@gnome.org>

	* dialog-graph-guru.c (vector_state_fill) : set the expr entry flags
	  for a new series too.

	* src/workbook-control.c (wb_control_parse_and_jump) : rename from
	  workbook_parse_and_jump to be consistent.

	* configure.in : bump gal version req.
parent 648252d0
......@@ -7,8 +7,6 @@ release, and longer term bugs.
Release Critical
----------------
Up GAL dependency. 0.16, perhaps.
Pending Patches
---------------
......@@ -21,13 +19,9 @@ Long term breakage
- Most arg-type functions need to be somehow marked as strict. Checking for
errors by hand everywhere is silly.
- Add ... in bonobo menus for insert object* and define name
- Add dirty flags to workbook too, adding a sheet should make workbook dirty
not the new sheet.
- Add -Wbad-function-cast and deal with it. Lots of fun here.
- Audit all fixed-length buffers. Most non-time-critical can be replaced
by proper usage of g_strdup_printf.
......@@ -40,8 +34,6 @@ Long term breakage
typically clicks to place the window.) This already works correctly
under many window managers.
- "-display foo:0.0" needs to be handled, somehow.
- Data->Filter dialog
: use expr entry widget.
......
2002-01-05 Jody Goldberg <jody@gnome.org>
* src/workbook-control.c (wb_control_parse_and_jump) : rename from
workbook_parse_and_jump to be consistent.
* configure.in : bump gal version req.
2002-01-04 Jody Goldberg <jody@gnome.org>
* src/commands.c (cmd_insert_rows) : dup the string.
......
......@@ -11,6 +11,7 @@ Jody:
* Support graphs with no data.
* Fix CRASH!! due to last minute translation fix.
* Some warning suppression for s390.
* Bump the GAL requirement to 0.16
Morten:
* Added DATE2UNIX and UNIX2DATE.
......
2002-01-05 Jody Goldberg <jody@gnome.org>
* src/workbook-control.c (wb_control_parse_and_jump) : rename from
workbook_parse_and_jump to be consistent.
* configure.in : bump gal version req.
2002-01-04 Jody Goldberg <jody@gnome.org>
* src/commands.c (cmd_insert_rows) : dup the string.
......
2002-01-05 Jody Goldberg <jody@gnome.org>
* src/workbook-control.c (wb_control_parse_and_jump) : rename from
workbook_parse_and_jump to be consistent.
* configure.in : bump gal version req.
2002-01-04 Jody Goldberg <jody@gnome.org>
* src/commands.c (cmd_insert_rows) : dup the string.
......
2002-01-05 Jody Goldberg <jody@gnome.org>
* src/workbook-control.c (wb_control_parse_and_jump) : rename from
workbook_parse_and_jump to be consistent.
* configure.in : bump gal version req.
2002-01-04 Jody Goldberg <jody@gnome.org>
* src/commands.c (cmd_insert_rows) : dup the string.
......
......@@ -24,7 +24,7 @@ AM_PATH_GTK(1.2.7)
GNOME_COMPILE_WARNINGS
set_mode_warnings=yes
if test "$GCC" = "yes" -a "$set_more_warnings" != "no"; then
for option in -Wsign-promo -Wsign-compare -Wpointer-arith -Wnested-externs -Wchar-subscripts; do
for option in -Wsign-promo -Wsign-compare -Wpointer-arith -Wnested-externs -Wchar-subscripts ; do
SAVE_CFLAGS="$CFLAGS"
CFLAGS="$CFLAGS $option"
AC_MSG_CHECKING([whether gcc understands $option])
......@@ -518,13 +518,13 @@ unset libglade_ok
dnl ******************************
dnl Gnome App Lib checking
dnl ******************************
AC_MSG_CHECKING(for Gnome App libraries (GAL) >= 0.14 )
AC_MSG_CHECKING(for Gnome App libraries (GAL) >= 0.16 )
gal_ok=no
if gnome-config --libs gal > /dev/null 2>&1; then
verstxt=`gnome-config --modversion gal`
vers=`echo "$verstxt" | sed -e "s/gal-//" -e 's/cvs$//' -e 's/pre$//' | \
awk -F. '{ printf "%d", $1*1000000 + $2*10000 + $3*100 + $4; }'`
if test "$vers" -ge 140000; then
if test "$vers" -ge 160000; then
AC_MSG_RESULT($marker_ok found $verstxt)
gal_ok=yes
else
......@@ -534,7 +534,7 @@ else
AC_MSG_RESULT($marker_fail not found)
fi
if test "$gal_ok" = no; then
AC_MSG_ERROR(You need at least GNOME Application libs 0.14 for this version of Gnumeric)
AC_MSG_ERROR(You need at least GNOME Application libs 0.16 for this version of Gnumeric)
fi
unset gal_ok
......
2002-01-05 Jody Goldberg <jody@gnome.org>
* dialog-graph-guru.c (vector_state_fill) : set the expr entry flags
for a new series too.
2002-01-04 Jody Goldberg <jody@gnome.org>
* dialog-graph-guru.c (vector_state_fill) : more protection for
......
......@@ -90,7 +90,7 @@ dialog_goto_cell (WorkbookControlGUI *wbcg)
text = gtk_entry_get_text (GTK_ENTRY (entry));
if (*text){
if (workbook_parse_and_jump (WORKBOOK_CONTROL (wbcg), text)) {
if (wb_control_parse_and_jump (WORKBOOK_CONTROL (wbcg), text)) {
char *tmp[1];
int i = 0;
gboolean existed = FALSE;
......
......@@ -292,17 +292,19 @@ vector_state_fill (VectorState *vs, xmlNode *series)
int id;
g_return_if_fail (!vs->state->updating);
g_return_if_fail (series);
/* clear beforehand to make error handling simpler */
vs->series_index =
e_xml_get_integer_prop_by_name_with_default (series, "index", -1);
vs->state->updating = TRUE;
gnumeric_expr_entry_clear (vs->entry);
gnumeric_expr_entry_set_flags (vs->entry,
GNUM_EE_ABS_COL|GNUM_EE_ABS_ROW, GNUM_EE_MASK);
vs->state->updating = FALSE;
if (series == NULL)
return;
vs->series_index =
e_xml_get_integer_prop_by_name_with_default (series, "index", -1);
vs->vector = NULL;
dim = gnm_graph_series_get_dimension (series, vs->dim_name);
if (dim != NULL) {
......
......@@ -178,7 +178,7 @@ wb_control_cur_sheet (WorkbookControl *wbc)
}
gboolean
workbook_parse_and_jump (WorkbookControl *wbc, const char *text)
wb_control_parse_and_jump (WorkbookControl *wbc, const char *text)
{
int col, row;
......
......@@ -75,6 +75,6 @@ WorkbookView *wb_control_view (WorkbookControl *wbc);
Workbook *wb_control_workbook (WorkbookControl *wbc);
Sheet *wb_control_cur_sheet (WorkbookControl *wbc);
gboolean workbook_parse_and_jump (WorkbookControl *wbc, const char *text);
gboolean wb_control_parse_and_jump (WorkbookControl *wbc, char const *text);
#endif /* GNUMERIC_WORKBOOK_CONTROL_H */
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment