Commit 0d439d13 authored by Jody Goldberg's avatar Jody Goldberg Committed by Jody Goldberg

Fix row/col ins/del problem discovered by JonKare.

2000-08-26  Jody Goldberg <jgoldberg@home.com>

	* src/sheet.c (colrow_move) : Reset the cell positions.
parent fc4aff24
......@@ -8,16 +8,9 @@ Release Critical
calculations to a crawl
- Saving xml should not rely on changing the textdomain to disable translation
of TRUE/FALSE in expressions.
Long term breakage
------------------
- We should save per block maximums.
- Changing an expression name that is in use does not recalc, or regen depends
correctly.
- The max row/col canvas scroll size is still hard coded.
- Copy sheet, and insert new sheet both append to the end of the sheet list
rather than insereting before the current sheet.
- The translate/untranslate routines for formats need to be written
- The currency list in the format dialog needs to be sorted for the locale
- When applying a currency symbol we need to store the NON-localized id.
- Increase/Decrease precision toolbar buttons should look at the displayed
precision for the edit cell and assign the changed value to the entire
selection. Not individually adjusting each non-blank cell's precision.
......@@ -26,8 +19,26 @@ Long term breakage
and remove decimals.
- While we're playing with those functions, lets add simple ones like inc/dec
font size and things like that.
- Copy sheet, and insert new sheet both append to the end of the sheet list
rather than insereting before the current sheet.
Post 0.57 Changes
-----------------
- Fix Borders
- Move the string -> parsing from parser to expr eval.
- Model View Controller
Long term breakage
------------------
- We should save per block maximums.
- Changing an expression name that is in use does not recalc, or regen depends
correctly.
- The max row/col canvas scroll size is still hard coded.
- Auto resize needs to handle empty cells.
- auto-fill does not resize row/col
- The implication of mixed mode references ($B$2:C3)
......
2000-08-26 Jody Goldberg <jgoldberg@home.com>
* src/sheet.c (colrow_move) : Reset the cell positions.
2000-08-25 Jody Goldberg <jgoldberg@home.com>
* Makefile.am : Build gnumeric before its executables.
2000-08-22 Jody Goldberg <jgoldberg@home.com>
* src/sheet.c (sheet_clone_styles) : Init the style tables.
......
2000-08-26 Jody Goldberg <jgoldberg@home.com>
* src/sheet.c (colrow_move) : Reset the cell positions.
2000-08-25 Jody Goldberg <jgoldberg@home.com>
* Makefile.am : Build gnumeric before its executables.
2000-08-22 Jody Goldberg <jgoldberg@home.com>
* src/sheet.c (sheet_clone_styles) : Init the style tables.
......
2000-08-26 Jody Goldberg <jgoldberg@home.com>
* src/sheet.c (colrow_move) : Reset the cell positions.
2000-08-25 Jody Goldberg <jgoldberg@home.com>
* Makefile.am : Build gnumeric before its executables.
2000-08-22 Jody Goldberg <jgoldberg@home.com>
* src/sheet.c (sheet_clone_styles) : Init the style tables.
......
2000-08-26 Jody Goldberg <jgoldberg@home.com>
* src/sheet.c (colrow_move) : Reset the cell positions.
2000-08-25 Jody Goldberg <jgoldberg@home.com>
* Makefile.am : Build gnumeric before its executables.
2000-08-22 Jody Goldberg <jgoldberg@home.com>
* src/sheet.c (sheet_clone_styles) : Init the style tables.
......
2000-08-26 Jody Goldberg <jgoldberg@home.com>
* src/sheet.c (colrow_move) : Reset the cell positions.
2000-08-25 Jody Goldberg <jgoldberg@home.com>
* Makefile.am : Build gnumeric before its executables.
2000-08-22 Jody Goldberg <jgoldberg@home.com>
* src/sheet.c (sheet_clone_styles) : Init the style tables.
......
2000-08-26 Jody Goldberg <jgoldberg@home.com>
* src/sheet.c (colrow_move) : Reset the cell positions.
2000-08-25 Jody Goldberg <jgoldberg@home.com>
* Makefile.am : Build gnumeric before its executables.
2000-08-22 Jody Goldberg <jgoldberg@home.com>
* src/sheet.c (sheet_clone_styles) : Init the style tables.
......
2000-08-26 Jody Goldberg <jgoldberg@home.com>
* src/sheet.c (colrow_move) : Reset the cell positions.
2000-08-25 Jody Goldberg <jgoldberg@home.com>
* Makefile.am : Build gnumeric before its executables.
2000-08-22 Jody Goldberg <jgoldberg@home.com>
* src/sheet.c (sheet_clone_styles) : Init the style tables.
......
......@@ -1888,6 +1888,9 @@ sheet_is_region_empty_or_selected (Sheet *sheet, int start_col, int start_row, i
* @sheet The sheet where the cell is inserted
* @cell The cell, it should already have col/pos pointers
* initialized pointing to the correct ColRowInfo
*
* Cell::pos must be valid before this is called. The position is used as the
* hash key.
*/
static void
sheet_cell_add_to_hash (Sheet *sheet, Cell *cell)
......@@ -2774,6 +2777,7 @@ colrow_move (Sheet *sheet,
ColRowCollection *info_collection,
int const old_pos, int const new_pos)
{
gboolean const is_cols = (info_collection == &sheet->cols);
ColRowInfo **segment = COLROW_GET_SEGMENT(info_collection, old_pos);
ColRowInfo *info = (segment != NULL) ?
segment[COLROW_SUB_INDEX(old_pos)] : NULL;
......@@ -2803,7 +2807,7 @@ colrow_move (Sheet *sheet,
info->pos = new_pos;
/* TODO : Figure out a way to merge these functions */
if (info_collection == &sheet->cols)
if (is_cols)
sheet_col_add (sheet, info);
else
sheet_row_add (sheet, info);
......@@ -2812,6 +2816,11 @@ colrow_move (Sheet *sheet,
for (; cells != NULL ; cells = g_list_remove (cells, cell)) {
cell = cells->data;
if (is_cols)
cell->pos.col = new_pos;
else
cell->pos.row = new_pos;
sheet_cell_add_to_hash (sheet, cell);
cell_relocate (cell, NULL);
cell_content_changed (cell);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment