Commit 0cefc165 authored by Morten Welinder's avatar Morten Welinder

Names: improve check for circular names.

parent db28d0e7
2016-01-01 Morten Welinder <terra@gnome.org>
* src/expr-name.c (expr_name_add): Improve check for circular name
defintion. Fixes #760046.
2015-12-28 Morten Welinder <terra@gnome.org>
* src/ssconvert.c (convert): When separating sheets, move current
......
......@@ -8,6 +8,7 @@ Andreas:
Morten:
* Teach ssconvert to split sheets into separate .txt files [#694408]
* Improve test suite.
* Fuzzed file fix. [#760046]
--------------------------------------------------------------------------
Gnumeric 1.12.26
......
......@@ -711,7 +711,16 @@ expr_name_add (GnmParsePos const *pp, char const *name,
fake_name.str = name;
if (texpr != NULL && expr_name_check_for_loop (name, texpr)) {
if (gnm_debug_flag ("names")) {
char *str = gnm_expr_top_as_string (texpr, pp, NULL);
g_printerr ("Adding Name=[%s] texpr=[%s] stub=[%s]\n",
name, str, stub ? expr_name_name (stub) : "-");
g_free (str);
}
if (texpr != NULL &&
(expr_name_check_for_loop (name, texpr) ||
(stub && expr_name_check_for_loop (expr_name_name (stub), texpr)))) {
gnm_expr_top_unref (texpr);
if (error_msg)
*error_msg = g_strdup_printf (_("'%s' has a circular reference"), name);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment