Commit 0c5c4567 authored by Morten Welinder's avatar Morten Welinder

Fix comparison operators. Plug Excel load leak -- the last remaining!

parent 08e9f3d7
1999-06-17 Morten Welinder <terra@diku.dk>
* src/expr.c (eval_expr): Fix error handling of comparisons.
* src/expr.c (expr_tree_new_constant): New function.
(expr_tree_new_unary): New function.
(expr_tree_new_binary): New function.
......
1999-06-17 Morten Welinder <terra@diku.dk>
* src/expr.c (eval_expr): Fix error handling of comparisons.
* src/expr.c (expr_tree_new_constant): New function.
(expr_tree_new_unary): New function.
(expr_tree_new_binary): New function.
......
1999-06-17 Morten Welinder <terra@diku.dk>
* src/expr.c (eval_expr): Fix error handling of comparisons.
* src/expr.c (expr_tree_new_constant): New function.
(expr_tree_new_unary): New function.
(expr_tree_new_binary): New function.
......
1999-06-17 Morten Welinder <terra@diku.dk>
* src/expr.c (eval_expr): Fix error handling of comparisons.
* src/expr.c (expr_tree_new_constant): New function.
(expr_tree_new_unary): New function.
(expr_tree_new_binary): New function.
......
1999-06-17 Morten Welinder <terra@diku.dk>
* ms-formula-read.c (make_function): Yet another leak fix.
* ms-formula-read.c (expr_tree_unary): Obsolete. Use
expr_tree_new_unary instead.
(expr_tree_cellref): Obsolete. Use expr_tree_new_var instead.
......
......@@ -648,9 +648,10 @@ make_function (PARSE_LIST **stack, int fn_idx, int numargs)
parse_list_free (&args);
parse_list_push (stack, expr_tree_new_error (errtxt));
g_free (errtxt);
if (tmp) expr_tree_unref (tmp);
expr_tree_unref (tmp);
return 0;
}
expr_tree_unref (tmp);
symbol_ref (name);
parse_list_push (stack, expr_tree_new_funcall (name, args));
return 1 ;
......@@ -671,7 +672,7 @@ make_function (PARSE_LIST **stack, int fn_idx, int numargs)
numargs = fd->num_args ;
else if (fd->num_args == -2)
g_warning("This sheet uses an Excel function "
"('%s') for which we don not have "
"('%s') for which we do not have "
"adequate documentation.\n"
"Please forward a copy (if possible) to "
"gnumeric-list@gnome.org. Thanks\n",
......
......@@ -1021,13 +1021,13 @@ eval_expr (Sheet *sheet, ExprTree *tree, int eval_col, int eval_row, char **erro
a = eval_expr (sheet, tree->u.binary.value_a,
eval_col, eval_row, error_string);
if (!a)
return NULL;
b = eval_expr (sheet, tree->u.binary.value_b,
eval_col, eval_row, error_string);
if (!(a && b)){
if (a)
value_release (a);
if (b)
value_release (b);
if (!b) {
value_release (a);
return NULL;
}
comp = compare (a, b);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment