OChangeLog-2005-11-14 265 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25
2001-06-02  Almer S. Tigelaar  <almer@gnome.org>
 
        * src/commands.[ch] (cmd_group_undo): Implement group undo/redo
  	(cmd_group_redo): Idem.
  	(cmd_group_destroy): Idem.
  	(cmd_group): Idem.
  
  	* src/workbook-control-gui.c (cb_data_group): Implement.
  	(cb_data_ungroup): Idem.
  	(group_ungroup_colrow): Utility function to determine if
  	columns or rows need to be grouped/ungrouped.
 
  	* src/sheet.[ch] (sheet_col_row_group_ungroup): New, high level routine
 	for adjusting outlines.
 	(sheet_col_row_fit_gutter): Dynamically adjust gutter size.
 	(cb_outline_level): Callback for the above.
 	(sheet_col_row_can_group): Query if a range of cols/rows
 	can actually group/ungroup.
 	(sheet_col_row_set_outline_level): Deprecated, remove.
 
 	* src/colrow.[ch] (colrow_set_outline): Set outline on a col/row.
 	
  	* src/GNOME_Gnumeric.xml: DataOutlineUnGroup change to
  	DataOutlineUngroup.

26 27 28 29 30 31
2001-06-02  Jody Goldberg <jgoldberg@home.com>

	* src/main.c (handle_paint_events) : be consistent and don't block.

	* src/io-context.c (io_progress_update) : avoid an infinite loop.

Jody Goldberg's avatar
Jody Goldberg committed
32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50
2001-06-02  Jody Goldberg <jgoldberg@home.com>

	* src/format.c (format_compile) : rewrite, not quite done.

	* src/commands.c (cmd_set_text_undo) : queue a recalc.
	(cmd_clear_redo) : ditto.
	* src/corba-sheet.c (Sheet_clear_region) : ditto.
	(Sheet_clear_region_content) : ditto.
	* src/gui-clipboard.c (x_selection_handler) : ditto.
	* src/sheet-merge.c (sheet_merge_add) : ditto.

	* src/eval.c : switch the depend lists to be singly linked.
	(dep_slist_filter_sheet) : convenience routine.
	(dependent_unqueue_sheet) : Used here.
	(dependent_unlink_sheet) : and here.

	* src/workbook-control-gui.c (display_formulas) :  convert the single
	  lists.

51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97
2001-06-01  Zbigniew Chyla  <cyba@gnome.pl>

	Support for reporting i/o progress via IOContext.

	* src/command-context-priv.h (struct CommandContextClass): Added
	progress_message_set virtual.

	* src/command-context.[ch] (gnumeric_progress_message_set): New.

	* src/io-context-priv.h
	Made IOContext a GtkObject.
	(enum GnumProgressHelperType, struct GnumProgressHelper): New.

	* src/io-context.[ch]
	Made IOContext a GtkObject.
	(io_progress_update, io_progress_message,
	file_io_progress_set, file_io_progress_update,
	memory_io_progress_set, memory_io_progress_update,
	count_io_progress_set, count_io_progress_update,
	io_progress_unset): New functions.
	(gnumeric_io_context_free): Removed, use gtk_object_destroy instead.

	* src/workbook-control-gui.c (wbcg_progress_message_set): New,
	implementation of CommandContext virtual.

	* src/workbook-view.c
	(wb_view_save_as, wb_view_save, wb_view_open_custom):
	s/gnumeric_io_context_free/gtk_object_destroy

	* src/xml-io.h
	(struct _XmlParseContext): New members (io_context, element_counter) for
	progress reporting.

	* src/xml-io.c
	(xml_read_styles): Update i/o progress every N_ELEMENTS_BETWEEN_UPDATES
	styles.
	(xml_sheet_read): Ditto for cells.
	(xml_get_n_children, xml_read_sheet_n_elements,
	xml_read_workbook_n_elements): Internal functions, calculating the
	number of "elements" (styles and cells) in workbook.
	(xml_workbook_read): Set up io progress to "Processing XML tree" stage.
	(gnumeric_xml_read_workbook): Load the file into an XML tree using the
	Push mode and update i/o progress regularly.

	* src/plugin-util.c
	#include <libgnome/libgnome.h> instead of <gnome.h>.

98 99 100 101 102 103 104 105 106 107 108 109 110 111 112
2001-05-31  Jody Goldberg <jgoldberg@home.com>

	* src/solver-lp.c : Use cell_eval in place of cell_eval_content.

	* src/eval.c (cb_range_hash_invalidate) : disconnect the list from the
	  dep record while removing its contents.  We don't want to modify the
	  list while we are walking it.  This is also an optimization in that
	  we don't need to modify the list.
	(cb_single_hash_invalidate) : ditto.
	(depsingle_dtor) : Ensure that the list has already been cleared.
	(deprange_dtor) : ditto.
	(dependent_unlink) : short circuit if we are destroying.

	* src/sheet.c (sheet_destroy) : Clear the controls first.

113 114
2001-05-31  Karl Eichwalder  <ke@suse.de>

Karl Eichwalder's avatar
Karl Eichwalder committed
115 116
	* src/GNOME_Gnumeric.xml: Fix 2 typos.

117 118 119
	* configure.in: Write gnome.desktop.in.
	* .cvsignore: Add gnome.desktop.in.

120 121 122 123 124
2001-05-31  Zbigniew Chyla  <cyba@gnome.pl>

	* workbook-view (wb_view_open_custom): Handle opener errors without
	crashing.

125 126
2001-05-30  Jody Goldberg <jgoldberg@home.com>

127
	* src/value.c (value_error_set_pos) : change name from
128 129 130 131 132 133 134 135 136
	  value_new_error_err since we don't actually new anything.

	* src/position.c (eval_pos_init_cellref) : delete broken crap.

	* src/func.c (cb_iterate_cellrange) : duplicate error here.
	(function_iterate_argument_values) : duplicate the non-terminate
	  error here.
	* src/collect.c (collect_floats) : not here.

137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249
2001-05-30  Jon K Hellan  <hellan@acm.org>

	* src/sheet-control-gui-priv.h: New file. Implementation details
	for SheetControlGUI and methods directly accessible from the GUI
	layer.

	* src/Makefile.am: Add sheet-control-gui-priv.h

	* src/sheet-control-gui.h: Move struct _SheetControlGUI to
	sheet-control-gui-priv.h. Remove declarations of methods which
	have been made virtual.

	* src/sheet-control-gui.c: Include sheet-control-gui-priv.h instead
	of sheet-control-gui.h. 
	Casts and temp variables because:
	- virtual scg methods now take a SheetControl parameter.
        - sheet member now lives in SheetControl.
	Make following methods static - externally available only as
	virtual SheetControl method: scg_redraw_all,
	scg_redraw_cell_region, scg_redraw_headers, scg_update_cursor_pos,
	scg_resize, scg_unant, scg_ant, scg_cursor_bound,
	scg_compute_visible_region, scg_make_cell_visible. Initialize
	class object with these as virtual methods together with
	scg_set_zoom_factor, scg_adjust_preferences, scg_scrollbar_config
	and scg_mode_edit.  Rename context_menu_hander (sic!) to
	context_menu_handler.

	*src/sheet-control.c (SC_VIRTUAL_FULL): Fix typo.
	(sc_destroy): Comment out unused variable.
	(sheet_control_init_state): Rename to sc_init_state.
	(sc_sheet): New accessor - returns sheet attribute.
	(sc_invalidate_sheet): New function - sets sheet attribute to
	NULL.
	(resize, set_zoom_factor, redraw_all, redraw_cell_region,
	redraw_headers, ant, unant, adjust_preferences, update_cursor_pos,
	scrollbar_config, mode_edit, compute_visible_region,
	make_cell_visible, cursor_bound): New virtual methods.

	* src/sheet-control.h: Declare new methods in sheet-control.c

	* src/selection.c: Use sc_redraw_cell_region, sc_redraw_headers
	instead of scg methods.
	
	* src/sheet.c (sheet_unant): Use sc_unant instead o scg_unant.
	(sheet_ant): Use sc_ant instead of scg_ant.
	(sheet_redraw_all): Use sc_redraw_all instead of scg_redraw_all.
	(sheet_redraw_all): Use sc_redraw_headers instead of
	scg_redraw_headers.
	(sheet_new_scg): Use sc_cursor_bound instead of scg_cursor_bound.
	(sheet_detach_scg): Rename to sheet_detach_control. Change
	parameter from SheetControlGUI to SheetControl. Use sc_sheet and
	sc_invalidate_sheet instead of direct attribute access.
	(sheet_set_zoom_factor): Use sc_set_zoom_factor instead of
	scg_set_zoom_factor.
	(sheet_update_only_grid): Use sc_compute_visible_region instead of
	scg_compute_visible_region.
	(sheet_col_row_gutter): Use sc_resize instead of scg_resize.
	(sheet_redraw_cell_region, sheet_redraw_partial_row,
	sheet_redraw_cell): Use sc_redraw_cell_region instead of
	scg_redraw_cell_region.
	(sheet_make_cell_visible): Use sc_make_cell_visible instead of
	scg_make_cell_visible.
	(sheet_cursor_set): Use sc_cursor_bound instead of
	scg_cursor_bound.
	(sheet_update_cursor_pos): Use sc_update_cursor_pos instead of
	scg_update_cursor_pos.
	(sheet_scrollbar_config): Use sc_scrollbar_config instead of
	scg_scrollbar_config.
	(sheet_adjust_preferences): Use sc_adjust_preferences, sc_resize
	and sc_redraw_all instead of scg_adjust_preferences, scg_resize
	and scg_redraw_all.

	* src/sheet.h (SHEET_FOREACH_CONTROL): Take list of SheetControls
	instead of SheetControlGUIs.

	* src/workbook.c (workbook_sheet_detach): Use sc_mode_edit instead
	of scg_mode_edit.
	
	* src/embeddable-grid.h: Include sheet-control-gui-priv.h instead
	of sheet-control-gui.h.

	* src/sheet-object-graphic.c: Ditto.

	* src/gnumeric-sheet.c: Include sheet-control-gui-priv.h instead
	of sheet-control-gui.h. 
	Casts and temp variables because:
	- virtual scg methods now take a SheetControl parameter.
        - sheet now lives in SheetControl.

	* src/item-bar.c: Ditto.
	
	* src/item-cursor.c: Ditto.
	
	* src/item-edit.c: Ditto.
	
	* src/item-grid.c: Ditto.

	* src/sheet-object-cell-comment.c: Ditto.

	* src/sheet-object-cell-container.c: Ditto.

	* src/sheet-object-item.c: Ditto.

	* src/sheet-object-widget.c: Ditto.

	* src/workbook-control-gui.c: Ditto.

	* src/workbook-object-toolbar.c: Ditto, but don't include
	sheet-control-gui-priv.h 

	* src/sheet-object.c (sheet_object_realize): Cast control to
	SheetControlGUI.

Chyla Zbigniew's avatar
Chyla Zbigniew committed
250 251 252 253
2001-05-30  Zbigniew Chyla  <cyba@gnome.pl>

	* src/stf.c (stf_init): Register as importer.

254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292
2001-05-29  Zbigniew Chyla  <cyba@gnome.pl>

	* src/file.h
	(typedef enum FileProbeLevel) New.
	(typedef GnumFileOpenerProbeFunc, gnum_file_opener_probe): Added
	FileProbeLevel argument.
	(GNUM_FILE_OPENER_CLASS, IS_GNUM_FILE_OPENER_CLASS,
	GNUM_FILE_SAVER_CLASS, IS_GNUM_FILE_SAVER_CLASS):
	Macros moved to file-priv.h.

	* src/file-priv.h
	(struct _GnumFileOpenerClass::probe): 
	(GNUM_FILE_OPENER_CLASS, IS_GNUM_FILE_OPENER_CLASS,
	GNUM_FILE_SAVER_CLASS, IS_GNUM_FILE_SAVER_CLASS):
	Macros moved from file.h.

	* src/file.c
	(gnum_file_opener_probe_real, gnum_file_opener_probe): 
	Added FileProbeLevel argument.

	* src/workbook-view.c
	(wb_view_open_custom): Iterate over FileProbeLevel values when probing
	the file (passing current value to probe function).

	* src/xml-io.c
	(xml_probe): Added FileProbeLevel argument, testing only file name if
	probe level == FILE_PROBE_FILE_NAME.

	* src/plugin-service.c (gnum_plugin_file_opener_probe):
	Use file_patterns only if probe level == FILE_PROBE_FILE_NAME, otherwise
	call module's probe function.

	* src/bonobo-io.c (gnumeric_bonobo_io_probe),
	src/plugin-service.h (struct _PluginServiceFileOpener),
	src/plugin-loader-module.c
	(gnumeric_plugin_loader_module_func_file_probe,
	struct ServiceLoaderDataFileOpener::module_func_file_probe):
	Added FileProbeLevel argument.

293 294 295 296 297 298 299 300
2001-05-27  Jody Goldberg <jgoldberg@home.com>
	From Juan Pablo Mendoza <pablo_juan@yahoo.com>

	* gnumeric-util.h (gnumeric_filter_modifiers): New macro.

	* workbook-control-gui.c (wb_edit_key_pressed): Use it.
	* gnumeric-sheet.c (gnumeric_filter_modifiers): Ditto.

301 302 303
	* sheet.c (sheet_name_quote): Escape \ and add more chars to
	  to quote_chr.

304 305 306 307 308 309
2001-05-27  Jody Goldberg <jgoldberg@home.com>

	* src/eval.c (sheet_region_queue_recalc) : Queue the dependents in the
	  region not just those that depend on it.
	(cell_queue_recalc) : no need to queue non expression cells.

310 311 312 313 314 315 316
2001-05-27  Nathan Cullen <furyu@fuse.net>
 
 	* src/history.c (history_menu_insert_separator): Fixed keyboard
 	navigation problem in non-bonobo build with separator for recently
 	opened files.  There was an "invisible" separator item so you needed
 	to arrow down twice to get from "Print Preview" to the first file.
 
317 318
2001-05-27  Jody Goldberg <jgoldberg@home.com>

319 320 321 322 323 324 325 326 327
	* src/expr.c (eval_expr_real) : recurse for arrays too.
	(expr_tree_array_corner) : rename from expr_tree_array_formula_corner,
	  and return the corner, not the expression in the corner.

	* src/eval.c (cb_range_hash_invalidate) : invalidate and free things
	  in place.
	(cb_single_hash_invalidate) : ditto.
	(do_deps_destroy) : simplify.

328 329 330
	* src/workbook-control-gui.c (wbcg_sheet_rename) : Use the table not
	  the container.

Chyla Zbigniew's avatar
Chyla Zbigniew committed
331 332 333 334
2001-05-27  Zbigniew Chyla  <cybs@gnome.pl>

	* src/plugin-service.c (parse_format_level_str): Fixed typo.

335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361
2001-05-26  Jody Goldberg <jgoldberg@home.com>

	* src/sheet.c (colrow_move) : no need to queue recalc here.
	(cb_sheet_cell_copy) : Actually copy the array values.

	* src/cell.c (cell_relocate) : Just relink, no need to queue a recalc.
	(cell_set_array_formula) : Remove the ability to queue the recalc at
	  this level.  Just link the formulas in.  Reorder the the arguments
	  to match the standard approach.

	* src/eval.c (workbook_recalc_all) : Used here.
	(workbook_queue_all_recalc) : new function.

	* src/xml-io.c (xml_workbook_read) : Queue everything for recalc.
	(xml_cell_set_array_expr) : no need to queue a recalc here.

	* src/commands.c (cmd_autofill_redo) : queue the recalc here.
	(cmd_area_set_text_redo) : we need to manually queue a recalc for
	  arrays now.

	* src/sheet.c (sheet_cell_set_text) : we need to queue a recalc for
	  both expressions and values now.
	(sheet_range_set_text) : queue recalcs for the region as a block.

	* src/graph-vector.c (graph_vector_new) : Just use dependent_link if
	  we don't want a recalc.

362 363 364 365 366 367 368
2001-05-27  Karl Eichwalder  <ke@suse.de>

	* Run xml-i18n-prepare:
	* gnumeric.desktop.in: Remove file.
	* gnumeric.desktop.in.in: New file.
	* Makefile.am: Adjust it for gnumeric.desktop.in.in.

Jody Goldberg's avatar
Jody Goldberg committed
369 370 371 372
2001-05-26  Jody Goldberg <jgoldberg@home.com>

	* src/sheet-control-gui.h : typo.

373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391
2001-05-26  Jon K Hellan  <hellan@acm.org>

	* src/sheet-control-gui.[ch]: Derive from SheetControl rather than
	GtkObject.

	* src/gnumeric.h: Add incomplete def of SheetControl.

	* src/Makefile.am: Add sheet-control.c, sheet-control.h,
	sheet-control-priv.h

	* src/sheet-control.c: New file. Stub base class for
	SheetControlGUI. 

	* src/sheet-control.h: Strip down even more from existing stub in
	CVS. 

	* src/sheet-control-priv.h: New file. Private header for
	SheetControl.

392 393 394 395
2001-05-26  Jody Goldberg <jgoldberg@home.com>

	* src/format.c (format_number) : suppress minus for "\(" to match "("

Karl Eichwalder's avatar
Karl Eichwalder committed
396 397 398 399
2001-05-26  Karl Eichwalder  <ke@suse.de>

	* src/workbook-control-gui.c: Fix typo.

400 401 402 403 404 405 406 407
2001-05-26  Jody Goldberg <jgoldberg@home.com>

	* src/cell.c (cell_eval_content) : Use the iteration prefs.

	* src/workbook.c (workbook_iteration_tolerance) : new function.
	(workbook_iteration_enabled) : ditto.
	(workbook_iteration_max_number) : ditto.

408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426
2001-05-26  Zbigniew Chyla  <cyba@gnome.pl>

	* src/gui-file.c (fill_save_menu): If recently used saver has been
	removed, use default saver, not the first one.

	* src/file.c
	(unregister_file_opener, unregister_file_opener_as_importer): Fixed
	leaks.
	(unregister_file_saver): Fixed stupid bug (and leaks).

	* src/plugin-service.h (struct _PluginServiceFileSaver): Added
	default_saver_priority field.

	* src/plugin-service.c
	(plugin_service_file_saver_read): Read "default_saver_priority"
	attribute.
	(plugin_service_file_saver_initialize): Register as default saver if
	default_saver_priority is non-negative.

427 428 429 430 431 432 433 434 435 436 437
2001-05-25  Jody Goldberg <jgoldberg@home.com>

	* src/value.c (value_diff) : new routine.  This looks ugly.  We should
	  be able to avoid replicating this code.

	* src/cell.c (cell_eval_content) : support iteration.

	* src/format.c (render_number) : make the buffer big enough.
	  The assumtion that mantissa and exp are both maxed should leave
	  enough room for thousand separators.

438 439 440 441 442
2001-05-25  Jon K Hellan  <hellan@acm.org>

	* src/workbook-control-gui.c (wbcg_sheet_add): Bugfix: Connect
	button_press_event handler with scg->table as data instead of scg.

443 444 445 446 447 448 449 450 451 452 453
2001-05-25  Jody Goldberg <jgoldberg@home.com>

	* src/workbook-view.c (wb_view_open_custom) : fix logic to avoid
	  adding a bogus view.

2001-05-24  Jody Goldberg <jgoldberg@home.com>

	* src/eval.c (workbook_recalc) : don't clear the flag until after the
	  calc is complete in case there is a cycle.
	(cell_eval) : ditto.

454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480
2001-05-24  Jon K Hellan  <hellan@acm.org>

	* src/workbook-control-gui.c (sheet_to_page_index): Rename view to
	scg. Retrieve it from object data on table.
	(sheet_to_page_index):
	(wb_control_gui_focus_cur_sheet, cb_sheet_label_button_press,
	cb_notebook_switch_page): Retrieve scg from object data on table.
	(wbcg_sheet_add): Show and insert in notebook scg->table. scg no
	longer is a GtkTable, it has one.

	* src/sheet-control-gui.c (scg_parent_class): Change to
	GtkObjectClass.
	(cb_table_destroy): New function. Finish all table and canvas
	dependent activities and set scg->table, scg->canvas to NULL.
	(scg_init): Don't create table here.
	(scg_construct): ..but here. Change terminology. Old: outer_table,
	table. New: scg->table, inner_table. Add scg to scg->table as
	object data. Add a destroy callback to scg->table.
	(scg_destroy): Move parts to cb_table_destroy. Unref table if not
	NULL.
	(scg_class_init, GNUMERIC_MAKE_TYPE): Inherit from GtkObject
	instead of GtkTable.
	(scg_cursor_visible): Be prepared for scg->canvas being NULL

	* src/sheet-control-gui.h (struct _SheetControlGUI,
	SheetControlGUIClass): Inherit from GtkObject instead of GtkTable.

481 482 483 484 485 486 487 488 489 490 491 492 493
2001-05-24  Jody Goldberg <jgoldberg@home.com>

	* src/workbook.c (workbook_enable_recursive_dirty) : new function.
	* src/workbook-private.c (workbook_private_init) : Init
	  recursive_dirty_enabled.
	* src/sheet.c (sheet_cell_remove) : Use recursive_dirty_enabled.
	* src/eval.c (dependent_changed) : ditto.

	* src/workbook-view.c (wb_view_open_custom) : while loading disable
	  recursive depend dirtying.  We are loading everything it is up to
	  the loader to handle the queuing correctly (either queuing all, or
	  just those necessary)

494 495 496 497 498 499 500 501 502 503 504 505 506
2001-05-23  Jody Goldberg <jgoldberg@home.com>

	* src/sheet.c (sheet_cell_destroy) : optionally queue the dependents
	  of this cell for recalc.

2001-05-23  Jody Goldberg <jgoldberg@home.com>

	* src/eval.c (dependent_changed) : Use cb_dependent_queue_recalc to
	  recursively queue the depends.
	Eg A1 : =sum(b1:b2)
	   B1 : =3
	if we do not recurse the assignment of '=3' would queue B1 but not A1

Jody Goldberg's avatar
Jody Goldberg committed
507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591
2001-05-22  Jody Goldberg <jgoldberg@home.com>

	* gnumeric.spec.in : bump version of libole2
	* README : ditto.
	* configure.in : ditto.

2001-05-19  Jody Goldberg <jgoldberg@home.com>

	* src/workbook.c (workbook_is_pristine) : no need to check the recalc
	  queue.  If there are no dependents there is nothing to put on the
	  eval queue.

	* src/func.c (cb_iterate_cellrange) : rename from
	  iterate_cellrange_callback remove 'generation' mechanism.

	* src/cell.c (cell_cleanout) : Clear both recalc flags,
	  in_queue and needs
	(cell_copy) : ditto.
	(cell_eval_content) : No need to render the value.  assign_value
	  already does it.
	(cell_content_changed) : deleted.

	* src/Makefile.am : merge dependent.[ch] into eval.[ch]

2001-05-18  Jody Goldberg <jgoldberg@home.com>

	* src/eval.c : reorg and merged with dependent.[ch]

	* src/sheet.c (sheet_cell_set_text) :
	  s/cell_content_changed/cell_queue_recalc/
	(sheet_cell_set_expr) : ditto.
	(sheet_cell_set_value) : ditto.
	(colrow_move) : ditto.
	(sheet_destroy_contents) : 
	  s/dependent_unqueue_recalc_sheet/dependent_unqueue_sheet/

	* src/cmd-edit.c (cmd_select_cur_row) : Make behavior match XL.
	(cmd_select_cur_col) : Make behavior match XL.

	* src/format.c (render_number) : avoid temporaries.
	(do_render_number) : ditto.

2001-05-17  Jody Goldberg <jgoldberg@home.com>

	* src/expr.c (eval_range) : delete.
	(eval_expr_real) : Use workbook_foreach_cell_in_range rather than
	  range_eval.  Remove 'generation' mechanism.
	(cb_range_eval) : a simple pass through

	* src/eval.c (sheet_region_recalc_deps) : rename from
	  sheet_recalc_dependencies and merge in sheet_region_get_deps.
	  Use the new foreach style interfaces.
	(cb_single_recalc_all_depends) : rename from cb_single_get_all_depends
	  and simplify.
	(cb_range_recalc_all_depends) : rename from cb_sheet_get_all_depends and simplify.
	(cb_dependent_queue_recalc) : new wrapper.
	(cb_region_contained_depend) : renamed from search_range_deps and simplify.
	(cell_foreach_dep) : rename from cell_get_dependencies and switch to
	  an in place api rather than creating a list.
	(cell_foreach_single_dep) : switch to in place api
	(cell_foreach_range_dep) : ditto.
	(search_cell_deps) : ditto.
	(cell_recalc_deps) : ditto.
	(cell_eval) : ditto.
	(cb_generation_queue) : new utility.

	* src/dependent.c (dependent_list_filter) : delete.

	* src/cmd-edit.c (cb_collect_deps) : new function split from.
	(cmd_select_cur_depends) : here. So that we can use the new depend
	  api.

	* src/sheet.c (sheet_move_range) : use sheet_region_recalc_deps.
	(sheet_{insert,delete}_{cols,rows}) : ditto.
	(sheet_cell_remove_simple) : Use in place depend interface.

	* src/cell.c (cell_content_changed) : Use in place depend interface.
	* src/clipboard.c (clipboard_paste_region) : ditto.
	* src/commands.c (cmd_area_set_text_redo) : ditto.
	(cmd_autofill_redo) : ditto.

2001-05-21  Jody Goldberg <jgoldberg@home.com>

	* Makefile.am : remove gnorba and modernize a bit.

592 593 594 595 596 597 598 599 600
2001-05-23  Zbigniew Chyla  <cyba@gnome.pl>

	* src/plugin-service.c
	(struct _InputFilePattern): Added "case_sensitive" field.
	(gnum_plugin_file_opener_probe): Support "case_sensitive" attribute when
	checking if file name matches the pattern.
	(plugin_service_file_opener_read): Support "case_sensitive" attribute.
	Now matching is case _insensitive_ by default.

601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619
2001-05-23  Zbigniew Chyla  <cyba@gnome.pl>

	* src/bonobo-io.c, src/clipboard.c, src/file.c, src/plugin.c,
	src/sheet-object.c, src/stf.c, src/workbook.c:
	Removed #include "xml-io.h".

	* src/dialogs/dialog-plugin-manager.c (gnumeric_dialog_question_yes_no):
	Function moved ...

	* src/gnumeric-util.[ch]: ... here.

	* src/gui-file.c
	(gui_file_import): Sorting file importers.
	(fill_save_menu): Sorting file savers, function simplified (doesn't use
	file_saver_is_default_format).
	(can_try_save_to): Function simplified, uses
	gnumeric_dialog_question_yes_no from gnumeric-util.h, default answer
	for question about overwriting a file is configurable.

620 621 622 623 624 625 626
2001-05-22  Almer S. Tigelaar  <almer@gnome.org>

	* src/xml-io.c : Bump XML version number.
	(xml_workbook_write): Write index of sheet names
	at the beginning of the file and always write
	latest version number.

627 628 629 630 631
2001-05-22  Jon K Hellan  <hellan@acm.org>

	* src/workbook-edit.c (wbcg_editing_expr): Use renamed function
	gnumeric_expr_entry_rangesel_meaningful.

632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657
2001-05-22  Zbigniew Chyla  <cyba@gnome.pl>

	* file.c
	(gnum_file_opener_setup, gnum_file_opener_new, gnum_file_opener_probe,
	gnum_file_opener_open, gnum_file_saver_setup, gnum_file_saver_new,
	gnum_file_saver_save, gnum_file_saver_fix_file_name,
	register_file_opener, register_file_opener_as_importer,
	unregister_file_opener, unregister_file_opener_as_importer,
	register_file_saver, register_file_saver_as_default,
	unregister_file_saver, get_default_file_saver,
	get_file_opener_by_id, get_file_saver_by_id,
	get_file_savers, get_file_openers, get_file_importers):
	Added gtk-doc style documentation.
	(struct _GnumFileOpener, struct _GnumFileOpenerClass,
	struct _GnumFileSaver, struct _GnumFileSaverClass): Removed structs
	already defined in file-priv.h.

	* workbook-view.c
	(wb_view_save_as, wb_view_save, wb_view_open, wb_view_open_custom):
	Added gtk-doc style documentation.

	* file.h
	(gnum_file_opener_setup, gnum_file_saver_setup): Declarations moved ...

	* file-priv.h: ... here

658 659 660 661 662 663 664 665 666 667 668
2001-05-21  Jon K Hellan  <hellan@acm.org>

	* src/workbook-control-gui-priv.h (struct _WorkbookControlGUI):
	Add toolbar_is_sensitive member.

	* src/workbook-control-gui.c (workbook_control_gui_init):
	Initialize wbcg->toolbar_is_sensitive.

	* src/workbook-edit.c (workbook_edit_toolbars_set_sensitive): Use 
	wbcg->toolbar_is_sensitive instead of static is_sensitive.
	
669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701
2001-05-21  Zbigniew Chyla  <cyba@gnome.pl>

	Cleaned up file i/o interface.

	* src/Makefile.am: Added file-priv.h.

	* src/file.[ch]:
	Made GnumFileOpener and GnumFileSaver GtkObjects with virtual probe,
	open and save methods.
	New GnumFileOpener methods: get_id.
	New GnumFileSaver methods: get_id, fix_file_name.
	New functions: register_file_opener, register_file_opener_as_importer,
	unregister_file_opener, unregister_file_opener_as_importer,
	register_file_saver, register_file_saver_as_default,
	unregister_file_saver, get_default_file_saver,
	get_file_opener_by_id, get_file_saver_by_id,
	get_file_savers, get_file_openers, get_file_importers.

	* src/file-priv.h: New file with definitions of structs:
	_GnumFileOpener, _GnumFileOpenerClass, _GnumFileSaver,
	_GnumFileSaverClass.

	* src/workbook.h
	(struct _Workbook): Added file_saver_sig_id field.
	s/FileSaver/GnumFileSaver/
	(workbook_get_file_saver): New accessor function.

	* src/workbook.c
	(cb_saver_destroy_event, workbook_destroy, workbook_set_saveinfo):
	When setting new file_saver, connect to its "destroy" signal and
	set file_saver to NULL in signal handler. Disconnect when changing file
	saver or destroying the workbook.
	(workbook_get_file_saver): New accessor function.
702 703 704 705
	(workbook_persist_file_load): Use wb_view_open instead of
	workbook_load_from.
	(workbook_persist_file_save): Use wb_view_save_as instead of calling
	gnumeric_xml_write_workbook directly.
706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776

	* src/workbook-view.[ch]
	(wb_view_set_attributev): Renamed to wb_view_set_attribute_list and
	simplified.
	(wb_view_save_as, wb_view_save, wb_view_open, wb_view_open_custom): New
	methods (some code moved from file.c).

	* src/gnumeric-sheet.c (gnumeric_sheet_filenames_dropped):
	Use wb_view_open() instead of workbook_try_read()+file_finish_load().

	* src/gui-file.c
	(gui_file_import): Use get_file_importers(). Use
	wb_view_open_custom() instead of file_opener_open() + manual creation
	of wb_view, error checking, etc.
	(is_saver_registered): Removed.
	(saver_activate): Don't check if saver is really registered.
	(file_saver_is_default_format): Use get_default_file_saver() instead
	of strcmp(extension, "gnumeric") hack.
	(do_save_as): Use gnum_file_saver_fix_file_name().
	Adjusted everything to file.h, workbook.h, workbook-control.h.

	* src/gui-file.h (gui_file_import): Signature change, now function
	returns gboolean.

	* src/gutils.[ch] (g_list_index_custom): New function.

	* src/history.c (file_history_cmd), src/main.c (gnumeric_main),
	src/workbook-control-gui.c (cb_file_open): Use wb_view_open()
	instead of workbook_read().

	* src/workbook-control-gui-priv.h (struct _WorkbookControlGUI):
	s/FileSaver/GnumFileSaver/

	* src/plugin-service
	Created GnumPluginFileOpener and GnumPluginFileSaver classes (derived
	from GnumFileOpener and GnumFileSaver respectively). Moved contents of
	plugin_service_file_opener_probe_func,
	plugin_service_file_opener_open_func,
	plugin_service_file_saver_save_func into
	gnum_plugin_file_opener_probe, gnum_plugin_file_opener_open,
	gnum_plugin_file_saver_save methods (slightly modified).
	(plugin_service_file_opener_read): Read "open" and "import" attributes
	of <service> tag.
	(plugin_service_file_opener_initialize,
	plugin_service_file_opener_cleanup): Register/unregister created
	file opener (GnumPluginFileOpener object) as normal opener and/or
	importer depending on "open" and "import" XML attributes.
	(plugin_service_file_opener_initialize,
	plugin_service_file_opener_cleanup): Register/unregister created
	file saver (GnumPluginFileSaver object).

	* src/plugin-service.h
	(struct _PluginServiceFileOpener):
	Added can_open and can_import fields.
	s/FileOpener/GnumFileOpener/
	(struct _PluginServiceFileSaver):
	s/FileSaver/GnumFileSaver/
	
	* src/plugin-loader-module.c
	(struct ServiceLoaderDataFileOpener, struct ServiceLoaderDataFileSaver),
	gnumeric_plugin_loader_module_func_file_probe,
	gnumeric_plugin_loader_module_func_file_open,
	gnumeric_plugin_loader_module_func_file_save):
	s/FileOpener/GnumFileOpener/
	s/FileSaver/GnumFileSaver/

	* src/stf.c
	(stf_read_workbook, stf_write_workbook): Signature change
	(don't return gboolean).
	(stf_init): Adjusted to file i/o interface changes.

777
	* src/xml-io.[ch]
778 779
	(gnumeric_xml_get_opener, xml_probe):
	s/FileOpener/GnumFileOpener/
780
	(gnumeric_xml_get_saver):
781 782 783 784 785
	s/FileSaver/GnumFileSaver/
	(gnumeric_xml_read_workbook, gnumeric_xml_write_workbook): Signature
	change (don't return gboolean).
	(xml_init): Adjusted to file i/o interface changes.

786 787 788 789 790 791 792 793 794
	* src/bonobo-io.c
	(gnumeric_bonobo_read_workbook, gnumeric_bonobo_write_workbook):
	Signature change (don't return gboolean).
	s/FileOpener/GnumFileOpener
	s/FileSaver/GnumFileSaver
	(gnumeric_bonobo_io_probe):
	s/FileOpener/GnumFileOpener
	(gnumeric_bonobo_io_init): Adjusted to file i/o interface changes.

795 796 797 798 799
2001-05-20  Chema Celorio  <chema@celorio.com>

	* src/sheet-control-gui.c (set_acetate_coords): make sure the accetate
	honors the direction of the object.

800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845
2001-05-20  Chema Celorio  <chema@celorio.com>

	* src/sheet-object.c (sheet_object_init): initialize the so->direction
	to _UNKNOWN
	(sheet_object_direction_set): impl.
	(sheet_object_rubber_band_directly): impl a small convenience function
	to get the value of SO_CLASS(so)->rubber_band_directly

	* src/sheet-object-widget.c (sheet_widget_checkbox_construct_with_range):
	add a label argument to also optionaly specify a label
	(sheet_widget_checkbox_clone): when cloning a checkbox, copy it's value
	too
	add a ->label and rename ->entry to ->expresion in CheckboxConfigState
	(cb_checkbox_label_changed): impl.
	(sheet_widget_checkbox_user_config): add an entry for the label of
	the checkbutton
	(sheet_widget_checkbox_set_sheet): call _set_active when setting the
	sheet of a checkbox

	* src/sheet-object-impl.h: add the SheetObjectDirection enums
	add ->direction to SheetObject
	add ->rubber_band_directly to SheetObjectClass

	* src/sheet-object-graphic.c (sheet_object_graphic_read_xml): read
	the object's direction
	(sheet_object_graphic_write_xml): save the direction of the object
	(sheet_object_graphic_class_init): so->direction = TRUE
	(sheet_object_graphic_init): initlalize so->direction

	* src/sheet-control-gui.c (scg_object_move): calculate the new direction
	of the object when moving a handle.
	(scg_object_view_position): the coordinates of the object depend on
	it's ->direction now.

	* src/item-grid.c (cb_obj_create_motion): if we are rubberbanding directly,
	calculate the sheet object direction and position.
	(cb_obj_create_button_release): only set the sheet if we are not rubber_banding_
	direcly. Objects that are rubber banded directly have already been attached to
	a sheet.
	(sheet_object_begin_creation): if we are rubber_banding_direclty the object,
	attach it to a sheet. 

	* src/sheet-object-widget.c (sheet_widget_checkbox_destroy): check if
	the dependent has been linked before unlinking. We might have created
	the object without attaching it to a sheet.

Jody Goldberg's avatar
Jody Goldberg committed
846 847 848 849 850
2001-05-21  Jody Goldberg <jgoldberg@home.com>

	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) : revert
	  my silliness.

851 852 853 854 855 856
2001-05-18  Jody Goldberg <jgoldberg@home.com>

	* src/format.c (render_number) : avoid temporaries.
	(do_render_number) : ditto.

2001-05-18  Jody Goldberg <jgoldberg@home.com>
Jody Goldberg's avatar
Jody Goldberg committed
857 858 859

	* configure.in : bump version to 0.66.

Jody Goldberg's avatar
Jody Goldberg committed
860 861 862 863 864 865 866 867 868
2001-05-20  Jody Goldberg <jgoldberg@home.com>

	* Release 0.65

2001-05-20  Jody Goldberg <jgoldberg@home.com>

	* configure.in : Remove ja, ko, zh* from ALL_LINGUAS until the po
	  files are fixed.

Chyla Zbigniew's avatar
Chyla Zbigniew committed
869 870 871 872
2001-05-20  Zbigniew Chyla  <cyba@gnome.pl>

	* src/sheet-object.c (sheet_object_read_xml): Fixed leaks.

873 874 875 876 877 878
2001-05-20  Zbigniew Chyla  <cyba@gnome.pl>

	* src/plugin.c (plugin_db_init): Last patch changed behaviour from
	"treat every plugin as known" to "treat every plugin as unknown" :-)
	Now it should be really fixed.

879 880 881 882 883
2001-05-19  Almer S. Tigelaar  <almer@gnome.org>
 
 	* src/workbook-edit.c (wbcg_edit_attach_guru):
 	Guard against two anted region on the same sheet.

884 885 886 887 888 889 890 891 892
2001-05-19  Jody Goldberg <jgoldberg@home.com>

	* src/plugin.c (plugin_db_extend_saved_active_plugin_id_list) : Merge
	  into plugin_db_init.
	(plugin_db_init) : Find the unknown plugins not the known plugins.
	  Remove the list of plugins that default to on.
	  Fix the use of gnome_config.

2001-05-19  Jody Goldberg <jgoldberg@home.com>
893

894 895 896 897
	* gnumeric.spec.in : update GAL req.
	* configure.in : ditto.
	* README : update

898 899 900
	* src/GNOME_Gnumeric.xml : Fix the accelerators to use xkeysym names
	  rather than the physical key for slash and space.

901 902
	* src/plugin.c (plugin_db_init) : Enable new plugins by default.

903 904 905 906
2001-05-17  Jody Goldberg <jgoldberg@home.com>

	* src/sheet-style.c (cell_tile_apply_pos) : Add more sanity checking.

907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925
2001-05-16  Jody Goldberg <jgoldberg@home.com>

	* src/item-bar.c (is_pointer_on_division) : Use
	  wbcg_rangesel_possible.
	* src/item-grid.c (item_grid_button_1) :  ditto.
	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) : ditto.
	* src/sheet-control-gui.c (scg_select_all) : ditto.
	(scg_colrow_select) : ditto.
	(scg_construct) : ensure we start with focus.
	(scg_rangesel_possible) : move from here.

	* src/workbook-control-gui.c (wbcg_rangesel_possible) : to here.
	(cb_notebook_switch_page) : expand the logic slightly to correct gurus.

	* src/workbook-edit.c (wbcg_edit_finish) : always check for rangesel.

	* src/parse-util.c (gnumeric_char_start_expr_p) : improve handling of
	  NULL.

926 927 928 929 930 931 932 933 934 935 936 937 938
2001-05-16  Jody Goldberg <jgoldberg@home.com>

	* src/workbook-edit.c (wbcg_edit_finish) : stop the current rangesel,
	  not rangesel on the current display sheet.

	* src/workbook-control-gui.c (cb_notebook_switch_page) : simplify and
	  use the new wbcg::rangesel to make things easier.
	(workbook_control_gui_init) : init the new flag.

	* src/sheet-control-gui.c (scg_rangesel_start) : store the scg doing
	  the rangesel in the wbcg.
	(scg_rangesel_stop) : clear it here.

939 940 941 942 943 944 945 946 947 948
2001-05-15  Jody Goldberg <jgoldberg@home.com>

	* src/sheet.c (sheet_stop_range_selection) : delete.

	* src/commands.c (cmd_paste_copy) : call splits_region to check for
	  partial arrays and merged regions.

	* src/sheet.c (cb_set_cell_content) : Use the bounding box.
	(sheet_range_set_text) : set the bounding box.

949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965
2001-05-15  Jon K Hellan  <hellan@acm.org>
 
 	* src/workbook-control.h: Define menu state enums for print setup,
 	search/replace and define names and a define for the lot.
 
 	* src/workbook-control-gui-priv.h (struct _WorkbookControlGUI): 
 	Add menu_item_print_setup, menu_item_search_replace,
 	menu_item_define_name members.
 
 	* src/workbook-edit.c (workbook_edit_attach_guru,
 	workbook_edit_detach_guru): Update Update print setup,
 	search/replace and define names sensitivity according to whether
 	or not we have guru.
 
 	* src/workbook-control-gui.c (wbcg_menu_state_update): Ditto. This
 	is where it's actually implemented.
 
966 967 968 969 970 971
2001-05-15  Almer S. Tigelaar  <almer@gnome.org>

	* src/sheet-control-gui.c (vertical_scroll_offset_changed): Sync
	for adjustment to scrollbars.
	(horizontal_scroll_offset_changed): Idem.

972 973
2001-05-14  Jody Goldberg <jgoldberg@home.com>

974 975 976 977 978
	* src/sheet-control-gui.c (vertical_scroll_offset_changed) : reinstate
	  this and optionally support delayed scrolling.
	(horizontal_scroll_offset_changed) : ditto.
	(scg_construct) : reinstate.

979 980 981
	* src/expr.c (cellref_boundingbox) : new function.
	(expr_tree_boundingbox) : implement.

982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998
2001-05-14  Almer S. Tigelaar  <almer@gnome.org>

	* src/colrow.c (rows_height_update): Add shrink flag.
	(cb_autofit_height_no_shrink): Callback function for new
	autofit without shrinking functionality.

	* src/commands.c (cmd_paste_cut_redo): Adjust for change
	to rows_height_update.
	(cmd_paste_copy_undo): Idem.
	(cmd_autoformat_undo): Idem.
	(cmd_format_undo): Idem.

	* src/clipboard.c (clipboard_paste_region): Idem.

	* src/sheet.c (sheet_clear_region): Idem.
	(sheet_apply_style): Idem.

999 1000 1001 1002 1003 1004 1005 1006 1007
2001-05-14  Almer S. Tigelaar  <almer@gnome.org>

	* src/commands.c (cmd_paste_copy_impl): New, contains
	what was previously in cmd_paste_copy_undo.
	(cmd_paste_copy_undo): Call upon cmd_paste_copy_impl.
	(cmd_paste_copy_redo): Idem.
	(cmd_paste_copy): Remove initialization of me->is_undo flag,
	the flag has been burned.

1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019
2001-05-14  Almer S. Tigelaar  <almer@gnome.org>

	* configure.in: Bump GAL version requirement to 0.7.99.5
	
  	* src/workbook-format-toolbar.c (cb_back_color_changed): Add
  	by_user flag handling and sync the combo's on all other views
 	if the color changes.
  	(cb_fore_color_changed): Idem.
  	(workbook_create_format_toolbar): Pass workbook view's to
  	color_group_fetch and sync the colors of the back and fore combo's
 	with the other views on creation.

1020 1021 1022 1023 1024 1025 1026 1027 1028
2001-05-14  Miguel de Icaza  <miguel@ximian.com>

	* src/sheet-control-gui.c: Removed support routines that used the
	Excel-like toolbar.  I got fed up with it. 
	(scg_construct): Use regular Gtk scrollbars.  Connect to value
	changed to reflect the state of the scrollbar on the spreadsheet
	inmediately instead of doing the broken Excel behaviour.
	That is one feature I cloned that was totally idiotic.

Almer S. Tigelaar's avatar
Almer S. Tigelaar committed
1029 1030 1031 1032 1033
2001-05-13  Almer S. Tigelaar  <almer@gnome.org>

	* src/workbook-control-gui.c (wbcg_error_splits_array):
	Resolve warning.

1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046
2001-05-13  Almer S. Tigelaar  <almer@gnome.org>
 
 	* src/colrow.c (colrow_save_sizes): Use float.
 	(colrow_restore_sizes): Use float.
 	(colrow_restore_sizes_group): Walk the selections
 	in parallel with the saved_sizes. Now this will
 	actually work for variabele size multiple selections.

	* src/commands.c (cmd_paste_copy_undo): Use the new
	is_undo flag. We need this to properly set and restore
	the row heights.
	(cmd_paste_copy_redo): Set is_undo to false.
	(cmd_paste_copy): Init is_undo flag.
1047 1048 1049

	* src/commands.c (cmd_resize_colrow): Correct descriptor
	for autofitting.
1050
	
1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062
2001-05-13  Jody Goldberg <jgoldberg@home.com>

	* src/clipboard.c (clipboard_paste_region) : Use the new CLEAR_NORESPAN
	  flag.  It is premature to respan the content of surrounding cells.
	  That should only happen AFTER the new content goes in.

	* src/sheet.c (sheet_cell_calc_span) : check for spans into this cell
	  even if this cell is a merged cell.
	(sheet_clear_region) : Make the respan conditional on a new flag.

	* src/workbook-control-gui.c (cb_change_zoom) : Always update the zoom
	  combo in case the entry does not match what was used.
1063

1064 1065
	* src/commands.c (cmd_clear_selection) : only print warning once.
	(cmd_clear_undo) : There is no undo for pasting comments.
1066 1067 1068
	(cmd_paste_copy) : doh! We can not print the name of the target range,
	  it is out of bounds!
	(cmd_paste_cut) : ditto.
1069

1070 1071 1072
	* src/item-grid.c (item_grid_draw) : If everything is hidden we can
	  get into odd states.

1073 1074 1075
	* src/expr.c (eval_expr_real) : New peek code generated some spurious
	  errors when concatenating blanks.

1076 1077 1078 1079 1080
2001-05-12  Jody Goldberg <jgoldberg@home.com>
	From Juan Pablo Mendoza <pablo_juan@yahoo.com>

	* src/workbook-control-gui.c (show_gui) : remove -64 limit.

1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098
2001-05-11  Jody Goldberg <jgoldberg@home.com>

	* src/application.c (application_real_time_auto_expr_recalc) : new
	  function.

	* src/sheet.c (auto_expr_timer_clear) : new function.
	(sheet_update) : toggle the selection_content_changed flag here and
	  use a timer rather than an idle handler.

	* src/workbook-edit.c (wbcg_edit_ctor) : Init the sensitivity timer.

	* src/workbook-control-gui.c (workbook_setup_edit_area) : Use
	  wbcg_edit_ctor.
	(wbcg_destroy) : use wbcg_edit_dtor.

	* src/main.c (gnumeric_main) : setlocale (LC_ALL, NULL) to force
	  initialization of LC_* from the environment.

1099 1100 1101 1102 1103
2001-05-11  Jon K Hellan  <hellan@acm.org>
 
 	* src/sheet-control-gui.c (scg_rangesel_changed): Improve handling
 	of merged cells. Freeze expr entry display until final range is found.
 
Jody Goldberg's avatar
Jody Goldberg committed
1104 1105
2001-05-10  Jody Goldberg <jgoldberg@home.com>

1106 1107 1108
	* src/workbook.c (workbook_sheet_delete) : Clear the combos as well as
	  the menus.

Jody Goldberg's avatar
Jody Goldberg committed
1109 1110
	* src/workbook-view.c (wb_view_selection_desc) : intelligent naming.

1111 1112 1113 1114 1115
2001-05-10  Morten Welinder  <terra@diku.dk>

	* src/main.c (gnumeric_main): Complain if binary is more than 180
 	days old.

1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126
2001-05-10  Almer S. Tigelaar  <almer@gnome.org>

	* src/commands.c (cmd_paste_cut_undo): Restore
	row heights after undo.
	(cmd_paste_cut_redo): Backup row heights.
	(cmd_paste_cut_destroy): Destroy saved sizes.
	(cmd_paste_cut): Initialize saved sizes.
	(cmd_paste_copy_undo): Save and restore row heights.
	(cmd_paste_copy_destroy): Destroy saved sizes.
	(cmd_paste_copy): Initialize saved sizes.

1127 1128 1129 1130 1131 1132 1133 1134 1135 1136
2001-05-09  Jody Goldberg <jgoldberg@home.com>

	* src/xml-io.c (xml_read_selection_info) : typo.  Use the child not
	  the parent node.
	(xml_write_selection_info) : Save the real position.

	* src/sheet.c (sheet_new_scg) : set cursor bound, not the details.
	(sheet_cursor_set) : add some sanity checks.
	(sheet_clone_selection) : use the real edit_pos.

Jody Goldberg's avatar
Jody Goldberg committed
1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154
2001-05-09  Jody Goldberg <jgoldberg@home.com>

	* src/item-cursor.c (cb_move_cursor) : typo.

	* src/cmd-edit.c (cmd_shift_cols) : correct bound if shifting right.
	(cmd_shift_rows) : correct bound if shifting down.

	* src/gnumeric-sheet.c (gnumeric_sheet_make_cell_visible) : If the
	  first == last then it is likely we are uninitialized and we can
	  start the search from the first the target may be contained in the
	  current region without scrolling.

	* src/sheet-control-gui.c (scg_construct) : resize is now called when
	  attached and the zoom scg_set_zoom_factor is set.
	(scg_set_zoom_factor) : resize.

	* src/workbook-control.c (workbook_control_init_state) : cut-n-paste-o.

1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238
2001-05-08  Jody Goldberg <jgoldberg@home.com>

	* src/selection.c (sheet_selection_set_internal) : split this out into.
	* src/sheet-merge.c (sheet_merge_find_container) : here.
	* src/sheet-control-gui.c (scg_rangesel_changed) : and here.

2001-05-08  Jody Goldberg <jgoldberg@home.com>

	* src/xml-io.c (xml_read_selection_info) : Use sheet_set_edit_pos.

	* src/selection.c (sheet_selection_extend) : merge into
	  scg_cursor_extend.

	* src/sheet-control-gui.c (scg_cursor_move_to) : rename from
	  scg_cursor_move.
	(scg_cursor_extend) : merge scg_cursor_extend_[hv]
	(scg_cursor_move) : merge scg_cursor_move_[hv]
	(scg_rangesel_extend) : merge scg_rangesel_extend_[hv]
	(scg_rangesel_move) : merge scg_rangesel_move_[hv]
	(scg_rangesel_start) : cleanup.

	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) : fix handling
	  of Home. Simplify the function pointers for move vs extend by
	  merging horizontal and vertical versions.

2001-05-08  Jody Goldberg <jgoldberg@home.com>

	s/scg_stop_range_selection/scg_rangesel_stop/

	s/scg_set_cursor_bounds/scg_cursor_bound/
	s/scg_cursor_vertical_extend/scg_cursor_extend_v/
	s/scg_cursor_horizontal_extend/scg_cursor_extend_h/
	s/scg_cursor_vertical_move/scg_cursor_move_v/
	s/scg_cursor_horizontal_move/scg_cursor_move_h/
	s/scg_cursor_vertical_extend/scg_rangesel_extend_v/
	s/scg_cursor_horizontal_extend/scg_rangesel_extend_h/
	s/scg_cursor_vertical_move/scg_rangesel_move_v/
	s/scg_cursor_horizontal_move/scg_rangesel_move_h/

	* src/sheet-control-gui.[ch] : Move the rangesel info from
	  gnumeric-sheet into here in preparation for panes.
	(scg_rangesel_extend_v) : merge content from
	  gnumeric-sheet equivalent.
	(scg_rangesel_extend_h) : ditto.
	(scg_rangesel_move_v) : ditto.
	(scg_rangesel_move_h) : ditto.
	(scg_rangesel_start) : ditto.
	(scg_rangesel_stop) : ditto.
	(start_range_selection) : moved from gnumeric-sheet.
	(scg_rangesel_possible) : renamed from
	    gnumeric_sheet_can_select_expr_range.
	(scg_rangesel_changed) : renamed from scg_range_selection_changed
	  and make this the point that rationalizes the cursor points.
	(scg_cursor_bound) : renamed from scg_set_cursor_bounds
	  and make this the point that raionalizes the cursor points.
	(scg_ant) : changes to item_cursor_set_bounds.
	(scg_colrow_select) : rangesel support is now in scg.
	(scg_select_all) : ditto.

	* src/workbook-edit.c : cleanup includes.

	* src/item-grid.c (item_grid_event) : rangesel support is now in scg.
	(item_grid_button_1) : ditto.

	* src/item-cursor.h : privatize the structure and class.

	* src/item-cursor.c (cb_autofill_scroll) : changes to
	  item_cursor_set_bounds_visibly signature.
	(cb_move_cursor) : ditto.
	(item_cursor_set_bounds_visibly) : changes to item_cursor_set_bounds
	  signature.
	(item_cursor_selection_event) : ditto.
	(item_cursor_set_bounds) : simplify.

	* src/item-bar.c (is_pointer_on_division) : rangesel support is now in scg.

	* src/gnumeric-sheet.[ch] : move the rangesel logic up into scg.

2001-05-08  Jody Goldberg <jgoldberg@home.com>

	From Juan Pablo Mendoza <pablo_juan@yahoo.com>
	* src/sheet.c: (sheet_clone_colrow_info): Clone col and row
	  default size.

1239 1240 1241 1242 1243 1244 1245
2001-05-08  Almer S. Tigelaar  <almer@gnome.org>

	* src/colrow.c (colrow_restore_sizes_group): Restore
	default from list of savedsizes.
	(colrow_set_sizes): When changing default save as
	list of savedsizes.

1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283
2001-05-08  Almer S. Tigelaar  <almer@gnome.org>

	* src/workbook-control-gui.c (wbcg_menu_state_update): New, combine
	all the enabling/disabling of menu items here including the newly
	added show/hide menu items.
	(wbcg_menu_state_enable_insert): Remove.
	(wbcg_menu_state_paste_special): Remove.
	(workbook_control_gui_ctor_class): Init menu_state_update callback
	and remove paste_special and enable_insert initializations.
	(workbook_control_gui_init): Initialize show/hide menu items.

	* src/workbook-control-gui-priv.h: Add show/hide detail menu items
	and tidy structure lay-out.
	
	* src/workbook-control-priv.h: Remove menu_state_enable_insert
	and menu_state_paste_special callbacks and add menu_state_update
	callback.
	
	* src/workbook-control.[ch]: Add wb_menu_state_update and
	remove wb_menu_state_paste_special and wb_menu_state_enable_insert.
	(wb_control_sheet_add): call wb_menu_state_update, Remove
	call to menu_state_paste_special.

	* src/sheet-private.h: Add enable_showhide_detail.
	
	* src/sheet.c (sheet_new): Initialize menu state booleans.
	(sheet_menu_state_enable_insert): Use wb_control_menu_state_update.
	
	* src/workbook-view.c (wb_view_menus_update): Idem and
	remove call to wb_control_menu_state_paste_special.
	
	* src/application.c (application_clipboard_clear): Idem.
	(application_clipboard_copy): Idem.
	(application_clipboard_cut): Idem.

	* src/selection.c (sheet_selection_set_internal): Add comment for
	show/hide detail enabling/disabling, something we can't do just yet.

1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301
2001-05-08  Jody Goldberg <jgoldberg@home.com>

	* src/clipboard.c (clipboard_paste_region) : Add PASTE_IGNORE_COMMENTS.

	* src/commands.c (cmd_merge_cells_undo) : Use it here.

2001-05-07  Jody Goldberg <jgoldberg@home.com>

	* src/sheet-merge.c (sheet_merge_remove) : adjust comments.
	(sheet_merge_add) : ditto.

	* src/sheet-object-cell-comment.c (comment_get_points) : handle merged
	  cells.

	* src/commands.c (cmd_unmerge_cells) : don't queue an undo object if
	  there is nothing to do.
	(cmd_merge_cells) : filter existing ranges too.

1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314
2001-05-07  Jody Goldberg <jgoldberg@home.com>

	* src/item-cursor.c (item_cursor_event) : ignore events while editing.

	* src/functions/fn-string.c (gnumeric_value) : s/free/g_free/
	* src/parse-util.c (parse_cell_name_list) : ditto.

	* src/parser.y (gnumeric_expr_parser) : reorganize slightly to improve
	  readability.

	* src/sheet.c (sheet_range_contains_region) : doh!.  forgot to invert
	  logic when I renamed the function.

1315 1316 1317 1318 1319 1320
2001-05-07  Jon K Hellan  <hellan@acm.org>

	* src/sheet-control-gui.c (scg_select_all): Handle select button
	both within and outside guru mode.
	(button_select_all): Use scg_select_all.

1321
2001-05-07  Morten Welinder  <terra@diku.dk>
1322 1323 1324 1325 1326 1327

	* src/stf.c (stf_write_workbook): Plug file descriptor leak.
	(stf_write_func): Constify.
	(stf_open_and_read): Protect against missing file size after
 	fstat.

1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338
2001-05-07  Almer S. Tigelaar  <almer@gnome.org>

	* src/workbook-edit.c
	(workbook_edit_toolbars_set_sensitive): New, enable/disable
	all toolbars. Now works for bonobo toolbars too.
	(cb_thaw_ui_toolbar): Use toolbars_set_sensitive.
	(workbook_edit_set_sensitive): Idem.

	* src/GNOME_Gnumeric.xml: Add toolbar commands and set verbs
	on existing toolbars.

1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349
2001-05-07  Almer S. Tigelaar  <almer@gnome.org>
    
    	* src/parser.y (gnumeric_expr_parser): Display which
    	token caused the parse error. And display more detailed
    	error messages for paren matching errors using
    	check_parens.
   	(find_matching_close): Utility function for paren matching.
    	(check_parens): Renamed from find_bracket. Replace bracket
    	with paren everywhere for consistency.
    	(yylex): Kill paren matching here.
 
Morten Welinder's avatar
Morten Welinder committed
1350 1351
2001-05-07  Morten Welinder  <terra@diku.dk>

Morten Welinder's avatar
Morten Welinder committed
1352 1353
	* src/item-grid.c (drag_start): Plug leak.

Morten Welinder's avatar
Morten Welinder committed
1354 1355
	* src/plugin.c (plugin_info_read): Fix truck-size leak.
	(plugin_file_state_from_string): Plug leak.
Morten Welinder's avatar
Morten Welinder committed
1356

1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464
2001-05-07  Zbigniew Chyla  <cyba@gnome.pl>

	Improved plugin system performance & scalability:
	- reading plugin information from file only if necessary
	  (usually when activating a plugin)
	- some minor optimizations (using hashes instead of lists, etc.)

	* src/Makefile.am
	(GNUMERIC_BASE_SOURCES): Sorted some items.

	* src/gutils.h (g_list_to_vector_custom): New macro.

	* src/plugin.c:
	Made some functions static.
	s/plugin_loader_get_by_id/plugin_loader_get_type_by_id/
	(struct _PluginInfo): Added has_full_info field.
	(get_file_state_as_string, plugin_file_state_as_string,
	plugin_file_state_from_string, plugin_file_state_free,
	plugin_cache_init, plugin_cache_shutdown):
	New functions, support for caching information about plugin ids
	stored in XML files (together with modification dates).
	(plugin_info_read_full_info_if_needed_error_info,
	plugin_info_read_full_info_if_needed): New functions loading missing
	plugin information from file if necessary.
	(plugin_info_read):
	Use existing PluginInfo struct rather than creating a new one,
	take XML file name (not parsed XML tree) as an argument.
	(plugin_info_new_from_xml):
	New function, creates new PluginInfo struct from XML file (using
	plugin_info_read).
	(plugin_info_new_with_id_and_dir_name_only):
	New function, creates new PluginInfo struct with only plugin id and
	directory name given (sets has_full_info to FALSE).
	(plugin_info_get_name, plugin_info_get_description,
	plugin_info_get_extra_info_list, plugin_info_is_active,
	plugin_info_peek_name, plugin_info_peek_description,
	plugin_info_peek_loader_type_str,
	plugin_info_provides_loader_by_type_str,
	plugin_info_is_loaded, plugin_info_peek_services_data,
	plugin_info_get_loader,
	plugin_inc_dependants, plugin_dec_dependants,
	plugin_dependencies_inc_dependants,
	plugin_dependencies_dec_dependants,
	plugin_get_loader_if_needed, activate_plugin, deactivate_plugin,
	plugin_can_deactivate, plugin_info_force_mark_inactive,
	plugin_load_service, plugin_unload_service,
	plugin_load_dependencies):
	Read full plugin information if needed.
	(plugin_info_free):
	Don't try to free most data if has_full_info == FALSE.
	(plugin_info_list_read_for_dir):
	Return one PluginInfo instead of a list, create incomplete
	PluginInfo (using plugin_info_new_with_id_and_dir_name_only) if
	found a directory in plugin_file_state_dir_hash.
	(plugin_info_list_read_for_subdirs_of_dir):
	Don't check if current file is a directory (it'll be detected
	anyway).
	(plugin_db_get_known_plugin_id_list,
	plugin_db_extend_known_plugin_id_list, plugin_db_is_known_plugin,
	plugin_db_get_saved_active_plugin_id_list,
	plugin_db_is_saved_active_plugin):
	Removed.
	(plugin_db_get_available_plugin_info_list): Just return
	available_plugin_info_list, never fail.
	(plugin_db_mark_plugin_for_deactivation,
	plugin_db_is_plugin_marked_for_deactivation, plugins_shutdown):
	Use hash table (plugins_marked_for_deactivation_hash) instead of
	a list.
	(plugin_db_init): Initialize available_plugin_info_list and
	saved_active_plugin_id_list here, use a hash table when detecting
	new plugins.
	(plugins_init): Call plugin_cache_init.
	(plugins_init): Call plugin_cache_shutdown.

	* src/plugin.h
	(plugin_info_read, plugin_info_print, plugin_info_list_read_for_dir,
	plugin_info_list_read_for_subdirs_of_dir,
	plugin_info_list_read_for_subdirs_of_dir_list,
	plugin_info_list_read_for_all_dirs,
	plugin_db_extend_known_plugin_id_list, plugin_db_is_known_plugin,
	plugin_db_extend_saved_active_plugin_id_list,
	plugin_db_is_saved_active_plugin,
	plugin_db_activate_saved_active_plugins):
	Removed (most of them are now static functions).

	* src/plugin-service.c
	(plugin_service_file_saver_initialize): Fixed serious typo.

	* src/dialogs/dialog-plugin-manager.c
	(cb_pm_button_activate_plugin_clicked,
	cb_pm_button_activate_all_clicked,
	cb_pm_button_deactivate_all_clicked,
	update_plugin_manager_view): Adjusted to
	plugin_db_get_available_plugin_info_list signature change.

	* plugins/applix/plugin.xml, plugins/dif/plugin.xml,
	plugins/excel/plugin.xml, plugins/gb/plugin.xml,
	plugins/gda/plugin.xml, plugins/gnome-glossary/plugin.xml,
	plugins/guile/plugin.xml, plugins/html/plugin.xml,
	plugins/lotus-123/plugin.xml, plugins/numtheory/plugin.xml,
	plugins/oleo/plugin.xml, plugins/perl/plugin.xml,
	plugins/plan-perfect/plugin.xml, plugins/py-func/plugin.xml,
	plugins/python/plugin.xml, plugins/python-loader/plugin.xml,
	plugins/sc/plugin.xml, plugins/sylk/plugin.xml,
	plugins/xbase/plugin.xml, plugins/xml_sax/plugin.xml:
	Removed <gnumeric_plugin_group> tags. Now every directory may contain
	only one plugin.

1465 1466 1467 1468 1469
2001-05-07  Almer S. Tigelaar  <almer@gnome.org>

	* src/preview-grid.c (preview_grid_draw_background):
	Call style_border_draw_diag here.

1470 1471
2001-05-06  Jody Goldberg <jgoldberg@home.com>

1472 1473 1474 1475 1476 1477 1478 1479
	* src/style-border.c (style_borders_row_draw) : don't draw the
	  diagonals here.
	(style_border_draw_diag) : split the diag drawing code into here.

	* src/item-grid.c (item_grid_draw_merged_range) : call
	  style_border_draw_diag here.
	(item_grid_draw_background) : and here.

1480 1481 1482 1483 1484 1485 1486 1487 1488 1489
	* src/workbook-format-toolbar.c (cb_merge_cells) : fragment the
	  selection just in case.
	(cb_unmerge_cells) : ditto.  Thanks Juan Pablo.

	* src/commands.c (cmd_unmerge_cells) : remove ugly hack cast.
	(cmd_merge_cells) : ditto.  DO NOT DO THAT !

	* src/sheet.c (sheet_range_splits_region) : implement the optional
	  ignore feature for merged regions too.

1490 1491 1492 1493 1494 1495
2001-05-06  Almer S. Tigelaar  <almer@gnome.org>

	* src/colrow.c (colrow_restore_sizes): Don't free things
	twice.
	(colrow_save_sizes): Initialize run length.

1496 1497 1498
2001-05-06  Almer S. Tigelaar  <almer@gnome.org>

	* src/gnumeric.h: Define ColRowRLESizeList.
Morten Welinder's avatar
Morten Welinder committed
1499

1500 1501 1502
 	* src/commands.c (cmd_ins_del_colrow_*) : For saving
 	and restoring the col/row sizes we now use a
	ColRowRLESizeList instead of a double *.
Morten Welinder's avatar
Morten Welinder committed
1503

1504 1505 1506 1507 1508
 	* src/colrow.[ch] (colrow_save_sizes) : Rebuild to return
 	a Run-Length encoded list of sizes.
 	(colrow_restore_sizes): Idem, but as parameter.
 	(colrow_size_list_destroy): Use colrow_rle_size_list_destroy.
	(colrow_rle_size_list_destroy): Free SavedSize's.
Morten Welinder's avatar
Morten Welinder committed
1509

1510 1511 1512 1513 1514
2001-05-06  Jon K Hellan  <hellan@acm.org>

	* src/sheet-control-gui.c (scg_range_selection_changed): Change
	item cursor if expr entry changed the range.

1515 1516 1517 1518 1519 1520 1521
2001-05-06  Jon K Hellan  <hellan@acm.org>

	* src/item-bar.h:  We don't need guru_cursor.

	* src/item-bar.c (item_bar_realize, item_bar_unrealize,
	set_cursor): Ditto

1522 1523 1524 1525 1526 1527 1528
2001-05-05  Jody Goldberg <jgoldberg@home.com>

	* src/sheet-merge.c (sheet_merge_add) : update the edit_pos if
	  necessary.

	* src/sheet.c (sheet_update_only_grid) : fix typo.

1529 1530 1531 1532 1533 1534 1535
2001-05-05  Almer S. Tigelaar  <almer@gnome.org>

  	* src/item-bar.[ch]:
 	(item_bar_realize): Initialize item_bar->shade and tidy to be
 	more correct.
 	(item_bar_unrealize): Unref item_bar->shade.
 	(item_bar_draw): Use item_bar->shade.
Morten Welinder's avatar
Morten Welinder committed
1536

Jon K Hellan's avatar
Jon K Hellan committed
1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548
2001-05-05  Jon K Hellan  <hellan@acm.org>

	* src/item-bar.h (struct _ItemBar): Add guru_cursor member.

	* src/item-bar.c (item_bar_realize): Initialize guru_cursor.
	(item_bar_unrealize): Destroy guru_cursor.
	(is_pointer_on_division): Handle uninitialized case.
	(set_cursor): Do not show resize cursor in guru mode.
	(item_bar_event): Allow gurus to do range selection. Do nothing if
	guru is up but no range selector active. Do not post context menu
	when guru is up.

1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565
2001-05-04  Jody Goldberg <jgoldberg@home.com>

	* src/sheet.c (sheet_range_splits_array) : Make the displaying the
	  warning optional.
	(sheet_range_splits_region) : ditto.
	(sheet_range_contains_region) : implement.

	* src/workbook-control-gui.c (sort_cmd) : no need to check for merges
	  or arrays here.
	* src/dialogs/dialog-cell-sort.c (dialog_cell_sort) : or here.

	* src/commands.c (cmd_sort) : it belongs here.

	* src/print.c (print_page) : in the case of grid lines we were off by
	  a point.  In the case without gridlines we need not display the
	  leading cell margins.

1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709
2001-05-04  Jody Goldberg <jgoldberg@home.com>

	s/clipboard_release/cellregion_free/
	s/range_copy/range_dup/
	s/cell_region_render_ascii/cellregion_to_string/
	s/clipboard_release/cellregion_free/

	* src/commands.c (cmd_autofill) : Use sheet_range_contains_region.
	(cmd_autofill_redo) : no need to test here.
	(cmd_paste_cut) : test destination for validity and ensure that it
	  does not slice up any merged regions or arrays.  Make the descriptor
	  an argument so that other commands can use this one.
	(cmd_ins_del_colrow_redo) : use colrow_max.
	(cmd_area_set_text_redo) : use sheet_ranges_split_region.
	(cmd_colrow_outline_change) : suppress warning.

	* src/gui-clipboard.c (x_selection_to_cell_region) : simplify by using
	  some of the convenience routines.

	* src/gutils.c (gnumeric_sys_data_dir) : warning suppression.
	(gnumeric_sys_lib_dir) : ditto.

	* src/item-bar.c (item_bar_draw) : add missing warning.

	* src/item-cursor.c (item_cursor_drag_event) : Don't assume the
	  release came from the button that started the grab (think about
	  multiple simultaneous button downs.
	(item_cursor_selection_event) : ditto.
	(item_cursor_do_drop) : changes to selection_first_range.

	* src/parse-util.c (col_name_internal) : new routine split from
	  col_name with better buffer handling.
	(col_name) : used here.
	(cols_name) : and in this new function.

	* src/print.c (sheet_print_selection) : changes to
	  selection_first_range.

	* src/print-info.c (print_info_new) : default even_if_only_styles to
	  false.  This is probably what most people want.

	* src/ranges.c (range_translate) : don't invert.
	(range_height) : new util.  could probably be #define.
	(range_width) : new util.  could probably be #define.
	(range_is_infinite) : use range_is_full.
	(range_is_full) : new util.

	* src/search.c (calculate_replacement) : warning suppression.

	* src/selection.c (sheet_selection_cut) : Use
	  sheet_range_splits_region and selection_first_range.
	(sheet_selection_copy) : Use selection_first_range and remove TODO
	  about supporting not paste by content for partial arrays.
	(selection_first_range) : Add optional error reporting if there are
	  multiple selection ranges.

	* src/format.c (format_get_currency) : diddle the logic to get
	  undefined to work the way people expect for locale C.

	* src/sheet-merge.c (sheet_merge_relocate) : remove some dead code.
	(sheet_merge_add) : changes to sheet_range_splits_array.

	* src/sheet-object-widget.c (sheet_widget_checkbox_construct) :
	  changes to selection_first_range.

	* src/sheet.c (sheet_delete_{cols,rows}) : changes to
	  sheet_range_splits_array.
	(sheet_insert_{cols,rows}) : use sheet_range_splits_array.
	(avoid_dividing_array_vertical) : delete.
	(avoid_dividing_array_horizontal) : delete.
	(sheet_is_pristine) : constness.
	(sheet_mark_clean) : delete.
	(sheet_clear_region) : changes to sheet_range_splits_array.
	(sheet_ranges_split_region) : renamed from selection_check_for_array.
	(sheet_range_splits_region) : new routine to check arrays and merged
	  regions.
	(sheet_range_splits_array) : improve and add hooks to be used for
	  overlapping checks.
	(cb_check_array_vertical) : report the array being split.
	(cb_check_array_horizontal) : report the array being split.

	* src/stf-parse.c (stf_parse_region) : use cellregion_new.
	(stf_parse_is_valid_data) : simplify.

	* src/value-sheet.c (value_area_get_width) : warning suppression.
	(value_area_get_height) : warning suppression.
	(value_area_fetch_x_y : signedness.
	(value_area_get_x_y) : signedness.

	* src/value.c (value_array_resize) : signedness.
	(value_array_set) : signedness.

	* src/workbook-control-gui.c (wbcg_error_splits_array) : signature
	  change.
	(cb_insert_rows) : use selection_first_range
	(cb_insert_cols) : ditto.
	(sort_cmd) : ditto.
	(cb_workbook_debug_info) : clean out some deadwood.

	* src/workbook-edit.c (auto_complete_matches) : warning suppression.

	* src/workbook.c (workbook_sheet_detach) : warning suppression.
	(g_ptr_array_insert) : warning suppression, moved to gutils.

	* src/xml-io.c (xml_write_attributes) : warning suppression.
	(xml_read_selection_clipboard) : use cellregion_new and tidyup.

	* src/clipboard.c (paste_link) : Only make the link sheet specific if
	  we need to.
	(clipboard_paste_region) : constness, support being able to paste
	  content only as link or value.
	(clipboard_prepend_cell) : check for arrays.
	(clipboard_copy_range) : use cellregion_new
	(cellregion_new) : new function
	(cellregion_free) : renamed from clipboard_release.
	(cellregion_to_string) : moved here from render-ascii.

	src/cmd-edit.c (cmd_paste) : more protection. Merge in
	  application_paste.
	(cmd_paste_to_selection) : handle changes to selection_is_simple and
	  use selection_first_range
	(cmd_shift_rows) : changes to cmd_paste_cut.
	(cmd_shift_cols) : ditto.

	* src/command-context-priv.h : change signature of splits array.
	* src/command-context.h : ditto.
	* src/command-context.c (gnumeric_error_splits_array) : ditto.

	* src/application.c (application_clipboard_clear) :
	(application_set_selected_sheet) : remove #warning, it is not portable.

	* src/commands.c
	* src/Makefile.am : remove render-ascii.[ch]  Move their content into
	  clipboard.

2001-05-01  Jody Goldberg <jgoldberg@home.com>

	* src/clipboard.c (clipboard_prepend_cell) : remove ugly
	  implementation.

	* src/workbook-edit.c (auto_complete_matches) : remove warning.

	* src/xml-io.c (xml_write_attributes) : remove warning.

Morten Welinder's avatar
Morten Welinder committed
1710 1711 1712 1713
2001-05-04  Morten Welinder  <terra@diku.dk>

	* src/expr.c (expr_parse_string): Plug leak.

Morten Welinder's avatar
Morten Welinder committed
1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734
2001-05-04  Morten Welinder  <terra@diku.dk>

	* src/analysis-tools.c (set_cell_value): Make public.

	* src/solver-lp.c (solver_sensitivity_report,
 	solver_answer_report): Use set_cell_value.

	* src/value.c (value_peek_string): New function.

	* src/expr.c (eval_expr_real): Simplify CONCAT case using
 	value_peek_string.

	* src/datetime.c (datetime_value_to_serial_raw): Simplify using
 	value_peek_string.

	* src/workbook-view.c (wb_view_auto_expr_recalc): Ditto.

	* src/graph-vector.c (graph_vector_seq_string): Ditto.

	* src/solver-lp.c (find_name): Ditto.

1735
2001-05-04  Almer S. Tigelaar  <almer@gnome.org>
Morten Welinder's avatar
Morten Welinder committed
1736

1737 1738 1739
 	* src/GNOME_Gnumeric.xml: Correct InsertComment
 	pixmap, add pixmap for Sort and add separators
 	on the right places.
Morten Welinder's avatar
Morten Welinder committed
1740

1741 1742
 	* src/pixmaps: Split sort ascending into 16x16 and
 	24x24 versions.
Morten Welinder's avatar
Morten Welinder committed
1743

1744 1745 1746 1747 1748 1749
 	* src/application.c: Account for the split. This
 	will make the menu item show up with a correct
 	icon in Bonobo.

	* src/workbook-control-gui.c: Idem. Use the 16x16
	icon for the menu.
Morten Welinder's avatar
Morten Welinder committed
1750

1751 1752 1753 1754 1755
2001-05-04  Almer S. Tigelaar  <almer@gnome.org>

	* src/commands.c (cmd_unmerge_cells): Correct minor typo.
	(cmd_merge_cells): Idem.

1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774
2001-05-03  Jon K Hellan  <hellan@acm.org>

	* src/gnumeric-util.c (cb_remove_object_data): New callback
	function. Removes object data from wbcg when dialog is destroyed.
	(gnumeric_keyed_dialog): New function. Make dialog a transient
	child of wbcg, attaching to wbcg object data to identify the
	dialog.
	(gnumeric_dialog_raise_if_exists): New function: Raise the dialog
	identified by key if it is registered on the wbcg.

	* src/gnumeric-util.h (gnumeric_dialog_make_unique,
	gnumeric_dialog_raise_if_exists): Declare.

 	* src/about.c (dialog_about): Use gnumeric_keyed_dialog.
	Use gnumeric_dialog_raise_if_exists to ensure that only one sheet
	object config dialog at a time can be displayed for a wbcg.

 	* src/sheet-object-widget.c (sheet_widget_checkbox_user_config):
	Ditto.
1775
	
1776 1777 1778 1779 1780 1781 1782 1783 1784
2001-05-02  Almer S. Tigelaar  <almer@gnome.org>

	* src/workbook-edit.c (cb_thaw_ui_toolbar): Callback timer
	routine, re-enables the toolbars.
	(workbook_edit_set_sensitive): Add a ui timer to eliminate
	toolbar flickering.

	* src/sheet.c (sheet_menu_state_enable_insert): Clean-up.

1785
2001-05-01  Almer S. Tigelaar  <almer@gnome.org>
Morten Welinder's avatar
Morten Welinder committed
1786

1787 1788 1789 1790 1791 1792 1793 1794 1795
 	* src/parser.y (yylex): Seek for matching )'s for ('s and
 	vice versa.
 	(find_bracket): The meat for the above functionality
 	(find_char): Split out from yylex, might be useful in other
 	places. Currently used to scan for matching quotes.
	(gnumeric_expr_parser): If the ExprTree is null, assume that
	an error has occurred, set a general "invalid expression" and
	mark the whole expression. Also display more detail when both
	the expression and error message are non-null.
Morten Welinder's avatar
Morten Welinder committed
1796

1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826
2001-05-01  Almer S. Tigelaar  <almer@gnome.org>

	* src/application.[ch] (application_clipboard_unant): Use
	sheet_unant.
	(application_clipboard_clear): Idem.
	(application_clipboard_copy): Use sheet_ant.
	(application_clipboard_cut): Idem.
	(application_clipboard_is_cut): New function, is the area
	on the clipboard marked for cutting or for copying?

	* src/selection.[ch] (sheet_selection_ant): Deprecated, remove.
	(sheet_selection_unant): Idem.

	* src/sheet-control-gui.[ch] (scg_selection_ant): Rename
	to scg_ant and add a ranges parameter where the ranges to
	ant can be specified.
	(scg_selection_unant): Rename to scg_unant.
	(scg_destroy): Make sure to un-ant everything.
	(scg_construct): Ant all anted regions on the sheet.

	* src/sheet.[ch] (sheet_ant): New, ants one or more regions
	on the sheet.
	(sheet_unant): New, unants all currently anted region on the
	sheet.
	(sheet_destroy): Make sure to free the ant list.

	* src/commands.c (cmd_ins_del_colrow_undo): Remove ugly ant-hack,
	this is no longer needed, application_clipboard_cut/copy handles
	this now.
	(cmd_ins_del_colrow_redo): Idem
Morten Welinder's avatar
Morten Welinder committed
1827
	(cmd_ins_del_colrow): Oh dear, we were actually storing both
1828 1829 1830
	the cut and copied area as a cut area and we were actually
	cutting even if the range was a copied area after shifting.

Jody Goldberg's avatar
Jody Goldberg committed
1831 1832 1833 1834 1835 1836 1837 1838
2001-04-30  Jody Goldberg <jgoldberg@home.com>

	* src/about.c (dialog_about) : sync with website.

	* src/format.c (format_number) : don't suppress the minus sign when
	  faced with a space in the format.  Is there a counter example ?
	(format_number) : handle negative improper fractions.

Morten Welinder's avatar
Morten Welinder committed
1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862
2001-04-30  Morten Welinder  <terra@diku.dk>

	* src/func.c (tokenized_help_find): Warning killer.

	* src/value.c (value_new_array): Kill warnings.
	(value_new_array_empty): Ditto.
	(value_release): Ditto.

	* src/print-cell.c (print_show): Use proper types.
	(get_width_string_n): Ditto.

	* src/number-match.c (gnumeric_error_init): Warning killer.

	* src/parser.y (deallocate_all): Warning killer.

	* src/item-bar.c (item_bar_draw): Avoid signedness problems.

	* src/format-template.c (hash_table_destroy): Warning killer.

	* src/colrow.h (struct _ColRowInfo): Make size_pixels an int.

	* src/value-sheet.c (value_area_get_width, value_area_get_height):
 	Return an int, not a guint.

1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881
2001-04-30  Almer S. Tigelaar  <almer@gnome.org>

	* src/commands.c (cmd_clear_selection): More descriptive
	descriptor.
	(cmd_format): Idem.
	(cmd_resize_colrow): Idem.
	(cmd_autofill): Idem.
	(cmd_autoformat): Idem.
	(cmd_unmerge_cells): Idem.
	(cmd_merge_cells): Idem.
	(cmd_colrow_std_size): Add "pts" to end of descriptor.
	(cmd_zoom): No need to re-assign gstring.
	(range_list_to_string): Convert a list of ranges to a
	string representation.

	* src/colrow.[ch] (colrow_index_list_to_string): Convert
	an index list to a string representation.
	(colrow_string_build): Utility routine for
	colrow_index_list_to_string.
Morten Welinder's avatar
Morten Welinder committed
1882

1883 1884 1885 1886 1887 1888
2001-04-30  Almer S. Tigelaar  <almer@gnome.org>

	* src/parser.y (gnumeric_expr_parser) : Give a warning
	when both the resulting ExprTree and error message is non-null.
	This should never happen.

1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900
2001-04-29  Jody Goldberg <jgoldberg@home.com>

	* src/parser.y (yylex) : return INVALID_TOKEN rather than EOF when a
	  lexical error is found.

	* src/selection.c (sheet_selection_cut) : It is ok for the source
	  region to have merged regions or arrays.  It is NOT ok for the
	  target to have regions that are split.

	* src/cmd-edit.c (cmd_paste) : Only clear the clipboard if the paste
	  was successful.

1901 1902 1903 1904 1905 1906 1907 1908 1909 1910
2001-04-29  Almer S. Tigelaar  <almer@gnome.org>

	* src/commands.c (cmd_zoom) : Implement zoom undo/redo
	(cmd_zoom_destroy) : Idem.
	(cmd_zoom_redo): Idem.
	(cmd_zoom_undo): Idem.

	* src/workbook-control-gui.c (cb_change_zoom):
	Use cmd_zoom here.

1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926
2001-04-28  Jody Goldberg <jgoldberg@home.com>

	* src/style-border.c (print_hline) : handle offset of screen coords vs
	  printer coords.
	(print_vline) : ditto.
	(style_borders_row_print) : sync with style_borders_row_draw and pass
	  width to the line drawing to handle different coordinate types.

	* src/ranges.c (range_translate) : warn if clipped not just if
	  removed.

	* src/clipboard.c (clipboard_prepend_cell) : store the source sheet if
	  possible.
	(paste_link) : Use the right sheets.
	(clipboard_paste_region) : send enough information into paste_link.

1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940
2001-04-27  Jody Goldberg <jgoldberg@home.com>

	* src/format.c (pre_parse_format) : Catch fractions too.
	(render_number) : don't pass in so many copies of flags.  Just use the
	  info struct.  Add a 'has_fraction' flag to disable rounding.
	(do_render_number) : ditto.
	(stern_brocot) : simple stern brocot tree.  Should really use an
	  adaptive precision but I am lazy.
	(format_number) : add fractions.

	* src/commands.c (cmd_autofill_redo) : changing visiblity can triger a
	  draw which requiresthat things be rendered and spanned.  Be sure to
	  complete the action BEFORE changing visibility.

1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951
2001-04-27  Chema Celorio  <chema@celorio.com>

	* src/sheet-object.h: add the header for clone_sheet

	* src/sheet-object.c (sheet_object_clone): implement
	(sheet_object_clone_sheet): implemnt.

	* src/sheet-object-widget.c (SOW_MAKE_TYPE): add read_xml, write_xml
	and clone methods to macro
	(sheet_object_widget_clone): implement.
	Implement for X in label, frame, button, checkbox
Morten Welinder's avatar
Morten Welinder committed
1952 1953 1954 1955
	(sheet_widget_x_construct_with_label):
	(sheet_widget_x_destroy):
	(sheet_widget_x_clone):
	(sheet_widget_x_write_xml):
1956
	(sheet_widget_x_read_xml):
Morten Welinder's avatar
Morten Welinder committed
1957

1958 1959 1960 1961 1962 1963 1964 1965 1966
	(sheet_object_widget_register): implement

	* src/sheet-object-impl.h: add the clone method

	* src/sheet-object-graphic.c (sheet_object_graphic_clone): implement.
	(sheet_object_filled_clone): implement.

	* src/sheet-object-cell-comment.c (cell_comment_clone): implement

1967 1968 1969 1970
2001-04-26  Jon K Hellan  <hellan@acm.org>

	* src/item-grid.c (item_grid_button_1): Invoke
	scg_start_range_selection rather than
Morten Welinder's avatar
Morten Welinder committed
1971
	gnumeric_sheet_start_range_selection.
1972 1973 1974 1975

	* src/sheet-control-gui.[ch] (scg_start_range_selection): New function.
	Start range selection in gsheet and notify expr entry.

1976 1977
2001-04-26  Jody Goldberg <jgoldberg@home.com>

1978 1979
	* configure.in : Add configure checks for finite and isfinite

1980 1981 1982 1983 1984 1985 1986
	* src/mathfunc.h (FINITE) : Move the #define wrapper out here.

	* src/cell.c : prune some includes
	(cell_default_halign) : rename to
	* src/style.c (style_default_halign) : to simplify headers for systems
	  that do not support fwd declarations of enums. H - cough - PUX

1987 1988 1989 1990 1991
2001-04-26  Morten Welinder  <terra@diku.dk>

	* src/stf-parse.c: Put a decisive end to the signed-vs-unsigned
	problems in here.  It's all glib's fault, really.

1992 1993 1994 1995 1996 1997
2001-04-26  Morten Welinder  <terra@diku.dk>

	* src/stf-parse.c (stf_parse_options_fixed_autodiscover): Fix a
 	signed vs. unsigned error.  (We underflowed from 0 to
 	0xffff...ff.)

1998 1999 2000 2001 2002
2001-04-26  Jody Goldberg <jgoldberg@home.com>

	* src/item-grid.c (item_grid_class_init) : Drat part of a canceled
	  patch slipped in.

2003 2004 2005
	* src/ranges.c (range_is_sane) : new function.
	(sheet_merge_add) : use it here.

Jon K Hellan's avatar
Jon K Hellan committed
2006 2007 2008 2009 2010 2011
2001-04-26  Jon K Hellan  <hellan@acm.org>

	* src/item-grid.c (item_grid_draw_background): Fix typo.

	* src/gnumeric-util.c (gnumeric_dialog_run): Fix silly mistake

2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027
2001-04-26  Jon K Hellan  <hellan@acm.org>

	* src/gnumeric-util.c (gnumeric_wb_dialog_run): Eliminate attempt
	to handle parent being closed underneath dialog running a
	recursive mainloop. That can't happen since GTK 1.2.7. Move what
	remains of the function into gnumeric_dialog_run.
	(gnumeric_dialog_run): See above.
	(gnumeric_set_transient): Place dialog according to user's
	placement policy.
	(gnumeric_non_modal_dialog): Use gnumeric_set_transient to get
	placement right.

	* src/gui-file.c (gui_file_save_as, dialog_query_load_file):
	No longer place at mouse, since gnumeric_set_transient now
	honours user's dialog placement policy.

2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069
2001-04-25  Jody Goldberg <jgoldberg@home.com>

	* src/sheet-style.c (sheet_style_get_list) : Add a horizontal merge
	  before dumping to a list.
	(cb_hash_to_list) : free elements that have been merged in the
	  horizonal step, but have not yet been removed.
	(cb_hash_merge_horiz) : new function. merge when possible, after a
	  merge either free the useless bit or mark it as useless for later
	  removal.
	(cb_style_list_add_node) : Use mstyle_equal for now to remerge
	  different instances of the same logical style.  This is necessary
	  until I finish the per sheet style index.
	(sheet_style_init) : add some sanity checks incase some bright boy
	  decides to up the size of sheet and forgets here.

	* src/xml-io.c (xml_sheet_write) : Add the properties for the
	  outline mode preferences.
	(xml_sheet_read) : ditto.

	* src/item-debug.h : fix the messages to include the module
	* src/item-bar.c : fix the item-debug grab/ungrab messages.
	(item_bar_update) : gnome_canvas_group_child_bounds is a deprecated
	  useless call.
	* src/item-edit.c : fix the item-debug grab/ungrab messages.
	(recalc_spans) : gnome_canvas_group_child_bounds is a deprecated
	  useless call.
	* src/item-grid.c : fix the item-debug grab/ungrab messages.
	(item_grid_update) : gnome_canvas_group_child_bounds is a deprecated
	  useless call.
	(item_grid_button_1) : If we are going to start selecting a range have
	  the grid to a grab on button down.  This should fix the pseudo-race
	  condition that was irritating the ExprEntry.

	* src/preview-grid.c (preview_grid_update) :
	  gnome_canvas_group_child_bounds is a deprecated useless call.
	* src/item-cursor.c : fix the item-debug grab/ungrab messages.
	(item_cursor_point) : animated cursors should never receive events.

	* src/cell-draw.c (cell_draw) : It is perfectly reasonable for
	  narrow/short cols/rows to produce cells that have negative sizes
	  with the margins removed.  exit silently.

2070 2071 2072 2073 2074 2075 2076
2001-04-25  Almer S. Tigelaar  <almer@gnome.org>

	* src/stf-parse.c (stf_parse_options_fixed_autodiscover):
	Fix ugly discovering error that can cause a non-existant column
	to be discovered if there are leading spaces and avoid skipping
	over columns that should be checked for emptyness. Fixes Bug #53499

2077 2078 2079 2080 2081
2001-04-24  Almer S. Tigelaar  <almer@gnome.org>

	* src/number-match.c : We are using the fabs function, so
	include math.h

2082 2083 2084 2085 2086 2087
2001-04-24  Morten Welinder  <terra@diku.dk>

	* src/parse-util.c (gnumeric_char_start_expr_p): Make sure lines
 	like "-----------" are not considered expressions.  (Even though
 	XL does.)

2088 2089 2090 2091 2092 2093
2001-04-23  Jon K Hellan  <hellan@acm.org>

	* src/sheet-control-gui.c (scg_stop_range_selection): Stop
	sliding. This was a race condition. The slide handler would think
	we were still range selecting.

2094 2095 2096 2097 2098
2001-04-23  Morten Welinder  <terra@diku.dk>

	* src/parse-util.c (gnumeric_char_start_expr_p): Handle initial
 	dash.  Also handle initial plus better.

2099 2100 2101 2102
2001-04-23  Morten Welinder  <terra@diku.dk>

	* src/xml-io.c (xml_read_style): Compare against right version.

2103 2104 2105 2106 2107
2001-04-23  Morten Welinder  <terra@diku.dk>

	* src/number-match.c (compute_value): Handle negative numbers(!).
  	Handle overflow better.

Morten Welinder's avatar
Morten Welinder committed
2108 2109 2110 2111
2001-04-23  Morten Welinder  <terra@diku.dk>

	* src/gui-clipboard.c (x_selection_to_cell_region): Plug leak.

2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140
2001-04-23  Almer S. Tigelaar  <almer@gnome.org>

	* src/workbook-edit.c (workbook_finish_editing): Give focus
	to the edit line when an error is encountered.
	* src/workbook-control-gui.c
	(wbcg_close_control) : Don't store the partially entered expression
	when we are going to close.
	(cb_file_quit) : Idem.
	(cb_notebook_switch_page) : Idem, for switching between tabs
	when we are _not_ in a subexpression.

	* src/parser.y : Correct off-by-one glitches and strtod exponent
	out of range error problem.

	* src/expr.[ch] (expr_parse_string): Use a ParseError struct
	instead of an error string.

	* src/commands.c (cmd_area_set_text_redo): Use expr_parse_string
	in the newly corrected fashion.
	* src/expr-name.c (expr_name_create): Idem, require a ParseError
	struct to be passed instead of a char** aswell.
	* src/parse-util.c (parse_text_value_or_expr): Idem.
	* src/sheet-object-widget.c (cb_checkbox_config_clicked): Idem.
	* src/test-parser.c (main): Idem.
	* src/xml-io.c (xml_cell_set_array_expr): Idem.

	* src/sheet.c (sheet_clone_names): Use expr_name_create which now
	uses ParseError instead of char **.
	* src/xml-io.c (xml_read_names): Idem.
Morten Welinder's avatar
Morten Welinder committed
2141

2142 2143 2144 2145 2146
2001-04-23  Morten Welinder  <terra@diku.dk>

	* src/GNOME_Gnumeric.xml: Define a few more outline commands, just
 	to shut up bonobo.

2147 2148 2149 2150 2151 2152
2001-04-22  Jody Goldberg <jgoldberg@home.com>

	* src/commands.c (cmd_colrow_outline_change) : Extend logic to support
	  having collapse buttons at the start or end of the range.  Fix a few
	  for behaviors.

2153 2154
2001-04-21  Jody Goldberg <jgoldberg@home.com>

2155 2156 2157 2158
	* src/colrow.c (colrow_visibility) : Don't toggle the visibility of
	  collapsed regions even if we are only hiding things.  It will make a
	  mess of undo.

2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182
	* src/workbook-control-gui.c (wbcg_menu_state_sheet_prefs) : add some
	  new prefs for outline mode.

	* src/colrow.c (colrow_adjust_outline_dir) : new stub.  implement
	  later.

	* src/sheet-control-gui.c (scg_set_gutters) : delete.
	(scg_resize) : split from.
	(scg_set_zoom_factor) : here. change signature to use zoom associated
	  with sheet.  No need to pass it in.

	* src/sheet.c (sheet_col_row_gutter) : Use scg_resize.
	(sheet_set_zoom_factor) : signature change.
	(sheet_adjust_preferences) : Adjust signature to optionally call
	  scg_resize.

	* src/item-bar.c (compute_pixels_from_indent) : Support disabling
	  outlines.

2001-04-20  Jody Goldberg <jgoldberg@home.com>

	* src/sheet.c (sheet_new) : init outline_symbols_{below,right},
	  and display_outlines

2183 2184 2185
2001-04-21  Jon K Hellan  <hellan@acm.org>

	* configure.in (have_gda): Today, gda plugin compiles again with
Morten Welinder's avatar
Morten Welinder committed
2186
	CVS libgda. Bump required version to 0.2.4.
2187

2188 2189 2190 2191 2192
2001-04-20  Jon K Hellan  <hellan@acm.org>

	* configure.in : Make gda plugin optional. Check for suitable
	versions - present CVS version doesn't compile.

Jody Goldberg's avatar
Jody Goldberg committed
2193 2194 2195 2196 2197 2198 2199 2200 2201
2001-04-19  Jody Goldberg <jgoldberg@home.com>

	* src/embeddable-grid.c (embeddable_grid_init_anon) :  fix leak.

	* src/workbook.c (workbook_sheet_rename) : fix error message.
	(workbook_sheets) : constness.
	(workbook_sheet_count) : ditto.
	(workbook_sheet_index_get) : ditto.

2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212
2001-04-18  Jody Goldberg <jgoldberg@home.com>

	* src/sheet.c (sheet_cell_set_expr) : clear old span when an
	  expression is assigned.
	(sheet_cell_set_text) : ditto.

	* src/application.c (application_init) : add new icons.

	* src/workbook-control-gui.c : Use the new icons.
	* src/GNOME_Gnumeric.xml : ditto.

2213 2214 2215 2216 2217 2218 2219 2220 2221
2001-04-18  Jon K Hellan  <hellan@acm.org>

	* src/sheet-control-gui.c (scg_rangesel_cursor_extend,
	scg_rangesel_cursor_bounds, scg_rangesel_horizontal_move,
	scg_rangesel_vertical_move, scg_rangesel_horizontal_extend,
	scg_rangesel_vertical_extend, scg_rangesel_cursor_extend): Use
	value of item_cursor from after GnumericSheet method has been
	invoked.

2222 2223 2224 2225 2226
	* src/workbook-edit.[ch] (workbook_get_entry,
	workbook_get_entry_logical): Change return type to
	GnumericExprEntry.
	(workbook_set_entry): Change type of entry argument to
	GnumericExprEntry.
Morten Welinder's avatar
Morten Welinder committed
2227

2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267
	* src/gnumeric-sheet.c (move_cursor): Move to scg::scg_move_cursor
	(cursor_horizontal_move): Move to scg::scg_cursor_horizontal_move
	(cursor_horizontal_extend): Move to
	scg::scg_cursor_horizontal_extend
	(cursor_vertical_move): Move to scg::scg_cursor_vertical_move
	(cursor_vertical_extend): Move to scg::scg_cursor_vertical_extend
	(selection_remove_selection_string,
	selection_insert_selection_string): Remove. GnumericExprEntry
	widget now handles this.
	(start_cell_selection_at): Rename to start_range_selection_at.
	(start_cell_selection): Rename to start_range_selection.
	(gnumeric_sheet_start_cell_selection): Rename to
	gnumeric_sheet_start_range_selection.
	(gnumeric_sheet_stop_cell_selection): Rename to
	gnumeric_sheet_stop_range_selection. Remove clear_string parameter
	and selection string manipulation.
	(rangesel_horizontal_move): Make non-static, rename to
	gnumeric_sheet_rangesel_horizontal_move, remove selection string
	manipulation.
	(rangesel_vertical_move): Make non-static, rename to
	gnumeric_sheet_rangesel_vertical_move, remove selection string
	manipulation.
	(rangesel_horizontal_extend): Make non-static, rename to
	gnumeric_sheet_rangesel_horizontal_extend, remove selection string
	manipulation.
	(rangesel_vertical_extend): Make non-static, rename to
	gnumeric_sheet_rangesel_vertical_extend, remove selection string
	manipulation.
	(gnumeric_sheet_key_mode_sheet): Use movefn's from scg instead of
	from GnumericSheet.

	* src/gnumeric-sheet.h (gnumeric_sheet_start_cell_selection):
	Rename to gnumeric_sheet_start_range_selection.
	(gnumeric_sheet_stop_cell_selection): Rename to
	gnumeric_sheet_stop_range_selection. Remove clear_string
	parameter.
	(gnumeric_sheet_rangesel_horizontal_move,
	gnumeric_sheet_rangesel_vertical_move,
	gnumeric_sheet_rangesel_horizontal_extend,
	gnumeric_sheet_rangesel_vertical_extend): Declare.
Morten Welinder's avatar
Morten Welinder committed
2268

2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322
	* src/gnumeric-util.[ch] (gnumeric_entry_at_subexpr_boundary_p):
	Rename to gnumeric_expr_entry_at_subexpr_boundary_p and move to
	gnumeric_expr_entry widget.

	* src/item-grid.c (item_grid_button_1, item_grid_event): Use scg
	methods instead of methods from GnumericSheet.

	* src/sheet.[ch] (sheet_stop_cell_selection): Rename to
	sheet_stop_range_selection.

	* src/sheet-control-gui.c (scg_colrow_select): Use scg methods
	instead of methods from GnumericSheet.
	(scg_stop_editing): Add call to scg_stop_cell_selection.
	(scg_range_selection_changed): New function. Notify ExprEntry that
	the expression range has changed.
	(scg_move_cursor): Moved here from GnumericSheet.
	(scg_rangesel_cursor_extend): Add call to
	scg_range_selection_changed.
	(scg_rangesel_cursor_bounds, scg_rangesel_horizontal_move,
	scg_rangesel_vertical_move, scg_rangesel_horizontal_extend,
	scg_rangesel_vertical_extend): New functions. Call GnumericSheet
	counterpart and notify ExprEntry.
	(scg_cursor_horizontal_move, scg_cursor_horizontal_extend,
	scg_cursor_vertical_move, scg_cursor_vertical_extend): Moved here
	from GnumericSheet.
	(scg_get_sel_cursor_pos): New function. Return selection cursor
	position.

	* src/sheet-control-gui.h (scg_range_selection_changed,
	scg_move_cursor, scg_rangesel_cursor_bounds,
	scg_rangesel_horizontal_move, scg_rangesel_vertical_move,
	scg_rangesel_horizontal_extend, scg_rangesel_vertical_extend,
	scg_cursor_horizontal_move, scg_cursor_vertical_move,
	scg_cursor_horizontal_extend, scg_cursor_vertical_extend,
	scg_get_sel_cursor_pos): Declare.

	* src/sheet-control-gui.[ch] (scg_stop_cell_selection): Rename to
	scg_stop_range_selection. Notify ExprEntry that range selection
	has stopped.

	* src/sheet-object-widget.c (cb_checkbox_config_focus): Call
	gnumeric_expr_entry_select_absolute.
	(sheet_widget_checkbox_user_config): Use GnumericExprEntry. Attach
	it to the scg.

	* src/workbook-control-gui.c (cb_notebook_switch_page): Use new
	function name sheet_stop_range_selection.

	* src/workbook-control-gui-priv.h (struct
	_WorkbookControlGUI::struct edit_line): entry and temp_entry are
	now GnumericExprEntries.
	(struct _WorkbookControlGUI): Remove select_abs_col,
	select_abs_row, select_full_col, select_full_row and
	select_single_cell.
Morten Welinder's avatar
Morten Welinder committed
2323

2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341
	* src/workbook-control-gui.c (wbcg_finish_editing,
	wb_edit_key_pressed, cb_autofunction, workbook_setup_edit_area,
	auto_complete_matches): Entry must now be cast to GtkEntry.
	(workbook_control_gui_init): select_abs_col, select_abs_row,
	select_full_col, select_full_row and select_single_cell no longer
	exist.

	* src/workbook-edit.c (workbook_finish_editing, entry_changed,
	workbook_start_editing_at_cursor): entry must now be cast to
	GtkEntry.
	(workbook_start_editing_at_cursor): Attach scg to
	ExprEntry. wbcg->select_abs_col and select_abs_row no longer
	exist.
	(workbook_edit_select_absolute): Move to ExprEntry widget.
	(workbook_edit_toggle_absolute): New function. Probably remove it
	again.
	(workbook_edit_init): Remove redundant 'g_assert != NULL'. Use
	GnumericExprEntry widget.
Morten Welinder's avatar
Morten Welinder committed
2342

Jody Goldberg's avatar
Jody Goldberg committed
2343 2344 2345 2346 2347 2348 2349 2350 2351 2352 2353 2354 2355 2356 2357
2001-04-17  Jody Goldberg <jgoldberg@home.com>

	* src/workbook-control-gui.c (wbcg_init_state) : implement.

2001-04-16  Jody Goldberg <jgoldberg@home.com>

	s/workbook_control_sheets_init/workbook_control_init_state/

	* src/commands.c (command_setup_combos) : new function to initialize
	  the undo/redo combos into a known state.
	* src/workbook-control.c (workbook_control_sheets_init) : called here.

	* src/workbook-control.c (wb_control_change_view) : new virtual.
	(workbook_control_set_view) : called here.

2358 2359 2360 2361 2362
2001-04-17  Jody Goldberg <jgoldberg@home.com>

	* src/workbook-edit.c (workbook_finish_editing) : fix.  We need to
	  ignore the leading '=' or '@'.

Jon K Hellan's avatar
Jon K Hellan committed
2363 2364 2365 2366
2001-04-17  Jon K Hellan  <hellan@acm.org>

	* configure.in: Fix typo

Jody Goldberg's avatar
Jody Goldberg committed
2367 2368 2369 2370 2371 2372 2373
2001-04-16  Jody Goldberg <jgoldberg@home.com>

	* configure.in : bump GAL version reqs.

	* src/workbook-format-toolbar.c (workbook_create_format_toolbar) :
	  Jump to updated interface.  Partially fix the shared group problems.

2374 2375 2376 2377 2378 2379
2001-04-15  Almer S. Tigelaar  <almer@gnome.org>

	* src/item-grid.c : Within all functions
	where the ItemGrid is a variable, s/item_grid/ig,
	s/grid/ig.

2380 2381
2001-04-15  Jody Goldberg <jgoldberg@home.com>

2382 2383 2384 2385
	* src/item-grid.c (item_grid_draw) : Hide merged cells.
	(item_grid_draw_merged_range) : calculate the size the same way we do
	  it in cell_draw.

2386 2387 2388 2389 2390 2391 2392 2393 2394 2395 2396 2397
	* src/workbook-control-gui.c (wbcg_finish_editing) : new virtual
	(workbook_control_gui_ctor_class) : connect it here.
	(wbcg_sheet_remove_all) : be sure we are no longer editing.

	* src/workbook-control-priv.h : new virtual.
	* src/workbook-control.c : ditto.
	* src/workbook-control.h : ditto.

	* src/colrow.c (colrow_visibility) : One last potential NULL.

	* src/graph-vector.c : some portability fixes.

2398 2399 2400 2401 2402 2403 2404 2405 2406 2407
2001-04-15  Almer S. Tigelaar  <almer@gnome.org>

	* src/parser.y : Add detailed parser error messages.

	* src/workbook-edit.c (workbook_finish_editing) : Abort
	if the expression is invalid and return a boolean indicating
	success or failure.

	* src/expr.c (expr_parse_string): Set error message to the
	result of gnumeric_expr_parser.
Morten Welinder's avatar
Morten Welinder committed
2408

2409 2410 2411 2412 2413 2414 2415 2416
	* src/parse-util.c (parse_error_init) : Properly initialize
	begin and end character.

	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet): Don't
	change the cursor position if workbook_finish_editing failed.
	(move_cursor): Idem.

	* src/item-grid.c (item_grid_button_1): Idem.
Morten Welinder's avatar
Morten Welinder committed
2417

2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431
2001-04-15  Almer S. Tigelaar  <almer@gnome.org>

	* src/preview-grid.c
	(preview_grid_realize) : Remove grid gc.
	(preview_grid_unrealize) : Idem.

	* src/item-grid.c
	(item_grid_realize) : Use gc.fill, gc.cell
	and gc.empty instead of fill_gc, etc.
	(item_grid_unrealize) : Idem.
	(item_grid_draw_merged_range) : Idem.
	(item_grid_draw_background) : Idem.
	(item_grid_draw) : Idem.

2432 2433 2434 2435 2436 2437 2438
2001-04-15  Almer S. Tigelaar  <almer@gnome.org>

	* src/preview-grid-controller.c,
	src/preview-grid-controller.h : Remove entirely, the
	preview-grid-controller abstraction is no longer
	needed.

2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453 2454 2455
2001-04-15  Almer S. Tigelaar  <almer@gnome.org>

	* src/preview-grid.c (pgrid_get_style) : Calls upon
	cb_cell_get_style, if NULL use default.
	(pg_get_row_height) : Retrieve row height.
	(pg_get_col_width) : Retrieve col width.
	(pg_get_row_offset) : Get offset of row.
	(pg_get_col_offset) : Get offset of column.
	(pg_construct_cell) : Construct a cell from a value.
	(pg_destruct_cell) : Destruct a cell.
	(preview_grid_realize) : Initialize default mstyle.
	(preview_grid_unrealize) : Free default mstyle.
	(preview_grid_set_arg) : Add support for row height and col
	width.
	(pg_style_get_row) : Use pg_* routines.
	(preview_grid_draw) : Idem.

Jody Goldberg's avatar
Jody Goldberg committed
2456 2457
2001-04-13  Jody Goldberg <jgoldberg@home.com>

2458 2459 2460 2461
	* idl/Makefile.am (dist-hook) : automate removing the generated files.

	* src/workbook-control-gui.c (workbook_menu_data_outline) : new menu.

Jody Goldberg's avatar
Jody Goldberg committed
2462 2463 2464
	* src/Makefile.am : workbook-control-bonobo is not ready for prime
	  time.

2465 2466 2467 2468 2469 2470 2471 2472 2473 2474 2475 2476 2477
2001-04-13  Jon K Hellan  <hellan@acm.org>

	* src/workbook-control-gui.c (workbook_control_gui_init): Use
	gtk_idle_add to postpone clipboard setup. For mysterious reasons,
	connecting callbacks to the table doesn't work. Toplevel does
	work, but we must wait until we live inside a toplevel.

	* src/gui-clipboard.c (x_selection_received,
	x_clipboard_bind_workbook): Use wb_control_gui_toplevel to
	determine toplevel.

	* src/gui-clipboard.[ch] (x_clipboard_bind_workbook): Change
	signature to make it callable as an idle function. Make it
Morten Welinder's avatar
Morten Welinder committed
2478
	determine the toplevel from
2479

Jody Goldberg's avatar
Jody Goldberg committed
2480 2481 2482 2483 2484
2001-04-13  Jody Goldberg <jgoldberg@home.com>

	* src/style.c (font_init) : rename fontmap -> fontmap2 for newer
	  versions of gnome-print.

2485 2486
2001-04-12  Jody Goldberg <jgoldberg@home.com>

2487 2488 2489 2490 2491 2492 2493 2494 2495
	* src/Makefile.am : rename gnumeric.xml GNOME_Gnumeric.xml.

	* src/sheet.c (sheet_col_add) : update the max outline_level.
	(sheet_row_add) : ditto.

	* src/xml-io.c (xml_read_colrow_info) : restore the col/row outline
	  level data.
	(xml_write_colrow_info) : store it here.

2496 2497 2498 2499 2500 2501 2502 2503 2504 2505 2506 2507 2508 2509
	* src/colrow.c (colrow_set_visibility) : don't collapse things unless
	  they are at the end of the region.  Always uncollapse things.

2001-04-11  Jody Goldberg <jgoldberg@home.com>

	* src/item-bar.c (item_bar_draw) : tweak the redraw a bit to match
	  event handling

	* src/mstyle.c (mstyle_elements_equal) : remove pointless asserts and
	  correct the logic.
	(mstyle_element_equal) : Stop passing structs.
	(mstyle_elements_equal) : adjust here.
	(mstyle_elements_compare) : and here.

Morten Welinder's avatar
Morten Welinder committed
2510 2511 2512 2513
2001-04-12  Morten Welinder  <terra@diku.dk>

	* src/plugin-util.c: Portability fix.

Jody Goldberg's avatar
Jody Goldberg committed
2514 2515 2516 2517 2518 2519
2001-04-12  Jody Goldberg <jgoldberg@home.com>

	* src/commands.c (cmd_paste_copy_undo) : Make the corner of the
	  restored region visible.
	(cmd_autofill_undo) : Ditto.
	(cmd_autofill_redo) : Ditto.
2520 2521 2522 2523 2524
	(cmd_colrow_outline_change) : Uncollapsing things should work better
	  now.

	* src/colrow.c (colrow_set_visibility) : collapse state changes can
	  occur more than once within a range.
Jody Goldberg's avatar
Jody Goldberg committed
2525 2526 2527

	* src/sheet.c (sheet_col_row_gutter_pts) : simplify, no need to store
	  sizes in pts.  Outline level is enough.
2528
	  s/sheet_col_row_gutter_pts/sheet_col_row_gutter/
Jody Goldberg's avatar
Jody Goldberg committed
2529

2530 2531 2532 2533 2534 2535 2536 2537 2538 2539 2540 2541 2542 2543 2544 2545 2546 2547 2548 2549 2550 2551 2552 2553 2554 2555 2556 2557 2558 2559 2560 2561 2562 2563 2564
2001-04-10  Jody Goldberg <jgoldberg@home.com>

	* src/cellspan.c (cell_calc_span) : fix chema's spanning problem.

	* src/workbook-control-gui.c (workbook_menu_data) : Add an icon for
	  the sort menu item.

2001-04-9  Jody Goldberg <jgoldberg@home.com>

	s/cmd_hide_selection_colrow/cmd_colrow_hide_selection/

	* src/commands.c (cmd_colrow_outline_change) : new wrapper for
	  colrow_hide that handled outline changes.

	* src/workbook-control-gui.c (cb_insert_{cols,rows}) : cancel edit.
	(cb_select_auto_expr) : return a value.

	* src/colrow.c (cb_col_row_visibility) : Use get rather than fetch.
	(colrow_find_outline_bound) : new function.
	(cb_colrow_visibility) : turn this into a wrapper for.
	(colrow_visibility) : this, and add honour_collapse flag.
	  invert the search to go fro mthe end to the start in preparation for
	  supporting the honour_collapse flag.  Insert the items into a sorted
	  list in case we want to merge them some day.
	(colrow_get_outline_toggle) : use new routine here too.

2001-04-05  Jody Goldberg <jgoldberg@home.com>

	* src/item-bar.c (item_bar_event) : Doh!  The outline events are
	  controled by the minor coordinate.

2001-04-01  Jody Goldberg <jgoldberg@home.com>

	* src/main.c (gnumeric_main) : shut plugins down first.

2565 2566 2567 2568
2001-04-04  Morten Welinder  <terra@diku.dk>

	* src/style.c (font_init): Improve error message.  Constify.

2569 2570 2571 2572
2001-04-04  Morten Welinder  <terra@diku.dk>

	* src/style.c (font_init): Refer to bugzilla, not bugs.

2573 2574 2575 2576 2577 2578 2579
2001-04-01  Zbigniew Chyla  <cyba@gnome.pl>

	* src/plugin.c
	(plugin_db_activate_saved_active_plugins): Don't update saved active
	plugin ids if PLUGIN_DEBUG is defined.
	(plugins_shutdown): Update saved active plugin ids only if needed.

2580 2581 2582 2583 2584 2585 2586 2587 2588 2589 2590 2591 2592
2001-04-01  Almer S. Tigelaar  <almer@gnome.org>

	* src/commands.c
	(cmd_ins_del_colrow_redo): Don't mirror the size of the
	selected cols/rows, instead look at the next visible col/row
	to the top/left for the size.
	(cmd_hide_colrow_correct_selection): Pass extra "forward" parameter
	value to colrow_find_adjacent_visible.

	* src/colrow.h, src/colrow.c
	(colrow_find_adjacent_visible): Add optional "forward" parameter.
	If unset it will seek to the right/bottom otherwise to the left/top.

2593 2594 2595 2596 2597 2598 2599 2600 2601
2001-03-31  Zbigniew Chyla  <cyba@gnome.pl>

	* src/plugin.[ch]: Replaced PLUGIN_MESSAGE macro with plugin_message
	function to avoid portability problems (some compilers don't support
	vararg macros), added "level" argument.

	* src/plugin-loader.c (gnumeric_plugin_loader_load,
	gnumeric_plugin_loader_unload): Adjusted to plugin.h.

2602 2603
2001-03-30  Jody Goldberg <jgoldberg@home.com>

2604 2605 2606 2607 2608 2609 2610 2611 2612 2613 2614 2615 2616
	* src/workbook-control-gui.c (wbcg_sheet_remove_all) : clear the
	  notebook BEFORE deleting it to avoid updating during destuction.

	* src/cellspan.c (cell_calc_span) : Cells in hidden columns can not
	  have spans.

	* src/file.c (file_finish_load) : no need to manually respan this will
	  happen via sheet_update.  This gives us a nice speed up.

	* src/sheet.c (sheet_cell_calc_span) : don't reregister spans that
	  have not changed.
	(sheet_new) : init all flags to true to ensure things get updated.

2617 2618 2619 2620 2621 2622 2623 2624 2625
	* src/main.c : remove style_debug option tha was unused.
	* src/mstyle.c (mstyle_elements_equal) : It was only mostly unused :-)

	* src/workbook-control-gui.c (wbcg_menu_state_sheet_count) : fix.

	* src/item-bar.c (is_pointer_on_division) : robustify in the face of
	  clicking out of bounds.
	(item_bar_event) : ditto, also simplfy a bit.

2626 2627 2628 2629 2630
2001-03-30  Zbigniew Chyla  <cyba@gnome.pl>

	* src/plugin.h: Commented out PLUGIN_DEBUG and PLUGIN_ALWAYS_LOAD
	macros.

2631 2632 2633 2634 2635
2001-03-29  Morten Welinder  <terra@diku.dk>

	* configure.in (try_python): Fix redirections and don't use the
	non-standard "grep -q".

2636 2637 2638 2639 2640 2641 2642 2643 2644 2645 2646 2647
2001-03-29  Morten Welinder  <terra@diku.dk>

	Responding to lots of bug reports from drk@sgi.com:

	* src/application.c (application_display_dpi_get): Don't
 	explicitly inline.  (The compiler hopefully will by itself.)

	* src/sheet-object-widget.c (DEP_TO_CHECKBOX): Avoid pointer
 	arithmetic on void pointers.

	* src/item-bar.c: Don't use zero-sized array.

2648 2649 2650 2651 2652
2001-03-29  Zbigniew Chyla  <cyba@gnome.pl>

	* src/plugin-service.c (plugin_service_file_opener_probe_func):
	Print an error on terminal before ignoring it.

2653 2654 2655 2656 2657 2658 2659 2660 2661
2001-03-28  Zbigniew Chyla  <cyba@gnome.pl>

	* sheet.c
	(sheet_update): Register idle function to update "auto_expression"
	instead of doing this immediately. Calculating a sum of many values
	may take a looong time.
	(sheet_update_auto_expr_idle_func): New function (code moved from
	sheet_update) updating "auto_expression" in idle loop.

2662 2663 2664
	* sheet-priv.h (struct _SheetPrivate): Added auto_expr_idle_id
	field.

2665 2666 2667 2668 2669 2670 2671 2672 2673 2674 2675 2676 2677 2678 2679
2001-03-26  Morten Welinder  <terra@diku.dk>

	* src/workbook.c (workbook_cells): New function, extracted from
 	cmd_search_replace_do.

	* src/sheet.c (sheet_cells): New function, extracted from
 	cmd_search_replace_do.

	* src/cell.c (cell_has_comment_pos): New function for those cells
 	that aren't really there.

	* src/commands.c (cmd_search_replace_do): Use workbook_cells and
 	sheet_cells.
	(cmd_search_replace_do_cell): Change to take position instead of
 	cell.  Handle missing cells without crashing.
2680 2681
	(cmd_search_replace_undo, cmd_search_replace_redo): Fix for
 	missing cells with comments.
2682

2683 2684 2685 2686 2687 2688 2689
2001-03-25  Almer S. Tigelaar  <almer@gnome.org>

	* src/commands.c
	(cmd_ins_del_colrow_redo): Resize inserted columns/rows
	to have the same size of the columns/rows that previously
	occupied the same space.

2690 2691 2692 2693 2694 2695 2696 2697 2698
2001-03-25  Almer S. Tigelaar  <almer@gnome.org>

	* src/commands.c
	(cmd_ins_del_colrow_undo): Re-ant the original cut selection.
	(cmd_ins_del_colrow_redo): Re-ant accounting for the shift in
	columns/rows.
	(cmd_ins_del_colrow_destroy): Free stored cut range.
	(cmd_ins_del_colrow): Store the cut range if any.

2699 2700 2701 2702
2001-03-23  Almer S. Tigelaar  <almer@gnome.org>

	* src/about.c : Make some small changes and add Zbigniew.

2703 2704 2705 2706 2707
2001-03-23  Morten Welinder  <terra@diku.dk>

	* src/gnumeric-util.c (gnumeric_glade_group_value): Function moved
 	from dialog-search-replace.c.

Chyla Zbigniew's avatar
Chyla Zbigniew committed
2708 2709 2710 2711
2001-03-21  Zbigniew Chyla  <cyba@gnome.pl>

	* src/gutils.h (g_vector_free_custom macro): Fixed stupid bug.

2712 2713 2714 2715 2716 2717 2718 2719
2001-03-20  Zbigniew Chyla  <cyba@gnome.pl>

	Moved XL support from Gnumeric binary into real plugin.

	* src/Makefile.am
	(gnumeric_libs): Removed ../plugins/excel/libexcel.a

	* src/main.c:
Morten Welinder's avatar
Morten Welinder committed
2720
	Removed:
2721 2722 2723 2724 2725
	- include "../plugins/excel/boot.h"
	- xxx_debug variables
	- (gnumeric_popt_options) excel debugging options
	- excel_init() and excel_shutdown() calls

2726 2727 2728 2729 2730 2731 2732 2733 2734 2735 2736 2737 2738 2739 2740 2741 2742 2743 2744 2745 2746 2747 2748 2749 2750 2751 2752 2753 2754 2755 2756 2757 2758 2759 2760 2761 2762 2763 2764 2765 2766 2767 2768 2769 2770 2771 2772 2773 2774 2775 2776 2777 2778
2001-03-20  Zbigniew Chyla  <cyba@gnome.pl>

	Added support for plugin dependencies + some fixes.

	* src/gutils.h (g_list_to_vector, g_vector_free_custom):
	New macros. (used macros instead of functions to avoid casting and
	pointer size problems - ANSI C doesn't guarantee that
	sizeof (void *) == sizeof (something_else *).

	* src/plugin-loader.c
	(gnumeric_plugin_loader_load): Load required plugin dependencies
	before the plugin itself, increment n_deps for every loaded
	dependency (by calling plugin_dependencies_inc_dependants).
	(gnumeric_plugin_loader_unload): New function.
	(gnumeric_plugin_loader_load_service): Increment number of loaded
	services if loaded succesfully.
	(gnumeric_plugin_loader_unload_service): Decrement number of loaded
	services if unloaded succesfully, unload plugin if it reaches zero.

	* src/plugin-loader.h
	(struct _GnumericPluginLoader): Added n_loaded_services.
	(gnumeric_plugin_loader_unload): New function.

	* src/plugin-service.c:
	(plugin_service_file_opener_open_func,
	plugin_service_file_saver_save_func):
	Used gnumeric_io_error_occurred (and gnumeric_io_clear_error) when
	checking for error.

	* src/plugin.c:
	(plugins_active_by_default): Array containing ids of "standard"
	plugins. These will be active by default.
	(struct _PluginDependency): New struct.
	(struct _PluginInfo): Added dependencies_v, d_deps. Replaced
	service_list with services_v (vector in place of list).
	(plugin_info_get_config_prefix, plugin_dependency_get_plugin_info,
	plugin_info_read_dependency_list, plugin_dependency_free,
	plugin_inc_dependants, plugin_dec_dependants,
	plugin_dependencies_inc_dependants,
	plugin_dependencies_dec_dependants,
	plugin_load_dependencies):
	New functions.
	(plugin_info_provides_loader_by_type_str, plugin_info_free):
	Adjusted to service_list -> services_v change.
	(plugin_info_read): Read (optional) dependencies, adjusted to
	service_list -> services_v change.
	(activate_plugin):
	Activate required dependencies before the plugin itself.
	Increment n_deps for every activated dependency (by calling
	plugin_dependencies_inc_dependants).
	Adjusted to service_list -> services_v change.
	(deactivate_plugin):
	Decrement n_deps for every activated dependency (by calling
Morten Welinder's avatar
Morten Welinder committed
2779
	plugin_dependencies_dec_dependants).
2780 2781 2782 2783 2784 2785 2786 2787 2788 2789 2790 2791 2792 2793 2794 2795 2796
	Adjusted to service_list -> services_v change.
	(plugin_can_deactivate):
	Return FALSE if any of n_deps > 0.
	Adjusted to service_list -> services_v change.
	(plugin_list_sort_by_dependency): Removed.
	(plugin_db_activate_plugin_list): Removed sorting.
	(plugin_db_init): Always activate new plugin if it's defined in
	plugins_active_by_default array.

	* src/plugin.h:
	(PluginDependencyType): New enum.
	(plugin_load_dependencies,
	plugin_inc_dependants, plugin_dec_dependants,
	plugin_dependencies_inc_dependants,
	plugin_dependencies_dec_dependants,
	plugin_info_get_config_prefix): New functions.

2797 2798 2799 2800 2801 2802 2803 2804 2805 2806 2807 2808 2809 2810 2811 2812
2001-03-20  Zbigniew Chyla  <cyba@gnome.pl>

	* src/io-context-priv.h:
	(struct _IOContext): Added error_occurred field.

	* src/io-context.c
	(gnumeric_io_context_new): Set error_occurred to FALSE by default.
	(gnumeric_io_error_system, gnumeric_io_error_read,
	gnumeric_io_error_save): Set error_occured to TRUE.
	(gnumeric_io_error_unknown, gnumeric_io_clear_error,
	gnumeric_io_error_occurred): New functions.

	* src/io-context.h
	(gnumeric_io_error_unknown, gnumeric_io_clear_error,
	gnumeric_io_error_occurred): New functions.

2813 2814
2001-03-18  Jody Goldberg <jgoldberg@home.com>

2815 2816 2817
	* src/workbook-control-gui.c (wb_edit_key_pressed) : handle failure
	  cases better.

Jody Goldberg's avatar
Jody Goldberg committed
2818 2819
	* src/colrow.c (colrow_foreach) : Doh!

2820 2821 2822
	* src/item-bar.c (item_bar_event) : Now that we are zooming this
	  canvas we need to transform the coordinates.

2823 2824 2825 2826 2827 2828 2829 2830 2831 2832 2833 2834 2835 2836 2837 2838 2839 2840 2841 2842 2843 2844 2845 2846 2847 2848 2849 2850 2851 2852 2853 2854 2855 2856 2857 2858 2859 2860 2861 2862 2863 2864 2865 2866 2867 2868 2869 2870 2871 2872 2873 2874 2875 2876 2877 2878 2879 2880 2881 2882 2883
2001-03-16  Jody Goldberg <jgoldberg@home.com>

	* src/item-bar.c (item_bar_calc_size) : rename from
	  item_bar_fonts_init.

	* src/sheet-control-gui.c (scg_set_zoom_factor) : prepare for panes by
	  zooming the col/row header canvases.  We need this as we transition
	  to using gnumeric-sheets instead of canvases to hold the item-bars.

2001-03-15  Jody Goldberg <jgoldberg@home.com>

	* src/colrow.c (colrow_equal) : handle outline&collapse.
	(colrow_copy) : ditto.

	* src/item-bar.c (outline_button_press) : new function.
	(item_bar_event) : used here.

2001-03-15  Jody Goldberg <jgoldberg@home.com>

	* src/item-bar.c (compute_pixels_from_pts) : new function.
	(item_bar_fonts_init) : resize the indent gutters based on the zoom.
	(item_bar_realize) : add another gc for outline drawing.
	(item_bar_unrealize) : ditto.
	(item_bar_draw) : implement drawing for groupings.
	(set_cursor) : handle cursor in the presence of groupings.

2001-03-14  Jody Goldberg <jgoldberg@home.com>

	* Makefile.am : update the handling of the oaf file.

	* src/sheet.c (sheet_col_row_default_calc) : rename from
	  sheet_col_row_default_init.

2001-03-13  Jody Goldberg <jgoldberg@home.com>

	* src/xml-io.c (xml_write_print_repeat_range) : PrintRepeatRange now
	  uses a simple Range.
	(xml_read_print_repeat_range) : ditto.
	* src/print-info.c (print_info_new) : ditto.
	(save_range) : Ditto.
	* src/dialogs/dialog-printer-setup.c (do_fetch_page_info) : ditto.
	* src/print.c (print_range_used_units) : ditto.
	(print_range_right_then_down) : ditto.
	(print_range_down_then_right) : ditto.
	(print_page_repeated_intersect) : ditto.
	(print_page_repeated_cols) : ditto.
	(print_page_repeated_rows) : ditto.
	(print_page) : ditto.

	* src/sheet-control-gui.c (scg_set_zoom_factor) : The sizing has moved
	  into the itembar.

	* src/item-bar.c : s/orientation/is_col_header/
	(item_bar_fonts_init) : Init the ideal cell size.
	(item_bar_update) : Begin to support grouping.
	(item_bar_draw) : ditto.
	(item_bar_init) : init the new members.

	* src/print-cell.c (print_cell) : re-enable halign FILL.
	* src/cell-draw.c (cell_draw) : ditto.

Jody Goldberg's avatar
Jody Goldberg committed
2884 2885 2886 2887
2001-03-17  Jody Goldberg <jgoldberg@home.com>

	* Release 0.64

2888 2889 2890 2891 2892
2001-03-16  Zbigniew Chyla  <cyba@gnome.pl>

	* configure.in: Checking if we can build a shared library depending on
	libpython and disabling Python support otherwise.

2893 2894 2895 2896 2897
2001-03-15  Jon K Hellan  <hellan@acm.org>

	* src/workbook-control-gui.c (verbs): Fix the build for bonobo by
	  ifdefing out verbs for cb_data_validate and cb_view_freeze_panes.

2898 2899