1. 08 Sep, 2007 1 commit
  2. 25 Nov, 2006 1 commit
    • Jody Goldberg's avatar
      add validation-combo.h · 131aee7a
      Jody Goldberg authored
      2006-11-24  Jody Goldberg <jody@gnome.org>
      	* src/Makefile.am : add validation-combo.h
      	* src/mstyle.c (gnm_style_get_validation) : constify the result.  We
      	  should not modify it while it's part of a style.
      	* src/sheet-control-gui.c (cb_collect_objects_to_commit) : handle
      	  no-view case.
      	* src/gnumeric-pane.c (gnm_pane_display_obj_size_tip) : ditto.
      	* src/sheet-object.c (sheet_object_clear_sheet) : Handle
      	  so::sheet == NULL (eg when data validation combo is cleared from
      	  wbv::finalize after content_destroy clears the sheet list)
      	  Drop the return flag, nothing was using.
      	* src/validation.c (gnm_validation_combo_new) : new.
      	(gnm_validation_combo_class_init) : new.
      	(gnm_validation_combo_finalize) : new.
      	(gnm_validation_combo_init) : new.
      	(validation_ref) : allow the reffing of const objects.
      	(validation_unref) : ditto, this should really be split into a const
      	  and non-const version.  We can do that for all unref routines.
      	* src/value.h : create new struct GnmValueIter.
      	* src/value.c (gnm_value_get_type) : Make GnmValue a glib boxed type.
      	* src/value-sheet.c (value_area_foreach) : rework to use GnmValueIter.
      	  All callers changed.
      	* src/workbook-view.h : s/::current_format/::current_style/
      	  and make it const.  We have a ref to it, so it's not going away
      	  _but_ we should never change it.
      	  Add validation_combo.  For the sheet object corresponding to an
      	  in cell data validation combo.
      	* src/workbook-view.c (wb_view_style_feedback) : renamed from
      	  wb_view_format_feedback all callers changed.  Add a creation
      	  and removal of data validation in cell combo.
      	(wb_view_finalize) : clear the validation combo if it exists.
      	(workbook_view_new) : init the combo.
      2006-11-24  Jody Goldberg <jody@gnome.org>
      	* tools/xmlunzip : Add the 'macro enabled' formats from office12
  3. 13 Nov, 2006 2 commits
    • Morten Welinder's avatar
      Use wb_view_detach_from_workbook. (workbook_detach_view, · 4cfea5d6
      Morten Welinder authored
      2006-11-13  Morten Welinder  <terra@gnome.org>
      	* src/workbook.c (workbook_dispose): Use
      	(workbook_detach_view, workbook_attach_view): Don't set wbv->wb
      	here.  Set in caller.
      	* src/workbook-view.c (workbook_view_class_init): Install new
      	property: auto-expr-text.
      	(wb_view_get_property, wb_view_set_property,
      	wb_view_auto_expr_text): Handle auto-expr-text.
      	(wb_view_detach_from_workbook): New function.
      	(wb_view_finalize): Use wb_view_detach_from_workbook.
      	* src/workbook-control-priv.h (WorkbookControlClass): Remove
      	auto_expr_value member.
      	* src/workbook-control-gui.c (wbcg_auto_expr_text_changed): New
      	function hooked up to WorkbookView::auto-expr-text.
      	(wbcg_auto_expr_value): Removed.
    • Morten Welinder's avatar
      Control auto-expression via wbv properties. · d532e209
      Morten Welinder authored
      2006-11-12  Morten Welinder  <terra@gnome.org>
      	* src/workbook-control-gui.c (cb_auto_expr_changed): Control
      	auto-expression via wbv properties.
      	(cb_auto_expr_precision_toggled): Ditto.
      	* src/workbook-view.h (WorkbookView): Replace auto_expr with more
      	sane auto_expr_func member.
      	* src/workbook-view.c (wb_view_auto_expr_recalc): Remove
      	always-TRUE second argument.  All callers changed.  Adjust to
      	WorkbookView changes.
      	(wb_view_auto_expr): Remove.
      	(wb_view_auto_expr_precision): Make static.
      	(workbook_view_class_init): Install properties for
  4. 12 Nov, 2006 1 commit
  5. 10 May, 2006 1 commit
    • Jody Goldberg's avatar
      new function broken out of wbv_save_to_uri for convenience. This API will · f1eccf84
      Jody Goldberg authored
      2006-05-09  Jody Goldberg <jody@gnome.org>
      	* src/workbook-view.c (wbv_save_to_output) : new function broken out
      	  of wbv_save_to_uri for convenience.  This API will change.
      	* src/sheet.c
      	(sheet_insert_cols) : make reloc_storage arg optionally NULL.
      	(sheet_delete_cols) : ditto.
      	(sheet_insert_rows) : ditto.
      	(sheet_delete_rows) : ditto.
  6. 30 Apr, 2006 1 commit
    • Jody Goldberg's avatar
      merge excel_write_PANE into here and fix export of H or V only freezes. · 563646db
      Jody Goldberg authored
      2006-04-29  Jody Goldberg <jody@gnome.org>
      	* ms-excel-write.c (excel_write_WINDOW2) : merge excel_write_PANE into
      	  here and fix export of H or V only freezes.
      2006-04-23  Jody Goldberg <jody@gnome.org>
      	* xlsx-write.c : new.  Basic export and some code that will move to
      	  libgsf for 'Open Package' support.
      	* plugin.xml.in : Add xlsx export.
      	* Makefile.am : ditto.
      2006-04-23  Jody Goldberg <jody@gnome.org>
      	* ms-excel-read.c (excel_read_EXTERNSHEET_v7) : patch
      	  tweak to import broken quoted sheetname from gnumeric-1.0.x eg
      2006-04-23  Jody Goldberg <jody@gnome.org>
      	* ms-chart.c (ms_excel_chart_read) : Don't set the graph and chart
      	  styles to blank unless this is a full sheet object.  Fixes the
      	  import of older charts that are not wrapped in BOF records eg
      2006-04-29  Jody Goldberg <jody@gnome.org>
      	* src/workbook-view.c (wb_view_get_index_in_wb) : new for xlsx export.
      	* src/selection.h (sv_selection_foreach) : renamed from
      	  selection_foreach_range.  All callers changed.
      	* src/selection.c (sv_selection_add_full) : renamed from
      	  sv_selection_add_range to be clearer.
      	(sv_selection_add_range) : new utility that takes a ... GnmRange.
      	* src/sheet-view.h : SheetView::selections make this a GSList, no need
      	  for a GList.  This makes the api more homogeneous.
      	* src/cell.c (cell_get_style) : constify the result and rename from
      	* src/ranges.c (range_as_string) : renamed from range_name.  All
      	  callers fixed.
      	* src/style-conditions.c (gnm_style_conditions_eval) : tack on hooks
      	  for some of the new condition types in office 12.
  7. 31 Mar, 2006 1 commit
    • Morten Welinder's avatar
      Remove. Remove. Remove. Remove. Remove. Remove. Remove. · 36afb7f3
      Morten Welinder authored
      2006-03-31  Morten Welinder  <terra@gnome.org>
      	* src/mathfunc.c (gcd): Remove.
      	* src/sheet-view.c (sv_get_control): Remove.
      	* src/stf-parse.c (stf_parse_options_remove_line_terminator): Remove.
      	* src/value.c (value_new_error_RECALC, value_array_resize): Remove.
      	* src/workbook-view.c (-wb_view_sheet_remove): Remove.
      	* src/ranges.c (range_adjacent, range_merge, range_is_infinite,
      	gnm_sheet_range_dup): Remove.
      	* src/sheet-control-gui.c (scg_toplevel): Remove.
      	* src/print-info.c (hf_formats_base_num): Make static.
      	* src/number-match.c (datetime_locale): Make static.
  8. 19 Mar, 2006 1 commit
    • Jody Goldberg's avatar
      init valid to false in case value_coerce_to_number fails and does not set · d4b73077
      Jody Goldberg authored
      2006-03-18  Jody Goldberg <jody@gnome.org>
      	* src/graph.c (gnm_go_data_vector_get_value) : init valid to false
      	  in case value_coerce_to_number fails and does not set it.
      	* src/gnumeric-pane.c (cb_sheet_object_view_destroyed) : handle life
      	  cycle change.
      2005-12-28  Jody Goldberg <jody@gnome.org>
      	* src/workbook.c : Move to GsfDocMetaData
      	* src/commands.c (cmd_change_meta_data*) : re-work for new metadata
      	* src/Makefile.am : remove the defunct summary.[ch]
      	* src/GNOME_Gnumeric-gtk.xml.in : enable the new dialog in place of
      	  the old one.
      	* src/wbcg-actions.c : ditto.
  9. 08 Jun, 2005 1 commit
    • Morten Welinder's avatar
      Rename "visible" property to "visibility" and make it an enum. All users · 380ff133
      Morten Welinder authored
      2005-06-08  Morten Welinder  <terra@gnome.org>
      	* src/sheet.c (gnm_sheet_class_init): Rename "visible" property to
      	"visibility" and make it an enum.  All users changed.
      	* src/sheet.h (struct _Sheet): Ditto for is_visible member.
      	* src/workbook-view.c (wb_view_sheet_remove): New function to
      	mirror wb_view_sheet_add.
      	* src/workbook.c (workbook_sheet_hide_controls): Use
  10. 03 May, 2005 1 commit
    • Morten Welinder's avatar
      Remove. · c4f8f07d
      Morten Welinder authored
      2005-05-03  Morten Welinder  <terra@gnome.org>
      	* src/workbook-view.c (wb_view_prefs_update): Remove.
      	* src/workbook-control-priv.h: Remove prefs_update member.
      	* src/sheet-control-priv.h: Remove adjust_preferences and
      	direction_changed members.
      	* src/sheet-control-gui.c (sheet_control_gui_new): Also hook up to
      	* src/workbook-control-gui-priv.h: Remove rtl property.  All users
      	changed to use sheet's text_is_rtl (and some already were).
      	* src/sheet-control-gui-priv.h: Remove text_is_rtl property.  All
      	users changed to use sheet's text_is_rtl (and some already were).
  11. 28 Mar, 2005 1 commit
    • Morten Welinder's avatar
      New function. · e2a98475
      Morten Welinder authored
      2005-03-28  Morten Welinder  <terra@gnome.org>
      	* src/workbook-view.c (wb_view_auto_expr_precision): New function.
      	* src/workbook-control-gui.c (cb_auto_expr_precision_toggled): New
      	(cb_select_auto_expr): Add a check item to control whether maximum
      	precision is used.
  12. 04 Mar, 2005 1 commit
  13. 08 Feb, 2005 1 commit
  14. 11 Jun, 2004 1 commit
    • Morten Welinder's avatar
      Switch to using URIs internally. · 38fdf042
      Morten Welinder authored
      2004-06-11  Morten Welinder  <terra@gnome.org>
      	* src/workbook.c (workbook_set_uri): Ranamed from
      	(workbook_get_uri): Renamed from workbook_get_filename.
      	* src/application.c (gnm_app_history_add): Change to take uri.
      	All callers changed.
      	* src/wbc-gtk.c (wbc_gtk_reload_recent_file_menu): Adapt to uris.
      	* src/gui-file.c (gui_file_read, do_save_as, go_file_is_writable):
      	Changed to take uri.  All callers changed.
      	* src/workbook-view.c (wb_view_new_from_uri): Renamed from
      	wb_view_new_from_file and adapted to take uri.  All callers
      	(wb_view_save_as): Change to take uri.  All callers changed.
  15. 10 May, 2004 1 commit
    • Jody Goldberg's avatar
      It seems like there can be multiple WINDOW2, SCL, PANE, SELECTION blocks · 959e4025
      Jody Goldberg authored
      2004-05-09  Jody Goldberg <jody@gnome.org>
      	* ms-excel-read.c (excel_read_WINDOW2) : It seems like there can be
      	  multiple WINDOW2, SCL, PANE, SELECTION blocks when there are
      	  multiple windows.  For now we don't support importing multiple views
      	  so we need to at least not break if a previous view was frozen.
  16. 12 Nov, 2003 2 commits
  17. 11 Oct, 2003 1 commit
    • Jody Goldberg's avatar
      new to write csv files without intervention. (stf_init) : Use it. · 7a725771
      Jody Goldberg authored
      2003-10-10  Jody Goldberg <jody@gnome.org>
      	* src/stf.c (stf_write_csv) : new to write csv files without
      	(stf_init) : Use it.
      2003-10-09  Jody Goldberg <jody@gnome.org>
      	* src/libgnumeric.c : pull the ancient if BONOBO checks
      	* src/io-context-gtk.c (icg_show_gui) : mark the window as a splash.
      	* schemas/Makefile.am : make friendlier for rpm builders
  18. 03 Jul, 2003 1 commit
    • Jody Goldberg's avatar
      remove gnome-print include · 6d388511
      Jody Goldberg authored
      2003-07-02  Jody Goldberg <jody@gnome.org>
      	* widget-font-selector.c : remove gnome-print include
      	* widget-pixmap-combo.h : Cleanup the includes
      	* gtk-combo-box.c (gtk_combo_box_init) : Use GObject properties in
      	  place of deprecated gtk_window_set_policy.
      	(gtk_combo_popup_tear_off) : ditto.
      	(gtk_combo_box_popup_display) : Use gtk_window_move in place of
      	  deprecated gtk_window_set_uposition.
      	(gtk_combo_box_get_pos) : Make multi head safe.
      2003-07-02  Jody Goldberg <jody@gnome.org>
      	* dialog-tabulate.c (dialog_tabulate) : Use GObject properties in
      	  place of deprecated gtk_window_set_policy.
      2003-07-02  Jody Goldberg <jody@gnome.org>
      	* src/sheet-control-gui.c (scg_comment_display) : Use gtk_window_move
      	  in place of the deprecated gtk_widget_set_uposition.
  19. 05 May, 2003 1 commit
    • Andreas J. Guelzow's avatar
      add argument to call of wb_view_new_from_input · 002c067b
      Andreas J. Guelzow authored
      	* src/bonobo-io.c (gnm_persist_stream_load): add argument
      	  to call of wb_view_new_from_input
      	* src/charset.c: new file
      	* src/charset.h: new file
      	* src/file-priv.h: (_GnmFileOpenerClass): add argument to
      	  declaration of open method
      	(_GnmFileOpener): add encoding_dependent field
      	(gnm_file_opener_setup): add argument
      	* src/file.c (gnm_file_opener_open_real): new argument to pass
      	  to open call
      	(gnm_file_opener_setup): new argument to be used for
      	  initialization of added field
      	(gnm_file_opener_new): add argument to call of
      	(gnm_file_opener_new_with_enc): new function
      	(gnm_file_opener_is_encoding_dependent): new function
      	(gnm_file_opener_open): new argument
      	* src/file.h (GnmFileOpenerOpenFuncWithEnc): new type
      	(gnm_file_opener_new_with_enc): new function
      	(gnm_file_opener_open): new argument
      	(gnm_file_opener_is_encoding_dependent): new function
      	* src/gui-clipboard.c (table_cellregion_read): add argument
      	  to call of wb_view_new_from_input
      	* src/gui-file.c (file_format_changed_cb_data): new type
      	(make_format_chooser): only make option menu
      	(gui_file_read): new argument to be passed to call of
      	(file_format_changed_cb): new callback
      	(gui_file_open): add encoding selector to load file dialog
      	* src/gui-file.h (gui_file_read): new argument
      	* src/history.c (file_history_cmd): add argument to call of
      	* src/main-application.c (main): add argument to call of
      	* src/plugin-service.c (gnm_plugin_file_opener_open): new
      	(gnm_plugin_file_opener_new): add argument to call of
      	* src/stf.c (stf_open_and_read): new argument
      	(stf_preparse): handle encoding conversion
      	(stf_read_workbook_auto_csvtab): new argument to be passed to
      	  the call of stf_parse
      	(stf_init): setup encoding
      	* src/workbook-view.c (wb_view_new_from_input): new argument to
      	  passed to the call of gnm_file_opener_open
      	(wb_view_new_from_file): new argument to be passed to the call
      	* src/workbook-view.h (wb_view_new_from_input): new argument
      	(wb_view_new_from_file): new argument
      	* corba-application.c (capp_workbook_open): add argument
      	  to call of wb_view_new_from_file
      	* Makefile.am: add src/charset.[ch]
  20. 05 Dec, 2002 1 commit
    • Jon Kåre Hellan's avatar
      Renamings: · 4afde1db
      Jon Kåre Hellan authored
      GnumFile  -> GnmFile
      gnum_file -> gnm_file
  21. 27 Jun, 2002 1 commit
    • Jody Goldberg's avatar
      add missing break. · c7e7774e
      Jody Goldberg authored
      2002-06-26  Jody Goldberg <jody@gnome.org>
      	* src/expr.c (do_gnm_expr_unref) : add missing break.
      2002-06-26  Jody Goldberg <jody@gnome.org>
      	* src/gui-util.c (gui_file_open) : move the magic directory selector
      	  for here.
      	(gnumeric_dialog_file_selection) : to here, so that it works for other
      	  situations too.
  22. 23 Jun, 2002 1 commit
    • Jody Goldberg's avatar
      delete the 'selection' function. It is no longer possible with a · 778809a4
      Jody Goldberg authored
      2002-06-23  Jody Goldberg <jody@gnome.org>
      	* src/func-builtin.c (func_builtin_init) : delete the 'selection'
      	  function.  It is no longer possible with a sheetview.
      	* src/workbook-control-gui.c (cb_select_auto_expr) : remove
      	  'selection(0)' argument and just pass function name.  The conversion
      	  to SheetView forces a different methodology.
      	* src/workbook-view.c (workbook_view_new) : ditto.
      	(wb_view_auto_expr_recalc) : Make the call manually.
  23. 19 Jun, 2002 2 commits
    • Jody Goldberg's avatar
      no need to unant, that is a view responsibility. · 753f052a
      Jody Goldberg authored
      2002-06-19  Jody Goldberg <jody@gnome.org>
      	* src/sheet.c (sheet_destroy) : no need to unant, that is a view
      	* src/sheet-view.c (sv_weakref_notify) : new.
      	(sv_weak_ref) : new.
      	(sv_weak_unref) : new.
      	(sv_unant) : move here from sheet.
      	(sv_ant) : move here from sheet.
      	(sv_selection_copy): from selection.c
      	(sv_selection_cut) : from selection.c
      	* src/sheet-control.c (sc_view) : new.
      	* src/sheet-control-gui.c (scg_ant) : the animated cursors are now
      	  stored in the view not the sheet.
      	(context_menu_handler) : sync with the workbook control criteria for
      	  enabling paste special.
      	* src/selection.c (sheet_selection_copy) : start the process of
      	  migrating to SheetView and move this there.
      	(sheet_selection_cut) : ditto.
      	* src/item-cursor.c (item_cursor_do_action) : pass a SheetView.
      	* src/gnumeric-canvas.c (gnm_canvas_key_mode_sheet) : pass a
      	* src/corba-sheet.c : untested patch to handle views.
      	* src/commands.c (cmd_ins_del_colrow_undo) : use the sheetview.
      	(cmd_ins_del_colrow_redo) : ditto.
      	(cmd_ins_del_colrow_finalize) : remove weakref on the view.
      	(cmd_ins_del_colrow) : add a weak ref to the view.
      	* src/application.c (application_init) : we store a view now, not just
      	  a sheet.
      	(application_clipboard_clear) : update all workbooks, not just this
      	  one, and store the view.
      	(application_clipboard_unant) : use the view.
      	(application_set_selected_sheet) : the selection is now view based.
      	(application_clipboard_cut_copy) : take a view and remove the crufy
      	  enable_paste_special flag.  That is handled locally.
      	(application_clipboard_is_empty) : handle SheetView.
      	(application_clipboard_is_cut) : ditto.
      	(application_clipboard_sheet_get) : ditto.
      	(application_clipboard_sheet_view_get) : ditto.
      	* src/workbook-control-gui.c (wbcg_menu_state_update) : Use the
      	  current sheet not some magic sheet.
      	* src/sheet.c (sheet_new) : delete enable_paste_special.
      	* src/workbook-control-gui.c (wbcg_menu_state_update) : paste special
      	  is for local copies, use the application data rather than a sheet
      	  local flag.
    • Jody Goldberg's avatar
      renamed from sheet_attach_control. (sheet_detach_view) : renamed from · a4555c21
      Jody Goldberg authored
      2002-06-19  Jody Goldberg <jody@gnome.org>
      	* src/sheet.c (sheet_attach_view) : renamed from sheet_attach_control.
      	(sheet_detach_view) : renamed from sheet_detach_control.
      	* src/sheet-view.c : new.
      	* src/sheet-control.c (sc_sheet_set) : delete bogus.
      	(sc_view) : new.
      	* src/sheet-control-gui.c (sheet_control_gui_new) : A control now takes a
      	  view in place of a model.
      	* src/selection.c (sheet_selection_redraw) : adjustment to
      	* src/gnumeric.h : Add SheetView
      	* src/Makefile.am : Add sheet-view.[ch]
      2002-06-18  Jody Goldberg <jody@gnome.org>
      	* src/workbook-control-gui.c (cb_insert_current_date) : check for
      	  failure to start editing.
      	(cb_insert_current_time) : ditto.
  24. 08 Jun, 2002 1 commit
    • Jody Goldberg's avatar
      libgsf has landed. · 7c1e9d5c
      Jody Goldberg authored
      libgsf has landed.
      2002-06-07  Jody Goldberg <jody@gnome.org>
      	* src/workbook-view.c (wb_view_open) : convert to libgsf.
      	* src/stf.c (stf_open_and_read) : convert to libgsf.
      	(stf_preparse) : ditto.
      	(stf_read_workbook) : ditto.
      	(stf_read_workbook_auto_csvtab) : ditto.
      	(stf_read_default_probe) : ditto.
      	* src/stf-parse.c (stf_parse_is_valid_data) : actually disable the
      	  wide char support if it is not available.
      	* src/gutils.c (gnm_extension_pointer) : copied from libgnome to
      	  decrease our dependence on it.
      	* src/gui-util.c (gnumeric_editable_enters) : modernize a bit.
      	* src/gnumeric-simple-canvas.c (gnm_simple_canvas_grab) : suppress
      	* src/file.c (gnum_file_opener_probe_real) : Use libgsf.
      	(gnum_file_opener_open_real) : ditto.
      	(gnum_file_opener_probe) : ditto.
      	(gnum_file_opener_open) : ditto.
      	(gnum_file_saver_save_to_stream_real) : disable, we can move this out
      	  of here when GsfOutput comes online.
      	* src/collect.c (string_range_function) : suppress warning.
      	* src/cell.c (cell_set_array_formula) : Adjust to the signature change
      	  for gnm_expr_new_array.
      	* src/sheet-autofill.c (autofill_cell) : ditto.
      2002-06-07  Jody Goldberg <jody@gnome.org>
      	* configure.in : require libgsf.
      	* src/xml-io.c (xml_check_version) : move the sanity checking here.
      	(gnumeric_xml_read_workbook) : rather than here.  Support GsfInput.
      	(xml_probe) : and here.
      	(gnumeric_xml_write_workbook_to_stream) : delete.
      2002-05-31  Jody Goldberg <jody@gnome.org>
      	* src/gnumeric-simple-canvas.c (gnm_simple_canvas_grab) : actually
      	  return the result.
  25. 16 Apr, 2002 1 commit
  26. 22 Mar, 2002 1 commit
    • Jody Goldberg's avatar
      Massive rename ExprTree -> GnmExpr · 0ac8fbbf
      Jody Goldberg authored
      2002-03-21  Jody Goldberg <jody@gnome.org>
      	* Massive rename
      	ExprTree -> GnmExpr
      	* src/print-info.c (load_formats) : suppress some warnings.
      	* src/func.c (function_def_call_with_values) : use g_alloca.
  27. 09 Mar, 2002 1 commit
    • Jody Goldberg's avatar
      switch Format->Workbook with Format->AutoFormat ditto. · 73a18b0f
      Jody Goldberg authored
      2002-03-08  Jody Goldberg <jody@gnome.org>
      	* src/GNOME_Gnumeric.xml : switch Format->Workbook with
      	* src/workbook-control-gui.c (workbook_menu_format) : ditto.
      	* src/workbook-view.c (wb_view_is_protected) : new.
      	* src/workbook-edit.c (wbcg_edit_start) : load style directly
      	  don't use cell_get_style.  This enables support for protection of
      	  blank cells.  Use wb_view_is_protected, and command_context_invalid.
      2002-03-08  C. Scott Ananian <cananian@lesser-magoo.lcs.mit.edu>
      	* src/gnumeric-canvas.c (gnm_canvas_key_mode_sheet): don't put us in
      	  edit mode if wbcg_edit_start indicates the cell is locked.
      	* src/workbook-control-gui.c (cb_autosum, cb_autofunction): handle
      	  case where wbcg_edit_start returns FALSE indicating that cell is
      	* src/workbook-edit.c (wbcg_edit_start): this function now returns a
      	   boolean which indicates whether the 'edit_start' attempt succeeded.
      	   Check cell properties to return FALSE if the cell is locked.
      	* src/workbook-edit.h (wbcg_edit_start): modify the prototype as per above.
      	* src/workbook-view.c (wb_view_set_attribute, workbook_view_init):
      	  Remove ARG_VIEW_* enumeration, which isn't used after Gnome2 port.
      	  Add WorkbookView::is_protected attribute, and initialize it to
      	  FALSE.  The update to wb_view_set_attribute is enough to get
      	  xml_sax import working properly (yay, modular code!).
      	* src/workbook-view.h: add 'is_protected' field to WorkbookView struct.
      	  This is TRUE iff the workbook is locked.
      	* src/xml-io.c (xml_write_wbv_attributes):
      	  Write the new 'protected' workbook view attribute.  Two lines are
      	  enough to get read/write from xml_io working.  Score one for
      	  xml_sax: zero should have been sufficient.
      	* src/dialogs/cell-format.glade: The 'worksheet protected' checkbox
      	  shouldn't be greyed-out anymore.
      	* src/dialogs/dialog-cell-format.c (cb_protection_sheet_protected_toggle,
      	fmt_dialog_init_protection_page, cb_fmt_dialog_dialog_buttons):
      	  connect up the 'worksheet protected' button in the
      	  Format->Cells->Protection dialog.  Update worksheet object when
      	  toggled and mark that the dialog's changed.
      	* src/dialogs/dialog-workbook-attr.c src/dialogs/workbook-attr.glade:
      	  Add Format->Worksheet->Protection dialog.
  28. 15 Feb, 2002 1 commit
    • Jody Goldberg's avatar
      We can now make distcheck · f84a08c5
      Jody Goldberg authored
      Requires a GAL update, and a gtk+ update
      2002-02-15  Jody Goldberg <jody@gnome.org>
      	* src/item-cursor.c (item_cursor_tip_setlabel) : enable now that the
      	  canvas bug is fixed.
      	* src/sheet-control-gui.c (cb_hscrollbar_adjust_bounds) : new.
      	(cb_vscrollbar_adjust_bounds) : new.
      	* src/gui-util.c (gtk_button_stock_alignment_set) : new.
      	(gnumeric_init_help_button) : new.
      	* src/gnumeric-canvas.h : Move declaration of
      	  GnumericCanvasSlideHandler here.
      	* src/gnumeric-canvas.c (gnm_canvas_guru_key) : forward to the entry,
      	  not the GnumericExprEntry wrapper.
      	(gnm_canvas_key_mode_sheet) : ditto.
      	* src/formats.c (cell_format_classify) : handle general.
      	* src/file-priv.h : Inherit from GObject.
      	* src/complete-sheet.c (complete_sheet_finalize) : call class_peek
      	  here to avoid potential reference problems.
      	* src/commands.c (cmd_set_text) : doh!  fix multi-line text.
      	(cmd_autoformat) : const.
      	* src/cell.c (cell_relocate) : const.
      	* src/clipboard.c (paste_cell_with_operation) : const.
      	(paste_cell) : ditto.
      	* src/application.c (application_init) : add jimmac's expr-entry icon.
      	* src/Makefile.am : distribute the marshaller.list
      	s/gtk_signal_connect/g_signal_connect/  + reformating.
      2002-02-11  Jody Goldberg <jody@gnome.org>
      	* src/stf.c (stf_init) : Make the names of the text import/export
  29. 01 Feb, 2002 1 commit
    • Jody Goldberg's avatar
      A pile of stale commits. · 10a5bf7a
      Jody Goldberg authored
      2002-01-30  Jody Goldberg <jody@gnome.org>
      	* ms-formula-read.c (ms_excel_parse_formula) : give a warning when
      	  dealing with references to external workbooks.
      2002-01-31  Jody Goldberg <jody@gnome.org>
      	* src/workbook-control-gui.c (wbcg_focus_cur_scg) : warning
      	(sheet_control_gui_new) : enable partial scrollbar support.
      	* src/workbook-control.c (wb_control_parse_and_jump) : make defined
      	  names absolute.
      2002-01-30  Jody Goldberg <jody@gnome.org>
      	* src/dialogs/dialog-autoformat.c (templates_load) : changes to
      	* src/xml-io-autoft.c (gnumeric_xml_write_format_template) : take a
      	  context not a control to clarify things.
      	(gnumeric_xml_read_format_template) : ditto.
      	* src/workbook.c (workbook_persist_file_save) : changes to
      	* src/io-context.c (io_context_destroy) : impl is a command context now.
      	(gnumeric_io_context_new) : weaken requirements so that all we need is
      	  a command context.  Not strictly necessary, but makes it less likely
      	  that people will get confused.
      	* src/workbook-view.c (wb_view_save_as) : Take a command context not a
      	  workbook control to avoid confusing what we are saving.
      	(wb_view_save) : ditto.
      	(wb_view_selection_desc) : Implement using an explicit control.
      	(wb_view_open_custom) : add a missing precondition.
      	* src/gui-file.c (do_save_as) : changes to wb_view_save_as.
      	(gui_file_save_to_stream) :  changes to gnumeric_io_context_new.
      	* src/file-autoft.c (category_get_templates_list) : take a command
      	context, not a workbookcontrol.
      	(category_group_get_templates_list) : ditto.
      	* src/format-template.c (format_template_new) : ditto.
      	(format_template_new_from_file) : ditto.
  30. 29 Jan, 2002 1 commit
    • Jody Goldberg's avatar
      move to new sheet widget layout. · b83b3724
      Jody Goldberg authored
      2002-01-29  Jody Goldberg <jody@gnome.org>
      	* ms-excel-read.c (ms_sheet_create_obj) : move to new sheet widget
      2002-01-29  Jody Goldberg <jody@gnome.org>
      	* src/workbook-control-gui.c (cb_notebook_switch_page) : fix changing
  31. 23 Jan, 2002 1 commit
  32. 01 Nov, 2001 1 commit
    • Jody Goldberg's avatar
      generalize and fix leak. (cb_add_clicked) : generalize. (cb_select_row) : · 2ab27ef1
      Jody Goldberg authored
      2001-11-01  Jody Goldberg <jgoldberg@home.com>
      	* dialog-autocorrect.c (cb_remove_clicked) : generalize and fix leak.
      	(cb_add_clicked) : generalize.
      	(cb_select_row) : generalize.
      	(autocorrect_init_exception_list) : new.
      	(exceptions_callback) : clean up slightly.
      	(ac_button_toggled) : simplify.
      	(ac_dialog_toggle_init) : new.
      	(dialog_autocorrect) : simplify.  Rather than saving the content
                and restoring on cancel, only store the new values on <OK>.
      2001-11-01  Jody Goldberg <jgoldberg@home.com>
      	* src/workbook-edit.c (entry_changed) : autocomplete is in the wbv now.
      	(wbcg_edit_start) : ditto.
      	* src/sheet-style.c (rstyle_apply) : fix some silliness in the new
      	  code, but more work to come.
      	* src/commands.c (cmd_set_text) : Yay! autocorrect is no longer tied
      	  to the gui.
      	* src/application.c (application_init) : Init autocorrection.
      	* src/workbook-view.c (wb_view_set_arg) : add do_auto_completion.
      	  Make this a per workbook-view, persistent attribute.  We still
      	  initialize from gnome-config, butthis should make things easier
      	  for users.
      	(wb_view_get_arg) : ditto.
      	(workbook_view_class_init) : ditto.
  33. 05 Jul, 2001 1 commit
    • Jody Goldberg's avatar
      Initial support for frozen panes. · 99073bd9
      Jody Goldberg authored
      2001-07-04  Jody Goldberg <jgoldberg@home.com>
      	* src/sheet-merge.c (sheet_merge_add) : Use sheet_redraw_range.
      	* src/sheet-control.c (sc_set_panes) : new virtual.
      	(sc_set_sheet) : renamed from sc_invalidate_sheet.
      	* src/sheet-control-gui.c (scg_primary_pane) : new function. Be very
      	  careful when using this.  It should not be necessary in most cases.
      	(scg_get_wbcg) : convenience routine.
      	(scg_redraw_all) : frozen panes.
      	(scg_redraw_region) : renamed from scg_redraw_cell_region, and frozen
      	  pane support.
      	(scg_redraw_headers) : merge in the code from gnumeric-sheet.
      	(scg_update_cursor_pos) : pane support.
      	(scg_resize) : ditto.
      	(scg_set_zoom_factor) : ditto.  Broken. needs to resize the panes.
      	(scg_scrollbar_config) : adjust to panes.
      	(scg_make_edit_pos_visible) : use scg_make_cell_visible.
      	(scg_colrow_select) : reorg a bit.
      	(vertical_scroll_offset_changed) : adjust to panes.
      	(horizontal_scroll_offset_changed) : ditto.
      	(cb_table_destroy) : ditto.
      	(scg_init) : init the top here.
      	(bar_set_left_col) : from gnumeric-sheet. Still needs work for panes.
      	(bar_set_top_row) : ditto.
      	(gnumeric_sheet_set_left_col) : ditto.
      	(gnumeric_sheet_set_top_row) : ditto.
      	(scg_set_left_col) : TODO.
      	(scg_set_top_row) : ditto.
      	(gnumeric_sheet_set_top_left) : new function split from.
      	(gnumeric_sheet_make_cell_visible) : here.
      	(scg_make_cell_visible) : adjsut to panes and do the real work here.
      	(scg_make_cell_visible_virt : wrapper for use as virtual.
      	(gnumeric_pane_new) : new function.
      	(gnumeric_pane_delete) : ditto.
      	(scg_set_panes) : ditto.
      	(scg_construct) : move the table attachments around and move the
      	  canvas groups into the panes.
      	(sheet_control_gui_new) : beef this up.
      	(scg_unant) : adjust to panes.
      	(scg_ant) : ditto.
      	(scg_cursor_visible) : ditto.
      	(scg_cursor_bound) : ditto.
      	(scg_adjust_preferences) : ditto.
      	(scg_compute_visible_region) : ditto.
      	(scg_create_editor) : ditto.
      	(scg_stop_editing) : ditto.
      	(scg_take_focus) : ditto.
      	(scg_sliding_callback) : adjust top panes, but is still much too
      	(scg_start_sliding) : ditto.
      	(cb_slide_handler) : ditto.
      	(cb_control_point_event) : ditto.
      	(new_control_point) : ditto.
      	(set_item_x_y) : ditto.
      	(set_acetate_coords) : ditto.
      	(scg_object_calc_position) : ditto.
      	(scg_object_view_position) : ditto.
      	(scg_rangesel_changed) : ditto.
      	(scg_rangesel_start) : ditto.
      	(scg_rangesel_stop) : ditto.
      	(scg_rangesel_move) : ditto.
      	(scg_rangesel_extend) : ditto.
      	* src/item-grid.c (sheet_object_begin_creation) : Use the group
      	  associated with the gsheet, not the scg, and use GNUMERIC_IS_SHEET
      	  in preference to != NULL.
      	* src/item-bar.c : Store the gnumeric-sheet rather than the scg so
      	  that we can get to the Pane.
      	* src/embeddable-grid.c (grid_view_activate) : Use scg_take_focus.
      	(grid_view_new) : Use sheet_control_gui_new in place of sheet_new_scg.
      	* convert to E_MAKE_TYPE
      	* Use IS_SHEET in preference to sheet != NULL
      	* sheet_range_calc_spans signature change
      	* src/clipboard.c (clipboard_paste_region) : special handling when
      	  pasting into a selection that consists of a single merged cell.
      	* src/application.c (application_set_selected_sheet) : Use IS_SHEET.
      	(application_clipboard_copy) : ditto.
      	(application_clipboard_cut) : ditto.
      	* src/Makefile.am :
      	    command-context-corba -> workbook-control-corba
      	* src/sheet.c : convert to using IS_SHEET in place of sheet != NULL in
      	  several places.
      	(sheet_is_frozen) : new function.
      	(sheet_freeze_panes) : implement.
      	(sheet_new) : init frozen pane data.
      	(sheet_range_calc_spans) : pass a pointer rather than copy of the range.
      	  and use sheet_redraw_range.
      	(sheet_apply_style) : use sheet_redraw_range.
      	(cb_sheet_get_extent) : premature optimization is evil.
      	(sheet_redraw_region) : rename from sheet_redraw_cell_region.
      	(sheet_set_edit_pos) : use sheet_redraw_range.
      	(sheet_move_range) : ditto.
      	(sheet_init_sc) : new routine.
      	(sheet_attach_control) : rename and task from sheet_new_scg.
      	(sheet_redraw_region) : renamed from sheet_redraw_cell_region.
      	* src/item-cursor.c (item_cursor_update) : increase the spacing for
      	  the autohandle.
      	* src/GNOME_Gnumeric.xml :
      	  - Use Control*colon and Control*semicolon
      	  - desensitize the graph guru for now.
      	  - Add freeze/thaw
      	* src/item-bar.c (item_bar_unrealize) : no need to double unref the
      	* src/print-cell.c (print_merged_range) : This is not being drawn on
      	  the screen, no need for all the fancy calcs to only draw the visible
      	  bits.  We will just clip it.
      	* src/print-cell.c (print_cell) : Use the calulated width, not the col
      	  width for splitting.
      	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) : Use the scg_
      	  versions of things in preference to the gnumeric_sheet_ versions.
      	(gnumeric_sheet_new) : Store the Pane that this is associated with.
      	(gnumeric_sheet_bar_set_top_row) : moved to sheet-control-gui.c
      	(gnumeric_sheet_set_top_row) : ditto.
      	(gnumeric_sheet_bar_set_left_col) : ditto.
      	(gnumeric_sheet_set_left_col) : ditto.
      	(gnumeric_sheet_make_cell_visible) : ditto.
      	(gsheet_compute_visible_region) : handle panes.
  34. 25 May, 2001 1 commit
    • Jody Goldberg's avatar
      fix logic to avoid adding a bogus view. · 237ebd5b
      Jody Goldberg authored
      2001-05-25  Jody Goldberg <jgoldberg@home.com>
      	* src/workbook-view.c (wb_view_open_custom) : fix logic to avoid
      	  adding a bogus view.
      2001-05-24  Jody Goldberg <jgoldberg@home.com>
      	* src/eval.c (workbook_recalc) : don't clear the flag until after the
      	  calc is complete in case there is a cycle.
      	(cell_eval) : ditto.
  35. 24 May, 2001 1 commit
    • Jody Goldberg's avatar
      Revamp the recalc queue · af206304
      Jody Goldberg authored
      2001-05-22  Jody Goldberg <jgoldberg@home.com>
      	* gnumeric.spec.in : bump version of libole2
      	* README : ditto.
      	* configure.in : ditto.
      2001-05-19  Jody Goldberg <jgoldberg@home.com>
      	* src/workbook.c (workbook_is_pristine) : no need to check the recalc
      	  queue.  If there are no dependents there is nothing to put on the
      	  eval queue.
      	* src/func.c (cb_iterate_cellrange) : rename from
      	  iterate_cellrange_callback remove 'generation' mechanism.
      	* src/cell.c (cell_cleanout) : Clear both recalc flags,
      	  in_queue and needs
      	(cell_copy) : ditto.
      	(cell_eval_content) : No need to render the value.  assign_value
      	  already does it.
      	(cell_content_changed) : deleted.
      	* src/Makefile.am : merge dependent.[ch] into eval.[ch]
      2001-05-18  Jody Goldberg <jgoldberg@home.com>
      	* src/eval.c : reorg and merged with dependent.[ch]
      	* src/sheet.c (sheet_cell_set_text) :
      	(sheet_cell_set_expr) : ditto.
      	(sheet_cell_set_value) : ditto.
      	(colrow_move) : ditto.
      	(sheet_destroy_contents) :
      	* src/cmd-edit.c (cmd_select_cur_row) : Make behavior match XL.
      	(cmd_select_cur_col) : Make behavior match XL.
      	* src/format.c (render_number) : avoid temporaries.
      	(do_render_number) : ditto.
      2001-05-17  Jody Goldberg <jgoldberg@home.com>
      	* src/expr.c (eval_range) : delete.
      	(eval_expr_real) : Use workbook_foreach_cell_in_range rather than
      	  range_eval.  Remove 'generation' mechanism.
      	(cb_range_eval) : a simple pass through
      	* src/eval.c (sheet_region_recalc_deps) : rename from
      	  sheet_recalc_dependencies and merge in sheet_region_get_deps.
      	  Use the new foreach style interfaces.
      	(cb_single_recalc_all_depends) : rename from cb_single_get_all_depends
      	  and simplify.
      	(cb_range_recalc_all_depends) : rename from cb_sheet_get_all_depends and simplify.
      	(cb_dependent_queue_recalc) : new wrapper.
      	(cb_region_contained_depend) : renamed from search_range_deps and simplify.
      	(cell_foreach_dep) : rename from cell_get_dependencies and switch to
      	  an in place api rather than creating a list.
      	(cell_foreach_single_dep) : switch to in place api
      	(cell_foreach_range_dep) : ditto.
      	(search_cell_deps) : ditto.
      	(cell_recalc_deps) : ditto.
      	(cell_eval) : ditto.
      	(cb_generation_queue) : new utility.
      	* src/dependent.c (dependent_list_filter) : delete.
      	* src/cmd-edit.c (cb_collect_deps) : new function split from.
      	(cmd_select_cur_depends) : here. So that we can use the new depend
      	* src/sheet.c (sheet_move_range) : use sheet_region_recalc_deps.
      	(sheet_{insert,delete}_{cols,rows}) : ditto.
      	(sheet_cell_remove_simple) : Use in place depend interface.
      	* src/cell.c (cell_content_changed) : Use in place depend interface.
      	* src/clipboard.c (clipboard_paste_region) : ditto.
      	* src/commands.c (cmd_area_set_text_redo) : ditto.
      	(cmd_autofill_redo) : ditto.
      2001-05-21  Jody Goldberg <jgoldberg@home.com>
      	* Makefile.am : remove gnorba and modernize a bit.
  36. 21 May, 2001 1 commit
    • Chyla Zbigniew's avatar
      Cleaned up file i/o interface. · 33d35aa2
      Chyla Zbigniew authored
      Cleaned up file i/o interface.
      * src/Makefile.am: Added file-priv.h.
      * src/file.[ch]:
      Made GnumFileOpener and GnumFileSaver GtkObjects with virtual probe,
      open and save methods.
      New GnumFileOpener methods: get_id.
      New GnumFileSaver methods: get_id, fix_file_name.
      New functions: register_file_opener, register_file_opener_as_importer,
      unregister_file_opener, unregister_file_opener_as_importer,
      register_file_saver, register_file_saver_as_default,
      unregister_file_saver, get_default_file_saver,
      get_file_opener_by_id, get_file_saver_by_id,
      get_file_savers, get_file_openers, get_file_importers.
      * src/file-priv.h: New file with definitions of structs:
      _GnumFileOpener, _GnumFileOpenerClass, _GnumFileSaver,
      * src/workbook.h
      (struct _Workbook): Added file_saver_sig_id field.
      (workbook_get_file_saver): New accessor function.
      * src/workbook.c
      (cb_saver_destroy_event, workbook_destroy, workbook_set_saveinfo):
      When setting new file_saver, connect to its "destroy" signal and
      set file_saver to NULL in signal handler. Disconnect when changing file
      saver or destroying the workbook.
      (workbook_get_file_saver): New accessor function.
      * src/workbook-view.[ch]
      (wb_view_set_attributev): Renamed to wb_view_set_attribute_list and
      (wb_view_save_as, wb_view_save, wb_view_open, wb_view_open_custom): New
      methods (some code moved from file.c).
      * src/gnumeric-sheet.c (gnumeric_sheet_filenames_dropped):
      Use wb_view_open() instead of workbook_try_read()+file_finish_load().
      * src/gui-file.c
      (gui_file_import): Use get_file_importers(). Use
      wb_view_open_custom() instead of file_opener_open() + manual creation
      of wb_view, error checking, etc.
      (is_saver_registered): Removed.
      (saver_activate): Don't check if saver is really registered.
      (file_saver_is_default_format): Use get_default_file_saver() instead
      of strcmp(extension, "gnumeric") hack.
      (do_save_as): Use gnum_file_saver_fix_file_name().
      Adjusted everything to file.h, workbook.h, workbook-control.h.
      * src/gui-file.h (gui_file_import): Signature change, now function
      returns gboolean.
      * src/gutils.[ch] (g_list_index_custom): New function.
      * src/history.c (file_history_cmd), src/main.c (gnumeric_main),
      src/workbook-control-gui.c (cb_file_open): Use wb_view_open()
      instead of workbook_read().
      * src/workbook-control-gui-priv.h (struct _WorkbookControlGUI):
      * src/plugin-service
      Created GnumPluginFileOpener and GnumPluginFileSaver classes (derived
      from GnumFileOpener and GnumFileSaver respectively). Moved contents of
      plugin_service_file_saver_save_func into
      gnum_plugin_file_opener_probe, gnum_plugin_file_opener_open,
      gnum_plugin_file_saver_save methods (slightly modified).
      (plugin_service_file_opener_read): Read "open" and "import" attributes
      of <service> tag.
      plugin_service_file_opener_cleanup): Register/unregister created
      file opener (GnumPluginFileOpener object) as normal opener and/or
      importer depending on "open" and "import" XML attributes.
      plugin_service_file_opener_cleanup): Register/unregister created
      file saver (GnumPluginFileSaver object).
      * src/plugin-service.h
      (struct _PluginServiceFileOpener):
      Added can_open and can_import fields.
      (struct _PluginServiceFileSaver):
      * src/plugin-loader-module.c
      (struct ServiceLoaderDataFileOpener, struct ServiceLoaderDataFileSaver),
      * src/stf.c
      (stf_read_workbook, stf_write_workbook): Signature change
      (don't return gboolean).
      (stf_init): Adjusted to file i/o interface changes.
      (gnumeric_xml_get_opener, xml_probe):
      (gnumeric_xml_read_workbook, gnumeric_xml_write_workbook): Signature
      change (don't return gboolean).
      (xml_init): Adjusted to file i/o interface changes.
  37. 29 Jan, 2001 1 commit
    • Almer S. Tigelaar's avatar
      Add flags for insert cols/rows and paste special. · 0acb7687
      Almer S. Tigelaar authored
      2001-01-29  Almer S. Tigelaar  <almer1@dds.nl>
      	* src/sheet.h: Add flags for insert cols/rows and paste special.
      	* src/selection.c
      	Remove the settings of insert cols/rows here.
      	Set insert cols/rows menu items and flags correctly.
      	(sheet_selection_reset_only): Reset insert cols/rows flags.
      	* src/application.c
      	(application_clipboard_clear): Set enable paste special flag.
      	(application_clipboard_copy): Ditto.
      	(application_clipboard_cut): Ditto.
      	* src/workbook-view.c, src/workbook-view.h
      	(wb_view_menus_update): New function, updates the
      	insert cols/rows and paste special menu items.
      	(wb_view_sheet_focus): Call menus_update here.
      	(wb_view_sheet_add): Ditto.
      	* src/workbook-control-gui.c
      	(workbook_control_gui_init): Update menu items here.