1. 05 Jul, 2000 1 commit
    • Morten Welinder's avatar
      const issues. · ff44e061
      Morten Welinder authored
      2000-07-05  Morten Welinder  <terra@diku.dk>
      
      	* src/clipboard.c (x_selection_to_cell_region): Copy data and zero
       	terminate it.
      
      	* src/stf-parse.c (stf_parse_fixed_line): Kill unneeded cast.
      	(stf_parse_convert_to_unix): Unconstify.  Don't bother keeping
       	track of len.  Handle form-feeds better.
      ff44e061
  2. 04 Jul, 2000 2 commits
  3. 30 Jun, 2000 1 commit
    • Jody Goldberg's avatar
      It is possible to have a guru up without editing. · 69d6d36b
      Jody Goldberg authored
      
      2000-06-30  Jody Goldberg <jgoldberg@home.com>
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_can_select_expr_range) : It is
      	  possible to have a guru up without editing.
      	(gnumeric_sheet_key_press) : rename from gnumeric_sheet_key.
      	(gnumeric_sheet_size_allocate) : rename from gnumeric_size_allocate.
      	(gnumeric_sheet_focus_in) : Enable the input context.
      	(gnumeric_sheet_focus_out) : Disable the input context.
      	(gnumeric_sheet_realize) : Create the input context.
      	(gnumeric_sheet_unrealize) : Destroy the input context.
      	(gnumeric_sheet_class_init) : Register the new methods.
      	(gnumeric_sheet_init) : Init the input context.
      
      	* src/clipboard.c (x_selection_handler) : Adjust to changes in
      	  application_clipboard_clear.
      	(x_selection_clear) : Ditto.
      	* src/cmd-edit.c (cmd_paste) : Ditto.
      	* src/sheet.c (sheet_destroy) : Ditto.
      
      	* src/application.c (application_clipboard_clear) : Make dropping the
      	  selection optional.  This removes the kludges necessary to handle
      	  changing the clipboard when we already have the selection.
      
      	* src/functions/fn-logical.c (gnumeric_true, gnumeric_false) :
      	  fix signatures.
      69d6d36b
  4. 28 Jun, 2000 1 commit
    • Jody Goldberg's avatar
      new function. · 93f11589
      Jody Goldberg authored
      
      2000-06-28  Jody Goldberg <jgoldberg@home.com>
      
      	* src/functions/fn-sheet.c (GNUMERIC_VERSION) : new function.
      
      	* src/workbook.c (workbook_do_destroy) : No need to release the
      	  clipboard here.  The Sheet does it for us.
      
      	* src/workbook-format-toolbar.c : Add Fill to the default money
      	  format.
      
      	* src/symbol.c : The only symbols are functions.  The global table
      	  should not be world visible.
      
      	* src/sheet.c (sheet_flag_status_update_cell) : Take a CellPos.
      	(sheet_get_extent_cb) : Use Cell::pos rather than adding an
      	  indirection.
      	(cb_set_cell_content) : Use StyleFormat.
      	(sheet_cell_set_value) : Call sheet_flag_status_update_cell.
      	(sheet_cell_set_value) : Ditto.
      	(sheet_destroy) : Prepare to clear out named expressions.
      	(colrow_move) : Handle changes in cell_relocate signature.
      	(sheet_move_range) : Ditto.
      
      	* src/sheet-autofill.c : Use StyleFormats.
      
      	* src/position.c (parse_pos_init) : Global position are permitted.
      
      	* src/parser.y : Large change.  Do not automaticlly look for function
      	  names or named expressions in the lexer.  The lexer returns STRING
      	  and QUOTED_STRING.  The parser then does the appropriate lookups to
      	  potentially convert to something else.  This allows us to have sheet
      	  names that are the same as functions.
      
      	* src/parse-util.c (cellref_name) : Add flag to optionally disable the
      	  addition of the sheet name.  This is useful when printing
      	  Sheet2!A1:A3 rather than Sheet2!A1:Sheet2!A3.
      
      	* src/number-match.c (format_create_regexp) : Handle fill formats.
      
      	* src/mstyle.c (mstyle_get_border) : Fix constness.
      
      	* src/mathfunc.c (combin, fact) : Moved these here from
      	  functions/fn-math.c
      
      	* src/main.c (gnumeric_main) : No more constants_init, or
      	  global_symbol_init.
      
      	* src/func.c () : Reorg.  Remove some dead code.  Begin adding
      	  workbook local function support, Begin adding volatile, and
      	  semi-volatile functions.  Move the use of SymbolTable internal
      	  in preparation for eliminating it.
      
      	* src/format.c (format_number) : Improve support for pound, yen, and euro.
      	  Remember to produce a number when we hit spacing.
      
      	* src/expr.c : Have ExprFunc refer directly to the FunctionDefinition
      	  We still use a SymbolTable internally, but that will be merged out
      	  later.
      
      	* src/expr-name.c : Major reorg.  Not complete.
      
      	* src/corba-sheet.c (fill_corba_value) : Adjust to changes in
      	  cellref_name signature.
      
      	* src/commands.c (cmd_set_date_time_undo) : No need to manually call
      	  update_cell_flag.  cell_remove, and cell_set_text do that for us.
      	(cmd_set_date_time_redo) : Ditto.
      	  Use StyleFormat.
      
      	* src/clipboard.c (paste_cell) : Take the ExprRewriteInfo as an
      	  argument.
      	(clipboard_paste_region) : Init the ExprRewriteInfo.  We need to do
      	  this here rather than in cell_relocate because we may be moving a
      	  region, not just a single cell, and references within the region
      	  should not be changed.
      
      	* src/cell.c (cell_relocate) : Take the relocation info as an
      	  argument.  Non NULL indicates a request to check bounds.  We can not
      	  do this at the cell level. becuase we may be moving a block rather
      	  than just a single cell, and references into the block should NOT be
      	  rewritten.
      	(cell_set_text_and_value) : Take a StyleFormat.
      	(cell_assign_value) : Ditto.
      	(cell_set_value) : Ditto.
      	(cell_set_expr_internal) : Ditto.
      	(cell_set_expr_unsafe) : Ditto.
      	(cell_set_expr) : Ditto.
      
      	* src/auto-format.c (do_af_suggest) : Expression now refers directly
      	  to functionDef.
      93f11589
  5. 05 Jun, 2000 1 commit
    • Jody Goldberg's avatar
      renamed from sheet_cell_formula_{link,unlink}. · 7f94ba9e
      Jody Goldberg authored
      
      2000-06-05  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_cell_expr_{link,unlink}) : renamed from
      	  sheet_cell_formula_{link,unlink}.
      
      	* src/cell.c (cell_relocate) : Doh! use the offset flags now that they
      	  are being passed.
      
      	* src/clipboard.c (paste_cell) : Renamed from paste_cell_flags.
      
      	* src/expr.c (compare) : value_is_empty_cell -> VALUE_IS_EMPTY.
      
      	* src/value.c (VALUE_IS_EMPTY) : rename from value_is_empty_cell.
      
      	* src/sheet-private.h : Add resize_scrollbar.
      
      	* src/sheet.c (sheet_{col,row}_add) : Use resize_scrollbar flag rather
      	  than manually updating the scrolling bar.
      	(sheet_update) : Handle resize_scrollbar.
      	(sheet_cell_expr_link) : renamed from sheet_cell_formula_link.
      	(sheet_cell_expr_unlink) : renamed from sheet_cell_formula_unlink.
      7f94ba9e
  6. 04 Jun, 2000 1 commit
    • Jody Goldberg's avatar
      Set the CELL_IN_SHEET_LIST flag. (sheet_cell_remove_from_hash) : Clear the · c6a63d53
      Jody Goldberg authored
      
      2000-06-04  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_cell_add_to_hash) : Set the CELL_IN_SHEET_LIST
      	  flag.
      	(sheet_cell_remove_from_hash) : Clear the CELL_IN_SHEET_LIST flag.
      	(cb_remove_allcells) : Ditto.
      	(sheet_cell_formula_link) : Set the CELL_IN_EXPR_LIST flag.
      	(sheet_cell_formula_unlink) : Clear the CELL_IN_EXPR_LIST flag.
      	(sheet_formulas_unlink) : Ditto.
      
      	* src/clipboard.c (paste_cell_flags) : Take some additional arguments
      	  so that pasted cells can potentially have their references made
      	  invariant, this is for sorting.
      	(clipboard_paste_region) : Pass the additional offsets when
      	  PASTE_EXPR_RELOCATE is specified.
      	(append_cell_closure_t) : Delete this type.  Move the origin cell info
      	  into CellRegion.
      
      	* src/cell.c (cell_copy) : Clear the sheet and associated flags for
      	  the copied cell.  This avoids accidentally realizing comments that
      	  become undeletable.
      	(cell_relocate) : Remove the unlink flag now that we have the
      	  additional cell_flags.
      c6a63d53
  7. 28 May, 2000 1 commit
    • Jody Goldberg's avatar
      Handle undo correctly when an attempt to paste fails. · 92922018
      Jody Goldberg authored
      2000-05-28  Jody Goldberg <jgoldberg@home.com>
      
      	* src/commands.c (cmd_paste_copy_undo) : handle paste errors.
      	(cmd_paste_copy_destroy) : do not release unless we are permitted to.
      
      	* src/clipboard.c (clipboard_paste_region) : Return a boolean
      	  indicating success or failure.
      
      2000-05-27  Jody Goldberg <jgoldberg@home.com>
      
      	* src/clipboard.c (clipboard_paste_region) : Off by one error.
      92922018
  8. 27 May, 2000 6 commits
    • Jody Goldberg's avatar
      Mark the sheet as dirt, and do a recalc. · f09360db
      Jody Goldberg authored
      
      2000-05-27  Jody Goldberg <jgoldberg@home.com>
      
      	* src/commands.c (cmd_paste_copy_undo) : Mark the sheet as dirt, and
      	  do a recalc.
      
      	* src/clipboard.c (clipboard_paste_region) : flag the need to
      	  potentially update the status range.
      f09360db
    • Jody Goldberg's avatar
      Respan/rerender as necessary after pasting. · 364faabb
      Jody Goldberg authored
      
      2000-05-27  Jody Goldberg <jgoldberg@home.com>
      
      	* src/clipboard.c (clipboard_paste_region) : Respan/rerender as
      	  necessary after pasting.
      364faabb
    • Jody Goldberg's avatar
      Do not try to paste if the conversion was canceled. · af97e1db
      Jody Goldberg authored
      
      2000-05-27  Jody Goldberg <jgoldberg@home.com>
      
      	* src/clipboard.c (x_selection_received) : Do not try to paste if the
      	  conversion was canceled.
      af97e1db
    • Jody Goldberg's avatar
      Move the handling of singletons and the setting of the selection here. · 984592e7
      Jody Goldberg authored
      
      2000-05-27  Jody Goldberg <jgoldberg@home.com>
      
      	* src/commands.c (cmd_paste_copy) : Move the handling of singletons
      	  and the setting of the selection here.
      	* src/clipboard.c (clipboard_paste_region) : From here.
      
      	* src/cmd-edit.c (cmd_paste_to_selection) : Remove incorrect
      	  precondition.
      984592e7
    • Jody Goldberg's avatar
      Fix typo, and thinko. · 24ac7f92
      Jody Goldberg authored
      
      2000-05-26  Jody Goldberg <jgoldberg@home.com>
      
      	* src/clipboard.c (clipboard_paste_region) : Fix typo, and thinko.
      24ac7f92
    • Jody Goldberg's avatar
      Revamp pasting. This needs alot of testing. Some initial work on a · 94c47dab
      Jody Goldberg authored
      Revamp pasting.
      This needs alot of testing.
      Some initial work on a function druid.
      
      2000-05-26  Jody Goldberg <jgoldberg@home.com>
      
      	* src/selection.c (selection_is_simple) : Use a command context.
      	(sheet_selection_paste) : Delete.
      
      	* src/plugin.c : rename error_plugin_problem -> error_plugin.
      
      	* src/item-grid.c (context_paste_cmd) : Use cmd_paste_to_selection.
      	(context_paste_special_cmd) : Ditto.
      
      	* src/gnumeric-sheet.c : remove cached 'controlling_entry' in
      	  preparation for the function druid.
      
      	* src/corba-sheet.c : Delete Sheet_selection_paste.
      	  this will need to be replaced with a new signature.
      
      	* src/item-cursor.c (item_cursor_do_action) : Use new cmd_paste.
      
      	* src/commands.c (cmd_area_set_text_{undo,redo}) : Use new
      	  clipboard_paste_region.
      	(cmd_ins_del_row_col_{undo,redo}) : Ditto.
      	(cmd_clear_{undo,redo}) : Ditto.
      	(cmd_set_date_time_{undo,redo}) : Ditto.
      	(cmd_paste_cut_*) : new functions.
      
      	* src/command-context*.c : Add progress, remove splits_array.
      
      	* src/cmd-edit.c (cmd_paste) : New function.
      	(cmd_paste_to_selection) : New function.
      
      	* src/clipboard.c : Reorganize/rewrite.
      	(clipboard_paste_region) : paste content.
      	(clipboard_paste) : paste content from clipboard or X selection.
      	(paste_target_init) : New function.
      	(sheet_paste_selection) : merge into clipboard_paste_region.
      
      	* src/application.c (application_clipboard_copy) : rename
      	  clipboard_copy_cell_range -> clipboard_copy_range.
      
      	* idl/Gnumeric.idl : Merge InvalidValue, SplitsArray -> InvalidCmd.
      
      	* src/workbook.c (workbook_setup_status_area) : Include a progress bar.
      94c47dab
  9. 21 May, 2000 1 commit
    • Jody Goldberg's avatar
      A few delayed patches. · 2779b474
      Jody Goldberg authored
      These optimize paste, exit, sheet deletetion,
      and start the process for fixing a few things.
      
      2000-05-17  Jody Goldberg <jgoldberg@home.com>
      
      	* src/clipboard.c (clipboard_copy_cell_range) : Adjust signature to
      	  take a range.
      	(sheet_paste_selection) : Export in preparation for adding undo.
      
      	* src/commands.c (cmd_paste_copy) : Some initial work.  Not used or
      	  complete.
      
      	* src/parse-util.c (parse_text_value_or_expr) : Start passing in the
      	  current format so that we can eventually attempt to match it before
      	  trying all the others.
      
      	* src/sheet.c (sheet_formulas_unlink) : New function.
      	(sheet_destroy_contents) : Optimize.
      
      	* src/dialogs/dialog-plugin-manager.c : Make a bit prettier.
      	* src/dialogs/plugin-manager.glade : Ditto.
      
      2000-05-16  Jody Goldberg <jgoldberg@home.com>
      
      	* plugins/*/*.c : Rationalize the naming scheme.
      
      2000-05-15  Jody Goldberg <jgoldberg@home.com>
      
      	* src/eval.[ch] : Rename
      	  cell_queue_recalc      -> eval_queue_cell
      	  cell_queue_recalc_list -> eval_queue_list
      	  cell_unqueue_recalc    -> eval_unqueue_cell
      	(eval_unqueue_sheet) : New function.
      
      	* src/sheet.c (sheet_cell_remove_simple) : Add precautionary removal
      	  of cells from recalc list.  We should not need this in most
      	  instances, but the check is inexpensive so I'll play it safe.
      	(sheet_destroy_contents) : Batch cleanups rather than doing it cell by
      	  cell.
      
      	* src/cell.c (cell_make_value) : Fill in the implementation.
      
      	* src/clipboard.c (paste_cell_flags) : Remove some dead code.
      	  Merged in paste_cell and fixed handling of paste by value.
      
      2000-05-14  Jody Goldberg <jgoldberg@home.com>
      
      	* src/clipboard.c (paste_cell) : No need to call cell_content_changed
      	  we can queue the recalc for the entire region later.  It is
      	  sufficent to make the cell as changed with sheet_cell_changed.
      	(paste_cell) : It is premature to redraw, we have no yet calculated
      	  spans.  Redraw and respan at the range level, not the cell.
      2779b474
  10. 17 May, 2000 1 commit
    • Jody Goldberg's avatar
      Fix bugs 10705 10775 11159 Morten's autofill UMR Han's crash on sheet · efd376c0
      Jody Goldberg authored
      Fix bugs
          10705
          10775
          11159
          Morten's autofill UMR
          Han's crash on sheet deletion.
      
      2000-05-17  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_get_extent) : Disable the use of
      	  sheet_style_get_extent until it is more intelligent.
      
      	* configure.in : Produce a Using OAF message in the non-bonobo case
      	  too.  Limit xml to version 1.x for now.
      
      	* src/cell.c (cell_set_text_and_value) : Set the entered_text BEFORE
      	  the value so that cells with format = text render correctly.
      efd376c0
  11. 03 May, 2000 1 commit
    • Jody Goldberg's avatar
      Begin to rationalize support for inverted and 3D references. · de62dd3a
      Jody Goldberg authored
      More renaming and movement name rationalization.
      Some minor improvements in the function wizard.
      
      2000-05-03  Jody Goldberg <jgoldberg@home.com>
      
      	* EvalPosition -> EvalPos
      	  ParsePosition -> ParsePos
      	  new struct RangeRef used in ValueRange
      
      	  eval_pos_init* -> position.[ch]
      	  parse_pos_init*
      	  cell_ref_{get,make}*
      
      	* src/workbook.c : Reorder the toolbar a bit.
      	(workbook_foreach_cell_in_range) : New function.
      	(cb_autofunction) : New routine.
      	(workbook_set_auto_expr) : DO NOT put real code into pre/post
      	  conditions.  It will be removed when debugging is eventually
      	  disabled.
      
      	* src/position.c (range_ref_normalize) : New function.
      
      	* src/ranges.c (range_normalize) : New function.
      
      	* src/expr.c (expr_implicit_intersection) : Use range_ref_normalize.
      
      	* src/eval.c (cell_eval_content) : No need to release the value.
      	  cell_assign_value already does that.
      	(dependency_range_ctor) : Use range_normalize.
      
      	* src/auto-format.c (do_af_suggest) : Use workbook_foreach_cell_in_range.
      
      	* src/cell.c (cell_set_expr_and_value) : link the new expression but
      	  do not queue it for recalc.
      	(cell_assign_value) : Release the old value.
      	(cell_copy) : Init the value to empty.
      
      	* src/func.c (function_iterate_do_value) : Use
      	  workbook_foreach_cell_in_range.
      
      	* src/dialogs/dialog-function-wizard.c (create_description) : Use
      	  a label rather than a text entry widget.  It looks better.
      
      	* src/functions/fn-string.c (gnumeric_expression) : range is already
      	  absolute.
      
      	* src/functions/fn-stat.c (gnumeric_linest) : Handle inverted ranges.
      	(gnumeric_logest) : Ditto.
      
      	* src/functions/fn-information.c (gnumeric_countblank) : Use
      	workbook_foreach_cell_in_range.
      	(gnumeric_{row,column}) : Handle inversions.
      
      	* src/functions/fn-lookup.c (gnumeric_offset) : No need to make
      	  absolute.  The marshaller already did that.
      
      2000-05-02  Jody Goldberg <jgoldberg@home.com>
      
      	* src/eval.c (dependency_range_ctor) : normalize the range.
      
      	* src/xml-io.c (xml_write_cell_and_position) : Suppress warning.
      
      	* src/pixmaps.h : Add function wizard and equal sign.
      de62dd3a
  12. 20 Apr, 2000 1 commit
    • Jody Goldberg's avatar
      Reorg cell contents and assignment. · bedb925b
      Jody Goldberg authored
      Fixs lots of usability details.
      
      2000-04-20  Jody Goldberg <jgoldberg@home.com>
      
      	* src/dialogs/dialog-cell-format.c : Use the edit_pos as the example
      	  not the top left corner.
      
      	* src/functions/fn-stat.c (gnumeric_ftest) : Use eval_pos_cellref
      	  to help localize the strangeness.
      	(gnumeric_ttest) : Ditto.
      
      	* src/xml-io.c (xml_write_cell_and_position) : If this is an array
      	  expression and we are the top left then add attributes to indicate
      	  size of array.  Ignore the rest of the array.
      	(xml_not_used_old_array_spec) : New routinr to handle the old array format.
      	(xml_cell_set_array_expr) : store an array.
      	(xml_read_cell) : Handle the old and the new array formats.
      
      	* src/workbook.c (workbook_close_if_user_permits) : Accept input
      	  first.
      	(wb_edit_key_pressed) : Handle array formulas here.
      	(workbook_detach_sheet) : Do not recalc all if we are exiting.
      	(workbook_start_editing_at_cursor) : When we start editing an
      	  array formula display just the formula not all the extra {}()[][] crap.
      
      	* src/sheet.c (SheetPrivate) : Add a recompute_spans flag.
      	(sheet_calc_spans) : New routine.
      	(sheet_cell_calc_span) : New routine.
      	(sheet_range_calc_spans) : Renamed and extended from
      	  sheet_cells_update.
      	(sheet_update) : Use sheet_calc_spans when necessary.
      	  Update the location region when the edit_pos changes.
      	(cb_recalc_spans_in_col) : Renamed from cb_collect_cells_in_col.
      	  Recalcs spans directly, no need to collect first.
      	(cb_set_cell_content) : New routine to set expr, or expr_and_value.
      	(sheet_range_set_text) : Use cb_set_cell_content, and remember
      	  chosen format with the cell rather than overriding the assigned
      	  format.
      	(sheet_cell_set_text) : Renamed from sheet_set_text.  Be more specific
      	  about how spans, rendering and the rest are handled.
      	(sheet_cell_set_expr) : New routine.
      	(sheet_cell_set_value) : Ditto.
      	(sheet_load_cell_val) : When displaying an array formula add {%s}()[][].
      	(sheet_redraw_cell_region) : Honour spans when redrawing.
      	(sheet_redraw_partial_row) : New routine.
      	(sheet_redraw_cell) : Ditto.
      	(sheet_is_cell_array) : Use cell_is_array.
      	(sheet_range_splits_array) : Renamed from sheet_check_for_partial_array.
      	(sheet_cell_add_to_hash) :  Do not touch spans at this point.
      	(sheet_cell_insert) : Rename from sheet_cell_add made recalc span
      	  optional.
      	(sheet_cell_new) : New routine that does not touch spans.
      	(sheet_cell_remove) : Made redraw optional.
      	(cb_clear_cell_comments) : Remove the cell if there is no comment.
      	(sheet_clear_region) : Remove the cell if there are no comments or
      	  contents.  Flag an update of the status region.
      
      	* src/sheet-view.c (cb_colrow_resize) : New function.
      	(sheet_view_col_size_changed) : Resize all rows, irrespective of
      	(sheet_view_row_size_changed) : existing cells.
      	(sheet_view_redraw_cell_region) : This no longer honours spans.
      
      	* src/sheet-style.c (sheet_style_attach) : Removed call to redraw.
      	sheet_cells_update : rename to sheet_range_calc_spans and move to
      	  sheet.c.
      
      	* src/sheet-autofill.c (autofill_cell) : Use sheet_cell_set_value
      	  rather than set_text.
      
      	* src/selection.c (sheet_selection_changed_hook) : Delete.
      	(sheet_selection_extend_to) : Update the status region to display the
      	  new size.
      	(sheet_selection_cut) : Use sheet_range_splits_array.
      	(selection_check_for_array) : New routine.
      
      	* src/parser.y : Remove icky array formula parsing that conflicted
      	  with array entries.
      
      	* src/number-match.c (format_match) : Return a Value * rather than a
      	  double.
      
      	* src/mstyle.c (mstyle_set_font_size) : Do not allow font sizes < 1.
      
      	* src/main.c (gnumeric_main) : Do NOT create an empty workbook
      	  then delete it if things are successfully loaded.  This causes
      	  a global recalc.  Instead add a flag to disable exit when the
      	  number of workbooks go to zero.  Then only enable the flag AFTER
      	  we have attempted to load the initial workbooks.
      
      	* src/item-grid.c (item_grid_event) : Update the status_region when
      	  button-1 is release.  It should display the edit_pos.
      
      	* src/gutils.c : Move cell_name, col_name, col_from_name,
      	  parse_cell_name, parse_cell_name_or_range and parse_cell_name_list,
      	  to parse-util.c.
      
      	* src/gnumeric.h  : Add RenderedValue.
      
      	* src/gnumeric-util.c (gnumeric_char_start_expr_p) : Move
      	  to parse-util.c
      
      	* src/file.c (workbook_read) : Remove freese thaw usage.
      	  Move call to update AFTER mark clean.
      
      	* src/expr.c (eval_pos_init) : Take a cellpos.
      	(parse_pos_evalpos) : New routine.
      	(eval_pos_cellref) : There is some questionable code scattered in the
      	  functions.  This routing localizes the odd bits for correction.
      
      	* src/eval.c (cell_eval_content) : Use sheet_redraw_cell,
      	  and rendered_value_calc_size.
      	(cell_get_dependencies) : Improve constness.
      
      	* src/corba-sheet.c : Remove the freeze thaw operations.
      	(Sheet_cell_set_formula) : Deleted.
      	(Sheet_range_set_formula) : Delete.
      
      	* src/commands.c : Adjust so that registration of command auto
      	  calls redo.  Add misc checks for splitting arrays.
      
      	* src/clipboard.h : Move the CellCopy types here from cell.h
      
      	* src/clipboard.c (paste_cell) : Use cell_has_expr.
      	  Don't insert the new cell till after its contents are assigned.
      
      	* src/cellspan.c (cell_register_span) : Improve constness.
      	(cell_unregister_span) : Ditto.
      	(row_cell_get_displayed_at) : Delete.
      	(cell_calc_span) : Moved here from cell.c
      
      	* src/dialogs/dialog-stf.glade : Adjust the header background colour
      	  to match the purdy new icon.  Add the icon.
      
      	* src/cell-draw.c : Use the rendered_value routines.
      	  Improve constness.
      
      	* src/analysis-tools.c (set_cell) : Use sheet_cell_fetch.
      
      	*.*
      	    cell_set_* -> sheet_cell_set_
      	    cell_set_*_simple -> cell_set_
      	    Cell::{row,col} -> Cell::{row,col}_info
      	    cell_get_text -> cell_get_entered_text
      	    cell_get_content -> cell_get_entered_text
      	    cell_name -> cell_coord_name
      	    cell_get_formatted_val -> cell_get_rendered_text
      	    cell_get_content -> cell_get_entered_text
      
      	* src/cell.c :
      	(cell_dirty) : Renamed from cell_modified.  Use
      	  sheet_set_dirty.
      	(cell_formula_changed) : Make the queuing of the recalc optional.
      	(cell_cleanout) : Handle union of expression and entered_text,
      	  and remove the rendered value.
      	(cell_copy) : Ditto.
      	(cell_destroy) : handle cell_modified -> cell_dirty.
      	(cell_set_text) : Use parse_text_value_or_expr and store the prefered
      	  format.
      	(cell_set_text_and_value) : New routine.
      	(cell_assign_value) : New routine.
      	(cell_set_value) : Support formats.
      	(cell_set_expr_and_value) : New routine.
      	(cell_set_expr_internal) : Split from cell_set_expr.
      	(cell_set_expr) : Divide to allow for not queuing a recalc.
      	(cell_set_array_formula) : Use cell_set_expr_internal.
      	(cell_is_array) : New utility.
      	(cell_is_partial_array) : New utility.
      	(cell_has_expr) : New utility.
      	(cell_render_value) : Use rendered_value_*.
      	Move all comment routines into cell-comment.[ch].
      
      	* idl/Gnumeric.idl : Remove cell_set_formula, and range_set_formula.
      	  These were identical to set_text.  Made Workbook embeddable.
      bedb925b
  13. 06 Apr, 2000 1 commit
    • Jody Goldberg's avatar
      Cache the Sheet* before freeing the closure. · a84d5411
      Jody Goldberg authored
      
      2000-04-05  Jody Goldberg <jgoldberg@home.com>
      
      	* src/clipboard.c (x_selection_received) : Cache the Sheet* before
      	  freeing the closure.
      
      	* src/workbook-format-toolbar.c (workbook_feedback_set) : Disable
      	  callbacks when setting the font status.  This avoids applying a
      	  spurious format.
      a84d5411
  14. 05 Apr, 2000 1 commit
    • Jody Goldberg's avatar
      Continue slow progress towards correctly updating the status region. · ac07ca90
      Jody Goldberg authored
      2000-04-05  Jody Goldberg <jgoldberg@home.com>
      
      	* src/commands.c (cmd_paste_cut_undo) : Use sheet_update and force a
      	  status update.
      	(cmd_paste_cut_redo) : Ditto. Change the selection here.
      
      	* src/sheet.c (sheet_flag_status_update_range) : Handle NULL ranges.
      
      	* src/selection.c (sheet_selection_add_range) : Use
      	  sheet_flag_status_update_range rather than an immediate call
      	  to selection_changed_hook (that is deprecated).
      	(sheet_selection_move) : Delete.
      	(sheet_selection_paste) : Use sheet_update.
      
      	* src/clipboard.c (clipboard_paste_region) : Remove unnecessary and
      	  incorrect code to do status updates.  The selection mechanism
      	  handles it already.
      	(x_selection_received) : Use sheet_update.
      
      	* src/about.c (dialog_about) : Add Almer.
      ac07ca90
  15. 04 Apr, 2000 1 commit
    • Jody Goldberg's avatar
      Improve status update. · 56a9e1f0
      Jody Goldberg authored
      Simplify a few command paths in preparation for registration.
      Hopefully fix bug 3961
      
      2000-04-04  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook.c (workbook_class_init) : Remove CELL_CHANGED.
      	(workbook_finish_editing) : At LAST! cmd_set_text is responsible for
      	  setting the text directly :-)
      
      	* src/workbook-format-toolbar.c (change_font_size_in_selection_cmd) :
      	  cmd_format takes care of the height adjustments.
      	* src/dialogs/dialog-cell-format.c (cb_fmt_dialog_dialog_apply) : Ditto.
      
      	* src/sheet.c (Sheet): Add flags edit_pos_changed, selection_content_changed.
      	(sheet_new) : init them.
      	(sheet_flag_status_update_cell) : New function that sets the flags.
      	(sheet_flag_status_update_range) : Ditto.
      	(sheet_update) : Fix typo. Add support for new flags.
      	(sheet_update_auto_expr) : Const correctness.
      	(sheet_update_controls) : Ditto.
      	(sheet_load_cell_val) : Ditto. Delete unused signal.
      	(sheet_set_text) : Use sheet_flag_status_update_range.
      	(sheet_set_edit_pos) : New routine.
      	(sheet_cursor_move) : Delete.
      	(sheet_fill_selection_with) : Remove.
      
      	* src/selection.c (sheet_selection_changed_hook) : const correctness.
      	(sheet_selection_change) : merge into sheet_selection_set.
      	(sheet_selection_extend_to) : Use sheet_selection_set.
      	(sheet_selection_set) : Merge with sheet_selection_change and use the
      	  sheet_cursor accessors rather than changing things directly.
      	(sheet_selection_walk_step) : Use sheet_selection_set, and sheet_set_edit_pos.
      
      	(sheet_is_all_selected) : const correctness.
      	(sheet_is_cell_selected) : New routine.
      	(sheet_is_range_selected) : New routine.
      
      	* src/item-grid.c (item_grid_draw_background) : Adjust to rename of
      	* sheet_selection_is_cell_selected -> sheet_is_cell_selected.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) : Cleanup the
      	  logic for creating fills and arrays so that it can have undo
      	  support.
      	  - Change the heuristic for selecting what type of characters can start
      	    an edit session.  Rather than using fixed Latin1 centric codes,
      	    guess that the 'length' field of the event is >0 if the character is
      	    printable.  Be more careful NOT to forward characters to the entry
      	    if we are not editing.
      	  - Use sheet_update.
      
      	* src/commands.c (command_pop_list_top) : Delete.
      	(cmd_format_redo) : Apply the height adjustment here.
      	(cmd_set_area_*) : Implement.
      	(*) : Use sheet_update.
      
      	* src/colrow.c (rows_height_update) : Moved here and generalized from
      	  sheet_selection_height_update.
      
      	* src/clipboard.c (sheet_paste_selection) : No need to call
      	  sheet_cursor_set.  sheet_selection_add_range already does that.
      	(clipboard_paste_region) : Flag updates to the status display if
      	  something changes.
      56a9e1f0
  16. 25 Mar, 2000 1 commit
    • Almer. S. Tigelaar's avatar
      Added a stf_dialog prefix to all functions and changed dialog_stf into · 6bee1a9d
      Almer. S. Tigelaar authored
      2000-03-25 Almer. S. Tigelaar.  <almer1@dds.nl>
      
      	* src/dialogs/dialog-stf.h, src/dialogs/dialog-stf.c : Added a
      	stf_dialog prefix to all functions and changed dialog_stf into
      	stf_dialog, this makes more sense as the same naming convention
      	was used in src/stf-parse.[ch] and src/dialogs/dialog-stf-preview.[ch]
      
      	* src/dialogs/dialog-stf-main-page.c : idem
      	* src/dialogs/dialog-stf-csv-page.c : idem
      	* src/dialogs/dialog-stf-fixed-page.c : idem
      	* src/dialogs/dialog-stf-format-page.c : idem
      	* src/dialogs/dialog-stf-preview.c : idem
      
      	* src/stf.c : Uses the renamed functions
      	* src/clipboard.c : idem
      6bee1a9d
  17. 17 Mar, 2000 1 commit
    • Miguel de Icaza's avatar
      Change NULL to CORBA_OBJECT_NIL · 684c9df2
      Miguel de Icaza authored
      
      
      2000-03-13  Miguel de Icaza  <miguel@helixcode.com>
      
      	* src/sheet-vector.c (sheet_vectors_cell_changed): Change NULL to
      	CORBA_OBJECT_NIL
      
      	* src/sheet-object-bonobo.c (sheet_object_bonobo_load_from_file):
      	Use the new IDL:Bonobo interface name, not the IDL:GNOME one
      	(sheet_object_bonobo_load_from_file): ditto.
      	(sheet_object_bonobo_load): ditto.
      
      	* src/sheet-object.c (sheet_set_mode_type): Temporary hack to get
      	the graphics working under 1:20 hours when my battery runs out of
      	power.
      
      	* src/sheet-object-container.c
      	(sheet_object_container_new_from_goadid): Renamed from
      	sheet_object_container_new
      
      	(sheet_object_container_new): Now takes a BonoboObjectClient as an
      	argument.
      
      2000-03-12  Miguel de Icaza  <miguel@helixcode.com>
      
      	* src/sheet-vector.c (impl_vector_get_numbers): Increment idx
      	here;
      	(impl_vector_get_vec_values): ditto.
      	(impl_vector_get_numbers): Use the proper values for the columns
      	row.
      	(impl_vector_get_vec_values): ditto.
      
      	* src/clipboard.c (x_clipboard_bind_workbook): Fix memory leak.
      	The problem is worse, because the warning comment there was
      	completely bogus.
      
      2000-03-12  Miguel de Icaza  <miguel@helixcode.com>
      
      	* graphic-type.c (graphic_type_show_page): On page switch, set the
      	graphics type to the first one in there.
      
      	* graphic-context.c (data_range_new): Assing this guy.
      684c9df2
  18. 07 Mar, 2000 1 commit
    • Almer. S. Tigelaar's avatar
      Gnumeric instances can now eXchange data in a gnumeric XML clipboard · be3852ca
      Almer. S. Tigelaar authored
      2000-03-07  Almer. S. Tigelaar.  <almer1@dds.nl>
      
      	Gnumeric instances can now eXchange data in a gnumeric
      	XML clipboard format. This way style information and such
      	can be preserved when copying/cutting from one instance
      	to another.
      
      	* src/xml-io.c, src/xml-io.h :
      	Added some functions for the gnumeric clipboard xml format.
      	(gnumeric_xml_read_selection_clipboard) :
      	For reading xml data from the clipboard
      	(gnumeric_xml_write_selection_clipboard) :
      	For writing xml data to the clipboard
      	(xml_read_selection_clipboard) :
      	For reading xml data from the clipboard, does the dirty work
      	(xml_write_selection_clipboard) :
      	For writing xml data to the clipboard, does the dirty work
      	(xml_read_cell_copy) :
      	Similar to xml_read_cell, but returns a CellCopy* instead
      	of a Cell*
      	(xml_write_cell_and_position) :
      	Similar to old xml_write_cell but allows you to set the col and
      	row manually
      	(xml_write_cell) :
      	Calls upon xml_write_cell_and_position, but takes the col and row
      	from the ColRowInfo members of type Cell.
      	(xml_read_style_region_ex) :
      	Read the xml data and returns an mstyle and a range. Does
      	_NOT_ attach this to a sheet.
      	(xml_read_style_region) :
      	calls upon xml_read_style_region_ex and attaches the mstyle
      	to a sheet
      
      	* src/cell.h
      	New cellcopy type added CELL_COPY_TYPE_AND_COMMENT, if a
      	cellcopy is of this type the comments will be put in
      	cellcopy.comment
      
      	* src/clipboard.c
      	(paste_cell_flags) :
      	added support for the new CELL_COPY_TYPE_TEXT_AND_COMMENT copy type
      	(x_selection_received) :
      	Modified so it support the TARGETS and GNUMERIC XML atoms and renders
      	the gnumeric clipboard xml format
      	(x_selection_handler) :
      	Now it can render theselection to ASCII text and gnumeric clipboard xml
      	format.
      	(x_clipboard_bind_workbook) :
      	Registers the new GNUMERIC XML atom that enables other instances of
      	gnumeric to see that we are also gnumeric and can render the clipboard
      	data in a the special gnumeric xml clipboard format
      	(clipboard_release) :
      	Handles new CELL_COPY_TYPE_TEXT_AND_COMMENT type
      be3852ca
  19. 02 Mar, 2000 1 commit
    • Almer. S. Tigelaar's avatar
      src/dialogs/dialog-stf-format-page.c src/dialogs/dialog-stf-preview.c · 41fcdb90
      Almer. S. Tigelaar authored
      2000-03-02  Almer. S. Tigelaar.  <almer1@dds.nl>
      
      	* src/dialogs/dialog-stf-format-page.c
      	* src/dialogs/dialog-stf-preview.c
      	* src/dialogs/dialog-stf-preview.h
      	* src/dialogs/dialog-stf.c
      	Modified, the format page now really display formatted
      	cells in the preview.
      	NOTE : A downside of this is that the cache is no longer shared
      	between fixed/csv pages and format pages.
      
      	* src/dialogs/dialog-stf.c
      	(dialog_stf_editables_enter) :
      	Disabled "enter activates default button" for the TextIndicator
      	field on the csv page. This would case the page to cycle, which
      	is ok, but it also caused the dropdown option to pop-up on the
      	next page, which is not ok.
      
      2000-03-02  Jon K Hellan  <hellan@acm.org>
      
      	* src/dialogs/dialog-stf.c (dialog_stf_druid_page_cancel): In
      	Yes/No dialog - set initial keyboard focus to "No". It went
      	nowhere.
      	(dialog_stf_set_initial_keyboard_focus): New function: Set
      	keyboard focus to the an appropriate widget on the page.
      	(dialog_stf_druid_page_next, dialog_stf_druid_page_previous): Set
      	initial keyboard focus.
      	(dialog_stf_druid_page_next): Make "Finish" button default on the the
      	final page. This doesn't change behaviour, but cues the user
      	visually.
      	(dialog_stf_druid_page_previous): Restore "Next" button as default
      	when coming from final page.
      	(dialog_stf_check_escape): New function: Watch keypresses, and
      	simulate "Cancel" when you see <Escape>.
      	(dialog_stf_attach_page_signals): Connect dialog_stf_check_escape
      	to handle <Escape>.
      	(dialog_stf_editables_enter): New function: Make <Ret> in text
      	fields activate default.
      	(dialog_stf): Use dialog_stf_editables_enter,
      	dialog_stf_set_initial_keyboard_focus. Make "next" button the
      	default button. Make window a child of the workbook window.
      
      	* src/dialogs/dialog-stf-format-page.c (format_page_init): Make
      	format list titles passive.
      
      	* src/dialogs/dialog-stf-fixed-page.c (fixed_page_init): Make
      	column list titles passive.
      
      	* src/clipboard.c (x_selection_to_cell_region): Add command
      	context to interface. Use it when calling dialog_stf.
      	(x_selection_to_cell_region):
      	(x_selection_received): Call x_selection_to_cell_region with
      	workbook_command_context_gui.
      41fcdb90
  20. 18 Feb, 2000 2 commits
    • Jody Goldberg's avatar
      - Merge some enhancements to the color combo boxes. · 771be446
      Jody Goldberg authored
      - Simplify and enhance the cursor and selection code.
        Its not as pretty as I'd like, but its getting better.
      - Fix a display glitch in the item-bar.  canvas redraw excludes
        the far coordinate.  That will teach me to read docs.
      
      2000-02-18  Jody Goldberg <jgoldberg@home.com>
      
      	* src/widgets/widget-color-combo.c (color_combo_construct) : typo.
      	(color_combo_new) : Disable the charting colours for now.  They are
      	  mostly duplicates.
      
      2000-02-16 Dom Lachowicz <dominicl@seas.upenn.edu>
      
      	* src/widgets/widget-color-combo.[ch]
      	Changed the code some to enable tooltips
      	Minor api changes
      
      2000-02-18  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook-view.c : Add history.h.
      
      2000-02-18  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_redraw_selection) : Delete.
      
      	* src/selection.c (sheet_selection_extend_to) : Short circuit when
      	  there would be no change to the selection.
      	(sheet_selection_change) : The sheet already has the correct edit,
      	  move, base positions.  Use them.
      
      	* src/sheet-view.c (sheet_view_redraw_headers) : gnome_canvas_request_redraw
      	  EXCLUDES the far coordinates.  Add 1 so that the last pixel get
      	  redrawn too.
      
      2000-02-18  Jody Goldberg <jgoldberg@home.com>
      
      	* src/history.c (history_menu_item_create) : typo.
      
      2000-02-18  Jody Goldberg <jgoldberg@home.com>
      
      	* src/dialogs/dialog-goal-seek.c (dialog_goal_seek) : Use edit_pos.
      	* src/dialogs/dialog-solver.c (dialog_solver) : Ditto.
      
      	* src/xml-io.c (xml_read_selection_info) : Use edit_pos.
      	(xml_write_selection_info) : Ditto.
      
      	* src/workbook.c (cb_sheet_check_dirty) : Use edit_pos.
      	(paste_cmd) : Ditto.
      	(paste_special_cmd) : Ditto.
      	(insert_current_date_cmd) : Ditto.
      	(insert_current_time_cmd) : Ditto.
      	(workbook_edit_comment) : Ditto.
      
      	* src/sheet.c (sheet_new) : sheet_selection_append -> sheet_selection_add.
      	(sheet_accept_pending_input) : Use edit_pos.
      	(sheet_load_cell_val) : Ditto.
      	(sheet_start_editing_at_cursor) : Ditto.
      	(sheet_update_controls) : Ditto.
      	(sheet_{col,row}_selection_type) : Fix cut-paste-o.
      	(walk_boundaries) : Move to selection.c.
      	(walk_boundaries_wrapped) : Ditto.
      	(sheet_selection_walk_step) : Reworked and moved to selection.c.
      	(sheet_cursor_move) : Switch to new framework.
      	(sheet_cursor_set) : Ditto.
      	(sheet_set_selection) : Delete.
      
      	* src/sheet.h : (SheetSlection) : Remove base member.
      	(Sheet) : adjsut notion of cursor to differentiate between,
      	edit, base, and movement.  (see comments).
      	* src/sheet-view.c (sheet_view_set_zoom_factor) : Use edit_pos.
      	(sheet_view_scrollbar_config) : Switch to new scheme.
      	(sheet_view_{col,row}_selection_changed) : Make the Top/Left visible
      	  cell the edit cursor when things are out of range.
      
      	* src/sheet-style.c (sheet_style_attach) : Use sheet_redraw_range directly.
      	(sheet_range_apply_style) : Ditto.
      	(sheet_range_set_border) : Ditto.
      
      	* src/selection.c (sheet_selection_add_range) : Renamed from,
      	  sheet_selection_append.  Document.  Switch to new edit, base, move
      	  scheme.  Directly call sheet_cursor_set rather than the confusingly
      	  named sheet_set_selection.
      	(sheet_selection_add) : Renamed from sheet_selection_append.
      	(sheet_selection_change) : Adjsut parm name from 'new' -> 'new_sel' to
      	  enable test compiles from C++.
      	(sheet_selection_extend_to) : Switch to new edit, base, move scheme.
      	(sheet_selection_extend) : Just call sheet_selection_extend_to for the
      	  main work.  Document.
      	(sheet_select_all) : sheet_selection_append_range -> sheet_selection_add_range.
      	(sheet_selection_extend_{horizontal, vertical} : Merge in to
      	  sheet_seletion_extend and fix.
      	(sheet_selection_set) : Switch to the new scheme.
      	(sheet_selection_reset) : sheet_selection_append -> sheet_selection_add.
      	  Use edit_pos.
      	(walk_boundaries) : Moved from sheet.c, merged with
      	  walk_boundaries_wrap, and change signature.
      	(sheet_selection_walk_step) : Moved from sheet.c and switched to the
      	  new method.  Do not change the selected region while iterating.
      
      	* src/item-grid.c (item_grid_paint_empty_cell) : Use edit_pos.
      	(item_grid_draw_cell) : Ditto.
      	(item_grid_event) : Ditto.
      	(context_paste_cmd) : Use the base and move cursors.
      	(context_paste_special_cmd) : Ditto.
      	(item_grid_button_1) : sheet_selection_append -> sheet_selection_add.
      
      	* src/item-cursor.c (item_cursor_autofill_event) : Use
      	  sheet_selection_add_range rather than the two step select extend.
      
      	* src/clipboard.c (sheet_paste_selection) : Use
      	  sheet_selection_add_range rather than the 2 step process
      	  of setting the corner and extending.
      
      	* plugins/excel/ms-excel-read.c (ms_excel_read_selection) :
      	    sheet_selection_append_range -> sheet_selection_add_range
      	* src/corba-sheet.c (Sheet_selection_append) : Ditto.
      	(Sheet_selection_append_range) : Ditto.
      
      	* src/gnumeric-sheet.c (move_cursor) : Ditto.
      	(gnumeric_sheet_key_mode_sheet) : Ditto.  Use edit_pos.
                sheet_selection_walk_step now handles the cursor and selection
      	  changes.
      	(gnumeric_sheet_set_selection) : Delete this was unnecessary.
      	(gnumeric_sheet_set_cursor_bounds) : Add preconditions.
      	(move_cursor_horizontal) : Use the edit_pos for movement.
      	(move_cursor_vertical) : Ditto.
      	(gnumeric_sheet_create_editing_cursor) : Ditto.
      	(start_cell_selection) : Ditto.
      	(move_horizontal_selection) : Use sheet_selection_extend.
      	(move_vertical_selection) : Ditto.
      	(gnumeric_sheet_compute_visible_ranges) : Force a redraw of the
      	  item-cursor when the visible region changes.  FIXME : This should be
      	  an update not a redraw.
      771be446
    • Miguel de Icaza's avatar
      Remove stf plugin from here. And from here. · 86a1dc8b
      Miguel de Icaza authored
      2000-02-18  Miguel de Icaza  <miguel@gnu.org>
      
      	* configure.in (EXTRA_GNOME_CFLAGS): Remove stf plugin from here.
      	* plugins/Makefile.am (SUBDIRS): And from here.
      
      	* src/stf.c (stf_open_and_read): Use malloc instead of g_malloc0
      	because g_malloc aborts execution if the buffer is too large
      	(which it might likely be).
      	(stf_read_workbook): Release using free, not g_free here.
      	(stf_read_workbook): Fix sheet object memory leak.
      	(stf_init): Kill old and unused code.
      86a1dc8b
  21. 11 Feb, 2000 1 commit
  22. 02 Feb, 2000 1 commit
    • Jody Goldberg's avatar
      Fix several memory problems (Thanks Morten) · 390f8af9
      Jody Goldberg authored
      2000-02-02  Jody Goldberg <jgoldberg@home.com>
      
      	* src/cell.c (cell_set_text) : Fix thinko.  We are assigning to the
      	  entered_text so we should unref that.  Always print the assigning
      	  empty warning.
      
      	* src/str.c (string_unref_ptr) : Delete unused function.
      
      	* src/clipboard.c (do_clipboard_paste_cell_region) : Use the correct
      	  clear flags for sheet_clear_region.
      	(x_selection_handler) : Ditto.
      
      	* src/workbook.c (workbook_expr_relocate) : We need to unref the new
      	  expression because the cell refs it itself.
      
      	* src/format.c (format_remove_decimal) : Correctly remove the last
      	  decimal. bug 5836.
      390f8af9
  23. 31 Jan, 2000 1 commit
    • Jody Goldberg's avatar
      Move more of the pure view elements into WorkbookPrivate. · a038ab94
      Jody Goldberg authored
      
      2000-01-31  Jody Goldberg <jgoldberg@home.com>
      
      	* src/worksheet.h : Move more of the pure view elements into
      	  WorkbookPrivate.
      
      	* src/sheet.h : Remove include of workbook.h
      
      	* *.c : manually include workbook.h only where we need it.
      
      	* src/ranges.c (parse_range) : Move here from dialog-analysis-tools.c
      	  to avoid warnings.
      
      	* src/corba-workbook.c (Workbook_save_to) : Adjust to new calling
      	  convention.
      	* src/corba-workbook-factory.c (WorkbookFactory_read) : Ditto.
      
      	* src/parser.y : Support interbook references.
      
      	* src/item-bar.c : Ignore scroll-wheel events. Eventually the app will
      	  handle these rather than the grid.
      a038ab94
  24. 25 Jan, 2000 1 commit
    • Jody Goldberg's avatar
      - Fix a problem with zooming caused by the new item-bar enhancements. - · 03198e1d
      Jody Goldberg authored
      
      - Fix a problem with zooming caused by the new item-bar enhancements.
      - Remove gnumeric-sheet.h from a number of places that it had no reason to be.
      - Move all of the row/col pos/offset cache into GnumericSheet.  WARNING
        I do not populate all of it yet.
      
      2000-01-26  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet-view.c (sheet_view_set_zoom_factor) : Keep the cursor in
      	  the same place and recompute the alignments for everything.
      
      	* src/item-cursor.c (item_cursor_set_bounds) : New function.
      
      	* src/gnumeric-sheet.h : Add more orthogonal structure for caching
      	  common row/col bounds and their canvas offsets.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_create) : Init the new members.
      	(gnumeric_sheet_filenames_dropped) : Keep the canvas private.
      	(gnumeric_sheet_make_cell_visible) : Add 'force_scroll' argument.
      
      	* src/clipboard.c (clipboard_release) : It is possible to have no
      	  styles associated with a region.
      
      	* src/item-grid.c : Remove overlapping cache of bounding rows/cols and
      	  offsets.  Use the superset in GnumericSheet.
      	 (item_grid_find_{row, col}) : Support sliding backwards.
      03198e1d
  25. 23 Jan, 2000 1 commit
    • Michael Meeks's avatar
      Stuff from Michael. · 7a8ae8e9
      Michael Meeks authored
      2000-01-23  Michael Meeks  <michael@edenproject.org>
      
      	* src/ranges.c (range_translate): fix glaring bugs + make
      	semantics saner.
      	(range_transpose): implement.
      
      	* src/clipboard.c (do_clipboard_paste_cell_region): s/cell.cell/cell.
      	(x_selection_to_cell_region): Null styles.
      	(clipboard_prepend_cell): kill mstyle inefficiency.
      	(clipboard_release): destroy styles.
      	(sheet_paste_selection): new style bits.
      
      	* src/render-ascii.c (cell_region_render_ascii): kill cell.cell
      
      	* src/cell.h (CellCopy): Kill MStyle member.
      
      	* src/ranges.c (range_init): implement helper.
      
      	* src/sheet-style.c (style_region_destroy): add precondition.
      	(sheet_get_styles_in_range, sheet_style_list_destroy): implement.
      7a8ae8e9
  26. 22 Jan, 2000 1 commit
  27. 15 Jan, 2000 3 commits
    • Jody Goldberg's avatar
      Work around for bug 5306. · 30b26e6c
      Jody Goldberg authored
      2000-01-18  Jody Goldberg <jgoldberg@home.com>
      
      	* src/clipboard.c (x_selection_to_cell_region) : Do not use ',' or ';' as seperators if
      	  the current locale uses them as decimal points.
      	(new_node) : Use g_strndup.
      30b26e6c
    • Jody Goldberg's avatar
      Bug 5305 · a06aa537
      Jody Goldberg authored
      2000-01-18  Jody Goldberg <jgoldberg@home.com>
      
      	* src/clipboard.c (x_selection_handler) : Add some preconditions to
      	  make code more robust.
      
      	* src/application.c (application_clipboard_clear) : Release ownership
      	  of the selection when the clipboard is cleared.
      a06aa537
    • Jody Goldberg's avatar
      Use cmd_clear_selection. · 3588e489
      Jody Goldberg authored
      
      2000-01-15  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook.c (clear_{all,formats,comments,content}_cmd) : Use
      	  cmd_clear_selection.
      
      	* src/sheet.c (sheet_clear_region) : Merge all types of deletion into
      	  this routine and add some bit flags to enable the different types.
      	(sheet_clear_region_content) : Delete.
      	(sheet_clear_region_comments) : Delete.
      	(clear_cell_format) : Delete.
      	(sheet_clear_region_formats) : Delete.
      	(sheet_move_range) : Adapt to changes in sheet_clear_region.
      
      	* src/selection.c (cb_sheet_selection_clear) : Delete.
      	(sheet_selection_clear) : Delete.
      	(cb_sheet_selection_clear_content) : Delete.
      	(sheet_selection_clear_content) : Delete.
      	(sheet_selection_clear_comments) : Delete.
      	(sheet_selection_clear_formats) : Delete.
      	(selection_get_ranges) : New function split out from selection_apply.
      	(selection_apply) : Use selection_get_ranges.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) : Use
      	  cmd_clear_selection.
      	* src/item-grid.c (context_clear_cmd) : Ditto.
      
      	* src/corba-sheet.c (Sheet_clear_region) : Adapt to new clear_region
      	  calling convention.
      	(Sheet_clear_region_content) : Use sheet_clear_region.
      	(Sheet_clear_region_comments) : Ditto.
      	(Sheet_clear_region_formats) : Ditto.
      
      	* src/commands.c (cmd_ins_del_row_col_{undo,redo}) : Reload the the
      	  edit bar just in case.
      	(cmd_set_date_time_{undo,redo}) : Ditto.
      	(cmd_clear{,_undo,_redo,_destroy}) : Implement.
      
      	* src/clipboard.c (paste_cell) : No need to flag the existance of
      	  formulas.
      	(paste_cell_flags) : Ditto.
      	(do_clipboard_paste_cell_region) : Don't recalc here.
      	(x_selection_received) : Recalc here.
      	(clipboard_paste_region) : Only use the X selection if the user does
      	  not pass in a CellRegion. Only use the clipboard_paste_callback_data
      	  if we are going through the X selection.
      3588e489
  28. 13 Jan, 2000 2 commits
    • Jody Goldberg's avatar
      When an X app requests that a region that was cut we should be consistant · f5a62550
      Jody Goldberg authored
      and clear the region after the operation.
      f5a62550
    • Jody Goldberg's avatar
      - Remove have_selection cruft. Use application instead. · c2637d6a
      Jody Goldberg authored
      - Fix cut & paste to consistantly mark & clear X selection.
      - Add depend on gtk >= 1.2.2 in configure.in
      
      2000-01-13  Jody Goldberg <jgoldberg@home.com>
      
      	* src/application.c (application_clipboard_copy,
      	  application_clipboard_cut) : Use application_set_selected_sheet.
      	(application_set_selected_sheet) : New routine that manages exporting
      	  selection to X too.
      
      	* src/clipboard.c (x_selection_clear) : Something else now has the
      	  selection.  Clear ours.
      	(clipboard_export_cell_region) : Delete.
      	(find_local_workbook_with_selection) : Delete.
      	(workbook_selection_locator) : Delete.
      
      	* ./src/item-grid.c (item_grid_popup_menu) : Always enable paste,
      	  only enable paste special when we have a local cut.  This matches
      	  the behavior of the menus and toolbar.
      
      	* configure.in : Add a depend on libgtk+ >= 1.2.2 because 1.2.1
      	  did not have gtk_object_get.
      c2637d6a
  29. 06 Jan, 2000 1 commit
  30. 03 Jan, 2000 1 commit
    • Jody Goldberg's avatar
      paste_special is only disabled for cut not for standard actions. · 42bca65b
      Jody Goldberg authored
      
      2000-01-03  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook.c (workbook_new) : paste_special is only disabled for
      	  cut not for standard actions.
      
      	* src/value-sheet.c (value_is_error) : New routine to look up errors.
      	(gnumeric_error_init) : New routine.
      	(constants_init) : Used here.
      
      	* src/parser.y (yylex) : If a string begins with '#' it may be an
      	  explicit error string.
      
      	* src/xml-io.c (xml_write_style_border) : Write BORDER_NONE's too,
      	  this makes it possible to save and restore the NONEs that erase borders.
      42bca65b