1. 10 Apr, 2000 4 commits
    • Michael Meeks's avatar
      correct include. · f84afb18
      Michael Meeks authored
      2000-04-11  Michael Meeks  <michael@helixcode.com>
      
      	* src/parser.y: correct include.
      
      	* src/cell.c (cell_set_rendered_text): move up to before its first use.
      f84afb18
    • Dom Lachowicz's avatar
      Minor bonobo print fixes ( preprocessed out of course ) · 452d4e17
      Dom Lachowicz authored
      Dom's s/private/priv/
      
      2000-04-09 Dom Lachowicz <dominicl@seas.upenn.edu>
      
       	* src/sheet.h: Rename member "private" -> "priv" in case anyone in the
       	future writes a plugin / module written in C++
      
       	* src/sheet.c (sheet_new, sheet_flag_status_update_cell,
       	sheet_flag_status_update_page, sheet_update, sheet_destroy,
       	sheet_set_edit_pos, sheet_insert_cols, sheet_delete_cols,
       	sheet_insert_rows, sheet_delete_rows, sheet_restore_row_col_sizes,
       	sheet_col_set_size_pts, sheet_col_set_size_pixels,
       	sheet_row_set_size_pts, sheet_row_set_size_pixels): Same
      
       	* src/corba-sheet.c (sheet_corba_setup, sheet_corba_shutdown): Same
      
       	* src/corba-workbook.c (corba_sheet): Same
      
       	* src/embeddable-grid.c (Grid_get_sheet): Same
      
       	* src/sheet-vector.c (sheet_vector_attach, sheet_vector_detach,
       	sheet_vectors_cell_changed, sheet_vectors_shutdown): Same
      452d4e17
    • Miguel de Icaza's avatar
      Do not destroy the context here, as it is dereferenced later in the · 30aba440
      Miguel de Icaza authored
      
      
      2000-04-07  Miguel de Icaza  <miguel@gnu.org>
      
      	* main.c (button_cancel): Do not destroy the context here, as it
      	is dereferenced later in the mainloop.
      
      2000-04-10  Miguel de Icaza  <miguel@gnu.org>
      
      	* Lots of files: replaces utils.h for gutils.h
      
      	* renamed utils.h to gutils.h to avoid the compilation problem on
      	some Unices (yes, fixing the Makefile would have done it, but
      	utils.h was still a lame name;  Of course gutils.h is not any
      	better, but it is now done).
      
      2000-04-07  Miguel de Icaza  <miguel@gnu.org>
      
      	* src/cellspan.c (span_remove): Pretify code.
      30aba440
    • Jody Goldberg's avatar
      Do NOT recalc on load for now even though there are are queued cells that · 43aa96ea
      Jody Goldberg authored
      
      2000-04-10  Jody Goldberg <jgoldberg@home.com>
      
      	* src/file.c (workbook_read) : Do NOT recalc on load for now even
      	  though there are are queued cells that desire it.  This will
      	  prematurely mark the sheet as dirty.  This will need to be
      	  revisited.
      
      	* src/cell.c (cell_set_rendered_text) : Make static.
      
      	* src/cell.c (cell_calc_dimensions) : Be careful to recalculate spans
      	  that centered on other cells when calculating the span for a new
      	  cell.
      43aa96ea
  2. 09 Apr, 2000 12 commits
    • Michael Meeks's avatar
      More print work; #ifdef out all bonobo-print work. · 42e62f53
      Michael Meeks authored
      More print work;
      #ifdef out all bonobo-print work.
      
      2000-04-09  Michael Meeks  <michael@helixcode.com>
      
      	* src/sheet-object-bonobo.c (sheet_object_bonobo_class_init): add print
      	hooks.
      
      	* src/sheet-object-graphic.c (sheet_object_graphic_print): implement.
      	(sheet_object_graphic_class_init): setup print method
      
      	* src/print.c (print_page_object): implement.
      	(print_page): add hook.
      
      	* src/sheet-object.c (sheet_object_print): implement.
      	(sheet_object_class_init): setup default print behavior.
      
      	* src/sheet-object.h: Add virtual method 'print'
      
      	* src/dialogs/dialog-cell-format.c (fmt_dialog_init_format_page):
      	free list after creation. (fmt_dialog_impl, cb_notebook_destroy):
      	pass the signal id without using the FormatState that is free'd by
      	the time we destroy the notebook.
      42e62f53
    • Morten Welinder's avatar
      Leak fixes. · 6a628fe4
      Morten Welinder authored
      6a628fe4
    • Jody Goldberg's avatar
      kill warning · c4588419
      Jody Goldberg authored
      c4588419
    • Jody Goldberg's avatar
      *** empty log message *** · c857d27e
      Jody Goldberg authored
      c857d27e
    • Jody Goldberg's avatar
      Do not change the target style if editing has not yet been enabled. · cd9b6682
      Jody Goldberg authored
      
      2000-04-09  Jody Goldberg <jgoldberg@home.com>
      
      	* src/dialogs/dialog-cell-format.c : Do not change the target style if
      	  editing has not yet been enabled.
      
      	* src/workbook.c (workbook_set_saveinfo) : If the save function is
      	  NULL default to xml.
      
      	* src/format.c (format_value) : Add some error checking.
      
      	* src/cell.c (calc_text_dimensions) : Make static
      
      	* src/main.c : Add main.h
      
      2000-04-03  Dom Lachowicz <dominicl@seas.upenn.edu>
      
       	* src/workbook.c (sheet_action_reorder_sheet): Right click on a
       	sheet tab, and if there's more than one sheet, you'll get an
       	option to bring up the re-order sheets dialog
      
       	* src/dialogs/dialog-plugin-manager.c (refresh_right_frame) :  Do not
      	  override default fonts and colours.
      
      	* src/dialogs/sheet-order.glade,
      	* src/dialogs/sheet-order.glade.h,
      	* src/dialogs/dialog-sheet-order.c (row_cb, delete_clicked_cb,
      	  up_clicked_cb, down_clicked_cb, close_clicked_cb,
      	  dialog_sheet_order_impl) : Improve look by moving buttons to the
      	  right edge rather than using stock buttons on the bottom and side.
      
      2000-04-07  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook.c (workbook_finish_editing) : resensitize the toolbars
      	  after editing.
      	(workbook_start_editing_at_cursor) : Desensitize the toolbars when we
      	  start to edit.
      cd9b6682
    • Morten Welinder's avatar
      Minor leak. · 2742644c
      Morten Welinder authored
      2742644c
    • Morten Welinder's avatar
      Leak fixes. · 70b5041f
      Morten Welinder authored
      70b5041f
    • Michael Meeks's avatar
      implement. (print_page): add hook. · 627c13f9
      Michael Meeks authored
      2000-04-09  Michael Meeks  <michael@helixcode.com>
      
      	* src/print.c (print_page_object): implement.
      	(print_page): add hook.
      
      	* src/sheet-object.c (sheet_object_print): implement.
      	(sheet_object_class_init): setup default print behavior.
      
      	* src/sheet-object.h: Add virtual method 'print'
      
      	* src/dialogs/dialog-cell-format.c (fmt_dialog_init_format_page):
      	free list after creation. (fmt_dialog_impl, cb_notebook_destroy):
      	pass the signal id without using the FormatState that is free'd by
      	the time we destroy the notebook.
      627c13f9
    • Jon K Hellan's avatar
      Put "cell_changed" signal back in. · eff5af9d
      Jon K Hellan authored
      2000-04-09  Jon K Hellan  <hellan@acm.org>
      
      	* src/workbook.[ch] (workbook_class_init): Put "cell_changed"
      	signal back in.
      
      	* src/sheet.c (sheet_load_cell_val): Ditto.
      
      2000-04-09  Jon K Hellan  <hellan@acm.org>
      
      	* gtk-combo-text.[ch]: Fix problem with mouseover: Mouseover from
      	last time popup was up persists if popup was last dismissed with
      	Escape.
      
      	* gtk-combo-text.h (_GtkComboText): Add member to remember which
      	entry widget we are caching.
      
      	* gtk-combo-text.c (gtk_combo_text_destroy): Disconnect
      	cb_pop_down.
      	(cb_enter): Remember which entry widget we are caching.
      	(cb_pop_down): New callback function. Forget cached entry widget.
      	(gtk_combo_text_construct): Note that we're not yet caching any
      	entry widget.
      	(gtk_combo_text_new): Connect cb_pop_down to pop_down_done.
      
      	* gtk-combo-box.c (gtk_combo_popup_tear_off): Add missing cast to
      	kill warning.
      	(gtk_combo_tearoff_bg_copy): It's not in use. #ifdef 0 it, and add
      	comment about when it would be needed.
      	(gtk_combo_popup_reparent): Add FIXME comment about code which
      	isn't used, but will be needed.
      eff5af9d
    • Michael Meeks's avatar
      Fix styles on move so they blank the 'underneath' style first instead · 09613e12
      Michael Meeks authored
      of superimposing styles.
      09613e12
    • Morten Welinder's avatar
      Brag. · 7ca8142c
      Morten Welinder authored
      7ca8142c
    • Morten Welinder's avatar
      Make auto-format work for sheet-relative cellrefs like "=sum(a1:a10)". · 9b636fcb
      Morten Welinder authored
      
      2000-04-09  Morten Welinder  <terra@diku.dk>
      
      	* src/sheet.h (ParsePositions): Add sheet.
      
      	* src/expr.c (parse_pos_init): New arg sheet.  All callers changed.
      
      	* src/parser.y (gnumeric_expr_parser): Use pp->sheet.
      9b636fcb
  3. 08 Apr, 2000 4 commits
  4. 07 Apr, 2000 13 commits
    • Jon K Hellan's avatar
      Replace member name with name_quoted and name_unquoted. In name_quoted, · 699e8bf7
      Jon K Hellan authored
      2000-04-08  Jon K Hellan  <hellan@acm.org>
      
              * src/sheet.h (struct _Sheet): Replace member name with
      	name_quoted and name_unquoted. In name_quoted, names with spaces
      	or quote characters are protected with quotes.
      
      	* src/analysis-tools.c (prepare_output): Use
      	workbook_sheet_get_free_name to ensure that we don't create more
      	than one sheet with the same name.
      
      	* src/eval.c (dump_cell_list, sheet_dump_dependencies): Dump
      	sheet->name_unquoted instead of sheet->name.
      
      	* src/expr-name.c (name_sheet_title): Make value from
      	sheet->name_quoted instead of sheet->name. FIXME: Is this correct?
      
      	* src/gnumeric-sheet.c (selection_insert_selection_string): Make
      	selection string from sheet->name_quoted instead of quoting
      	sheet->name here.
      
      	* src/print-info.c (render_tab): Render sheet->name_unquoted
      	instead of sheet->name.
      
      	* src/print-preview.c (create_toplevel): Use sheet->name_unquoted
      	instead of sheet->name in window title.
      
      	* src/selection.c (sheet_selection_to_string, range_to_string):
      	Make reference string from sheet->name_quoted instead of quoting
      	sheet->name here.
      
      	* src/sheet.[ch] (sheet_quote_name): Rename to
      	sheet_name_quote. Take name_unquoted parameter, not a sheet.
      
      	* src/sheet.c (sheet_rename, sheet_new): Set both
      	sheet->name_quoted and sheet->name_unquoted.
      	(sheet_destroy): Free both sheet->name_quoted and
      	name_unquoted.
      	(cellref_name): Make reference from sheet->name_quoted instead of
      	quoting sheet->name here.
      
      	* src/test.c (thrash_sheet): Use sheet->name_unquoted instead of
      	sheet->name in debug output.
      
      	* src/value-sheet.c (value_dump): Dump sheet->name_quoted instead
      	of quoting sheet->name here.
      	(encode_cellref): Use sheet->name_quoted instead of quoting
      	sheet->name here.
      
      	* src/workbook.[ch] (workbook_sheet_get_free_name): Make it more
      	generally useful: Add "base" and "always_suffix" parameters. The
      	caller should now select the base to make the name from
      	(e.g. "Sheet"), and specify whether or not a suffix should be
      	added when the name "base" is not in use.
      
      	* src/workbook.c (insert_sheet_cmd): Use new signature of
      	workbook_sheet_get_free_name.
      	(workbook_rename_sheet): Insert unquoted name in hash table.
      	(sheet_label_text_changed_signal): Remove test for quote
      	characters in sheet name.
      	(sheet_action_delete_sheet): Prompt with name_unquoted instead of
      	name.
      	(sheet_action_rename_sheet, workbook_attach_sheet): Use
      	name_unquoted instead on name.
      	(workbook_detach_sheet): Use sheet->name_unquoted as hash key
      	instead of sheet->name.
      
      	* src/workbook-cmd-format.c
      	(workbook_cmd_format_sheet_change_name): Use name_unquoted instead
      	on name.
      
      	* src/xml-io.c (xml_sheet_write): Output sheet->name_unquoted
      	instead of sheet->name.
      
      	* src/dialogs/dialog-sheet-order.c (dialog_sheet_order_impl): Make
      	list header passive.
      	(add_to_sheet_clist, delete_cb): Substitute sheet->name_unquoted
      	for sheet->name.
      
      	* src/dialogs/dialog-zoom.c (dialog_zoom_impl): Ditto.
      
      2000-04-08  Jon K Hellan  <hellan@acm.org>
      
      	* graphic-context.c (graphic_wizard_guess_series): Substitute
      	sheet->name_quoted for sheet->name.
      
      2000-04-08  Jon K Hellan  <hellan@acm.org>
      
      	* ms-excel-read.c (ms_excel_set_xf, ms_excel_read_formula,
      	ms_excel_read_sheet):  Use
      	gnum_sheet->name_unquoted instead of gnum_sheet->name in debug
      	output.
      	(ms_excel_read_workbook): Remove unused variable to silence
      	warning.
      
      	* ms-excel-write.c (write_externsheets): Output
      	gnum_sheet->name_quoted instead of gnum_sheet->name. FIXME: Is
      	this correct?
      	(write_sheet): Use gnum_sheet->name_unquoted instead of
      	gnum_sheet->name in debug output.
      	(write_workbook): Output gnum_sheet->name_unquoted instead of
      	gnum_sheet->name.
      
      	* ms-formula-read.c (ms_excel_parse_formula): Use
      	gnum_sheet->name_unquoted instead of gnum_sheet->name in debug
      	output.
      
      	* ms-obj.c (object_anchor_to_position): Ditto.
      
      2000-04-08  Jon K Hellan  <hellan@acm.org>
      
      	* html.c (html_write_wb_html32, html_write_wb_html40): Output
      	sheet->name_unquoted instead of sheet->name.
      	(html_read): Gettextize sheet name template.
      
      	* latex.c (html_write_wb_latex, html_write_wb_latex2e):  Output
      	sheet->name_unquoted instead of sheet->name.
      
      	* roff.c (write_wb_roff): Ditto
      
      2000-04-08  Jon K Hellan  <hellan@acm.org>
      
      	* lotus.c (attach_sheet): Remove \n from sheet name. Gettextize
      	sheet name template.
      
      2000-04-08  Jon K Hellan  <hellan@acm.org>
      
      	* oleo.c (attach_sheet): Remove \n from sheet name. Gettextize
      	sheet name template.
      
      2000-04-08  Jon K Hellan  <hellan@acm.org>
      
      	* pln.c (pln_read_workbook): Use workbook_set_saveinfo instead of
      	workbook_set_filename.
      
      2000-04-08  Jon K Hellan  <hellan@acm.org>
      
      	* text-io.c (writeTextSheet): Output sheet->name_unquoted instead of
      	sheet->name.
      	(readTextWorkbook): Ungettextize name of sheet to
      	create. text_parse_file is supposed to rename it.
      699e8bf7
    • Jon K Hellan's avatar
      Use gladified random dialog: changed most members. (struct · 99790b18
      Jon K Hellan authored
      2000-04-08  Jon K Hellan  <hellan@acm.org>
      
      	* src/dialogs/dialog-analysis-tools.c (struct
      	random_tool_callback_t): Use gladified random dialog: changed most
      	members.
      	(struct DistributionStrs): New struct to hold name to show in list
      	and parameter labels for a random distribution.
      	(distribution_strs): Change to a DistributionStrs struct.
      	(output_range_selected): New callback function. This is part of a
      	change which selects the corresponding toggle button when the
      	output range field is entered. This works for all gladified
      	dialogs in this file.
      	(set_output_option_signals): Set up output_range_selected callback
      	on output range field. The widget is retrieved by name, so widget
      	names in analysis-tools.glade had to be changed.
      	(dialog_correlation_tool, dialog_covariance_tool,
      	dialog_ttest_paired_tool, dialog_ttest_eq_tool,
      	dialog_ttest_neq_tool, dialog_ftest_tool, dialog_average_tool,
      	dialog_ranking_tool, dialog_anova_single_factor_tool,
      	dialog_anova_two_factor_without_r_tool): New widget name for
      	output range field.
      	(dialog_correlation_tool, dialog_covariance_tool,
      	dialog_ttest_paired_tool, dialog_ttest_eq_tool,
      	dialog_ttest_neq_tool, dialog_ftest_tool, dialog_average_tool,
      	dialog_ranking_tool, dialog_anova_single_factor_tool,
      	dialog_anova_two_factor_without_r_tool): Make <Enter> in entry
      	fields activate default button.
      	(distribution_strs_find, distribution_parbox_config,
      	combo_get_distribution, dialog_random_realized): These new
      	functions are helpers for gladified random generation dialog.
      	(distribution_strs_find): Find strings record, given distribution
      	enum.
      	(distribution_parbox_config): Configure parameter widgets given
      	random distribution.
      	(combo_get_distribution): Find from combo the distribution the
      	user selected.
      	(distribution_callback): Configure parameter widgets for the
      	distribution which was selected.
      	(dialog_random_realized): Make initial geometry of distribution
      	table permanent.
      	(dialog_random_tool): Libgladify. This is a complete
      	rewrite. Other changes: Make the "distribution" variable function
      	static instead of file static. Rebuild the dialog each time it is
      	displayed. This is like the other libglade dialogs in this file.
      	Make <Enter> in entry fields activate default button. Get random
      	distribution name and parameter label strings from
      	distribution_strs struct. Use a "realized" callback to make
      	initial geometry permanent. Unref accel group for distribution
      	parameter widgets when dialog is destroyed.
      
      	* src/dialogs/analysis-tools.glade (All dialogs): Remove ':' from
      	frame labels. Add accelerators. Rename output range entry widgets
      	to xxx_output_range_entry. Minor output options tweaks.
      	(FTest dialog, TTest1 dialog, TTest2 dialog, TTest3 dialog): Use
      	alignment and fill instead of spaces to place label strings.
      	(Anova2 dialog, MovingAverage dialog): Use table in input frame so
      	that entry fields are aligned.
      	(Random dialog:) New dialog.
      99790b18
    • Morten Welinder's avatar
      Unref, not destroy. · d73b7bd1
      Morten Welinder authored
      2000-04-07  Morten Welinder  <terra@diku.dk>
      
      	* widget-pixmap-combo.c (pixmap_combo_destroy): Unref, not destroy.
      d73b7bd1
    • Miguel de Icaza's avatar
      Replace ::finalize with ::destroy. · 89b87726
      Miguel de Icaza authored
      2000-04-07  Miguel de Icaza  <miguel@gnu.org>
      
      	* widget-pixmap-combo.c (pixmap_combo_class_init): Replace
      	::finalize with ::destroy.
      89b87726
    • Morten Welinder's avatar
      Leaks. · 7760802e
      Morten Welinder authored
      2000-04-07  Morten Welinder  <terra@diku.dk>
      
      	* src/selection.c (sheet_selection_reset_only): Free the right list.
      	(sheet_is_range_selected): Avoid double assignment.
      	(sheet_is_cell_selected): Ditto.
      
      	* src/history.c (history_menu_remove_items): Plug leak.
      7760802e
    • Miguel de Icaza's avatar
      Fix leak. · d24709ac
      Miguel de Icaza authored
      2000-04-07  Miguel de Icaza  <miguel@gnu.org>
      
      	* widget-pixmap-combo.c (pixmap_combo_finalize): Fix leak.
      d24709ac
    • Jody Goldberg's avatar
      Fix typo, did this ever work ? · cf3f1e00
      Jody Goldberg authored
      
      2000-04-07  Jody Goldberg <jgoldberg@home.com>
      
      	* src/embeddable-grid.h (GridViewClass) : Fix typo, did this ever work ?
      
      	* src/workbook.c (workbook_move_sheet) : Mark the book as dirty when a
      	  sheet moved.
      	(insert_sheet_cmd) : Mark book as dirty when sheet is added.
      	(workbook_attach_sheet) : Add a precondition to avoid failing in the
      	  bonobo case.
      cf3f1e00
    • Morten Welinder's avatar
      Get rid of COLLECT_IGNORE_POSITIVE and COLLECT_IGNORE_NEGATIVE. · 6b3ee7b5
      Morten Welinder authored
      2000-04-07  Morten Welinder  <terra@diku.dk>
      
      	* src/collect.h (CollectFlags): Get rid of COLLECT_IGNORE_POSITIVE
       	and COLLECT_IGNORE_NEGATIVE.
      
      	* src/collect.c (callback_function_collect): Don't have the above
       	flags.
      
      	* src/functions/fn-financial.c (irr_npv_df): New function.
      	(gnumeric_irr): Use irr_npv_df for better results.
      	(gnumeric_ipmt, gnumeric_ppmt): Fix order of arguments!  (It works
       	so much better that way.)
      	(gnumeric_mirr): Fix formula.
      
      	* src/goal-seek.c (update_data): Spelling fix.
      
      	* src/functions/fn-financial.c (gnumeric_rate, gnumeirc_irr,
       	gnumeric_xirr): Use the supplied guess.
      6b3ee7b5
    • Jody Goldberg's avatar
      Fix minor thinko in eval_expr. · 0f4097ca
      Jody Goldberg authored
      Improve status update after load.
      
      2000-04-06  Jody Goldberg <jgoldberg@home.com>
      
      	* src/xml-io.c (gnumeric_xml_read_workbook) : No need to recalc, the
      	  loader handles it.
      
      	* src/file.c (workbook_read) : Do a recalc and sheet_update after loading.
      	  Wrap entire process in deep_{freeze,thaw}.
      
      	* src/expr.c (eval_expr) : Fix thinko.
      0f4097ca
    • Jody Goldberg's avatar
      Fix thinko. · f4bd1b61
      Jody Goldberg authored
      
      2000-04-06  Jody Goldberg <jgoldberg@home.com>
      
      	* src/expr.c (eval_expr) : Fix thinko.
      f4bd1b61
    • Jody Goldberg's avatar
      A small stabilization patch. Hopefully this will not conflict. · 0edb562f
      Jody Goldberg authored
      2000-04-06  Jody Goldberg <jgoldberg@home.com>
      
      	* graph.c (graph_compute_scatter_dimensions) : Minor patch to avoid
      	  crashing on empty selection.
      	* graph-view-scatter.c (graph_view_scatter_plot) : Ditto.
      	(graph_view_line_plot) : Ditto.
      0edb562f
    • Jody Goldberg's avatar
      Fix http://bugs.gnome.org/db/85/8506.html · 18e5debc
      Jody Goldberg authored
      Mixed mode references are evil.
      
      A bit of interface improvement for gtk-combo-text
      
      2000-04-06  Jody Goldberg <jgoldberg@home.com>
      
      	* src/functions/fn-string.c : Add func 'expression' to return text of
      	  formula.
      
      	* src/parser.y : It is illegal to write A1:Sheet2!A3.
      
      	* src/value.c (value_new_cellrange) : Take the eval pos so that we can
      	  correctly invert mixed mode references when necessary.
      
      	* src/expr.c (cell_ref_make_abs) : New routine.
      	(expr_relocate) : Handle changes in value_new_cellrange.
      	* src/func.c (function_marshal_arg) : Ditto.
      	* src/ranges.c (range_parse) : Ditto.
      
      	* src/corba-sheet.c (Sheet_cell_set_value) : No need to check these
      	  references.  They seem to be hard coded to be relative.
      
      	* src/functions/fn-lookup.c (gnumeric_offset) : Begin to handle
      	  relative references.
      
      	* src/sheet.c (cellref_get) : Simplify the logic a smidge.
      
      	* src/workbook.c (workbook_finish_editing) : Restore the edit area
      	  manually for now.  We may need to make the update flags finer grain.
      18e5debc
    • Miguel de Icaza's avatar
      Rename graph component name · 237ff618
      Miguel de Icaza authored
      237ff618
  5. 06 Apr, 2000 7 commits