1. 18 Apr, 2001 1 commit
    • Jon K Hellan's avatar
      Change return type to GnumericExprEntry. (workbook_set_entry): Change type · eb52c908
      Jon K Hellan authored
      2001-04-18  Jon K Hellan  <hellan@acm.org>
      
      	* src/workbook-edit.[ch] (workbook_get_entry,
      	workbook_get_entry_logical): Change return type to
      	GnumericExprEntry.
      	(workbook_set_entry): Change type of entry argument to
      	GnumericExprEntry.
      
      	* src/gnumeric-sheet.c (move_cursor): Move to scg::scg_move_cursor
      	(cursor_horizontal_move): Move to scg::scg_cursor_horizontal_move
      	(cursor_horizontal_extend): Move to
      	scg::scg_cursor_horizontal_extend
      	(cursor_vertical_move): Move to scg::scg_cursor_vertical_move
      	(cursor_vertical_extend): Move to scg::scg_cursor_vertical_extend
      	(selection_remove_selection_string,
      	selection_insert_selection_string): Remove. GnumericExprEntry
      	widget now handles this.
      	(start_cell_selection_at): Rename to start_range_selection_at.
      	(start_cell_selection): Rename to start_range_selection.
      	(gnumeric_sheet_start_cell_selection): Rename to
      	gnumeric_sheet_start_range_selection.
      	(gnumeric_sheet_stop_cell_selection): Rename to
      	gnumeric_sheet_stop_range_selection. Remove clear_string parameter
      	and selection string manipulation.
      	(rangesel_horizontal_move): Make non-static, rename to
      	gnumeric_sheet_rangesel_horizontal_move, remove selection string
      	manipulation.
      	(rangesel_vertical_move): Make non-static, rename to
      	gnumeric_sheet_rangesel_vertical_move, remove selection string
      	manipulation.
      	(rangesel_horizontal_extend): Make non-static, rename to
      	gnumeric_sheet_rangesel_horizontal_extend, remove selection string
      	manipulation.
      	(rangesel_vertical_extend): Make non-static, rename to
      	gnumeric_sheet_rangesel_vertical_extend, remove selection string
      	manipulation.
      	(gnumeric_sheet_key_mode_sheet): Use movefn's from scg instead of
      	from GnumericSheet.
      
      	* src/gnumeric-sheet.h (gnumeric_sheet_start_cell_selection):
      	Rename to gnumeric_sheet_start_range_selection.
      	(gnumeric_sheet_stop_cell_selection): Rename to
      	gnumeric_sheet_stop_range_selection. Remove clear_string
      	parameter.
      	(gnumeric_sheet_rangesel_horizontal_move,
      	gnumeric_sheet_rangesel_vertical_move,
      	gnumeric_sheet_rangesel_horizontal_extend,
      	gnumeric_sheet_rangesel_vertical_extend): Declare.
      
      	* src/gnumeric-util.[ch] (gnumeric_entry_at_subexpr_boundary_p):
      	Rename to gnumeric_expr_entry_at_subexpr_boundary_p and move to
      	gnumeric_expr_entry widget.
      
      	* src/item-grid.c (item_grid_button_1, item_grid_event): Use scg
      	methods instead of methods from GnumericSheet.
      
      	* src/sheet.[ch] (sheet_stop_cell_selection): Rename to
      	sheet_stop_range_selection.
      
      	* src/sheet-control-gui.c (scg_colrow_select): Use scg methods
      	instead of methods from GnumericSheet.
      	(scg_stop_editing): Add call to scg_stop_cell_selection.
      	(scg_range_selection_changed): New function. Notify ExprEntry that
      	the expression range has changed.
      	(scg_move_cursor): Moved here from GnumericSheet.
      	(scg_rangesel_cursor_extend): Add call to
      	scg_range_selection_changed.
      	(scg_rangesel_cursor_bounds, scg_rangesel_horizontal_move,
      	scg_rangesel_vertical_move, scg_rangesel_horizontal_extend,
      	scg_rangesel_vertical_extend): New functions. Call GnumericSheet
      	counterpart and notify ExprEntry.
      	(scg_cursor_horizontal_move, scg_cursor_horizontal_extend,
      	scg_cursor_vertical_move, scg_cursor_vertical_extend): Moved here
      	from GnumericSheet.
      	(scg_get_sel_cursor_pos): New function. Return selection cursor
      	position.
      
      	* src/sheet-control-gui.h (scg_range_selection_changed,
      	scg_move_cursor, scg_rangesel_cursor_bounds,
      	scg_rangesel_horizontal_move, scg_rangesel_vertical_move,
      	scg_rangesel_horizontal_extend, scg_rangesel_vertical_extend,
      	scg_cursor_horizontal_move, scg_cursor_vertical_move,
      	scg_cursor_horizontal_extend, scg_cursor_vertical_extend,
      	scg_get_sel_cursor_pos): Declare.
      
      	* src/sheet-control-gui.[ch] (scg_stop_cell_selection): Rename to
      	scg_stop_range_selection. Notify ExprEntry that range selection
      	has stopped.
      
      	* src/sheet-object-widget.c (cb_checkbox_config_focus): Call
      	gnumeric_expr_entry_select_absolute.
      	(sheet_widget_checkbox_user_config): Use GnumericExprEntry. Attach
      	it to the scg.
      
      	* src/workbook-control-gui.c (cb_notebook_switch_page): Use new
      	function name sheet_stop_range_selection.
      
      	* src/workbook-control-gui-priv.h (struct
      	_WorkbookControlGUI::struct edit_line): entry and temp_entry are
      	now GnumericExprEntries.
      	(struct _WorkbookControlGUI): Remove select_abs_col,
      	select_abs_row, select_full_col, select_full_row and
      	select_single_cell.
      
      	* src/workbook-control-gui.c (wbcg_finish_editing,
      	wb_edit_key_pressed, cb_autofunction, workbook_setup_edit_area,
      	auto_complete_matches): Entry must now be cast to GtkEntry.
      	(workbook_control_gui_init): select_abs_col, select_abs_row,
      	select_full_col, select_full_row and select_single_cell no longer
      	exist.
      
      	* src/workbook-edit.c (workbook_finish_editing, entry_changed,
      	workbook_start_editing_at_cursor): entry must now be cast to
      	GtkEntry.
      	(workbook_start_editing_at_cursor): Attach scg to
      	ExprEntry. wbcg->select_abs_col and select_abs_row no longer
      	exist.
      	(workbook_edit_select_absolute): Move to ExprEntry widget.
      	(workbook_edit_toggle_absolute): New function. Probably remove it
      	again.
      	(workbook_edit_init): Remove redundant 'g_assert != NULL'. Use
      	GnumericExprEntry widget.
      
      2001-04-18 Jon K Hellan  <hellan@acm.org>
      
      	* src/dialogs/dialog-define-names.c (struct NameGuruState):
      	Change type of expr_text to GnumericExprEntry.
      	(name_guru_set_expr, name_guru_update_sensitivity,
      	name_guru_set_expr, cb_name_guru_add): expr_text must now be
      	cast to GTK_ENTRY.  (cb_name_guru_value_focus): Use
      	gnumeric_expr_entry_set_absolute. w argument is now expected
      	to be a GnumericExprEntry.  (cb_name_guru_set_focus): New
      	function. Make anted selection go away when a widget other
      	than expr_text receives focus.  (name_guru_init): Create a
      	GnumericExprEntry and insert in the dialog. Attach it to the
      	current sheet. Connect cb_name_guru_set_focus to dialog's
      	set-focus signal, and remove the focus-in handler from
      	name_value.
      
      	* src/dialogs/dialog-function-wizard.c (struct ArgumentState):
      	Change type of entry to GnumericExprEntry.
      	(formula_guru_set_expr): Change type of new_entry to
      	GnumericExprEntry. Cast to GTK_ENTRY where necessary.
      	(formula_guru_set_expr, cb_formula_guru_rolled_entry_changed,
      	cb_formula_guru_entry_changed, formula_guru_init):
      	ArgumentState->entry must now be cast to GTK_ENTRY.
      	(formula_guru_set_rolled_state): Change type of new_entry to
      	GnumericExprEntry. Cast to GTK_ENTRY where necessary.
      	(formula_guru_arg_new): Create a GnumericExprEntry instead of
      	a GtkEntry and insert in the dialog. Attach it to the current
      	sheet.  (formula_guru_init): Create a GnumericExprEntry for
      	rolled_entry and insert in the dialog. Attach it to the
      	current sheet.  (dialog_formula_guru): Value returned by
      	workbook_get_entry must now be cast to GTK_ENTRY.
      
      	* src/dialogs/formula-guru.glade: Remove 'rolled_entry'
      	GtkEntry. A GnumericExprEntry is now added at runtime instead.
      
      	* src/dialogs/names.glade: Remove 'expr_text' GtkEntry. A
      	GnumericExprEntry is now added at runtime instead.
      eb52c908
  2. 15 Apr, 2001 1 commit
    • Almer S. Tigelaar's avatar
      Add detailed parser error messages. · fa7e253a
      Almer S. Tigelaar authored
      2001-04-15  Almer S. Tigelaar  <almer@gnome.org>
      
      	* src/parser.y : Add detailed parser error messages.
      
      	* src/workbook-edit.c (workbook_finish_editing) : Abort
      	if the expression is invalid and return a boolean indicating
      	success or failure.
      
      	* src/expr.c (expr_parse_string): Set error message to the
      	result of gnumeric_expr_parser.
      
      	* src/parse-util.c (parse_error_init) : Properly initialize
      	begin and end character.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet): Don't
      	change the cursor position if workbook_finish_editing failed.
      	(move_cursor): Idem.
      
      	* src/item-grid.c (item_grid_button_1): Idem.
      fa7e253a
  3. 17 Mar, 2001 1 commit
    • Jody Goldberg's avatar
      Handle outline mode. (ms_excel_read_colinfo) : ditto. (ms_excel_read_guts) · e1a87d5f
      Jody Goldberg authored
      
      2001-03-15  Jody Goldberg <jgoldberg@home.com>
      
      	* ms-excel-read.c (ms_excel_read_row) : Handle outline mode.
      	(ms_excel_read_colinfo) : ditto.
      	(ms_excel_read_guts) : ditto.
      
      2001-03-16  Jody Goldberg <jgoldberg@home.com>
      
      	* src/item-bar.c (item_bar_calc_size) : rename from
      	  item_bar_fonts_init.
      
      	* src/sheet-control-gui.c (scg_set_zoom_factor) : prepare for panes by
      	  zooming the col/row header canvases.  We need this as we transition
      	  to using gnumeric-sheets instead of canvases to hold the item-bars.
      
      2001-03-15  Jody Goldberg <jgoldberg@home.com>
      
      	* src/colrow.c (colrow_equal) : handle outline&collapse.
      	(colrow_copy) : ditto.
      
      	* src/item-bar.c (outline_button_press) : new function.
      	(item_bar_event) : used here.
      
      2001-03-15  Jody Goldberg <jgoldberg@home.com>
      
      	* src/item-bar.c (compute_pixels_from_pts) : new function.
      	(item_bar_fonts_init) : resize the indent gutters based on the zoom.
      	(item_bar_realize) : add another gc for outline drawing.
      	(item_bar_unrealize) : ditto.
      	(item_bar_draw) : implement drawing for groupings.
      	(set_cursor) : handle cursor in the presence of groupings.
      
      2001-03-14  Jody Goldberg <jgoldberg@home.com>
      
      	* Makefile.am : update the handling of the oaf file.
      
      	* src/sheet.c (sheet_col_row_default_calc) : rename from
      	  sheet_col_row_default_init.
      
      2001-03-13  Jody Goldberg <jgoldberg@home.com>
      
      	* src/xml-io.c (xml_write_print_repeat_range) : PrintRepeatRange now
      	  uses a simple Range.
      	(xml_read_print_repeat_range) : ditto.
      	* src/print-info.c (print_info_new) : ditto.
      	(save_range) : Ditto.
      	* src/dialogs/dialog-printer-setup.c (do_fetch_page_info) : ditto.
      	* src/print.c (print_range_used_units) : ditto.
      	(print_range_right_then_down) : ditto.
      	(print_range_down_then_right) : ditto.
      	(print_page_repeated_intersect) : ditto.
      	(print_page_repeated_cols) : ditto.
      	(print_page_repeated_rows) : ditto.
      	(print_page) : ditto.
      
      	* src/sheet-control-gui.c (scg_set_zoom_factor) : The sizing has moved
      	  into the itembar.
      
      	* src/item-bar.c : s/orientation/is_col_header/
      	(item_bar_fonts_init) : Init the ideal cell size.
      	(item_bar_update) : Begin to support grouping.
      	(item_bar_draw) : ditto.
      	(item_bar_init) : init the new members.
      
      	* src/print-cell.c (print_cell) : re-enable halign FILL.
      	* src/cell-draw.c (cell_draw) : ditto.
      e1a87d5f
  4. 11 Mar, 2001 1 commit
    • Jody Goldberg's avatar
      avoid generating a spurious signal when pressing on the scrollbar but not · 77e75622
      Jody Goldberg authored
      
      2001-03-10  Jody Goldberg <jgoldberg@home.com>
      
      	* gnumeric-[vh]scrollbar.c (gnumeric_[vh]scrollbar_button_press) : avoid
      	  generating a spurious signal when pressing on the scrollbar but not
      	  moving.
      
      2001-03-10  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet-control-gui.c (scg_construct) : lay some ground work for
      	  multiple panes.
      
      2001-03-08  Jody Goldberg <jgoldberg@home.com>
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_find_{col,row}) : fix off by
      	  one width/height error at far boundary.
      
      	* src/xml-io.c (xml_get_print_unit) : make units case sensitive.
      77e75622
  5. 29 Jan, 2001 1 commit
    • Almer S. Tigelaar's avatar
      Rename to sheet_selection_reset. · 2862b796
      Almer S. Tigelaar authored
      2001-01-30  Almer S. Tigelaar  <almer1@dds.nl>
      
      	* src/selection.c, src/selection.h:
      	(sheet_selection_reset_only): Rename to sheet_selection_reset.
      
      	* src/cmd-edit.c: s/sheet_selection_reset_only/sheet_selection_reset.
      	* src/commands.c: Ditto.
      	* src/gnumeric-sheet.c: Ditto.
      	* src/item-grid.c: Ditto.
      	* src/sheet.c: Ditto.
      	* src/sheet-control-gui.c: Ditto.
      	* src/xml-io.c: Ditto.
      
      2001-01-30  Almer S. Tigelaar  <almer1@dds.nl>
      
      	* ms-excel-read.c (ms_excel_read_selection):
      	Rename sheet_selection_reset_only to sheet_selection_reset.
      
      2001-01-30  Almer S. Tigelaar  <almer1@dds.nl>
      
      	* xml2.c
      	(xml2ParseSelection): Rename sheet_selection_reset_only
      	to sheet_selection_reset.
      2862b796
  6. 26 Jan, 2001 1 commit
  7. 23 Jan, 2001 1 commit
    • Jody Goldberg's avatar
      If we are not selecting a range for an expression then we should cancel · 63e24beb
      Jody Goldberg authored
      
      2001-01-23  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet-control-gui.c (scg_colrow_select) : If we are not
      	  selecting a range for an expression then we should cancel editing.
      	(scg_context_menu) : cancel editing.
      
      2001-01-22  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c : Use the new wrapper function in scg (for now) rather
      	  than a direct call to gsheet.
      
      	* src/sheet-control-gui.c (scg_set_cursor_bounds) : new function to
      	  wrap direct calls to gsheet.  This is prep for supporting panes.
      	(scg_compute_visible_region) : new function
      	(scg_make_cell_visible) : new function
      	(scg_create_editor) : new function
      	(scg_stop_editing) : new function
      	(scg_stop_cell_selection) : new function
      
      	* src/pattern.c (gnumeric_background_set_gc) : no need for setting GC
      	  in non selection case.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_create_editor) : renamed from
      	  gnumeric_sheet_create_editing_cursor.
      	(gsheet_compute_visible_region) : rename from
      	  gnumeric_sheet_compute_visible_ranges
      63e24beb
  8. 16 Jan, 2001 1 commit
    • Jody Goldberg's avatar
      Borders now work. We still don't handle the intersection cases properly. · 925863b2
      Jody Goldberg authored
      And the top and left of merged cells will look odd.
      
      2001-01-16  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet-style.c (sheet_style_get_uniform) : don't leak border ref.
      
      	* src/workbook.c (workbook_sheet_delete) : disable the undo/redo
      	  combos when we clear the undo stack.
      
      2001-01-14  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet-style.c (style_row) : don't apply none to a cleared
      	  border.
      
      	* src/sheet-style.h (StyleRow) : const.
      
      	* src/mstyle.c (mstyle_get_color) : const.
      
      	* src/pattern.c (gnumeric_background_set_gc) : remove duplicate
      	  test, const.
      
      2001-01-13  Jody Goldberg <jgoldberg@home.com>
      
      	* src/item-grid.c (item_grid_draw) : rewrite.
      
      	* src/sheet-control-gui.c (sheet_view_redraw_cell_region) : make the
      	  borders wider.
      
      	* src/commands.c (cmd_format) : if there are no borders there is no
      	  need to save the surroundings.
      
      	* src/selection.c (selection_contains_colrow) : const
      
      	* src/sheet-style.c (get_style_row) : Fix stupidity.
      	(style_row) : ditto.
      
      2001-01-12  Jody Goldberg <jgoldberg@home.com>
      
      	* src/cell-draw.c (cell_draw) : const.
      
      	* src/pattern.c (gnumeric_background_set_gc) : const.
      	(gnumeric_background_set_pc) : const.
      
      	* src/sheet-control-gui.c (sheet_view_selection_ant) : No more 'grid'
      	  argument.
      
      	* src/item-grid.c : privatize the structure in preparation for panes.
      
      	* src/item-edit.c (entry_create_feedback_range) : no more grid
      	  argument.  Use scg instead.
      	(item_edit_set_arg) : ditto.
      
      	* src/item-cursor.c (item_cursor_set_arg) : delete the GRID argument
      	  it was useless.
      
      	* src/gnumeric-sheet.c (start_cell_selection_at) : Avoid casting the
      	  result of a function call.  Remove setting 'Grid' deleted argument.
      	(gnumeric_sheet_new) : No more Grid argument.
      
      	* src/preview-grid.c (preview_grid_draw_border) : moved here from
      	  item-grid.
      925863b2
  9. 12 Jan, 2001 1 commit
    • Jody Goldberg's avatar
      Rework the style engine. Mostly functional. see BUGS for remaining details. · 9e615b65
      Jody Goldberg authored
      NOTE : I have not tested persistance.
      
      2001-01-11  Jody Goldberg <jgoldberg@home.com>
      
      	* src/mstyle.c (mstyle_ref_multiple) : new function.
      	(mstyle_copy_merge) : new function.
      	(mstyle_new_default) : Do not cache the result.  That is done at the
      	  sheet level.
      	(mstyle_do_merge) : delete.
      	(mstyle_get_format) : constness.
      
      	* src/format-template.c (cb_format_sheet_border) : delete.
      	(format_template_apply_to_sheet_regions) : borders are no longer special.
      
      	* src/expr.c (expr_tree_array_formula_corner) : do not store the
      	  corner anymore.
      	(expr_tree_new_array) : ditto.
      	(do_expr_tree_unref) : ditto.
      
      	* src/cell.c (cell_relocate) : Arrays are simplified.  No need to keep
      	  a pointer to the corner.  It made the system too brittle.
      	(cell_set_mstyle) : delete.
      
      	* src/Makefile.am : remove test.[ch]
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_find_{col,row}) : There is no
      	  1 pixel border.
      
      2001-01-09  Jody Goldberg <jgoldberg@home.com>
      
      	* src/mstyle.h : Change order of borders to match BorderLocation
      
      2001-01-08  Jody Goldberg <jgoldberg@home.com>
      
      	* src/ranges.c (range_has_header) : avoid leaking styles.
      
      	* src/cell.c (cell_get_mstyle) : Use sheet_style_get, and do not bump
      	  the ref count.
      	(cell_render_value) : Adjust.
      	(cell_get_format : Adjust.
      	(cell_set_text) : Adjust.
      
      	* src/functions/fn-information.c (gnumeric_cell) : sheet_style_get
      	  does not make a reference. Use it.
      	* src/workbook-format-toolbar.c (modify_cell_format) :  Ditto.
      	(change_selection_font) : Ditto.
      	* src/sheet-autofill.c (fill_item_new) : ditto.
      	* src/print-cell.c (print_cell_range) : ditto.
      	* src/cellspan.c (cell_calc_span) : ditto.
      	* src/sheet.c (sheet_cell_set_text) : ditto.
      	* src/rendered-value.c (rendered_value_calc_size) : ditto.
      	* src/workbook-view.c (wb_view_format_feedback) : ditto.
      
      2001-01-07  Jody Goldberg <jgoldberg@home.com>
      
      	* src/dialogs/dialog-cell-format.c (dialog_cell_format) :
      	  init initial style to NULL.
      	(fmt_dialog_selection_type) : call sheet_style_get_uniform here.
      
      	* src/commands.c (cmd_format_redo) : Now that apply_border is not
      	  doing a redraw we need to if there is no style applied.
      
      	* src/selection.c (sheet_selection_extend_to) : Add support akin to
      	  gnumeric_sheet_rangesel_cursor_extend to extend to full col/row.
      
      	* src/sheet-control-gui.c (scg_colrow_select) : extend to full col/row
      	  if necessary.
      
      	* src/item-bar.c (item_bar_event) : Set the selection, not extend it.
      9e615b65
  10. 04 Jan, 2001 2 commits
    • Jody Goldberg's avatar
      remove crufty use of ItemCursor::base. The cursors have both corners now. · c135fb90
      Jody Goldberg authored
      
      2001-01-04  Jody Goldberg <jgoldberg@home.com>
      
      	* src/gnumeric-sheet.c (rangesel_{horizontal,vertical}_move) : remove
      	  crufty use of ItemCursor::base.  The cursors have both corners now.
      c135fb90
    • Jody Goldberg's avatar
      Some work on range selection · 4a320299
      Jody Goldberg authored
      2001-01-04  Jody Goldberg <jgoldberg@home.com>
      
      	* src/item-cursor.c (item_cursor_event) : animated cursors can no be
      	  dragged or resized.   NOTE : This introduces a small bug while
      	  fixing another.  The animated cursor is frequently drawn on top of
      	  the current selection cursor when it is first created.  As such the
      	  selection cursor does not receive all the events it should.
      	  Ideally the canvas would pass ignored events to the widget below, but
      	  that is not going to happen.  We can not just forward the events to
      	  the other cursor because it may have moved.  We would need to ensure
      	  that we only forward things in the areas that are overlapping.  Which
      	  is not easy.
      	(item_cursor_set_spin_base) : delete.
      
      	* src/item-grid.c (item_grid_button_1) : support shift-extending a
      	  range selection cursor.
      
      	* src/workbook-view.c (wb_view_selection_desc) : Add some safety.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_rangesel_cursor_extend) :
      	  Intelligently handle extension to full rows/cols and rename from
      	  gnumeric_sheet_selection_extend.
      	(start_cell_selection_at) : no need to set the base a second time.
      	(gnumeric_sheet_rangesel_cursor_bounds) : rename from
      	  gnumeric_sheet_selection_cursor_place and allow the specification of
      	  base and move coords.
      	(gnumeric_sheet_selection_cursor_base) : delete.
      
      	* src/item-bar.c (is_pointer_on_division) : no resizing while range
      	  selecting.
      	(get_element_from_pixel) : delete dead code.
      
      2001-01-03  Jody Goldberg <jgoldberg@home.com>
      
      	* src/item-bar.c (item_bar_event) : Call scg_colrow_select directly.
      	  and convert from using 'is_vertical' to 'is_cols' which is the
      	  convention everywhere else.
      	(cb_extend_selection) : ditto.
      	(colrow_tip_setlabel) : ditto.
      	(item_bar_marshal) : delete.
      	(get_row_name) : fortify a bit.
      
      	* src/sheet-control-gui.c (scg_colrow_select) : merge together from
      	  sheet_view_{col,row}_selection_changed and rewrite.
      	(sheet_view_construct) : remove handlers for the item-bar signal.
      
      	* src/commands.c (cmd_autofill_redo) : check for array violations.
      	  Clear the target range.  This will allow entire arrays to be filled.
      	(cmd_autofill) : Use the area that we will be filling rather.  Excude
      	  the area that will not change.
      
      	* src/sheet.c (sheet_{col,row}_get_info) : simplify.
      
      	* src/selection.c (walk_boundaries) : don't walk into hidden cols/rows.
      4a320299
  11. 31 Dec, 2000 1 commit
  12. 25 Dec, 2000 1 commit
    • Jody Goldberg's avatar
      clean up includes. · 0ae4c759
      Jody Goldberg authored
      
      2000-12-25  Jody Goldberg <jgoldberg@home.com>
      
      	* src/ranges.h : clean up includes.
      0ae4c759
  13. 17 Dec, 2000 4 commits
    • Jody Goldberg's avatar
      fix cut-n-paste-o. (rangesel_vertical_move) : Ditto. · 861334d1
      Jody Goldberg authored
      
      2000-12-17  Jody Goldberg <jgoldberg@home.com>
      
      	* src/gnumeric-sheet.c (cursor_vertical_move) : fix cut-n-paste-o.
      	(rangesel_vertical_move) : Ditto.
      861334d1
    • Jody Goldberg's avatar
      support merged cells fully. (sheet_find_boundary_vertical) : Ditto. · 01660787
      Jody Goldberg authored
      
      2000-12-17  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_find_boundary_horizontal) : support merged cells
      	  fully.
      	(sheet_find_boundary_vertical) : Ditto.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_set_cursor_bounds) : Remove
      	  unnecessary sanity checks.
      	(cursor_horizontal_move) : pass the base row.
      	(cursor_vertical_move) : Ditto.
      	(rangesel_horizontal_move) : Ditto.
      	(rangesel_vertical_move) : Ditto.
      	(rangesel_horizontal_extend) : Ditto.
      	(rangesel_vertical_extend) : Ditto.
      
      	* src/selection.c (sheet_selection_extend) : Pass the base row/col.
      	* src/item-cursor.c (item_cursor_selection_event) : Ditto.
      01660787
    • Jody Goldberg's avatar
      no need to normalize. (sheet_cursor_set) : no need to normalize. · 523cc03f
      Jody Goldberg authored
      
      2000-12-17  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_new_sheet_view) : no need to normalize.
      	(sheet_cursor_set) : no need to normalize.
      
      	* src/item-cursor.c (item_cursor_set_bounds) : Add a notion of
      	  move_corner and base_corner.
      
      	* src/gnumeric-sheet.c
      	(cursor_horizontal_move) : renamed from move_cursor_horizontal.
      	(cursor_horizontal_extend) : renamed from move_horizontal_selection.
      	(cursor_vertical_move) : renamed from move_cursor_vertical.
      	(cursor_vertical_extend) : renamed from move_vertical_selection.
      	(gnumeric_sheet_selection_extend) : no need to normalize.  the
      	  item-cursor now does it for us.
      	(rangesel_horizontal_move) : renamed from selection_cursor_move_horizontal.
      	(rangesel_vertical_move) : renamed from selection_cursor_move_vertical.
      	(rangesel_horizontal_extend) : renamed from selection_expand_horizontal.
      	  Use the new item-cursor base/move corners.
      	(rangesel_vertical_extend) : renamed from selection_expand_vertical.
      	  Use the new item-cursor base/move corners.
      	(gnumeric_sheet_key_mode_sheet) : simplify.
      
      	* src/sheet.c (sheet_find_boundary_horizontal) : support merged cells.
      	(sheet_find_boundary_vertical) : ditto.
      	(sheet_set_edit_pos) : Add edit_pos vs edit_pos_real to improve merged
      	  cell support.
      	(sheet_region_get_merged_cell) : new function.
      
      	* src/gnumeric-sheet.c (move_cursor_horizontal) : Use edit_pos_real to
      	  improve handling for merged cells.
      	(move_cursor_vertical) : Ditto.
      	(start_cell_selection) : Ditto.
      523cc03f
    • Jody Goldberg's avatar
      support merged cells. (sheet_find_boundary_vertical) : ditto. · 17579c92
      Jody Goldberg authored
      
      2000-12-17  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_find_boundary_horizontal) : support merged cells.
      	(sheet_find_boundary_vertical) : ditto.
      	(sheet_set_edit_pos) : Add edit_pos vs edit_pos_real to improve merged
      	  cell support.
      	(sheet_region_get_merged_cell) : new function.
      
      	* src/gnumeric-sheet.c (move_cursor_horizontal) : Use edit_pos_real to
      	  improve handling for merged cells.
      	(move_cursor_vertical) : Ditto.
      	(start_cell_selection) : Ditto.
      
      2000-12-16  Jody Goldberg <jgoldberg@home.com>
      
      	s/Sheet::cursor::edit_pos/Sheet::edit_pos/
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_new) : No need to pass in the
      	  col/row items.  They are available from the sheet control.
      
      	* src/sheet-control-gui.c (sheet_view_construct) : signature change to
      	  gnumeric_sheet_new.
      17579c92
  14. 16 Dec, 2000 2 commits
    • Jody Goldberg's avatar
      No need to pass in the col/row items. They are available from the sheet · 5c96585d
      Jody Goldberg authored
      
      2000-12-16  Jody Goldberg <jgoldberg@home.com>
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_new) : No need to pass in the
      	  col/row items.  They are available from the sheet control.
      
      	* src/sheet-control-gui.c (sheet_view_construct) : signature change to
      	  gnumeric_sheet_new.
      5c96585d
    • Jody Goldberg's avatar
      Tidy up the naming scheme a bit. s/row_col/colrow/ s/col_row/colrow/ · 30c9841e
      Jody Goldberg authored
      
      2000-12-15  Jody Goldberg <jgoldberg@home.com>
      
      	Tidy up the naming scheme a bit.
      	s/row_col/colrow/
      	s/col_row/colrow/
      	s/SheetSelection/Range/
      
      	* src/workbook-cmd-format.c (workbook_cmd_resize_selected_colrow) :
      	  Merged from workbook_cmd_format_column_width and.
      	  & workbook_cmd_format_row_height
      
      	* src/item-bar.c (item_bar_end_resize) : Call scg_colrow_size_set
      	  directly.
      	(item_bar_class_init) : remove the SIZE_CHANGED signal.
      
      	* src/selection.c (sheet_selection_full_cols_rows) : merge
      	  sheet_selection_full_cols & sheet_selection_full_rows.
      30c9841e
  15. 15 Dec, 2000 1 commit
    • Jody Goldberg's avatar
      Move the span handling here. from here. · 17fb06d4
      Jody Goldberg authored
      
      2000-12-14  Jody Goldberg <jgoldberg@home.com>
      
      	* src/item-grid.c (item_grid_draw) : Move the span handling here.
      	* src/cell-draw.c (cell_draw) : from here.
      
      	* src/print-cell.c (print_cell_range) : Move the span handling here.
      	(print_cell) : rather than here.
      
      	* src/sheet-control-gui.c (scg_get_distance) : merge
      	  sheet_{row,col}_distance_get_pixels and make the result sheet
      	  control specific.
      
      2000-12-14  Jody Goldberg <jgoldberg@home.com>
      
      	* src/cell.c (cell_convert_expr_to_value) : rename from cell_make_value.
      
      	* src/format.c (format_number) : adjust signature to take the
      	  colwidth in preparation for supporting
      	(format_value) : pass in the width.
      
      2000-12-14  Jody Goldberg <jgoldberg@home.com>
      
      	* src/formats.c (currency_date_format_init) : correctly place currency
      	  before or after the value, and optionally include a space.
      
      	* src/format.c (format_get_currency) : include info on currency
      	  placement.
      
      2000-12-14  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook.c (workbook_sheet_rename) : Handle renames that only
      	  change case more smoothly.
      17fb06d4
  16. 09 Dec, 2000 1 commit
  17. 07 Dec, 2000 1 commit
    • Jody Goldberg's avatar
      Add some new icons · 850e9b36
      Jody Goldberg authored
      
      2000-12-07  Jody Goldberg <jgoldberg@home.com>
      
      	* src/application.c (application_init) : Add some new icons
      
      	* src/gnumeric.xml : Use the new icons
      	* src/workbook-control-gui.c : Ditto
      	* src/workbook-format-toolbar.c : Ditto.
      850e9b36
  18. 06 Dec, 2000 1 commit
    • Jody Goldberg's avatar
      new function. · 0c48da68
      Jody Goldberg authored
      
      2000-12-05  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_region_adjacent_merge) : new function.
      
      	* src/cellspan.c (cell_calc_span) : Use it here to pre bound the
      	  potential span region.
      
      2000-12-05  Jody Goldberg <jgoldberg@home.com>
      
      	* src/item-grid.c (item_grid_draw_merged_range) : Draw borders too.
      	  This can easily be optimized.
      
      	* src/selection.c (sheet_selection_add_range) : Use
      	  sheet_selection_set.
      0c48da68
  19. 05 Dec, 2000 1 commit
    • Jody Goldberg's avatar
      Init the selection descriptor and format format. (wb_view_selection_desc) · 20e35ce1
      Jody Goldberg authored
      
      2000-12-04  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook-view.c (wb_view_sheet_focus) : Init the selection
      	  descriptor and format format.
      	(wb_view_selection_desc) : new function.
      	(workbook_view_init) : Init the expression and format before setting
      	  the current sheet.  Setting the sheet will update the content.
      
      	* src/workbook-control.c (wb_control_sheet_add) : Init the format,
      	  edit line, and selection descriptor.
      
      	* src/selection.c (sheet_get_selection_name) : Delete.
      	(sheet_selection_extend_to) : Use wb_view_selection_desc.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_key_release) : Use
      	  wb_view_selection_desc.
      	* src/item-grid.c (item_grid_event) : Ditto.
      20e35ce1
  20. 01 Dec, 2000 1 commit
    • Jody Goldberg's avatar
      new function. (sheet_object_position_pixels) : new function. · f4cc38b8
      Jody Goldberg authored
      
      2000-12-01  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet-object.c (sheet_object_position_pts) : new function.
      	(sheet_object_position_pixels) : new function.
      
      2000-11-30  Jody Goldberg <jgoldberg@home.com>
      
      	* src/xml-io.c : Begin moving the sheet object xml io into virtuals.
      
      2000-11-30  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c : Add SHEET_FOREACH_CONTROL to help abstract the
      	  implementation of controls and simplify changes later.
      	(sheet_set_zoom_factor) : reposition objects not just comments.
      	(sheet_get_objects) : New function.
      
      2000-11-30  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet-object.c : Move most (not yet all) of the GUI aspects into
      	  the sheet control.  Revamp the semantics of the sheet-object
      	  virtuals.
      	new_view : now handles the sizing and realizing of objects.
      	Add support for persistance here.
      	Delete get/set bound.
      
      	* src/sheet-object-container.c : convert to new object management design
      	* src/sheet-object-graphic.c : Ditto.
      	* src/sheet-object-item.c : Ditto.
      	* src/sheet-object-widget.c : Ditto.
      
      	* src/sheet-object-bonobo.c (sheet_object_bonobo_construct) :
      	  sheet_object_construct now takes a default size.
      
      2000-11-30  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet-control-gui.c : Move cell comment and sheet object
      	  placement routines here.  Rather than scattering them in non-gui
      	  modules.
      
      2000-11-30  Jody Goldberg <jgoldberg@home.com>
      
      	* src/print.c (print_object_view_position) : Convert object position
      	  to points.
      
      	* src/selection.c (sheet_selection_redraw) : simplify.
      
      2000-11-30  Jody Goldberg <jgoldberg@home.com>
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_object) : SheetObject
      	  editing is now specific to the SheetControl.
      	(gnumeric_sheet_key_press) : Ditto.
      	(gnumeric_sheet_key_release) : Ditto.
      
      	* src/selection.c (sheet_is_cell_selected) : Ditto.
      	(sheet_col_selection_type) : Ditto.
      	(sheet_row_selection_type) : Ditto.
      
      	* src/item-bar.c (item_bar_draw) : Ditto.
      
      	* src/item-grid.c (item_grid_draw_background) : Ditto.
      	(item_grid_button_1) : Ditto.
      	(item_grid_event) : Ditto.
      	(cb_obj_create_motion) : Move the object creation GUI here.
      	(cb_obj_create_button_release) : and add partial support for
      	  autoscroll.
      	(sheet_object_begin_creation) : Ditto.
      
      2000-11-30  Jody Goldberg <jgoldberg@home.com>
      
      	* src/cell.c (cell_copy) : Comments are no longer associated directly
      	  with cells.
      	* src/clipboard.c (paste_cell) : Ditto.
      	(clipboard_release) : Ditto.
      
      	* src/bonobo-io.c (gnumeric_bonobo_obj_read) : No need to set bounds
      	  or realize the object here.  That is handed at a higher level.
      
      2000-11-30  Jody Goldberg <jgoldberg@home.com>
      
      	* src/number-match.c (compute_value) : Use strtol to simplify things.
      
      	* src/func.c (tokenized_help_new) : translate the help text.
      
      2000-11-27  Jody Goldberg <jgoldberg@home.com>
      
      	* src/formats.c (currency_date_format_init) : quote the currency
      	  names.
      f4cc38b8
  21. 20 Nov, 2000 1 commit
    • Jody Goldberg's avatar
      Use a more conventional approach to path seperators. Adjust here. · 982d6c10
      Jody Goldberg authored
      
      2000-11-20  Jody Goldberg <jgoldberg@home.com>
      
      	* configure.in : Use a more conventional approach to path seperators.
      	* src/gutils.c (gnumeric_usr_dir) : Adjust here.
      	(gnumeric_sys_data_dir) : and here.
      	(gnumeric_sys_lib_dir) : and here.
      
      2000-11-20  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_clone_selection) : Fix.
      
      	* src/item-grid.c (item_grid_draw_merged_range) : If the merged region
      	  is fully selected paint it as such.
      
      	* src/selection.c (sheet_is_full_range_selected) : new function.
      	(sheet_selection_set) : support merged cells.
      982d6c10
  22. 19 Nov, 2000 1 commit
    • Jody Goldberg's avatar
      : (sheet_region_unmerge) : (sheet_region_merge) : implement. · 4da5da9f
      Jody Goldberg authored
      
      2000-11-19  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_region_is_merge_cell) :
      	(sheet_region_get_merged) :
      	(sheet_region_unmerge) :
      	(sheet_region_merge) : implement.
      
      2000-11-19  Jody Goldberg <jgoldberg@home.com>
      
      	* src/item-grid.c (item_grid_draw_merged_range) : new function.
      	  This may be clearer if we draw the grid lines after the background.
      	  It does not support borders or selection yet.
      	(item_grid_draw) : Use it.
      
      2000-11-19  Jody Goldberg <jgoldberg@home.com>
      
      	* src/cellspan.c (cell_is_empty) : new utility function.
      	  span calculation is now rather inefficent.  We could be smarter if
      	  we had a better representation of spans.  For now adding support for
      	  merged cells here would be enough.
      	(cell_calc_span) : Use it.
      
      	* src/cell-draw.c (cell_draw) : decrease dependence on
      	  Cell::{col,row})_info::size_pixels.  This is not accurate for merged
      	  cells.  More work is needed.  I have not converted the multiline
      	  formating yet.  The signature of this function sucks.
      	  We should pass in either span or width height, not both.
      
      	* src/print-cell.c (print_cell) : Stay consistent with cell_draw.
      	  NOTE : I have not ported over the merged cell support.  It seems
      	  pointless until it is working completely for drawing.
      
      2000-11-19  Jody Goldberg <jgoldberg@home.com>
      
      	* s/sheet_view/scg/
      
      	* src/formats.c (currency_symbols) : Add the slovenian tolar.
      
      2000-11-16  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet-control-gui.c (scg_context_menu) : renamed from
      	  item_grid_popoup_menu and moved here where it makes more sense.
      4da5da9f
  23. 17 Nov, 2000 1 commit
    • Jody Goldberg's avatar
      Add config test. Implement test here. and here. · cac9224e
      Jody Goldberg authored
      
      2000-11-16  Jody Goldberg <jgoldberg@home.com>
      
      	* src/format.c (format_month_before_day) : Add config test.
      	* configure.in : Implement test here.
      	* config.h.in : and here.
      
      2000-11-15  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_update_only_grid) : split from sheet_update.
      	(sheet_update) : call sheet_update_only_grid.
      cac9224e
  24. 15 Nov, 2000 2 commits
    • Morten Welinder's avatar
      Remove trailing white-space from files that have it. · 5570aef3
      Morten Welinder authored
      (The following command was done in src/ and plugins/.  Note, that the
      grep has a space and a tab.)
      
      for i in `find . -name '*.[ch]' -print`; do if grep '[         ]$' $i >/dev/null; then echo $i; perl -pi -e 's/[ \t]+$//' $i; fi; done
      5570aef3
    • Jody Goldberg's avatar
      Follow convention that the manager is set when attached, and not before. · ad531019
      Jody Goldberg authored
      
      2000-11-15  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook-control.c (workbook_control_set_view) : Follow
      	  convention that the manager is set when attached, and not before.
      	* src/workbook-view.c (wb_view_attach_control) : Ditto.  Set the
      	  tile on the new control.
      	* src/workbook.c (workbook_attach_view) : Ditto.
      
      2000-11-15  Jody Goldberg <jgoldberg@home.com>
      
      	* src/command-context-corba.[ch] : This is incorrectly named and used
      	  the wrong way :-( But at least it is compilable.  I'll fix this
      	  later.
      
      2000-11-15  Jody Goldberg <jgoldberg@home.com>
      
      	* src/colrow.c (col_row_foreach) : Use ColRowSegments
      	(col_row_restore_sizes) : Ditto.
      	* src/sheet.c (sheet_{col,row}_add) : Ditto.
      	(sheet_{col,row}_get_info) : Ditto.
      	(sheet_{col,row}_get) : Ditto.
      	(sheet_cell_foreach_range) : Ditto.
      	(sheet_{col,row}_destroy) : Ditto.
      	(sheet_regen_adjacent_spans) : Ditto.
      	(colrow_move) : Ditto.
      	(sheet_{col,row}_get_distance_pixels) : Ditto.
      	(sheet_{col,row}_get_distance_pts) : Ditto.
      	(sheet_{col,row}_set_size_pts) : Ditto.
      
      2000-11-15  Jody Goldberg <jgoldberg@home.com>
      
      	s/sheet-view/sheet-control-gui/
      
      	* src/Makefile.am : Add command-context-corba.[ch] temporarily
      
      	* configure.in : Default to non-bonobo build
      ad531019
  25. 09 Nov, 2000 2 commits
    • Morten Welinder's avatar
      gmorten poors syrup into Miguel's keyboard. · d56b90d7
      Morten Welinder authored
      * gmorten poors syrup into Miguel's keyboard.
      d56b90d7
    • Jody Goldberg's avatar
      Initialize fully, add prepared_to_drag_flag. (item_cursor_selection_event) · a3602968
      Jody Goldberg authored
      
      2000-11-08  Jody Goldberg <jgoldberg@home.com>
      
      	* src/item-cursor.c (item_cursor_init) : Initialize fully, add
      	  prepared_to_drag_flag.
      	(item_cursor_selection_event) : Move most of the state change
      	  associated with BUTTON_PRESS into MOTION_NOTIFY.  And use the
      	  prepared_to_drag_flag flag to indicate a requirement to initiate a
      	  drag. Move most of the double click handling here.  The resone for
      	  these changes was that there was a race condition in the old
      	  version.  We were creating a new item cursor when we did a button
      	  press.  It started in exactly the same position as the current
      	  cursor.  2BUTTON_PRESS were sometimes being sent to the new cusor
      	  and sometimes showing up as PRESS events on the old with no RELEASE.
      	  This patch attempts to delay creating the new drag cursor until we
      	  are sure this is not a double click so that the proper event
      	  sequence is sent to the main cursor.
      
      	* src/border.c (style_border_unref) : Unref the colour.
      	(style_border_fetch) : unref the colour when needed.
      a3602968
  26. 01 Nov, 2000 2 commits
    • Jody Goldberg's avatar
      Set the position to where we expect it to be. · 4dd6af23
      Jody Goldberg authored
      
      2000-11-01  Jody Goldberg <jgoldberg@home.com>
      
      	* src/gnumeric-sheet.c (selection_insert_selection_string) :
      	  Set the position to where we expect it to be.
      	(gnumeric_sheet_key_mode_sheet) : Only call sheet_update if we are not editing.
      
      2000-11-01  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_name_quote) : names with parethesis require quotes.
      4dd6af23
    • Jody Goldberg's avatar
      bug 30338 · d129f42a
      Jody Goldberg authored
      2000-11-01  Jody Goldberg <jgoldberg@home.com>
      
      	* */*.[ch] : s/SheetView::sheet_view/SheetView::canvas/
      	  This has been bugging me for months.
      
      	* src/gnumeric-sheet.c (move_cursor) : stop the edit at this level
      	  rather than in sheet_cursor_set.
      	(gnumeric_sheet_key_mode_sheet) : Use move_cursor.
      d129f42a
  27. 31 Oct, 2000 1 commit
    • Jody Goldberg's avatar
      Set LC_MONETARY and LC_NUMERIC. Ditto. (xml_workbook_read) : Ditto. · ffac72f5
      Jody Goldberg authored
      
      2000-10-31  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook-view.c (wb_view_auto_expr) : Set LC_MONETARY and
      	  LC_NUMERIC.
      	* src/xml-io.c (xml_workbook_write) : Ditto.
      	(xml_workbook_read) : Ditto.
      
      2000-10-31  Jody Goldberg <jgoldberg@home.com>
      
      	* src/dialogs/*.[ch] : WorkbookControlGUI is now required for gui
      	  operations.  A WorkbookView is required to know which sheet is the
      	  current.
      
      	* src/xml-io.c : We now load/save WorkbookViews.
      
      	* src/xml-io-autoft.c : Adjust to signature changes.
      
      	* src/workbook.c : Split the View into WorkbookView.
      	  Abstract the Controler interface, and move the GUI specific
      	  implementation of the Controler into WorkbookControlGUI.
      
      	* src/workbook-view.c : Complete rewrite with correct semantics.
      
      	* src/workbook-private.h : Move all the GUI specific stuff into
      	  WorkbookControlGUI were it belongs.
      
      	* src/workbook-private.c (workbook_private_class_init) : Fix typo.
      
      	* src/workbook-edit.c : These are now WorkbookControlGUI specific.
      	  We should rename the functions eventually.
      	* src/workbook-format-toolbar.c : Ditto.
      	* src/workbook-object-toolbar.c : Ditto.
      
      	* src/workbook-cmd-format.c : Adjust to signature changes.
      	  and use WorkbookControlGUI were necessary.
      
      	* src/style.c (style_font_new_from) : Delete dead code.
      
      	* src/solver-lp.c : Adjust to signature changes.
      	* src/sort.c : Ditto.
      	* src/stf.c : Ditto. Make dialog conditional on gui-ness.
      
      	* src/sheet.c (sheet_new_sheet_view) : IS_SHEET checks for NULL.
      	(sheet_detach_sheet_view) : renamed from sheet_destroy_sheet_view
      	  and only take a SheetView as argument.
      	(sheet_new) : Do not create a view by default.
      	(sheet_update_zoom_controls) : foreach control.
      	(sheet_update_editpos) : ditto.
      	(sheet_update) : handle multiple views and controls.
      
      	* src/sheet-view.c : Commands take WorkbookControls rather than
      	  CommandContexts.
      
      	* src/sheet-object-widget.c : Most things take WorkbookControlGUI
      	  rather than Workbooks.
      
      	* src/sheet-object-container.c (sheet_object_container_new_view) :
      	  Use the uic from the WorkbookControlGUI.
      
      	* src/sheet-control.c : New file. Unused so far.
      	  cp sheet-view.c sheet-control.c
      	  s/SheetView/SheetControl/
      
      	* src/print.c : Make the GUI dependency explicit.
      	  At some point the setup dialog should be split out of here.
      
      	* src/main.c (gnumeric_main) : Explicitly create a WorkbookControlGUI
      	  only adding sheets if nothing was loaded.  Improve handing of exit
      	  request while loading.
      
      	* src/item-grid.c (item_grid_draw) : Filter the edit cell from here
      	  because we know which control to use.
      	(context_menu_hander) : Switch to WorkbookControlGUI.
      	(item_grid_popup_menu) : Ditto.
      
      	* src/item-edit.c : Everything takes a WorkbookControlGUI inplace of a
      	  Workbook now.
      
      	* src/item-cursor.c (item_cursor_target_region_ok) : dialog_run takes
      	  a WorkbookControlGUI.
      	(item_cursor_do_action) : All the commands take WorkbookControls.
      
      	* src/item-bar.c (item_bar_event) : item_grid_popup_menu takes a
      	  SheetView now.
      
      	* src/history.c : Take WorkbookControlGUI.
      	  Update all controls for each workbook.
      
      	* src/gui-clipboard.c : Use 'unsigned char'
      
      	* src/gnumeric.xml : More work to split commands from layout.
      
      	* src/gnumeric-util.c (gnumeric_no_modify_array_notice) : Delete.
      	(gnumeric_notice) : Take a WorkbookControlGUI.
      	(gnumeric_wb_dialog_run) : Ditto.
      	(gnumeric_dialog_run) : Ditto.
      	(gnumeric_dialog_show) : Ditto.
      	(gnumeric_set_transient) : Ditto.
      	(gnumeric_glade_xml_new) : Ditto.
      	(gnumeric_non_modal_dialog) : Ditto.
      	(gnumeric_inject_widget_into_bonoboui) : Ditto.
      
      	* src/gnumeric-sheet.c : SheetView now has a WorkbookControlGUI member
      	  to keep track of which control it is associated with. Use it.
      
      	* src/file.c : Adjust to lots of signature changes.
      	  We now load/save WorkbookView rather than Workbook.
      	  Add a placeholder struct IOContext so that we can consider doing
      	  smarter import/export and dealing with warnings and missing things
      	  smoothly.
      
      	* src/eval.c (workbook_recalc_all) : After a recalc update all views.
      
      	* src/commands.c (undo_redo_menu_labels) : foreach control.
      	(command_undo) : ditto.
      	(command_redo) : ditto.
      	(command_push_undo) : change signature.  The workbookcontrol
      	  now acts as the command context.
      
      	* src/cmd-edit.c : Adjust to signature changes.
      
      	* src/clipboard.c : split the gui specific X handlers out into a new
      	  file.
      	* src/gui-clipboard.c :  here.
      
      	* src/cell-draw.c (cell_draw) : Do not test the sheet for whether or
      	  not to we are editing.  That is at the control level.  Test it in
      	  the rendering loop.
      
      	* src/bonobo-io.c : FIXME. adjusted to signature changes.  Totatly
      	  broken for now.  This needs a View rather than a Model and should be
      	  associated with something.
      
      	* src/application.c (application_workbook_list_add) : New function.
      	(application_workbook_list_remove) : New function.
      	(application_workbook_list) : New function.
      	(application_clipboard_copy) : foreach control.
      	(application_clipboard_cut) : foreach control.
      	(application_clipboard_clear) : foreach control.
      	(application_workbook_foreach) : renamed from workbook_foreach.
      	(application_set_selected_sheet) : FIXME. Disabled for now.
      
      	* src/about.c (cb_closed) : Associated the flag with the control
      	  directly.
      	(dialog_about) : dialogs are associated with gui-controls.
      
      	* src/analysis-tools.c : change all dialog signatures to handle MVC
      	  split of workbook.
      
      2000-10-30  Jody Goldberg <jgoldberg@home.com>
      
      	* src/Makefile.am : Add new command-context,  io-context,
      	  workbook-view, workbook-control, workbook-control-gui files.
      	  Remove old command-context-gui, command-context-corba, and disable
      	  corba-* for now.
      
      2000-10-29  Jody Goldberg <jgoldberg@home.com>
      
      	* idl/gnumeric-graphs.idl : Remove studdly caps.  I wish people would
      	  make up their minds.
      
      	* idl/Gnumeric.idl : Remove Workbook::show.
      
      2000-10-29  Jody Goldberg <jgoldberg@home.com>
      
      	* BUGS : Update.
      	* NEWS : Update.
      	* TODO : Update.
      ffac72f5
  28. 28 Sep, 2000 1 commit
    • Jody Goldberg's avatar
      Use bonobo_object_unref rather than bonobo_object_client_unref. · 765fdd37
      Jody Goldberg authored
      
      2000-09-28  Jody Goldberg <jgoldberg@home.com>
      
      	* src/dialogs/dialog-graph-guru.c (graph_guru_state_destroy) : Use
      	  bonobo_object_unref rather than bonobo_object_client_unref.
      	(cb_graph_guru_clicked) : On success clear the State's pointer to the
      	  manager so that it does not get deleted.
      	(graph_manager_destroy) : new routine to clear out the remote manager.
      	(graph_guru_init_manager) : Use it.
      
      	* src/workbook.c (cut_cmd) : Delete the object explicitly.
      	* src/sheet-object.c (sheet_object_remove_cb) : Ditto.
      
      	* src/sheet-object-container.c (view_destroyed) : rename from
      	  item_destroy to clarify its function.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_object) : Add
      	  KP_Delete.  There is no need to change the mode and clear anything.
      	  The sheet_object destructor takes care of it.
      765fdd37
  29. 24 Sep, 2000 1 commit
    • Jody Goldberg's avatar
      Suppress some warnings and make non-bonobo build clean. · a9a20284
      Jody Goldberg authored
      2000-09-24  Jody Goldberg <jgoldberg@home.com>
      
      	* src/normal-args.c : Suppress warning.
      
      	* src/functions/fn*.c : Add a prototype of the _init routine to
      	  suppress warning.
      
      	* src/eval.c (cell_recalc_dependencies ) : Comment out until it is
      	  implemented.
      
      	* src/sheet-object-widget.c (sheet_object_widget_new) : delete.
      a9a20284
  30. 22 Sep, 2000 1 commit
    • Jody Goldberg's avatar
      redraw the selection. redraw the selection. · fafbc8cf
      Jody Goldberg authored
      
      2000-09-21  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_hide_cursor) : redraw the selection.
      	* src/sheet.c (sheet_show_cursor) : redraw the selection.
      
      	* src/sheet-object.c : Improve framework for editing/creating objects.
      	  We are more consistent about hiding the selection, and when to make
      	  things visible again.
      
      	* src/sheet-object-widget.c : Begin framework for configuring the
      	  sheet widgets.
      
      	* src/selection.c (sheet_selection_redraw) : new function.
      
      	* src/item-grid.c (item_grid_button_1) : Don't cancel object editing
      	  if there is a guru up.  We could be configuring things.
      
      	* src/selection.c (sheet_is_cell_selected) : Do no show selections
      	  while objects are being edited.
      
      	* src/gnumeric-util.c (gnumeric_non_modal_dialog) : Change the
      	  signature.
      
      	* src/sheet-object.c (sheet_object_destroy) : Improve safety.
      fafbc8cf
  31. 20 Sep, 2000 1 commit
    • Jody Goldberg's avatar
      We always create an in canvas edit item, but sometimes we jump the focus · 9fc2db80
      Jody Goldberg authored
      
      2000-09-20  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook-edit.c (workbook_start_editing_at_cursor) : We always
      	  create an in canvas edit item, but sometimes we jump the focus to
      	  the status line.
      
      	* src/value.c (value_new_cellrange_r) : set the sheet for both
      	  cell_refs.
      
      	* src/sheet-object-widget.c (checkbox_set_expr) : Fix.
      
      	* src/graph-series.c (graph_series_seq_scalar) : No need to handle
      	  headers here.
      	(graph_series_seq_date) : or here.
      	(graph_series_seq_string) : or here.
      	(graph_series_eval) : Handle idl rename.
      	(series_get_name) : No need to do this here.
      	(impl_vector_scalar_value) : No need to calculate label.
      	(impl_vector_date_value) : Ditto.
      	(impl_vector_string_value) : Ditto.
      	(graph_series_set_expr) : Correctly register and un register deps.
      	(graph_series_new) : series names are handled at a higher level.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) : Restore the
      	  behaviour of F2.
      
      	* src/expr.c (cellrange_relocate) : BE smarter about checking for
      	  potential 3d references.
      
      	* idl/gnumeric-graphs.idl : Rename routines using lowercase underscore
      	  rather than StuddyCaps.
      
      	* src/workbook.c (workbook_expr_relocate) : Handle dependents.
      
      	* src/position.c (eval_pos_init_dep) : new function.
      
      	* configure.in : Prepare for release.
      	  Update req for gnome-print to 0.23
      	  Update req for libglade to 0.14
      	  Comment out pspell.
      	  Leave perl disabled.
      
      	* gnumeric.spec.in : Ditto.
      	* README : Ditto.
      
      2000-09-19  Jody Goldberg <jgoldberg@home.com>
      
      	* src/xml-io.c (natural_order_cm) : Using col_info and row_info is
      	  deprecated.
      9fc2db80
  32. 19 Sep, 2000 1 commit
    • Jody Goldberg's avatar
      Bug 24122 · 62fd10ba
      Jody Goldberg authored
      2000-09-18  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_flag_status_update_cell) : Adjust signature.
      
      2000-09-18  Jody Goldberg <jgoldberg@home.com>
      
      	* dialog-solver.c (dialog_solver) : No need to create a cell manually
      	  and fill with empty.  sheet_cell_fetch will handle that.
      
      	* dialog-goal-seek.c (dialog_goal_seek) : No need to create cell
      	  locally.
      	(gnumeric_goal_seek) : Update size, span, and status region for the
      	  cell that was being tweaked.  While solving we did not update it.
      62fd10ba