1. 12 Aug, 2000 1 commit
    • Jody Goldberg's avatar
      Add graph-guru for bonobo enabled builds. · c665e798
      Jody Goldberg authored
      
      2000-08-11  Jody Goldberg <jgoldberg@home.com>
      
      	* src/dialogs/Makefile.am : Add graph-guru for bonobo enabled builds.
      
      	* src/dialogs/formula-guru.glade (rolled_label) : Don't fill.
      
      2000-08-11  Jody Goldberg <jgoldberg@home.com>
      
      	* src/functions/fn-math.c (gnumeric_g_product) : Ignore blanks.
      	(gnumeric_product) : Ditto.
      	(gnumeric_sumsq) : Ditto.
      	(gnumeric_suma) : Ditto.
      	(gnumeric_sum) : Ditto.
      	(gnumeric_gcd) : Ditto.
      
      2000-08-11  Jody Goldberg <jgoldberg@home.com>
      
      	* src/corba-args.c : Remove support for Gnorba. Die Pig Die !
      	* src/corba-workbook-factory.c : Ditto.
      	* src/embeddable-grid.c : Ditto.
      	* src/sheet-object.c : Ditto.
      	* src/workbook.c : Ditto.
      
      	* src/cell-comment.c (cell_comment_realize) : Use Cell::pos rather
      	  than Cell::{row,col}_info->pos.
      	(cell_comment_reposition) : Ditto.
      	* src/cell-draw.c (cell_draw) : Ditto.
      	* src/cellspan.c (cell_register_span) : Ditto.
      	(cell_calc_span) : Ditto.
      	* src/clipboard.c (paste_cell_with_operation) : Ditto.
      	(paste_cell) : Ditto.
      	* src/cmd-edit.c (cb_compare_deps) : Ditto.
      	(cmd_select_cur_depends) : Ditto.
      	* src/eval.c (dependency_range_ctor) : Ditto.
      	(handle_cell_single_dep) : Ditto.
      	(handle_cell_range_deps) : Ditto.
      	(cell_get_range_dependencies) : Ditto.
      	(cell_get_dependencies) : Ditto.
      	* src/item-grid.c (item_grid_draw) : Ditto.
      	* src/parse-util.c (cell_name) : Ditto.
      	* src/position.c (eval_pos_init_cell) : Ditto.
      	* src/print-cell.c (print_cell) : Ditto.
      	(print_cell_range) : Ditto.
      	* src/sheet-autofill.c (autofill_cell) : Ditto.
      	* src/sheet-vector.c (sheet_vectors_cell_changed) : Ditto.
      	* src/sheet.c (sheet_cell_calc_span) : Ditto.
      	(sheet_reposition_comments) : Ditto.
      	(sheet_get_extent_cb) : Ditto.
      	(sheet_redraw_cell) : Ditto.
      	(sheet_cell_add_to_hash) : Ditto.
      	(sheet_cell_insert) : Ditto.
      	(sheet_cell_new) : Ditto.
      	(sheet_cell_remove_from_hash) : Ditto.
      	(sheet_move_range) : Ditto.
      	* src/solver-lp.c (solver_simplex) : Ditto.
      	(make_solver_arrays) : Ditto.
      	(solver_affine_scaling) : Ditto.
      	(make_int_array) : Ditto.
      	(solver_branch_and_bound) : Ditto.
      	(solver_answer_report) : Ditto.
      	(solver_sensitivity_report) : Ditto.
      	* src/xml-io.c (xml_write_cell) : Ditto.
      	(xml_cell_set_array_expr) : Ditto.
      	(xml_write_solver) : Ditto.
      	* src/dialogs/dialog-solver.c (check_int_constraints) : Ditto.
      
      	* src/about.c : Move the ABOUT_KEY here from.
      	* src/dialogs/dialogs.h : here.  Also, add dialog_graph_guru.
      
      	* src/Makefile.am : Remove wizard.h and the seperate wizard library.
      c665e798
  2. 10 Jul, 2000 1 commit
    • Jody Goldberg's avatar
      Bug 16860 A few portability problems. · 7b8afaf0
      Jody Goldberg authored
      Bug 16860
      A few portability problems.
      
      2000-07-09  Jody Goldberg <jgoldberg@home.com>
      
      	* src/history.c (history_menu_item_create) : Fix.
      
      	* src/stf-parse.c (stf_parse_options_before_modification) : Simplify
      	  for irix compiler.
      
      	* src/print-info.c (print_info_new) : cellrange is a ValueRange.
      	(save_range) : Ditto.
      	* src/dialogs/dialog-printer-setup.c (do_setup_page_info) : Ditto.
      	(do_fetch_page_info) : Ditto.
      7b8afaf0
  3. 06 Jul, 2000 1 commit
    • Jody Goldberg's avatar
      bug 16490. We were attempting to display the entered text rather than the · 2a420f79
      Jody Goldberg authored
      bug 16490.
      We were attempting to display the entered text rather than the formated text
      and falling over when the copied cell had no sheet.  This is not lovely, but it
      is as clean as we'll get for now.
      
      2000-07-06  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet-style.c (sheet_style_compute_from_list) : Make public.
      	  and rename from sheet_mstyle_compute_from_list.  Changed all
      	  callers.
      
      	* src/rendered-value.c (rendered_value_new) : Optionaly take a style
      	  list.  Use it if offered.
      
      	* src/cell.c (cell_render_value) : New signature for rendered_value_new.
      
      	* src/render-ascii.c (cell_region_render_ascii) : Temporarily reverse
      	  the style list so that it goes in the correct direction.   Use
      	  rendered_value not entered_text.
      
      	* src/clipboard.c (clipboard_prepend_cell) : Init the Cell::pos with
      	  the offsets.  This is useful in when looking up formats.
      2a420f79
  4. 03 Jul, 2000 1 commit
    • Morten Welinder's avatar
      Don't add one to the number of lines if the last line is empty. · 332034ff
      Morten Welinder authored
      2000-07-03  Morten Welinder  <terra@diku.dk>
      
      	* src/stf-parse.c (stf_parse_get_rowcount): Don't add one to the
       	number of lines if the last line is empty.
      
      	* src/sheet.c (sheet_cell_set_text): Plug leak.
      
      	* src/workbook-format-toolbar.c
       	(do_sheet_selection_apply_number_format): Avoid double translation
       	of format.
      
      	* src/mstyle.c (mstyle_set_format_text): Renamed from
       	mstyle_set_format.
      	(mstyle_set_format): New function taking a StyleFormat *.
      332034ff
  5. 28 Jun, 2000 1 commit
    • Jody Goldberg's avatar
      new function. · 93f11589
      Jody Goldberg authored
      
      2000-06-28  Jody Goldberg <jgoldberg@home.com>
      
      	* src/functions/fn-sheet.c (GNUMERIC_VERSION) : new function.
      
      	* src/workbook.c (workbook_do_destroy) : No need to release the
      	  clipboard here.  The Sheet does it for us.
      
      	* src/workbook-format-toolbar.c : Add Fill to the default money
      	  format.
      
      	* src/symbol.c : The only symbols are functions.  The global table
      	  should not be world visible.
      
      	* src/sheet.c (sheet_flag_status_update_cell) : Take a CellPos.
      	(sheet_get_extent_cb) : Use Cell::pos rather than adding an
      	  indirection.
      	(cb_set_cell_content) : Use StyleFormat.
      	(sheet_cell_set_value) : Call sheet_flag_status_update_cell.
      	(sheet_cell_set_value) : Ditto.
      	(sheet_destroy) : Prepare to clear out named expressions.
      	(colrow_move) : Handle changes in cell_relocate signature.
      	(sheet_move_range) : Ditto.
      
      	* src/sheet-autofill.c : Use StyleFormats.
      
      	* src/position.c (parse_pos_init) : Global position are permitted.
      
      	* src/parser.y : Large change.  Do not automaticlly look for function
      	  names or named expressions in the lexer.  The lexer returns STRING
      	  and QUOTED_STRING.  The parser then does the appropriate lookups to
      	  potentially convert to something else.  This allows us to have sheet
      	  names that are the same as functions.
      
      	* src/parse-util.c (cellref_name) : Add flag to optionally disable the
      	  addition of the sheet name.  This is useful when printing
      	  Sheet2!A1:A3 rather than Sheet2!A1:Sheet2!A3.
      
      	* src/number-match.c (format_create_regexp) : Handle fill formats.
      
      	* src/mstyle.c (mstyle_get_border) : Fix constness.
      
      	* src/mathfunc.c (combin, fact) : Moved these here from
      	  functions/fn-math.c
      
      	* src/main.c (gnumeric_main) : No more constants_init, or
      	  global_symbol_init.
      
      	* src/func.c () : Reorg.  Remove some dead code.  Begin adding
      	  workbook local function support, Begin adding volatile, and
      	  semi-volatile functions.  Move the use of SymbolTable internal
      	  in preparation for eliminating it.
      
      	* src/format.c (format_number) : Improve support for pound, yen, and euro.
      	  Remember to produce a number when we hit spacing.
      
      	* src/expr.c : Have ExprFunc refer directly to the FunctionDefinition
      	  We still use a SymbolTable internally, but that will be merged out
      	  later.
      
      	* src/expr-name.c : Major reorg.  Not complete.
      
      	* src/corba-sheet.c (fill_corba_value) : Adjust to changes in
      	  cellref_name signature.
      
      	* src/commands.c (cmd_set_date_time_undo) : No need to manually call
      	  update_cell_flag.  cell_remove, and cell_set_text do that for us.
      	(cmd_set_date_time_redo) : Ditto.
      	  Use StyleFormat.
      
      	* src/clipboard.c (paste_cell) : Take the ExprRewriteInfo as an
      	  argument.
      	(clipboard_paste_region) : Init the ExprRewriteInfo.  We need to do
      	  this here rather than in cell_relocate because we may be moving a
      	  region, not just a single cell, and references within the region
      	  should not be changed.
      
      	* src/cell.c (cell_relocate) : Take the relocation info as an
      	  argument.  Non NULL indicates a request to check bounds.  We can not
      	  do this at the cell level. becuase we may be moving a block rather
      	  than just a single cell, and references into the block should NOT be
      	  rewritten.
      	(cell_set_text_and_value) : Take a StyleFormat.
      	(cell_assign_value) : Ditto.
      	(cell_set_value) : Ditto.
      	(cell_set_expr_internal) : Ditto.
      	(cell_set_expr_unsafe) : Ditto.
      	(cell_set_expr) : Ditto.
      
      	* src/auto-format.c (do_af_suggest) : Expression now refers directly
      	  to functionDef.
      93f11589
  6. 20 Jun, 2000 1 commit
    • Jody Goldberg's avatar
      We need to manually trigger a changed event after setting the position · 739a6dc7
      Jody Goldberg authored
      2000-06-19  Jody Goldberg <jgoldberg@home.com>
      
      	* dialog-function-wizard.c (formula_guru_set_expr) : We need to
      	  manually trigger a changed event after setting the position becuase
      	  pre-gtk-1.4 setting the text reset the cursor position to 0.
      	(cb_formula_guru_entry_event) : new function.
      	(cb_formula_guru_rolled_entry_event) : new function.
      
      
      2000-06-19  Jody Goldberg <jgoldberg@home.com>
      
      	* src/eval.c (invalidate_refs) : const.
      	(do_deps_destroy) : const.
      
      	* src/cell.c (cell_set_expr_internal) : Be careful about unrefing.
      
      	* src/item-edit.c (entry_event) : Rather than catching 'event' and
      	  checking for the type of event we want.  Catch the events directly.
      	  That way the events can take place BEFORE we look for our position.
      739a6dc7
  7. 06 Jun, 2000 1 commit
    • Jody Goldberg's avatar
      silence a few warnings. · 8adf2128
      Jody Goldberg authored
      Fix a problem with the new expr_relocate flag for pasting when soring.
      
      2000-06-05  Jody Goldberg <jgoldberg@home.com>
      
      	* src/cell.c (cell_relocate) : when relocating the expression
      	  be careful to use the offsets when calculating the validity.
      
      	* src/workbook-edit.c (workbook_auto_complete_destroy) : Only remove
      	  signal if it has been activated.  Only delete the completer if it
      	  exists.
      8adf2128
  8. 05 Jun, 2000 1 commit
    • Jody Goldberg's avatar
      renamed from sheet_cell_formula_{link,unlink}. · 7f94ba9e
      Jody Goldberg authored
      
      2000-06-05  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_cell_expr_{link,unlink}) : renamed from
      	  sheet_cell_formula_{link,unlink}.
      
      	* src/cell.c (cell_relocate) : Doh! use the offset flags now that they
      	  are being passed.
      
      	* src/clipboard.c (paste_cell) : Renamed from paste_cell_flags.
      
      	* src/expr.c (compare) : value_is_empty_cell -> VALUE_IS_EMPTY.
      
      	* src/value.c (VALUE_IS_EMPTY) : rename from value_is_empty_cell.
      
      	* src/sheet-private.h : Add resize_scrollbar.
      
      	* src/sheet.c (sheet_{col,row}_add) : Use resize_scrollbar flag rather
      	  than manually updating the scrolling bar.
      	(sheet_update) : Handle resize_scrollbar.
      	(sheet_cell_expr_link) : renamed from sheet_cell_formula_link.
      	(sheet_cell_expr_unlink) : renamed from sheet_cell_formula_unlink.
      7f94ba9e
  9. 04 Jun, 2000 1 commit
    • Jody Goldberg's avatar
      Set the CELL_IN_SHEET_LIST flag. (sheet_cell_remove_from_hash) : Clear the · c6a63d53
      Jody Goldberg authored
      
      2000-06-04  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_cell_add_to_hash) : Set the CELL_IN_SHEET_LIST
      	  flag.
      	(sheet_cell_remove_from_hash) : Clear the CELL_IN_SHEET_LIST flag.
      	(cb_remove_allcells) : Ditto.
      	(sheet_cell_formula_link) : Set the CELL_IN_EXPR_LIST flag.
      	(sheet_cell_formula_unlink) : Clear the CELL_IN_EXPR_LIST flag.
      	(sheet_formulas_unlink) : Ditto.
      
      	* src/clipboard.c (paste_cell_flags) : Take some additional arguments
      	  so that pasted cells can potentially have their references made
      	  invariant, this is for sorting.
      	(clipboard_paste_region) : Pass the additional offsets when
      	  PASTE_EXPR_RELOCATE is specified.
      	(append_cell_closure_t) : Delete this type.  Move the origin cell info
      	  into CellRegion.
      
      	* src/cell.c (cell_copy) : Clear the sheet and associated flags for
      	  the copied cell.  This avoids accidentally realizing comments that
      	  become undeletable.
      	(cell_relocate) : Remove the unlink flag now that we have the
      	  additional cell_flags.
      c6a63d53
  10. 24 May, 2000 2 commits
    • Morten Welinder's avatar
      Style now needs to be initialised before formats. · 169f4952
      Morten Welinder authored
      2000-05-24  Morten Welinder  <terra@diku.dk>
      
      	* src/main.c (gnumeric_main): Style now needs to be initialised
       	before formats.
      
      	* src/number-match.c (format_match): Take a StyleFormat ** instead
       	of a char ** for the suggested format.  All callers changed.
      	(format_parse_t): rename member format to format_str and
       	introduce new member format, a StyleFormat *.
      	(format_match_define): Get a style at this point.
      
      	* src/datetime.c (datetime_value_to_serial_raw): Don't supply a
       	format return variable to format_match since we aren't interested
       	in the result.
      
      	* src/parse-util.c (parse_text_value_or_expr): Return a
       	StyleFormat * instead of a char *.  All callers changed.
      
      	* src/expr.c (expr_parse_string): Take a StyleFormat ** instead of
       	a char ** for the suggested format.  All callers changed.
      
      	* src/parser.y (make_string_return): Turn parser_desired_format
       	into a StyleFormat **.
      	(gnumeric_expr_parser): Take a StyleFormat ** instead of a char **
       	for the suggested format.  All callers changed.
      
      	* src/auto-format.c (auto_style_format_suggest): New function.
      
      
      	* src/sheet-style.c (sheet_style_optimize): Include adjacent
       	ranges in the list of styles to consider.  Handle intervening
       	styles better.  Don't stop searching for matching pairs just
       	because we merge -- only when the merge kills the slave.
      
      	* src/ranges.c (range_dump): Don't print "\n".  All callers
       	changed as needed.
      
      	* src/sheet-style.c (sheet_style_optimize, sheet_styles_dump):
       	Send all debugging output to stderr.  (As opposed to half stderr
       	and half stdout.)
      169f4952
    • Jody Goldberg's avatar
      Actually assign the format after we ref it. (cell_get_format) : Cells with · 45e0d807
      Jody Goldberg authored
      
      2000-05-24  Jody Goldberg <jgoldberg@home.com>
      
      	* src/cell.c (cell_set_expr_internal) : Actually assign the format
      	  after we ref it.
      	(cell_get_format) : Cells with format 'General' may appear to have
      	  a format via autoformat or via the text that was entered.
      45e0d807
  11. 21 May, 2000 1 commit
    • Jody Goldberg's avatar
      A few delayed patches. · 2779b474
      Jody Goldberg authored
      These optimize paste, exit, sheet deletetion,
      and start the process for fixing a few things.
      
      2000-05-17  Jody Goldberg <jgoldberg@home.com>
      
      	* src/clipboard.c (clipboard_copy_cell_range) : Adjust signature to
      	  take a range.
      	(sheet_paste_selection) : Export in preparation for adding undo.
      
      	* src/commands.c (cmd_paste_copy) : Some initial work.  Not used or
      	  complete.
      
      	* src/parse-util.c (parse_text_value_or_expr) : Start passing in the
      	  current format so that we can eventually attempt to match it before
      	  trying all the others.
      
      	* src/sheet.c (sheet_formulas_unlink) : New function.
      	(sheet_destroy_contents) : Optimize.
      
      	* src/dialogs/dialog-plugin-manager.c : Make a bit prettier.
      	* src/dialogs/plugin-manager.glade : Ditto.
      
      2000-05-16  Jody Goldberg <jgoldberg@home.com>
      
      	* plugins/*/*.c : Rationalize the naming scheme.
      
      2000-05-15  Jody Goldberg <jgoldberg@home.com>
      
      	* src/eval.[ch] : Rename
      	  cell_queue_recalc      -> eval_queue_cell
      	  cell_queue_recalc_list -> eval_queue_list
      	  cell_unqueue_recalc    -> eval_unqueue_cell
      	(eval_unqueue_sheet) : New function.
      
      	* src/sheet.c (sheet_cell_remove_simple) : Add precautionary removal
      	  of cells from recalc list.  We should not need this in most
      	  instances, but the check is inexpensive so I'll play it safe.
      	(sheet_destroy_contents) : Batch cleanups rather than doing it cell by
      	  cell.
      
      	* src/cell.c (cell_make_value) : Fill in the implementation.
      
      	* src/clipboard.c (paste_cell_flags) : Remove some dead code.
      	  Merged in paste_cell and fixed handling of paste by value.
      
      2000-05-14  Jody Goldberg <jgoldberg@home.com>
      
      	* src/clipboard.c (paste_cell) : No need to call cell_content_changed
      	  we can queue the recalc for the entire region later.  It is
      	  sufficent to make the cell as changed with sheet_cell_changed.
      	(paste_cell) : It is premature to redraw, we have no yet calculated
      	  spans.  Redraw and respan at the range level, not the cell.
      2779b474
  12. 20 May, 2000 2 commits
    • Jody Goldberg's avatar
      Still more Chema discovery. · 7355ba25
      Jody Goldberg authored
      2000-05-19  Jody Goldberg <jgoldberg@home.com>
      
      	* src/cell.c (cell_set_format) : Apply the format to a NEW style, not the current
      	   style which may be say .... the DEFAULT!!!
      7355ba25
    • Jody Goldberg's avatar
      Doh! Fix the rest of the paste crashes. · 451b2fd3
      Jody Goldberg authored
      Doh!
      Fix the rest of the paste crashes.
      
      2000-05-19  Jody Goldberg <jgoldberg@home.com>
      
      	* src/cell.c (cell_copy) : Ref the format if one exists.
      451b2fd3
  13. 17 May, 2000 1 commit
    • Jody Goldberg's avatar
      Fix bugs 10705 10775 11159 Morten's autofill UMR Han's crash on sheet · efd376c0
      Jody Goldberg authored
      Fix bugs
          10705
          10775
          11159
          Morten's autofill UMR
          Han's crash on sheet deletion.
      
      2000-05-17  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_get_extent) : Disable the use of
      	  sheet_style_get_extent until it is more intelligent.
      
      	* configure.in : Produce a Using OAF message in the non-bonobo case
      	  too.  Limit xml to version 1.x for now.
      
      	* src/cell.c (cell_set_text_and_value) : Set the entered_text BEFORE
      	  the value so that cells with format = text render correctly.
      efd376c0
  14. 09 May, 2000 2 commits
  15. 06 May, 2000 2 commits
    • Jody Goldberg's avatar
      Split from cell_set_expr. · 4d72a2e6
      Jody Goldberg authored
      
      2000-05-06  Jody Goldberg <jgoldberg@home.com>
      
      	* src/cell.c (cell_set_expr_unsafe) : Split from cell_set_expr.
      
      	* src/eval.c (invalidate_refs) : Use cell_set_expr_unsafe.
      
      	* src/sheet.c (sheet_set_zoom_factor) : Depending on the order of
      	  initialization we may also need to render some unrendered values.
      4d72a2e6
    • Michael Meeks's avatar
      Add 3D dependency support. (cb_single_hash_to_list, · 479bddb8
      Michael Meeks authored
      2000-05-06  Michael Meeks  <michael@helixcode.com>
      
      	* src/eval.c (handle_cell_range_deps): Add 3D dependency support.
      	(cb_single_hash_to_list, cb_range_hash_to_list): Re-arrange handling of
      	where the list is collated. (do_deps_destroy): update.
      	(cell_drop_dependencies): remove cretinism here.
      	(drop_cell_range_dep, handle_cell_single_dep): return on NULL deps structure.
      
      	* src/sheet-style.c (sheet_style_attach): enable cache trash avoidance code.
      
      	* src/sheet.c (sheet_cell_remove_internal): short circuit for NULL
      	deps.
      
      	* src/expr.c (expr_rewrite): update to handle workbook case.
      
      	* src/eval.c (workbook_deps_destroy): update for speed.
      	(sheet_deps_destroy): split body into (do_deps_destroy): here.
      
      	* src/workbook.c (workbook_delete_sheet): destroy the sheet's
      	dependencies here as well; very silly. (workbook_do_destroy): destroy
      	deps of all sheets up front.
      479bddb8
  16. 03 May, 2000 2 commits
    • Jody Goldberg's avatar
      Fix leak morten found. · 43002eb0
      Jody Goldberg authored
      
      Fix leak morten found.
      
      2000-05-03  Jody Goldberg <jgoldberg@home.com>
      
      	* src/cell.c (cell_set_array_formula) : Add some invariants to catch
      	  inverted arrays.  The function should use the supplier's
      	  reference.  It should not re-reference the supplied expression.
      	  Document this.
      43002eb0
    • Jody Goldberg's avatar
      Begin to rationalize support for inverted and 3D references. · de62dd3a
      Jody Goldberg authored
      More renaming and movement name rationalization.
      Some minor improvements in the function wizard.
      
      2000-05-03  Jody Goldberg <jgoldberg@home.com>
      
      	* EvalPosition -> EvalPos
      	  ParsePosition -> ParsePos
      	  new struct RangeRef used in ValueRange
      
      	  eval_pos_init* -> position.[ch]
      	  parse_pos_init*
      	  cell_ref_{get,make}*
      
      	* src/workbook.c : Reorder the toolbar a bit.
      	(workbook_foreach_cell_in_range) : New function.
      	(cb_autofunction) : New routine.
      	(workbook_set_auto_expr) : DO NOT put real code into pre/post
      	  conditions.  It will be removed when debugging is eventually
      	  disabled.
      
      	* src/position.c (range_ref_normalize) : New function.
      
      	* src/ranges.c (range_normalize) : New function.
      
      	* src/expr.c (expr_implicit_intersection) : Use range_ref_normalize.
      
      	* src/eval.c (cell_eval_content) : No need to release the value.
      	  cell_assign_value already does that.
      	(dependency_range_ctor) : Use range_normalize.
      
      	* src/auto-format.c (do_af_suggest) : Use workbook_foreach_cell_in_range.
      
      	* src/cell.c (cell_set_expr_and_value) : link the new expression but
      	  do not queue it for recalc.
      	(cell_assign_value) : Release the old value.
      	(cell_copy) : Init the value to empty.
      
      	* src/func.c (function_iterate_do_value) : Use
      	  workbook_foreach_cell_in_range.
      
      	* src/dialogs/dialog-function-wizard.c (create_description) : Use
      	  a label rather than a text entry widget.  It looks better.
      
      	* src/functions/fn-string.c (gnumeric_expression) : range is already
      	  absolute.
      
      	* src/functions/fn-stat.c (gnumeric_linest) : Handle inverted ranges.
      	(gnumeric_logest) : Ditto.
      
      	* src/functions/fn-information.c (gnumeric_countblank) : Use
      	workbook_foreach_cell_in_range.
      	(gnumeric_{row,column}) : Handle inversions.
      
      	* src/functions/fn-lookup.c (gnumeric_offset) : No need to make
      	  absolute.  The marshaller already did that.
      
      2000-05-02  Jody Goldberg <jgoldberg@home.com>
      
      	* src/eval.c (dependency_range_ctor) : normalize the range.
      
      	* src/xml-io.c (xml_write_cell_and_position) : Suppress warning.
      
      	* src/pixmaps.h : Add function wizard and equal sign.
      de62dd3a
  17. 01 May, 2000 1 commit
    • Jody Goldberg's avatar
      ExprName -> NamedExpression ArrayRef -> ExprArray · 8d168628
      Jody Goldberg authored
      
      2000-05-01  Jody Goldberg <jgoldberg@home.com>
      
      	* ExprName -> NamedExpression
      	  ArrayRef -> ExprArray
      
      	change ExprTree to be a union of similar types and split
      	the elements into discrete types.
      	    ExprConstant
      	    ExprFunction
      	    ExprUnary
      	    ExprBinary
      	    ExprName
      	    ExprVar
      	    ExprArray
      
      	    expr->oper -> expr->any.oper
      
      2000-04-29  Jody Goldberg <jgoldberg@home.com>
      
      	* src/value.c (value_new_empty) : Don't allocate any memory.
      	(value_release) : Don't free any either.
      
      	* src/sheet-style.c (border_check) : Init outer_style to remove a
      	  warning.
      8d168628
  18. 29 Apr, 2000 2 commits
  19. 27 Apr, 2000 2 commits
    • Jody Goldberg's avatar
      Do redraws respans, and redimensions here. · a92f62cc
      Jody Goldberg authored
      
      2000-04-27  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook-format-toolbar.c (modify_cell_region) : Do redraws
      	  respans, and redimensions here.
      
      	* src/cell.c (cell_set_format) : Do not attempt to render or redraw
      	  the value.
      a92f62cc
    • Jody Goldberg's avatar
      Batch of quickies. · 27d8d83b
      Jody Goldberg authored
      2000-04-26  Jody Goldberg <jgoldberg@home.com>
      
      	* src/gnumeric-sheet.c (start_cell_selection_at) : Only hide the
      	  primary cursor when selecting cells on a different sheet.
      
      	* src/expr.c (eval_expr_real) : Pass EVAL_PERMIT_NON_SCALAR to
      	  eval_expr_real when evaluating an array.
      
      	* src/cell.c (cell_set_array_formula) : typo.
      
      	* src/sheet.c (sheet_find_boundary_{horizontal,vertical}) : Another thinko.
      27d8d83b
  20. 20 Apr, 2000 1 commit
    • Jody Goldberg's avatar
      Reorg cell contents and assignment. · bedb925b
      Jody Goldberg authored
      Fixs lots of usability details.
      
      2000-04-20  Jody Goldberg <jgoldberg@home.com>
      
      	* src/dialogs/dialog-cell-format.c : Use the edit_pos as the example
      	  not the top left corner.
      
      	* src/functions/fn-stat.c (gnumeric_ftest) : Use eval_pos_cellref
      	  to help localize the strangeness.
      	(gnumeric_ttest) : Ditto.
      
      	* src/xml-io.c (xml_write_cell_and_position) : If this is an array
      	  expression and we are the top left then add attributes to indicate
      	  size of array.  Ignore the rest of the array.
      	(xml_not_used_old_array_spec) : New routinr to handle the old array format.
      	(xml_cell_set_array_expr) : store an array.
      	(xml_read_cell) : Handle the old and the new array formats.
      
      	* src/workbook.c (workbook_close_if_user_permits) : Accept input
      	  first.
      	(wb_edit_key_pressed) : Handle array formulas here.
      	(workbook_detach_sheet) : Do not recalc all if we are exiting.
      	(workbook_start_editing_at_cursor) : When we start editing an
      	  array formula display just the formula not all the extra {}()[][] crap.
      
      	* src/sheet.c (SheetPrivate) : Add a recompute_spans flag.
      	(sheet_calc_spans) : New routine.
      	(sheet_cell_calc_span) : New routine.
      	(sheet_range_calc_spans) : Renamed and extended from
      	  sheet_cells_update.
      	(sheet_update) : Use sheet_calc_spans when necessary.
      	  Update the location region when the edit_pos changes.
      	(cb_recalc_spans_in_col) : Renamed from cb_collect_cells_in_col.
      	  Recalcs spans directly, no need to collect first.
      	(cb_set_cell_content) : New routine to set expr, or expr_and_value.
      	(sheet_range_set_text) : Use cb_set_cell_content, and remember
      	  chosen format with the cell rather than overriding the assigned
      	  format.
      	(sheet_cell_set_text) : Renamed from sheet_set_text.  Be more specific
      	  about how spans, rendering and the rest are handled.
      	(sheet_cell_set_expr) : New routine.
      	(sheet_cell_set_value) : Ditto.
      	(sheet_load_cell_val) : When displaying an array formula add {%s}()[][].
      	(sheet_redraw_cell_region) : Honour spans when redrawing.
      	(sheet_redraw_partial_row) : New routine.
      	(sheet_redraw_cell) : Ditto.
      	(sheet_is_cell_array) : Use cell_is_array.
      	(sheet_range_splits_array) : Renamed from sheet_check_for_partial_array.
      	(sheet_cell_add_to_hash) :  Do not touch spans at this point.
      	(sheet_cell_insert) : Rename from sheet_cell_add made recalc span
      	  optional.
      	(sheet_cell_new) : New routine that does not touch spans.
      	(sheet_cell_remove) : Made redraw optional.
      	(cb_clear_cell_comments) : Remove the cell if there is no comment.
      	(sheet_clear_region) : Remove the cell if there are no comments or
      	  contents.  Flag an update of the status region.
      
      	* src/sheet-view.c (cb_colrow_resize) : New function.
      	(sheet_view_col_size_changed) : Resize all rows, irrespective of
      	(sheet_view_row_size_changed) : existing cells.
      	(sheet_view_redraw_cell_region) : This no longer honours spans.
      
      	* src/sheet-style.c (sheet_style_attach) : Removed call to redraw.
      	sheet_cells_update : rename to sheet_range_calc_spans and move to
      	  sheet.c.
      
      	* src/sheet-autofill.c (autofill_cell) : Use sheet_cell_set_value
      	  rather than set_text.
      
      	* src/selection.c (sheet_selection_changed_hook) : Delete.
      	(sheet_selection_extend_to) : Update the status region to display the
      	  new size.
      	(sheet_selection_cut) : Use sheet_range_splits_array.
      	(selection_check_for_array) : New routine.
      
      	* src/parser.y : Remove icky array formula parsing that conflicted
      	  with array entries.
      
      	* src/number-match.c (format_match) : Return a Value * rather than a
      	  double.
      
      	* src/mstyle.c (mstyle_set_font_size) : Do not allow font sizes < 1.
      
      	* src/main.c (gnumeric_main) : Do NOT create an empty workbook
      	  then delete it if things are successfully loaded.  This causes
      	  a global recalc.  Instead add a flag to disable exit when the
      	  number of workbooks go to zero.  Then only enable the flag AFTER
      	  we have attempted to load the initial workbooks.
      
      	* src/item-grid.c (item_grid_event) : Update the status_region when
      	  button-1 is release.  It should display the edit_pos.
      
      	* src/gutils.c : Move cell_name, col_name, col_from_name,
      	  parse_cell_name, parse_cell_name_or_range and parse_cell_name_list,
      	  to parse-util.c.
      
      	* src/gnumeric.h  : Add RenderedValue.
      
      	* src/gnumeric-util.c (gnumeric_char_start_expr_p) : Move
      	  to parse-util.c
      
      	* src/file.c (workbook_read) : Remove freese thaw usage.
      	  Move call to update AFTER mark clean.
      
      	* src/expr.c (eval_pos_init) : Take a cellpos.
      	(parse_pos_evalpos) : New routine.
      	(eval_pos_cellref) : There is some questionable code scattered in the
      	  functions.  This routing localizes the odd bits for correction.
      
      	* src/eval.c (cell_eval_content) : Use sheet_redraw_cell,
      	  and rendered_value_calc_size.
      	(cell_get_dependencies) : Improve constness.
      
      	* src/corba-sheet.c : Remove the freeze thaw operations.
      	(Sheet_cell_set_formula) : Deleted.
      	(Sheet_range_set_formula) : Delete.
      
      	* src/commands.c : Adjust so that registration of command auto
      	  calls redo.  Add misc checks for splitting arrays.
      
      	* src/clipboard.h : Move the CellCopy types here from cell.h
      
      	* src/clipboard.c (paste_cell) : Use cell_has_expr.
      	  Don't insert the new cell till after its contents are assigned.
      
      	* src/cellspan.c (cell_register_span) : Improve constness.
      	(cell_unregister_span) : Ditto.
      	(row_cell_get_displayed_at) : Delete.
      	(cell_calc_span) : Moved here from cell.c
      
      	* src/dialogs/dialog-stf.glade : Adjust the header background colour
      	  to match the purdy new icon.  Add the icon.
      
      	* src/cell-draw.c : Use the rendered_value routines.
      	  Improve constness.
      
      	* src/analysis-tools.c (set_cell) : Use sheet_cell_fetch.
      
      	*.*
      	    cell_set_* -> sheet_cell_set_
      	    cell_set_*_simple -> cell_set_
      	    Cell::{row,col} -> Cell::{row,col}_info
      	    cell_get_text -> cell_get_entered_text
      	    cell_get_content -> cell_get_entered_text
      	    cell_name -> cell_coord_name
      	    cell_get_formatted_val -> cell_get_rendered_text
      	    cell_get_content -> cell_get_entered_text
      
      	* src/cell.c :
      	(cell_dirty) : Renamed from cell_modified.  Use
      	  sheet_set_dirty.
      	(cell_formula_changed) : Make the queuing of the recalc optional.
      	(cell_cleanout) : Handle union of expression and entered_text,
      	  and remove the rendered value.
      	(cell_copy) : Ditto.
      	(cell_destroy) : handle cell_modified -> cell_dirty.
      	(cell_set_text) : Use parse_text_value_or_expr and store the prefered
      	  format.
      	(cell_set_text_and_value) : New routine.
      	(cell_assign_value) : New routine.
      	(cell_set_value) : Support formats.
      	(cell_set_expr_and_value) : New routine.
      	(cell_set_expr_internal) : Split from cell_set_expr.
      	(cell_set_expr) : Divide to allow for not queuing a recalc.
      	(cell_set_array_formula) : Use cell_set_expr_internal.
      	(cell_is_array) : New utility.
      	(cell_is_partial_array) : New utility.
      	(cell_has_expr) : New utility.
      	(cell_render_value) : Use rendered_value_*.
      	Move all comment routines into cell-comment.[ch].
      
      	* idl/Gnumeric.idl : Remove cell_set_formula, and range_set_formula.
      	  These were identical to set_text.  Made Workbook embeddable.
      bedb925b
  21. 10 Apr, 2000 3 commits
    • Michael Meeks's avatar
      correct include. · f84afb18
      Michael Meeks authored
      2000-04-11  Michael Meeks  <michael@helixcode.com>
      
      	* src/parser.y: correct include.
      
      	* src/cell.c (cell_set_rendered_text): move up to before its first use.
      f84afb18
    • Miguel de Icaza's avatar
      Do not destroy the context here, as it is dereferenced later in the · 30aba440
      Miguel de Icaza authored
      
      
      2000-04-07  Miguel de Icaza  <miguel@gnu.org>
      
      	* main.c (button_cancel): Do not destroy the context here, as it
      	is dereferenced later in the mainloop.
      
      2000-04-10  Miguel de Icaza  <miguel@gnu.org>
      
      	* Lots of files: replaces utils.h for gutils.h
      
      	* renamed utils.h to gutils.h to avoid the compilation problem on
      	some Unices (yes, fixing the Makefile would have done it, but
      	utils.h was still a lame name;  Of course gutils.h is not any
      	better, but it is now done).
      
      2000-04-07  Miguel de Icaza  <miguel@gnu.org>
      
      	* src/cellspan.c (span_remove): Pretify code.
      30aba440
    • Jody Goldberg's avatar
      Do NOT recalc on load for now even though there are are queued cells that · 43aa96ea
      Jody Goldberg authored
      
      2000-04-10  Jody Goldberg <jgoldberg@home.com>
      
      	* src/file.c (workbook_read) : Do NOT recalc on load for now even
      	  though there are are queued cells that desire it.  This will
      	  prematurely mark the sheet as dirty.  This will need to be
      	  revisited.
      
      	* src/cell.c (cell_set_rendered_text) : Make static.
      
      	* src/cell.c (cell_calc_dimensions) : Be careful to recalculate spans
      	  that centered on other cells when calculating the span for a new
      	  cell.
      43aa96ea
  22. 09 Apr, 2000 1 commit
    • Jody Goldberg's avatar
      Do not change the target style if editing has not yet been enabled. · cd9b6682
      Jody Goldberg authored
      
      2000-04-09  Jody Goldberg <jgoldberg@home.com>
      
      	* src/dialogs/dialog-cell-format.c : Do not change the target style if
      	  editing has not yet been enabled.
      
      	* src/workbook.c (workbook_set_saveinfo) : If the save function is
      	  NULL default to xml.
      
      	* src/format.c (format_value) : Add some error checking.
      
      	* src/cell.c (calc_text_dimensions) : Make static
      
      	* src/main.c : Add main.h
      
      2000-04-03  Dom Lachowicz <dominicl@seas.upenn.edu>
      
       	* src/workbook.c (sheet_action_reorder_sheet): Right click on a
       	sheet tab, and if there's more than one sheet, you'll get an
       	option to bring up the re-order sheets dialog
      
       	* src/dialogs/dialog-plugin-manager.c (refresh_right_frame) :  Do not
      	  override default fonts and colours.
      
      	* src/dialogs/sheet-order.glade,
      	* src/dialogs/sheet-order.glade.h,
      	* src/dialogs/dialog-sheet-order.c (row_cb, delete_clicked_cb,
      	  up_clicked_cb, down_clicked_cb, close_clicked_cb,
      	  dialog_sheet_order_impl) : Improve look by moving buttons to the
      	  right edge rather than using stock buttons on the bottom and side.
      
      2000-04-07  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook.c (workbook_finish_editing) : resensitize the toolbars
      	  after editing.
      	(workbook_start_editing_at_cursor) : Desensitize the toolbars when we
      	  start to edit.
      cd9b6682
  23. 01 Apr, 2000 1 commit
    • Jody Goldberg's avatar
      Fix the silly edit bug tha was being reported. · fce11703
      Jody Goldberg authored
      Some major work on item-edit.
      
      2000-03-31  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook.c : Switch over to useing GNOMEUIINFO_ITEM_ where
      	  possible.
      	(cb_editline_focus_in) : Do not start editing if we are already
      	  editing.
      
      	* src/utils.c (parse_cell_name) : constness.
      
      	* src/style.c (style_font_gdk_font) : constness.
      	(style_font_gdk_font) : ditto.
      	(style_font_gnome_font) : ditto.
      	(style_font_get_height) : ditto.
      
      	* src/sheet.c (sheet_set_zoom_factor) : redimension all cells, rather
      	  than the sparse sheet region.  Do not auto-resize.
      	(sheet_cell_add) :  Adjust to new calling convention for
      	  cell_calc_dimensions.
      	(sheet_stop_editing) : Rename from sheet_destroy_edit_cursor.
      
      	* src/sheet-view.c (sheet_view_get_style_font) : constness.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_create_editing_cursor) :
      	  No need to set all those arguments.
      	(destroy_item_editor) : Merge into gnumeric_sheet_stop_editing.
      	(gnumeric_sheet_stop_editing) : Renamed from
      	  gnumeric_sheet_destroy_editing_cursor.
      
      	* src/cell.[ch] (cell_set_rendered_text) : Adjust to new calling
      	  convention for cell_calc_dimensions.
      	(cell_calc_dimensions) : Adjust calling convetion to make auto
      	  resizing optional.
      	(calc_text_dimensions) : Adjust calling convention to directly set size.
      
      	* src/sheet-style.c (re_dimension_cells_cb) :  Adjust to new calling
      	  convention for cell_calc_dimensions.
      
      	* src/item-edit.c : Major rework to behave better at margins,
      	  correctly handle cells whose display contents span differently than
      	  their displayed values, multi-line display mechanics, and a blinking
      	  cursor :-)
      fce11703
  24. 24 Mar, 2000 1 commit
    • Jody Goldberg's avatar
      Patch for bugs 5490 and 7743. We need better format recognition soon. · 72eeb832
      Jody Goldberg authored
      
      Patch for bugs 5490 and 7743.
      We need better format recognition soon.
      
      2000-03-23  Jody Goldberg <jgoldberg@home.com>
      
      	* src/cell.c (cell_set_text_simple) : Do NOT set the entered text
      	  when importing non string values.  There are still gotchas
      	  elsewhere. eg enter 90 format to current and edit box shows
      	  something that we can not parse.
      72eeb832
  25. 23 Mar, 2000 1 commit
    • Jody Goldberg's avatar
      Add CENTER_ACROSS_SELECTION. (cell_set_text_simple) : Begin transition to · bbf396c6
      Jody Goldberg authored
      
      2000-03-23  Jody Goldberg <jgoldberg@home.com>
      
      	* src/cell.c (cell_calculate_span) : Add CENTER_ACROSS_SELECTION.
      	(cell_set_text_simple) : Begin transition to checking
      	  format of current cell for match.  No real change yet.
      
      	* idl/Gnumeric.idl : Add CENTER_ACROSS_SELECTION.
      	* src/cell-draw.c (cell_draw) : Ditto.
      	* src/print-cell.c (print_cell) : Ditto.
      	* src/corba-sheet.c (Sheet_cell_set_alignment) : Ditto.
      	(Sheet_cell_get_alignment) : Ditto.
      	* src/dialogs/dialog-cell-format.c (fmt_dialog_init_align_page) : Ditto.
      	* src/dialogs/cell-format.glade : Ditto, reorganize alignment page.
      
      	* src/format.c : Move definition of _StyleFormatEntry from mstyle.h.
      
      	* src/number-match.c (format_create_regexp) : Extend to support
      	  currency names.
      
      	* src/item-grid.c (item_grid_draw_border) : minor optimization for
      	  non-border case.
      bbf396c6
  26. 22 Mar, 2000 1 commit
    • Jody Goldberg's avatar
      Fix span bugs. · 99ec14fe
      Jody Goldberg authored
      2000-03-22  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_reposition_comments) : Merged from
      	  sheet_reposition_comments_from_row and
      	  sheet_reposition_comments_from_col.
      
      	(sheet_update) : New function.  Use the new update flags from
      	  SheetPrivate that are set in the col/row resize functions
      	  to do delayed resizing and updates.  This allows the resizing to be
      	  batched for an entire logical operation.
      	(sheet_{col,row}_set_size_pixels) : Set the update flags.
      
      	* src/workbook-cmd-format.c (workbook_cmd_format_{row,column}_auto_fit) : No need to
      	  worry about redraws.  Use sheet_update.
      	(workbook_cmd_format_{row_height,column_width}) : Ditto.
      
      	* src/sheet-view.c (sheet_view_redraw_cell_region) : No need to
      	  recalculate the spans,  Use the pre-calculated versions.
      	(sheet_view_col_size_changed) : Use sheet_update.
      	(sheet_view_row_size_changed) : Ditto.
      
      	* src/sheet-style.c (re_dimension_cells_cb) : Use cell_calc_dimensions.
      	(sheet_cells_update) : No need to redraw per cell and guess the bound.
      	  It is simpler and more correct to calc dimension per cell, and
      	  redraw the region BEFORE and AFTER to handle spans.
      
      	* src/cell.[ch] (cell_style_changed) : Delete.
      
      	* src/cell-draw.c (cell_draw) : continue syncing with print code.
      	  Be even more careful in the possible presence of style bugs.
      	* src/item-grid.c (item_grid_draw) : Ditto.
      	* src/print-cell.c (print_cell) : Ditto.
      
      	* src/analysis-tools.c (correlation_tool) : Use sheet_update.
      	(covariance_tool) : Ditto.
      	(ttest_paired_tool) : Ditto.
      	(ttest_eq_var_tool) : Ditto.
      	(ttest_neq_var_tool) : Ditto.
      	(ftest_tool) : Ditto.
      
      2000-03-21  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet-private.h : Add status flags to accumulate state changes
      	  for later redraw.
      
      	* src/commands.c (cmd_format_redo) : Use sheet_update
      	  in case the row/col sizes changed due to font size changes.
      	(cmd_format_undo) : Ditto.
      
      	* src/widgets/gtk-combo-box.c (cb_state_change) : Only pseudo-prelight
      	  the display when over the arrow, not vice versa.
      	(gtk_combo_box_init) : Ditto.
      	(gtk_combo_box_set_display) : Ditto.
      
      	* src/sheet.c (sheet_row_get_distance_pts) : Enable reversed indicies.
      	(sheet_col_get_distance_pts) : Ditto.
      
      	* src/plugin.c (plugin_load) : Add more version checking to ensure
      	  that very old plugins that do not check their versions can not be
      	  loaded.
      
      2000-03-20  Jody Goldberg <jgoldberg@home.com>
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_make_cell_visible) : When
      	  forcing a scroll do a hard reset of the visible ranges.
      	(gnumeric_sheet_compute_visible_ranges) : Ditto.
      	(gnumeric_sheet_set_top_row) : Remove extraneous scroll.
      	(gnumeric_sheet_set_left_col) : Remove extraneous scroll.
      99ec14fe
  27. 10 Mar, 2000 1 commit
    • Jody Goldberg's avatar
      Constness. · c2af08a9
      Jody Goldberg authored
      2000-03-10  Jody Goldberg <jgoldberg@home.com>
      
      	* src/func.c (tokenized_help_new) : Constness.
      
      	* src/widgets/gtk-combo-box.c (cb_state_change) : New function to keep
      	  the state of the combo display button and the combo arrow in sync.
      	(gtk_combo_box_init) : Connect cb_state_change to the arrow.
      	(gtk_combo_box_set_display) : Ditto for the display widget.
      
      	* src/sheet.c (sheet_set_zoom_factor) : Bound the factor at 10% and 500%
      
      	* src/workbook.c (change_zoom_in_current_sheet_cb) :
      	  call change_displayed_zoom_cb to adjust the combo to contain the
      	(workbook_focus_current_sheet) : Only emit signal if the sheet
      	  changed.
      
      2000-03-08  Jody Goldberg <jgoldberg@home.com>
      
      	* src/collect.c (callback_function_collect) : Treat arrays and ranges
      	  as errors.
      
      	* src/format.c (format_value) : formating a range returns a
      	  #VALUE! message.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) :
      	  Use the workbook flags, and delete the icky globals.
      	(start_cell_selection_at) : Hide the std cursor when a cell selection
      	  cursor is created.
      	(gnumeric_sheet_stop_cell_selection) : Restore the std cursor.
      
      2000-03-07  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook.c (accept_input) : Use workbook_finish_editing.
      	(cancel_input) : Ditto.
      	(do_focus_sheet) : Support range selection across spreadsheets.
      	(workbook_get_sheet_position) : Fix and document.
      	(workbook_move_sheet) : Fix.
      	(workbook_focus_sheet) : Handle errors cleanly.
      	(wb_edit_key_pressed) : Improve F4 handling.
      	(wizard_input) : Begin non-modal function wizard.  NOT FINSIHED.
      	(workbook_start_editing_at_cursor) : transfered from
      	  sheet_start_editing_at_cursor.
      	(workbook_finish_editing) : Distilled from sheet_{accept,cancel}_pending_input.
      	(Workbook) : Add editing_cell, editing_sheet, editing.
      
      	* src/sheet.c (sheet_stop_editing) : Delete.
      	(sheet_accept_pending_input) : Merge into workbook_finish_editing.
      	(sheet_cancel_pending_input) : Ditto.
      	(sheet_start_editing_at_cursor) :
      	(sheet_create_edit_cursor) : New function.
      	(sheet_destroy_edit_cursor) : New function.
      	(sheet_destroy_cell_select_cursor) :  New function.
      	(Sheet) : Delete editing and editing_cell.
      
      	* src/selection.c (sheet_selection_changed_hook) : Make public.  This
      	  should eventually move but I'm not sure where.  It is used for more
      	  than just changes in the selection in the current sheet.  It must
      	  also be called when the sheet changes.  What it REALLY does it to
      	  sync the shared workbook state with the current sheet's selection.
      
      	* src/item-cursor.c (item_cursor_init) : Handle change from
      	  sheet_accept_pending_input -> workbook_finish_editing.
      	* src/item-grid.c (item_grid_button_1) : Ditto.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_can_move_cursor) : Edit moved
      	  from sheet -> workbook.
      	(selection_insert_selection_string) : Extend to support
      	  abs/rel refs and intersheet-refs.
      	(gnumeric_sheet_stop_cell_selection) : Add clear_string argument
      	  to optionally remove the selection range.
      	(gnumeric_sheet_key_mode_sheet) : Adjust to movement of editing flag
      	  from sheet -> workbook.  Be careful to use the original sheet when
      	  moving rather than the current sheet.  Support F4 while editing.
      
      	* src/cell-draw.c (cell_draw) : editing_cell has moved from sheet to
      	  workbook.  Fix font ref leak when drawing the edit cell.
      
      	* src/dialogs/dialog-function-wizard.c : Begin transition to being
      	  non-modal.  NOT FINISHED.
      c2af08a9
  28. 01 Mar, 2000 1 commit
    • Miguel de Icaza's avatar
      Notify the sheet that the cell changed using sheet_cell_changed. · eec41abe
      Miguel de Icaza authored
      2000-02-29  Miguel de Icaza  <miguel@nuclecu.unam.mx>
      
      	* src/cell.c (cell_content_changed): Notify the sheet that the
      	cell changed using sheet_cell_changed.
      
      	* src/sheet-vector.c: New file.  Implements the Gnumeric:Vector
      	interface (and supports non-contiguous ranges)
      
      	* src/sheet.c (sheet_destroy): free private structure.
      	(sheet_new): init private structure.
      	(sheet_cell_changed): New function.
      
      	* src/sheet-private.h: New file.
      
      	* src/sheet.h: Sheet structure includes SheetPrivate field now.
      eec41abe
  29. 28 Feb, 2000 1 commit
    • Jody Goldberg's avatar
      Improve the handling of backgrounds and selection in the presence of · bb5371b7
      Jody Goldberg authored
      
      Improve the handling of backgrounds and selection
      in the presence of spanning columns.
      
      Improve borders.  Somewhat more correct handling of double lined borders.
      Still mostly wrong, but its a start.
      
      2000-02-28  Jody Goldberg <jgoldberg@home.com>
      
      	* src/expr.h : Move FunctionDefinition to
      	* src/gnumeric.h : here.
      
      	* src/cellspan.c (col_hash) : Use GPOINTER_TO_INT.
      	(col_compare) : Ditto.
      	(row_init_span) : Delete.
      	(free_hash_value) : Renamed from free_hash_key.
      	(cell_register_span) : Register all cells in a span, malloc a
      	  CellSpanInfo to store a descriptor about the first and last cols.
      	(assemble_unregister_span_list) : Delete.
      	(span_remove) : New function for use by g_hash_table_foreach_remove.
      	(cell_unregister_span) : Use g_hash_table_foreach_remove.
      	(row_cell_get_displayed_at) : Adjust to new descriptor.
      	(row_span_get) : New function.
      
      	* src/cell.c (cell_calculate_span) : Renamed from cell_get_span.
      
      	* src/cell-draw.c (cell_draw) : Do not draw backgrounds here.
      	  Use new CellSpanInfo to avoid recomputing spans every time.
      	(cell_is_blank) : Remove hack about treating empty strings as empty.
      
      	* src/cellspan.h : New file.  Move span decls here.
      
      	* src/item-grid.c (item_grid_draw) : Rework to correctly handle
      	  backgrounds and borders for spanning columns.
      
      2000-02-27  Jody Goldberg <jgoldberg@home.com>
      
      	* src/cell.c (cell_is_blank) : Update.
      
      	* src/border.c (style_border_draw) : Make somewhat more correct.
      	  Still broken for non-top-left corners.
      
      	* src/item-grid.c (item_grid_draw_border) : Ditto.
      	(item_grid_draw_background) : Rename from item_grid_paint_empty_cell
      	  handle spans more cleanly.
      	(item_grid_draw_cell) : handle conditionals for displaying contents here.
      	  Remove all handling of backgrounds.
      bb5371b7
  30. 16 Feb, 2000 1 commit
    • Jody Goldberg's avatar
      More header cleanup. Remove value.h and sheet.h from expr.h. Remove · c73b937c
      Jody Goldberg authored
      
      2000-02-15  Jody Goldberg <jgoldberg@home.com>
      
      	* *.[ch] : More header cleanup.  Remove value.h and sheet.h
      	  from expr.h.  Remove sheet.h from cell.h.
      
      2000-02-16  Dom Lachowicz <dominicl@seas.upenn.edu>
      
      	* src/plugin-manager.c : Move functionality.
      	* src/dialogs/dialog-plugin-manager.c : here.  and move to libglade.
      
      	* src/workbook.c (plugins_cmd) : Use dialog_plugin_manager instead
      	  of plugin_manager_new.
      c73b937c
  31. 14 Feb, 2000 1 commit
    • Jody Goldberg's avatar
      A few more pts vs pixels cleanups and fixes. · fbf52c42
      Jody Goldberg authored
      2000-02-14  Jody Goldberg <jgoldberg@home.com>
      
      	* src/item-bar.c (item_bar_event) : Handle rename from
      	  sheet_{col,row}_size_fit -> sheet_{col,row}_size_fit_pixels
      	* src/selection.c (cb_set_row_height) : Ditto.
      	* src/workbook-cmd-format.c
      	(workbook_cmd_format_{column,row}_auto_fit) : Ditto.
      
      	* src/cell.c (cell_calc_dimensions) : Use sheet_row_set_size_pixels
      	  rather than sheet_row_set_internal_size_pts.
      
      	* src/sheet.c (sheet_{col,row}_set_size_{pixels,pts}) :
      	  Use sheet_row_fetch to avoid manually adding rows/col.
      	  Syncronize implementations and move the 'set_internal' code
      	  here.
      	(sheet_{col,row}_set_internal_size_pts) : Delete.
      	(sheet_{col,row}_size_fit) : Rename sheet_{col,row}_size_fit_pixels
      	(colrow_compute_pts_from_pixels) : Typo.
      fbf52c42