1. 24 Apr, 2000 3 commits
    • Jody Goldberg's avatar
      Rename ea_status -> selection_descriptor Moved ea_entry here and called it · c2687829
      Jody Goldberg authored
      2000-04-24  Jody Goldberg <jgoldberg@home.com>
      	* src/workbook-private.h : Rename ea_status -> selection_descriptor
      	Moved ea_entry here and called it edit_line.
      	* src/workbook.c (workbook_get_entry) : new routine.
      	* src/dialogs/function-select.glade : Made this a dialog, not a popup.
      	* src/summary.c (summary_item_free) : format police.
      	* src/value-sheet.c (value_area_foreach) : Ditto.
      	* src/sheet.c (sheet_new) : Init the update flags to FALSE, rather
      	  than TRUE now that the system seems to be getting their initial
      	  state correct when importing, paging and the like.
      	(sheet_load_cell_val) : Use workbook_get_entry.
      	(sheet_find_boundary_horizontal) : format police.
      	(sheet_find_boundary_vertical) : Ditto.
      	(sheet_range_splits_array) : Ditto.
      	(sheet_delete_{cols,rows}) : Ditto.
      	(sheet_restore_row_col_sizes) : Ditto.
      	(sheet_col_get_distance_{pixels,pts}) : Ditto.
      	(sheet_row_get_distance_pixels) : Ditto.
      	(sheet_row_get_distance_pts) : Ditto, Init accumulator.
      	* src/selection.c (sheet_selection_set) : format police.
      	(selection_check_for_array) : Ditto.
      	(sheet_selection_walk_step) : Ditto.
      	* src/sheet-view.c (horizontal_scroll_event) : Ditto.
      	(vertical_scroll_event) : Ditto.
      	* src/dialogs/dialog-cell-format.c : Ditto.
      	* src/dialogs/dialog-printer.c : Ditto.
      	* src/dialogs/dialog-workbook-attr.c : Ditto.
      	* src/functions/fn-eng.c : Ditto.
      	* src/functions/fn-lookup.c : Ditto.
      	* src/functions/fn-string.c : Ditto.
      	* src/pattern.c (gnumeric_sheet_patterns) : Add a few patterns for
      	  applix.  More are needed, and these are not available in the format
      	  dialog yet.
      	* src/number-match.c (compute_value) : Use g_strtod.
      	(format_match) : Ditto.
      	* src/item-edit.c : Use workbook_get_entry.
      	* src/item-bar.c (item_bar_event) : format police.
      	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) : Do not set
      	  the focus directly.  Leave that to workbook_start_editing.
      	(gnumeric_sheet_new) : Use workbook_get_entry.
      	* src/format.c (render_number) : format police.
      	* src/complex.c (complex_from_string) : Use g_strtod.
      	* src/functions/fn-database.c : Ditto.
      	* src/colrow.c (cb_row_col_visibility) : format police.
      	* src/main.c (gnumeric_main) : Move the workbook_style_test to the
      	  empty case.
      	* src/mstyle.c (mstyle_set_pattern) : Add some safety.
      	* src/number-match.c (format_match) : Handle empties.
    • Morten Welinder's avatar
      Doc fix. · c2845312
      Morten Welinder authored
    • Michael Meeks's avatar
      Thrash styles in a different fashion. · f7cb6959
      Michael Meeks authored
  2. 22 Apr, 2000 4 commits
    • Tuomas Kuosmanen's avatar
      new autosum icon /tigert · e98c1722
      Tuomas Kuosmanen authored
    • Michael Meeks's avatar
      Fix bonobo build, Re-tool style cache flushing to allow possible get/set, · 0a99e188
      Michael Meeks authored
      Fix bonobo build,
      Re-tool style cache flushing to allow possible get/set, get/set performance
      improvement some other time.
      2000-04-22  Michael Meeks  <michael@helixcode.com>
      	* src/sheet-style.c (sheet_style_attach): comment out optimization
      	for now.
      	* src/workbook.h (workbook_mark_clean): remove redundant prototype.
      	* src/corba-workbook.c (Workbook_save_to): use workbook_set_dirty
      2000-04-21  Michael Meeks  <michael@helixcode.com>
      	* src/sheet-style.c (sheet_style_cache_flush): update, kill inline
      	update all cache_flushes to be more explicit.
    • Almer. S. Tigelaar's avatar
      Fixed Bug #9007 Note : Does not fix the mouse click problem, just the · 415c2aef
      Almer. S. Tigelaar authored
      2000-04-22  Almer. S. Tigelaar.  <almer1@dds.nl>
      	Fixed Bug #9007
      	Note : Does not fix the mouse click problem, just the focus
      	* src/workbook.c
      	(workbook_attach_sheet) : Attaches a signal handler for
      	the "editing_stopped" signal of the editable label.
      	(sheet_label_editing_stopped_signal) : The signal handler
      	of the "editing_stopped" signal.
      2000-04-22  Almer. S. Tigelaar.  <almer1@dds.nl>
      	* widget-editable-label.c : Added new event "editing_stopped",
      	this signal is emmited when the user presses "ESC" or presses
      	the mouse button(s) outside the editable label.
    • Chema Celorio's avatar
      small typo that was causing a MCSSRB. ( multiple cell span string redraw · 3fc2f6b3
      Chema Celorio authored
      2000-04-21  Chema Celorio  <chema@celorio.com>
      	* src/sheet.c (sheet_redraw_cell_region): small typo
      	that was causing a MCSSRB.
      	( multiple cell span string redraw bug)
  3. 21 Apr, 2000 4 commits
  4. 20 Apr, 2000 5 commits
    • Jody Goldberg's avatar
      Don't display preview text if there is none. (dialog_cell_format) : Don't · d9a5775b
      Jody Goldberg authored
      2000-04-20  Jody Goldberg <jgoldberg@home.com>
      	* src/dialogs/dialog-cell-format.c (draw_format_preview) : Don't
      	  display preview text if there is none.
      	(dialog_cell_format) : Don't init the preview text if the cell is empty.
      	* src/plugin.c (plugin_load) : Fix leak.
      	* src/formats.c (currency_symbols) : Add Yen.
      	* src/corba-sheet.c (Sheet_cell_set_value):
      	cell_set_value -> sheet_cell_set_value
    • Jody Goldberg's avatar
      Commit some missing files. · 6cf840d1
      Jody Goldberg authored
      2000-04-20  Jody Goldberg <jgoldberg@home.com>
      	* src/plugin.c (plugin_load) : Fix leak.
    • Matt Wilson's avatar
      sheet_cell_set_value -> cell_set_value · 58654303
      Matt Wilson authored
      2000-04-20  Matt Wilson  <msw@redhat.com>
      	* src/corba-sheet.c (Sheet_cell_set_value):
      	sheet_cell_set_value -> cell_set_value
      	* src/corba-sheet.c: include cell-comment.h, rendered-value.h
    • Jody Goldberg's avatar
      Fix last minute header change. · adc4b852
      Jody Goldberg authored
    • Jody Goldberg's avatar
      Reorg cell contents and assignment. · bedb925b
      Jody Goldberg authored
      Fixs lots of usability details.
      2000-04-20  Jody Goldberg <jgoldberg@home.com>
      	* src/dialogs/dialog-cell-format.c : Use the edit_pos as the example
      	  not the top left corner.
      	* src/functions/fn-stat.c (gnumeric_ftest) : Use eval_pos_cellref
      	  to help localize the strangeness.
      	(gnumeric_ttest) : Ditto.
      	* src/xml-io.c (xml_write_cell_and_position) : If this is an array
      	  expression and we are the top left then add attributes to indicate
      	  size of array.  Ignore the rest of the array.
      	(xml_not_used_old_array_spec) : New routinr to handle the old array format.
      	(xml_cell_set_array_expr) : store an array.
      	(xml_read_cell) : Handle the old and the new array formats.
      	* src/workbook.c (workbook_close_if_user_permits) : Accept input
      	(wb_edit_key_pressed) : Handle array formulas here.
      	(workbook_detach_sheet) : Do not recalc all if we are exiting.
      	(workbook_start_editing_at_cursor) : When we start editing an
      	  array formula display just the formula not all the extra {}()[][] crap.
      	* src/sheet.c (SheetPrivate) : Add a recompute_spans flag.
      	(sheet_calc_spans) : New routine.
      	(sheet_cell_calc_span) : New routine.
      	(sheet_range_calc_spans) : Renamed and extended from
      	(sheet_update) : Use sheet_calc_spans when necessary.
      	  Update the location region when the edit_pos changes.
      	(cb_recalc_spans_in_col) : Renamed from cb_collect_cells_in_col.
      	  Recalcs spans directly, no need to collect first.
      	(cb_set_cell_content) : New routine to set expr, or expr_and_value.
      	(sheet_range_set_text) : Use cb_set_cell_content, and remember
      	  chosen format with the cell rather than overriding the assigned
      	(sheet_cell_set_text) : Renamed from sheet_set_text.  Be more specific
      	  about how spans, rendering and the rest are handled.
      	(sheet_cell_set_expr) : New routine.
      	(sheet_cell_set_value) : Ditto.
      	(sheet_load_cell_val) : When displaying an array formula add {%s}()[][].
      	(sheet_redraw_cell_region) : Honour spans when redrawing.
      	(sheet_redraw_partial_row) : New routine.
      	(sheet_redraw_cell) : Ditto.
      	(sheet_is_cell_array) : Use cell_is_array.
      	(sheet_range_splits_array) : Renamed from sheet_check_for_partial_array.
      	(sheet_cell_add_to_hash) :  Do not touch spans at this point.
      	(sheet_cell_insert) : Rename from sheet_cell_add made recalc span
      	(sheet_cell_new) : New routine that does not touch spans.
      	(sheet_cell_remove) : Made redraw optional.
      	(cb_clear_cell_comments) : Remove the cell if there is no comment.
      	(sheet_clear_region) : Remove the cell if there are no comments or
      	  contents.  Flag an update of the status region.
      	* src/sheet-view.c (cb_colrow_resize) : New function.
      	(sheet_view_col_size_changed) : Resize all rows, irrespective of
      	(sheet_view_row_size_changed) : existing cells.
      	(sheet_view_redraw_cell_region) : This no longer honours spans.
      	* src/sheet-style.c (sheet_style_attach) : Removed call to redraw.
      	sheet_cells_update : rename to sheet_range_calc_spans and move to
      	* src/sheet-autofill.c (autofill_cell) : Use sheet_cell_set_value
      	  rather than set_text.
      	* src/selection.c (sheet_selection_changed_hook) : Delete.
      	(sheet_selection_extend_to) : Update the status region to display the
      	  new size.
      	(sheet_selection_cut) : Use sheet_range_splits_array.
      	(selection_check_for_array) : New routine.
      	* src/parser.y : Remove icky array formula parsing that conflicted
      	  with array entries.
      	* src/number-match.c (format_match) : Return a Value * rather than a
      	* src/mstyle.c (mstyle_set_font_size) : Do not allow font sizes < 1.
      	* src/main.c (gnumeric_main) : Do NOT create an empty workbook
      	  then delete it if things are successfully loaded.  This causes
      	  a global recalc.  Instead add a flag to disable exit when the
      	  number of workbooks go to zero.  Then only enable the flag AFTER
      	  we have attempted to load the initial workbooks.
      	* src/item-grid.c (item_grid_event) : Update the status_region when
      	  button-1 is release.  It should display the edit_pos.
      	* src/gutils.c : Move cell_name, col_name, col_from_name,
      	  parse_cell_name, parse_cell_name_or_range and parse_cell_name_list,
      	  to parse-util.c.
      	* src/gnumeric.h  : Add RenderedValue.
      	* src/gnumeric-util.c (gnumeric_char_start_expr_p) : Move
      	  to parse-util.c
      	* src/file.c (workbook_read) : Remove freese thaw usage.
      	  Move call to update AFTER mark clean.
      	* src/expr.c (eval_pos_init) : Take a cellpos.
      	(parse_pos_evalpos) : New routine.
      	(eval_pos_cellref) : There is some questionable code scattered in the
      	  functions.  This routing localizes the odd bits for correction.
      	* src/eval.c (cell_eval_content) : Use sheet_redraw_cell,
      	  and rendered_value_calc_size.
      	(cell_get_dependencies) : Improve constness.
      	* src/corba-sheet.c : Remove the freeze thaw operations.
      	(Sheet_cell_set_formula) : Deleted.
      	(Sheet_range_set_formula) : Delete.
      	* src/commands.c : Adjust so that registration of command auto
      	  calls redo.  Add misc checks for splitting arrays.
      	* src/clipboard.h : Move the CellCopy types here from cell.h
      	* src/clipboard.c (paste_cell) : Use cell_has_expr.
      	  Don't insert the new cell till after its contents are assigned.
      	* src/cellspan.c (cell_register_span) : Improve constness.
      	(cell_unregister_span) : Ditto.
      	(row_cell_get_displayed_at) : Delete.
      	(cell_calc_span) : Moved here from cell.c
      	* src/dialogs/dialog-stf.glade : Adjust the header background colour
      	  to match the purdy new icon.  Add the icon.
      	* src/cell-draw.c : Use the rendered_value routines.
      	  Improve constness.
      	* src/analysis-tools.c (set_cell) : Use sheet_cell_fetch.
      	    cell_set_* -> sheet_cell_set_
      	    cell_set_*_simple -> cell_set_
      	    Cell::{row,col} -> Cell::{row,col}_info
      	    cell_get_text -> cell_get_entered_text
      	    cell_get_content -> cell_get_entered_text
      	    cell_name -> cell_coord_name
      	    cell_get_formatted_val -> cell_get_rendered_text
      	    cell_get_content -> cell_get_entered_text
      	* src/cell.c :
      	(cell_dirty) : Renamed from cell_modified.  Use
      	(cell_formula_changed) : Make the queuing of the recalc optional.
      	(cell_cleanout) : Handle union of expression and entered_text,
      	  and remove the rendered value.
      	(cell_copy) : Ditto.
      	(cell_destroy) : handle cell_modified -> cell_dirty.
      	(cell_set_text) : Use parse_text_value_or_expr and store the prefered
      	(cell_set_text_and_value) : New routine.
      	(cell_assign_value) : New routine.
      	(cell_set_value) : Support formats.
      	(cell_set_expr_and_value) : New routine.
      	(cell_set_expr_internal) : Split from cell_set_expr.
      	(cell_set_expr) : Divide to allow for not queuing a recalc.
      	(cell_set_array_formula) : Use cell_set_expr_internal.
      	(cell_is_array) : New utility.
      	(cell_is_partial_array) : New utility.
      	(cell_has_expr) : New utility.
      	(cell_render_value) : Use rendered_value_*.
      	Move all comment routines into cell-comment.[ch].
      	* idl/Gnumeric.idl : Remove cell_set_formula, and range_set_formula.
      	  These were identical to set_text.  Made Workbook embeddable.
  5. 19 Apr, 2000 1 commit
    • Almer. S. Tigelaar's avatar
      Created an stf options struct which was never freed or used · 1435c616
      Almer. S. Tigelaar authored
      2000-04-18  Almer. S. Tigelaar.  <almer1@dds.nl>
      	* src/dialogs/dialog-stf-format-page.c
      	(stf_dialog_format_page_init) : Created an stf options struct
      	which was never freed or used
      	* src/dialogs/dialog-stf-preview.c
      	(stf_preview_merge_with_hash) : Somehow there was a *gigantic* leak
      	in this routine. I simply rewrote it from scratsch because I didn't
      	see the error. This seemed to help, because the leak is gone. :-)
      	* src/dialogs/dialog-stf-preview.[ch]
      	Added some 'how it works' comments on top. Should make it clear
              who is responsible of freeing memory and when.
      	(stf_preview_share_hash) : Removed.
      	I removed the hash sharing, it is obsolete and just wasted space as
      	hashes are no longer shared between druid pages anyway.
  6. 18 Apr, 2000 1 commit
  7. 17 Apr, 2000 2 commits
  8. 16 Apr, 2000 4 commits
  9. 15 Apr, 2000 6 commits
  10. 14 Apr, 2000 6 commits
  11. 13 Apr, 2000 1 commit
  12. 12 Apr, 2000 1 commit
    • Jon K Hellan's avatar
      Really add accelerators to history menu items. · f3e64d9d
      Jon K Hellan authored
      2000-04-12  Jon K Hellan  <hellan@acm.org>
      	* src/history.c (history_menu_item_create): Really add
      	accelerators to history menu items.
      	* src/dialogs/dialog-analysis-tools.c (dialog_random_tool): Bug:
      	Dialog would quit when combo list was popped via keyboard. Fix:
      	Remove gnome_dialog_editable_enters from distribution combo.
      2000-04-11  Jon K Hellan  <hellan@acm.org>
      	* src/dialogs/dialog-zoom.c (focus_to_custom): New callback: Set
      	focus to custom spinbutton when custom radiobutton is checked.
      	(dialog_zoom_impl): Connect the callback.
      	* src/dialogs/dialog-analysis-tools.c (focus_on_entry): New
      	callback: Set focus to output range entry when output range
      	radiobutton is checked.
      	(set_output_option_signals): Connect the callback.
      	(distribution_parbox_config): Only add accelerator if we've got
  13. 11 Apr, 2000 2 commits