1. 09 Jun, 2000 6 commits
  2. 08 Jun, 2000 16 commits
    • Jody Goldberg's avatar
      update · 567f3038
      Jody Goldberg authored
      567f3038
    • Jody Goldberg's avatar
      ok now I understand what those calls to gnome_canvas_get_scroll_offsets · cecea671
      Jody Goldberg authored
      
      2000-06-08  Jody Goldberg <jgoldberg@home.com>
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_compute_visible_ranges) :
      	  ok now I understand what those calls to
      	  gnome_canvas_get_scroll_offsets where supposed to do.
      cecea671
    • Jody Goldberg's avatar
      Patch leak. · d6418a40
      Jody Goldberg authored
      
      2000-06-08  Jody Goldberg <jgoldberg@home.com>
      
      	* src/colrow.c (col_row_restore_sizes_group) : Patch leak.
      d6418a40
    • Jon K Hellan's avatar
      Silence run-time warning: Check for non-null list item from hash before · 560f646c
      Jon K Hellan authored
      2000-06-08  Jon K Hellan  <hellan@acm.org>
      
      	* gtk-combo-text.c (gtk_combo_text_set_text): Silence run-time
      	warning: Check for non-null list item from hash before casting to
      	widget.
      560f646c
    • Jody Goldberg's avatar
      Patch leak. · 87f72c55
      Jody Goldberg authored
      87f72c55
    • Jody Goldberg's avatar
      I hate typos. · 990a0113
      Jody Goldberg authored
      990a0113
    • Jody Goldberg's avatar
      Only autocomplete text that begins with an alphabetic · 69665bb8
      Jody Goldberg authored
      
      2000-06-08  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook-edit.c (entry_changed) : Only autocomplete text that
      	  begins with an alphabetic
      69665bb8
    • Jody Goldberg's avatar
      update · 75f7d8d0
      Jody Goldberg authored
      75f7d8d0
    • Morten Welinder's avatar
      Leak fix. · 9c7495cf
      Morten Welinder authored
      9c7495cf
    • Jody Goldberg's avatar
      Do not make the edge visible, the scroll time will take care of that. · f4b6302b
      Jody Goldberg authored
      
      2000-06-08  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet-view.c (sheet_view_{col,row}_selection_changed) :
      	  Do not make the edge visible, the scroll time will take care of
      	  that.
      	(sheet_view_{col,row}_size_changed) : Use the new undo wrappers.
      	(cb_colrow_resize) : Use the new undo wrappers.
      	(sheet_view_init) : Init the scroll timers.
      	(sheet_view_stop_sliding) : Based on the version from item_grid.
      	(sheet_view_start_sliding) : Ditto.
      	(sheet_view_sliding_callback) : Ditto.  Added callback support.
      	  tuned scroll parameters.
      
      	* src/number.h : Clear out unused cruft.
      
      	* src/item-grid.c : Move support for scroll timers into sheet-view.
      
      	* src/item-bar.c (get_element_from_pixel) : Renamed from
      	  get_col_from_pos.
      	(cb_extend_selection) : New function.
      	(item_bar_event) : Use the sliding scroll mechanism in sheet_view.
      
      	* src/item-cursor.c (item_cursor_selection_event) : Adapt to changes in
      	  item_grid_find_{col,row}.
      	(item_cursor_drag_event) : Ditto.
      
      	* src/sheet.c (sheet_foreach_colrow) : renamed and moved to.
      	* src/colrow.c (col_row_foreach) here.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_find_{col,row}) : Moved here
      	  and renamed from.
      	* src/item-grid.c (item_grid_find_{col,row}) : here.
      
      	* src/value.c (value_equal) : deleted.
      	(value_compare) : Moved and renamed from
      	* src/expr.c (compare) : here.
      	(expr_dump_tree) : Delete replicated function.
      
      	* src/colrow.c (col_row_size_list_destroy) :
      	(col_row_index_list_destroy) : New function.
      	(col_row_get_index_list) : New function.
      	(col_row_set_sizes) : New function.
      	(col_row_restore_sizes_group) : New function.
      
      	(col_row_save_sizes) : Moved from sheet.c
      	col_row_restore_sizes : Ditto.
      	cb_set_row_height : Ditto.
      	rows_height_update : Ditto.
      
      	src/commands.c (cmd_resize_row_col*) : Implement.
      f4b6302b
    • Morten Welinder's avatar
      Take advantage of sort_data_length and sort_permute_invert. · f73e172f
      Morten Welinder authored
      2000-06-08  Morten Welinder  <terra@diku.dk>
      
      	* src/commands.c (cmd_sort_undo): Take advantage of
       	sort_data_length and sort_permute_invert.
      
      	* src/sort.c (sort_data_length): Make public.
      	(sort_permute_invert): New function.
      f73e172f
    • ERDI Gergo's avatar
      Fixed a possible memory leak (callback data was not freed) · c66708d1
      ERDI Gergo authored
      2000-06-08  ERDI Gergo  <cactus@cactus.rulez.org>
      
      	* src/dialogs/dialog-printer-setup.c (unit_editor_configure):
      	Fixed a possible memory leak (callback data was not freed)
      c66708d1
    • Morten Welinder's avatar
      Remove left-overs. · d9e8be7d
      Morten Welinder authored
      d9e8be7d
    • Jon K Hellan's avatar
      Set zoom using gtk_combo_text_set_text. (change_zoom_in_current_sheet_cb): · 980b6a03
      Jon K Hellan authored
      2000-06-08  Jon K Hellan  <hellan@acm.org>
      
      	* src/workbook.c (change_displayed_zoom_cb): Set zoom using
      	gtk_combo_text_set_text.
      	(change_zoom_in_current_sheet_cb): Check that current sheet is non
      	NULL.
      	(workbook_zoom_feedback_set): Block callbacks while changing
      	displayed zoom.
      
      	* src/workbook-format-toolbar.c (workbook_create_format_toolbar):
      	Drop the empty font name - that was needed in the option menu, but
      	not now we're using a combo box.  Ignore nameless fonts in
      	gnumeric_font_family_list. (We were displaying *two* blank lines
      	at the top - now we've got rid of both.)
      	(workbook_feedback_set): Set font size and font name using
      	gtk_combo_text_set_text, which also selects the item in the combo
      	list if present.  Get rid of hack to select font name in list -
      	this is now done in the widget.
      	(workbook_feedback_set):
      
      	* src/sheet.c (sheet_set_zoom_factor): Check that sheet isn't NULL.
      
      2000-06-08  Jon K Hellan  <hellan@acm.org>
      
      	* gtk-combo-text.[ch] (gtk_combo_text_set_text): New function. Set
      	displayed text, and select it in the list if present.
      
      	* gtk-combo-text.c (cb_remove_from_hash): New function. Remove
      	list item widget from hash when item is deleted.
      	(gtk_combo_text_add_item): Store list item widget in hash instead
      	of list item position. This way, it works even if items are
      	deleted.
      980b6a03
    • Ariel Rios's avatar
      Removal of unused code. Found some nasty problems that need to be addresed · ca016474
      Ariel Rios authored
      2000-06-07  Ariel Rios  <ariel@arcavia.com>
      
      * plugin.c: Removal of unused code. Found some nasty problems
      that need to be addresed urgently in ranges and arrays.
      
      * doc/guile-gnumeric.txt: Updated.
      ca016474
    • Morten Welinder's avatar
      Fix sorting. · 812617f7
      Morten Welinder authored
      812617f7
  3. 07 Jun, 2000 6 commits
    • Jody Goldberg's avatar
      Escaped characters trigger a render too. This code really needs to be · ec3a30d3
      Jody Goldberg authored
      
      2000-06-07  Jody Goldberg <jgoldberg@home.com>
      
      	* src/format.c (format_number) : Escaped characters trigger a render
      	  too.  This code really needs to be rationalized.
      
      2000-06-06  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook.c (workbook_delete_sheet) : Update the undo/redo
      	  toolbar and menus.
      
      	* src/sort.c (sort_permute) : Avoid Leak.
      
      	* src/main.c (gnumeric_main) : Fix typo that was breaking minicons.
      ec3a30d3
    • Morten Welinder's avatar
      Plug leak. · dc3feb4b
      Morten Welinder authored
      2000-06-14  Morten Welinder  <terra@diku.dk>
      
      	* ms-formula-write.c (ms_excel_write_formula): Plug leak.
      
      	* ms-excel-write.c (ms_excel_check_write): In case of error, clear
       	out the state.
      	(ms_excel_write_free_state): "New" function.
      	(write_workbook): Don't free workbook here.
      	(ms_excel_write_workbook): Do it here and plug a leak.
      
      	* boot.c (excel_save): Free the state.
      dc3feb4b
    • Jody Goldberg's avatar
      FORMAT records supercede the internal table. · d1b4f46f
      Jody Goldberg authored
      
      2000-06-07  Jody Goldberg <jgoldberg@home.com>
      
      	* ms-excel-read.c (biff_format_data_lookup) : FORMAT records supercede
      	  the internal table.
      d1b4f46f
    • Darin Adler's avatar
      143e12b7
    • Yuri Syrota's avatar
      Updated Ukrainian translation · 3d870810
      Yuri Syrota authored
      3d870810
    • Miguel de Icaza's avatar
      Update code. · 763a09be
      Miguel de Icaza authored
      2000-06-06  Miguel de Icaza  <miguel@helixcode.com>
      
      	* src/commands.c (cmd_set_text): Update code.
      
      	* src/workbook-edit.c (workbook_auto_complete_destroy): Simplify
      	test here.
      763a09be
  4. 06 Jun, 2000 6 commits
    • Morten Welinder's avatar
      Gripe. · 3a6ab57e
      Morten Welinder authored
      3a6ab57e
    • Miguel de Icaza's avatar
      Simplify test here. · 55a579e3
      Miguel de Icaza authored
      2000-06-06  Miguel de Icaza  <miguel@helixcode.com>
      
      	* src/workbook-edit.c (workbook_auto_complete_destroy): Simplify
      	test here.
      55a579e3
    • Vladimir Vuksan's avatar
      Changes and improvements :-) · 5b5cba2d
      Vladimir Vuksan authored
      5b5cba2d
    • Jody Goldberg's avatar
      update · 6e65e887
      Jody Goldberg authored
      6e65e887
    • JP Rosevear's avatar
      Call sort_permute with the given permutation index (sort_contents): Call · 13960fdc
      JP Rosevear authored
      2000-06-06  JP Rosevear  <jpr@arcavia.com>
      
      	* src/sort.c (sort_position): Call sort_permute with the given
      	permutation index
      	(sort_contents): Call sort_qsort to get a permutation index and
      	then use sort_permute to actually move the rows
      	(sort_permute): Use copy and paste to move rows/cols around
      	(sort_permute_next): Find next row/col the hasn't been set based
      	on the permutation array
      	(sort_permute_is_set): Find if a a bit in a bit array is set
      	(sort_permute_set): Set a bit in a bit array
      	(sort_permute_find): Find a given number in a permutation array
      	(sort_qsort): Produce a permutation index for sorting rows or cols
      	(sort_swap): Swap two entries in the permutation index
      	(sort_compare_sets): Compare two sets of cells
      	(sort_compare_cells): Compare two cells
      	(sort_data_destroy): Destroy SortData struct
      
      	* src/commands.c (cmd_sort): Store the new sort data structure
      	(cmd_sort_redo): Call sort_contents only if a permutation index
      	does not already exist, otherwise use the index with sort_postion
      	(cmd_sort_undo): Create an inverse of the permutation index
      	if it doesn't already exit to call sort_positon with
      
      	* src/commands.h: New cmd_sort prototype.
      
      	* src/workbook.c (sort_cmd): Reflecting sorting API changes
      
      2000-06-06  JP Rosevear  <jpr@arcavia.com>
      
      	* cell-sort.glade: GUI tidying
      
      	* dialog-cell-sort.c (dialog_cell_sort_ok): Reflect sorting
      changes
      	(dialog_cell_sort_del_clause): ditto
      	(dialog_cell_sort_header_toggled): ditto
      	(dialog_cell_sort): ditto
      13960fdc
    • Jody Goldberg's avatar
      silence a few warnings. · 8adf2128
      Jody Goldberg authored
      Fix a problem with the new expr_relocate flag for pasting when soring.
      
      2000-06-05  Jody Goldberg <jgoldberg@home.com>
      
      	* src/cell.c (cell_relocate) : when relocating the expression
      	  be careful to use the offsets when calculating the validity.
      
      	* src/workbook-edit.c (workbook_auto_complete_destroy) : Only remove
      	  signal if it has been activated.  Only delete the completer if it
      	  exists.
      8adf2128
  5. 05 Jun, 2000 6 commits
    • Miguel de Icaza's avatar
      Fix merge problem · 6d0bdb8a
      Miguel de Icaza authored
      6d0bdb8a
    • Miguel de Icaza's avatar
      Moved the editing code here · 4a371b47
      Miguel de Icaza authored
      4a371b47
    • Miguel de Icaza's avatar
      This adds autocompletion. · aa133206
      Miguel de Icaza authored
      It is missing one forced repaint that makes the stuff look slower
      than it is.
      
      2000-06-05  Miguel de Icaza  <miguel@helixcode.com>
      
      	* src/gnumeric-util.c (gtk_radio_button_select): Add
      	precondition.  Chema found this, but we should add the proper
      	check at an upper layer.
      
      2000-06-04  Miguel de Icaza  <miguel@helixcode.com>
      
      	* src/gnumeric-util.c (gnumeric_entry_at_subexpr_boundary_p):
      	Change prototype to use GtkEntry instead of GtkWidget.
      
      	* src/workbook-edit.c (workbook_finish_editing): Changed direct access to
      	workbook->private_entry to workbook_get_entry.
      	(entry_changed): ditto.
      	(workbook_start_editing_at_cursor): ditto.
      	(workbook_editing_expr): ditto.
      	(workbook_edit_get_display_text): ditto.
      
      	* src/workbook.c (autosum_cmd): Changed direct access to
      	workbook->private_entry to workbook_get_entry.
      	(do_focus_sheet): ditto.
      	(wb_edit_key_pressed): ditto.
      	(workbook_setup_edit_area): ditto.
      
      	* src/workbook.c (cb_autofunction): ditto.
      
      	* src/workbook-private.h: Make edit_line a structure to keep track
      	of the entry and its signal changed.  Also take a chance to change
      	this to the self descriptive GtkEntry instead of GtkWidget.
      
      	* src/commands.c (cmd_set_text): Added const here.
      
      	* src/workbook.c (workbook_do_destroy): Add destroy notification
      	for the editing facilities
      
      	* src/item-edit.c (item_edit_set_arg): removed auto complete code
      	from here.
      
      2000-06-03  Miguel de Icaza  <miguel@helixcode.com>
      
      	* src/workbook-edit.c, src/workbook-edit.h: New files.  Moved
      	workbook_start_editing_at_cursor, workbook_finish_editing,
      	workbook_get_entry, workbook_editing_expr here.  Killed
      	workbook_set_entry prototype.
      
      	* src/workbook.c (workbook_start_editing_at_cursor): Moved
      	autocomplete here.
      
      	* src/workbook.h: Removed warning.  #include <config.h> is a
      	mandatory header file in every C file.  A correct approach is to
      	use something like Nautilus' perl script that verifies the
      	presence of config.h as the first include.
      
      	* src/workbook.c (close_cmd): Removed ulgy (void)
      	(quit_cmd): More.
      	(sheet_action_rename_sheet): more.
      	(workbook_finish_editing): Fixed more ugly.
      
      	* src/gutils.c (gnumeric_sys_glade_dir): Fixed ugly indentation.
      	(gnumeric_usr_plugin_dir): More ugly stuff fixed.
      	(gnumeric_usr_dir): Removed ugly const.
      
      2000-05-02  Miguel de Icaza  <miguel@helixcode.com>
      
      	* src/item-edit.h: New ::entry member, auto_max_size, auto_complete_text
      
      	* src/item-edit.c (item_edit_draw_text): Take an ItemEdit as a
      	first argument, and reduce the cluttered arguments we were
      	passing.
      	(item_edit_draw): Cursor_pos is now only the position, it is not
      	overloaded with show/hide cursor as well.
      	(item_edit_draw_text): Update acoordingly.
      	(item_edit_draw_cursor): This new routine paints the cursor only.
      	(item_edit_set_arg): Add a new signal handler for "activated" on
      	the entry
      	(cb_item_edit_cursor_blink): Removed FIXME.
      	(item_edit_set_arg): Init item_edit->entry.  I am pretty sure this
      	existed in the past.
      
      2000-05-01  Miguel de Icaza  <miguel@helixcode.com>
      
      	* src/item-edit.c (item_edit_draw): Pass auto-completing flag.
      	(item_edit_draw_text): Invert auto-complete region.
      	(item_edit_set_arg): Init auto_completing here.
      	(item_edit_complete_notify): Set the entry from the
      	auto-completing data here.
      
      
      2000-06-04  Miguel de Icaza  <miguel@helixcode.com>
      
      	* dialog-function-wizard.c (dialog_function_druid): Use
      	workbook_get_entry here.
      
      	* dialog-printer-setup.c (spin_button_adapt_to_unit): Added
      	g_assert_not_reached ();
      aa133206
    • Jody Goldberg's avatar
      renamed from sheet_cell_formula_{link,unlink}. · 7f94ba9e
      Jody Goldberg authored
      
      2000-06-05  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_cell_expr_{link,unlink}) : renamed from
      	  sheet_cell_formula_{link,unlink}.
      
      	* src/cell.c (cell_relocate) : Doh! use the offset flags now that they
      	  are being passed.
      
      	* src/clipboard.c (paste_cell) : Renamed from paste_cell_flags.
      
      	* src/expr.c (compare) : value_is_empty_cell -> VALUE_IS_EMPTY.
      
      	* src/value.c (VALUE_IS_EMPTY) : rename from value_is_empty_cell.
      
      	* src/sheet-private.h : Add resize_scrollbar.
      
      	* src/sheet.c (sheet_{col,row}_add) : Use resize_scrollbar flag rather
      	  than manually updating the scrolling bar.
      	(sheet_update) : Handle resize_scrollbar.
      	(sheet_cell_expr_link) : renamed from sheet_cell_formula_link.
      	(sheet_cell_expr_unlink) : renamed from sheet_cell_formula_unlink.
      7f94ba9e
    • Morten Welinder's avatar
      Plug leak. · 82da7fbe
      Morten Welinder authored
      2000-06-14  Morten Welinder  <terra@diku.dk>
      
      	* ms-formula-write.c (ms_excel_write_formula): Plug leak.
      
      	* ms-excel-write.c (ms_excel_check_write): In case of error, clear
       	out the state.
      	(ms_excel_write_free_state): "New" function.
      	(write_workbook): Don't free workbook here.
      	(ms_excel_write_workbook): Do it here and plug a leak.
      
      	* boot.c (excel_save): Free the state.
      82da7fbe
    • Michael Meeks's avatar