1. 24 Sep, 2000 1 commit
    • Jody Goldberg's avatar
      Suppress some warnings and make non-bonobo build clean. · a9a20284
      Jody Goldberg authored
      2000-09-24  Jody Goldberg <jgoldberg@home.com>
      
      	* src/normal-args.c : Suppress warning.
      
      	* src/functions/fn*.c : Add a prototype of the _init routine to
      	  suppress warning.
      
      	* src/eval.c (cell_recalc_dependencies ) : Comment out until it is
      	  implemented.
      
      	* src/sheet-object-widget.c (sheet_object_widget_new) : delete.
      a9a20284
  2. 23 Sep, 2000 1 commit
    • 4's avatar
      Simple sed for item-container bits. · 183013a7
      4 authored
      
      Simple sed for item-container bits.
      
      2000-09-24    <michael@thomas.home>
      
      	* src/workbook-private.h: update to item container.
      183013a7
  3. 11 Sep, 2000 1 commit
    • Jody Goldberg's avatar
      The initial version of active objects. · ccdc4a78
      Jody Goldberg authored
      2000-09-10  Jody Goldberg <jgoldberg@home.com>
      
      	* src/xml-io.c (xml_read_sheet_object) : objects have their positions
      	  set after creation, not before.
      	NOTE : This routine is incomplete.  It does not handle all of the
      	  objects.  It is questionable whether or not it even belongs here.
      	  We may want to encapsulate the persistence on a per object basis.
      	(xml_sheet_read) : localize and improve variable naming.
      
      	* src/workbook.c : Add an ifdef around the GnomeUI handler in bonobo
      	  mode.  Move the object creation cruft into its own file.
      	(select_component_id) : new function.
      	(create_embedded_component_cmd) : simplify.
      	(create_embedded_item_cmd) : simplify.
      	(create_button_cmd) : Delete.
      	(create_checkbox_cmd) : Delete.
      	(create_line_cmd) : Delete.
      	(create_arrow_cmd) : Delete.
      	(create_rectangle_cmd) : delete.
      	(create_ellipse_cmd) : delete.
      	(cut_cmd) : simplify object handling.
      	(insert_object_cmd) : Use sheet_object_bonobo_new_from_oid.
      	(do_focus_sheet) : Handle object toolbar too.
      	(workbook_detach_sheet) : Before messing with the views go back to
      	  simple edit mode.
      
      	* src/workbook-object-toolbar.c (create_object_command) : new
      	  function.
      	(cmd_create_*) : Use here.
      
      	* src/workbook-edit.c (workbook_edit_set_sensitive) : Add the object
      	  toolbar.
      
      	* src/sheet-object.c (sheet_release_coords) : delete.
      	(sheet_object_destroy) : simplify.
      	(SheetObject::end_popup) : remove.
      	(SheetObject::populate_menu) : rename from start_popup.
      	(SheetObject::new_view) : rename from realize.
      	(SheetObject::user_config) : New virtual.
      	(sheet_object_construct) : initialize dragging to FALSE.
      	  s/Sheet::objects/Sheet::sheet_objects/
      	(sheet_object_drop_file) : Moved.
      	(sheet_object_realize) : No need for SheetView::temp_item.
      	(button_widget_create) : delete.
      	(checkbox_widget_create) : delete.
      	(sheet_object_create_button) : delete.
      	(sheet_object_create_checkbox) : delete.
      	(create_object) : delete.
      	(cb_obj_create_motion) : rename from sheet_motion_notify.  Simplify.
      	  Rubber band a rectangle rather than the actual object.
      	  Keep track of whether or not a we have resized larger than the
      	  minimum 5x5 size.
      	(cb_obj_create_button_release) : rename from sheet_button_release.
      	  Change behavior to have the release do the realizing and bound
      	  setting.  Set the bounds to the current coord ONLY if we have moved
      	  enough, otherwise just use the default size of the object tranformed
      	  to the location of the original button press.
      	(shutdown_sheet_object_creation) : merge into button release.
      	(sheet_leave_notify) : Delete.
      	(sheet_button_press) : Delete.
      	(sheet_object_begin_creation) : Delete.
      	(sheet_finish_object_creation) : merge into button release and clear
      	  out all the cruft requiring removal of signals.
      	(sheet_mode_clear) : new function.  Does some object management.
      	(sheet_set_mode_type) : delete.
      	(sheet_set_mode_type_full) : delete content.  Split logical action into.
      	(sheet_mode_edit) : here.
      	(sheet_mode_edit_object) : here.
      	(sheet_mode_create_object) : and here.
      	(sheet_object_destroy_control_points) : be more pedantic a about
      	  checking that we have a valid view.
      	(sheet_object_stop_editing) : Adjust for new object editing semantics.
      	(set_item_x) : Merge this
      	(set_item_y) : and this.
      	(set_item_x_y) : into here.  And add the logic to call
      	  new_control_point.
      	(new_control_point) : Set the cursor here.
      	(update_bbox) : Recall that the bounding box excludes the far coords.
      	(control_point_handle_event) : No need to make object the current, if
      	  we are being called we are current.
      	(sheet_object_populate_menu) : rename from sheet_object_start_popup.
      	(sheet_object_end_popup) : delete.
      	(sheet_object_canvas_event) : adjust to function renaming.
      	(sheet_object_widget_event) : delete.
      	(sheet_object_widget_handle) : delete.
      	(sheet_object_start_editing) : delete, no need.  update_bbox does all
      	  of this.
      	(sheet_object_make_current) : delete.
      	(sheet_object_insert) : this was not what its name suggested.  It was
      	  a rather specialized bonobo utility.  Move it where it belongs.
      
      	* src/sheet-object-widget.c : Rewrite.
      
      	* src/sheet-object-item.c (sheet_object_item_new_view) : rename from
      	  sheet_object_item_realize.
      
      	* src/sheet-object-graphic.c (sheet_object_graphic_new_view) :
      	  rename from sheet_object_graphic_realize.
      	(sheet_object_filled_new_view) : renamed from sheet_object_filled_realize.
      	(sheet_object_create_line) : No need to take position, do that later.
      	(sheet_object_create_filled) : Ditto.
      
      	* src/sheet-object-container.c (user_activation_request_cb) : Adjust
      	  to changes in sheet mode handling.
      	(sheet_object_container_new_view) : rename from sheet_object_container_realize.
      	(sheet_object_container_new_bonobo) : No need to take pos info, that
      	  is set later.
      	(sheet_object_container_new_object) : Ditto.
      	(sheet_object_container_new_file) : Moved and renamed from sheet_object_drop_file.
      
      	* src/sheet-object-bonobo.c (sheet_object_bonobo_construct) : No need
      	  to take position info.  Bounds are set later.
      	(sheet_object_bonobo_new_from_oid) : Move from sheet_object_insert
      	  which was much to generic a name and location for this.
      
      	* src/print.c (print_sheet_range) : Adjust to rename of the
      	  sheet_object list.
      
      	* src/pixmaps.h : Remove the pixmaps that moved to the object toolbar.
      
      	* src/item-grid.c (item_grid_button_1) : Handle object creation and
      	  finishing object editing directly, no more need for adding and
      	  removing handlers.  Adjust arg to be a Button event.
      	(item_grid_event) : Add a new cursor for object creation.
      	(item_grid_event) : Do not change to edit mode until we know why the
      	  button was pressed.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_object) :
      	  s/sheet_set_mode_type/sheet_mode_edit/
      	(gnumeric_sheet_key_press) : Adjust to new mode scheme.
      	(gnumeric_sheet_key_release) : Ditto.
      	(gnumeric_sheet_filenames_dropped) : Ditto.
      
      	* src/gnumeric.h : Add fwd decl of SheetObject.
      
      	* src/gnumeric-sheet.h : delete GnumericSheet::mode .
      
      	* src/gnumeric-type-util.h : Rename GNUMERIC_MAKE_TYPE_WITH_PARENT
      	  to GNUMERIC_MAKE_TYPE_WITH_CLASS.  That makes more sense.
      
      	* src/eval.c (invalidate_refs) : Use dependent_set_expr.
      	(cell_eval) : New need to check generation If we are called we are out
      	  of date.
      
      	* src/dependent.c (dependent_eval) : moved from eval.c.
      	(dependent_type_register) : New routine.
      	(dependent_set_expr) ; Ditto.
      	(dependent_debug_name) : Use the new registry.
      
      	* src/dependent.h : Reorder flags, remove explicit types for graphs
      	  and checkboxes.  Those are handled by the virtual table.
      
      	* src/commands.c : s/PARENT/CLASS/
      
      	* src/cell.h : Reorder the CellFlags.
      
      	* src/bonobo-io.c (gnumeric_bonobo_obj_read) : Do not pass the
      	  position to sheet_object_containter_new_object.
      
      	* src/Makefile.am : Add workbook-object-toolbar.[ch]
      	  and graph-series.[ch]
      	  merge the libraries from the two idl files.
      
      2000-09-09  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet-view.c (sheet_view_construct) : Init control points to NULL.
      	(SheetView::temp_item) : remove this.
      
      	* src/sheet.c (sheet_new) : Init the members associated with objects.
      	(sheet_destroy) : Destroy objects.
      	(Sheet::mode) : remove.
      
      	* src/gnumeric.xml : Add a label for the selection menu.
      
      	* src/sheet-object-container.c (sheet_object_container_realize) :
      	  Fix warning.
      
      2000-09-07  Jody Goldberg <jgoldberg@home.com>
      
      	* src/item-bar.c (colrow_tip_setlabel) : mark the size tooltips as
      	  containing pts.
      	* src/dialogs/row-height.glade :
      	* src/dialogs/col-width.glade : Ditto.
      ccdc4a78
  4. 06 Sep, 2000 1 commit
    • Michael Meeks's avatar
      Check for bonobo 0.19 · f1ca24dc
      Michael Meeks authored
      2000-09-06  Michael Meeks  <michael@helixcode.com>
      
      	* configure.in: Check for bonobo 0.19
      
      	* src/workbook.c: Add/Modify -> Add\\Modify for now.
      
      	* src/workbook-view.c (workbook_view_set_title): use get_toplevel
      	(workbook_view_set_size):
      
      	* src/workbook-private.h: add a main_vbox to put toolbars into.
      
      	* src/workbook-format-toolbar.c (workbook_create_format_toolbar):
      	hack for non-bonobized toolbars.
      
      	* src/workbook.c (workbook_show, workbook_hide, workbook_get_toplevel):
      	helper functions.
      
      	* src/corba-workbook.c (Workbook_show): use workbook show/hide
      
      	* src/analysis-tools.c (prepare_output): ditto.
      
      	* src/main.c (gnumeric_main): ditto.
      
      	* src/clipboard.c (clipboard_paste, x_selection_received),
      	(x_clipboard_bind_workbook): ditto.
      
      	* src/application.c (application_set_selected_sheet): use
      	workbook_get_toplevel
      
      	* src/history.c (file_history_cmd): ditto.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_filenames_dropped): ditto.
      
      	* src/xml-io.c (xml_workbook_write): get_toplevel upd.
      
      	* src/workbook.c (new_cmd, file_open_cmd, file_import_cmd): show / hide.
      	(workbook_setup_edit_area): get_toplevel
      f1ca24dc
  5. 21 Aug, 2000 1 commit
    • Jody Goldberg's avatar
      Improve regexps. · 9ad38a63
      Jody Goldberg authored
      
      2000-08-21  Jody Goldberg <jgoldberg@home.com>
      
      	* src/number-match.c (format_create_regexp) : Improve regexps.
      
      	* src/formats.c (cell_format_is_number) : Format always uses standard
      	  decimal chars.
      
      	* src/format.c (gnumeric_setlocale) : New routine that clears cached
      	  locale info.
      	(format_get_decimal) : Improve use mon_decimal.
      	(format_get_thousand) : Improve use mon_thousands_sep.
      	(format_get_arg_sep) : New func.
      	(format_get_col_sep) : New func.
      	(format_destroy) : Use GPtrArray.
      	(render_number) : Improve localization.
      	(format_add_thousand) : rename format_toggle_thousands. De-localize.
      	(find_decimal_char) : De-localize.
      	(format_remove_decimal) : Ditto.
      	(format_add_decimal) : Ditto.
      	(format_number) : Ditto.
      
      	* src/expr.c (do_expr_tree_to_string) : Use format_get_arg_sep.
      
      	* src/cell.c (cell_get_format) : Update for the changes to StyleFormat.
      
      	* src/auto-format.c (auto_style_format_suggest) :
      	  style_format_new -> style_format_new_XL
      
      	* src/mstyle.c (mstyle_element_dump) : There is no direct access to
      	  the format string anymore.
      	(mstyle_set_format_text) : Add a warning.
      
      	* src/gutils.[ch] (float_get_from_range) : Delete.
      	(int_get_from_range) : Ditto.
      
      	* src/parser.y : Revamp lexer to use strtol, and strtod for number
      	  parsing.  Begin hooks for supporting row & col selection. (3:4 or A:B)
      
      	* src/print-info.c (render_value_with_format) : Changes to StyleFormat.
      
      	* src/sheet.h : Move SpanCalcFlags.
      	* src/gnumeric.h : here.
      
      	* src/style.[ch] : Privatize StyleFormat, move it to format.[ch]
      
      	* src/value.c (value_get_as_string) : Correctly localize things for
      	  output.
      
      	* src/workbook-format-toolbar.c (modify_cell_format) : format
      	  modification callback modifies the StyleFormat.
      
      	* src/workbook.c (workbook_set_auto_expr) : Use gnumeric_setlocale.
      
      	* src/xml-io.c (xml_workbook_read) : Use gnumeric_setlocale.
      	(xml_workbook_write) : Ditto.
      	(xml_read_cell) : Use style_format_new_XL.
      	(xml_write_cell_and_position) : Store the number formats in non localized XL form.
      	(xml_write_style) : Ditto.
      
      	* src/dialogs/dialog-cell-format.c (fmt_dialog_init_format_page) :
      	  Display localized number formats.
      	(fillin_negative_samples) : Not need to localize generated number
      	  formats.
      
      	* src/dialogs/dialog-function-wizard.c (formula_guru_set_expr) : Use
      	  format_get_arg_sep.
      
      	* src/dialogs/dialog-stf-format-page.c
      	  (stf_dialog_format_page_prepare) : StyleFormats are now explicitly
      	  stored in a locale neutral format.
      
      	* src/functions/fn-string.c (gnumeric_text) : changes to
      	  style_format_new.
      
      	* src/functions/fn-financial.c (coupdayb) : Silence some warnings.
      
      	* src/functions/fn-information.c (translate_cell_format) : This should
      	  now work for different locales.
      
      2000-08-18  Jody Goldberg <jgoldberg@home.com>
      
      	* src/number-match.c (compute_value) : Extend the match algorithms to
      	  handle the new regexps.
      
      	* src/format.c (format_get_thousand) : provide a better default for
      	  countries using ',' as a decimal point.
      9ad38a63
  6. 13 Jun, 2000 1 commit
    • Jody Goldberg's avatar
      - Initial version of formula guru · 489a4201
      Jody Goldberg authored
      - Some extensions to auto-fill
      - Slight reorg of Bonobo support.
      
      2000-06-13  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook.c : Enable the formula guru, make WorkbookPrivate hold
      	  the BonoboObject in the ENABLED_BONOBO case.
      
      	* src/workbook-edit.c (workbook_finish_editing) : Disconnect any gurus
      	  that may be up.
      	(entry_changed) : Do not autocomplete expressions.  Gurus play havoc
      	  with this.
      	(workbook_edit_auto_complete_init) : Delete unused.
      	(workbook_get_entry_logical) : New function.
      	(workbook_set_entry) : New function.
      	(workbook_edit_attach_guru) : New function.
      	(workbook_edit_detach_guru) : New function.
      	(workbook_editing_expr) : When a guru is up we are always editing an
      	  expression. TODO, tune this.
      	(workbook_edit_load_value) : Moved from Sheet, and renamed from
      	  sheet_load_cell_val.
      	(workbook_edit_init) : Handle gurus.
      
      	* src/sheet.c (sheet_destroy_cell_select_cursor) : Make clearing optional.
      
      	* src/sheet-vector.c (sheet_vector_new) : The vectors are
      	  BonoboObjects, destroy them correctly.
      	(sheet_vectors_shutdown) : Ditto.
      
      	* src/sheet-object.c (sheet_set_mode_type_full) : Silence warning.
      	(sheet_object_insert) : Renamed from sheet_insert_object and moved
      	  from sheet.c
      
      	* src/pixmaps.h : Enable the Formula guru.
      
      	* src/parser.y (arg_list) : Improve handling of empty arguments.
      
      	* src/gnumeric-sheet.c (selection_remove_selection_string) : Use
      	  workbook_get_entry_logical.
      	(selection_insert_selection_string) : Ditto.
      	(start_cell_selection_at) : Ditto.
      	(gnumeric_sheet_key_mode_sheet) : Ditto.
      
      	* src/workbook-private.[ch] : Make this into a Bonobo Object for now.
      
      	* src/embeddable-grid.c (embeddable_grid_init_anon) : Use
      	  workbook_new_with_sheets.
      	(embeddable_grid_new) : WorkbookPrivate is temporarily the bonobo
      	  object.
      
      	* src/history.c (history_menu_item_create) : Ditto.
      	(history_menu_locate_separator) : Ditto.
      	(history_menu_insert_separator) : Ditto.
      	(history_menu_remove_items) : Ditto.
      
      	* src/sheet-object-bonobo.c (sheet_object_bonobo_construct) : Ditto.
      	* src/sheet-object-container.c (sheet_object_container_realize) : Ditto.
      
      	* src/workbook-view.c (workbook_view_set_paste_special_state) : Ditto.
      	(change_menu_label) : Ditto.
      
      	* src/file.c (workbook_try_read) : Workbook is now always just a
      	  GtkObject.
      	(workbook_import) : Ditto.
      
      	* src/formats.c (cell_format_date) : Add some new formats.
      
      	* src/format.c (find_decimal_char) : Restore constness.
      	(format_remove_decimal) : Fix the const correctly.
      
      	* src/commands.c (cmd_ins_del_row_col_redo) : Fix to use the new
      	  semantics.
      
      2000-06-12  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet-autofill.c (fill_item_destroy) : Free the format.
      	(fill_item_new) : Handle filling by month and year.
      	(autofill_compute_delta) : Ditto.
      	(autofill_cell) : Ditto.
      
      	* src/formats.c (cell_format_is_number) : currently handle the single
      	  character currencies.
      	(cell_format_date) : year only formats.
      
      2000-06-10  Jody Goldberg <jgoldberg@home.com>
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_make_cell_visible) : Minor
      	  optimization.
      489a4201
  7. 05 Jun, 2000 1 commit
    • Miguel de Icaza's avatar
      This adds autocompletion. · aa133206
      Miguel de Icaza authored
      It is missing one forced repaint that makes the stuff look slower
      than it is.
      
      2000-06-05  Miguel de Icaza  <miguel@helixcode.com>
      
      	* src/gnumeric-util.c (gtk_radio_button_select): Add
      	precondition.  Chema found this, but we should add the proper
      	check at an upper layer.
      
      2000-06-04  Miguel de Icaza  <miguel@helixcode.com>
      
      	* src/gnumeric-util.c (gnumeric_entry_at_subexpr_boundary_p):
      	Change prototype to use GtkEntry instead of GtkWidget.
      
      	* src/workbook-edit.c (workbook_finish_editing): Changed direct access to
      	workbook->private_entry to workbook_get_entry.
      	(entry_changed): ditto.
      	(workbook_start_editing_at_cursor): ditto.
      	(workbook_editing_expr): ditto.
      	(workbook_edit_get_display_text): ditto.
      
      	* src/workbook.c (autosum_cmd): Changed direct access to
      	workbook->private_entry to workbook_get_entry.
      	(do_focus_sheet): ditto.
      	(wb_edit_key_pressed): ditto.
      	(workbook_setup_edit_area): ditto.
      
      	* src/workbook.c (cb_autofunction): ditto.
      
      	* src/workbook-private.h: Make edit_line a structure to keep track
      	of the entry and its signal changed.  Also take a chance to change
      	this to the self descriptive GtkEntry instead of GtkWidget.
      
      	* src/commands.c (cmd_set_text): Added const here.
      
      	* src/workbook.c (workbook_do_destroy): Add destroy notification
      	for the editing facilities
      
      	* src/item-edit.c (item_edit_set_arg): removed auto complete code
      	from here.
      
      2000-06-03  Miguel de Icaza  <miguel@helixcode.com>
      
      	* src/workbook-edit.c, src/workbook-edit.h: New files.  Moved
      	workbook_start_editing_at_cursor, workbook_finish_editing,
      	workbook_get_entry, workbook_editing_expr here.  Killed
      	workbook_set_entry prototype.
      
      	* src/workbook.c (workbook_start_editing_at_cursor): Moved
      	autocomplete here.
      
      	* src/workbook.h: Removed warning.  #include <config.h> is a
      	mandatory header file in every C file.  A correct approach is to
      	use something like Nautilus' perl script that verifies the
      	presence of config.h as the first include.
      
      	* src/workbook.c (close_cmd): Removed ulgy (void)
      	(quit_cmd): More.
      	(sheet_action_rename_sheet): more.
      	(workbook_finish_editing): Fixed more ugly.
      
      	* src/gutils.c (gnumeric_sys_glade_dir): Fixed ugly indentation.
      	(gnumeric_usr_plugin_dir): More ugly stuff fixed.
      	(gnumeric_usr_dir): Removed ugly const.
      
      2000-05-02  Miguel de Icaza  <miguel@helixcode.com>
      
      	* src/item-edit.h: New ::entry member, auto_max_size, auto_complete_text
      
      	* src/item-edit.c (item_edit_draw_text): Take an ItemEdit as a
      	first argument, and reduce the cluttered arguments we were
      	passing.
      	(item_edit_draw): Cursor_pos is now only the position, it is not
      	overloaded with show/hide cursor as well.
      	(item_edit_draw_text): Update acoordingly.
      	(item_edit_draw_cursor): This new routine paints the cursor only.
      	(item_edit_set_arg): Add a new signal handler for "activated" on
      	the entry
      	(cb_item_edit_cursor_blink): Removed FIXME.
      	(item_edit_set_arg): Init item_edit->entry.  I am pretty sure this
      	existed in the past.
      
      2000-05-01  Miguel de Icaza  <miguel@helixcode.com>
      
      	* src/item-edit.c (item_edit_draw): Pass auto-completing flag.
      	(item_edit_draw_text): Invert auto-complete region.
      	(item_edit_set_arg): Init auto_completing here.
      	(item_edit_complete_notify): Set the entry from the
      	auto-completing data here.
      
      
      2000-06-04  Miguel de Icaza  <miguel@helixcode.com>
      
      	* dialog-function-wizard.c (dialog_function_druid): Use
      	workbook_get_entry here.
      
      	* dialog-printer-setup.c (spin_button_adapt_to_unit): Added
      	g_assert_not_reached ();
      aa133206
  8. 28 May, 2000 1 commit
    • ERDI Gergo's avatar
      Create and insert GtkComboStacks into the toolbar for Undo/Redols · f7ea6af7
      ERDI Gergo authored
      2000-05-28  ERDI Gergo  <cactus@cactus.rulez.org>
      
      	* src/workbook.c: Create and insert GtkComboStacks into the
      	toolbar for Undo/Redols
      
      	* src/commands.c: Use the new undo/redo stack methods
      
      	* src/workbook-view.[ch]: Several new methods to modify the user interface
      	to the undo/redo stack
      f7ea6af7
  9. 04 May, 2000 1 commit
    • Jody Goldberg's avatar
      Desensitize the '=' during editing. · 786d336b
      Jody Goldberg authored
      Fix typ in toolbar init.
      Fix typo in sheet deletion.
      
      2000-05-04  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook.c : Fix typo that was calling undo for redo toolbar.
      	({redo,undo}_cmd) : Use workbook_finish_editing directly.
      	(cb_auto{function,sum}) : If we are already editing do not start.
      	  When the wizard is in place bring it up.
      	(workbook_start_editing_at_cursor) : Make the '=' insensitive while
      	  editing.
      	(workbook_finish_editing) : Make the '=' sensitive.
      	(sheet_action_delete_sheet) : Fix typo and rename parm
      	  'current_sheet' -> 'sheet' to avoid confision with
      	  workbook->current_sheet.
      786d336b
  10. 24 Apr, 2000 1 commit
    • Jody Goldberg's avatar
      Rename ea_status -> selection_descriptor Moved ea_entry here and called it · c2687829
      Jody Goldberg authored
      
      2000-04-24  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook-private.h : Rename ea_status -> selection_descriptor
      	Moved ea_entry here and called it edit_line.
      	* src/workbook.c (workbook_get_entry) : new routine.
      
      	* src/dialogs/function-select.glade : Made this a dialog, not a popup.
      
      	* src/summary.c (summary_item_free) : format police.
      	* src/value-sheet.c (value_area_foreach) : Ditto.
      
      	* src/sheet.c (sheet_new) : Init the update flags to FALSE, rather
      	  than TRUE now that the system seems to be getting their initial
      	  state correct when importing, paging and the like.
      	(sheet_load_cell_val) : Use workbook_get_entry.
      	(sheet_find_boundary_horizontal) : format police.
      	(sheet_find_boundary_vertical) : Ditto.
      	(sheet_range_splits_array) : Ditto.
      	(sheet_delete_{cols,rows}) : Ditto.
      	(sheet_restore_row_col_sizes) : Ditto.
      	(sheet_col_get_distance_{pixels,pts}) : Ditto.
      	(sheet_row_get_distance_pixels) : Ditto.
      	(sheet_row_get_distance_pts) : Ditto, Init accumulator.
      
      	* src/selection.c (sheet_selection_set) : format police.
      	(selection_check_for_array) : Ditto.
      	(sheet_selection_walk_step) : Ditto.
      	* src/sheet-view.c (horizontal_scroll_event) : Ditto.
      	(vertical_scroll_event) : Ditto.
      	* src/dialogs/dialog-cell-format.c : Ditto.
      	* src/dialogs/dialog-printer.c : Ditto.
      	* src/dialogs/dialog-workbook-attr.c : Ditto.
      	* src/functions/fn-eng.c : Ditto.
      	* src/functions/fn-lookup.c : Ditto.
      	* src/functions/fn-string.c : Ditto.
      
      	* src/pattern.c (gnumeric_sheet_patterns) : Add a few patterns for
      	  applix.  More are needed, and these are not available in the format
      	  dialog yet.
      
      	* src/number-match.c (compute_value) : Use g_strtod.
      	(format_match) : Ditto.
      
      	* src/item-edit.c : Use workbook_get_entry.
      
      	* src/item-bar.c (item_bar_event) : format police.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) : Do not set
      	  the focus directly.  Leave that to workbook_start_editing.
      	(gnumeric_sheet_new) : Use workbook_get_entry.
      
      	* src/format.c (render_number) : format police.
      
      	* src/complex.c (complex_from_string) : Use g_strtod.
      	* src/functions/fn-database.c : Ditto.
      
      	* src/colrow.c (cb_row_col_visibility) : format police.
      
      	* src/main.c (gnumeric_main) : Move the workbook_style_test to the
      	  empty case.
      
      	* src/mstyle.c (mstyle_set_pattern) : Add some safety.
      
      	* src/number-match.c (format_match) : Handle empties.
      c2687829
  11. 20 Apr, 2000 1 commit
    • Jody Goldberg's avatar
      Reorg cell contents and assignment. · bedb925b
      Jody Goldberg authored
      Fixs lots of usability details.
      
      2000-04-20  Jody Goldberg <jgoldberg@home.com>
      
      	* src/dialogs/dialog-cell-format.c : Use the edit_pos as the example
      	  not the top left corner.
      
      	* src/functions/fn-stat.c (gnumeric_ftest) : Use eval_pos_cellref
      	  to help localize the strangeness.
      	(gnumeric_ttest) : Ditto.
      
      	* src/xml-io.c (xml_write_cell_and_position) : If this is an array
      	  expression and we are the top left then add attributes to indicate
      	  size of array.  Ignore the rest of the array.
      	(xml_not_used_old_array_spec) : New routinr to handle the old array format.
      	(xml_cell_set_array_expr) : store an array.
      	(xml_read_cell) : Handle the old and the new array formats.
      
      	* src/workbook.c (workbook_close_if_user_permits) : Accept input
      	  first.
      	(wb_edit_key_pressed) : Handle array formulas here.
      	(workbook_detach_sheet) : Do not recalc all if we are exiting.
      	(workbook_start_editing_at_cursor) : When we start editing an
      	  array formula display just the formula not all the extra {}()[][] crap.
      
      	* src/sheet.c (SheetPrivate) : Add a recompute_spans flag.
      	(sheet_calc_spans) : New routine.
      	(sheet_cell_calc_span) : New routine.
      	(sheet_range_calc_spans) : Renamed and extended from
      	  sheet_cells_update.
      	(sheet_update) : Use sheet_calc_spans when necessary.
      	  Update the location region when the edit_pos changes.
      	(cb_recalc_spans_in_col) : Renamed from cb_collect_cells_in_col.
      	  Recalcs spans directly, no need to collect first.
      	(cb_set_cell_content) : New routine to set expr, or expr_and_value.
      	(sheet_range_set_text) : Use cb_set_cell_content, and remember
      	  chosen format with the cell rather than overriding the assigned
      	  format.
      	(sheet_cell_set_text) : Renamed from sheet_set_text.  Be more specific
      	  about how spans, rendering and the rest are handled.
      	(sheet_cell_set_expr) : New routine.
      	(sheet_cell_set_value) : Ditto.
      	(sheet_load_cell_val) : When displaying an array formula add {%s}()[][].
      	(sheet_redraw_cell_region) : Honour spans when redrawing.
      	(sheet_redraw_partial_row) : New routine.
      	(sheet_redraw_cell) : Ditto.
      	(sheet_is_cell_array) : Use cell_is_array.
      	(sheet_range_splits_array) : Renamed from sheet_check_for_partial_array.
      	(sheet_cell_add_to_hash) :  Do not touch spans at this point.
      	(sheet_cell_insert) : Rename from sheet_cell_add made recalc span
      	  optional.
      	(sheet_cell_new) : New routine that does not touch spans.
      	(sheet_cell_remove) : Made redraw optional.
      	(cb_clear_cell_comments) : Remove the cell if there is no comment.
      	(sheet_clear_region) : Remove the cell if there are no comments or
      	  contents.  Flag an update of the status region.
      
      	* src/sheet-view.c (cb_colrow_resize) : New function.
      	(sheet_view_col_size_changed) : Resize all rows, irrespective of
      	(sheet_view_row_size_changed) : existing cells.
      	(sheet_view_redraw_cell_region) : This no longer honours spans.
      
      	* src/sheet-style.c (sheet_style_attach) : Removed call to redraw.
      	sheet_cells_update : rename to sheet_range_calc_spans and move to
      	  sheet.c.
      
      	* src/sheet-autofill.c (autofill_cell) : Use sheet_cell_set_value
      	  rather than set_text.
      
      	* src/selection.c (sheet_selection_changed_hook) : Delete.
      	(sheet_selection_extend_to) : Update the status region to display the
      	  new size.
      	(sheet_selection_cut) : Use sheet_range_splits_array.
      	(selection_check_for_array) : New routine.
      
      	* src/parser.y : Remove icky array formula parsing that conflicted
      	  with array entries.
      
      	* src/number-match.c (format_match) : Return a Value * rather than a
      	  double.
      
      	* src/mstyle.c (mstyle_set_font_size) : Do not allow font sizes < 1.
      
      	* src/main.c (gnumeric_main) : Do NOT create an empty workbook
      	  then delete it if things are successfully loaded.  This causes
      	  a global recalc.  Instead add a flag to disable exit when the
      	  number of workbooks go to zero.  Then only enable the flag AFTER
      	  we have attempted to load the initial workbooks.
      
      	* src/item-grid.c (item_grid_event) : Update the status_region when
      	  button-1 is release.  It should display the edit_pos.
      
      	* src/gutils.c : Move cell_name, col_name, col_from_name,
      	  parse_cell_name, parse_cell_name_or_range and parse_cell_name_list,
      	  to parse-util.c.
      
      	* src/gnumeric.h  : Add RenderedValue.
      
      	* src/gnumeric-util.c (gnumeric_char_start_expr_p) : Move
      	  to parse-util.c
      
      	* src/file.c (workbook_read) : Remove freese thaw usage.
      	  Move call to update AFTER mark clean.
      
      	* src/expr.c (eval_pos_init) : Take a cellpos.
      	(parse_pos_evalpos) : New routine.
      	(eval_pos_cellref) : There is some questionable code scattered in the
      	  functions.  This routing localizes the odd bits for correction.
      
      	* src/eval.c (cell_eval_content) : Use sheet_redraw_cell,
      	  and rendered_value_calc_size.
      	(cell_get_dependencies) : Improve constness.
      
      	* src/corba-sheet.c : Remove the freeze thaw operations.
      	(Sheet_cell_set_formula) : Deleted.
      	(Sheet_range_set_formula) : Delete.
      
      	* src/commands.c : Adjust so that registration of command auto
      	  calls redo.  Add misc checks for splitting arrays.
      
      	* src/clipboard.h : Move the CellCopy types here from cell.h
      
      	* src/clipboard.c (paste_cell) : Use cell_has_expr.
      	  Don't insert the new cell till after its contents are assigned.
      
      	* src/cellspan.c (cell_register_span) : Improve constness.
      	(cell_unregister_span) : Ditto.
      	(row_cell_get_displayed_at) : Delete.
      	(cell_calc_span) : Moved here from cell.c
      
      	* src/dialogs/dialog-stf.glade : Adjust the header background colour
      	  to match the purdy new icon.  Add the icon.
      
      	* src/cell-draw.c : Use the rendered_value routines.
      	  Improve constness.
      
      	* src/analysis-tools.c (set_cell) : Use sheet_cell_fetch.
      
      	*.*
      	    cell_set_* -> sheet_cell_set_
      	    cell_set_*_simple -> cell_set_
      	    Cell::{row,col} -> Cell::{row,col}_info
      	    cell_get_text -> cell_get_entered_text
      	    cell_get_content -> cell_get_entered_text
      	    cell_name -> cell_coord_name
      	    cell_get_formatted_val -> cell_get_rendered_text
      	    cell_get_content -> cell_get_entered_text
      
      	* src/cell.c :
      	(cell_dirty) : Renamed from cell_modified.  Use
      	  sheet_set_dirty.
      	(cell_formula_changed) : Make the queuing of the recalc optional.
      	(cell_cleanout) : Handle union of expression and entered_text,
      	  and remove the rendered value.
      	(cell_copy) : Ditto.
      	(cell_destroy) : handle cell_modified -> cell_dirty.
      	(cell_set_text) : Use parse_text_value_or_expr and store the prefered
      	  format.
      	(cell_set_text_and_value) : New routine.
      	(cell_assign_value) : New routine.
      	(cell_set_value) : Support formats.
      	(cell_set_expr_and_value) : New routine.
      	(cell_set_expr_internal) : Split from cell_set_expr.
      	(cell_set_expr) : Divide to allow for not queuing a recalc.
      	(cell_set_array_formula) : Use cell_set_expr_internal.
      	(cell_is_array) : New utility.
      	(cell_is_partial_array) : New utility.
      	(cell_has_expr) : New utility.
      	(cell_render_value) : Use rendered_value_*.
      	Move all comment routines into cell-comment.[ch].
      
      	* idl/Gnumeric.idl : Remove cell_set_formula, and range_set_formula.
      	  These were identical to set_text.  Made Workbook embeddable.
      bedb925b
  12. 26 Mar, 2000 1 commit
    • Jody Goldberg's avatar
      Make a happy TigerT. · ccc0ed7c
      Jody Goldberg authored
      2000-03-26  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook-format-toolbar.c (change_font_size_in_selection_cmd) :
      	  default size is 10 points.
      	(workbook_create_format_toolbar) : Switch the size selector over to
      	  gtk-combo-text too.
      
      2000-03-26  Jody Goldberg <jgoldberg@home.com>
      
      	* gtk-combo-text.c : Add a hash to be used for proper lookup of
      	  entries made directly in the edit area.  Yes morten it leaks.
      	(gtk_combo_text_construct) : Make scrolling
      	  optional.
      	(gtk_combo_text_add_item) : Add some brute force mouse over effects.
      	  Still need autoscroll, and cancel.
      ccc0ed7c
  13. 12 Mar, 2000 1 commit
    • Jody Goldberg's avatar
      Sensitize/desensitize the ok/cancel buttons. hiding changed shapes. · 61291261
      Jody Goldberg authored
      Re gen glade file.
      
      2000-03-11  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook.c (workbook_setup_edit_area) : Use sensitize rather
      	  than show/hide for the ok/cancel buttons.  Return wizard back
      	  to end of list.
      	(workbook_new) : Revert last change, no longer necessary.
      	(workbook_start_editing_at_cursor) : Sensitize the ok/cancel edit buttons.
      	(workbook_finish_editing) : desensitize them.
      61291261
  14. 11 Mar, 2000 1 commit
    • Jody Goldberg's avatar
      When the edit lined receives focus start editing. (accept_input) : No need · 297927c2
      Jody Goldberg authored
      
      2000-03-11  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook.c (cb_editline_focus_in) : When the edit lined receives
      	  focus start editing.
      	(accept_input) : No need to force edit mode we should already be in
      	  edit mode.
      	(workbook_setup_edit_area) : Move the wizard button to the begining of
      	  the list and store the ok and cancel buttons in the Private section.
      	  Hook cb_editline_focus_in to focus-in.
      	(workbook_new) : After show_all, we need to hide the ok/cancel edit
      	  buttons.  We start out not editing.
      	(workbook_start_editing_at_cursor) : Show the ok/cancel edit buttons.
      	(workbook_finish_editing) : Hide them.
      297927c2
  15. 14 Feb, 2000 1 commit
  16. 06 Feb, 2000 1 commit
    • ERDI Gergo's avatar
      Added myself to the contributors list · b3e9a312
      ERDI Gergo authored
      2000-02-01  ERDI Gergo  <cactus@cactus.rulez.org>
      
      	* src/about.c (dialog_about): Added myself to the contributors list
      
      	* src/widgets/gtk-combo-box.c (gtk_combo_box_popup_hide):
      	explicitly cast function pointers to avoid a warning
      
      	* src/solver-lp.c (simplex_step_three): Default value for `min' to
      	eliminate a warning
      
      	* src/dialogs/dialog-advanced-filter.c: Included ranges.h
      	(removing an `implicit declaration' warning)
      
      	* src/commands.c: Included `dialogs.h'
      
      	* src/workbook.c (workbook_standard_toolbar_orient): Hide the zoom
      	combo box on vertical toolbars
      
      	* src/widgets/gtk-combo-text.[ch]: New widget: easy-to-use combo box
      
      2000-01-28  ERDI Gergo  <cactus@cactus.rulez.org>
      
      	* src/workbook.c (workbook_create_standard_toobar): Added a zoom
      	button to the toolbar as requested
      b3e9a312
  17. 31 Jan, 2000 1 commit
    • Jody Goldberg's avatar
      Move more of the pure view elements into WorkbookPrivate. · a038ab94
      Jody Goldberg authored
      
      2000-01-31  Jody Goldberg <jgoldberg@home.com>
      
      	* src/worksheet.h : Move more of the pure view elements into
      	  WorkbookPrivate.
      
      	* src/sheet.h : Remove include of workbook.h
      
      	* *.c : manually include workbook.h only where we need it.
      
      	* src/ranges.c (parse_range) : Move here from dialog-analysis-tools.c
      	  to avoid warnings.
      
      	* src/corba-workbook.c (Workbook_save_to) : Adjust to new calling
      	  convention.
      	* src/corba-workbook-factory.c (WorkbookFactory_read) : Ditto.
      
      	* src/parser.y : Support interbook references.
      
      	* src/item-bar.c : Ignore scroll-wheel events. Eventually the app will
      	  handle these rather than the grid.
      a038ab94
  18. 02 Jan, 2000 1 commit
    • Miguel de Icaza's avatar
      the last element of a paste was being dropped. · 109202e0
      Miguel de Icaza authored
      2000-01-02  Miguel de Icaza  <miguel@gnu.org>
      
      	* src/clipboard.c (x_selection_to_cell_region): the last element
      	of a paste was being dropped.
      
      2000-01-02  Miguel de Icaza  <miguel@gnu.org>
      
      	* src/workbook-view.c (workbook_view_set_paste_special_state):
      	Renamed this function to suit better its new purpose: only manage
      	the paste special item, as paste can pull the information from the
      	X clipboard.
      
      	* src/parser.y (release_const_tree): New routine used to release
      109202e0
  19. 01 Jan, 2000 1 commit
    • Miguel de Icaza's avatar
      Use application_clipboar_unant here. (gnumeric_sheet_key_mode_object): · fd8a5da2
      Miguel de Icaza authored
      2000-01-01  Miguel de Icaza  <miguel@gnu.org>
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet): Use
      	application_clipboar_unant here.
      	(gnumeric_sheet_key_mode_object): ditto.
      
      	* src/sheet.c (sheet_start_editing_at_cursor): ditto.
      
      	* src/workbook-format-toolbar.c (change_selection_font): ditto
      	(set_selection_halign): ditto
      
      	* src/application.c (application_clipboard_copy): Use defines.
      	(application_clipboard_cut): Use defines.
      	(application_clipboard_unant): New function, less agressive
      	marking of unanting.
      
      	* src/workbook-view.c (workbook_view_set_paste_state): Use
      	named defines instead of arbitrary constants.  Please, no magic
      	constants ever in Gnumeric guys.
      
      	* src/application.c:
      
      	* src/workbook-private.h: Move the menu_item fields to
      	workbook_private.
      fd8a5da2
  20. 31 Dec, 1999 1 commit
  21. 30 Dec, 1999 1 commit
    • Miguel de Icaza's avatar
      New macro, copied from Evolution. We need to refactor our code in Gnumeric · 87152856
      Miguel de Icaza authored
      1999-12-30  Miguel de Icaza  <miguel@gnu.org>
      
      	* src/gnumeric-type-util.h (GNUMERIC_MAKE_TYPE): New macro, copied
      	from Evolution.  We need to refactor our code in Gnumeric to use
      	this macro.
      
      	* src/workbook.c (workbook_do_destroy): Destroy the per-workbook
      	context here.  Hardcoded to be a GUI context for now.
      	(workbook_new): Create the context here.
      	(workbook_command_context_gui): This routine is now the one that
      	returns the command context.
      
      	* src/gnumeric.h: Added CommandCOntext typedef here.
      
      	* All files: renamed CmdContext to CommandContext.
      	renamed command_context_gui to workbook_command_context_gui.
      
      	* src/workbook-view.c: Removed the GUI_CmdContext class setup.
      	* src/command-context.c: Replaced the ad-hoc object system with a
      	GtkObject-based system.
      87152856
  22. 22 Sep, 1999 1 commit
    • Miguel de Icaza's avatar
      Set size here to get correct feedback results. · b99fe1a1
      Miguel de Icaza authored
      1999-09-21  Miguel de Icaza  <miguel@gnu.org>
      
      	* src/sheet.c (cell_is_homogeneous): Set size here to get correct
      	feedback results.
      
      	* src/workbook-format-toolbar.c (change_font_in_selection_cmd):
      	Simplified to use apply_style_to_selection
      	(apply_style_to_selection): Big nice wrapper.
      	(change_font_size_in_selection_cmd): Implement.
      
      	* src/pixmaps.h: Removed GNUMERIC_TEST_ACTIVE_OBJECT for release.
      
      	* src/workbook-format-toolbar.c: More toolbar work, now we have
      	color selectors for foreground and background.
      
      	* src/workbook.c: Split the format toolbar
      
      	* src/workbook-format-toolbar.[ch]: Now they contain the
      	format-toolbar code.
      
      	* src/sheet-object-graphic.c (sheet_object_filled_realize): Width
      	is now in points, not pixels.
      
      	* src/widgets/gtk-combo-box.[ch]: New files, they implement an
      	extensible ComboBox for Gtk.
      
      	* src/widgets/color-combo.[ch]: New files, they implement the
      	ColorCombo box.
      b99fe1a1