1. 24 Sep, 2000 2 commits
    • Jody Goldberg's avatar
      Suppress some warnings and make non-bonobo build clean. · a9a20284
      Jody Goldberg authored
      2000-09-24  Jody Goldberg <jgoldberg@home.com>
      
      	* src/normal-args.c : Suppress warning.
      
      	* src/functions/fn*.c : Add a prototype of the _init routine to
      	  suppress warning.
      
      	* src/eval.c (cell_recalc_dependencies ) : Comment out until it is
      	  implemented.
      
      	* src/sheet-object-widget.c (sheet_object_widget_new) : delete.
      a9a20284
    • Jody Goldberg's avatar
      Attempt to inject the standard controls. This does not work. Continue work · 0361f272
      Jody Goldberg authored
      
      2000-09-23  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook.c (workbook_create_standard_toobar) : Attempt to inject
      	  the standard controls.  This does not work.
      	* src/gnumeric.xml : Continue work on bonobizing toolbars.
      
      2000-09-23  Jody Goldberg <jgoldberg@home.com>
      	For : realms@telerama.com
      
      	* src/datetime.c (datetime_g_days_between) : new function.
      	(datetime_g_months_between) : Ditto.
      	(datetime_g_years_between) : Ditto.
      
      	* src/functions/fn-date.c : Implement DateDif.
      
      2000-09-23  Jody Goldberg <jgoldberg@home.com>
      
      	* src/clipboard.c (x_selection_to_cell_region) : typo.
      
      	* src/gnumeric-util.c (gnumeric_inject_widget_into_bonoboui) : New
      	  utility routine.
      0361f272
  2. 23 Sep, 2000 3 commits
    • JP Rosevear's avatar
      Create an IDL_FLAGS variable with various paths based on GNOME_PATH · c8f3fe50
      JP Rosevear authored
      2000-09-23  JP Rosevear  <jpr@helixcode.com>
      
      	* configure.in: Create an IDL_FLAGS variable with various paths based
      	on GNOME_PATH
      
      	* idl/Makefile.am: Use IDL_FLAGS
      c8f3fe50
    • Almer S. Tigelaar's avatar
      return invalid character or NULL if the data is valid. · 8aad5f3a
      Almer S. Tigelaar authored
      2000-09-23  Almer S. Tigelaar  <almer1@dds.nl>
      
      	* src/stf-parse.c, src/stf-parse.h:
      	(stf_parse_is_valid_data): return invalid character
      	or NULL if the data is valid.
      
      	* src/clipboard.c:
      	(stf_read_workbook): Adjust to cope with the new
      	stf_parse_is_valid_data.
      
      	* src/stf.c:
      	(x_selection_to_cell_region): Idem.
      8aad5f3a
    • Jody Goldberg's avatar
      Use stock icons. Ditto. Ditto. Add more verbs. · 1c9409f7
      Jody Goldberg authored
      
      2000-09-23  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook-format-toolbar.c : Use stock icons.
      	* src/workbook-object-toolbar.c : Ditto.
      	* src/workbook.c : Ditto.  Add more verbs.
      
      	* src/workbook-edit.c (workbook_edit_set_sensitive) : toolbar
      	  sensitization is broken for bonobo.
      
      	* src/gnumeric.xml : The beginings of toolbar support.
      
      	* src/application.c : Register all pixmaps as stock icons.
      
      2000-09-22  Jody Goldberg <jgoldberg@home.com>
      
      	* src/history.c (history_menu_insert_separator) : Use
      	  history_menu_locate_separator.  This is crufty.
      1c9409f7
  3. 22 Sep, 2000 6 commits
    • Morten Welinder's avatar
      Increase buffer size, just in case. (append_hour_elapsed): Ditto. · 63e185e6
      Morten Welinder authored
      2000-09-22  Morten Welinder  <terra@diku.dk>
      
      	* src/format.c (append_hour): Increase buffer size, just in case.
      	(append_hour_elapsed): Ditto.
      	(append_minute): Ditto.
      	(append_second): Ditto.
      	(append_minute_elapsed): Sort-of ditto.
      	(append_second_elapsed): Ditto.
      	(append_hour): Fix hour display for am/pm mode for the midnight
       	and noon hours.
      63e185e6
    • Morten Welinder's avatar
      Use bigger stack buffer so we will almost never have to allocate · 84b81c0e
      Morten Welinder authored
      2000-09-22  Morten Welinder  <terra@diku.dk>
      
      	* src/print-cell.c (print_show_iso8859_1): Use bigger stack buffer
       	so we will almost never have to allocate dynamically.
      84b81c0e
    • Jody Goldberg's avatar
      Check buttons actually work now. · 687f3661
      Jody Goldberg authored
      The range selection looks aweful, but it is a start.
      687f3661
    • Jody Goldberg's avatar
      redraw the selection. redraw the selection. · fafbc8cf
      Jody Goldberg authored
      
      2000-09-21  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_hide_cursor) : redraw the selection.
      	* src/sheet.c (sheet_show_cursor) : redraw the selection.
      
      	* src/sheet-object.c : Improve framework for editing/creating objects.
      	  We are more consistent about hiding the selection, and when to make
      	  things visible again.
      
      	* src/sheet-object-widget.c : Begin framework for configuring the
      	  sheet widgets.
      
      	* src/selection.c (sheet_selection_redraw) : new function.
      
      	* src/item-grid.c (item_grid_button_1) : Don't cancel object editing
      	  if there is a guru up.  We could be configuring things.
      
      	* src/selection.c (sheet_is_cell_selected) : Do no show selections
      	  while objects are being edited.
      
      	* src/gnumeric-util.c (gnumeric_non_modal_dialog) : Change the
      	  signature.
      
      	* src/sheet-object.c (sheet_object_destroy) : Improve safety.
      fafbc8cf
    • Lauris Kaplinski's avatar
      b892d363
    • Jody Goldberg's avatar
      implement. · 958108da
      Jody Goldberg authored
      
      2000-09-21  Jody Goldberg <jgoldberg@home.com>
      
      	* src/format.c (format_month_before_day) : implement.
      
      	* src/workbook.c (workbook_expr_relocate) : Support dependents other
      	  than cells.
      	(workbook_expr_unrelocate) : Ditto.
      958108da
  4. 21 Sep, 2000 3 commits
    • Jody Goldberg's avatar
      Temp fix to get things compiling. What should we be using? · 9e3e7802
      Jody Goldberg authored
      
      2000-09-21  Jody Goldberg <jgoldberg@home.com>
      
      	* src/print-cell.c (print_show_iso8859_1) : Temp fix to get things
      	  compiling.  What should we be using?
      9e3e7802
    • Jody Goldberg's avatar
      warning suppression. · 3b0a67ec
      Jody Goldberg authored
      3b0a67ec
    • Jody Goldberg's avatar
      no need to translate the money format. We generate it elsewhere. · cec33cc8
      Jody Goldberg authored
      
      2000-09-21  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook-format-toolbar.c (workbook_cmd_format_as_money) :
      	  no need to translate the money format.  We generate it elsewhere.
      	(workbook_cmd_format_as_percent) : ditto.
      
      	* src/formats.c : Most format strings are NOT required to be
      	  translated anymore.  We store them internaly in the C locale.
      	(currency_date_format_init) : customize the currency symbol, and the
      	  day/month order.
      
      	* src/format.c (format_get_currency) : new function.
      	(format_month_before_day) : New stub.  How to do this portably.
      	(lookup_color_by_name) : new routine.
      	(lookup_color) : that was split from here.
      	(format_remove_decimal) : Fix a bit.  still broken for fmts with
      	  multiple cases.
      	(format_value) : no need to translate the format.
      	(translate_format_color) : new routine.
      	(style_format_delocalize) : new routine.  Add colour support.
      	(style_format_new_XL) : split from here.
      	(style_format_str_as_XL) : new routine.  Add colour support.
      	(style_format_as_XL) : split from here.
      
      2000-09-20  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet-object.c (sheet_object_destroy) : If the current object is
      	  destroyed switch back to edit mode.
      cec33cc8
  5. 20 Sep, 2000 3 commits
  6. 19 Sep, 2000 4 commits
    • Morten Welinder's avatar
      isdigit takes unsigned chars, not chars. · 8e1c25c3
      Morten Welinder authored
      2000-09-19  Morten Welinder  <terra@diku.dk>
      
      	* src/workbook.c (workbook_sheet_name_strip_number): isdigit takes
       	unsigned chars, not chars.
      
      	* src/functions/fn-lookup.c (find_index_linear): Quiet warnings.
      
      
      2000-09-19  Morten Welinder <terra@diku.dk>
      
      	* applix-read.c (applix_read_colormap): isdigit takes unsigned
       	chars, not chars.
      	(applix_parse_style): Ditto.
      	(applix_read_impl): Ditto.
      8e1c25c3
    • Michael Meeks's avatar
      add GNOME_DATADIR · db53dfa6
      Michael Meeks authored
      2000-09-18  Michael Meeks  <michael@helixcode.com>
      
      	* src/Makefile.am (INCLUDES): add GNOME_DATADIR
      
      	* src/workbook.c (workbook_new): use it.
      db53dfa6
    • Jody Goldberg's avatar
      Woohoo! The last of the release critical bugs are done. · b121e5da
      Jody Goldberg authored
      2000-09-18  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_row_size_fit_pixels) : PUTRID KLUDGE.
      	  Avoid the ugly row size changes when fitting the size.
      
      	* src/format.c (style_format_new_XL) : Implement translation.
      	(style_format_as_XL) : Ditto.
      
      	* src/number-match.c (format_match_init) : No need to compare to
      	  translated General.
      
      	* src/sheet.c (sheet_flag_status_update_cell) : Adjust signature.
      b121e5da
    • Jody Goldberg's avatar
      Bug 24122 · 62fd10ba
      Jody Goldberg authored
      2000-09-18  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_flag_status_update_cell) : Adjust signature.
      
      2000-09-18  Jody Goldberg <jgoldberg@home.com>
      
      	* dialog-solver.c (dialog_solver) : No need to create a cell manually
      	  and fill with empty.  sheet_cell_fetch will handle that.
      
      	* dialog-goal-seek.c (dialog_goal_seek) : No need to create cell
      	  locally.
      	(gnumeric_goal_seek) : Update size, span, and status region for the
      	  cell that was being tweaked.  While solving we did not update it.
      62fd10ba
  7. 18 Sep, 2000 1 commit
    • Morten Welinder's avatar
      Leak and crash fixes. · bae5583d
      Morten Welinder authored
      
      2000-09-17  Morten Welinder  <terra@diku.dk>
      
      	* src/main.c (gnumeric_main): Init colours earlier.
      
      
      2000-09-17  Morten Welinder  <terra@diku.dk>
      
      	* dialog-autoformat.c (dialog_autoformat): Free "info" only when
       	done with it.  Free tooltips using unref, not plain g_free.
      bae5583d
  8. 17 Sep, 2000 3 commits
    • Jody Goldberg's avatar
      We need to recalc the size after rendering the value. However, it is · df403993
      Jody Goldberg authored
      
      2000-09-17  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook.c (cb_cell_rerender) : We need to recalc the size
      	  after rendering the value.  However, it is wasteful to redraw each
      	  cell individually.
      	(cb_sheet_pref_display_formulas) : redraw entire sheet.  It is
      	  simpler.
      df403993
    • Jody Goldberg's avatar
      Use the newly minted Gnome Application Library (GAL) · 031ceea8
      Jody Goldberg authored
      2000-09-17  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook-format-toolbar.c : Use the new Gnome App Libs (GAL)
      	  routines.
      	* src/workbook-view.c : Ditto.
      	* src/workbook.c : Ditto.
      
      	* src/main.c (gnumeric_main) : call e_color_init and e_color_shutdown.
      
      	* src/gnumeric-util.c (gnumeric_create_tooltip) :
      	  Rename from color -> e_color.
      	* src/style.c (style_color_new) : Ditto.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_realize) :
      	  Rename from cursor -> e_cursor.
      	* src/item-cursor.c (item_cursor_set_cursor) : Ditto.
      	* src/cell-comment.c (cell_comment_clicked) : Ditto.
      	* src/item-grid.c (item_grid_event) : Ditto.
      	* src/sheet-object.c : Ditto.
      
      	* src/color.c : Split the utilities into the gal library.
      
      	* src/Makefile.am : Remove cursors.[ch]
      
      	* configure.in : Handle the new Gnome App Lib (GAL)
      031ceea8
    • Jody Goldberg's avatar
      GraphSeries is responsible for registering. · 8259d107
      Jody Goldberg authored
      2000-09-17  Jody Goldberg <jgoldberg@home.com>
      
      	* src/dialogs/dialog-graph-guru.c (cb_create_series_from_range) :
      	  GraphSeries is responsible for registering.
      
      	* src/history.c : Attempt to convert to the new bonobo ui handler.
      
      	* src/graph-series.c (graph_series_eval) : Support string and date
      	  series.
      	(series_get_name) : New function.
      	(impl_vector_scalar_value) : Use it here.
      	(impl_vector_date_value) : here
      	(impl_vector_string_value) : and here.
      	(cb_check_range_for_pure_string) : new function.
      	(graph_series_new) : Start guess whether a series is scalar or string.
      	(graph_series_servant) : Delete.
      	(graph_series_set_subscriber) : Take responsibility for registering
      	  with the remote Graph::Manager.
      
      	* src/gnumeric.xml : Remove bogus '/menu/File/open' placeholder
      	  Name the '/menu/File/FileHistory' placeholder.
      
      	* src/sheet-object-container.c (sheet_object_container_update_bounds)
      	  Fix off by 1 error here.
      	(make_container_item) : And here.
      
      	* src/sheet-object.c (sheet_object_add_view) : Renamed from
      	  sheet_view_object_realize.
      	(sheet_object_remove_view) : Renamed from sheet_view_object_unrealize.
      	(control_point_handle_event) : Enable edit popup from control points.
      8259d107
  9. 16 Sep, 2000 3 commits
    • Almer S. Tigelaar's avatar
      Remove ability to focus widgets on the Template Details tab. Remove the · 2f343484
      Almer S. Tigelaar authored
      2000-09-16  Almer S. Tigelaar  <almer1@dds.nl>
      
      	* src/dialogs/autoformat.glade:
      	Remove ability to focus widgets on the Template Details tab.
      	Remove the 'Apply Dimensions' checkbox.
      	Add some accelerators.
      	Add tooltip to category combo.
      
      	* src/dialogs/dialog-autoformat.c:
      	(cb_category_entry_changed): Replaced by cb_category_popwin_hide
      	(cb_category_popwin_hide): Invoked when the popup window of
      	the category window becomes hidden.
      	(dialog_autoformat): Remove handling for dimensions checkbox and
      	change signal binding for category combo.
      2f343484
    • Michael Meeks's avatar
      use datadir for get_ui_fname. · 8a6b93ff
      Michael Meeks authored
      2000-09-16  Michael Meeks  <michael@helixcode.com>
      
      	* src/workbook.c (workbook_new): use datadir for get_ui_fname.
      8a6b93ff
    • Almer S. Tigelaar's avatar
      New autoformat dialog. · 42aa39da
      Almer S. Tigelaar authored
      2000-09-16  Almer S. Tigelaar  <almer1@dds.nl>
      
      	* src/dialogs/autoformat.glade:
      	New autoformat dialog.
      
      	* src/dialogs/dialog-autoformat.c:
      	(fill_category_list): Replace with load_categories.
      	(load_categories): Same role as fill_category_list, but
      	loads them into a GtkList instead.
      	(free_categories): New, frees a GtkList holding categories.
      	(templates_load): Hide the scrollbar when it's not needed, remove
      	obsolete label code.
      	(previews_load): Set only the template name as tooltip.
      	(cb_more_clicked): Removed entirely, the more button is no longer.
      	(cb_new_clicked): Replaced by cb_new_activated.
      	(cb_new_activated): Same as cb_new_clicked but now
      	for a GtkMenuItem.
      	(cb_edit_clicked): Replaced by cb_edit_activated.
      	(cb_edit_activated): Same as cb_edit_clicked but now
      	for a GtkMenuItem.
      	(cb_remove_clicked): Replaced by cb_remove_current_activated.
      	(cb_remove_current_activated): Same as cb_remove_clicked but now
      	for a GtkMenuItem.
      	(cb_categories_select_row): Replace with cb_category_entry_changed.
      	(cb_category_entry_changed): New, same role as cb_categories_select_row,
      	but now for the 'category' GtkEntry instead of the previous GtkCList.
      	(cb_apply_button_toggled): Replaced by cb_apply_item_toggled.
      	(cb_apply_item_toggled): Same as cb_apply_item_toggled, but now for
      	GtkCheckMenuItem.
      	(cb_gridlines_button_toggled): Replaced by cb_gridlines_item_toggled.
      	(cb_gridlines_item_toggled): Same as cb_gridlines_item_toggled, but now
      	for GtkCheckMenuItem.
      	(setup_apply_item): New, load a glade control and bind it's event to
      	cb_apply_item_toggled in one step.
      	(dialog_autoformat): Adjusted to handle the new controls.
      42aa39da
  10. 15 Sep, 2000 3 commits
    • Jody Goldberg's avatar
      Profilacticly NULL the gui pointer. · c6903e61
      Jody Goldberg authored
      
      2000-09-15  Jody Goldberg <jgoldberg@home.com>
      
      	* src/dialogs/dialog-graph-guru.c (dialog_graph_guru) : Profilacticly
      	  NULL the gui pointer.
      c6903e61
    • Jody Goldberg's avatar
      Use placeholder for file history. How to have multiple place holders ? · d50e95d8
      Jody Goldberg authored
      
      2000-09-15  Jody Goldberg <jgoldberg@home.com>
      
      	* src/gnumeric.xml : Use placeholder for file history.
      	  How to have multiple place holders ?
      
      	* src/history.c (history_menu_insert_items) : Quick fix to reduce
      	  number of warnings.
      
      	* src/sheet-object.c (sheet_object_stop_editing) : Use set_active.
      	(sheet_mode_edit_object) : Ditto.
      d50e95d8
    • Jody Goldberg's avatar
      Fix off by one error. (sheet_object_widget_update_bounds) : Ditto. · f2e1b498
      Jody Goldberg authored
      
      2000-09-14  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet-object-widget.c (sheet_object_widget_new_view) : Fix off
      	  by one error.
      	(sheet_object_widget_update_bounds) : Ditto.
      	(control_point_handle_event) : Handle events for the acetate.
      
      	* src/sheet-object.c (sheet_object_destroy_control_points) : Avoid
      	  hard coding the number of control points.
      	(sheet_object_begin_creation) : event coordinates are already mapped.
      	(update_bbox) : The off by 1 error was in the widget wrapper not here.
      
      	* idl/gnumeric-graphs.idl : Make the Vector::changed routines oneway.
      f2e1b498
  11. 14 Sep, 2000 1 commit
    • Jody Goldberg's avatar
      Use sheet_selection_full_rows and workbook_cmd_format_row_height. · 01af4e73
      Jody Goldberg authored
      
      2000-09-14  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet-view.c (sheet_view_row_size_changed) : Use
      	  sheet_selection_full_rows and workbook_cmd_format_row_height.
      	(sheet_view_col_size_changed) : Use
      	  sheet_selection_full_cols and workbook_cmd_format_column_width.
      
      	* src/item-grid.c (context_row_height) : Use sheet_dialog_set_row_height.
      	(context_col_width) : Use sheet_dialog_set_column_width.
      
      	* src/workbook-cmd-format.c (sheet_dialog_set_column_width) : Split
      	  the gui into here.
      	(workbook_cmd_format_column_width) : And the action into here.  Use
      	  the appropriate commands to get undo support.
      	(workbook_cmd_format_column_auto_fit) : Use workbook_cmd_format_column_width.
      	(sheet_dialog_set_row_height) : Split the gui into here.
      	(workbook_cmd_format_row_height) : And the action into here.  Use
      	  the appropriate commands to get undo support.
      	(workbook_cmd_format_row_auto_fit) : Use workbook_cmd_format_row_height.
      
      	* src/selection.c (sheet_row_selection_type) : moved from sheet.c
      	(sheet_col_selection_type) : moved from sheet.c
      	(sheet_selection_full_cols) : new routine.
      	(sheet_selection_full_rows) : new routine.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) : Don't jump
      	  directly to the edit line with F2.  Start editing in sheet first.
      
      	* src/selection.c (selection_foreach_range) : Add the option of
      	  iterating the list backwards.
      
      	* src/workbook-cmd-format.c (cb_colrow_collect) : New function.
      
      	* src/workbook-cmd-format.c (workbook_cmd_format_column_width) : Fix.
      	(workbook_cmd_format_row_height) : Fix.
      
      	* src/sheet-object-graphic.c (sheet_object_graphic_update_bounds) :
      	  new function.
      	(sheet_object_filled_new_view) : Set the bounds when a new view is
      	  constructed.  DO NOT rely on the realized list, new objects are not
      	  added until AFTER construction.
      	* src/sheet-object.c (sheet_object_update_bounds) : delete.
      
      2000-09-13  Jody Goldberg <jgoldberg@home.com>
      
      	* src/expr.c (cellref_relocate) : Return more information so that we
      	  can differentiate relocating rows, cols, or both.
      	(cellrange_relocate) : Use the new information to extend the
      	  heuristic for when to relocate a range.  In the past we assumed that
      	  unless both ends of the range were moving we should not do the
      	  relocation.  It seems that there are other cases which will also
      	  relocate.  When inserting/deleting rows/cols or cutting a region
      	  that includes an entire side of the source region we should
      	  relocate.
      	  Sadly this patch is incomplete.  It relocates too much now.
      	  If you cut B2 and paste it into B3 the source region A1:B2 will
      	  resize to A1:B3 even though it should not.  At least ins/del row/col
      	  will now work.
      
      2000-09-12  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook.c (create_bonobo_object) : Fixed.
      
      	* src/sheet-object-bonobo.c (sheet_object_bonobo_new_from_oid) :
      	  Delete duplicate function.
      
      2000-09-11  Jody Goldberg <jgoldberg@home.com>
      
      	* src/commands.c (cmd_ins_del_row_col_{undo,redo}) : Insert/delete
      	  rows/cols clears the cut buffer.  Copies are preserved.
      
      	* src/sheet-object.c (cb_obj_create_button_release) :  remove the
      	  bonobo specific file handling.  That is to be done earlier
      	  or in a different place.  This routine is strictly for placement,
      	  not content.
      	(sheet_mode_clear) : Move the deactivation here for now.  Hopefully
      	  move it to a virtual.
      
      	* src/about.c (dialog_about) : suppress warning.
      01af4e73
  12. 12 Sep, 2000 1 commit
    • Morten Welinder's avatar
      It's not pining, it's passed on. This leak is no more. · e1167fe4
      Morten Welinder authored
      It has ceased to be. It's expired and gone to meet its
      maker. This is a late leak. It's a stiff. Bereft of life, it
      rests in peace. If you hadn't nailed it to the perch, it
      would be pushing up the daisies. It's rung down the
      curtain and joined the choir invisible. This is an
      ex-leak.
      
      (ahem)
      e1167fe4
  13. 11 Sep, 2000 6 commits
    • Jon K Hellan's avatar
      Add print_debugging variable / debug_print startup option. · a8e8311c
      Jon K Hellan authored
      2000-09-11  Jon K Hellan  <hellan@acm.org>
      
      	* src/main.c: Add print_debugging variable / debug_print startup
      	option.
      	(gnumeric_main): Make stdout line buffered - we only use it for
      	debug info.
      
      	* src/print-cell.[ch] (print_make_rectangle_path): New function: make
      	a rectangular gnome-print path.
      	* src/print-cell.c (print_cell): Use it.
      
      	* src/print.c (print_empty_pages variable): Remove. This variable
      	is never set. With the new repeated row/column handling, the logic
      	will have to be rewritten anyway if needed.
      	(print_page_repeated_rows): Remove unused parameters start_row and
      	end_row.
      	(print_page_repeated_cols): s/row/col/. Fix bug - was repeat_left,
      	corrected to repeat_top.
      	(print_page_object): Remove unused parameters page_width /
      	page_height and end_col / end_row.
      	(print_hf_element): Rename from print_hf
      	(print_hf_line): New function. Logic shared by print_header and
      	print_footer. Clip to header region. if print_debugging != 0, draw
      	a box around header region.
      	(print_headers): Use print_hf_line. Place at correct y position -
      	ascenders flush with inside of top margin.
      	(print_footers): Descenders flush with inside of bottom
      	margin. Otherwise like headers.
      	(print_page): Include logic for repeated rows and columns: They
      	are only repeated after the start of the repeating range has been
      	seen in the regular page flow. Fix grid size bug when centering
      	horizontally or vertically. Use print_make_rectangle_path.  Remove
      	print_empty_pages logic.
      	(compute_group): New function. Old compute groups changed to only
      	compute one page. Rationale: Available space on page for normal
      	cell flow changes once repeated rows/columns kick in, so there is
      	no gain in precomputing a list.
      	(render_sheet_objects): New function. Factored out of
      	print_sheet_range.
      	(print_range_down_then_right): New function. Used to be the row
      	major loop of print_sheet_range. Include logic for repeated rows
      	and columns (see print_page).
      	(print_range_right_then_down): s/row major/column major/
      	(print_sheet_range): Restructure into a small function that calls
      	render_sheet_objects, print_range_down_then_right,
      	print_range_right_then_down.
      	(compute_sheet_pages): Remove print_empty_pages logic. The
      	variable is never set. With the new repeated row/column handling,
      	the logic will have to be rewritten anyway if needed.
      	(compute_sheet_pages, print_sheet): Remove "key" parameter because
      	we are now called from g_list_foreach instead of
      	g_hash_table_foreach.
      
      	(compute_pages): Use list returned by workbook_sheets instead of
      	wb->sheets so sheets are processed in order.
      	(workbook_print_all): Print sheets in display order. To do so, use
      	list returned by workbook_sheets instead of wb->sheets.
      	(sheet_print): Use changed print_sheet signature.
      
      	* src/workbook.h (struct _Workbook): Rename "sheets" to
      	sheet_hash_private.
      
      	* src/workbook.c (workbook_do_destroy, workbook_do_destroy,
      	workbook_set_dirty, workbook_is_dirty, workbook_is_pristine,
      	workbook_init, workbook_rename_sheet, workbook_sheet_count,
      	workbook_attach_sheet, workbook_detach_sheet,
      	workbook_sheet_lookup): s/wb->sheets/wb->sheet_hash_private/
      	(cb_assemble_selection, workbook_selection_to_string): Not in
      	use. Remove.
      
      	* src/workbook-view.c (workbook_view_pref_visibility):
      	s/wb->sheets/wb->sheet_hash_private/
      a8e8311c
    • Morten Welinder's avatar
      Quiet the test. · da9afceb
      Morten Welinder authored
      2000-09-11  Morten Welinder  <terra@diku.dk>
      
      	* configure.in (pspell): Quiet the test.
      da9afceb
    • Jody Goldberg's avatar
      forgot the ChangeLog · 8f32563c
      Jody Goldberg authored
      8f32563c
    • Michael Meeks's avatar
      s/BonoboApp/BonoboWin/ · d977550f
      Michael Meeks authored
      2000-09-11  Michael Meeks  <michael@helixcode.com>
      
      	* src/workbook-format-toolbar.c: s/BonoboApp/BonoboWin/
      
      	* src/workbook-object-toolbar.c: ditto.
      
      	* src/workbook.c: s/BonoboApp/BonoboWin/
      	(verbs): Add FileSaveAs which I seem to have forgotten.
      d977550f
    • Jody Goldberg's avatar
      Plug some leaks. · 94beb3ab
      Jody Goldberg authored
      94beb3ab
    • Jody Goldberg's avatar
      The initial version of active objects. · ccdc4a78
      Jody Goldberg authored
      2000-09-10  Jody Goldberg <jgoldberg@home.com>
      
      	* src/xml-io.c (xml_read_sheet_object) : objects have their positions
      	  set after creation, not before.
      	NOTE : This routine is incomplete.  It does not handle all of the
      	  objects.  It is questionable whether or not it even belongs here.
      	  We may want to encapsulate the persistence on a per object basis.
      	(xml_sheet_read) : localize and improve variable naming.
      
      	* src/workbook.c : Add an ifdef around the GnomeUI handler in bonobo
      	  mode.  Move the object creation cruft into its own file.
      	(select_component_id) : new function.
      	(create_embedded_component_cmd) : simplify.
      	(create_embedded_item_cmd) : simplify.
      	(create_button_cmd) : Delete.
      	(create_checkbox_cmd) : Delete.
      	(create_line_cmd) : Delete.
      	(create_arrow_cmd) : Delete.
      	(create_rectangle_cmd) : delete.
      	(create_ellipse_cmd) : delete.
      	(cut_cmd) : simplify object handling.
      	(insert_object_cmd) : Use sheet_object_bonobo_new_from_oid.
      	(do_focus_sheet) : Handle object toolbar too.
      	(workbook_detach_sheet) : Before messing with the views go back to
      	  simple edit mode.
      
      	* src/workbook-object-toolbar.c (create_object_command) : new
      	  function.
      	(cmd_create_*) : Use here.
      
      	* src/workbook-edit.c (workbook_edit_set_sensitive) : Add the object
      	  toolbar.
      
      	* src/sheet-object.c (sheet_release_coords) : delete.
      	(sheet_object_destroy) : simplify.
      	(SheetObject::end_popup) : remove.
      	(SheetObject::populate_menu) : rename from start_popup.
      	(SheetObject::new_view) : rename from realize.
      	(SheetObject::user_config) : New virtual.
      	(sheet_object_construct) : initialize dragging to FALSE.
      	  s/Sheet::objects/Sheet::sheet_objects/
      	(sheet_object_drop_file) : Moved.
      	(sheet_object_realize) : No need for SheetView::temp_item.
      	(button_widget_create) : delete.
      	(checkbox_widget_create) : delete.
      	(sheet_object_create_button) : delete.
      	(sheet_object_create_checkbox) : delete.
      	(create_object) : delete.
      	(cb_obj_create_motion) : rename from sheet_motion_notify.  Simplify.
      	  Rubber band a rectangle rather than the actual object.
      	  Keep track of whether or not a we have resized larger than the
      	  minimum 5x5 size.
      	(cb_obj_create_button_release) : rename from sheet_button_release.
      	  Change behavior to have the release do the realizing and bound
      	  setting.  Set the bounds to the current coord ONLY if we have moved
      	  enough, otherwise just use the default size of the object tranformed
      	  to the location of the original button press.
      	(shutdown_sheet_object_creation) : merge into button release.
      	(sheet_leave_notify) : Delete.
      	(sheet_button_press) : Delete.
      	(sheet_object_begin_creation) : Delete.
      	(sheet_finish_object_creation) : merge into button release and clear
      	  out all the cruft requiring removal of signals.
      	(sheet_mode_clear) : new function.  Does some object management.
      	(sheet_set_mode_type) : delete.
      	(sheet_set_mode_type_full) : delete content.  Split logical action into.
      	(sheet_mode_edit) : here.
      	(sheet_mode_edit_object) : here.
      	(sheet_mode_create_object) : and here.
      	(sheet_object_destroy_control_points) : be more pedantic a about
      	  checking that we have a valid view.
      	(sheet_object_stop_editing) : Adjust for new object editing semantics.
      	(set_item_x) : Merge this
      	(set_item_y) : and this.
      	(set_item_x_y) : into here.  And add the logic to call
      	  new_control_point.
      	(new_control_point) : Set the cursor here.
      	(update_bbox) : Recall that the bounding box excludes the far coords.
      	(control_point_handle_event) : No need to make object the current, if
      	  we are being called we are current.
      	(sheet_object_populate_menu) : rename from sheet_object_start_popup.
      	(sheet_object_end_popup) : delete.
      	(sheet_object_canvas_event) : adjust to function renaming.
      	(sheet_object_widget_event) : delete.
      	(sheet_object_widget_handle) : delete.
      	(sheet_object_start_editing) : delete, no need.  update_bbox does all
      	  of this.
      	(sheet_object_make_current) : delete.
      	(sheet_object_insert) : this was not what its name suggested.  It was
      	  a rather specialized bonobo utility.  Move it where it belongs.
      
      	* src/sheet-object-widget.c : Rewrite.
      
      	* src/sheet-object-item.c (sheet_object_item_new_view) : rename from
      	  sheet_object_item_realize.
      
      	* src/sheet-object-graphic.c (sheet_object_graphic_new_view) :
      	  rename from sheet_object_graphic_realize.
      	(sheet_object_filled_new_view) : renamed from sheet_object_filled_realize.
      	(sheet_object_create_line) : No need to take position, do that later.
      	(sheet_object_create_filled) : Ditto.
      
      	* src/sheet-object-container.c (user_activation_request_cb) : Adjust
      	  to changes in sheet mode handling.
      	(sheet_object_container_new_view) : rename from sheet_object_container_realize.
      	(sheet_object_container_new_bonobo) : No need to take pos info, that
      	  is set later.
      	(sheet_object_container_new_object) : Ditto.
      	(sheet_object_container_new_file) : Moved and renamed from sheet_object_drop_file.
      
      	* src/sheet-object-bonobo.c (sheet_object_bonobo_construct) : No need
      	  to take position info.  Bounds are set later.
      	(sheet_object_bonobo_new_from_oid) : Move from sheet_object_insert
      	  which was much to generic a name and location for this.
      
      	* src/print.c (print_sheet_range) : Adjust to rename of the
      	  sheet_object list.
      
      	* src/pixmaps.h : Remove the pixmaps that moved to the object toolbar.
      
      	* src/item-grid.c (item_grid_button_1) : Handle object creation and
      	  finishing object editing directly, no more need for adding and
      	  removing handlers.  Adjust arg to be a Button event.
      	(item_grid_event) : Add a new cursor for object creation.
      	(item_grid_event) : Do not change to edit mode until we know why the
      	  button was pressed.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_object) :
      	  s/sheet_set_mode_type/sheet_mode_edit/
      	(gnumeric_sheet_key_press) : Adjust to new mode scheme.
      	(gnumeric_sheet_key_release) : Ditto.
      	(gnumeric_sheet_filenames_dropped) : Ditto.
      
      	* src/gnumeric.h : Add fwd decl of SheetObject.
      
      	* src/gnumeric-sheet.h : delete GnumericSheet::mode .
      
      	* src/gnumeric-type-util.h : Rename GNUMERIC_MAKE_TYPE_WITH_PARENT
      	  to GNUMERIC_MAKE_TYPE_WITH_CLASS.  That makes more sense.
      
      	* src/eval.c (invalidate_refs) : Use dependent_set_expr.
      	(cell_eval) : New need to check generation If we are called we are out
      	  of date.
      
      	* src/dependent.c (dependent_eval) : moved from eval.c.
      	(dependent_type_register) : New routine.
      	(dependent_set_expr) ; Ditto.
      	(dependent_debug_name) : Use the new registry.
      
      	* src/dependent.h : Reorder flags, remove explicit types for graphs
      	  and checkboxes.  Those are handled by the virtual table.
      
      	* src/commands.c : s/PARENT/CLASS/
      
      	* src/cell.h : Reorder the CellFlags.
      
      	* src/bonobo-io.c (gnumeric_bonobo_obj_read) : Do not pass the
      	  position to sheet_object_containter_new_object.
      
      	* src/Makefile.am : Add workbook-object-toolbar.[ch]
      	  and graph-series.[ch]
      	  merge the libraries from the two idl files.
      
      2000-09-09  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet-view.c (sheet_view_construct) : Init control points to NULL.
      	(SheetView::temp_item) : remove this.
      
      	* src/sheet.c (sheet_new) : Init the members associated with objects.
      	(sheet_destroy) : Destroy objects.
      	(Sheet::mode) : remove.
      
      	* src/gnumeric.xml : Add a label for the selection menu.
      
      	* src/sheet-object-container.c (sheet_object_container_realize) :
      	  Fix warning.
      
      2000-09-07  Jody Goldberg <jgoldberg@home.com>
      
      	* src/item-bar.c (colrow_tip_setlabel) : mark the size tooltips as
      	  containing pts.
      	* src/dialogs/row-height.glade :
      	* src/dialogs/col-width.glade : Ditto.
      ccdc4a78
  14. 10 Sep, 2000 1 commit
    • Almer S. Tigelaar's avatar
      Limit the number of lines displayed in the preview. This is a temporary · d473b0ae
      Almer S. Tigelaar authored
      2000-09-10  Almer S. Tigelaar  <almer1@dds.nl>
      
      	* src/dialogs/dialog-stf.h: Limit the number of lines
      	displayed in the preview. This is a temporary solution for
      	bug #23426.
      
      	* src/dialogs/dialog-stf-csv-page.c:
      	(stf_dialog_csv_page_prepare): Ditto.
      
      	* src/dialogs/dialog-stf-fixed-page.c:
      	(stf_dialog_fixed_page_prepare): Ditto.
      
      	* src/dialogs/dialog-stf-format-page.c:
      	(stf_dialog_format_page_prepare): Ditto.
      	(format_page_format_changed): Kill memory
      	leak.
      
      	* src/stf-parse.c:
      	(stf_parse_csv_line): Change to still return
      	something if the maximum number of columns is
      	exceeded.
      	(stf_parse_fixed_line): Ditto.
      
      	* src/dialogs/dialog-stf-preview.c:
      	(stf_preview_render): Adjust to only render SHEET_MAX_COLS
      	columns.
      	(stf_preview_get_table_pixel_width): Ditto.
      d473b0ae