GitLab

* dif.c
(dif_input_context_new): Allocate "empty" line by default.
(dif_get_line): Fixed typo.

* workbook-view (wb_view_open_custom): Handle opener errors without
crashing.

2001-05-29  Jody Goldberg <jgoldberg@home.com>

	* fn-stat.c (gnumeric_mode) : Handle errors.
	(gnumeric_count) : ditto.
	(gnumeric_counta) : ditto.
	(gnumeric_prob) : return the correct error, and simplfy.
	(gnumeric_frequency) : ditto.
	(make_list) : renamed from init_make_list_closure, and moved
	  replicated code here.
	(stat_helper) : helper routine.
	(gnumeric_ftest) : use here.
	(gnumeric_ttest) : and here.

2001-05-30  Jody Goldberg <jgoldberg@home.com>

	* src/value.c (value_new_error_err) : change name from
	  value_new_error_err since we don't actually new anything.

	* src/position.c (eval_pos_init_cellref) : delete broken crap.

	* src/func.c (cb_iterate_cellrange) : duplicate error here.
	(function_iterate_argument_values) : duplicate the non-terminate
	  error here.
	* src/collect.c (collect_floats) : not here.

2001-05-30  Jon K Hellan  <hellan@acm.org>

	* gnumeric-expr-entry.c (gnumeric_expr_entry_set_scg): Use
	sc_sheet function to access sheet.

2001-05-30  Jon K Hellan  <hellan@acm.org>

	Previous attempt to commit failed. Trying again.

	* src/sheet-control-gui-priv.h: New file. Implementation details
	for SheetControlGUI and methods directly accessible from the GUI
	layer.

	* src/Makefile.am: Add sheet-control-gui-priv.h

	* src/sheet-control-gui.h: Move struct _SheetControlGUI to
	sheet-control-gui-priv.h. Remove declarations of methods which
	have been made virtual.

	* src/sheet-control-gui.c: Include sheet-control-gui-priv.h instead
	of sheet-control-gui.h.
	Casts and temp variables because:
	- virtual scg methods now take a SheetControl parameter.
        - sheet member now lives in SheetControl.
	Make following methods static - externally available only as
	virtual SheetControl method: scg_redraw_all,
	scg_redraw_cell_region, scg_redraw_headers, scg_update_cursor_pos,
	scg_resize, scg_unant, scg_ant, scg_cursor_bound,
	scg_compute_visible_region, scg_make_cell_visible. Initialize
	class object with these as virtual methods together with
	scg_set_zoom_factor, scg_adjust_preferences, scg_scrollbar_config
	and scg_mode_edit.  Rename context_menu_hander (sic!) to
	context_menu_handler.

	*src/sheet-control.c (SC_VIRTUAL_FULL): Fix typo.
	(sc_destroy): Comment out unused variable.
	(sheet_control_init_state): Rename to sc_init_state.
	(sc_sheet): New accessor - returns sheet attribute.
	(sc_invalidate_sheet): New function - sets sheet attribute to
	NULL.
	(resize, set_zoom_factor, redraw_all, redraw_cell_region,
	redraw_headers, ant, unant, adjust_preferences, update_cursor_pos,
	scrollbar_config, mode_edit, compute_visible_region,
	make_cell_visible, cursor_bound): New virtual methods.

	* src/sheet-control.h: Declare new methods in sheet-control.c

	* src/selection.c: Use sc_redraw_cell_region, sc_redraw_headers
	instead of scg methods.

	* src/sheet.c (sheet_unant): Use sc_unant instead o scg_unant.
	(sheet_ant): Use sc_ant instead of scg_ant.
	(sheet_redraw_all): Use sc_redraw_all instead of scg_redraw_all.
	(sheet_redraw_all): Use sc_redraw_headers instead of
	scg_redraw_headers.
	(sheet_new_scg): Use sc_cursor_bound instead of scg_cursor_bound.
	(sheet_detach_scg): Rename to sheet_detach_control. Change
	parameter from SheetControlGUI to SheetControl. Use sc_sheet and
	sc_invalidate_sheet instead of direct attribute access.
	(sheet_set_zoom_factor): Use sc_set_zoom_factor instead of
	scg_set_zoom_factor.
	(sheet_update_only_grid): Use sc_compute_visible_region instead of
	scg_compute_visible_region.
	(sheet_col_row_gutter): Use sc_resize instead of scg_resize.
	(sheet_redraw_cell_region, sheet_redraw_partial_row,
	sheet_redraw_cell): Use sc_redraw_cell_region instead of
	scg_redraw_cell_region.
	(sheet_make_cell_visible): Use sc_make_cell_visible instead of
	scg_make_cell_visible.
	(sheet_cursor_set): Use sc_cursor_bound instead of
	scg_cursor_bound.
	(sheet_update_cursor_pos): Use sc_update_cursor_pos instead of
	scg_update_cursor_pos.
	(sheet_scrollbar_config): Use sc_scrollbar_config instead of
	scg_scrollbar_config.
	(sheet_adjust_preferences): Use sc_adjust_preferences, sc_resize
	and sc_redraw_all instead of scg_adjust_preferences, scg_resize
	and scg_redraw_all.

	* src/sheet.h (SHEET_FOREACH_CONTROL): Take list of SheetControls
	instead of SheetControlGUIs.

	* src/workbook.c (workbook_sheet_detach): Use sc_mode_edit instead
	of scg_mode_edit.

	* src/embeddable-grid.h: Include sheet-control-gui-priv.h instead
	of sheet-control-gui.h.

	* src/sheet-object-graphic.c: Ditto.

	* src/gnumeric-sheet.c: Include sheet-control-gui-priv.h instead
	of sheet-control-gui.h.
	Casts and temp variables because:
	- virtual scg methods now take a SheetControl parameter.
        - sheet now lives in SheetControl.

	* src/item-bar.c: Ditto.

	* src/item-cursor.c: Ditto.

	* src/item-edit.c: Ditto.

	* src/item-grid.c: Ditto.

	* src/sheet-object-cell-comment.c: Ditto.

	* src/sheet-object-cell-container.c: Ditto.

	* src/sheet-object-item.c: Ditto.

	* src/sheet-object-widget.c: Ditto.

	* src/workbook-control-gui.c: Ditto.

	* src/workbook-object-toolbar.c: Ditto, but don't include
	sheet-control-gui-priv.h

	* src/sheet-object.c (sheet_object_realize): Cast control to
	SheetControlGUI.

2001-05-30  Jon K Hellan  <hellan@acm.org>

	* src/sheet-control-gui-priv.h: New file. Implementation details
	for SheetControlGUI and methods directly accessible from the GUI
	layer.

	* src/Makefile.am: Add sheet-control-gui-priv.h

	* src/sheet-control-gui.h: Move struct _SheetControlGUI to
	sheet-control-gui-priv.h. Remove declarations of methods which
	have been made virtual.

	* src/sheet-control-gui.c: Include sheet-control-gui-priv.h instead
	of sheet-control-gui.h.
	Casts and temp variables because:
	- virtual scg methods now take a SheetControl parameter.
        - sheet member now lives in SheetControl.
	Make following methods static - externally available only as
	virtual SheetControl method: scg_redraw_all,
	scg_redraw_cell_region, scg_redraw_headers, scg_update_cursor_pos,
	scg_resize, scg_unant, scg_ant, scg_cursor_bound,
	scg_compute_visible_region, scg_make_cell_visible. Initialize
	class object with these as virtual methods together with
	scg_set_zoom_factor, scg_adjust_preferences, scg_scrollbar_config
	and scg_mode_edit.  Rename context_menu_hander (sic!) to
	context_menu_handler.

	*src/sheet-control.c (SC_VIRTUAL_FULL): Fix typo.
	(sc_destroy): Comment out unused variable.
	(sheet_control_init_state): Rename to sc_init_state.
	(sc_sheet): New accessor - returns sheet attribute.
	(sc_invalidate_sheet): New function - sets sheet attribute to
	NULL.
	(resize, set_zoom_factor, redraw_all, redraw_cell_region,
	redraw_headers, ant, unant, adjust_preferences, update_cursor_pos,
	scrollbar_config, mode_edit, compute_visible_region,
	make_cell_visible, cursor_bound): New virtual methods.

	* src/sheet-control.h: Declare new methods in sheet-control.c

	* src/selection.c: Use sc_redraw_cell_region, sc_redraw_headers
	instead of scg methods.

	* src/sheet.c (sheet_unant): Use sc_unant instead o scg_unant.
	(sheet_ant): Use sc_ant instead of scg_ant.
	(sheet_redraw_all): Use sc_redraw_all instead of scg_redraw_all.
	(sheet_redraw_all): Use sc_redraw_headers instead of
	scg_redraw_headers.
	(sheet_new_scg): Use sc_cursor_bound instead of scg_cursor_bound.
	(sheet_detach_scg): Rename to sheet_detach_control. Change
	parameter from SheetControlGUI to SheetControl. Use sc_sheet and
	sc_invalidate_sheet instead of direct attribute access.
	(sheet_set_zoom_factor): Use sc_set_zoom_factor instead of
	scg_set_zoom_factor.
	(sheet_update_only_grid): Use sc_compute_visible_region instead of
	scg_compute_visible_region.
	(sheet_col_row_gutter): Use sc_resize instead of scg_resize.
	(sheet_redraw_cell_region, sheet_redraw_partial_row,
	sheet_redraw_cell): Use sc_redraw_cell_region instead of
	scg_redraw_cell_region.
	(sheet_make_cell_visible): Use sc_make_cell_visible instead of
	scg_make_cell_visible.
	(sheet_cursor_set): Use sc_cursor_bound instead of
	scg_cursor_bound.
	(sheet_update_cursor_pos): Use sc_update_cursor_pos instead of
	scg_update_cursor_pos.
	(sheet_scrollbar_config): Use sc_scrollbar_config instead of
	scg_scrollbar_config.
	(sheet_adjust_preferences): Use sc_adjust_preferences, sc_resize
	and sc_redraw_all instead of scg_adjust_preferences, scg_resize
	and scg_redraw_all.

	* src/sheet.h (SHEET_FOREACH_CONTROL): Take list of SheetControls
	instead of SheetControlGUIs.

	* src/workbook.c (workbook_sheet_detach): Use sc_mode_edit instead
	of scg_mode_edit.

	* src/embeddable-grid.h: Include sheet-control-gui-priv.h instead
	of sheet-control-gui.h.

	* src/sheet-object-graphic.c: Ditto.

	* src/gnumeric-sheet.c: Include sheet-control-gui-priv.h instead
	of sheet-control-gui.h.
	Casts and temp variables because:
	- virtual scg methods now take a SheetControl parameter.
        - sheet now lives in SheetControl.

	* src/item-bar.c: Ditto.

	* src/item-cursor.c: Ditto.

	* src/item-edit.c: Ditto.

	* src/item-grid.c: Ditto.

	* src/sheet-object-cell-comment.c: Ditto.

	* src/sheet-object-cell-container.c: Ditto.

	* src/sheet-object-item.c: Ditto.

	* src/sheet-object-widget.c: Ditto.

	* src/workbook-control-gui.c: Ditto.

	* src/workbook-object-toolbar.c: Ditto, but don't include
	sheet-control-gui-priv.h

	* src/sheet-object.c (sheet_object_realize): Cast control to
	SheetControlGUI.

* src/stf.c (stf_init): Register as importer.

* src/file.h
(typedef enum FileProbeLevel) New.
(typedef GnumFileOpenerProbeFunc, gnum_file_opener_probe): Added
FileProbeLevel argument.
(GNUM_FILE_OPENER_CLASS, IS_GNUM_FILE_OPENER_CLASS,
GNUM_FILE_SAVER_CLASS, IS_GNUM_FILE_SAVER_CLASS):
Macros moved to file-priv.h.

* src/file-priv.h
(struct _GnumFileOpenerClass::probe):
(GNUM_FILE_OPENER_CLASS, IS_GNUM_FILE_OPENER_CLASS,
GNUM_FILE_SAVER_CLASS, IS_GNUM_FILE_SAVER_CLASS):
Macros moved from file.h.

* src/file.c
(gnum_file_opener_probe_real, gnum_file_opener_probe):
Added FileProbeLevel argument.

* src/workbook-view.c
(wb_view_open_custom): Iterate over FileProbeLevel values when probing
the file (passing current value to probe function).

* src/xml-io.c
(xml_probe): Added FileProbeLevel argument, testing only file name if
probe level == FILE_PROBE_FILE_NAME.

* src/plugin-service.c (gnum_plugin_file_opener_probe):
Use file_patterns only if probe level == FILE_PROBE_FILE_NAME, otherwise
call module's probe function.

* src/bonobo-io.c (gnumeric_bonobo_io_probe),
src/plugin-service.h (struct _PluginServiceFileOpener),
src/plugin-loader-module.c
(gnumeric_plugin_loader_module_func_file_probe,
struct ServiceLoaderDataFileOpener::module_func_file_probe):
Added FileProbeLevel argument.

* xml-sax-read.c (xml_sax_file_probe): Added FileProbeLevel argument.

* sylk.c (sylk_file_probe): Added FileProbeLevel argument.

* python-loader.c (gnumeric_plugin_loader_python_func_file_probe): Added
FileProbeLevel argument.

* boot.c (lotus_file_probe): Added FileProbeLevel argument.

* boot.c (excel_file_probe): Added FileProbeLevel argument.

* boot.c (applix_file_probe): Added FileProbeLevel argument.

2001-05-29  Almer S. Tigelaar <almer@gnome.org>

	* BUGS: Add request for single-cell ExprEntry selection.

* dif.c
New line parsing routine - doesn't allocate/deallocate memory at every
input line, stops processing at the end of mmaped file (instead of
crashing).
Write empty cells too (previous behaviour was incorrect).
Write the current sheet instead of the first one (for XL compatibility).
Detailed error reporting, fixed leaks, general cleanup.

* dif.h: Removed.

* Makefile.am (dif_la_SOURCES): Removed dif.h

* plugin.xml (<service>): Set "open" to TRUE, added <file_patterns>.

2001-05-27  Jody Goldberg <jgoldberg@home.com>
	From Juan Pablo Mendoza <pablo_juan@yahoo.com>

	* sheet.c (sheet_name_quote): Escape \ and add more chars to
	  to quote_chr.

2001-05-27  Jody Goldberg <jgoldberg@home.com>
	From Juan Pablo Mendoza <pablo_juan@yahoo.com>

	* gnumeric-util.h (gnumeric_filter_modifiers): New macro.

	* workbook-control-gui.c (wb_edit_key_pressed): Use it.
	* gnumeric-sheet.c (gnumeric_filter_modifiers): Ditto.

2001-05-27  Jody Goldberg <jgoldberg@home.com>

	* ms-excel-write.c (write_window2) :
	  Switch the BIFF_WINDOW2 0x23e -> 0x3e
	(write_names) : fix biff type.

	* ms-excel-read.c (ms_excel_read_formula) : cleanup some old
	  inconsistentcies.  keep as many of the BIFF_* using their major
	  types.
	  Switch the BIFF_STRING 0x207 -> 0x07
	  Switch the BIFF_BOOLERR 0x205 -> 0x05
	(ms_excel_read_window2) : split this out into a neater bundle.

2001-05-27  Jody Goldberg <jgoldberg@home.com>

	* src/eval.c (sheet_region_queue_recalc) : Queue the dependents in the
	  region not just those that depend on it.
	(cell_queue_recalc) : no need to queue non expression cells.

2001-05-27  Jody Goldberg <jgoldberg@home.com>

	* src/expr.c (eval_expr_real) : recurse for arrays too.
	(expr_tree_array_corner) : rename from expr_tree_array_formula_corner,
	  and return the corner, not the expression in the corner.

	* src/eval.c (cb_range_hash_invalidate) : invalidate and free things
	  in place.
	(cb_single_hash_invalidate) : ditto.
	(do_deps_destroy) : simplify.

	* src/workbook-control-gui.c (wbcg_sheet_rename) : Use the table not
	  the container.

2001-05-27  Nathan Cullen <furyu@fuse.net>

 	* src/history.c (history_menu_insert_separator): Fixed keyboard
 	navigation problem in non-bonobo build with separator for recently
 	opened files.  There was an "invisible" separator item so you needed
 	to arrow down twice to get from "Print Preview" to the first file.

2001-05-27  Jody Goldberg <jgoldberg@home.com>

	* src/workbook-control-gui.c (wbcg_sheet_rename) : Use the table not
	  the container.

2001-05-27  Almer S. Tigelaar  <almer@gnome.org>

	* validate.glade: Make non-modal.

	* dialog-validate.c (setup_widgets): Use ExprEntry's instead
	of normal entries.
	(dialog_validate): Cope for non-modality of dialog.
	(cb_dialog_destroy): New, clean up when user closes
	the dialog.
	(cb_dialog_set_focus): New, Handle ExprEntry's.
	(cb_dialog_clicked): Handle the dialog buttons.
	(connect_signals): Connect the new signals.

2001-05-27  Almer S. Tigelaar  <almer@gnome.org>

	* dialog-cell-format.c (setup_color_pickers) : Correctly
	initialize color combo depending on the style element.

* src/plugin-service.c (parse_format_level_str): Fixed typo.

2001-05-27  Karl Eichwalder  <ke@suse.de>

	* de.po: Update.

2001-05-26  Jody Goldberg <jgoldberg@home.com>

	* xml-sax-read.c (xml_sax_file_open) : If successful queue everything
	  for recalc.
	(xml_cell_set_array_expr) : no need to queue a recalc for arrays.

2001-05-26  Jody Goldberg <jgoldberg@home.com>

	* src/sheet.c (colrow_move) : no need to queue recalc here.
	(cb_sheet_cell_copy) : Actually copy the array values.

	* src/cell.c (cell_relocate) : Just relink, no need to queue a recalc.
	(cell_set_array_formula) : Remove the ability to queue the recalc at
	  this level.  Just link the formulas in.  Reorder the the arguments
	  to match the standard approach.

	* src/eval.c (workbook_recalc_all) : Used here.
	(workbook_queue_all_recalc) : new function.

	* src/xml-io.c (xml_workbook_read) : Queue everything for recalc.
	(xml_cell_set_array_expr) : no need to queue a recalc here.

	* src/commands.c (cmd_autofill_redo) : queue the recalc here.
	(cmd_area_set_text_redo) : we need to manually queue a recalc for
	  arrays now.

	* src/sheet.c (sheet_cell_set_text) : we need to queue a recalc for
	  both expressions and values now.
	(sheet_range_set_text) : queue recalcs for the region as a block.

	* src/graph-vector.c (graph_vector_new) : Just use dependent_link if
	  we don't want a recalc.

2001-05-27  Karl Eichwalder  <ke@suse.de>

	* Run xml-i18n-prepare:
	* gnumeric.desktop.in: Remove file.
	* gnumeric.desktop.in.in: New file.
	* Makefile.am: Adjust it for gnumeric.desktop.in.in.

2001-05-27  Karl Eichwalder  <ke@suse.de>

	* da.po, es.po, et.po, fr.po, gl.po, hu.po, ja.po, ko.po, no.po,
	pl.po, pt.po, ru.po, sk.po, sv.po:

2001-05-26  Jody Goldberg <jgoldberg@home.com>

	* src/sheet-control-gui.h : typo.

2001-05-26  Jon K Hellan  <hellan@acm.org>

	* src/sheet-control-gui.[ch]: Derive from SheetControl rather than
	GtkObject.

	* src/gnumeric.h: Add incomplete def of SheetControl.

	* src/Makefile.am: Add sheet-control.c, sheet-control.h,
	sheet-control-priv.h

	* src/sheet-control.c: New file. Stub base class for
	SheetControlGUI.

	* src/sheet-control.h: Strip down even more from existing stub in
	CVS.

	* src/sheet-control-priv.h: New file. Private header for
	SheetControl.

2001-05-26  Jody Goldberg <jgoldberg@home.com>

	* src/format.c (format_number) : suppress minus for "\(" to match "("

2001-05-26  Karl Eichwalder  <ke@suse.de>

	* de.po: Update.

2001-05-26  Karl Eichwalder  <ke@suse.de>

	* de.po: Update (again).