1. 15 May, 2000 1 commit
    • Jody Goldberg's avatar
      Fix typo breaking row/col ins/del breakage :-( · a5e04f49
      Jody Goldberg authored
      Make some minor improvements in status display for row/col selection.
      2000-05-14  Jody Goldberg <jgoldberg@home.com>
      	* src/commands.h : Reformat.
      	* src/commands.c (cmd_ins_del_row_col_{undo,redo}) : unant the
      	  selection when the topology changes.
      	* src/workbook.c (workbook_expr_relocate) : Fix typo.
      	* src/sheet-view.c (sheet_view_{col,row}_selection_changed) : Call
      	  sheet_update after a change.
  2. 09 May, 2000 1 commit
  3. 04 May, 2000 1 commit
  4. 03 May, 2000 2 commits
    • Morten Welinder's avatar
      Mention Marko's work. · dcd9ca14
      Morten Welinder authored
    • Michael Meeks's avatar
      Accelerate intersheet dependancies for Hans, · 3de60968
      Michael Meeks authored
      2000-05-03  Michael Meeks  <michael@helixcode.com>
      	* doc/Dependencies.txt: update to reflect changes.
      	* src/eval.c: comment and const mending.
      	(handle_cell_range_deps): prune no inter-sheet singletons code,
      	it is a sluggish anachronism. (handle_cell_single_dep): setup
      	the correct sheet to enter data into.
      	* src/eval.h: expunge redundant commenting, re-order,
      	const kill.
  5. 02 May, 2000 1 commit
    • Jody Goldberg's avatar
      New function. · b2198f30
      Jody Goldberg authored
      2000-05-01  Jody Goldberg <jgoldberg@home.com>
      	* src/expr.c (expr_tree_shared) : New function.
      	* src/xml-io.c (gnumeric_xml_write_selection_clipboard) : Init and
      	  destroy the expression hash.
      	(gnumeric_xml_read_selection_clipboard) : Ditto.
      	(gnumeric_xml_read_workbook) : Ditto.
      	(gnumeric_xml_write_workbook) : Ditto.
      	(xml_write_cell_and_position) : When saving cells that have expression
      	  assign and store an ID for shared expressions.
      	(xml_read_cell) : Use the ID to restore shared expressions.
  6. 01 May, 2000 1 commit
  7. 28 Apr, 2000 1 commit
  8. 27 Apr, 2000 2 commits
    • Karl Eichwalder's avatar
      Add da, es, no, and uk. · 1ac7d47e
      Karl Eichwalder authored
      * NEWS (Translations): Add da, es, no, and uk.
    • Jody Goldberg's avatar
      Improve versioning. Fix a few bugs. · 2c8b64d0
      Jody Goldberg authored
      Improve versioning.
      Fix a few bugs.
      2000-04-26  Jody Goldberg <jgoldberg@home.com>
      	* src/command-context.c (gnumeric_error_sys_err) : New function.
      	* src/command-context-gui.c (ccg_error_sys_err) : Support it.
      	* src/gnumeric-util.c (gnumeric_glade_xml_new) : Use gnumeric_error_sys_err.
      	* src/gutils.c (gnumeric_sys_{data,lib,glade,plugin)_dir) : New functions.
      	(gnumeric_usr_dir, gnumeric_usr_plugin_dir) : New functions.
      	* src/plugin.c (load_all_plugins) : Use
      	  gnumeric_usr_plugin_dir, and  gnumeric_sys_plugin_dir.
      	* src/item-edit.c (point_is_inside_range) : Handle non-singleton
      	  expr start characters.
      2000-04-25  Jody Goldberg <jgoldberg@home.com>
      	* *.c : glade_new_xml -> gnumeric_glade_new_xml
      	  Localize GNUMERIC_GLADEDIR so that plugins can use it too.
      	* src/gnumeric-util.c (gnumeric_glade_xml_new) : New function.
      	* */Makefile.am : Set 'DATADIR' rather than GLADEDIR.  And version
      	  the glade file the same way the plugins are set.  This should
      	  probably expand to include architecture akin to gcc.
      	* src/widgets/widget-editable-label.c (el_button_press_event) :
      	  Clicking in another window accepts the changes.  Once we have
      	  reliquished our grab push the button event back on the queue
      	  so that it can be forwarded on to the appropriate recipient (9007).
      	* src/parse-util.c (parse_text_value_or_expr) : Watch for 1 character
      	  strings which could start an expression.
  9. 20 Apr, 2000 1 commit
    • Jody Goldberg's avatar
      Reorg cell contents and assignment. · bedb925b
      Jody Goldberg authored
      Fixs lots of usability details.
      2000-04-20  Jody Goldberg <jgoldberg@home.com>
      	* src/dialogs/dialog-cell-format.c : Use the edit_pos as the example
      	  not the top left corner.
      	* src/functions/fn-stat.c (gnumeric_ftest) : Use eval_pos_cellref
      	  to help localize the strangeness.
      	(gnumeric_ttest) : Ditto.
      	* src/xml-io.c (xml_write_cell_and_position) : If this is an array
      	  expression and we are the top left then add attributes to indicate
      	  size of array.  Ignore the rest of the array.
      	(xml_not_used_old_array_spec) : New routinr to handle the old array format.
      	(xml_cell_set_array_expr) : store an array.
      	(xml_read_cell) : Handle the old and the new array formats.
      	* src/workbook.c (workbook_close_if_user_permits) : Accept input
      	(wb_edit_key_pressed) : Handle array formulas here.
      	(workbook_detach_sheet) : Do not recalc all if we are exiting.
      	(workbook_start_editing_at_cursor) : When we start editing an
      	  array formula display just the formula not all the extra {}()[][] crap.
      	* src/sheet.c (SheetPrivate) : Add a recompute_spans flag.
      	(sheet_calc_spans) : New routine.
      	(sheet_cell_calc_span) : New routine.
      	(sheet_range_calc_spans) : Renamed and extended from
      	(sheet_update) : Use sheet_calc_spans when necessary.
      	  Update the location region when the edit_pos changes.
      	(cb_recalc_spans_in_col) : Renamed from cb_collect_cells_in_col.
      	  Recalcs spans directly, no need to collect first.
      	(cb_set_cell_content) : New routine to set expr, or expr_and_value.
      	(sheet_range_set_text) : Use cb_set_cell_content, and remember
      	  chosen format with the cell rather than overriding the assigned
      	(sheet_cell_set_text) : Renamed from sheet_set_text.  Be more specific
      	  about how spans, rendering and the rest are handled.
      	(sheet_cell_set_expr) : New routine.
      	(sheet_cell_set_value) : Ditto.
      	(sheet_load_cell_val) : When displaying an array formula add {%s}()[][].
      	(sheet_redraw_cell_region) : Honour spans when redrawing.
      	(sheet_redraw_partial_row) : New routine.
      	(sheet_redraw_cell) : Ditto.
      	(sheet_is_cell_array) : Use cell_is_array.
      	(sheet_range_splits_array) : Renamed from sheet_check_for_partial_array.
      	(sheet_cell_add_to_hash) :  Do not touch spans at this point.
      	(sheet_cell_insert) : Rename from sheet_cell_add made recalc span
      	(sheet_cell_new) : New routine that does not touch spans.
      	(sheet_cell_remove) : Made redraw optional.
      	(cb_clear_cell_comments) : Remove the cell if there is no comment.
      	(sheet_clear_region) : Remove the cell if there are no comments or
      	  contents.  Flag an update of the status region.
      	* src/sheet-view.c (cb_colrow_resize) : New function.
      	(sheet_view_col_size_changed) : Resize all rows, irrespective of
      	(sheet_view_row_size_changed) : existing cells.
      	(sheet_view_redraw_cell_region) : This no longer honours spans.
      	* src/sheet-style.c (sheet_style_attach) : Removed call to redraw.
      	sheet_cells_update : rename to sheet_range_calc_spans and move to
      	* src/sheet-autofill.c (autofill_cell) : Use sheet_cell_set_value
      	  rather than set_text.
      	* src/selection.c (sheet_selection_changed_hook) : Delete.
      	(sheet_selection_extend_to) : Update the status region to display the
      	  new size.
      	(sheet_selection_cut) : Use sheet_range_splits_array.
      	(selection_check_for_array) : New routine.
      	* src/parser.y : Remove icky array formula parsing that conflicted
      	  with array entries.
      	* src/number-match.c (format_match) : Return a Value * rather than a
      	* src/mstyle.c (mstyle_set_font_size) : Do not allow font sizes < 1.
      	* src/main.c (gnumeric_main) : Do NOT create an empty workbook
      	  then delete it if things are successfully loaded.  This causes
      	  a global recalc.  Instead add a flag to disable exit when the
      	  number of workbooks go to zero.  Then only enable the flag AFTER
      	  we have attempted to load the initial workbooks.
      	* src/item-grid.c (item_grid_event) : Update the status_region when
      	  button-1 is release.  It should display the edit_pos.
      	* src/gutils.c : Move cell_name, col_name, col_from_name,
      	  parse_cell_name, parse_cell_name_or_range and parse_cell_name_list,
      	  to parse-util.c.
      	* src/gnumeric.h  : Add RenderedValue.
      	* src/gnumeric-util.c (gnumeric_char_start_expr_p) : Move
      	  to parse-util.c
      	* src/file.c (workbook_read) : Remove freese thaw usage.
      	  Move call to update AFTER mark clean.
      	* src/expr.c (eval_pos_init) : Take a cellpos.
      	(parse_pos_evalpos) : New routine.
      	(eval_pos_cellref) : There is some questionable code scattered in the
      	  functions.  This routing localizes the odd bits for correction.
      	* src/eval.c (cell_eval_content) : Use sheet_redraw_cell,
      	  and rendered_value_calc_size.
      	(cell_get_dependencies) : Improve constness.
      	* src/corba-sheet.c : Remove the freeze thaw operations.
      	(Sheet_cell_set_formula) : Deleted.
      	(Sheet_range_set_formula) : Delete.
      	* src/commands.c : Adjust so that registration of command auto
      	  calls redo.  Add misc checks for splitting arrays.
      	* src/clipboard.h : Move the CellCopy types here from cell.h
      	* src/clipboard.c (paste_cell) : Use cell_has_expr.
      	  Don't insert the new cell till after its contents are assigned.
      	* src/cellspan.c (cell_register_span) : Improve constness.
      	(cell_unregister_span) : Ditto.
      	(row_cell_get_displayed_at) : Delete.
      	(cell_calc_span) : Moved here from cell.c
      	* src/dialogs/dialog-stf.glade : Adjust the header background colour
      	  to match the purdy new icon.  Add the icon.
      	* src/cell-draw.c : Use the rendered_value routines.
      	  Improve constness.
      	* src/analysis-tools.c (set_cell) : Use sheet_cell_fetch.
      	    cell_set_* -> sheet_cell_set_
      	    cell_set_*_simple -> cell_set_
      	    Cell::{row,col} -> Cell::{row,col}_info
      	    cell_get_text -> cell_get_entered_text
      	    cell_get_content -> cell_get_entered_text
      	    cell_name -> cell_coord_name
      	    cell_get_formatted_val -> cell_get_rendered_text
      	    cell_get_content -> cell_get_entered_text
      	* src/cell.c :
      	(cell_dirty) : Renamed from cell_modified.  Use
      	(cell_formula_changed) : Make the queuing of the recalc optional.
      	(cell_cleanout) : Handle union of expression and entered_text,
      	  and remove the rendered value.
      	(cell_copy) : Ditto.
      	(cell_destroy) : handle cell_modified -> cell_dirty.
      	(cell_set_text) : Use parse_text_value_or_expr and store the prefered
      	(cell_set_text_and_value) : New routine.
      	(cell_assign_value) : New routine.
      	(cell_set_value) : Support formats.
      	(cell_set_expr_and_value) : New routine.
      	(cell_set_expr_internal) : Split from cell_set_expr.
      	(cell_set_expr) : Divide to allow for not queuing a recalc.
      	(cell_set_array_formula) : Use cell_set_expr_internal.
      	(cell_is_array) : New utility.
      	(cell_is_partial_array) : New utility.
      	(cell_has_expr) : New utility.
      	(cell_render_value) : Use rendered_value_*.
      	Move all comment routines into cell-comment.[ch].
      	* idl/Gnumeric.idl : Remove cell_set_formula, and range_set_formula.
      	  These were identical to set_text.  Made Workbook embeddable.
  10. 17 Apr, 2000 1 commit
  11. 16 Apr, 2000 1 commit
    • Morten Welinder's avatar
      Quiet a bit. · 41ea0dd6
      Morten Welinder authored
      2000-04-16  Morten Welinder  <terra@diku.dk>
      	* src/eval.c (cell_add_explicit_dependency): Quiet a bit.
      	* src/functions/fn-lookup.c (gnumeric_match): Fix.
  12. 15 Apr, 2000 1 commit
    • Morten Welinder's avatar
      Fix for empty case. · 87bd4167
      Morten Welinder authored
      2000-04-15  Morten Welinder  <terra@diku.dk>
      	* src/functions/fn-stat.c (gnumeric_quartile): Fix for empty case.
  13. 11 Apr, 2000 1 commit
  14. 09 Apr, 2000 1 commit
  15. 07 Apr, 2000 2 commits
    • Morten Welinder's avatar
      Morten Welinder authored
      2000-04-07  Morten Welinder  <terra@diku.dk>
      	* src/collect.h (CollectFlags): Get rid of COLLECT_IGNORE_POSITIVE
      	* src/collect.c (callback_function_collect): Don't have the above
      	* src/functions/fn-financial.c (irr_npv_df): New function.
      	(gnumeric_irr): Use irr_npv_df for better results.
      	(gnumeric_ipmt, gnumeric_ppmt): Fix order of arguments!  (It works
       	so much better that way.)
      	(gnumeric_mirr): Fix formula.
      	* src/goal-seek.c (update_data): Spelling fix.
      	* src/functions/fn-financial.c (gnumeric_rate, gnumeirc_irr,
       	gnumeric_xirr): Use the supplied guess.
    • Jody Goldberg's avatar
      Fix minor thinko in eval_expr. · 0f4097ca
      Jody Goldberg authored
      Improve status update after load.
      2000-04-06  Jody Goldberg <jgoldberg@home.com>
      	* src/xml-io.c (gnumeric_xml_read_workbook) : No need to recalc, the
      	  loader handles it.
      	* src/file.c (workbook_read) : Do a recalc and sheet_update after loading.
      	  Wrap entire process in deep_{freeze,thaw}.
      	* src/expr.c (eval_expr) : Fix thinko.
  16. 04 Apr, 2000 1 commit
    • Jody Goldberg's avatar
      Improve status update. · 56a9e1f0
      Jody Goldberg authored
      Simplify a few command paths in preparation for registration.
      Hopefully fix bug 3961
      2000-04-04  Jody Goldberg <jgoldberg@home.com>
      	* src/workbook.c (workbook_class_init) : Remove CELL_CHANGED.
      	(workbook_finish_editing) : At LAST! cmd_set_text is responsible for
      	  setting the text directly :-)
      	* src/workbook-format-toolbar.c (change_font_size_in_selection_cmd) :
      	  cmd_format takes care of the height adjustments.
      	* src/dialogs/dialog-cell-format.c (cb_fmt_dialog_dialog_apply) : Ditto.
      	* src/sheet.c (Sheet): Add flags edit_pos_changed, selection_content_changed.
      	(sheet_new) : init them.
      	(sheet_flag_status_update_cell) : New function that sets the flags.
      	(sheet_flag_status_update_range) : Ditto.
      	(sheet_update) : Fix typo. Add support for new flags.
      	(sheet_update_auto_expr) : Const correctness.
      	(sheet_update_controls) : Ditto.
      	(sheet_load_cell_val) : Ditto. Delete unused signal.
      	(sheet_set_text) : Use sheet_flag_status_update_range.
      	(sheet_set_edit_pos) : New routine.
      	(sheet_cursor_move) : Delete.
      	(sheet_fill_selection_with) : Remove.
      	* src/selection.c (sheet_selection_changed_hook) : const correctness.
      	(sheet_selection_change) : merge into sheet_selection_set.
      	(sheet_selection_extend_to) : Use sheet_selection_set.
      	(sheet_selection_set) : Merge with sheet_selection_change and use the
      	  sheet_cursor accessors rather than changing things directly.
      	(sheet_selection_walk_step) : Use sheet_selection_set, and sheet_set_edit_pos.
      	(sheet_is_all_selected) : const correctness.
      	(sheet_is_cell_selected) : New routine.
      	(sheet_is_range_selected) : New routine.
      	* src/item-grid.c (item_grid_draw_background) : Adjust to rename of
      	* sheet_selection_is_cell_selected -> sheet_is_cell_selected.
      	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) : Cleanup the
      	  logic for creating fills and arrays so that it can have undo
      	  - Change the heuristic for selecting what type of characters can start
      	    an edit session.  Rather than using fixed Latin1 centric codes,
      	    guess that the 'length' field of the event is >0 if the character is
      	    printable.  Be more careful NOT to forward characters to the entry
      	    if we are not editing.
      	  - Use sheet_update.
      	* src/commands.c (command_pop_list_top) : Delete.
      	(cmd_format_redo) : Apply the height adjustment here.
      	(cmd_set_area_*) : Implement.
      	(*) : Use sheet_update.
      	* src/colrow.c (rows_height_update) : Moved here and generalized from
      	* src/clipboard.c (sheet_paste_selection) : No need to call
      	  sheet_cursor_set.  sheet_selection_add_range already does that.
      	(clipboard_paste_region) : Flag updates to the status display if
      	  something changes.
  17. 02 Apr, 2000 1 commit
  18. 01 Apr, 2000 1 commit
    • Jody Goldberg's avatar
      Fix the silly edit bug tha was being reported. · fce11703
      Jody Goldberg authored
      Some major work on item-edit.
      2000-03-31  Jody Goldberg <jgoldberg@home.com>
      	* src/workbook.c : Switch over to useing GNOMEUIINFO_ITEM_ where
      	(cb_editline_focus_in) : Do not start editing if we are already
      	* src/utils.c (parse_cell_name) : constness.
      	* src/style.c (style_font_gdk_font) : constness.
      	(style_font_gdk_font) : ditto.
      	(style_font_gnome_font) : ditto.
      	(style_font_get_height) : ditto.
      	* src/sheet.c (sheet_set_zoom_factor) : redimension all cells, rather
      	  than the sparse sheet region.  Do not auto-resize.
      	(sheet_cell_add) :  Adjust to new calling convention for
      	(sheet_stop_editing) : Rename from sheet_destroy_edit_cursor.
      	* src/sheet-view.c (sheet_view_get_style_font) : constness.
      	* src/gnumeric-sheet.c (gnumeric_sheet_create_editing_cursor) :
      	  No need to set all those arguments.
      	(destroy_item_editor) : Merge into gnumeric_sheet_stop_editing.
      	(gnumeric_sheet_stop_editing) : Renamed from
      	* src/cell.[ch] (cell_set_rendered_text) : Adjust to new calling
      	  convention for cell_calc_dimensions.
      	(cell_calc_dimensions) : Adjust calling convetion to make auto
      	  resizing optional.
      	(calc_text_dimensions) : Adjust calling convention to directly set size.
      	* src/sheet-style.c (re_dimension_cells_cb) :  Adjust to new calling
      	  convention for cell_calc_dimensions.
      	* src/item-edit.c : Major rework to behave better at margins,
      	  correctly handle cells whose display contents span differently than
      	  their displayed values, multi-line display mechanics, and a blinking
      	  cursor :-)
  19. 31 Mar, 2000 1 commit
    • JP Rosevear's avatar
      Allow per type reading of the "Attribute" xml node so that complex types · a5595f76
      JP Rosevear authored
      2000-03-31  JP Rosevear  <jpr@arcavia.com>
      	* src/xml-io.c (xml_read_attribute): Allow per type reading of
      	the "Attribute" xml node so that complex types can sort themselves
      	(xml_write_attribute): Allow per type writing of the "Attribute"
      	node so that complex types can write themselves appropriately.
      	(xml_write_attributes): Tidy and use xml_write_attribute.
      	(xml_read_attribute): Tiday and use xml_read_attribute.
  20. 29 Mar, 2000 1 commit
    • Jon K Hellan's avatar
      Add titles for torn off combos. · da485b05
      Jon K Hellan authored
      2000-03-29  Jon K Hellan  <hellan@acm.org>
      	* src/workbook-format-toolbar.c (workbook_create_format_toolbar):
      	Add titles for torn off combos.
      	* src/workbook.c (workbook_create_standard_toobar): Ditto
      2000-03-29  Jon K Hellan  <hellan@acm.org>
      	* src/widgets/gtk-combo-box.h (gtk_combo_box_set_title): Declare
      	* src/widgets/gtk-combo-box.c (struct _GtkComboBoxPrivate):
      	New/renamed members: toplevel, tearoff_window: Popup's
      	toplevel when torn_off/not torn off. torn_off: Tearoff status
      	flag. Names are the same as in gtk/gtkmenu.c. tearable: The tearoff
      	"button". popup: The widget which gets torn off. This is actually
      	the event box.
      	(gtk_combo_box_finalize): Destroy tearoff window.
      	(gtk_combo_box_popup_hide): Turned into a wrapper which does
      	nothing if popup is torn off, and calls
      	gtk_combo_box_popup_hide_unconditional if it isn't.
      	(gtk_combo_box_popup_hide_unconditional): Contains the logic which
      	used to be in gtk_combo_box_popup_hide. If torn off, the popup is
      	reattached after hiding.
      	(gtk_combo_box_popup_display): Realize popup as well as toplevel.
      	(gtk_combo_toggle_pressed): Use
      	(gtk_combo_box_key_press): New function. Dismiss popup on escape.
      	(gtk_combo_box_init): Various renamings. Connect key press handler.
      	(gtk_combo_popup_tear_off): New function. Tear off the popup.
      	(cb_tearable_button_release): Toggle tearoff state.
      	(gtk_combo_box_construct): Make tearoff menu item no fill, no
      	(gtk_combo_box_set_title): New function. Set a title to display
      	over the tearoff window.
  21. 26 Mar, 2000 2 commits
    • Almer. S. Tigelaar's avatar
      New, ment for reducing some duplicate code in the plugins and provide · bfaed296
      Almer. S. Tigelaar authored
      2000-03-26  Almer. S. Tigelaar.  <almer1@dds.nl>
      	* src/plugin-util.c, src/plugin-util.h: New, ment for reducing
      	some duplicate code in the plugins and provide better error
      	reporting. modified the ff-csv plugin to use the new functions.
      2000-03-26  Almer. S. Tigelaar.  <almer1@dds.nl>
      	* csv-io.c (csv_write_workbook, csv_read_workbook) : modified to use
      	new plugin-utils (src/plugin-util.[ch])
    • Jody Goldberg's avatar
      Prep for release. · 831eef61
      Jody Goldberg authored
      DOM's plugin manger aesthetic adjustments.
      2000-03-25  Jody Goldberg <jgoldberg@home.com>
      	* src/sheet.c (sheet_{col,row}_set_size_pts) : Set the update flags.
      	* src/workbook.c : Add undo/redo elements.
      2000-03-25  Jody Goldberg <jgoldberg@home.com>
      	For Dom Lachowicz <cinamod@hotmail.com>
      	* src/plugin.[ch] (plugin_data_get_size,
      	  plugin_data_last_modified) : New functions.
      	(plugin_load): updated
      	* src/dialogs/dialog-plugin-manager.c
      	(dialog-plugin-manager-impl, refresh-right-frame): updated.
      	* src/dialogs/plugin-manager.glade,
      	  New layout, enabled word-wrap in description,
      	  Other aesthetic changes
  22. 25 Mar, 2000 4 commits
  23. 24 Mar, 2000 1 commit
  24. 07 Mar, 2000 1 commit
  25. 05 Mar, 2000 2 commits
    • Jukka-Pekka Iivonen's avatar
      Added documentation of the Solver tool. · 01a6c10e
      Jukka-Pekka Iivonen authored
      2000-03-05  Jukka-Pekka Iivonen  <iivonen@iki.fi>
              * doc/C/solver.sgml, doc/C/images/solver-0[1,2,3,4,5].jpg: Added
              documentation of the Solver tool.
    • Jody Goldberg's avatar
      - Strike through - initial format dialog support for underline and · 7f8319da
      Jody Goldberg authored
      - Strike through
      - initial format dialog support for underline and strikethrough.
      - Printing of underlines and strikethroughs.
      2000-03-05  Jody Goldberg <jgoldberg@home.com>
      	* src/dialogs/dialog-cell-format.c : Enable the underline and
      	  strikethrough elements. TODO : redo the preview for the font
      	  tab to support underlining and friends.
      	* src/dialogs/cell-format.glade : Rename the underline combo and
      	  strikethrough button.
      	* src/xml-io.c (xml_write_style) : Add strikethrough.
      	(xml_read_style) : Ditto.
      	* src/workbook-format-toolbar.c (workbook_feedback_set) : Only show
      	  the underline button for single underlines.
      	* src/sheet-view.[ch] : rename select_all -> select_all_btn.
      	  remove unused element.
      	* src/sheet-object.h : Remove silly self inclusion.
      	* src/print-cell.c : Support underlining and strikethrough.
      	  Move even closer into sync with drawing code.
      	* src/mstyle.c : Add strikethrough and cleanup includes.
      	* src/main.h : Add include for popt.h.
      	* src/item-grid.c (item_grid_draw_border) : No more need for BOTTOM or
      	(item_grid_draw_cell) : Delete, and merge with draw_cell.
      	* src/commands.c (cmd_set_text_undo) : Use cursor_set rather than
      	* src/corba-sheet.c (Sheet_cursor_move) : Ditto.
      	(gnumeric_sheet_key_mode_sheet) : Ditto.
      	* src/workbook.c (workbook_parse_and_jump) : Ditto.
      	* src/cell-draw.c : Clean includes, add support for strikethrough.
  26. 04 Mar, 2000 1 commit
    • Morten Welinder's avatar
      THE WORLD'S BEST KEPT C SECRETS, PART 12: · e2df9a9e
      Morten Welinder authored
      The functions isalpha, isdigit, ..., isspace, tolower, and toupper
      are ONLY defined on EOF (typically -1) and unsigned characters.
      Read the manual pages from various OSs -- it's in there.
      It is wrong to call these with signed characters as argument; the
      type "char" can be, and often is, signed.  Please don't write code
           void frob (char *s)
             while (isspace (*s))       /* WRONG! */
             /* ... */
      Instead write something like
           void frob (char *s)
             while (isspace ((unsigned char)*s))   /* Right */
             /* ... */
      Note: the above is true even if you don't like it.  Some people have
      gotten terrible upset and defensive when they have had this problem
      pointed out to them.  That does not help.
      FYI, all this makes a serious difference on Solaris, HP-UX and maybe
      other OSs.
  27. 02 Mar, 2000 1 commit
    • Dom Lachowicz's avatar
      Catch Div0 && invalid log() domain. · a681f037
      Dom Lachowicz authored
      2000-03-01  Dom Lachowicz <dominicl@seas.upenn.edu>
      	* src/functions/fn-eng.c (val_to_base): Catch Div0 && invalid log()
      	* src/functions/fn-financial (gnumeric_accrint, gnumeric_recieved),
      	(gnumeric_pricemat): Same
      	* src/functions/fn-stat.c (gnumeric_ttest): Ditto
  28. 29 Feb, 2000 2 commits
    • Jody Goldberg's avatar
      A present for Quartic, borders can now print. · a1cea178
      Jody Goldberg authored
      2000-02-29  Jody Goldberg <jgoldberg@home.com>
      	* src/cell-print.c : Sync with logic in item-bar::draw to add borders
      	  and more correctly handle spanning.
      	* src/pattern.c (gnumeric_background_set_pc) : New routine cloned from
      	* src/border.c (style_border_set_pc_dash) : New routine cloned from
      	(style_border_set_pc) : New routine cloned from style_border_set_gc.
      	(style_border_print) : New routine cloned from style_border_draw.
      	* src/cell-draw.c (cell_draw) : No need to return number of spans.
    • Morten Welinder's avatar
      Claim some stuff. · 0e1a9a2b
      Morten Welinder authored
  29. 28 Feb, 2000 3 commits
    • Jon Kåre Hellan's avatar
      *** empty log message *** · d2df84bd
      Jon Kåre Hellan authored
    • Jody Goldberg's avatar
      Improve the handling of backgrounds and selection in the presence of · bb5371b7
      Jody Goldberg authored
      Improve the handling of backgrounds and selection
      in the presence of spanning columns.
      Improve borders.  Somewhat more correct handling of double lined borders.
      Still mostly wrong, but its a start.
      2000-02-28  Jody Goldberg <jgoldberg@home.com>
      	* src/expr.h : Move FunctionDefinition to
      	* src/gnumeric.h : here.
      	* src/cellspan.c (col_hash) : Use GPOINTER_TO_INT.
      	(col_compare) : Ditto.
      	(row_init_span) : Delete.
      	(free_hash_value) : Renamed from free_hash_key.
      	(cell_register_span) : Register all cells in a span, malloc a
      	  CellSpanInfo to store a descriptor about the first and last cols.
      	(assemble_unregister_span_list) : Delete.
      	(span_remove) : New function for use by g_hash_table_foreach_remove.
      	(cell_unregister_span) : Use g_hash_table_foreach_remove.
      	(row_cell_get_displayed_at) : Adjust to new descriptor.
      	(row_span_get) : New function.
      	* src/cell.c (cell_calculate_span) : Renamed from cell_get_span.
      	* src/cell-draw.c (cell_draw) : Do not draw backgrounds here.
      	  Use new CellSpanInfo to avoid recomputing spans every time.
      	(cell_is_blank) : Remove hack about treating empty strings as empty.
      	* src/cellspan.h : New file.  Move span decls here.
      	* src/item-grid.c (item_grid_draw) : Rework to correctly handle
      	  backgrounds and borders for spanning columns.
      2000-02-27  Jody Goldberg <jgoldberg@home.com>
      	* src/cell.c (cell_is_blank) : Update.
      	* src/border.c (style_border_draw) : Make somewhat more correct.
      	  Still broken for non-top-left corners.
      	* src/item-grid.c (item_grid_draw_border) : Ditto.
      	(item_grid_draw_background) : Rename from item_grid_paint_empty_cell
      	  handle spans more cleanly.
      	(item_grid_draw_cell) : handle conditionals for displaying contents here.
      	  Remove all handling of backgrounds.
    • Jukka-Pekka Iivonen's avatar
      The Solver can now solve the negative variables too. · 02e2eb17
      Jukka-Pekka Iivonen authored
      2000-02-28  Jukka-Pekka Iivonen  <iivonen@iki.fi>
      	* src/solver-lp.c (count_dimensions, make_solver_arrays,
      	solver_affine_scaling, solver_branch_and_bound): The Solver can
      	now solve the negative variables too.
      	* src/dialogs/dialog-solver.c (dialog_solver_options): Made the
      	`Assume non-negative' to be sensitive.