1. 15 May, 2000 1 commit
    • Jody Goldberg's avatar
      Fix typo breaking row/col ins/del breakage :-( · a5e04f49
      Jody Goldberg authored
      Make some minor improvements in status display for row/col selection.
      
      2000-05-14  Jody Goldberg <jgoldberg@home.com>
      
      	* src/commands.h : Reformat.
      
      	* src/commands.c (cmd_ins_del_row_col_{undo,redo}) : unant the
      	  selection when the topology changes.
      
      	* src/workbook.c (workbook_expr_relocate) : Fix typo.
      
      	* src/sheet-view.c (sheet_view_{col,row}_selection_changed) : Call
      	  sheet_update after a change.
      a5e04f49
  2. 09 May, 2000 2 commits
    • Morten Welinder's avatar
      Typo. · ede37a28
      Morten Welinder authored
      ede37a28
    • Jody Goldberg's avatar
      thanks Chema · ea7ad36d
      Jody Goldberg authored
      - Spans were not redrawn when interupted.
      - Spans were not recalculated when the blockage was cleared.
      - Sorting crashed because the semantics of sheet_remove_cell
        changed to call cell_destroy.
      
      2000-05-08  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_cell_calc_span) : redraw the bounding range when
      	  interupting spans.
      	(sheet_clear_region) : Respan ranges that were interupted by the
      	  cleared region.
      	(sheet_cell_remove_simple) : rename from sheet_cell_remove_internal and
      	  export.
      ea7ad36d
  3. 08 May, 2000 1 commit
    • Jody Goldberg's avatar
      Call sheet_update so that selection changes via mouse movement will update · acbe5a8b
      Jody Goldberg authored
      2000-05-08  Jody Goldberg <jgoldberg@home.com>
      
      	* src/selection.c (sheet_selection_extend_to) : Call sheet_update
      	  so that selection changes via mouse movement will update the status
      	  areas.
      	(sheet_selection_set) : Call sheet_flag_selection_change.
      
      	* src/sheet.c (sheet_flag_selection_change) : New function to
      	  flag that sheet_update should recalc the autoexpressions.
      acbe5a8b
  4. 05 May, 2000 1 commit
    • Jody Goldberg's avatar
      Make code match comment. We can safely ignore blanks. (gnumeric_sumif) : · 5ba47b54
      Jody Goldberg authored
      
      2000-05-05  Jody Goldberg <jgoldberg@home.com>
      
      	* src/functions/fn-math.c (gnumeric_countif) :
      	    Make code match comment.  We can safely ignore blanks.
      	(gnumeric_sumif) : Code was correct.  Add a larger comment explaining
      	  rationale.
      	(gnumeric_sumx2my2) : Code was wrong.  We can not skip blank cells
      	  if there are multiple ranges that need to be kept in sync.
      	(gnumeric_sumx2py2) : Ditto.
      	(gnumeric_sumxmy2) : Ditto.
      5ba47b54
  5. 04 May, 2000 1 commit
  6. 03 May, 2000 1 commit
    • Jody Goldberg's avatar
      Begin to rationalize support for inverted and 3D references. · de62dd3a
      Jody Goldberg authored
      More renaming and movement name rationalization.
      Some minor improvements in the function wizard.
      
      2000-05-03  Jody Goldberg <jgoldberg@home.com>
      
      	* EvalPosition -> EvalPos
      	  ParsePosition -> ParsePos
      	  new struct RangeRef used in ValueRange
      
      	  eval_pos_init* -> position.[ch]
      	  parse_pos_init*
      	  cell_ref_{get,make}*
      
      	* src/workbook.c : Reorder the toolbar a bit.
      	(workbook_foreach_cell_in_range) : New function.
      	(cb_autofunction) : New routine.
      	(workbook_set_auto_expr) : DO NOT put real code into pre/post
      	  conditions.  It will be removed when debugging is eventually
      	  disabled.
      
      	* src/position.c (range_ref_normalize) : New function.
      
      	* src/ranges.c (range_normalize) : New function.
      
      	* src/expr.c (expr_implicit_intersection) : Use range_ref_normalize.
      
      	* src/eval.c (cell_eval_content) : No need to release the value.
      	  cell_assign_value already does that.
      	(dependency_range_ctor) : Use range_normalize.
      
      	* src/auto-format.c (do_af_suggest) : Use workbook_foreach_cell_in_range.
      
      	* src/cell.c (cell_set_expr_and_value) : link the new expression but
      	  do not queue it for recalc.
      	(cell_assign_value) : Release the old value.
      	(cell_copy) : Init the value to empty.
      
      	* src/func.c (function_iterate_do_value) : Use
      	  workbook_foreach_cell_in_range.
      
      	* src/dialogs/dialog-function-wizard.c (create_description) : Use
      	  a label rather than a text entry widget.  It looks better.
      
      	* src/functions/fn-string.c (gnumeric_expression) : range is already
      	  absolute.
      
      	* src/functions/fn-stat.c (gnumeric_linest) : Handle inverted ranges.
      	(gnumeric_logest) : Ditto.
      
      	* src/functions/fn-information.c (gnumeric_countblank) : Use
      	workbook_foreach_cell_in_range.
      	(gnumeric_{row,column}) : Handle inversions.
      
      	* src/functions/fn-lookup.c (gnumeric_offset) : No need to make
      	  absolute.  The marshaller already did that.
      
      2000-05-02  Jody Goldberg <jgoldberg@home.com>
      
      	* src/eval.c (dependency_range_ctor) : normalize the range.
      
      	* src/xml-io.c (xml_write_cell_and_position) : Suppress warning.
      
      	* src/pixmaps.h : Add function wizard and equal sign.
      de62dd3a
  7. 02 May, 2000 1 commit
    • Jody Goldberg's avatar
      New function. · b2198f30
      Jody Goldberg authored
      
      2000-05-01  Jody Goldberg <jgoldberg@home.com>
      
      	* src/expr.c (expr_tree_shared) : New function.
      
      	* src/xml-io.c (gnumeric_xml_write_selection_clipboard) : Init and
      	  destroy the expression hash.
      	(gnumeric_xml_read_selection_clipboard) : Ditto.
      	(gnumeric_xml_read_workbook) : Ditto.
      	(gnumeric_xml_write_workbook) : Ditto.
      	(xml_write_cell_and_position) : When saving cells that have expression
      	  assign and store an ID for shared expressions.
      	(xml_read_cell) : Use the ID to restore shared expressions.
      b2198f30
  8. 29 Apr, 2000 1 commit
  9. 27 Apr, 2000 2 commits
    • Jody Goldberg's avatar
      update · 2621c346
      Jody Goldberg authored
      2621c346
    • Jody Goldberg's avatar
      Improve versioning. Fix a few bugs. · 2c8b64d0
      Jody Goldberg authored
      Improve versioning.
      Fix a few bugs.
      
      2000-04-26  Jody Goldberg <jgoldberg@home.com>
      
      	* src/command-context.c (gnumeric_error_sys_err) : New function.
      	* src/command-context-gui.c (ccg_error_sys_err) : Support it.
      
      	* src/gnumeric-util.c (gnumeric_glade_xml_new) : Use gnumeric_error_sys_err.
      
      	* src/gutils.c (gnumeric_sys_{data,lib,glade,plugin)_dir) : New functions.
      	(gnumeric_usr_dir, gnumeric_usr_plugin_dir) : New functions.
      
      	* src/plugin.c (load_all_plugins) : Use
      	  gnumeric_usr_plugin_dir, and  gnumeric_sys_plugin_dir.
      
      	* src/item-edit.c (point_is_inside_range) : Handle non-singleton
      	  expr start characters.
      
      2000-04-25  Jody Goldberg <jgoldberg@home.com>
      
      	* *.c : glade_new_xml -> gnumeric_glade_new_xml
      	  Localize GNUMERIC_GLADEDIR so that plugins can use it too.
      
      	* src/gnumeric-util.c (gnumeric_glade_xml_new) : New function.
      
      	* */Makefile.am : Set 'DATADIR' rather than GLADEDIR.  And version
      	  the glade file the same way the plugins are set.  This should
      	  probably expand to include architecture akin to gcc.
      
      	* src/widgets/widget-editable-label.c (el_button_press_event) :
      	  Clicking in another window accepts the changes.  Once we have
      	  reliquished our grab push the button event back on the queue
      	  so that it can be forwarded on to the appropriate recipient (9007).
      
      	* src/parse-util.c (parse_text_value_or_expr) : Watch for 1 character
      	  strings which could start an expression.
      2c8b64d0
  10. 20 Apr, 2000 1 commit
    • Jody Goldberg's avatar
      Reorg cell contents and assignment. · bedb925b
      Jody Goldberg authored
      Fixs lots of usability details.
      
      2000-04-20  Jody Goldberg <jgoldberg@home.com>
      
      	* src/dialogs/dialog-cell-format.c : Use the edit_pos as the example
      	  not the top left corner.
      
      	* src/functions/fn-stat.c (gnumeric_ftest) : Use eval_pos_cellref
      	  to help localize the strangeness.
      	(gnumeric_ttest) : Ditto.
      
      	* src/xml-io.c (xml_write_cell_and_position) : If this is an array
      	  expression and we are the top left then add attributes to indicate
      	  size of array.  Ignore the rest of the array.
      	(xml_not_used_old_array_spec) : New routinr to handle the old array format.
      	(xml_cell_set_array_expr) : store an array.
      	(xml_read_cell) : Handle the old and the new array formats.
      
      	* src/workbook.c (workbook_close_if_user_permits) : Accept input
      	  first.
      	(wb_edit_key_pressed) : Handle array formulas here.
      	(workbook_detach_sheet) : Do not recalc all if we are exiting.
      	(workbook_start_editing_at_cursor) : When we start editing an
      	  array formula display just the formula not all the extra {}()[][] crap.
      
      	* src/sheet.c (SheetPrivate) : Add a recompute_spans flag.
      	(sheet_calc_spans) : New routine.
      	(sheet_cell_calc_span) : New routine.
      	(sheet_range_calc_spans) : Renamed and extended from
      	  sheet_cells_update.
      	(sheet_update) : Use sheet_calc_spans when necessary.
      	  Update the location region when the edit_pos changes.
      	(cb_recalc_spans_in_col) : Renamed from cb_collect_cells_in_col.
      	  Recalcs spans directly, no need to collect first.
      	(cb_set_cell_content) : New routine to set expr, or expr_and_value.
      	(sheet_range_set_text) : Use cb_set_cell_content, and remember
      	  chosen format with the cell rather than overriding the assigned
      	  format.
      	(sheet_cell_set_text) : Renamed from sheet_set_text.  Be more specific
      	  about how spans, rendering and the rest are handled.
      	(sheet_cell_set_expr) : New routine.
      	(sheet_cell_set_value) : Ditto.
      	(sheet_load_cell_val) : When displaying an array formula add {%s}()[][].
      	(sheet_redraw_cell_region) : Honour spans when redrawing.
      	(sheet_redraw_partial_row) : New routine.
      	(sheet_redraw_cell) : Ditto.
      	(sheet_is_cell_array) : Use cell_is_array.
      	(sheet_range_splits_array) : Renamed from sheet_check_for_partial_array.
      	(sheet_cell_add_to_hash) :  Do not touch spans at this point.
      	(sheet_cell_insert) : Rename from sheet_cell_add made recalc span
      	  optional.
      	(sheet_cell_new) : New routine that does not touch spans.
      	(sheet_cell_remove) : Made redraw optional.
      	(cb_clear_cell_comments) : Remove the cell if there is no comment.
      	(sheet_clear_region) : Remove the cell if there are no comments or
      	  contents.  Flag an update of the status region.
      
      	* src/sheet-view.c (cb_colrow_resize) : New function.
      	(sheet_view_col_size_changed) : Resize all rows, irrespective of
      	(sheet_view_row_size_changed) : existing cells.
      	(sheet_view_redraw_cell_region) : This no longer honours spans.
      
      	* src/sheet-style.c (sheet_style_attach) : Removed call to redraw.
      	sheet_cells_update : rename to sheet_range_calc_spans and move to
      	  sheet.c.
      
      	* src/sheet-autofill.c (autofill_cell) : Use sheet_cell_set_value
      	  rather than set_text.
      
      	* src/selection.c (sheet_selection_changed_hook) : Delete.
      	(sheet_selection_extend_to) : Update the status region to display the
      	  new size.
      	(sheet_selection_cut) : Use sheet_range_splits_array.
      	(selection_check_for_array) : New routine.
      
      	* src/parser.y : Remove icky array formula parsing that conflicted
      	  with array entries.
      
      	* src/number-match.c (format_match) : Return a Value * rather than a
      	  double.
      
      	* src/mstyle.c (mstyle_set_font_size) : Do not allow font sizes < 1.
      
      	* src/main.c (gnumeric_main) : Do NOT create an empty workbook
      	  then delete it if things are successfully loaded.  This causes
      	  a global recalc.  Instead add a flag to disable exit when the
      	  number of workbooks go to zero.  Then only enable the flag AFTER
      	  we have attempted to load the initial workbooks.
      
      	* src/item-grid.c (item_grid_event) : Update the status_region when
      	  button-1 is release.  It should display the edit_pos.
      
      	* src/gutils.c : Move cell_name, col_name, col_from_name,
      	  parse_cell_name, parse_cell_name_or_range and parse_cell_name_list,
      	  to parse-util.c.
      
      	* src/gnumeric.h  : Add RenderedValue.
      
      	* src/gnumeric-util.c (gnumeric_char_start_expr_p) : Move
      	  to parse-util.c
      
      	* src/file.c (workbook_read) : Remove freese thaw usage.
      	  Move call to update AFTER mark clean.
      
      	* src/expr.c (eval_pos_init) : Take a cellpos.
      	(parse_pos_evalpos) : New routine.
      	(eval_pos_cellref) : There is some questionable code scattered in the
      	  functions.  This routing localizes the odd bits for correction.
      
      	* src/eval.c (cell_eval_content) : Use sheet_redraw_cell,
      	  and rendered_value_calc_size.
      	(cell_get_dependencies) : Improve constness.
      
      	* src/corba-sheet.c : Remove the freeze thaw operations.
      	(Sheet_cell_set_formula) : Deleted.
      	(Sheet_range_set_formula) : Delete.
      
      	* src/commands.c : Adjust so that registration of command auto
      	  calls redo.  Add misc checks for splitting arrays.
      
      	* src/clipboard.h : Move the CellCopy types here from cell.h
      
      	* src/clipboard.c (paste_cell) : Use cell_has_expr.
      	  Don't insert the new cell till after its contents are assigned.
      
      	* src/cellspan.c (cell_register_span) : Improve constness.
      	(cell_unregister_span) : Ditto.
      	(row_cell_get_displayed_at) : Delete.
      	(cell_calc_span) : Moved here from cell.c
      
      	* src/dialogs/dialog-stf.glade : Adjust the header background colour
      	  to match the purdy new icon.  Add the icon.
      
      	* src/cell-draw.c : Use the rendered_value routines.
      	  Improve constness.
      
      	* src/analysis-tools.c (set_cell) : Use sheet_cell_fetch.
      
      	*.*
      	    cell_set_* -> sheet_cell_set_
      	    cell_set_*_simple -> cell_set_
      	    Cell::{row,col} -> Cell::{row,col}_info
      	    cell_get_text -> cell_get_entered_text
      	    cell_get_content -> cell_get_entered_text
      	    cell_name -> cell_coord_name
      	    cell_get_formatted_val -> cell_get_rendered_text
      	    cell_get_content -> cell_get_entered_text
      
      	* src/cell.c :
      	(cell_dirty) : Renamed from cell_modified.  Use
      	  sheet_set_dirty.
      	(cell_formula_changed) : Make the queuing of the recalc optional.
      	(cell_cleanout) : Handle union of expression and entered_text,
      	  and remove the rendered value.
      	(cell_copy) : Ditto.
      	(cell_destroy) : handle cell_modified -> cell_dirty.
      	(cell_set_text) : Use parse_text_value_or_expr and store the prefered
      	  format.
      	(cell_set_text_and_value) : New routine.
      	(cell_assign_value) : New routine.
      	(cell_set_value) : Support formats.
      	(cell_set_expr_and_value) : New routine.
      	(cell_set_expr_internal) : Split from cell_set_expr.
      	(cell_set_expr) : Divide to allow for not queuing a recalc.
      	(cell_set_array_formula) : Use cell_set_expr_internal.
      	(cell_is_array) : New utility.
      	(cell_is_partial_array) : New utility.
      	(cell_has_expr) : New utility.
      	(cell_render_value) : Use rendered_value_*.
      	Move all comment routines into cell-comment.[ch].
      
      	* idl/Gnumeric.idl : Remove cell_set_formula, and range_set_formula.
      	  These were identical to set_text.  Made Workbook embeddable.
      bedb925b
  11. 17 Apr, 2000 1 commit
  12. 15 Apr, 2000 1 commit
  13. 10 Apr, 2000 1 commit
    • Jody Goldberg's avatar
      Do NOT recalc on load for now even though there are are queued cells that · 43aa96ea
      Jody Goldberg authored
      
      2000-04-10  Jody Goldberg <jgoldberg@home.com>
      
      	* src/file.c (workbook_read) : Do NOT recalc on load for now even
      	  though there are are queued cells that desire it.  This will
      	  prematurely mark the sheet as dirty.  This will need to be
      	  revisited.
      
      	* src/cell.c (cell_set_rendered_text) : Make static.
      
      	* src/cell.c (cell_calc_dimensions) : Be careful to recalculate spans
      	  that centered on other cells when calculating the span for a new
      	  cell.
      43aa96ea
  14. 09 Apr, 2000 1 commit
    • Jody Goldberg's avatar
      Do not change the target style if editing has not yet been enabled. · cd9b6682
      Jody Goldberg authored
      
      2000-04-09  Jody Goldberg <jgoldberg@home.com>
      
      	* src/dialogs/dialog-cell-format.c : Do not change the target style if
      	  editing has not yet been enabled.
      
      	* src/workbook.c (workbook_set_saveinfo) : If the save function is
      	  NULL default to xml.
      
      	* src/format.c (format_value) : Add some error checking.
      
      	* src/cell.c (calc_text_dimensions) : Make static
      
      	* src/main.c : Add main.h
      
      2000-04-03  Dom Lachowicz <dominicl@seas.upenn.edu>
      
       	* src/workbook.c (sheet_action_reorder_sheet): Right click on a
       	sheet tab, and if there's more than one sheet, you'll get an
       	option to bring up the re-order sheets dialog
      
       	* src/dialogs/dialog-plugin-manager.c (refresh_right_frame) :  Do not
      	  override default fonts and colours.
      
      	* src/dialogs/sheet-order.glade,
      	* src/dialogs/sheet-order.glade.h,
      	* src/dialogs/dialog-sheet-order.c (row_cb, delete_clicked_cb,
      	  up_clicked_cb, down_clicked_cb, close_clicked_cb,
      	  dialog_sheet_order_impl) : Improve look by moving buttons to the
      	  right edge rather than using stock buttons on the bottom and side.
      
      2000-04-07  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook.c (workbook_finish_editing) : resensitize the toolbars
      	  after editing.
      	(workbook_start_editing_at_cursor) : Desensitize the toolbars when we
      	  start to edit.
      cd9b6682
  15. 07 Apr, 2000 2 commits
    • Jody Goldberg's avatar
      Fix typo, did this ever work ? · cf3f1e00
      Jody Goldberg authored
      
      2000-04-07  Jody Goldberg <jgoldberg@home.com>
      
      	* src/embeddable-grid.h (GridViewClass) : Fix typo, did this ever work ?
      
      	* src/workbook.c (workbook_move_sheet) : Mark the book as dirty when a
      	  sheet moved.
      	(insert_sheet_cmd) : Mark book as dirty when sheet is added.
      	(workbook_attach_sheet) : Add a precondition to avoid failing in the
      	  bonobo case.
      cf3f1e00
    • Jody Goldberg's avatar
      Fix http://bugs.gnome.org/db/85/8506.html · 18e5debc
      Jody Goldberg authored
      Mixed mode references are evil.
      
      A bit of interface improvement for gtk-combo-text
      
      2000-04-06  Jody Goldberg <jgoldberg@home.com>
      
      	* src/functions/fn-string.c : Add func 'expression' to return text of
      	  formula.
      
      	* src/parser.y : It is illegal to write A1:Sheet2!A3.
      
      	* src/value.c (value_new_cellrange) : Take the eval pos so that we can
      	  correctly invert mixed mode references when necessary.
      
      	* src/expr.c (cell_ref_make_abs) : New routine.
      	(expr_relocate) : Handle changes in value_new_cellrange.
      	* src/func.c (function_marshal_arg) : Ditto.
      	* src/ranges.c (range_parse) : Ditto.
      
      	* src/corba-sheet.c (Sheet_cell_set_value) : No need to check these
      	  references.  They seem to be hard coded to be relative.
      
      	* src/functions/fn-lookup.c (gnumeric_offset) : Begin to handle
      	  relative references.
      
      	* src/sheet.c (cellref_get) : Simplify the logic a smidge.
      
      	* src/workbook.c (workbook_finish_editing) : Restore the edit area
      	  manually for now.  We may need to make the update flags finer grain.
      18e5debc
  16. 06 Apr, 2000 1 commit
  17. 04 Apr, 2000 1 commit
    • Jody Goldberg's avatar
      Improve status update. · 56a9e1f0
      Jody Goldberg authored
      Simplify a few command paths in preparation for registration.
      Hopefully fix bug 3961
      
      2000-04-04  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook.c (workbook_class_init) : Remove CELL_CHANGED.
      	(workbook_finish_editing) : At LAST! cmd_set_text is responsible for
      	  setting the text directly :-)
      
      	* src/workbook-format-toolbar.c (change_font_size_in_selection_cmd) :
      	  cmd_format takes care of the height adjustments.
      	* src/dialogs/dialog-cell-format.c (cb_fmt_dialog_dialog_apply) : Ditto.
      
      	* src/sheet.c (Sheet): Add flags edit_pos_changed, selection_content_changed.
      	(sheet_new) : init them.
      	(sheet_flag_status_update_cell) : New function that sets the flags.
      	(sheet_flag_status_update_range) : Ditto.
      	(sheet_update) : Fix typo. Add support for new flags.
      	(sheet_update_auto_expr) : Const correctness.
      	(sheet_update_controls) : Ditto.
      	(sheet_load_cell_val) : Ditto. Delete unused signal.
      	(sheet_set_text) : Use sheet_flag_status_update_range.
      	(sheet_set_edit_pos) : New routine.
      	(sheet_cursor_move) : Delete.
      	(sheet_fill_selection_with) : Remove.
      
      	* src/selection.c (sheet_selection_changed_hook) : const correctness.
      	(sheet_selection_change) : merge into sheet_selection_set.
      	(sheet_selection_extend_to) : Use sheet_selection_set.
      	(sheet_selection_set) : Merge with sheet_selection_change and use the
      	  sheet_cursor accessors rather than changing things directly.
      	(sheet_selection_walk_step) : Use sheet_selection_set, and sheet_set_edit_pos.
      
      	(sheet_is_all_selected) : const correctness.
      	(sheet_is_cell_selected) : New routine.
      	(sheet_is_range_selected) : New routine.
      
      	* src/item-grid.c (item_grid_draw_background) : Adjust to rename of
      	* sheet_selection_is_cell_selected -> sheet_is_cell_selected.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) : Cleanup the
      	  logic for creating fills and arrays so that it can have undo
      	  support.
      	  - Change the heuristic for selecting what type of characters can start
      	    an edit session.  Rather than using fixed Latin1 centric codes,
      	    guess that the 'length' field of the event is >0 if the character is
      	    printable.  Be more careful NOT to forward characters to the entry
      	    if we are not editing.
      	  - Use sheet_update.
      
      	* src/commands.c (command_pop_list_top) : Delete.
      	(cmd_format_redo) : Apply the height adjustment here.
      	(cmd_set_area_*) : Implement.
      	(*) : Use sheet_update.
      
      	* src/colrow.c (rows_height_update) : Moved here and generalized from
      	  sheet_selection_height_update.
      
      	* src/clipboard.c (sheet_paste_selection) : No need to call
      	  sheet_cursor_set.  sheet_selection_add_range already does that.
      	(clipboard_paste_region) : Flag updates to the status display if
      	  something changes.
      56a9e1f0
  18. 02 Apr, 2000 2 commits
  19. 01 Apr, 2000 1 commit
  20. 30 Mar, 2000 1 commit
  21. 26 Mar, 2000 1 commit
    • Jody Goldberg's avatar
      Make a happy TigerT. · ccc0ed7c
      Jody Goldberg authored
      2000-03-26  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook-format-toolbar.c (change_font_size_in_selection_cmd) :
      	  default size is 10 points.
      	(workbook_create_format_toolbar) : Switch the size selector over to
      	  gtk-combo-text too.
      
      2000-03-26  Jody Goldberg <jgoldberg@home.com>
      
      	* gtk-combo-text.c : Add a hash to be used for proper lookup of
      	  entries made directly in the edit area.  Yes morten it leaks.
      	(gtk_combo_text_construct) : Make scrolling
      	  optional.
      	(gtk_combo_text_add_item) : Add some brute force mouse over effects.
      	  Still need autoscroll, and cancel.
      ccc0ed7c
  22. 25 Mar, 2000 1 commit
    • Jody Goldberg's avatar
      Restore the auto/clear behavior of the color combo boxes and improve their · f76743a0
      Jody Goldberg authored
      handling of defaults.
      
      Switch the font selector to use the gnumeric gtk-combo-text.
      
      Make the combo-text scrollable.  It still needs work on selecting the
      right list element if the value is entered directly.
      
      2000-03-25  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook-format-toolbar.c (change_font_in_selection_cmd) :
      	  Switch to the gnumeric gtk-combo-text.
      	(workbook_create_format_toolbar) : Pass in a default colour.
      	(fore_color_changed) : Handle the NULL indicator as auto colour.
      	  Hard code to black for now.
      	(back_color_changed) : Handle the NULL indicator as no background.
      f76743a0
  23. 24 Mar, 2000 2 commits
  24. 22 Mar, 2000 3 commits
    • Jody Goldberg's avatar
      The current implementation supports arrays and references. It does not · 3b84712d
      Jody Goldberg authored
      
      2000-03-22  Jody Goldberg <jgoldberg@home.com>
      
      	* src/functions/fn-lookup.c (gnumeric_index) : The current
      	  implementation supports arrays and references. It does not support
      	  the special case of index 0,0 returning the entire range, nor does
      	  it support the second syntax (ref, row, col, area_num).
      	(gnumeric_match) : Document that only match_type == 0 works.
      3b84712d
    • Jody Goldberg's avatar
      Fix some typos. · 10e9a53e
      Jody Goldberg authored
      2000-03-22  Jody Goldberg <jgoldberg@home.com>
      
      	* src/plugin.c (plugin_load) : Typo.
      
      	* src/workbook.c (recalc_cmd) : Bug7739.
      10e9a53e
    • Jody Goldberg's avatar
      Fix span bugs. · 99ec14fe
      Jody Goldberg authored
      2000-03-22  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_reposition_comments) : Merged from
      	  sheet_reposition_comments_from_row and
      	  sheet_reposition_comments_from_col.
      
      	(sheet_update) : New function.  Use the new update flags from
      	  SheetPrivate that are set in the col/row resize functions
      	  to do delayed resizing and updates.  This allows the resizing to be
      	  batched for an entire logical operation.
      	(sheet_{col,row}_set_size_pixels) : Set the update flags.
      
      	* src/workbook-cmd-format.c (workbook_cmd_format_{row,column}_auto_fit) : No need to
      	  worry about redraws.  Use sheet_update.
      	(workbook_cmd_format_{row_height,column_width}) : Ditto.
      
      	* src/sheet-view.c (sheet_view_redraw_cell_region) : No need to
      	  recalculate the spans,  Use the pre-calculated versions.
      	(sheet_view_col_size_changed) : Use sheet_update.
      	(sheet_view_row_size_changed) : Ditto.
      
      	* src/sheet-style.c (re_dimension_cells_cb) : Use cell_calc_dimensions.
      	(sheet_cells_update) : No need to redraw per cell and guess the bound.
      	  It is simpler and more correct to calc dimension per cell, and
      	  redraw the region BEFORE and AFTER to handle spans.
      
      	* src/cell.[ch] (cell_style_changed) : Delete.
      
      	* src/cell-draw.c (cell_draw) : continue syncing with print code.
      	  Be even more careful in the possible presence of style bugs.
      	* src/item-grid.c (item_grid_draw) : Ditto.
      	* src/print-cell.c (print_cell) : Ditto.
      
      	* src/analysis-tools.c (correlation_tool) : Use sheet_update.
      	(covariance_tool) : Ditto.
      	(ttest_paired_tool) : Ditto.
      	(ttest_eq_var_tool) : Ditto.
      	(ttest_neq_var_tool) : Ditto.
      	(ftest_tool) : Ditto.
      
      2000-03-21  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet-private.h : Add status flags to accumulate state changes
      	  for later redraw.
      
      	* src/commands.c (cmd_format_redo) : Use sheet_update
      	  in case the row/col sizes changed due to font size changes.
      	(cmd_format_undo) : Ditto.
      
      	* src/widgets/gtk-combo-box.c (cb_state_change) : Only pseudo-prelight
      	  the display when over the arrow, not vice versa.
      	(gtk_combo_box_init) : Ditto.
      	(gtk_combo_box_set_display) : Ditto.
      
      	* src/sheet.c (sheet_row_get_distance_pts) : Enable reversed indicies.
      	(sheet_col_get_distance_pts) : Ditto.
      
      	* src/plugin.c (plugin_load) : Add more version checking to ensure
      	  that very old plugins that do not check their versions can not be
      	  loaded.
      
      2000-03-20  Jody Goldberg <jgoldberg@home.com>
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_make_cell_visible) : When
      	  forcing a scroll do a hard reset of the visible ranges.
      	(gnumeric_sheet_compute_visible_ranges) : Ditto.
      	(gnumeric_sheet_set_top_row) : Remove extraneous scroll.
      	(gnumeric_sheet_set_left_col) : Remove extraneous scroll.
      99ec14fe
  25. 18 Mar, 2000 1 commit
  26. 14 Mar, 2000 1 commit
  27. 10 Mar, 2000 1 commit
    • Jody Goldberg's avatar
      Constness. · c2af08a9
      Jody Goldberg authored
      2000-03-10  Jody Goldberg <jgoldberg@home.com>
      
      	* src/func.c (tokenized_help_new) : Constness.
      
      	* src/widgets/gtk-combo-box.c (cb_state_change) : New function to keep
      	  the state of the combo display button and the combo arrow in sync.
      	(gtk_combo_box_init) : Connect cb_state_change to the arrow.
      	(gtk_combo_box_set_display) : Ditto for the display widget.
      
      	* src/sheet.c (sheet_set_zoom_factor) : Bound the factor at 10% and 500%
      
      	* src/workbook.c (change_zoom_in_current_sheet_cb) :
      	  call change_displayed_zoom_cb to adjust the combo to contain the
      	(workbook_focus_current_sheet) : Only emit signal if the sheet
      	  changed.
      
      2000-03-08  Jody Goldberg <jgoldberg@home.com>
      
      	* src/collect.c (callback_function_collect) : Treat arrays and ranges
      	  as errors.
      
      	* src/format.c (format_value) : formating a range returns a
      	  #VALUE! message.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) :
      	  Use the workbook flags, and delete the icky globals.
      	(start_cell_selection_at) : Hide the std cursor when a cell selection
      	  cursor is created.
      	(gnumeric_sheet_stop_cell_selection) : Restore the std cursor.
      
      2000-03-07  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook.c (accept_input) : Use workbook_finish_editing.
      	(cancel_input) : Ditto.
      	(do_focus_sheet) : Support range selection across spreadsheets.
      	(workbook_get_sheet_position) : Fix and document.
      	(workbook_move_sheet) : Fix.
      	(workbook_focus_sheet) : Handle errors cleanly.
      	(wb_edit_key_pressed) : Improve F4 handling.
      	(wizard_input) : Begin non-modal function wizard.  NOT FINSIHED.
      	(workbook_start_editing_at_cursor) : transfered from
      	  sheet_start_editing_at_cursor.
      	(workbook_finish_editing) : Distilled from sheet_{accept,cancel}_pending_input.
      	(Workbook) : Add editing_cell, editing_sheet, editing.
      
      	* src/sheet.c (sheet_stop_editing) : Delete.
      	(sheet_accept_pending_input) : Merge into workbook_finish_editing.
      	(sheet_cancel_pending_input) : Ditto.
      	(sheet_start_editing_at_cursor) :
      	(sheet_create_edit_cursor) : New function.
      	(sheet_destroy_edit_cursor) : New function.
      	(sheet_destroy_cell_select_cursor) :  New function.
      	(Sheet) : Delete editing and editing_cell.
      
      	* src/selection.c (sheet_selection_changed_hook) : Make public.  This
      	  should eventually move but I'm not sure where.  It is used for more
      	  than just changes in the selection in the current sheet.  It must
      	  also be called when the sheet changes.  What it REALLY does it to
      	  sync the shared workbook state with the current sheet's selection.
      
      	* src/item-cursor.c (item_cursor_init) : Handle change from
      	  sheet_accept_pending_input -> workbook_finish_editing.
      	* src/item-grid.c (item_grid_button_1) : Ditto.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_can_move_cursor) : Edit moved
      	  from sheet -> workbook.
      	(selection_insert_selection_string) : Extend to support
      	  abs/rel refs and intersheet-refs.
      	(gnumeric_sheet_stop_cell_selection) : Add clear_string argument
      	  to optionally remove the selection range.
      	(gnumeric_sheet_key_mode_sheet) : Adjust to movement of editing flag
      	  from sheet -> workbook.  Be careful to use the original sheet when
      	  moving rather than the current sheet.  Support F4 while editing.
      
      	* src/cell-draw.c (cell_draw) : editing_cell has moved from sheet to
      	  workbook.  Fix font ref leak when drawing the edit cell.
      
      	* src/dialogs/dialog-function-wizard.c : Begin transition to being
      	  non-modal.  NOT FINISHED.
      c2af08a9
  28. 06 Mar, 2000 1 commit
  29. 01 Mar, 2000 1 commit
  30. 28 Feb, 2000 2 commits
    • Jody Goldberg's avatar
      update · f8162ca7
      Jody Goldberg authored
      f8162ca7
    • Jody Goldberg's avatar
      Improve the handling of backgrounds and selection in the presence of · bb5371b7
      Jody Goldberg authored
      
      Improve the handling of backgrounds and selection
      in the presence of spanning columns.
      
      Improve borders.  Somewhat more correct handling of double lined borders.
      Still mostly wrong, but its a start.
      
      2000-02-28  Jody Goldberg <jgoldberg@home.com>
      
      	* src/expr.h : Move FunctionDefinition to
      	* src/gnumeric.h : here.
      
      	* src/cellspan.c (col_hash) : Use GPOINTER_TO_INT.
      	(col_compare) : Ditto.
      	(row_init_span) : Delete.
      	(free_hash_value) : Renamed from free_hash_key.
      	(cell_register_span) : Register all cells in a span, malloc a
      	  CellSpanInfo to store a descriptor about the first and last cols.
      	(assemble_unregister_span_list) : Delete.
      	(span_remove) : New function for use by g_hash_table_foreach_remove.
      	(cell_unregister_span) : Use g_hash_table_foreach_remove.
      	(row_cell_get_displayed_at) : Adjust to new descriptor.
      	(row_span_get) : New function.
      
      	* src/cell.c (cell_calculate_span) : Renamed from cell_get_span.
      
      	* src/cell-draw.c (cell_draw) : Do not draw backgrounds here.
      	  Use new CellSpanInfo to avoid recomputing spans every time.
      	(cell_is_blank) : Remove hack about treating empty strings as empty.
      
      	* src/cellspan.h : New file.  Move span decls here.
      
      	* src/item-grid.c (item_grid_draw) : Rework to correctly handle
      	  backgrounds and borders for spanning columns.
      
      2000-02-27  Jody Goldberg <jgoldberg@home.com>
      
      	* src/cell.c (cell_is_blank) : Update.
      
      	* src/border.c (style_border_draw) : Make somewhat more correct.
      	  Still broken for non-top-left corners.
      
      	* src/item-grid.c (item_grid_draw_border) : Ditto.
      	(item_grid_draw_background) : Rename from item_grid_paint_empty_cell
      	  handle spans more cleanly.
      	(item_grid_draw_cell) : handle conditionals for displaying contents here.
      	  Remove all handling of backgrounds.
      bb5371b7
  31. 26 Feb, 2000 1 commit
  32. 22 Feb, 2000 1 commit