1. 01 Jul, 2000 3 commits
    • Morten Welinder's avatar
      Guard against empty entry. · 9ba10168
      Morten Welinder authored
      2000-06-30  Morten Welinder  <terra@diku.dk>
      
      	* src/file.c (dialog_query_load_file): Guard against empty entry.
      9ba10168
    • Morten Welinder's avatar
      Plug leak. · 1067a54a
      Morten Welinder authored
      2000-06-30  Morten Welinder  <terra@diku.dk>
      
      	* src/parse-util.c (parse_cell_name_list): Plug leak.
      
      
      2000-06-30  Morten Welinder  <terra@diku.dk>
      
      	* dialog-solver.c (dialog_results): Initialise
       	keep_solver_solution.
      	(dialog_solver): Remove buffer overflow.  Mark string for
       	translation.  Call free_original_values to plug leak.  Remove
       	several bogus casts.
      	(constr_change_click): Remove buffer overflow.
      	(free_original_values): New function.
      
      	* dialog-autocorrect.c (add_fl_clicked): Use g_strdup.
      	(add_in_clicked): Ditto.
      1067a54a
    • Morten Welinder's avatar
      Remove a number of evil fixed-length buffers. · c2479cad
      Morten Welinder authored
      
      
      2000-06-30  Morten Welinder  <terra@diku.dk>
      
      	* src/solver-lp.c (write_constraint_str): Return an allocated
       	string instead of taking an unsized buffer.  Constify.  All
       	callers changed.
      c2479cad
  2. 30 Jun, 2000 5 commits
    • Morten Welinder's avatar
      Get rid of old plugins. · 43074ed0
      Morten Welinder authored
      43074ed0
    • JP Rosevear's avatar
      Use consistent names. · 8bf014a8
      JP Rosevear authored
      2000-06-30  JP Rosevear  <jpr@arcavia.com>
      
      	* src/embeddable-grid.c (EmbeddableGridFactory_init): Use
      consistent names.
      
      	* gnumeric.gnorba: Make server names consistent
      
      	* gnumeric.oafinfo: Make server names consistent
      8bf014a8
    • Jody Goldberg's avatar
      It is possible to have a guru up without editing. · 69d6d36b
      Jody Goldberg authored
      
      2000-06-30  Jody Goldberg <jgoldberg@home.com>
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_can_select_expr_range) : It is
      	  possible to have a guru up without editing.
      	(gnumeric_sheet_key_press) : rename from gnumeric_sheet_key.
      	(gnumeric_sheet_size_allocate) : rename from gnumeric_size_allocate.
      	(gnumeric_sheet_focus_in) : Enable the input context.
      	(gnumeric_sheet_focus_out) : Disable the input context.
      	(gnumeric_sheet_realize) : Create the input context.
      	(gnumeric_sheet_unrealize) : Destroy the input context.
      	(gnumeric_sheet_class_init) : Register the new methods.
      	(gnumeric_sheet_init) : Init the input context.
      
      	* src/clipboard.c (x_selection_handler) : Adjust to changes in
      	  application_clipboard_clear.
      	(x_selection_clear) : Ditto.
      	* src/cmd-edit.c (cmd_paste) : Ditto.
      	* src/sheet.c (sheet_destroy) : Ditto.
      
      	* src/application.c (application_clipboard_clear) : Make dropping the
      	  selection optional.  This removes the kludges necessary to handle
      	  changing the clipboard when we already have the selection.
      
      	* src/functions/fn-logical.c (gnumeric_true, gnumeric_false) :
      	  fix signatures.
      69d6d36b
    • Jukka-Pekka Iivonen's avatar
      Added FALSE(). · 4beddd14
      Jukka-Pekka Iivonen authored
      2000-06-30  Jukka-Pekka Iivonen  <iivonen@iki.fi>
      
      	* src/functions/fn-logical.c: Added FALSE().
      4beddd14
    • Jody Goldberg's avatar
      Bug 15796 · 71d65f69
      Jody Goldberg authored
      2000-06-29  Jody Goldberg <jgoldberg@home.com>
      
      	* src/application.c (application_set_selected_sheet) : short circuit
      	  clearing the selection if we are in the same workbook, not just the
      	  same sheet.
      71d65f69
  3. 29 Jun, 2000 3 commits
  4. 28 Jun, 2000 4 commits
    • Jody Goldberg's avatar
      Ref the function here. · c3de6cfe
      Jody Goldberg authored
      
      2000-06-28  Jody Goldberg <jgoldberg@home.com>
      
      	* src/expr.c (expr_tree_new_funcall) : Ref the function here.
      c3de6cfe
    • Jody Goldberg's avatar
      Init the new elements. · ca054481
      Jody Goldberg authored
      
      2000-06-28  Jody Goldberg <jgoldberg@home.com>
      
      	* src/func.c (fn_def_new) : Init the new elements.
      ca054481
    • Jody Goldberg's avatar
      new function. · 93f11589
      Jody Goldberg authored
      
      2000-06-28  Jody Goldberg <jgoldberg@home.com>
      
      	* src/functions/fn-sheet.c (GNUMERIC_VERSION) : new function.
      
      	* src/workbook.c (workbook_do_destroy) : No need to release the
      	  clipboard here.  The Sheet does it for us.
      
      	* src/workbook-format-toolbar.c : Add Fill to the default money
      	  format.
      
      	* src/symbol.c : The only symbols are functions.  The global table
      	  should not be world visible.
      
      	* src/sheet.c (sheet_flag_status_update_cell) : Take a CellPos.
      	(sheet_get_extent_cb) : Use Cell::pos rather than adding an
      	  indirection.
      	(cb_set_cell_content) : Use StyleFormat.
      	(sheet_cell_set_value) : Call sheet_flag_status_update_cell.
      	(sheet_cell_set_value) : Ditto.
      	(sheet_destroy) : Prepare to clear out named expressions.
      	(colrow_move) : Handle changes in cell_relocate signature.
      	(sheet_move_range) : Ditto.
      
      	* src/sheet-autofill.c : Use StyleFormats.
      
      	* src/position.c (parse_pos_init) : Global position are permitted.
      
      	* src/parser.y : Large change.  Do not automaticlly look for function
      	  names or named expressions in the lexer.  The lexer returns STRING
      	  and QUOTED_STRING.  The parser then does the appropriate lookups to
      	  potentially convert to something else.  This allows us to have sheet
      	  names that are the same as functions.
      
      	* src/parse-util.c (cellref_name) : Add flag to optionally disable the
      	  addition of the sheet name.  This is useful when printing
      	  Sheet2!A1:A3 rather than Sheet2!A1:Sheet2!A3.
      
      	* src/number-match.c (format_create_regexp) : Handle fill formats.
      
      	* src/mstyle.c (mstyle_get_border) : Fix constness.
      
      	* src/mathfunc.c (combin, fact) : Moved these here from
      	  functions/fn-math.c
      
      	* src/main.c (gnumeric_main) : No more constants_init, or
      	  global_symbol_init.
      
      	* src/func.c () : Reorg.  Remove some dead code.  Begin adding
      	  workbook local function support, Begin adding volatile, and
      	  semi-volatile functions.  Move the use of SymbolTable internal
      	  in preparation for eliminating it.
      
      	* src/format.c (format_number) : Improve support for pound, yen, and euro.
      	  Remember to produce a number when we hit spacing.
      
      	* src/expr.c : Have ExprFunc refer directly to the FunctionDefinition
      	  We still use a SymbolTable internally, but that will be merged out
      	  later.
      
      	* src/expr-name.c : Major reorg.  Not complete.
      
      	* src/corba-sheet.c (fill_corba_value) : Adjust to changes in
      	  cellref_name signature.
      
      	* src/commands.c (cmd_set_date_time_undo) : No need to manually call
      	  update_cell_flag.  cell_remove, and cell_set_text do that for us.
      	(cmd_set_date_time_redo) : Ditto.
      	  Use StyleFormat.
      
      	* src/clipboard.c (paste_cell) : Take the ExprRewriteInfo as an
      	  argument.
      	(clipboard_paste_region) : Init the ExprRewriteInfo.  We need to do
      	  this here rather than in cell_relocate because we may be moving a
      	  region, not just a single cell, and references within the region
      	  should not be changed.
      
      	* src/cell.c (cell_relocate) : Take the relocation info as an
      	  argument.  Non NULL indicates a request to check bounds.  We can not
      	  do this at the cell level. becuase we may be moving a block rather
      	  than just a single cell, and references into the block should NOT be
      	  rewritten.
      	(cell_set_text_and_value) : Take a StyleFormat.
      	(cell_assign_value) : Ditto.
      	(cell_set_value) : Ditto.
      	(cell_set_expr_internal) : Ditto.
      	(cell_set_expr_unsafe) : Ditto.
      	(cell_set_expr) : Ditto.
      
      	* src/auto-format.c (do_af_suggest) : Expression now refers directly
      	  to functionDef.
      93f11589
    • Miguel de Icaza's avatar
      Add OAF support here. · d0321221
      Miguel de Icaza authored
      2000-06-22  Miguel de Icaza  <miguel@helixcode.com>
      
      	* src/sheet-object-item.c (sheet_object_item_new): Add OAF support
      	here.
      d0321221
  5. 27 Jun, 2000 2 commits
    • JP Rosevear's avatar
      Undo transposition of find_bound_walk parameters. · c6075c55
      JP Rosevear authored
      2000-06-27  JP Rosevear  <jpr@arcavia.com>
      
      	* src/functions/fn-lookup.c (find_index_bisection): Undo
      	transposition of find_bound_walk parameters.
      
      	* samples/excel/lookfuns2.xls: Add type mismatch tests.
      c6075c55
    • Jukka-Pekka Iivonen's avatar
      Fixed copy-paste bug in documentation. · aa8a7aa8
      Jukka-Pekka Iivonen authored
      2000-06-27  Jukka-Pekka Iivonen  <iivonen@iki.fi>
      
      	* src/functions/fn-stat.c (help_finv): Fixed copy-paste bug in
       	documentation.
      
      	* src/functions/fn-logical.c: Added TRUE() function since it is
       	also a function in Excel.
      
      	* TODO: Updated the status of the build-in functions.
      aa8a7aa8
  6. 26 Jun, 2000 4 commits
    • JP Rosevear's avatar
      New function that doesn't require an error variable - use only if · 6b68e93d
      JP Rosevear authored
      2000-06-26  JP Rosevear  <jpr@arcavia.com>
      
      	* src/value.c (value_get_as_checked_bool): New function that
      	doesn't require an error variable - use only if confident that
      	the value does actually exist.
      
      	* src/value.h: Add new prototype.
      
      	* src/functions/fn-lookup.c: Clean up cruft
      	(find_type_valid): See if the value is a string or is gnumeric.
      	(find_compare_type_valid): See if the types are comparable.
      	(find_bound_walk): Walk an integer range first in one direction
      	and then in the other direction.
      	(find_index_linear): Do a linear search on a range or array.
      	(find_index_bisection): Do a bisection search on a range or array
      	that also follows excel rules for for handling type mismatches
      	during the search and finding the first and last item matching
      	the search.
      	(gnumeric_vlookup): Use new functions and implement undocumented
      	excel behaviour.
      	(gnumeric_hlookup): ditto
      	(gnumeric_lookup): ditto
      	(gnumeric_match): ditto
      6b68e93d
    • Morten Welinder's avatar
      Don't double translate. Compare the right number of characters. · ef4e3980
      Morten Welinder authored
      2000-06-26  Morten Welinder  <terra@diku.dk>
      
      	* src/format.c (lookup_color): Don't double translate.  Compare
       	the right number of characters.
      ef4e3980
    • Michael Meeks's avatar
      return non-filenames as NULL. · c13cb208
      Michael Meeks authored
      2000-06-26  Michael Meeks  <michael@helixcode.com>
      
      	* src/sheet-object-bonobo.c (get_file_name): return non-filenames
      	as NULL.
      c13cb208
    • Jukka-Pekka Iivonen's avatar
      Implemented COUPDAYS for basis 0, 2, 3, and 4 (basis 1 is still not · b02f342f
      Jukka-Pekka Iivonen authored
      2000-06-26  Jukka-Pekka Iivonen  <iivonen@iki.fi>
      
      	* src/functions/fn-financial.c: Implemented COUPDAYS for basis 0,
       	2, 3, and 4 (basis 1 is still not implented).
      b02f342f
  7. 23 Jun, 2000 4 commits
    • Morten Welinder's avatar
      Constify. (set_group_option_signals): Constify. (new_frame): Constify. · 9379ee6e
      Morten Welinder authored
      2000-06-23  Morten Welinder  <terra@diku.dk>
      
      	* src/dialogs/dialog-analysis-tools.c (set_output_option_signals):
       	Constify.
      	(set_group_option_signals): Constify.
      	(new_frame): Constify.
      	(error_in_entry): Constify.
      	(new_dialog): Constify.
      
      	* src/analysis-tools.c: major cleanup.  Eliminate fixed-size
       	buffers that might overflow; constify; plug leaks; improve
       	precision; produce numbers without going through strings.
      	(set_cell_float, set_cell_int, set_cell_na, set_cell_printf): New
       	functions.
      
      	* src/xml-io.c (xml_write_range): Constify.
      	(xml_get_gnome_canvas_points): Mark code as bogus.
      	(xml_set_gnome_canvas_points): Constify.  Improve space checks.
      	(xml_set_value_int): Improve buffer sizing.
      	(xml_set_value_string): Constify.
      	(xml_set_color_value): Improve buffer sizing.
      
      	* src/ranges.c (parse_range): Constify, simplify, optimise, and
       	secure.
      	(range_parse): Fix strict case.
      
      	* src/parse-util.c (parse_cell_name_or_range): Remove bogus cast.
      9379ee6e
    • Jon K Hellan's avatar
      (sheet_object_container_new_bonobo): As suggested by Michael: use the · 57fdcf94
      Jon K Hellan authored
      2000-06-23  Jon K Hellan  <hellan@acm.org>
      
      	(sheet_object_container_new_bonobo): As suggested by Michael:
      	use the accessor function bonobo_client_site_get_embeddable to
      	get the bound embeddable.
      57fdcf94
    • Karl Eichwalder's avatar
      198d2f30
    • Jody Goldberg's avatar
      Revert part of patch 1.48 to item-edit.c · 2512f495
      Jody Goldberg authored
      2000-06-22  Jody Goldberg <jgoldberg@home.com>
      
      	* src/item-edit.c (item_edit_draw_text) : Restore code that was
      	  deleted to handle a cursor on another line, or at the start of the
      	  line.
      2512f495
  8. 22 Jun, 2000 1 commit
  9. 21 Jun, 2000 1 commit
    • Michael Meeks's avatar
      fix. · cc570eae
      Michael Meeks authored
      2000-06-21  Michael Meeks  <michael@helixcode.com>
      
      	* src/embeddable-grid.c (embeddable_grid_init_anon): fix.
      cc570eae
  10. 20 Jun, 2000 5 commits
    • Morten Welinder's avatar
      Leak and assertion fix from Jody's tree. · e44670ba
      Morten Welinder authored
      2000-06-20  Morten Welinder  <terra@diku.dk>
      
      	* src/commands.c (cmd_ins_del_row_col_undo): Leak and assertion
       	fix from Jody's tree.
      e44670ba
    • Jody Goldberg's avatar
      Plug leak. · ff6ab926
      Jody Goldberg authored
      
      2000-06-20  Jody Goldberg <jgoldberg@home.com>
      
      	* src/commands.c (cmd_paste_cut_redo) : Plug leak.
      ff6ab926
    • Jody Goldberg's avatar
      strings with only spaces are NOT numbers. · a159d5d5
      Jody Goldberg authored
      
      2000-06-20  Jody Goldberg <jgoldberg@home.com>
      
      	* src/number-match.c (format_match) : strings with only spaces are NOT
      	  numbers.
      a159d5d5
    • Jody Goldberg's avatar
      Release 0.56 · 56ebe393
      Jody Goldberg authored
      56ebe393
    • Jody Goldberg's avatar
      We need to manually trigger a changed event after setting the position · 739a6dc7
      Jody Goldberg authored
      2000-06-19  Jody Goldberg <jgoldberg@home.com>
      
      	* dialog-function-wizard.c (formula_guru_set_expr) : We need to
      	  manually trigger a changed event after setting the position becuase
      	  pre-gtk-1.4 setting the text reset the cursor position to 0.
      	(cb_formula_guru_entry_event) : new function.
      	(cb_formula_guru_rolled_entry_event) : new function.
      
      
      2000-06-19  Jody Goldberg <jgoldberg@home.com>
      
      	* src/eval.c (invalidate_refs) : const.
      	(do_deps_destroy) : const.
      
      	* src/cell.c (cell_set_expr_internal) : Be careful about unrefing.
      
      	* src/item-edit.c (entry_event) : Rather than catching 'event' and
      	  checking for the type of event we want.  Catch the events directly.
      	  That way the events can take place BEFORE we look for our position.
      739a6dc7
  11. 19 Jun, 2000 3 commits
  12. 18 Jun, 2000 3 commits
  13. 17 Jun, 2000 1 commit
  14. 16 Jun, 2000 1 commit
    • Jody Goldberg's avatar
      Move error and boolean handling to the value level. · 6b2218b0
      Jody Goldberg authored
      2000-06-15  Jody Goldberg <jgoldberg@home.com>
      
      	* src/value-sheet.c (value_is_error) : No need for 'offset' parm.
      
      	* src/number-match.c (format_match) : Parse TRUE/FALSE as this level.
      
      	* src/value-sheet.c (constants_init) : TRUE/FALSE are not symbols.
      	  They are values.  A symbol only has value in an expression.
      	  A value operates at a lower level.  eg
      	A1 : '=TRUE' will work as a value or a symbol
      	A1 : 'TRUE' will only work as a value
      
      2000-06-15  Jody Goldberg <jgoldberg@home.com>
      
      	* src/format.c (lookup_color) : Handle translated colours.
      6b2218b0