GitLab

2001-05-04  Jon K Hellan  <hellan@acm.org>

	* hf-config.glade: Set this one invisible, too.

2001-05-04  Morten Welinder  <terra@diku.dk>

	* src/expr.c (expr_parse_string): Plug leak.

2001-05-04  Jon K Hellan  <hellan@acm.org>

	* src/dialogs/dialog-stf-export.glade: Set invisible to avoid
        flicker when popping up.

2001-05-04  Jon K Hellan  <hellan@acm.org>

 	* src/dialogs/dialog-printer-setup.c (struct
 	PrinterSetupState) : Add ExprEntry widgets.
 	(do_setup_page_info): Add ExprEntry widgets on the fly.
 	(do_print_cb): Close print setup dialog before displaying print
 	dialog. FIXME.
 	(do_print_preview_cb): No longer close the dialog.
 	(do_print_cancel_cb): New function. Close the dialog.
 	(do_print_ok_cb): New function. Save info and close the dialog.
 	(do_print_set_focus_cb): New function. Enable range selection when
 	an ExprEntry acquires focus.
 	(do_setup_main_dialog): Clean up dead code. Attach callbacks to
 	"ok", "cancel", "set-focus" and "destroy". Attach guru.
 	(printer_setup_state_free): Move just after
 	printer_setup_state_new. Set conversion_listeners member to NULL
 	after freeing list.
 	(do_fetch_page_info): top_entry and left_entry widgets are now
 	taken from state rather than glade_xml_get_widget.
 	(dialog_printer_setup): Eliminate recursive mainloop.

2001-05-04  Jon K Hellan  <hellan@acm.org>

	* src/widgets/gnumeric-expr-entry.h: GnumericExprEntryPrivate is
	unused. Remove.

	* src/widgets/gnumeric-expr-entry.c
	(gnumeric_expr_entry_set_rangesel_from_range):  Make sure that pos
	>= 0. Implement full column and full row flags.
	(gnumeric_expr_entry_toggle_absolute): Call update_reangesel_text
	with pos = 0.

2001-05-04  Jon K Hellan  <hellan@acm.org>

	* workbook-attr.glade: Don't set title here after all. It has no
	effect.

	(Only checked in dialog-workbook-attr.c last time I tried to
	do this.)

2001-05-04  Jon K Hellan  <hellan@acm.org>

	* dialog-workbook-attr.c (attr_dialog_impl): Back out change
	below. Looks like <title> in glade file doesn't work for property
	dialogs.

	* workbook-attr.glade: Don't set title here after all. It has no
	effect.

2001-05-04  Morten Welinder  <terra@diku.dk>

	* src/analysis-tools.c (set_cell_value): Make public.

	* src/solver-lp.c (solver_sensitivity_report,
 	solver_answer_report): Use set_cell_value.

	* src/value.c (value_peek_string): New function.

	* src/expr.c (eval_expr_real): Simplify CONCAT case using
 	value_peek_string.

	* src/datetime.c (datetime_value_to_serial_raw): Simplify using
 	value_peek_string.

	* src/workbook-view.c (wb_view_auto_expr_recalc): Ditto.

	* src/graph-vector.c (graph_vector_seq_string): Ditto.

	* src/solver-lp.c (find_name): Ditto.

2001-05-04  Morten Welinder  <terra@diku.dk>

	* fn-string.c (gnumeric_exact, gnumeric_len, gnumeric_rept,
 	gnumeric_find): Ditto.

	* fn-eng.c (value_get_as_complex): Simplify using
 	value_peek_string.

2001-05-04  Morten Welinder  <terra@diku.dk>

	* fn-string.c (gnumeric_len, gnumeric_exact, gnumeric_trim):
 	Cleanup.
	(gnumeric_rept): Un-suckify.

2001-05-04  Almer S. Tigelaar  <almer@gnome.org>

 	* src/GNOME_Gnumeric.xml: Correct InsertComment
 	pixmap, add pixmap for Sort and add separators
 	on the right places.

 	* src/pixmaps: Split sort ascending into 16x16 and
 	24x24 versions.

 	* src/application.c: Account for the split. This
 	will make the menu item show up with a correct
 	icon in Bonobo.

	* src/workbook-control-gui.c: Idem. Use the 16x16
	icon for the menu.

2001-05-04  Almer S. Tigelaar  <almer@gnome.org>

	* hf-config.glade: Set window title.
	* search-replace.glade: Idem.
	* workbook-attr.glade: Idem.

	* autoformat.glade: Correct window title.
	* dialog-stf-export.glade: Idem.
	* validate.glade: Idem.
	* solver.glade: Idem and some minor polishing.

	* dialog-workbook-attr.c: Don't set the window title
	with gtk_window_set_title, it's in the glade file anyway.

2001-05-04  Almer S. Tigelaar  <almer@gnome.org>

	* src/commands.c (cmd_unmerge_cells): Correct minor typo.
	(cmd_merge_cells): Idem.

2001-05-04  Almer S. Tigelaar  <almer@gnome.org>

	* names.glade: Set window title.

2001-05-01  Jody Goldberg <jgoldberg@home.com>

	* applix-read.c : suppress warnings.

2001-05-03  Jon K Hellan  <hellan@acm.org>

	* src/gnumeric-util.c (cb_remove_object_data): New callback
	function. Removes object data from wbcg when dialog is destroyed.
	(gnumeric_keyed_dialog): New function. Make dialog a transient
	child of wbcg, attaching to wbcg object data to identify the
	dialog.
	(gnumeric_dialog_raise_if_exists): New function: Raise the dialog
	identified by key if it is registered on the wbcg.

	* src/gnumeric-util.h (gnumeric_dialog_make_unique,
	gnumeric_dialog_raise_if_exists): Declare.

 	* src/about.c (dialog_about): Use gnumeric_keyed_dialog.
	Use gnumeric_dialog_raise_if_exists to ensure that only one sheet
	object config dialog at a time can be displayed for a wbcg.

 	* src/sheet-object-widget.c (sheet_widget_checkbox_user_config):
	Ditto.

2001-05-03  Jon K Hellan  <hellan@acm.org>

	* src/dialogs/dialog-define-names.c (name_guru_init): Use
	gnumeric_keyed_dialog rather than gnumeric_non_modal_dialog.
	(dialog_define_names): Use (gnumeric_dialog_raise_if_exists to
	ensure that only one instance at a time can be displayed for a
	wbcg.

2001-05-02  Almer S. Tigelaar  <almer@gnome.org>

	* src/workbook-edit.c (cb_thaw_ui_toolbar): Callback timer
	routine, re-enables the toolbars.
	(workbook_edit_set_sensitive): Add a ui timer to eliminate
	toolbar flickering.

	* src/sheet.c (sheet_menu_state_enable_insert): Clean-up.

2001-05-01  Almer S. Tigelaar  <almer@gnome.org>

 	* src/parser.y (yylex): Seek for matching )'s for ('s and
 	vice versa.
 	(find_bracket): The meat for the above functionality
 	(find_char): Split out from yylex, might be useful in other
 	places. Currently used to scan for matching quotes.
	(gnumeric_expr_parser): If the ExprTree is null, assume that
	an error has occurred, set a general "invalid expression" and
	mark the whole expression. Also display more detail when both
	the expression and error message are non-null.

2001-05-01  Morten Welinder  <terra@diku.dk>

	* fn-string.c (gnumeric_left, gnumeric_right, gnumeric_lower,
 	gnumeric_upper, gnumeric_clean, gnumeric_proper): Un-suckify.
	(wildcards_and_question_marks, parse_search_string): Constify.

2001-05-01  Almer S. Tigelaar  <almer@gnome.org>

	* src/application.[ch] (application_clipboard_unant): Use
	sheet_unant.
	(application_clipboard_clear): Idem.
	(application_clipboard_copy): Use sheet_ant.
	(application_clipboard_cut): Idem.
	(application_clipboard_is_cut): New function, is the area
	on the clipboard marked for cutting or for copying?

	* src/selection.[ch] (sheet_selection_ant): Deprecated, remove.
	(sheet_selection_unant): Idem.

	* src/sheet-control-gui.[ch] (scg_selection_ant): Rename
	to scg_ant and add a ranges parameter where the ranges to
	ant can be specified.
	(scg_selection_unant): Rename to scg_unant.
	(scg_destroy): Make sure to un-ant everything.
	(scg_construct): Ant all anted regions on the sheet.

	* src/sheet.[ch] (sheet_ant): New, ants one or more regions
	on the sheet.
	(sheet_unant): New, unants all currently anted region on the
	sheet.
	(sheet_destroy): Make sure to free the ant list.

	* src/commands.c (cmd_ins_del_colrow_undo): Remove ugly ant-hack,
	this is no longer needed, application_clipboard_cut/copy handles
	this now.
	(cmd_ins_del_colrow_redo): Idem
	(cmd_ins_del_colrow): Oh dear, we were actually storing both
	the cut and copied area as a cut area and we were actually
	cutting even if the range was a copied area after shifting.

2001-04-30  Jody Goldberg <jgoldberg@home.com>

	* src/about.c (dialog_about) : sync with website.

	* src/format.c (format_number) : don't suppress the minus sign when
	  faced with a space in the format.  Is there a counter example ?
	(format_number) : handle negative improper fractions.

2001-04-30  Morten Welinder  <terra@diku.dk>

	* src/func.c (tokenized_help_find): Warning killer.

	* src/value.c (value_new_array): Kill warnings.
	(value_new_array_empty): Ditto.
	(value_release): Ditto.

	* src/print-cell.c (print_show): Use proper types.
	(get_width_string_n): Ditto.

	* src/number-match.c (gnumeric_error_init): Warning killer.

	* src/parser.y (deallocate_all): Warning killer.

	* src/item-bar.c (item_bar_draw): Avoid signedness problems.

	* src/format-template.c (hash_table_destroy): Warning killer.

	* src/colrow.h (struct _ColRowInfo): Make size_pixels an int.

	* src/value-sheet.c (value_area_get_width, value_area_get_height):
 	Return an int, not a guint.

2001-04-26  Morten Welinder  <terra@diku.dk>

	* fn-string.c (gnumeric_mid): Un-suckify.
	(gnumeric_find): Un-suckify.
	(gnumeric_substitute): Warning killer.
	(match_string): Warning killer.

	* fn-information.c (translate_cell_format): Warning killer.

	* fn-eng.c (val_to_base): Warning killer.

2001-04-30  Morten Welinder  <terra@diku.dk>

	* ms-summary.c (sum_name_to_excel): Fix index count.  Constify.
  	Make static.
	(excel_to_gnum_mapping): Make static.

2001-04-30  Almer S. Tigelaar  <almer@gnome.org>

	* src/commands.c (cmd_clear_selection): More descriptive
	descriptor.
	(cmd_format): Idem.
	(cmd_resize_colrow): Idem.
	(cmd_autofill): Idem.
	(cmd_autoformat): Idem.
	(cmd_unmerge_cells): Idem.
	(cmd_merge_cells): Idem.
	(cmd_colrow_std_size): Add "pts" to end of descriptor.
	(cmd_zoom): No need to re-assign gstring.
	(range_list_to_string): Convert a list of ranges to a
	string representation.

	* src/colrow.[ch] (colrow_index_list_to_string): Convert
	an index list to a string representation.
	(colrow_string_build): Utility routine for
	colrow_index_list_to_string.

2001-04-30  Almer S. Tigelaar  <almer@gnome.org>

	* src/parser.y (gnumeric_expr_parser) : Give a warning
	when both the resulting ExprTree and error message is non-null.
	This should never happen.

2001-04-29  Jody Goldberg <jgoldberg@home.com>

	* ms-excel-write.c (write_window2) : Headers are in default style.
	  And grid colour is auto, not black.

2001-04-29  Jody Goldberg <jgoldberg@home.com>

	* src/parser.y (yylex) : return INVALID_TOKEN rather than EOF when a
	  lexical error is found.

2001-04-29  Almer S. Tigelaar  <almer@gnome.org>

	* fn-information.c (gnumeric_cell): Implement remaining
	information types for the CELL function.
	(retrieve_format_info): A helper function for gnumeric_cell
	for gathering format characteristics.

2001-04-29  Almer S. Tigelaar  <almer@gnome.org>

	* src/commands.c (cmd_zoom) : Implement zoom undo/redo
	(cmd_zoom_destroy) : Idem.
	(cmd_zoom_redo): Idem.
	(cmd_zoom_undo): Idem.

	* src/workbook-control-gui.c (cb_change_zoom):
	Use cmd_zoom here.

intersections of double lines.  However, nothing significant.

2001-04-28  Jody Goldberg <jgoldberg@home.com>

	* src/style-border.c (print_hline) : handle offset of screen coords vs
	  printer coords.
	(print_vline) : ditto.
	(style_borders_row_print) : sync with style_borders_row_draw and pass
	  width to the line drawing to handle different coordinate types.

	* src/ranges.c (range_translate) : warn if clipped not just if
	  removed.

	* src/clipboard.c (clipboard_prepend_cell) : store the source sheet if
	  possible.
	(paste_link) : Use the right sheets.
	(clipboard_paste_region) : send enough information into paste_link.

2001-04-27  Jody Goldberg <jgoldberg@home.com>

	* src/format.c (pre_parse_format) : Catch fractions too.
	(render_number) : don't pass in so many copies of flags.  Just use the
	  info struct.  Add a 'has_fraction' flag to disable rounding.
	(do_render_number) : ditto.
	(stern_brocot) : simple stern brocot tree.  Should really use an
	  adaptive precision but I am lazy.
	(format_number) : add fractions.

	* src/commands.c (cmd_autofill_redo) : changing visiblity can triger a
	  draw which requiresthat things be rendered and spanned.  Be sure to
	  complete the action BEFORE changing visibility.