1. 05 Jun, 2000 1 commit
    • Jody Goldberg's avatar
      renamed from sheet_cell_formula_{link,unlink}. · 7f94ba9e
      Jody Goldberg authored
      
      2000-06-05  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_cell_expr_{link,unlink}) : renamed from
      	  sheet_cell_formula_{link,unlink}.
      
      	* src/cell.c (cell_relocate) : Doh! use the offset flags now that they
      	  are being passed.
      
      	* src/clipboard.c (paste_cell) : Renamed from paste_cell_flags.
      
      	* src/expr.c (compare) : value_is_empty_cell -> VALUE_IS_EMPTY.
      
      	* src/value.c (VALUE_IS_EMPTY) : rename from value_is_empty_cell.
      
      	* src/sheet-private.h : Add resize_scrollbar.
      
      	* src/sheet.c (sheet_{col,row}_add) : Use resize_scrollbar flag rather
      	  than manually updating the scrolling bar.
      	(sheet_update) : Handle resize_scrollbar.
      	(sheet_cell_expr_link) : renamed from sheet_cell_formula_link.
      	(sheet_cell_expr_unlink) : renamed from sheet_cell_formula_unlink.
      7f94ba9e
  2. 03 May, 2000 1 commit
    • Jody Goldberg's avatar
      Begin to rationalize support for inverted and 3D references. · de62dd3a
      Jody Goldberg authored
      More renaming and movement name rationalization.
      Some minor improvements in the function wizard.
      
      2000-05-03  Jody Goldberg <jgoldberg@home.com>
      
      	* EvalPosition -> EvalPos
      	  ParsePosition -> ParsePos
      	  new struct RangeRef used in ValueRange
      
      	  eval_pos_init* -> position.[ch]
      	  parse_pos_init*
      	  cell_ref_{get,make}*
      
      	* src/workbook.c : Reorder the toolbar a bit.
      	(workbook_foreach_cell_in_range) : New function.
      	(cb_autofunction) : New routine.
      	(workbook_set_auto_expr) : DO NOT put real code into pre/post
      	  conditions.  It will be removed when debugging is eventually
      	  disabled.
      
      	* src/position.c (range_ref_normalize) : New function.
      
      	* src/ranges.c (range_normalize) : New function.
      
      	* src/expr.c (expr_implicit_intersection) : Use range_ref_normalize.
      
      	* src/eval.c (cell_eval_content) : No need to release the value.
      	  cell_assign_value already does that.
      	(dependency_range_ctor) : Use range_normalize.
      
      	* src/auto-format.c (do_af_suggest) : Use workbook_foreach_cell_in_range.
      
      	* src/cell.c (cell_set_expr_and_value) : link the new expression but
      	  do not queue it for recalc.
      	(cell_assign_value) : Release the old value.
      	(cell_copy) : Init the value to empty.
      
      	* src/func.c (function_iterate_do_value) : Use
      	  workbook_foreach_cell_in_range.
      
      	* src/dialogs/dialog-function-wizard.c (create_description) : Use
      	  a label rather than a text entry widget.  It looks better.
      
      	* src/functions/fn-string.c (gnumeric_expression) : range is already
      	  absolute.
      
      	* src/functions/fn-stat.c (gnumeric_linest) : Handle inverted ranges.
      	(gnumeric_logest) : Ditto.
      
      	* src/functions/fn-information.c (gnumeric_countblank) : Use
      	workbook_foreach_cell_in_range.
      	(gnumeric_{row,column}) : Handle inversions.
      
      	* src/functions/fn-lookup.c (gnumeric_offset) : No need to make
      	  absolute.  The marshaller already did that.
      
      2000-05-02  Jody Goldberg <jgoldberg@home.com>
      
      	* src/eval.c (dependency_range_ctor) : normalize the range.
      
      	* src/xml-io.c (xml_write_cell_and_position) : Suppress warning.
      
      	* src/pixmaps.h : Add function wizard and equal sign.
      de62dd3a
  3. 29 Apr, 2000 1 commit
  4. 21 Apr, 2000 1 commit
    • Jody Goldberg's avatar
      Fix a few update issues on startup. · 22913301
      Jody Goldberg authored
      Optimize a bit to ensure that we do not rerender already rendered cells
      on startup.
      Make Value::type const in preparation for spliting the union.
      22913301
  5. 20 Apr, 2000 1 commit
    • Jody Goldberg's avatar
      Reorg cell contents and assignment. · bedb925b
      Jody Goldberg authored
      Fixs lots of usability details.
      
      2000-04-20  Jody Goldberg <jgoldberg@home.com>
      
      	* src/dialogs/dialog-cell-format.c : Use the edit_pos as the example
      	  not the top left corner.
      
      	* src/functions/fn-stat.c (gnumeric_ftest) : Use eval_pos_cellref
      	  to help localize the strangeness.
      	(gnumeric_ttest) : Ditto.
      
      	* src/xml-io.c (xml_write_cell_and_position) : If this is an array
      	  expression and we are the top left then add attributes to indicate
      	  size of array.  Ignore the rest of the array.
      	(xml_not_used_old_array_spec) : New routinr to handle the old array format.
      	(xml_cell_set_array_expr) : store an array.
      	(xml_read_cell) : Handle the old and the new array formats.
      
      	* src/workbook.c (workbook_close_if_user_permits) : Accept input
      	  first.
      	(wb_edit_key_pressed) : Handle array formulas here.
      	(workbook_detach_sheet) : Do not recalc all if we are exiting.
      	(workbook_start_editing_at_cursor) : When we start editing an
      	  array formula display just the formula not all the extra {}()[][] crap.
      
      	* src/sheet.c (SheetPrivate) : Add a recompute_spans flag.
      	(sheet_calc_spans) : New routine.
      	(sheet_cell_calc_span) : New routine.
      	(sheet_range_calc_spans) : Renamed and extended from
      	  sheet_cells_update.
      	(sheet_update) : Use sheet_calc_spans when necessary.
      	  Update the location region when the edit_pos changes.
      	(cb_recalc_spans_in_col) : Renamed from cb_collect_cells_in_col.
      	  Recalcs spans directly, no need to collect first.
      	(cb_set_cell_content) : New routine to set expr, or expr_and_value.
      	(sheet_range_set_text) : Use cb_set_cell_content, and remember
      	  chosen format with the cell rather than overriding the assigned
      	  format.
      	(sheet_cell_set_text) : Renamed from sheet_set_text.  Be more specific
      	  about how spans, rendering and the rest are handled.
      	(sheet_cell_set_expr) : New routine.
      	(sheet_cell_set_value) : Ditto.
      	(sheet_load_cell_val) : When displaying an array formula add {%s}()[][].
      	(sheet_redraw_cell_region) : Honour spans when redrawing.
      	(sheet_redraw_partial_row) : New routine.
      	(sheet_redraw_cell) : Ditto.
      	(sheet_is_cell_array) : Use cell_is_array.
      	(sheet_range_splits_array) : Renamed from sheet_check_for_partial_array.
      	(sheet_cell_add_to_hash) :  Do not touch spans at this point.
      	(sheet_cell_insert) : Rename from sheet_cell_add made recalc span
      	  optional.
      	(sheet_cell_new) : New routine that does not touch spans.
      	(sheet_cell_remove) : Made redraw optional.
      	(cb_clear_cell_comments) : Remove the cell if there is no comment.
      	(sheet_clear_region) : Remove the cell if there are no comments or
      	  contents.  Flag an update of the status region.
      
      	* src/sheet-view.c (cb_colrow_resize) : New function.
      	(sheet_view_col_size_changed) : Resize all rows, irrespective of
      	(sheet_view_row_size_changed) : existing cells.
      	(sheet_view_redraw_cell_region) : This no longer honours spans.
      
      	* src/sheet-style.c (sheet_style_attach) : Removed call to redraw.
      	sheet_cells_update : rename to sheet_range_calc_spans and move to
      	  sheet.c.
      
      	* src/sheet-autofill.c (autofill_cell) : Use sheet_cell_set_value
      	  rather than set_text.
      
      	* src/selection.c (sheet_selection_changed_hook) : Delete.
      	(sheet_selection_extend_to) : Update the status region to display the
      	  new size.
      	(sheet_selection_cut) : Use sheet_range_splits_array.
      	(selection_check_for_array) : New routine.
      
      	* src/parser.y : Remove icky array formula parsing that conflicted
      	  with array entries.
      
      	* src/number-match.c (format_match) : Return a Value * rather than a
      	  double.
      
      	* src/mstyle.c (mstyle_set_font_size) : Do not allow font sizes < 1.
      
      	* src/main.c (gnumeric_main) : Do NOT create an empty workbook
      	  then delete it if things are successfully loaded.  This causes
      	  a global recalc.  Instead add a flag to disable exit when the
      	  number of workbooks go to zero.  Then only enable the flag AFTER
      	  we have attempted to load the initial workbooks.
      
      	* src/item-grid.c (item_grid_event) : Update the status_region when
      	  button-1 is release.  It should display the edit_pos.
      
      	* src/gutils.c : Move cell_name, col_name, col_from_name,
      	  parse_cell_name, parse_cell_name_or_range and parse_cell_name_list,
      	  to parse-util.c.
      
      	* src/gnumeric.h  : Add RenderedValue.
      
      	* src/gnumeric-util.c (gnumeric_char_start_expr_p) : Move
      	  to parse-util.c
      
      	* src/file.c (workbook_read) : Remove freese thaw usage.
      	  Move call to update AFTER mark clean.
      
      	* src/expr.c (eval_pos_init) : Take a cellpos.
      	(parse_pos_evalpos) : New routine.
      	(eval_pos_cellref) : There is some questionable code scattered in the
      	  functions.  This routing localizes the odd bits for correction.
      
      	* src/eval.c (cell_eval_content) : Use sheet_redraw_cell,
      	  and rendered_value_calc_size.
      	(cell_get_dependencies) : Improve constness.
      
      	* src/corba-sheet.c : Remove the freeze thaw operations.
      	(Sheet_cell_set_formula) : Deleted.
      	(Sheet_range_set_formula) : Delete.
      
      	* src/commands.c : Adjust so that registration of command auto
      	  calls redo.  Add misc checks for splitting arrays.
      
      	* src/clipboard.h : Move the CellCopy types here from cell.h
      
      	* src/clipboard.c (paste_cell) : Use cell_has_expr.
      	  Don't insert the new cell till after its contents are assigned.
      
      	* src/cellspan.c (cell_register_span) : Improve constness.
      	(cell_unregister_span) : Ditto.
      	(row_cell_get_displayed_at) : Delete.
      	(cell_calc_span) : Moved here from cell.c
      
      	* src/dialogs/dialog-stf.glade : Adjust the header background colour
      	  to match the purdy new icon.  Add the icon.
      
      	* src/cell-draw.c : Use the rendered_value routines.
      	  Improve constness.
      
      	* src/analysis-tools.c (set_cell) : Use sheet_cell_fetch.
      
      	*.*
      	    cell_set_* -> sheet_cell_set_
      	    cell_set_*_simple -> cell_set_
      	    Cell::{row,col} -> Cell::{row,col}_info
      	    cell_get_text -> cell_get_entered_text
      	    cell_get_content -> cell_get_entered_text
      	    cell_name -> cell_coord_name
      	    cell_get_formatted_val -> cell_get_rendered_text
      	    cell_get_content -> cell_get_entered_text
      
      	* src/cell.c :
      	(cell_dirty) : Renamed from cell_modified.  Use
      	  sheet_set_dirty.
      	(cell_formula_changed) : Make the queuing of the recalc optional.
      	(cell_cleanout) : Handle union of expression and entered_text,
      	  and remove the rendered value.
      	(cell_copy) : Ditto.
      	(cell_destroy) : handle cell_modified -> cell_dirty.
      	(cell_set_text) : Use parse_text_value_or_expr and store the prefered
      	  format.
      	(cell_set_text_and_value) : New routine.
      	(cell_assign_value) : New routine.
      	(cell_set_value) : Support formats.
      	(cell_set_expr_and_value) : New routine.
      	(cell_set_expr_internal) : Split from cell_set_expr.
      	(cell_set_expr) : Divide to allow for not queuing a recalc.
      	(cell_set_array_formula) : Use cell_set_expr_internal.
      	(cell_is_array) : New utility.
      	(cell_is_partial_array) : New utility.
      	(cell_has_expr) : New utility.
      	(cell_render_value) : Use rendered_value_*.
      	Move all comment routines into cell-comment.[ch].
      
      	* idl/Gnumeric.idl : Remove cell_set_formula, and range_set_formula.
      	  These were identical to set_text.  Made Workbook embeddable.
      bedb925b
  6. 07 Apr, 2000 1 commit
    • Jody Goldberg's avatar
      Fix http://bugs.gnome.org/db/85/8506.html · 18e5debc
      Jody Goldberg authored
      Mixed mode references are evil.
      
      A bit of interface improvement for gtk-combo-text
      
      2000-04-06  Jody Goldberg <jgoldberg@home.com>
      
      	* src/functions/fn-string.c : Add func 'expression' to return text of
      	  formula.
      
      	* src/parser.y : It is illegal to write A1:Sheet2!A3.
      
      	* src/value.c (value_new_cellrange) : Take the eval pos so that we can
      	  correctly invert mixed mode references when necessary.
      
      	* src/expr.c (cell_ref_make_abs) : New routine.
      	(expr_relocate) : Handle changes in value_new_cellrange.
      	* src/func.c (function_marshal_arg) : Ditto.
      	* src/ranges.c (range_parse) : Ditto.
      
      	* src/corba-sheet.c (Sheet_cell_set_value) : No need to check these
      	  references.  They seem to be hard coded to be relative.
      
      	* src/functions/fn-lookup.c (gnumeric_offset) : Begin to handle
      	  relative references.
      
      	* src/sheet.c (cellref_get) : Simplify the logic a smidge.
      
      	* src/workbook.c (workbook_finish_editing) : Restore the edit area
      	  manually for now.  We may need to make the update flags finer grain.
      18e5debc
  7. 22 Feb, 2000 1 commit
  8. 10 Feb, 2000 1 commit
    • Jody Goldberg's avatar
      Remove inclusion of cell.h. Adjust includes to loosen things a bit more. · f6b62c13
      Jody Goldberg authored
      
      2000-02-10  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.h : Remove inclusion of cell.h.  Adjust includes to loosen
      	  things a bit more.
      
      	* src/colrow.h : Remove margin_a_pt margin_b_pt.  Margins are NOT
      	  scaled by resolution or zoom.
      	  Rename units -> size_pts and store as float rather than double.
      	  Rename pixels-> size_pixels
      	  hard_size -> use gboolean rather than a 1 element bitfield
      
      	* src/style.h : Move the typedefs from here.
      	* src/gnumeric.h : to here.
      
      	*.[ch] : Catch up with the renames and include changes.
      f6b62c13
  9. 06 Jan, 2000 1 commit
  10. 03 Jan, 2000 1 commit
    • Jody Goldberg's avatar
      paste_special is only disabled for cut not for standard actions. · 42bca65b
      Jody Goldberg authored
      
      2000-01-03  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook.c (workbook_new) : paste_special is only disabled for
      	  cut not for standard actions.
      
      	* src/value-sheet.c (value_is_error) : New routine to look up errors.
      	(gnumeric_error_init) : New routine.
      	(constants_init) : Used here.
      
      	* src/parser.y (yylex) : If a string begins with '#' it may be an
      	  explicit error string.
      
      	* src/xml-io.c (xml_write_style_border) : Write BORDER_NONE's too,
      	  this makes it possible to save and restore the NONEs that erase borders.
      42bca65b
  11. 26 Sep, 1999 1 commit
    • Miguel de Icaza's avatar
      Load content from bonobo objects here. (sheet_view_object_unrealize): Keep · 3b3fe4c9
      Miguel de Icaza authored
      1999-09-26  Miguel de Icaza  <miguel@gnu.org>
      
      	* src/sheet-object.c (sheet_button_release): Load content from
      	bonobo objects here.
      	(sheet_view_object_unrealize): Keep the bookkeeping of realized
      	objects in the GnomeCanvasItem destroy handler.
      
      	* src/sheet-object-bonobo.c (sheet_object_bonobo_load_from_file):
      	New base class for SheetObjectContainer and SheetObjectBonobo
      
      	* src/sheet-object-container.c: Redid for reusing the new
      	hierarchy SheetObjectBonobo hierarchy.
      
      1999-09-25  Miguel de Icaza  <miguel@gnu.org>
      
      	* src/sheet-object.c (create_object): handle
      	SHEET_MODE_CREATE_CANVAS_ITEM.
      
      	* src/sheet.h (Sheet::mode_data): new field to keep per-mode data
      	during the lifetime of the mode.
      
      	* src/sheet-object-item.c: New sheet-object type.  This one is
      	used for embedding Bonobo-based CanvasItems.
      3b3fe4c9
  12. 09 Sep, 1999 1 commit
  13. 02 Aug, 1999 2 commits
  14. 01 Aug, 1999 1 commit
    • Jody Goldberg's avatar
      (MW's hand-pathced version of Jody's changes.) · 8ec8acb1
      Jody Goldberg authored
      
      1999-08-01  Jody Goldberg  <jgoldberg@home.com>
      
      	* src/fn-date.c (get_serial_date): Constify.  Improve handling of
       	date_serial 0.
      	(gnumeric_networkdays): Add partial implementation.  (MW: turned
       	off.)
      
      	* src/eval.c (add_value_deps): Handle empty value.
      
      	* src/collect.c (callback_function_collect): Ignore empty values.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) : Support
      	<C-PgUp> <C-PgDown> moving through the sheets.
      
      	* src/Gnumeric.idl : Add VALUE_ERROR, VALUE_BOOLEAN, VALUE_EMPTY
      	in a few more places.
      
      	* src/corba-sheet.c : Ditto.
      
      	* src/value.c (value_new_empty): New function.
      	(value_dump, value_copy_to, value_get_as_bool,
       	value_get_as_string, value_get_as_int, value_get_as_float): Handle
       	empty value.
      8ec8acb1
  15. 28 Jul, 1999 1 commit
  16. 27 Jul, 1999 1 commit