1. 05 Jun, 2000 1 commit
    • Jody Goldberg's avatar
      renamed from sheet_cell_formula_{link,unlink}. · 7f94ba9e
      Jody Goldberg authored
      
      2000-06-05  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_cell_expr_{link,unlink}) : renamed from
      	  sheet_cell_formula_{link,unlink}.
      
      	* src/cell.c (cell_relocate) : Doh! use the offset flags now that they
      	  are being passed.
      
      	* src/clipboard.c (paste_cell) : Renamed from paste_cell_flags.
      
      	* src/expr.c (compare) : value_is_empty_cell -> VALUE_IS_EMPTY.
      
      	* src/value.c (VALUE_IS_EMPTY) : rename from value_is_empty_cell.
      
      	* src/sheet-private.h : Add resize_scrollbar.
      
      	* src/sheet.c (sheet_{col,row}_add) : Use resize_scrollbar flag rather
      	  than manually updating the scrolling bar.
      	(sheet_update) : Handle resize_scrollbar.
      	(sheet_cell_expr_link) : renamed from sheet_cell_formula_link.
      	(sheet_cell_expr_unlink) : renamed from sheet_cell_formula_unlink.
      7f94ba9e
  2. 22 May, 2000 1 commit
    • Jody Goldberg's avatar
      New files. · 77d84d6c
      Jody Goldberg authored
      
      2000-05-21  Jody Goldberg <jgoldberg@home.com>
      
      	* src/cmd-edit.[ch] : New files.
      
      	* src/workbook.c (cb_edit_select_*) : Use the cmd-edit utilities.
      	Make a 'select' sub menu of edit.
      
      	* src/sheet.c : Use the newly added CellPos in each Cell rather than
      	  mallocing a seperate struct.
      
      	* src/selection.c (sheet_select_all) : Move.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) : Make the
      	  selection commands accelerators.
      77d84d6c
  3. 20 May, 2000 1 commit
    • Jody Goldberg's avatar
      Fix a few Chema bugs. · 6166dda7
      Jody Goldberg authored
      The cursor border was not being resized when rows/cols were hidden.
      Cell contents were not being re-rendered/sized when the format was
          cleared.
      
      2000-05-19  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_update) : Update cursor positions when visibility
      	  changes.
      	(sheet_clear_region) : When clearing formats we need to update the
      	  spans and sizes of the contents.
      	(sheet_update_cursor_pos) : New function.
      	(sheet_row_col_visible) : changing the status of a row/col changes visibility.
      
      	* src/sheet-view.c (sheet_view_update_cursor_pos) : New function split
      	  out from sheet_view_set_zoom_factor.
      	(sheet_view_set_zoom_factor) : Use sheet_view_update_cursor_pos.
      6166dda7
  4. 15 May, 2000 1 commit
    • Jody Goldberg's avatar
      Fix typo breaking row/col ins/del breakage :-( · a5e04f49
      Jody Goldberg authored
      Make some minor improvements in status display for row/col selection.
      
      2000-05-14  Jody Goldberg <jgoldberg@home.com>
      
      	* src/commands.h : Reformat.
      
      	* src/commands.c (cmd_ins_del_row_col_{undo,redo}) : unant the
      	  selection when the topology changes.
      
      	* src/workbook.c (workbook_expr_relocate) : Fix typo.
      
      	* src/sheet-view.c (sheet_view_{col,row}_selection_changed) : Call
      	  sheet_update after a change.
      a5e04f49
  5. 24 Apr, 2000 1 commit
    • Jody Goldberg's avatar
      Rename ea_status -> selection_descriptor Moved ea_entry here and called it · c2687829
      Jody Goldberg authored
      
      2000-04-24  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook-private.h : Rename ea_status -> selection_descriptor
      	Moved ea_entry here and called it edit_line.
      	* src/workbook.c (workbook_get_entry) : new routine.
      
      	* src/dialogs/function-select.glade : Made this a dialog, not a popup.
      
      	* src/summary.c (summary_item_free) : format police.
      	* src/value-sheet.c (value_area_foreach) : Ditto.
      
      	* src/sheet.c (sheet_new) : Init the update flags to FALSE, rather
      	  than TRUE now that the system seems to be getting their initial
      	  state correct when importing, paging and the like.
      	(sheet_load_cell_val) : Use workbook_get_entry.
      	(sheet_find_boundary_horizontal) : format police.
      	(sheet_find_boundary_vertical) : Ditto.
      	(sheet_range_splits_array) : Ditto.
      	(sheet_delete_{cols,rows}) : Ditto.
      	(sheet_restore_row_col_sizes) : Ditto.
      	(sheet_col_get_distance_{pixels,pts}) : Ditto.
      	(sheet_row_get_distance_pixels) : Ditto.
      	(sheet_row_get_distance_pts) : Ditto, Init accumulator.
      
      	* src/selection.c (sheet_selection_set) : format police.
      	(selection_check_for_array) : Ditto.
      	(sheet_selection_walk_step) : Ditto.
      	* src/sheet-view.c (horizontal_scroll_event) : Ditto.
      	(vertical_scroll_event) : Ditto.
      	* src/dialogs/dialog-cell-format.c : Ditto.
      	* src/dialogs/dialog-printer.c : Ditto.
      	* src/dialogs/dialog-workbook-attr.c : Ditto.
      	* src/functions/fn-eng.c : Ditto.
      	* src/functions/fn-lookup.c : Ditto.
      	* src/functions/fn-string.c : Ditto.
      
      	* src/pattern.c (gnumeric_sheet_patterns) : Add a few patterns for
      	  applix.  More are needed, and these are not available in the format
      	  dialog yet.
      
      	* src/number-match.c (compute_value) : Use g_strtod.
      	(format_match) : Ditto.
      
      	* src/item-edit.c : Use workbook_get_entry.
      
      	* src/item-bar.c (item_bar_event) : format police.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) : Do not set
      	  the focus directly.  Leave that to workbook_start_editing.
      	(gnumeric_sheet_new) : Use workbook_get_entry.
      
      	* src/format.c (render_number) : format police.
      
      	* src/complex.c (complex_from_string) : Use g_strtod.
      	* src/functions/fn-database.c : Ditto.
      
      	* src/colrow.c (cb_row_col_visibility) : format police.
      
      	* src/main.c (gnumeric_main) : Move the workbook_style_test to the
      	  empty case.
      
      	* src/mstyle.c (mstyle_set_pattern) : Add some safety.
      
      	* src/number-match.c (format_match) : Handle empties.
      c2687829
  6. 20 Apr, 2000 1 commit
    • Jody Goldberg's avatar
      Reorg cell contents and assignment. · bedb925b
      Jody Goldberg authored
      Fixs lots of usability details.
      
      2000-04-20  Jody Goldberg <jgoldberg@home.com>
      
      	* src/dialogs/dialog-cell-format.c : Use the edit_pos as the example
      	  not the top left corner.
      
      	* src/functions/fn-stat.c (gnumeric_ftest) : Use eval_pos_cellref
      	  to help localize the strangeness.
      	(gnumeric_ttest) : Ditto.
      
      	* src/xml-io.c (xml_write_cell_and_position) : If this is an array
      	  expression and we are the top left then add attributes to indicate
      	  size of array.  Ignore the rest of the array.
      	(xml_not_used_old_array_spec) : New routinr to handle the old array format.
      	(xml_cell_set_array_expr) : store an array.
      	(xml_read_cell) : Handle the old and the new array formats.
      
      	* src/workbook.c (workbook_close_if_user_permits) : Accept input
      	  first.
      	(wb_edit_key_pressed) : Handle array formulas here.
      	(workbook_detach_sheet) : Do not recalc all if we are exiting.
      	(workbook_start_editing_at_cursor) : When we start editing an
      	  array formula display just the formula not all the extra {}()[][] crap.
      
      	* src/sheet.c (SheetPrivate) : Add a recompute_spans flag.
      	(sheet_calc_spans) : New routine.
      	(sheet_cell_calc_span) : New routine.
      	(sheet_range_calc_spans) : Renamed and extended from
      	  sheet_cells_update.
      	(sheet_update) : Use sheet_calc_spans when necessary.
      	  Update the location region when the edit_pos changes.
      	(cb_recalc_spans_in_col) : Renamed from cb_collect_cells_in_col.
      	  Recalcs spans directly, no need to collect first.
      	(cb_set_cell_content) : New routine to set expr, or expr_and_value.
      	(sheet_range_set_text) : Use cb_set_cell_content, and remember
      	  chosen format with the cell rather than overriding the assigned
      	  format.
      	(sheet_cell_set_text) : Renamed from sheet_set_text.  Be more specific
      	  about how spans, rendering and the rest are handled.
      	(sheet_cell_set_expr) : New routine.
      	(sheet_cell_set_value) : Ditto.
      	(sheet_load_cell_val) : When displaying an array formula add {%s}()[][].
      	(sheet_redraw_cell_region) : Honour spans when redrawing.
      	(sheet_redraw_partial_row) : New routine.
      	(sheet_redraw_cell) : Ditto.
      	(sheet_is_cell_array) : Use cell_is_array.
      	(sheet_range_splits_array) : Renamed from sheet_check_for_partial_array.
      	(sheet_cell_add_to_hash) :  Do not touch spans at this point.
      	(sheet_cell_insert) : Rename from sheet_cell_add made recalc span
      	  optional.
      	(sheet_cell_new) : New routine that does not touch spans.
      	(sheet_cell_remove) : Made redraw optional.
      	(cb_clear_cell_comments) : Remove the cell if there is no comment.
      	(sheet_clear_region) : Remove the cell if there are no comments or
      	  contents.  Flag an update of the status region.
      
      	* src/sheet-view.c (cb_colrow_resize) : New function.
      	(sheet_view_col_size_changed) : Resize all rows, irrespective of
      	(sheet_view_row_size_changed) : existing cells.
      	(sheet_view_redraw_cell_region) : This no longer honours spans.
      
      	* src/sheet-style.c (sheet_style_attach) : Removed call to redraw.
      	sheet_cells_update : rename to sheet_range_calc_spans and move to
      	  sheet.c.
      
      	* src/sheet-autofill.c (autofill_cell) : Use sheet_cell_set_value
      	  rather than set_text.
      
      	* src/selection.c (sheet_selection_changed_hook) : Delete.
      	(sheet_selection_extend_to) : Update the status region to display the
      	  new size.
      	(sheet_selection_cut) : Use sheet_range_splits_array.
      	(selection_check_for_array) : New routine.
      
      	* src/parser.y : Remove icky array formula parsing that conflicted
      	  with array entries.
      
      	* src/number-match.c (format_match) : Return a Value * rather than a
      	  double.
      
      	* src/mstyle.c (mstyle_set_font_size) : Do not allow font sizes < 1.
      
      	* src/main.c (gnumeric_main) : Do NOT create an empty workbook
      	  then delete it if things are successfully loaded.  This causes
      	  a global recalc.  Instead add a flag to disable exit when the
      	  number of workbooks go to zero.  Then only enable the flag AFTER
      	  we have attempted to load the initial workbooks.
      
      	* src/item-grid.c (item_grid_event) : Update the status_region when
      	  button-1 is release.  It should display the edit_pos.
      
      	* src/gutils.c : Move cell_name, col_name, col_from_name,
      	  parse_cell_name, parse_cell_name_or_range and parse_cell_name_list,
      	  to parse-util.c.
      
      	* src/gnumeric.h  : Add RenderedValue.
      
      	* src/gnumeric-util.c (gnumeric_char_start_expr_p) : Move
      	  to parse-util.c
      
      	* src/file.c (workbook_read) : Remove freese thaw usage.
      	  Move call to update AFTER mark clean.
      
      	* src/expr.c (eval_pos_init) : Take a cellpos.
      	(parse_pos_evalpos) : New routine.
      	(eval_pos_cellref) : There is some questionable code scattered in the
      	  functions.  This routing localizes the odd bits for correction.
      
      	* src/eval.c (cell_eval_content) : Use sheet_redraw_cell,
      	  and rendered_value_calc_size.
      	(cell_get_dependencies) : Improve constness.
      
      	* src/corba-sheet.c : Remove the freeze thaw operations.
      	(Sheet_cell_set_formula) : Deleted.
      	(Sheet_range_set_formula) : Delete.
      
      	* src/commands.c : Adjust so that registration of command auto
      	  calls redo.  Add misc checks for splitting arrays.
      
      	* src/clipboard.h : Move the CellCopy types here from cell.h
      
      	* src/clipboard.c (paste_cell) : Use cell_has_expr.
      	  Don't insert the new cell till after its contents are assigned.
      
      	* src/cellspan.c (cell_register_span) : Improve constness.
      	(cell_unregister_span) : Ditto.
      	(row_cell_get_displayed_at) : Delete.
      	(cell_calc_span) : Moved here from cell.c
      
      	* src/dialogs/dialog-stf.glade : Adjust the header background colour
      	  to match the purdy new icon.  Add the icon.
      
      	* src/cell-draw.c : Use the rendered_value routines.
      	  Improve constness.
      
      	* src/analysis-tools.c (set_cell) : Use sheet_cell_fetch.
      
      	*.*
      	    cell_set_* -> sheet_cell_set_
      	    cell_set_*_simple -> cell_set_
      	    Cell::{row,col} -> Cell::{row,col}_info
      	    cell_get_text -> cell_get_entered_text
      	    cell_get_content -> cell_get_entered_text
      	    cell_name -> cell_coord_name
      	    cell_get_formatted_val -> cell_get_rendered_text
      	    cell_get_content -> cell_get_entered_text
      
      	* src/cell.c :
      	(cell_dirty) : Renamed from cell_modified.  Use
      	  sheet_set_dirty.
      	(cell_formula_changed) : Make the queuing of the recalc optional.
      	(cell_cleanout) : Handle union of expression and entered_text,
      	  and remove the rendered value.
      	(cell_copy) : Ditto.
      	(cell_destroy) : handle cell_modified -> cell_dirty.
      	(cell_set_text) : Use parse_text_value_or_expr and store the prefered
      	  format.
      	(cell_set_text_and_value) : New routine.
      	(cell_assign_value) : New routine.
      	(cell_set_value) : Support formats.
      	(cell_set_expr_and_value) : New routine.
      	(cell_set_expr_internal) : Split from cell_set_expr.
      	(cell_set_expr) : Divide to allow for not queuing a recalc.
      	(cell_set_array_formula) : Use cell_set_expr_internal.
      	(cell_is_array) : New utility.
      	(cell_is_partial_array) : New utility.
      	(cell_has_expr) : New utility.
      	(cell_render_value) : Use rendered_value_*.
      	Move all comment routines into cell-comment.[ch].
      
      	* idl/Gnumeric.idl : Remove cell_set_formula, and range_set_formula.
      	  These were identical to set_text.  Made Workbook embeddable.
      bedb925b
  7. 11 Apr, 2000 1 commit
    • Jody Goldberg's avatar
      Force clean after post load recalc. · 94d91805
      Jody Goldberg authored
      
      2000-04-10  Jody Goldberg <jgoldberg@home.com>
      
      	* src/file.c (workbook_read) : Force clean after post load recalc.
      
      	* src/sheet-view.c (sheet_view_col_selection_changed) : keep the
      	  moving col visible.
      	(sheet_view_row_selection_changed) : Keep the moving row visible.
      
      	* src/item-grid.c (item_grid_find_col) : Tune iteration bounds to
      	  improve speed and allow for scrolling back to the first col/row.
      
      	* src/item-cursor.c (item_cursor_autofill_event) : Pass the coords of
      	  the cell we want to keep visible rather than the top left corner.
      	(item_cursor_set_bounds_visibly) : Rename the parameters to reflect
      	  their real purpose.
      94d91805
  8. 10 Apr, 2000 1 commit
    • Miguel de Icaza's avatar
      Do not destroy the context here, as it is dereferenced later in the · 30aba440
      Miguel de Icaza authored
      
      
      2000-04-07  Miguel de Icaza  <miguel@gnu.org>
      
      	* main.c (button_cancel): Do not destroy the context here, as it
      	is dereferenced later in the mainloop.
      
      2000-04-10  Miguel de Icaza  <miguel@gnu.org>
      
      	* Lots of files: replaces utils.h for gutils.h
      
      	* renamed utils.h to gutils.h to avoid the compilation problem on
      	some Unices (yes, fixing the Makefile would have done it, but
      	utils.h was still a lame name;  Of course gutils.h is not any
      	better, but it is now done).
      
      2000-04-07  Miguel de Icaza  <miguel@gnu.org>
      
      	* src/cellspan.c (span_remove): Pretify code.
      30aba440
  9. 09 Apr, 2000 2 commits
  10. 04 Apr, 2000 1 commit
    • Jon K Hellan's avatar
      Call gnumeric_sheet_make_visible only if sheet widget is realized. · affafc8a
      Jon K Hellan authored
      2000-04-04  Jon K Hellan  <hellan@acm.org>
      
      	* src/sheet-view.c (sheet_view_set_zoom_factor): Call
      	gnumeric_sheet_make_visible only if sheet widget is realized.
      	(sheet_view_make_edit_pos_visible): New function: Make cell at
      	edit position visible.
      	(sheet_view_size_allocate): Add call to
      	sheet_view_make_edit_pos_visible.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_make_cell_visible): Add
      	comment.
      
      	* src/xml-io.c (xml_sheet_read): Read zoom into a local variable
      	before calling sheet_set_zoom_factor. Otherwise,
      	sheet_set_zoom_factor would assume that it had already initialized
      	this factor.
      
      	* src/workbook.c (change_zoom_in_current_sheet_cb): No longer call
      	change_displayed_zoom_cb, sheet_set_zoom_factor will call it
      	indirectly.
      
      	* src/workbook.[ch] (workbook_class_init,
      	workbook_focus_current_sheet, workbook_create_standard_toobar):
      	Rename "sheet_changed" signal to "sheet_entered".  Remove
      	"cell_changed" signal.
      	(workbook_focus_current_sheet): Rename "sheet_changed" signal to
      	"sheet_entered".
      	(workbook_zoom_feedback_set): New function: Update zoom combo in
      	toolbar when zoom changes.
      
      	* src/sheet.c (sheet_update_zoom_controls): New function: Update
      	zoom controls when zoom changes.
      	(sheet_set_zoom_factor): Use it.
      	(sheet_load_cell_val): Do not emit "cell_changed".
      
      	* src/dialogs/dialog-cell-format.c (cb_fmt_dialog_dialog_apply):
      	Call sheet_update_controls to update toolbar controls.
      
      	* src/history.c (file_history_cmd): Remove pristine workbook when
      	a new one is read in. For consistency with File/Open, File/Import
      	and Bonobo File/History.
      
      	* src/dialogs/dialog-workbook-attr.c
      	(cb_attr_dialog_dialog_apply): Include workbook-view.h to get
      	prototype for workbook_view_pref_visibility.
      
      	* src/border.h (style_border_print): Remove bogus const in  prototype.
      	Reported by Aron Griffis.
      affafc8a
  11. 01 Apr, 2000 1 commit
    • Jody Goldberg's avatar
      Fix the silly edit bug tha was being reported. · fce11703
      Jody Goldberg authored
      Some major work on item-edit.
      
      2000-03-31  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook.c : Switch over to useing GNOMEUIINFO_ITEM_ where
      	  possible.
      	(cb_editline_focus_in) : Do not start editing if we are already
      	  editing.
      
      	* src/utils.c (parse_cell_name) : constness.
      
      	* src/style.c (style_font_gdk_font) : constness.
      	(style_font_gdk_font) : ditto.
      	(style_font_gnome_font) : ditto.
      	(style_font_get_height) : ditto.
      
      	* src/sheet.c (sheet_set_zoom_factor) : redimension all cells, rather
      	  than the sparse sheet region.  Do not auto-resize.
      	(sheet_cell_add) :  Adjust to new calling convention for
      	  cell_calc_dimensions.
      	(sheet_stop_editing) : Rename from sheet_destroy_edit_cursor.
      
      	* src/sheet-view.c (sheet_view_get_style_font) : constness.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_create_editing_cursor) :
      	  No need to set all those arguments.
      	(destroy_item_editor) : Merge into gnumeric_sheet_stop_editing.
      	(gnumeric_sheet_stop_editing) : Renamed from
      	  gnumeric_sheet_destroy_editing_cursor.
      
      	* src/cell.[ch] (cell_set_rendered_text) : Adjust to new calling
      	  convention for cell_calc_dimensions.
      	(cell_calc_dimensions) : Adjust calling convetion to make auto
      	  resizing optional.
      	(calc_text_dimensions) : Adjust calling convention to directly set size.
      
      	* src/sheet-style.c (re_dimension_cells_cb) :  Adjust to new calling
      	  convention for cell_calc_dimensions.
      
      	* src/item-edit.c : Major rework to behave better at margins,
      	  correctly handle cells whose display contents span differently than
      	  their displayed values, multi-line display mechanics, and a blinking
      	  cursor :-)
      fce11703
  12. 22 Mar, 2000 2 commits
    • Jody Goldberg's avatar
      Fix some typos. · 10e9a53e
      Jody Goldberg authored
      2000-03-22  Jody Goldberg <jgoldberg@home.com>
      
      	* src/plugin.c (plugin_load) : Typo.
      
      	* src/workbook.c (recalc_cmd) : Bug7739.
      10e9a53e
    • Jody Goldberg's avatar
      Fix span bugs. · 99ec14fe
      Jody Goldberg authored
      2000-03-22  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_reposition_comments) : Merged from
      	  sheet_reposition_comments_from_row and
      	  sheet_reposition_comments_from_col.
      
      	(sheet_update) : New function.  Use the new update flags from
      	  SheetPrivate that are set in the col/row resize functions
      	  to do delayed resizing and updates.  This allows the resizing to be
      	  batched for an entire logical operation.
      	(sheet_{col,row}_set_size_pixels) : Set the update flags.
      
      	* src/workbook-cmd-format.c (workbook_cmd_format_{row,column}_auto_fit) : No need to
      	  worry about redraws.  Use sheet_update.
      	(workbook_cmd_format_{row_height,column_width}) : Ditto.
      
      	* src/sheet-view.c (sheet_view_redraw_cell_region) : No need to
      	  recalculate the spans,  Use the pre-calculated versions.
      	(sheet_view_col_size_changed) : Use sheet_update.
      	(sheet_view_row_size_changed) : Ditto.
      
      	* src/sheet-style.c (re_dimension_cells_cb) : Use cell_calc_dimensions.
      	(sheet_cells_update) : No need to redraw per cell and guess the bound.
      	  It is simpler and more correct to calc dimension per cell, and
      	  redraw the region BEFORE and AFTER to handle spans.
      
      	* src/cell.[ch] (cell_style_changed) : Delete.
      
      	* src/cell-draw.c (cell_draw) : continue syncing with print code.
      	  Be even more careful in the possible presence of style bugs.
      	* src/item-grid.c (item_grid_draw) : Ditto.
      	* src/print-cell.c (print_cell) : Ditto.
      
      	* src/analysis-tools.c (correlation_tool) : Use sheet_update.
      	(covariance_tool) : Ditto.
      	(ttest_paired_tool) : Ditto.
      	(ttest_eq_var_tool) : Ditto.
      	(ttest_neq_var_tool) : Ditto.
      	(ftest_tool) : Ditto.
      
      2000-03-21  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet-private.h : Add status flags to accumulate state changes
      	  for later redraw.
      
      	* src/commands.c (cmd_format_redo) : Use sheet_update
      	  in case the row/col sizes changed due to font size changes.
      	(cmd_format_undo) : Ditto.
      
      	* src/widgets/gtk-combo-box.c (cb_state_change) : Only pseudo-prelight
      	  the display when over the arrow, not vice versa.
      	(gtk_combo_box_init) : Ditto.
      	(gtk_combo_box_set_display) : Ditto.
      
      	* src/sheet.c (sheet_row_get_distance_pts) : Enable reversed indicies.
      	(sheet_col_get_distance_pts) : Ditto.
      
      	* src/plugin.c (plugin_load) : Add more version checking to ensure
      	  that very old plugins that do not check their versions can not be
      	  loaded.
      
      2000-03-20  Jody Goldberg <jgoldberg@home.com>
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_make_cell_visible) : When
      	  forcing a scroll do a hard reset of the visible ranges.
      	(gnumeric_sheet_compute_visible_ranges) : Ditto.
      	(gnumeric_sheet_set_top_row) : Remove extraneous scroll.
      	(gnumeric_sheet_set_left_col) : Remove extraneous scroll.
      99ec14fe
  13. 05 Mar, 2000 1 commit
    • Jody Goldberg's avatar
      - Strike through - initial format dialog support for underline and · 7f8319da
      Jody Goldberg authored
      - Strike through
      - initial format dialog support for underline and strikethrough.
      - Printing of underlines and strikethroughs.
      
      2000-03-05  Jody Goldberg <jgoldberg@home.com>
      
      	* src/dialogs/dialog-cell-format.c : Enable the underline and
      	  strikethrough elements. TODO : redo the preview for the font
      	  tab to support underlining and friends.
      
      	* src/dialogs/cell-format.glade : Rename the underline combo and
      	  strikethrough button.
      
      	* src/xml-io.c (xml_write_style) : Add strikethrough.
      	(xml_read_style) : Ditto.
      
      	* src/workbook-format-toolbar.c (workbook_feedback_set) : Only show
      	  the underline button for single underlines.
      
      	* src/sheet-view.[ch] : rename select_all -> select_all_btn.
      	  remove unused element.
      
      	* src/sheet-object.h : Remove silly self inclusion.
      
      	* src/print-cell.c : Support underlining and strikethrough.
      	  Move even closer into sync with drawing code.
      
      	* src/mstyle.c : Add strikethrough and cleanup includes.
      
      	* src/main.h : Add include for popt.h.
      
      	* src/item-grid.c (item_grid_draw_border) : No more need for BOTTOM or
      	  RIGHT.
      	(item_grid_draw_cell) : Delete, and merge with draw_cell.
      
      	* src/commands.c (cmd_set_text_undo) : Use cursor_set rather than
      	  cursor_move.
      	* src/corba-sheet.c (Sheet_cursor_move) : Ditto.
      	(gnumeric_sheet_key_mode_sheet) : Ditto.
      	* src/workbook.c (workbook_parse_and_jump) : Ditto.
      
      	* src/cell-draw.c : Clean includes, add support for strikethrough.
      7f8319da
  14. 28 Feb, 2000 2 commits
    • Jody Goldberg's avatar
      - Select All and ctrl-A should be the same. · 11252b02
      Jody Goldberg authored
      - cursor movement should accept pending input.
      11252b02
    • Jody Goldberg's avatar
      Improve the handling of backgrounds and selection in the presence of · bb5371b7
      Jody Goldberg authored
      
      Improve the handling of backgrounds and selection
      in the presence of spanning columns.
      
      Improve borders.  Somewhat more correct handling of double lined borders.
      Still mostly wrong, but its a start.
      
      2000-02-28  Jody Goldberg <jgoldberg@home.com>
      
      	* src/expr.h : Move FunctionDefinition to
      	* src/gnumeric.h : here.
      
      	* src/cellspan.c (col_hash) : Use GPOINTER_TO_INT.
      	(col_compare) : Ditto.
      	(row_init_span) : Delete.
      	(free_hash_value) : Renamed from free_hash_key.
      	(cell_register_span) : Register all cells in a span, malloc a
      	  CellSpanInfo to store a descriptor about the first and last cols.
      	(assemble_unregister_span_list) : Delete.
      	(span_remove) : New function for use by g_hash_table_foreach_remove.
      	(cell_unregister_span) : Use g_hash_table_foreach_remove.
      	(row_cell_get_displayed_at) : Adjust to new descriptor.
      	(row_span_get) : New function.
      
      	* src/cell.c (cell_calculate_span) : Renamed from cell_get_span.
      
      	* src/cell-draw.c (cell_draw) : Do not draw backgrounds here.
      	  Use new CellSpanInfo to avoid recomputing spans every time.
      	(cell_is_blank) : Remove hack about treating empty strings as empty.
      
      	* src/cellspan.h : New file.  Move span decls here.
      
      	* src/item-grid.c (item_grid_draw) : Rework to correctly handle
      	  backgrounds and borders for spanning columns.
      
      2000-02-27  Jody Goldberg <jgoldberg@home.com>
      
      	* src/cell.c (cell_is_blank) : Update.
      
      	* src/border.c (style_border_draw) : Make somewhat more correct.
      	  Still broken for non-top-left corners.
      
      	* src/item-grid.c (item_grid_draw_border) : Ditto.
      	(item_grid_draw_background) : Rename from item_grid_paint_empty_cell
      	  handle spans more cleanly.
      	(item_grid_draw_cell) : handle conditionals for displaying contents here.
      	  Remove all handling of backgrounds.
      bb5371b7
  15. 22 Feb, 2000 1 commit
    • Jody Goldberg's avatar
      Some border improvements. · e18beddb
      Jody Goldberg authored
      - Use DASH_ON_OFF to correctly handle borders for cells with a background
        colour.
      
      - Prefer Top/Left vs Bottom/Right.  This works around problems with borders
        for cells with backgrounds..  BUT does not solve it for importing.  That
        will require the next generation border code that has yet to be designed.
      
      - A crappy implementation of double borders.  Does NOT handle cells with
        backgrounds, or the myriad intersection cases.
      
      - Improve handling of undo and redraw for borders.
      
      2000-02-21  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_cursor_set) : Be religous about handing edit_pos
      	  changes.
      
      	* src/commands.c (cmd_format) : save for formats for a range 1 cell
      	  thick around the selection so that borders are handled.
      
      	* src/sheet-view.c (sheet_view_redraw_cell_region) : Redraw a border
      	  around the selected region to handle thick borders */
      
      	* src/sheet-object.c (sheet_object_canvas_event) : Ignore mouse wheel
      	  events.
      
      	* src/border.c (style_border_set_gc_dash) : Use GDK_LINE_ON_OFF_DASH
      	  so that background colours show through.
      
      	* src/sheet-style.c (sheet_range_set_border) : Prefer top vs bottom
      	  and left vs right.  This will simplify drawing eventually.
      e18beddb
  16. 20 Feb, 2000 1 commit
    • Jody Goldberg's avatar
      - Switch the item-cursor over to a delayed update model in an attempt to · 3d3ec8bf
      Jody Goldberg authored
        fix a redraw bug.  Things are faster but not fixed.
      
      - Fix the real problem.  More cleanup of the cursor/selection code is required.
        There is too much incest in there.  We are redoing 75% of the necessary operations
        at several level in an attempt to get all the requisite pieces.
      
      2000-02-20  Jody Goldberg <jgoldberg@home.com>
      
      	* src/item-cursor.c : Switch to a quartic approved delayed update
      	  model.  Do not change the bounding box while drawing.
      
      	* src/selection.c (sheet_selection_add_range) : Do NOT directly change
      	  the edit/move/base characteristics of the sheet sheet_cursor_set handles
      	  that.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_compute_visible_ranges) : Use
      	  item_cursor_reposition rather than pretending that the cursor moved.
      
      	* src/item-grid.c (item_grid_button_1) : Don't call both
      	  sheet_cursor_move and sheet_selection_add.  The former was moving
      	  the edit cursor without redrawing it.
      3d3ec8bf
  17. 18 Feb, 2000 1 commit
    • Jody Goldberg's avatar
      - Merge some enhancements to the color combo boxes. · 771be446
      Jody Goldberg authored
      - Simplify and enhance the cursor and selection code.
        Its not as pretty as I'd like, but its getting better.
      - Fix a display glitch in the item-bar.  canvas redraw excludes
        the far coordinate.  That will teach me to read docs.
      
      2000-02-18  Jody Goldberg <jgoldberg@home.com>
      
      	* src/widgets/widget-color-combo.c (color_combo_construct) : typo.
      	(color_combo_new) : Disable the charting colours for now.  They are
      	  mostly duplicates.
      
      2000-02-16 Dom Lachowicz <dominicl@seas.upenn.edu>
      
      	* src/widgets/widget-color-combo.[ch]
      	Changed the code some to enable tooltips
      	Minor api changes
      
      2000-02-18  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook-view.c : Add history.h.
      
      2000-02-18  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_redraw_selection) : Delete.
      
      	* src/selection.c (sheet_selection_extend_to) : Short circuit when
      	  there would be no change to the selection.
      	(sheet_selection_change) : The sheet already has the correct edit,
      	  move, base positions.  Use them.
      
      	* src/sheet-view.c (sheet_view_redraw_headers) : gnome_canvas_request_redraw
      	  EXCLUDES the far coordinates.  Add 1 so that the last pixel get
      	  redrawn too.
      
      2000-02-18  Jody Goldberg <jgoldberg@home.com>
      
      	* src/history.c (history_menu_item_create) : typo.
      
      2000-02-18  Jody Goldberg <jgoldberg@home.com>
      
      	* src/dialogs/dialog-goal-seek.c (dialog_goal_seek) : Use edit_pos.
      	* src/dialogs/dialog-solver.c (dialog_solver) : Ditto.
      
      	* src/xml-io.c (xml_read_selection_info) : Use edit_pos.
      	(xml_write_selection_info) : Ditto.
      
      	* src/workbook.c (cb_sheet_check_dirty) : Use edit_pos.
      	(paste_cmd) : Ditto.
      	(paste_special_cmd) : Ditto.
      	(insert_current_date_cmd) : Ditto.
      	(insert_current_time_cmd) : Ditto.
      	(workbook_edit_comment) : Ditto.
      
      	* src/sheet.c (sheet_new) : sheet_selection_append -> sheet_selection_add.
      	(sheet_accept_pending_input) : Use edit_pos.
      	(sheet_load_cell_val) : Ditto.
      	(sheet_start_editing_at_cursor) : Ditto.
      	(sheet_update_controls) : Ditto.
      	(sheet_{col,row}_selection_type) : Fix cut-paste-o.
      	(walk_boundaries) : Move to selection.c.
      	(walk_boundaries_wrapped) : Ditto.
      	(sheet_selection_walk_step) : Reworked and moved to selection.c.
      	(sheet_cursor_move) : Switch to new framework.
      	(sheet_cursor_set) : Ditto.
      	(sheet_set_selection) : Delete.
      
      	* src/sheet.h : (SheetSlection) : Remove base member.
      	(Sheet) : adjsut notion of cursor to differentiate between,
      	edit, base, and movement.  (see comments).
      	* src/sheet-view.c (sheet_view_set_zoom_factor) : Use edit_pos.
      	(sheet_view_scrollbar_config) : Switch to new scheme.
      	(sheet_view_{col,row}_selection_changed) : Make the Top/Left visible
      	  cell the edit cursor when things are out of range.
      
      	* src/sheet-style.c (sheet_style_attach) : Use sheet_redraw_range directly.
      	(sheet_range_apply_style) : Ditto.
      	(sheet_range_set_border) : Ditto.
      
      	* src/selection.c (sheet_selection_add_range) : Renamed from,
      	  sheet_selection_append.  Document.  Switch to new edit, base, move
      	  scheme.  Directly call sheet_cursor_set rather than the confusingly
      	  named sheet_set_selection.
      	(sheet_selection_add) : Renamed from sheet_selection_append.
      	(sheet_selection_change) : Adjsut parm name from 'new' -> 'new_sel' to
      	  enable test compiles from C++.
      	(sheet_selection_extend_to) : Switch to new edit, base, move scheme.
      	(sheet_selection_extend) : Just call sheet_selection_extend_to for the
      	  main work.  Document.
      	(sheet_select_all) : sheet_selection_append_range -> sheet_selection_add_range.
      	(sheet_selection_extend_{horizontal, vertical} : Merge in to
      	  sheet_seletion_extend and fix.
      	(sheet_selection_set) : Switch to the new scheme.
      	(sheet_selection_reset) : sheet_selection_append -> sheet_selection_add.
      	  Use edit_pos.
      	(walk_boundaries) : Moved from sheet.c, merged with
      	  walk_boundaries_wrap, and change signature.
      	(sheet_selection_walk_step) : Moved from sheet.c and switched to the
      	  new method.  Do not change the selected region while iterating.
      
      	* src/item-grid.c (item_grid_paint_empty_cell) : Use edit_pos.
      	(item_grid_draw_cell) : Ditto.
      	(item_grid_event) : Ditto.
      	(context_paste_cmd) : Use the base and move cursors.
      	(context_paste_special_cmd) : Ditto.
      	(item_grid_button_1) : sheet_selection_append -> sheet_selection_add.
      
      	* src/item-cursor.c (item_cursor_autofill_event) : Use
      	  sheet_selection_add_range rather than the two step select extend.
      
      	* src/clipboard.c (sheet_paste_selection) : Use
      	  sheet_selection_add_range rather than the 2 step process
      	  of setting the corner and extending.
      
      	* plugins/excel/ms-excel-read.c (ms_excel_read_selection) :
      	    sheet_selection_append_range -> sheet_selection_add_range
      	* src/corba-sheet.c (Sheet_selection_append) : Ditto.
      	(Sheet_selection_append_range) : Ditto.
      
      	* src/gnumeric-sheet.c (move_cursor) : Ditto.
      	(gnumeric_sheet_key_mode_sheet) : Ditto.  Use edit_pos.
                sheet_selection_walk_step now handles the cursor and selection
      	  changes.
      	(gnumeric_sheet_set_selection) : Delete this was unnecessary.
      	(gnumeric_sheet_set_cursor_bounds) : Add preconditions.
      	(move_cursor_horizontal) : Use the edit_pos for movement.
      	(move_cursor_vertical) : Ditto.
      	(gnumeric_sheet_create_editing_cursor) : Ditto.
      	(start_cell_selection) : Ditto.
      	(move_horizontal_selection) : Use sheet_selection_extend.
      	(move_vertical_selection) : Ditto.
      	(gnumeric_sheet_compute_visible_ranges) : Force a redraw of the
      	  item-cursor when the visible region changes.  FIXME : This should be
      	  an update not a redraw.
      771be446
  18. 13 Feb, 2000 1 commit
    • Jody Goldberg's avatar
      Major rationalization of pts vs pixels and the use of margins. · b6d04cff
      Jody Goldberg authored
      Some redraw speedups and the addition of XL2000 style alpha bended selections.
      
      2000-02-13  Jody Goldberg <jgoldberg@home.com>
      
      	* ./src/sheet-view.c (sheet_view_redraw_cell_region) : redraw the
      	  bounding grid lines too.
      
      	* src/item-cursor.c (item_cursor_get_pixel_coords) : Clip the cursor
      	  region to the visible range.  The layout still needs cleaning to
      	  match the 'correct' way of implementing canvas-items, but this
      	  heuristic saves us lots of iterations through the accumulator for
      	  the size of the entire sheet.
      
      2000-02-12  Jody Goldberg <jgoldberg@home.com>
      
      	* src/gnumeric-sheet.c : Use visible flag and adjust to naming and
      	  margin changes.
      
      	* src/item-bar.c (colrow_tip_setlabel) : Use the format provided by
      	  XL2000.  Things are correct for rows, colwidth are quoted in pts
      	  rather than char widths.
      	(get_col_from_pos) : Use visible flag.
      	(item_bar_start_resize) : Function renaming.
      	(is_pointer_on_division) : Ditto.
      	(item_bar_draw) : Changes to margins.
      
      	* src/item-edit.c : Function renaming.
      	* src/item-cursor.c : Ditto.  decrease spacing for auto handle.
      
      	* src/item-grid.c (item_grid_draw) : Remove inversion process for the
      	  selection.  Instead have the cells draw their background
      	  differently.  Use the visible flag.
      	(item_grid_paint_empty_cell) : Ditto.
      	(item_grid_paint_cell) : Ditto.
      
      	* src/mstyle.c (mstyle_new_default) : The default vert alignment is BOTTOM.
      
      	* src/pattern.c (gnumeric_background_set_gc) : Draw the background of
      	  a selected cell differently.
      
      	* src/print-cell.c (DIM) : margins are already included.
      	(print_cell_text) : Adjust argument order to more closely match
      	  cell_draw.  Add support for vertical alignment of 1 line cells.
      	  Invert control of single vs multiple lines.
      	(print_cell) : Adjust to changes in the arguments.
      	(print_cell_range) : Use the visible flag.
      	  Draw line at the boundary rather than pretending there were
      	  additional rows/cols.
      
      	* src/print.c (compute_groups) : size_pts INCLUDES margins.  Use 'visible' flag.
      	(print_page) : Adjust to function renaming.
      	(print_range_used_units) : Ditto.
      
      	* src/selection.c : Include sheet-view directly for now.
      	(cb_set_row_height) : Adjust to function renaming.
      
      	* src/sheet-view.c (sheet_view_redraw_cell_region) : Adjust to function
      	  renaming.
      	(sheet_view_redraw_headers) : Ditto.
      	(sheet_view_set_zoom_factor) : Ditto.
      	(sheet_view_col_size_changed) : Ditto.
      	(sheet_view_row_size_changed) : Ditto.
      	(sheet_view_comment_get_points) : Ditto.
      
      	* src/sheet.[ch] : Rationalize function names, and add glossary.
      	Make the use of margins and sizes (in points and pixels) consistant.
      
      	(sheet_col_get_external_width : Delete.
      	(sheet_row_get_external_height : Delete.
      	(sheet_col_get_distance : Rename sheet_col_get_distance_pixels.
      	(sheet_row_get_distance : Rename sheet_row_get_distance_pixels.
      	(sheet_row_get_unit_distance : Rename sheet_row_get_distance_pts.
      	(sheet_col_get_unit_distance : Rename sheet_col_get_distance_pts.
      	(sheet_col_set_width : Rename sheet_col_set_size_pixels.
      	(sheet_col_set_width_units : Rename sheet_col_set_size_pts.
      	(sheet_row_set_height : Rename sheet_row_set_size_pixels.
      	(sheet_row_set_height_units) : Rename sheet_row_set_size_pts.
      	(sheet_get_default_external_col_width) : Rename sheet_col_get_default_size_pts.
      	(sheet_get_default_external_row_height): Rename sheet_row_get_default_size_pts.
      	(sheet_col_set_internal_width) : sheet_col_set_internal_size_pts.
      	(sheet_row_set_internal_height): sheet_row_set_internal_size_pts.
      	(sheet_{row,col}_set_default_size_pts) : New functions.
      
      	(sheet_init_default_styles) : Tune to match XL defaults.
      
      	* src/sort.c : Use g_strcasecmp, and include <stdlib.h>
      
      	* src/style.c (style_color_new) : Init the selection colour as a 50%
      	  alpha blend with lavender.
      
      	* src/style.h : Change default font to be Helvetica 9 because it will
      	  scale better when the standard 96 dpi resolution is assumed.
      	  Add a selected_color to StyleColor.
      
      	* src/value-sheet.c : Include <gnome.h> to get the
      	  internationalization support.
      
      	* src/workbook-cmd-format.c (workbook_cmd_format_column_auto_fit) :
      	  sheet_col_set_width -> sheet_col_set_size_pixels.
      	(workbook_cmd_format_column_width) :
      	  sheet_col_set_width_units -> sheet_col_set_size_pts.
      	(workbook_cmd_format_row_auto_fit) :
                sheet_row_set_height -> sheet_row_set_size_pixels
      	(workbook_cmd_format_row_height) :
      	  sheet_row_set_height_units -> sheet_row_set_size_pts.
      
      	* src/xml-io.c (xml_read_rows_info) : Rename
      	  sheet_row_set_height_units -> sheet_row_set_size_pts.
      	(xml_read_cols_info) : Rename
      	  sheet_col_set_height_units -> sheet_col_set_size_pts.
      	(xml_read_colrow_info) : Remove hack with negative pixels.
      	  Use 'visible' flag instead.
      	(xml_write_colrow_info) : Ditto.
      b6d04cff
  19. 10 Feb, 2000 2 commits
    • Jody Goldberg's avatar
      Remove inclusion of cell.h. Adjust includes to loosen things a bit more. · f6b62c13
      Jody Goldberg authored
      
      2000-02-10  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.h : Remove inclusion of cell.h.  Adjust includes to loosen
      	  things a bit more.
      
      	* src/colrow.h : Remove margin_a_pt margin_b_pt.  Margins are NOT
      	  scaled by resolution or zoom.
      	  Rename units -> size_pts and store as float rather than double.
      	  Rename pixels-> size_pixels
      	  hard_size -> use gboolean rather than a 1 element bitfield
      
      	* src/style.h : Move the typedefs from here.
      	* src/gnumeric.h : to here.
      
      	*.[ch] : Catch up with the renames and include changes.
      f6b62c13
    • Jody Goldberg's avatar
      Some improvements to the default sizes of things to resizing. · 676c70fb
      Jody Goldberg authored
      We will need to tweak this to get things to match properly.
      
      2000-02-09  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook.c (change_displayed_zoom_cb) : Add a '%' at the end of
      	  the zoom specification.
      	(workbook_create_standard_toobar) : Adjust the list of zoom labels.
      
      	* src/style.c (font_init) : Add comment explaining that the default
      	  fonts are not scaled by resolution, and that we depend on that.
      
      	* src/sheet.c (sheet_init_default_styles) : Set the default sizes
      	  based on the size of the default font not on pixels.
      
      	* src/sheet-view.c (new_canvas_bar) : Don't set the size or scroll
      	  region here.
      	(sheet_view_construct) : Call sheet_view_set_zoom_factor with a factor
      	  of 1 to set sizes and scroll regions.
      	(sheet_view_set_zoom_factor) : Do not hard code the sizes of the free
      	  dimensions.  Set them based on the font used for the headers.
      676c70fb
  20. 04 Feb, 2000 1 commit
    • Jody Goldberg's avatar
      Add some config variables to the application to allow for axis dependent · d6fe542a
      Jody Goldberg authored
      zooming based on the screen display resolution (eg 110 dpi).  No GUI currently
      available.
      
      2000-02-04  Jody Goldberg <jgoldberg@home.com>
      
      	* src/widgets/widget-font-selector.c (font_selector_set_points) : new
      	  function.
      	* src/dialogs/dialog-cell-format.c (fmt_dialog_init_font_page) : Use it.
      
      2000-02-04  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_col_set_internal_width) : Scale by the axis
      	  resolution adjment.
      	(sheet_row_set_internal_height) : Ditto.
      	(colrow_set_units) : Ditto.
      	(sheet_compute_col_row_new_size) : Ditto.
      
      	* src/item-bar.c (item_bar_fonts_init) : Scale by resolution.
      	(item_bar_start_resize) : Ditto.
      	(item_bar_event) : Ditto.
      
      	* src/cell.c (cell_calc_dimensions) : Adjust interface to take the
      	  cell. Scale the height test by the vertical resolution adjustment.
      
      	* src/cell-draw.c (sheet_view_get_style_font) : rename from
      	  sheet_get_style_font in preparation for view split.  Scale
      	  the font by the average of the resolutions.
      d6fe542a
  21. 31 Jan, 2000 1 commit
    • Jody Goldberg's avatar
      Move more of the pure view elements into WorkbookPrivate. · a038ab94
      Jody Goldberg authored
      
      2000-01-31  Jody Goldberg <jgoldberg@home.com>
      
      	* src/worksheet.h : Move more of the pure view elements into
      	  WorkbookPrivate.
      
      	* src/sheet.h : Remove include of workbook.h
      
      	* *.c : manually include workbook.h only where we need it.
      
      	* src/ranges.c (parse_range) : Move here from dialog-analysis-tools.c
      	  to avoid warnings.
      
      	* src/corba-workbook.c (Workbook_save_to) : Adjust to new calling
      	  convention.
      	* src/corba-workbook-factory.c (WorkbookFactory_read) : Ditto.
      
      	* src/parser.y : Support interbook references.
      
      	* src/item-bar.c : Ignore scroll-wheel events. Eventually the app will
      	  handle these rather than the grid.
      a038ab94
  22. 28 Jan, 2000 1 commit
  23. 27 Jan, 2000 1 commit
    • Jody Goldberg's avatar
      - Some xml fixes - Row/col ins/del undo fix. - Mouse scroll fix, and · d99c96e7
      Jody Goldberg authored
      - Some xml fixes
      - Row/col ins/del undo fix.
      - Mouse scroll fix, and scrollbar speedup.
      
      2000-01-27  Jody Goldberg <jgoldberg@home.com>
      
      	* *.c : convert to using Workbook::current_sheet rather than
      	    workbook_get_current_sheet.
      
      	* src/workbook.c : Add a current_sheet member to Workbook.
      	Delete some old test code.
      	(do_focus_sheet) : Cancel inputs and update edit area with new cell.
      	(workbook_focus_current_sheet) : Update current_sheet.
      	(workbook_get_current_sheet) : Delete.
      
      	* src/sheet.c (sheet_cursor_{move, set}) : Delete call to
      	  gnumeric_sheet_cursor_set.
      
      	* src/sheet.c (sheet_{row,col}_add) : Use sheet_view_scrollbar_config.
      	  We should not be touching GUI directly.
      
      	* src/sheet-view.c (sheet_view_scrollbar_config) : Set the scrollbar's
      	  value as well as it max and page info.
      
      	* src/gnumeric-sheet.[ch] (gnumeric_sheet_cursor_set) : Delete.
      	  The scrollbars reflect the visible range, not the cursor cell.
      
      	* src/item-cursor.c (item_cursor_set_bounds_visibly) : Remove call to
      	  gnumeric_sheet_cursor_set.
      
      2000-01-26  Jody Goldberg <jgoldberg@home.com>
      
      	* src/xml-io.c (xml_workbook_write) : Do not save the current
      	  edit-text.  We don't save the current cell or the current selection
      	  so restoring the text of the ex-cursor is quite confusing.
      	(xml_workbook_read) : Restore window size.
      	(gnumeric_xml_sheet_{read,write}) : Delete unused.
      	(xml_get_range) : Utility routine.
      	(xml_read_selection_info) : Utility routine to restore the selection.
      
      	* src/sheet.c (sheet_{insert,delete}_{cols,rows}) : Do the
      	  insert/delete even if it looks like there are no cells there.
      	  There may be styles.
      d99c96e7
  24. 25 Jan, 2000 1 commit
    • Jody Goldberg's avatar
      - Fix a problem with zooming caused by the new item-bar enhancements. - · 03198e1d
      Jody Goldberg authored
      
      - Fix a problem with zooming caused by the new item-bar enhancements.
      - Remove gnumeric-sheet.h from a number of places that it had no reason to be.
      - Move all of the row/col pos/offset cache into GnumericSheet.  WARNING
        I do not populate all of it yet.
      
      2000-01-26  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet-view.c (sheet_view_set_zoom_factor) : Keep the cursor in
      	  the same place and recompute the alignments for everything.
      
      	* src/item-cursor.c (item_cursor_set_bounds) : New function.
      
      	* src/gnumeric-sheet.h : Add more orthogonal structure for caching
      	  common row/col bounds and their canvas offsets.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_create) : Init the new members.
      	(gnumeric_sheet_filenames_dropped) : Keep the canvas private.
      	(gnumeric_sheet_make_cell_visible) : Add 'force_scroll' argument.
      
      	* src/clipboard.c (clipboard_release) : It is possible to have no
      	  styles associated with a region.
      
      	* src/item-grid.c : Remove overlapping cache of bounding rows/cols and
      	  offsets.  Use the superset in GnumericSheet.
      	 (item_grid_find_{row, col}) : Support sliding backwards.
      03198e1d
  25. 23 Jan, 2000 1 commit
    • Jody Goldberg's avatar
      Improve itembar redraw. · b8823fde
      Jody Goldberg authored
      2000-01-22  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet-view.c (sheet_view_redraw_headers) : New function that
      	  will redraw a subset of an itembar.
      	(sheet_view_redraw_columns) : Delete.
      	(sheet_view_redraw_rows) : Delete.
      
      	* src/sheet.c (sheet_redraw_headers) : Call sheet_view_redraw_headers.
      	(sheet_redraw_columns) : Delete.
      	(sheet_redraw_rows) : Delete.
      
      	* src/gnumeric-sheet.h (GnumericSheet) : Remove unused member item_bar_col.
      
      	* src/colrow.c (col_row_set_visiblity) : Use sheet_redraw_headers
      	  in place of sheet_redraw_{cols,row}.
      	* src/selection.c (sheet_selection_append_range) : Ditto.
      	(sheet_select_all) : Ditto.
      	(sheet_selection_reset_only) : Ditto.  Clear the selection internally.
      
      	* src/sheet.c (sheet_{col,row}_get_distance) : Handle from > to.
      
      	* src/item-cursor.c (item_cursor_get_pixel_coords) : Use the
      	  precalculated offsets.
      	* src/item-edit.c (item_edit_get_pixel_coords) : Ditto.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_bar_set_top_row) : Update the
      	  item_grid's notion of the top.  Calculate the new distance using the
      	  previous top as the start point.
      	(gnumeric_sheet_bar_set_left_col) : Rename from top_col.  Ditto.
      
      2000-01-21  Jody Goldberg <jgoldberg@home.com>
      
      	* src/item-bar.c (item_bar_draw) : Remove minor drawing glitch when
      	  drawing at the edge of the sheet.
      	(item_bar_class_init) : Remove the unsed 'First' argument.
      
      	* src/item-grid.c (item_grid_draw) : Draw gridlines even at the
      	  outer edges.
      b8823fde
  26. 17 Jan, 2000 1 commit
    • Jody Goldberg's avatar
      Implement a more user preferences. · 76e2dfd1
      Jody Goldberg authored
      2000-01-17  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook.c : Menu items for sheet and workbook preferences.
      
      	* src/sheet-view.c (sheet_view_adjust_preferences) : New function.
      	* src/sheet.c (sheet_adjust_preferences) : New function.
      	(sheet_new) : Init the new preferences.
      	(sheet_set_text) : Avoid leaking in the failure case.
      
      	* src/selection.c (sheet_selection_paste) : Pass a context.
      
      	* src/cell.c (cell_render_value) : display_fomulas is now a sheet
      	  level preference.
      	(cell_is_number) : return boolean.
      	(cell_is_zero) : New function.
      
      	* src/item-grid.c (item_grid_draw_cell) : honour display_zero.
      76e2dfd1
  27. 13 Jan, 2000 1 commit
  28. 21 Nov, 1999 2 commits
    • Jody Goldberg's avatar
      Bug 3289 · e29ab7db
      Jody Goldberg authored
      1999-12-19  Jody Goldberg <jgoldberg@home.com>
      
      	* src/selection.c (sheet_selection_cut) : Fix Typo.
      
      	* src/item-bar.c (item_bar_start_resize) : Don't bother setting the
      	  location of the line here.  Instead we set the correctly zoomed
      	  bounds of the static-dimension.
      	(item_bar_end_resize) : Clear the saved points.
      	(item_bar_init) : Init the guide and points to NULL;
      	(item_bar_event) : No need to call canvas to world.  We zoom manually.
      	(item_bar_get_line_points) : Delete.
      e29ab7db
    • Jody Goldberg's avatar
      Use needs_name flag rather than checking the filename. All books now have · bcdc766d
      Jody Goldberg authored
      1999-11-21  Jody Goldberg <jgoldberg@home.com>
      
      	* src/file.c (workbook_save) : Use needs_name flag rather than
      	  checking the filename.  All books now have file names.
      
      	* src/workbook.c (workbook_new_with_sheets) : Move default name
      	  assignment.
      	(workbook_new) : Here.  Make the default name end in .gnumeric.
      	  Add a needs_name flag marking this name as auto generated.
      	(workbook_set_filename) : Clear the needs_name flag.
      bcdc766d
  29. 19 Nov, 1999 1 commit
  30. 15 Nov, 1999 1 commit
  31. 13 Nov, 1999 1 commit
  32. 06 Nov, 1999 1 commit
  33. 02 Nov, 1999 1 commit
  34. 30 Oct, 1999 1 commit
  35. 09 Oct, 1999 1 commit