GitLab

- Strike through
- initial format dialog support for underline and strikethrough.
- Printing of underlines and strikethroughs.

2000-03-05  Jody Goldberg <jgoldberg@home.com>

	* src/dialogs/dialog-cell-format.c : Enable the underline and
	  strikethrough elements. TODO : redo the preview for the font
	  tab to support underlining and friends.

	* src/dialogs/cell-format.glade : Rename the underline combo and
	  strikethrough button.

	* src/xml-io.c (xml_write_style) : Add strikethrough.
	(xml_read_style) : Ditto.

	* src/workbook-format-toolbar.c (workbook_feedback_set) : Only show
	  the underline button for single underlines.

	* src/sheet-view.[ch] : rename select_all -> select_all_btn.
	  remove unused element.

	* src/sheet-object.h : Remove silly self inclusion.

	* src/print-cell.c : Support underlining and strikethrough.
	  Move even closer into sync with drawing code.

	* src/mstyle.c : Add strikethrough and cleanup includes.

	* src/main.h : Add include for popt.h.

	* src/item-grid.c (item_grid_draw_border) : No more need for BOTTOM or
	  RIGHT.
	(item_grid_draw_cell) : Delete, and merge with draw_cell.

	* src/commands.c (cmd_set_text_undo) : Use cursor_set rather than
	  cursor_move.
	* src/corba-sheet.c (Sheet_cursor_move) : Ditto.
	(gnumeric_sheet_key_mode_sheet) : Ditto.
	* src/workbook.c (workbook_parse_and_jump) : Ditto.

	* src/cell-draw.c : Clean includes, add support for strikethrough.

----------------------------------------

The functions isalpha, isdigit, ..., isspace, tolower, and toupper
are ONLY defined on EOF (typically -1) and unsigned characters.
Read the manual pages from various OSs -- it's in there.

It is wrong to call these with signed characters as argument; the
type "char" can be, and often is, signed.  Please don't write code
like

     void frob (char *s)
     {
       while (isspace (*s))       /* WRONG! */
         s++;
       /* ... */
     }

Instead write something like

     void frob (char *s)
     {
       while (isspace ((unsigned char)*s))   /* Right */
         s++;
       /* ... */
     }

Note: the above is true even if you don't like it.  Some people have
gotten terrible upset and defensive when they have had this problem
pointed out to them.  That does not help.

FYI, all this makes a serious difference on Solaris, HP-UX and maybe
other OSs.

far grid line.

2000-03-03  Jody Goldberg <jgoldberg@home.com>

	* src/cell-draw.c (cell_draw) : Correct off by one error for
	  right alignment.

	* src/print-cell.c (print_cell_text) : Ditto.

2000-03-03  Jody Goldberg <jgoldberg@home.com>

	* src/print-cell.c (print_cell_range) : Don't forget to increment
	  when dealing with hidden cols/rows.
	* src/item-grid.c (item_grid_draw) : Ditto.

Modified Files:
 	balsa/po/da.po dia/po/da.po glade/po/da.po gnome-db/po/da.po
 	gnomeicu/po/da.po gnomeicu/src/GnomeICU.desktop
	gnumeric/po/da.po

2000-03-01  Dom Lachowicz <dominicl@seas.upenn.edu>

	* src/dialogs/dialog-plugin-manager.c (add_to_clist, populate_clist),
	(add_cb, remove_cb, row_cb, remove_cb, dialog_plugin_manager),
	(dialog_plugin_manager_impl): Re-implemented dialog.
	(refresh_right_frame): New function

	* src/dialogs/plugin-manager.glade: updated.

	* src/dialogs/plugin-manager.glade.h: updated

2000-03-03  Jon K Hellan  <hellan@acm.org>

	* doc/python-gnumeric.txt: Updated documentation

	* plugins/python/python.c (value_to_python): Update comment.
	(boolean_to_python): Use class gnumeric_defs.Boolean - we can now
	recognize booleans and convert them back.
	(boolean_check): New function: Checks if object is instance of
	gnumeric_defs.Boolean.
	(boolean_from_python): New function: Convert back to VALUE_BOOLEAN.
	(range_from_python): Remove misleading comment.
	(value_from_python): Handle boolean.
	(call_function): Factored out of marshal_func.
	(marshal_func): Rename to marshal_func_args. Added sanity checks.
	(marshal_func_nodes): New function. Handles varargs.
	(register_function): Handle varargs.
	(apply): Fix refcounting bug.

	* gnumeric_defs.py (Boolean): New class. Implements boolean.

More work on the wizard.  Series are sent.  If you can compile it, it theoretically works now -miguel

2000-03-02  Jon K Hellan  <hellan@acm.org>

	* src/symbol.c (symbol_is_unused): Test went wrong way.
	(symbol_remove): Ditto.

	* plugins/python/python.c (apply): Plug "Value" leak.
	(array_from_python): Fix silly mistake.
	(row_from_python): Rename "col" variable to "rowno"

2000-03-01  Dom Lachowicz <dominicl@seas.upenn.edu>

	* src/functions/fn-eng.c (val_to_base): Catch Div0 && invalid log()
	domain.

	* src/functions/fn-financial (gnumeric_accrint, gnumeric_recieved),
	(gnumeric_pricemat): Same

	* src/functions/fn-stat.c (gnumeric_ttest): Ditto

2000-03-02  Michael Meeks  <michael@helixcode.com>

	* src/sheet-vector.c (sheet_vector_corba_object_create): made static.
	(sheet_vector_new): setup sheet_vector->sheet.
	(sheet_vector_detach): re-arrange to compile.

2000-03-02  Jon K Hellan  <hellan@acm.org>

	* doc/python-gnumeric.txt: Updated documentation

	* src/func.h: Make FunctionCategory.name a String * instead of
	gchar *. This was necessary to allow user defined categories.
	src/func.c (function_category_compare, function_get_category): Use
	new FunctionCategory. Fix wrong use of g_list_find_custom.
	(function_def_count_args, function_def_get_arg_type): Null pointer
	check.

	* src/dialogs/dialog-function-select.c (function_categories_fill):
	ditto.

2000-03-01  Jon K Hellan  <hellan@acm.org>

	* python.c (exception_to_string): Rename to string_from_exception.
	(value_from_exception): New function. Converts the current Python
	exception to a new VALUE_ERROR.
	(file static variable eval_pos): remove
	(value_to_python): Fix refcounting bug re Py_None.
	(value_from_python): Caller is now responsible for converting
	exception to VALUE_ERROR.
	(marshal_func): Handle optional arguments. Use
	value_from_exception. Do away with eval_pos kludge. Consequence:
	We must pass FunctionEvalInfo as an extra parameter to the python
	functions.
	(apply): Add context parameter.
	(register_function): Add category parameter to Python
	signature. Register function in given category.

	* gnumeric_startup.py: Add category argument to all
	register_function calls.
	(gnumeric_mid, py_abs): Add context parameter.

	* python.c

2000-03-02  Almer. S. Tigelaar.  <almer1@dds.nl>

	* src/dialogs/dialog-stf-format-page.c
	* src/dialogs/dialog-stf-preview.c
	* src/dialogs/dialog-stf-preview.h
	* src/dialogs/dialog-stf.c
	Modified, the format page now really display formatted
	cells in the preview.
	NOTE : A downside of this is that the cache is no longer shared
	between fixed/csv pages and format pages.

	* src/dialogs/dialog-stf.c
	(dialog_stf_editables_enter) :
	Disabled "enter activates default button" for the TextIndicator
	field on the csv page. This would case the page to cycle, which
	is ok, but it also caused the dropdown option to pop-up on the
	next page, which is not ok.

2000-03-02  Jon K Hellan  <hellan@acm.org>

	* src/dialogs/dialog-stf.c (dialog_stf_druid_page_cancel): In
	Yes/No dialog - set initial keyboard focus to "No". It went
	nowhere.
	(dialog_stf_set_initial_keyboard_focus): New function: Set
	keyboard focus to the an appropriate widget on the page.
	(dialog_stf_druid_page_next, dialog_stf_druid_page_previous): Set
	initial keyboard focus.
	(dialog_stf_druid_page_next): Make "Finish" button default on the the
	final page. This doesn't change behaviour, but cues the user
	visually.
	(dialog_stf_druid_page_previous): Restore "Next" button as default
	when coming from final page.
	(dialog_stf_check_escape): New function: Watch keypresses, and
	simulate "Cancel" when you see <Escape>.
	(dialog_stf_attach_page_signals): Connect dialog_stf_check_escape
	to handle <Escape>.
	(dialog_stf_editables_enter): New function: Make <Ret> in text
	fields activate default.
	(dialog_stf): Use dialog_stf_editables_enter,
	dialog_stf_set_initial_keyboard_focus. Make "next" button the
	default button. Make window a child of the workbook window.

	* src/dialogs/dialog-stf-format-page.c (format_page_init): Make
	format list titles passive.

	* src/dialogs/dialog-stf-fixed-page.c (fixed_page_init): Make
	column list titles passive.

	* src/clipboard.c (x_selection_to_cell_region): Add command
	context to interface. Use it when calling dialog_stf.
	(x_selection_to_cell_region):
	(x_selection_received): Call x_selection_to_cell_region with
	workbook_command_context_gui.

Lots of more work on the wizard for graphics.

2000-03-02  Miguel de Icaza  <miguel@helixcode.com>

	* src/about.c (dialog_about): Changed to www.helixcode.com

2000-03-01  Miguel de Icaza  <miguel@helixcode.com>

	* src/parser.c (gnumeric_expr_parser): Make preconditions clear.

	* src/ranges.c: Removed gnome.h from the include list.

	* src/sheet.h: Fix comment.  The list contains SheetSelection
	structures not Ranges.

Lots of work on the wizard/graphics directory

2000-03-01  Jon K Hellan  <hellan@acm.org>

	* src/dialogs/cell-format.glade: Font pane: Make accelerator for
	underline combo work. Enable strikethrough.

2000-03-01  Michael Meeks  <michael@helixcode.com>

	* configure.in: Bump required ver. of gnome-print.

	* src/style.c (style_font_get_height): hack for new gnome-print
 	to kill annoying warning.

Revamped the design docs.

2000-03-01  Jon K Hellan  <hellan@acm.org>

	* src/dialogs/cell-format.glade: Enable underline in fonts pane.

2000-03-01  Jon K Hellan  <hellan@acm.org>

	* src/dialogs/advanced-filter.glade: Added accelerators and some
	padding.

Bug 6652
- Handle spans correctly when calculating extent.
- Correct lots of off by one errors resulting in differences between
  postscript and gdk models of clipping and drawing.

2000-02-29  Miguel de Icaza  <miguel@nuclecu.unam.mx>

	* src/cell.c (cell_content_changed): Notify the sheet that the
	cell changed using sheet_cell_changed.

	* src/sheet-vector.c: New file.  Implements the Gnumeric:Vector
	interface (and supports non-contiguous ranges)

	* src/sheet.c (sheet_destroy): free private structure.
	(sheet_new): init private structure.
	(sheet_cell_changed): New function.

	* src/sheet-private.h: New file.

	* src/sheet.h: Sheet structure includes SheetPrivate field now.

2000-02-29  Jody Goldberg <jgoldberg@home.com>

	* src/workbook-format-toolbar.c (change_selection_font) : Add underline.
	(underline_cmd) : New function.
	(workbook_format_toolbar) : Add underline.
	(workbook_feedback_set) : Ditto.

	* src/xml-io.c (xml_read_style) : Restore underline style.
	(xml_write_style) : Save the underline style.

	* src/pattern.c (gnumeric_background_set_pc) : suppress warning.

	* src/mstyle.[ch] : Add MSTYLE_FONT_UNDERLINE.
	(mstyle_get_font_uline) : New function.
	(mstyle_set_font_uline) : New function.

	* src/cell-draw.c (draw_text) : new function to add underlines.
	(draw_overflow) : Use draw_text.
	(cell_draw) : Ditto.

	* src/gnumeric.h : Add StyleUnderlineType.

	* gnumeric.spec.in : Update the requirements.

2000-03-01  Jon K Hellan  <hellan@acm.org>

	* doc/python-gnumeric.txt: Clarified mapping of arrays.

	* plugins/python/python.c (cell_ref_to_python, range_to_python,
	cell_ref_from_python): Simplify error handling.
	(boolean_to_python): Simplify
	(row_to_python): New function. Converts an array row to
	Python.
	(array_to_python): New function. Converts an array to Python.
	(value_to_python): Handle array.
	(range_check): Factored out of value_from_python.
	(range_from_python): Restructure to use value_new_cellrange
	(array_check): New function. Check if object is array.
	(value_from_python): Restructure to use the value_new_xxx
	constructors.
	(apply): Release values when no longer needed.

2000-02-29  Jody Goldberg <jgoldberg@home.com>

	* src/cell-print.c : Sync with logic in item-bar::draw to add borders
	  and more correctly handle spanning.

	* src/pattern.c (gnumeric_background_set_pc) : New routine cloned from
	  gnumeric_background_set_gc.

	* src/border.c (style_border_set_pc_dash) : New routine cloned from
	  style_border_set_gc_dash.
	(style_border_set_pc) : New routine cloned from style_border_set_gc.
	(style_border_print) : New routine cloned from style_border_draw.

	* src/cell-draw.c (cell_draw) : No need to return number of spans.

2000-02-29  Jukka-Pekka Iivonen  <iivonen@iki.fi>

	* src/sheet.c (sheet_new): Added initialization of all the Solver
 	parameters.

	* src/xml-io.c: Enabled the solver parameter saving again.

2000-02-29  Jon K Hellan  <hellan@acm.org>

	* python.c: Great renaming:
	convert_py_exception_to_string -> exception_to_string
	convert_cell_ref_to_python     -> cell_ref_to_python
	convert_range_to_python        -> range_to_python
	convert_boolean_to_python      -> boolean_to_python
	convert_value_to_python        -> value_to_python
	convert_cell_ref_from_python   -> cell_ref_from_python
	convert_range_from_python      -> range_from_python
	convert_python_to_value        -> value_from_python
	gnumeric_apply                 -> apply
	gnumeric_register_function     -> register_function

2000-02-29  Jon K Hellan  <hellan@acm.org>

	* src/gnumeric-util.[ch] (gnumeric_set_transient): New
	function. Make the window a child of the workbook in the command
	context, if there is one.
	(gnumeric_editable_enters): New function. Like
	gnome_dialog_editable_enters, but not just for GnomeDialogs.

	* src/gnumeric-util.c (gnumeric_dialog_run): Remove incorrect
	comment.
	(gnumeric_dialog_show): Fix typo.

2000-02-29  Jon K Hellan  <hellan@acm.org>

	* src/dialogs/dialog-cell-format.c: The dialog moved when "Apply"
	was pressed. This was an unavoidable consequence of using
	gnome_dialog_run. We switch to a purely callback based design -
	this module was almost there, anyway. And we can make the dialog
	modeless if we wish.
	(cb_fmt_dialog_dialog_destroy): New function. Free resources upon
	"destroy". This gets called whenever "OK" or "WM close" are
	pressed.
	(fmt_dialog_impl): Connect "destroy" handler. Replace
	gnome_dialog_run (recursive main loop) with gnumeric_dialog_show
	(no such thing). Set modal explicitly.
	(dialog_cell_format): Remove initial comment which these changes
	made incorrect. Allocate state record on heap instead of stack.
	Move resource deallocation to cb_fmt_dialog_destroy.

2000-02-28  Kjartan Maraas  <kmaraas@online.no>

	* no.po: Updated Norwegian translation.

Bug 6683.
normalize ranges.