1. 09 May, 2000 2 commits
    • Jody Goldberg's avatar
      When guessing what the entered text was for a supplied string value · 7d4e2b1a
      Jody Goldberg authored
      
      2000-05-08  Jody Goldberg <jgoldberg@home.com>
      
      	* src/cell.c (cell_set_value) : When guessing what the entered text
      	  was for a supplied string value prepend a \' to ensure that the
      	  value stays a string, and so that blank cells work better.
      7d4e2b1a
    • Jody Goldberg's avatar
      thanks Chema · ea7ad36d
      Jody Goldberg authored
      - Spans were not redrawn when interupted.
      - Spans were not recalculated when the blockage was cleared.
      - Sorting crashed because the semantics of sheet_remove_cell
        changed to call cell_destroy.
      
      2000-05-08  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_cell_calc_span) : redraw the bounding range when
      	  interupting spans.
      	(sheet_clear_region) : Respan ranges that were interupted by the
      	  cleared region.
      	(sheet_cell_remove_simple) : rename from sheet_cell_remove_internal and
      	  export.
      ea7ad36d
  2. 08 May, 2000 7 commits
    • Jon K Hellan's avatar
      New callback: Make double click on list in import filter chooser works · c1def8a8
      Jon K Hellan authored
      2000-05-08  Jon K Hellan  <hellan@acm.org>
      
      	* src/file.c (cb_select): New callback: Make double click on list
      	in import filter chooser works like "OK".
      	(workbook_import): Back when we first started using glade, we used
      	a hack to avoid flicker when popping up the filter chooser. We now
      	know how to do it right, and remove the hack.
      	(workbook_import): Connect callback to handle double click.
      	(workbook_import): Fix bug: return value from import would clobber
      	return value from dialog_run. We now close dialog after retrieving
      	selection, but before importing.  We really should keep the dialog
      	up until user either succeeds with import or explicitly
      	cancels. But we let that wait. This behaviour should be
      	implemented in a lot of places in a coordinated way.
      	(workbook_import): Do not destroy workbook after WM close - it is
      	already destroyed.
      c1def8a8
    • Morten Welinder's avatar
      Survive version "0.19cvs". include <config.h> · 94640601
      Morten Welinder authored
      2000-05-03  Morten Welinder  <terra@diku.dk>
      
      	* configure.in (gnome-print): Survive version "0.19cvs".
      	* *: include <config.h>
      94640601
    • Jody Goldberg's avatar
      commit missing changelog · 9daac31c
      Jody Goldberg authored
      9daac31c
    • Jody Goldberg's avatar
      Call sheet_update so that selection changes via mouse movement will update · acbe5a8b
      Jody Goldberg authored
      2000-05-08  Jody Goldberg <jgoldberg@home.com>
      
      	* src/selection.c (sheet_selection_extend_to) : Call sheet_update
      	  so that selection changes via mouse movement will update the status
      	  areas.
      	(sheet_selection_set) : Call sheet_flag_selection_change.
      
      	* src/sheet.c (sheet_flag_selection_change) : New function to
      	  flag that sheet_update should recalc the autoexpressions.
      acbe5a8b
    • Jon K Hellan's avatar
      This change was committed a week ago, but I forgot the changelog: · 44d15c1f
      Jon K Hellan authored
      2000-05-08  Jon K Hellan  <hellan@acm.org>
      
      	This change was committed a week ago, but I forgot the changelog:
      
      	* src/dialogs/dialog-goto-cell.c (cb_row_selected): Make double
      	click on list work like "OK".
      
      	* src/dialogs/dialog-goto-cell.c (dialog_goto_cell): Remove
      	buttons which do not do anything yet.
      44d15c1f
    • Jon K Hellan's avatar
      New callback: Give up focus when widget is destroyed. This gets rid of a · ba540ef4
      Jon K Hellan authored
      2000-05-07  Jon K Hellan  <hellan@acm.org>
      
      	* src/workbook.c (yield_focus): New callback: Give up focus when
      	widget is destroyed. This gets rid of a warning when import is
      	canceled.
      	(workbook_attach_sheet): Connect callback.
      	(workbook_set_focus): Do nothing if focus target argument is NULL.
      ba540ef4
    • Jody Goldberg's avatar
      Bump the xml version to v3. (xml_probe) : Handle v[123]. · 4604f988
      Jody Goldberg authored
      2000-05-07  Jody Goldberg <jgoldberg@home.com>
      
      	* src/xml-io.c (xml_workbook_write) : Bump the xml version to v3.
      	(xml_probe) : Handle v[123].
      4604f988
  3. 07 May, 2000 3 commits
  4. 06 May, 2000 4 commits
    • Jody Goldberg's avatar
      Split from cell_set_expr. · 4d72a2e6
      Jody Goldberg authored
      
      2000-05-06  Jody Goldberg <jgoldberg@home.com>
      
      	* src/cell.c (cell_set_expr_unsafe) : Split from cell_set_expr.
      
      	* src/eval.c (invalidate_refs) : Use cell_set_expr_unsafe.
      
      	* src/sheet.c (sheet_set_zoom_factor) : Depending on the order of
      	  initialization we may also need to render some unrendered values.
      4d72a2e6
    • Almer. S. Tigelaar's avatar
      Add the form feed character (\f) as valid text character. · 9f058999
      Almer. S. Tigelaar authored
      2000-05-06  Almer. S. Tigelaar.  <almer1@dds.nl>
      
      	* src/stf-parse.c (stf_parse_is_valid_data) : Add
      	the form feed character (\f) as valid text character.
      	(stf_parse_convert_to_unix) : In addition to CRLF and CR,
      	remove form feeds (\f) from data.
      
      	* src/stf.c (stf_read_workbook) : Add a workbook_recalc just
      	to be sure.
      9f058999
    • Michael Meeks's avatar
      Add 3D dependency support. (cb_single_hash_to_list, · 479bddb8
      Michael Meeks authored
      2000-05-06  Michael Meeks  <michael@helixcode.com>
      
      	* src/eval.c (handle_cell_range_deps): Add 3D dependency support.
      	(cb_single_hash_to_list, cb_range_hash_to_list): Re-arrange handling of
      	where the list is collated. (do_deps_destroy): update.
      	(cell_drop_dependencies): remove cretinism here.
      	(drop_cell_range_dep, handle_cell_single_dep): return on NULL deps structure.
      
      	* src/sheet-style.c (sheet_style_attach): enable cache trash avoidance code.
      
      	* src/sheet.c (sheet_cell_remove_internal): short circuit for NULL
      	deps.
      
      	* src/expr.c (expr_rewrite): update to handle workbook case.
      
      	* src/eval.c (workbook_deps_destroy): update for speed.
      	(sheet_deps_destroy): split body into (do_deps_destroy): here.
      
      	* src/workbook.c (workbook_delete_sheet): destroy the sheet's
      	dependencies here as well; very silly. (workbook_do_destroy): destroy
      	deps of all sheets up front.
      479bddb8
    • Jody Goldberg's avatar
      Be sure the clear the expr if we are returning a value. · ed03b2ab
      Jody Goldberg authored
      
      2000-05-06  Jody Goldberg <jgoldberg@home.com>
      
      	* src/parse-util.c (parse_text_value_or_expr) : Be sure the clear the
      	  expr if we are returning a value.
      ed03b2ab
  5. 05 May, 2000 2 commits
  6. 04 May, 2000 9 commits
    • Michael Meeks's avatar
      Fixed bonobo menu merging. · e9bb3082
      Michael Meeks authored
      e9bb3082
    • Jody Goldberg's avatar
      NULL the undo, redo lists after clearing them. · d4c03b6e
      Jody Goldberg authored
      
      NULL the undo, redo lists after clearing them.
      
      2000-05-04  Jody Goldberg <jgoldberg@home.com>
      	(workbook_delete_sheet) : NULL the undo, redo lists after they are
      	  cleared.
      	(workbook_do_destroy) : Ditto.
      d4c03b6e
    • Michael Meeks's avatar
      don't shrink. sheet sized ranges. (sheet_style_compute): add precondition · eb1b5e70
      Michael Meeks authored
      2000-05-04  Michael Meeks  <michael@helixcode.com>
      
      	* src/sheet-style.c (sheet_style_delete_colrow): don't shrink.
      	sheet sized ranges. (sheet_style_compute): add precondition for
      	Norberts.
      
      	* src/workbook.c (workbook_new_with_sheets): kill ' ' in
      	sheet names.
      
      	* corba-test/test-gnumeric-corba.c (do_test): ditto.
      eb1b5e70
    • Jody Goldberg's avatar
      Desensitize the '=' during editing. · 786d336b
      Jody Goldberg authored
      Fix typ in toolbar init.
      Fix typo in sheet deletion.
      
      2000-05-04  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook.c : Fix typo that was calling undo for redo toolbar.
      	({redo,undo}_cmd) : Use workbook_finish_editing directly.
      	(cb_auto{function,sum}) : If we are already editing do not start.
      	  When the wizard is in place bring it up.
      	(workbook_start_editing_at_cursor) : Make the '=' insensitive while
      	  editing.
      	(workbook_finish_editing) : Make the '=' sensitive.
      	(sheet_action_delete_sheet) : Fix typo and rename parm
      	  'current_sheet' -> 'sheet' to avoid confision with
      	  workbook->current_sheet.
      786d336b
    • Almer. S. Tigelaar's avatar
      : Check if cell->rendered_value is NULL. To avoid segfaulting. · d6b0dfd5
      Almer. S. Tigelaar authored
      2000-05-04  Almer. S. Tigelaar.  <almer1@dds.nl>
      
      	* src/rendered-value.c :
      	(rendered_value_calc_size) : Check if
      	cell->rendered_value is NULL. To avoid
      	segfaulting.
      d6b0dfd5
    • Almer. S. Tigelaar's avatar
      Added stf-exporter documentation · 06c6a355
      Almer. S. Tigelaar authored
      2000-05-04  Almer. S. Tigelaar.  <almer1@dds.nl>
      
      	* doc/stf-export.txt :
      	Added stf-exporter documentation
      06c6a355
    • Almer. S. Tigelaar's avatar
      : New, makes dialogs close when enter is pressed inside a gtkcombo. · 852d09b7
      Almer. S. Tigelaar authored
      2000-05-04  Almer. S. Tigelaar.  <almer1@dds.nl>
      
      	* src/gnumeric-util.[ch] :
      	(gnumeric_combo_enters) : New, makes dialogs
      	close when enter is pressed inside a gtkcombo.
      
      	* src/dialogs/dialog-stf.c :
      	(stf_dialog_editables_enter) : Modified to use
      	the above function for combo boxes.
      
      	* src/dialogs/dialog-stf-export.c :
      	(stf_export_dialog_editables_enter) : Modified to
      	use the above function for combo boxes.
      852d09b7
    • Jody Goldberg's avatar
      new function. Handle. Handle. · 9a04a8ea
      Jody Goldberg authored
      
      2000-05-03  Jody Goldberg <jgoldberg@home.com>
      
      	* src/command-context.c (gnumeric_error_invalid) : new function.
      	* src/command-context-gui.c (ccg_error_invalid) : Handle.
      	* src/command-context-corba.c (ccc_error_invalid) : Handle.
      
      	* src/commands.c (cmd_rename_sheet_{undo,redo}) : Pass a context to
      	  workbook_rename_sheet.
      
      	* src/workbook.c (workbook_rename_sheet) : Sheet names can not be
      	  empty.  Take a CommandContext and report the error.  Invert the
      	  return value.
      9a04a8ea
    • Jody Goldberg's avatar
      Fix old typo that was causing bug 10001 by breaking AM/PM. · edcf0c68
      Jody Goldberg authored
      
      2000-05-03  Jody Goldberg <jgoldberg@home.com>
      
      	* src/format.c (pre_parse_format) : Fix old typo that was causing
      	  bug 10001 by breaking AM/PM.
      edcf0c68
  7. 03 May, 2000 5 commits
    • Jody Goldberg's avatar
      Fix leak morten found. · 43002eb0
      Jody Goldberg authored
      
      Fix leak morten found.
      
      2000-05-03  Jody Goldberg <jgoldberg@home.com>
      
      	* src/cell.c (cell_set_array_formula) : Add some invariants to catch
      	  inverted arrays.  The function should use the supplier's
      	  reference.  It should not re-reference the supplied expression.
      	  Document this.
      43002eb0
    • Morten Welinder's avatar
      Add version check. · d7191722
      Morten Welinder authored
      2000-05-03  Morten Welinder  <terra@diku.dk>
      
      	* autogen.sh (libtool): Add version check.
      d7191722
    • Jody Goldberg's avatar
      Begin to rationalize support for inverted and 3D references. · de62dd3a
      Jody Goldberg authored
      More renaming and movement name rationalization.
      Some minor improvements in the function wizard.
      
      2000-05-03  Jody Goldberg <jgoldberg@home.com>
      
      	* EvalPosition -> EvalPos
      	  ParsePosition -> ParsePos
      	  new struct RangeRef used in ValueRange
      
      	  eval_pos_init* -> position.[ch]
      	  parse_pos_init*
      	  cell_ref_{get,make}*
      
      	* src/workbook.c : Reorder the toolbar a bit.
      	(workbook_foreach_cell_in_range) : New function.
      	(cb_autofunction) : New routine.
      	(workbook_set_auto_expr) : DO NOT put real code into pre/post
      	  conditions.  It will be removed when debugging is eventually
      	  disabled.
      
      	* src/position.c (range_ref_normalize) : New function.
      
      	* src/ranges.c (range_normalize) : New function.
      
      	* src/expr.c (expr_implicit_intersection) : Use range_ref_normalize.
      
      	* src/eval.c (cell_eval_content) : No need to release the value.
      	  cell_assign_value already does that.
      	(dependency_range_ctor) : Use range_normalize.
      
      	* src/auto-format.c (do_af_suggest) : Use workbook_foreach_cell_in_range.
      
      	* src/cell.c (cell_set_expr_and_value) : link the new expression but
      	  do not queue it for recalc.
      	(cell_assign_value) : Release the old value.
      	(cell_copy) : Init the value to empty.
      
      	* src/func.c (function_iterate_do_value) : Use
      	  workbook_foreach_cell_in_range.
      
      	* src/dialogs/dialog-function-wizard.c (create_description) : Use
      	  a label rather than a text entry widget.  It looks better.
      
      	* src/functions/fn-string.c (gnumeric_expression) : range is already
      	  absolute.
      
      	* src/functions/fn-stat.c (gnumeric_linest) : Handle inverted ranges.
      	(gnumeric_logest) : Ditto.
      
      	* src/functions/fn-information.c (gnumeric_countblank) : Use
      	workbook_foreach_cell_in_range.
      	(gnumeric_{row,column}) : Handle inversions.
      
      	* src/functions/fn-lookup.c (gnumeric_offset) : No need to make
      	  absolute.  The marshaller already did that.
      
      2000-05-02  Jody Goldberg <jgoldberg@home.com>
      
      	* src/eval.c (dependency_range_ctor) : normalize the range.
      
      	* src/xml-io.c (xml_write_cell_and_position) : Suppress warning.
      
      	* src/pixmaps.h : Add function wizard and equal sign.
      de62dd3a
    • Michael Meeks's avatar
      Accelerate intersheet dependancies for Hans, · 3de60968
      Michael Meeks authored
      2000-05-03  Michael Meeks  <michael@helixcode.com>
      
      	* doc/Dependencies.txt: update to reflect changes.
      
      	* src/eval.c: comment and const mending.
      	(handle_cell_range_deps): prune no inter-sheet singletons code,
      	it is a sluggish anachronism. (handle_cell_single_dep): setup
      	the correct sheet to enter data into.
      
      	* src/eval.h: expunge redundant commenting, re-order,
      	const kill.
      3de60968
    • Almer. S. Tigelaar's avatar
      s/strcasecmp/g_strcasecmp/ · 4741a7a5
      Almer. S. Tigelaar authored
      2000-05-03  Almer. S. Tigelaar.  <almer1@dds.nl>
      
      	* *.c: s/strcasecmp/g_strcasecmp/
      4741a7a5
  8. 02 May, 2000 3 commits
    • Almer. S. Tigelaar's avatar
      We called gtk_widget_destroy _after_ gnome_dialog_close. This causes a · d4dfa9af
      Almer. S. Tigelaar authored
      2000-05-02  Almer. S. Tigelaar.  <almer1@dds.nl>
      
      	* src/file.c (workbook_import) : We called gtk_widget_destroy
      	_after_ gnome_dialog_close. This causes a weird "invalid cast"
      	message each time something was successfully imported.
      d4dfa9af
    • Michael Meeks's avatar
      fixup popt for oaf. · a7225c31
      Michael Meeks authored
      2000-05-01  Michael Meeks  <michael@helixcode.com>
      
      	* src/corba-args.c (gnumeric_arg_parse): fixup popt for oaf.
      
      2000-05-02  Michael Meeks  <michael@helixcode.com>
      
      	* main.c (layout_factory_init): update for oaf.
      
      	* sample.c (create_test): nicer activation.
      
      2000-05-02  Michael Meeks  <michael@helixcode.com>
      
      	* graphic-context.c (get_graphics_component): update for oaf.
      a7225c31
    • Jody Goldberg's avatar
      New function. · b2198f30
      Jody Goldberg authored
      
      2000-05-01  Jody Goldberg <jgoldberg@home.com>
      
      	* src/expr.c (expr_tree_shared) : New function.
      
      	* src/xml-io.c (gnumeric_xml_write_selection_clipboard) : Init and
      	  destroy the expression hash.
      	(gnumeric_xml_read_selection_clipboard) : Ditto.
      	(gnumeric_xml_read_workbook) : Ditto.
      	(gnumeric_xml_write_workbook) : Ditto.
      	(xml_write_cell_and_position) : When saving cells that have expression
      	  assign and store an ID for shared expressions.
      	(xml_read_cell) : Use the ID to restore shared expressions.
      b2198f30
  9. 01 May, 2000 5 commits
    • Jody Goldberg's avatar
      ExprName -> NamedExpression ArrayRef -> ExprArray · 8d168628
      Jody Goldberg authored
      
      2000-05-01  Jody Goldberg <jgoldberg@home.com>
      
      	* ExprName -> NamedExpression
      	  ArrayRef -> ExprArray
      
      	change ExprTree to be a union of similar types and split
      	the elements into discrete types.
      	    ExprConstant
      	    ExprFunction
      	    ExprUnary
      	    ExprBinary
      	    ExprName
      	    ExprVar
      	    ExprArray
      
      	    expr->oper -> expr->any.oper
      
      2000-04-29  Jody Goldberg <jgoldberg@home.com>
      
      	* src/value.c (value_new_empty) : Don't allocate any memory.
      	(value_release) : Don't free any either.
      
      	* src/sheet-style.c (border_check) : Init outer_style to remove a
      	  warning.
      8d168628
    • Jon K Hellan's avatar
      Popup tool and dismiss chooser on double click. · c62b6cac
      Jon K Hellan authored
      2000-05-01  Jon K Hellan  <hellan@acm.org>
      
      	* src/dialogs/dialog-analysis-tools.c (selection_made): Popup tool
      	and dismiss chooser on double click.
      
      	* src/dialogs/col-width.glade: Add title
      	* src/dialogs/import.glade: Ditto
      	* src/dialogs/row-height.glade: Ditto
      	* src/dialogs/sheet-rename.glade: Ditto
      	* src/dialogs/summary.glade: Ditto
      
      	* src/dialogs/analysis-tools.glade (All dialogs): Add padding
      	between input and output frames.
      	(TTest1 dialog, TTest2 dialog, TTest3 dialog, Anova2 dialog,
      	MovingAverage dialog): Remove spaces from label string.
      	(Anova1 dialog, Correlation dialog, Covariance dialog,
      	RankAndPercentile dialog): Use table in input frame. Get rid of
      	frame around "Grouped by". Use alignment and fill instead of
      	spaces to place label strings. Minor output options tweaks.
      	(MovingAverage dialog): Place all user widgets inside the same
      	vbox to make padding uniform.
      c62b6cac
    • Michael Meeks's avatar
      Handle oafinfo.in · af769d68
      Michael Meeks authored
      2000-05-01  Michael Meeks  <michael@helixcode.com>
      
      	* configure.in: Handle oafinfo.in
      
      	* src/sheet-object.c (sheet_set_mode_type_full): oafize.
      
      	* src/sheet-object-container.c (sheet_object_container_new_from_goadid):
      	ditto.
      
      	* src/sheet.c (sheet_insert_object): always launch via.
      	bonobo_object_activate regardless of monikers.
      
      	* idl/Gnumeric.idl: add a comment telling people to look elsewhere if
      	they want to write bonobo components.
      
      	* src/workbook.c (insert_object_cmd): update for oaf.
      
      	* src/main.c (gnumeric_main): Check for NULL ctx, on corba failure.
      
      	* src/corba-args.c (gnumeric_arg_parse): NULL ctx.
      
      	* src/corba-workbook-factory.c (_WorkbookFactory_init): update to
      	use od_server_register.
      	(WorkbookFactory_create_object): use Bonobo_stringlist not GNOME_stringlist,
      	when was this last compiled ...
      
      	* src/corba-args.c (gnumeric_arg_parse): update for OAF.
      
      	* acconfig.h: USING_OAF
      
      	* configure.in: ditto.
      
      2000-05-01  Michael Meeks  <michael@helixcode.com>
      
      	* HACKING: make it more explicit.
      af769d68
    • Morten Welinder's avatar
      () -> (void). · 14e1f2ab
      Morten Welinder authored
      14e1f2ab
    • Morten Welinder's avatar
      fix prototype. (C isn't C++.) · 9227ee8c
      Morten Welinder authored
      2000-05-01  Morten Welinder  <terra@diku.dk>
      
      	* src/gutils.c (gnumeric_usr_plugin_dir, gnumeric_sys_plugin_dir,
       	gnumeric_sys_glade_dir): fix prototype.  (C isn't C++.)
      
      	* src/complete.c (complete_destroy): Static.
      
      	* src/regression.c: Inlcude <string.h> for memset.
      9227ee8c