1. 27 Jun, 2001 1 commit
  2. 18 Jun, 2001 1 commit
  3. 15 Jun, 2001 1 commit
    • Jody Goldberg's avatar
      Use CellPos directly. · 90113e73
      Jody Goldberg authored
      2001-06-15  Jody Goldberg <jgoldberg@home.com>
      	* ms-excel-read.c (ms_excel_sheet_new) : Use CellPos directly.
      	* ms-formula-read.c (ms_excel_parse_formula) : some cleanup.
      2001-06-14  Jody Goldberg <jgoldberg@home.com>
      	* src/sheet-control-gui.c (scg_colrow_select) : don't
      	  discard input when selecting a range.
      	* src/xml-io.c (xml_write_range) : Add some safety.
  4. 12 Jun, 2001 1 commit
    • Chyla Zbigniew's avatar
      Two extra helpers (value, workbook) + changes in count helper), removed · baace536
      Chyla Zbigniew authored
      * src/io-context-priv.h
      (enum GnumProgressHelperType, struct GnumProgressHelper): Two extra
      helpers (value, workbook) + changes in count helper), removed min_f and
      max_f fields.
      (struct ProgressRange): New.
      (struct _IOContext): Added progress_ranges, progress_min, progress_max.
      * src/io-context.h
      (enum WbProgressElements): New.
      (file_io_progress_set, memory_io_progress_set):
      Removed min_f and max_f arguments.
      (count_io_progress_set): Added step argument, removed min_f and max_f.
      (count_io_progress_update): s/value/inc.
      (io_progress_range_push, io_progress_range_pop,
      value_io_progress_set, value_io_progress_update,
      workbook_io_progress_set, workbook_io_progress_update): New.
      * src/io-context.c
      (io_context_init): Initialize extra fields: progress_ranges,
      progress_min, progress_max.
      (io_progress_update): Adjust the value, using current range
      <progress_min, progress_max>.
      (io_progress_range_push, io_progress_range_pop): New.
      (file_io_progress_set, memory_io_progress_set):
      Removed min_f and max_f arguments.
      (file_io_progress_update, memory_io_progress_update): Don't adjust value
      to current range, io_progress_update takes care of this.
      (count_io_progress_set): Added "step" argument, initialize extra
      struct fields: last, current, step.
      (count_io_progress_update): Take value increase as an argument, not
      value itself. Return immediately if value hasn't changed enough.
      (value_io_progress_set, value_io_progress_update,
      workbook_io_progress_set, workbook_io_progress_update): New. Two
      additional helpers, "workbook" should be very useful when saving
      * src/xml-io.h (struct _XmlParseContext): Removed element_counter.
      * src/xml-io.c
      (xml_read_styles, xml_sheet_read): Don't increment element_counter
      manually, just call count_io_progress_update.
      (xml_workbook_read): Pass the size of the step to
      count_io_progress_set, use io_progress_range_{push,pop}.
      (gnumeric_xml_read_workbook): Use io progress helper of type "value".
  5. 04 Jun, 2001 2 commits
  6. 03 Jun, 2001 1 commit
    • Chyla Zbigniew's avatar
      Updating i/o progress while saving Gnumeric XML file. · 229358f8
      Chyla Zbigniew authored
      Updating i/o progress while saving Gnumeric XML file.
      * src/xml-io.c
      (xml_write_cell_and_position): Update i/o progress every
      (xml_write_styles): Ditto for styles.
      (gnumeric_xml_read_workbook): Better error reporting.
      (workbook_get_n_elements): Internal function, calculating the number of
      "elements" (styles and cells) in workbook.
      (gnumeric_xml_write_workbook): Split saving to three stages: building
      XML tree, dumping it to memory buffer, saving (compressed) buffer
      contents to file. Update i/o progress regularly.
      The second stage still freezes UI though :(
  7. 01 Jun, 2001 1 commit
    • Chyla Zbigniew's avatar
      Support for reporting i/o progress via IOContext. · a1a6847e
      Chyla Zbigniew authored
      Support for reporting i/o progress via IOContext.
      * src/command-context-priv.h (struct CommandContextClass): Added
      progress_message_set virtual.
      * src/command-context.[ch] (gnumeric_progress_message_set): New.
      * src/io-context-priv.h
      Made IOContext a GtkObject.
      (enum GnumProgressHelperType, struct GnumProgressHelper): New.
      * src/io-context.[ch]
      Made IOContext a GtkObject.
      (io_progress_update, io_progress_message,
      file_io_progress_set, file_io_progress_update,
      memory_io_progress_set, memory_io_progress_update,
      count_io_progress_set, count_io_progress_update,
      io_progress_unset): New functions.
      (gnumeric_io_context_free): Removed, use gtk_object_destroy instead.
      * src/workbook-control-gui.c (wbcg_progress_message_set): New,
      implementation of CommandContext virtual.
      * src/workbook-view.c
      (wb_view_save_as, wb_view_save, wb_view_open_custom):
      * src/xml-io.h
      (struct _XmlParseContext): New members (io_context, element_counter) for
      progress reporting.
      * src/xml-io.c
      (xml_read_styles): Update i/o progress every N_ELEMENTS_BETWEEN_UPDATES
      (xml_sheet_read): Ditto for cells.
      (xml_get_n_children, xml_read_sheet_n_elements,
      xml_read_workbook_n_elements): Internal functions, calculating the
      number of "elements" (styles and cells) in workbook.
      (xml_workbook_read): Set up io progress to "Processing XML tree" stage.
      (gnumeric_xml_read_workbook): Load the file into an XML tree using the
      Push mode and update i/o progress regularly.
      * src/plugin-util.c
      #include <libgnome/libgnome.h> instead of <gnome.h>.
  8. 29 May, 2001 1 commit
    • Chyla Zbigniew's avatar
      Added FileProbeLevel argument. (GNUM_FILE_OPENER_CLASS, · ecec4fee
      Chyla Zbigniew authored
      * src/file.h
      (typedef enum FileProbeLevel) New.
      (typedef GnumFileOpenerProbeFunc, gnum_file_opener_probe): Added
      FileProbeLevel argument.
      Macros moved to file-priv.h.
      * src/file-priv.h
      (struct _GnumFileOpenerClass::probe):
      Macros moved from file.h.
      * src/file.c
      (gnum_file_opener_probe_real, gnum_file_opener_probe):
      Added FileProbeLevel argument.
      * src/workbook-view.c
      (wb_view_open_custom): Iterate over FileProbeLevel values when probing
      the file (passing current value to probe function).
      * src/xml-io.c
      (xml_probe): Added FileProbeLevel argument, testing only file name if
      probe level == FILE_PROBE_FILE_NAME.
      * src/plugin-service.c (gnum_plugin_file_opener_probe):
      Use file_patterns only if probe level == FILE_PROBE_FILE_NAME, otherwise
      call module's probe function.
      * src/bonobo-io.c (gnumeric_bonobo_io_probe),
      src/plugin-service.h (struct _PluginServiceFileOpener),
      struct ServiceLoaderDataFileOpener::module_func_file_probe):
      Added FileProbeLevel argument.
  9. 27 May, 2001 1 commit
    • Jody Goldberg's avatar
      If successful queue everything for recalc. (xml_cell_set_array_expr) : no · b740bf75
      Jody Goldberg authored
      2001-05-26  Jody Goldberg <jgoldberg@home.com>
      	* xml-sax-read.c (xml_sax_file_open) : If successful queue everything
      	  for recalc.
      	(xml_cell_set_array_expr) : no need to queue a recalc for arrays.
      2001-05-26  Jody Goldberg <jgoldberg@home.com>
      	* src/sheet.c (colrow_move) : no need to queue recalc here.
      	(cb_sheet_cell_copy) : Actually copy the array values.
      	* src/cell.c (cell_relocate) : Just relink, no need to queue a recalc.
      	(cell_set_array_formula) : Remove the ability to queue the recalc at
      	  this level.  Just link the formulas in.  Reorder the the arguments
      	  to match the standard approach.
      	* src/eval.c (workbook_recalc_all) : Used here.
      	(workbook_queue_all_recalc) : new function.
      	* src/xml-io.c (xml_workbook_read) : Queue everything for recalc.
      	(xml_cell_set_array_expr) : no need to queue a recalc here.
      	* src/commands.c (cmd_autofill_redo) : queue the recalc here.
      	(cmd_area_set_text_redo) : we need to manually queue a recalc for
      	  arrays now.
      	* src/sheet.c (sheet_cell_set_text) : we need to queue a recalc for
      	  both expressions and values now.
      	(sheet_range_set_text) : queue recalcs for the region as a block.
      	* src/graph-vector.c (graph_vector_new) : Just use dependent_link if
      	  we don't want a recalc.
  10. 24 May, 2001 1 commit
    • Jody Goldberg's avatar
      Revamp the recalc queue · af206304
      Jody Goldberg authored
      2001-05-22  Jody Goldberg <jgoldberg@home.com>
      	* gnumeric.spec.in : bump version of libole2
      	* README : ditto.
      	* configure.in : ditto.
      2001-05-19  Jody Goldberg <jgoldberg@home.com>
      	* src/workbook.c (workbook_is_pristine) : no need to check the recalc
      	  queue.  If there are no dependents there is nothing to put on the
      	  eval queue.
      	* src/func.c (cb_iterate_cellrange) : rename from
      	  iterate_cellrange_callback remove 'generation' mechanism.
      	* src/cell.c (cell_cleanout) : Clear both recalc flags,
      	  in_queue and needs
      	(cell_copy) : ditto.
      	(cell_eval_content) : No need to render the value.  assign_value
      	  already does it.
      	(cell_content_changed) : deleted.
      	* src/Makefile.am : merge dependent.[ch] into eval.[ch]
      2001-05-18  Jody Goldberg <jgoldberg@home.com>
      	* src/eval.c : reorg and merged with dependent.[ch]
      	* src/sheet.c (sheet_cell_set_text) :
      	(sheet_cell_set_expr) : ditto.
      	(sheet_cell_set_value) : ditto.
      	(colrow_move) : ditto.
      	(sheet_destroy_contents) :
      	* src/cmd-edit.c (cmd_select_cur_row) : Make behavior match XL.
      	(cmd_select_cur_col) : Make behavior match XL.
      	* src/format.c (render_number) : avoid temporaries.
      	(do_render_number) : ditto.
      2001-05-17  Jody Goldberg <jgoldberg@home.com>
      	* src/expr.c (eval_range) : delete.
      	(eval_expr_real) : Use workbook_foreach_cell_in_range rather than
      	  range_eval.  Remove 'generation' mechanism.
      	(cb_range_eval) : a simple pass through
      	* src/eval.c (sheet_region_recalc_deps) : rename from
      	  sheet_recalc_dependencies and merge in sheet_region_get_deps.
      	  Use the new foreach style interfaces.
      	(cb_single_recalc_all_depends) : rename from cb_single_get_all_depends
      	  and simplify.
      	(cb_range_recalc_all_depends) : rename from cb_sheet_get_all_depends and simplify.
      	(cb_dependent_queue_recalc) : new wrapper.
      	(cb_region_contained_depend) : renamed from search_range_deps and simplify.
      	(cell_foreach_dep) : rename from cell_get_dependencies and switch to
      	  an in place api rather than creating a list.
      	(cell_foreach_single_dep) : switch to in place api
      	(cell_foreach_range_dep) : ditto.
      	(search_cell_deps) : ditto.
      	(cell_recalc_deps) : ditto.
      	(cell_eval) : ditto.
      	(cb_generation_queue) : new utility.
      	* src/dependent.c (dependent_list_filter) : delete.
      	* src/cmd-edit.c (cb_collect_deps) : new function split from.
      	(cmd_select_cur_depends) : here. So that we can use the new depend
      	* src/sheet.c (sheet_move_range) : use sheet_region_recalc_deps.
      	(sheet_{insert,delete}_{cols,rows}) : ditto.
      	(sheet_cell_remove_simple) : Use in place depend interface.
      	* src/cell.c (cell_content_changed) : Use in place depend interface.
      	* src/clipboard.c (clipboard_paste_region) : ditto.
      	* src/commands.c (cmd_area_set_text_redo) : ditto.
      	(cmd_autofill_redo) : ditto.
      2001-05-21  Jody Goldberg <jgoldberg@home.com>
      	* Makefile.am : remove gnorba and modernize a bit.
  11. 22 May, 2001 1 commit
    • Almer S. Tigelaar's avatar
      Bump XML version number. (xml_workbook_write): Write index of sheet names · b89fa763
      Almer S. Tigelaar authored
      2001-05-22  Almer S. Tigelaar  <almer@gnome.org>
      	* src/xml-io.c : Bump XML version number.
      	(xml_workbook_write): Write index of sheet names
      	at the beginning of the file and always write
      	latest version number.
      2001-05-22  Almer S. Tigelaar  <almer@gnome.org>
      	* xml-sax-read.c (xml_sax_sheet_name): Don't create
      	sheet here.
      	(xml_sax_wb_sheetname): Create sheet here.
      	(xml_sax_finish_parse_wb_names_name): Fix workbook level
      	name reading.
      	(xml_sax_start_element): Handle new sheetnameindex.
      	(xml_sax_end_element): Idem.
      	(xml_sax_characters): Idem.
      	(xml_sax_wb): Small tweak for correct version reading.
  12. 21 May, 2001 1 commit
    • Chyla Zbigniew's avatar
      Cleaned up file i/o interface. · 33d35aa2
      Chyla Zbigniew authored
      Cleaned up file i/o interface.
      * src/Makefile.am: Added file-priv.h.
      * src/file.[ch]:
      Made GnumFileOpener and GnumFileSaver GtkObjects with virtual probe,
      open and save methods.
      New GnumFileOpener methods: get_id.
      New GnumFileSaver methods: get_id, fix_file_name.
      New functions: register_file_opener, register_file_opener_as_importer,
      unregister_file_opener, unregister_file_opener_as_importer,
      register_file_saver, register_file_saver_as_default,
      unregister_file_saver, get_default_file_saver,
      get_file_opener_by_id, get_file_saver_by_id,
      get_file_savers, get_file_openers, get_file_importers.
      * src/file-priv.h: New file with definitions of structs:
      _GnumFileOpener, _GnumFileOpenerClass, _GnumFileSaver,
      * src/workbook.h
      (struct _Workbook): Added file_saver_sig_id field.
      (workbook_get_file_saver): New accessor function.
      * src/workbook.c
      (cb_saver_destroy_event, workbook_destroy, workbook_set_saveinfo):
      When setting new file_saver, connect to its "destroy" signal and
      set file_saver to NULL in signal handler. Disconnect when changing file
      saver or destroying the workbook.
      (workbook_get_file_saver): New accessor function.
      * src/workbook-view.[ch]
      (wb_view_set_attributev): Renamed to wb_view_set_attribute_list and
      (wb_view_save_as, wb_view_save, wb_view_open, wb_view_open_custom): New
      methods (some code moved from file.c).
      * src/gnumeric-sheet.c (gnumeric_sheet_filenames_dropped):
      Use wb_view_open() instead of workbook_try_read()+file_finish_load().
      * src/gui-file.c
      (gui_file_import): Use get_file_importers(). Use
      wb_view_open_custom() instead of file_opener_open() + manual creation
      of wb_view, error checking, etc.
      (is_saver_registered): Removed.
      (saver_activate): Don't check if saver is really registered.
      (file_saver_is_default_format): Use get_default_file_saver() instead
      of strcmp(extension, "gnumeric") hack.
      (do_save_as): Use gnum_file_saver_fix_file_name().
      Adjusted everything to file.h, workbook.h, workbook-control.h.
      * src/gui-file.h (gui_file_import): Signature change, now function
      returns gboolean.
      * src/gutils.[ch] (g_list_index_custom): New function.
      * src/history.c (file_history_cmd), src/main.c (gnumeric_main),
      src/workbook-control-gui.c (cb_file_open): Use wb_view_open()
      instead of workbook_read().
      * src/workbook-control-gui-priv.h (struct _WorkbookControlGUI):
      * src/plugin-service
      Created GnumPluginFileOpener and GnumPluginFileSaver classes (derived
      from GnumFileOpener and GnumFileSaver respectively). Moved contents of
      plugin_service_file_saver_save_func into
      gnum_plugin_file_opener_probe, gnum_plugin_file_opener_open,
      gnum_plugin_file_saver_save methods (slightly modified).
      (plugin_service_file_opener_read): Read "open" and "import" attributes
      of <service> tag.
      plugin_service_file_opener_cleanup): Register/unregister created
      file opener (GnumPluginFileOpener object) as normal opener and/or
      importer depending on "open" and "import" XML attributes.
      plugin_service_file_opener_cleanup): Register/unregister created
      file saver (GnumPluginFileSaver object).
      * src/plugin-service.h
      (struct _PluginServiceFileOpener):
      Added can_open and can_import fields.
      (struct _PluginServiceFileSaver):
      * src/plugin-loader-module.c
      (struct ServiceLoaderDataFileOpener, struct ServiceLoaderDataFileSaver),
      * src/stf.c
      (stf_read_workbook, stf_write_workbook): Signature change
      (don't return gboolean).
      (stf_init): Adjusted to file i/o interface changes.
      (gnumeric_xml_get_opener, xml_probe):
      (gnumeric_xml_read_workbook, gnumeric_xml_write_workbook): Signature
      change (don't return gboolean).
      (xml_init): Adjusted to file i/o interface changes.
  13. 19 May, 2001 1 commit
  14. 14 May, 2001 1 commit
  15. 12 May, 2001 1 commit
    • Jody Goldberg's avatar
      add sheet_merge. (xml_sax_start_element) : add sheet_merge, and · eb7517d7
      Jody Goldberg authored
      2001-05-11  Jody Goldberg <jgoldberg@home.com>
      	* xml-sax-read.c (xml_sax_characters) : add sheet_merge.
      	(xml_sax_start_element) : add sheet_merge, and sheet_merged_regions.
      	(xml_sax_end_element) : call xml_sax_parse_merge.
      	(xml_sax_parse_merge) : new function.
      	(xml_sax_parse_sheet_end) : new function to set the zoom after the
      	(xml_sax_parse_sheet_start) : renamed from xml_sax_parse_sheet.
      	(xml_parse_sheet_zoom) : just store the zoom don't set till later.
      	(xml_sax_cols_rows) : new function.
      2001-05-10  Jody Goldberg <jgoldberg@home.com>
      	* xml-sax-read.c (xml_sax_parse_attr_bool) : new function.
      	(xmlSaxParseSheet) : use it here.
      	(xml_sax_parse_wb) : fix inverted cmp.
      	(xmlSaxParseSheet) : no sheet yet here.  Just store the prefs for
      	(xmlSaxParseSheet) : use any saved prefs.
      	(xml_sax_file_open) : typo.
      2001-05-11  Jody Goldberg <jgoldberg@home.com>
      	* src/application.c (application_real_time_auto_expr_recalc) : new
      	* src/sheet.c (auto_expr_timer_clear) : new function.
      	(sheet_update) : toggle the selection_content_changed flag here and
      	  use a timer rather than an idle handler.
      	* src/workbook-edit.c (wbcg_edit_ctor) : Init the sensitivity timer.
      	* src/workbook-control-gui.c (workbook_setup_edit_area) : Use
      	(wbcg_destroy) : use wbcg_edit_dtor.
      	* src/main.c (gnumeric_main) : setlocale (LC_ALL, NULL) to force
      	  initialization of LC_* from the environment.
  16. 10 May, 2001 1 commit
    • Jody Goldberg's avatar
      typo. Use the child not the parent node. (xml_write_selection_info) : Save · 35bb5752
      Jody Goldberg authored
      2001-05-09  Jody Goldberg <jgoldberg@home.com>
      	* src/xml-io.c (xml_read_selection_info) : typo.  Use the child not
      	  the parent node.
      	(xml_write_selection_info) : Save the real position.
      	* src/sheet.c (sheet_new_scg) : set cursor bound, not the details.
      	(sheet_cursor_set) : add some sanity checks.
      	(sheet_clone_selection) : use the real edit_pos.
  17. 09 May, 2001 1 commit
    • Jody Goldberg's avatar
      Round 3 of the great rangesel cursor cleanup · 79f8f44b
      Jody Goldberg authored
      Still some bugs but things are much closer
      2001-05-08  Jody Goldberg <jgoldberg@home.com>
      	* src/selection.c (sheet_selection_set_internal) : split this out into.
      	* src/sheet-merge.c (sheet_merge_find_container) : here.
      	* src/sheet-control-gui.c (scg_rangesel_changed) : and here.
      2001-05-08  Jody Goldberg <jgoldberg@home.com>
      	* src/xml-io.c (xml_read_selection_info) : Use sheet_set_edit_pos.
      	* src/selection.c (sheet_selection_extend) : merge into
      	* src/sheet-control-gui.c (scg_cursor_move_to) : rename from
      	(scg_cursor_extend) : merge scg_cursor_extend_[hv]
      	(scg_cursor_move) : merge scg_cursor_move_[hv]
      	(scg_rangesel_extend) : merge scg_rangesel_extend_[hv]
      	(scg_rangesel_move) : merge scg_rangesel_move_[hv]
      	(scg_rangesel_start) : cleanup.
      	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) : fix handling
      	  of Home. Simplify the function pointers for move vs extend by
      	  merging horizontal and vertical versions.
  18. 04 May, 2001 1 commit
    • Jody Goldberg's avatar
      s/clipboard_release/cellregion_free/ s/range_copy/range_dup/ · 32bde6ee
      Jody Goldberg authored
      2001-05-04  Jody Goldberg <jgoldberg@home.com>
      	* src/commands.c (cmd_autofill) : Use sheet_range_contains_region.
      	(cmd_autofill_redo) : no need to test here.
      	(cmd_paste_cut) : test destination for validity and ensure that it
      	  does not slice up any merged regions or arrays.  Make the descriptor
      	  an argument so that other commands can use this one.
      	(cmd_ins_del_colrow_redo) : use colrow_max.
      	(cmd_area_set_text_redo) : use sheet_ranges_split_region.
      	(cmd_colrow_outline_change) : suppress warning.
      	* src/gui-clipboard.c (x_selection_to_cell_region) : simplify by using
      	  some of the convenience routines.
      	* src/gutils.c (gnumeric_sys_data_dir) : warning suppression.
      	(gnumeric_sys_lib_dir) : ditto.
      	* src/item-bar.c (item_bar_draw) : add missing warning.
      	* src/item-cursor.c (item_cursor_drag_event) : Don't assume the
      	  release came from the button that started the grab (think about
      	  multiple simultaneous button downs.
      	(item_cursor_selection_event) : ditto.
      	(item_cursor_do_drop) : changes to selection_first_range.
      	* src/parse-util.c (col_name_internal) : new routine split from
      	  col_name with better buffer handling.
      	(col_name) : used here.
      	(cols_name) : and in this new function.
      	* src/print.c (sheet_print_selection) : changes to
      	* src/print-info.c (print_info_new) : default even_if_only_styles to
      	  false.  This is probably what most people want.
      	* src/ranges.c (range_translate) : don't invert.
      	(range_height) : new util.  could probably be #define.
      	(range_width) : new util.  could probably be #define.
      	(range_is_infinite) : use range_is_full.
      	(range_is_full) : new util.
      	* src/search.c (calculate_replacement) : warning suppression.
      	* src/selection.c (sheet_selection_cut) : Use
      	  sheet_range_splits_region and selection_first_range.
      	(sheet_selection_copy) : Use selection_first_range and remove TODO
      	  about supporting not paste by content for partial arrays.
      	(selection_first_range) : Add optional error reporting if there are
      	  multiple selection ranges.
      	* src/format.c (format_get_currency) : diddle the logic to get
      	  undefined to work the way people expect for locale C.
      	* src/sheet-merge.c (sheet_merge_relocate) : remove some dead code.
      	(sheet_merge_add) : changes to sheet_range_splits_array.
      	* src/sheet-object-widget.c (sheet_widget_checkbox_construct) :
      	  changes to selection_first_range.
      	* src/sheet.c (sheet_delete_{cols,rows}) : changes to
      	(sheet_insert_{cols,rows}) : use sheet_range_splits_array.
      	(avoid_dividing_array_vertical) : delete.
      	(avoid_dividing_array_horizontal) : delete.
      	(sheet_is_pristine) : constness.
      	(sheet_mark_clean) : delete.
      	(sheet_clear_region) : changes to sheet_range_splits_array.
      	(sheet_ranges_split_region) : renamed from selection_check_for_array.
      	(sheet_range_splits_region) : new routine to check arrays and merged
      	(sheet_range_splits_array) : improve and add hooks to be used for
      	  overlapping checks.
      	(cb_check_array_vertical) : report the array being split.
      	(cb_check_array_horizontal) : report the array being split.
      	* src/stf-parse.c (stf_parse_region) : use cellregion_new.
      	(stf_parse_is_valid_data) : simplify.
      	* src/value-sheet.c (value_area_get_width) : warning suppression.
      	(value_area_get_height) : warning suppression.
      	(value_area_fetch_x_y : signedness.
      	(value_area_get_x_y) : signedness.
      	* src/value.c (value_array_resize) : signedness.
      	(value_array_set) : signedness.
      	* src/workbook-control-gui.c (wbcg_error_splits_array) : signature
      	(cb_insert_rows) : use selection_first_range
      	(cb_insert_cols) : ditto.
      	(sort_cmd) : ditto.
      	(cb_workbook_debug_info) : clean out some deadwood.
      	* src/workbook-edit.c (auto_complete_matches) : warning suppression.
      	* src/workbook.c (workbook_sheet_detach) : warning suppression.
      	(g_ptr_array_insert) : warning suppression, moved to gutils.
      	* src/xml-io.c (xml_write_attributes) : warning suppression.
      	(xml_read_selection_clipboard) : use cellregion_new and tidyup.
      	* src/clipboard.c (paste_link) : Only make the link sheet specific if
      	  we need to.
      	(clipboard_paste_region) : constness, support being able to paste
      	  content only as link or value.
      	(clipboard_prepend_cell) : check for arrays.
      	(clipboard_copy_range) : use cellregion_new
      	(cellregion_new) : new function
      	(cellregion_free) : renamed from clipboard_release.
      	(cellregion_to_string) : moved here from render-ascii.
      	src/cmd-edit.c (cmd_paste) : more protection. Merge in
      	(cmd_paste_to_selection) : handle changes to selection_is_simple and
      	  use selection_first_range
      	(cmd_shift_rows) : changes to cmd_paste_cut.
      	(cmd_shift_cols) : ditto.
      	* src/command-context-priv.h : change signature of splits array.
      	* src/command-context.h : ditto.
      	* src/command-context.c (gnumeric_error_splits_array) : ditto.
      	* src/application.c (application_clipboard_clear) :
      	(application_set_selected_sheet) : remove #warning, it is not portable.
      	* src/commands.c
      	* src/Makefile.am : remove render-ascii.[ch]  Move their content into
      2001-05-01  Jody Goldberg <jgoldberg@home.com>
      	* src/clipboard.c (clipboard_prepend_cell) : remove ugly
      	* src/workbook-edit.c (auto_complete_matches) : remove warning.
      	* src/xml-io.c (xml_write_attributes) : remove warning.
  19. 26 Apr, 2001 2 commits
    • Jody Goldberg's avatar
      Move the #define wrapper out here. · a0aaf6ad
      Jody Goldberg authored
      2001-04-26  Jody Goldberg <jgoldberg@home.com>
      	* src/mathfunc.h (FINITE) : Move the #define wrapper out here.
      	* src/cell.c : prune some includes
      	(cell_default_halign) : rename to
      	* src/style.c (style_default_halign) : to simplify headers for systems
      	  that do not support fwd declarations of enums. H - cough - PUX
    • Jody Goldberg's avatar
      Add a horizontal merge before dumping to a list. (cb_hash_to_list) : free · 0088cc12
      Jody Goldberg authored
      2001-04-25  Jody Goldberg <jgoldberg@home.com>
      	* src/sheet-style.c (sheet_style_get_list) : Add a horizontal merge
      	  before dumping to a list.
      	(cb_hash_to_list) : free elements that have been merged in the
      	  horizonal step, but have not yet been removed.
      	(cb_hash_merge_horiz) : new function. merge when possible, after a
      	  merge either free the useless bit or mark it as useless for later
      	(cb_style_list_add_node) : Use mstyle_equal for now to remerge
      	  different instances of the same logical style.  This is necessary
      	  until I finish the per sheet style index.
      	(sheet_style_init) : add some sanity checks incase some bright boy
      	  decides to up the size of sheet and forgets here.
      	* src/xml-io.c (xml_sheet_write) : Add the properties for the
      	  outline mode preferences.
      	(xml_sheet_read) : ditto.
      	* src/item-debug.h : fix the messages to include the module
      	* src/item-bar.c : fix the item-debug grab/ungrab messages.
      	(item_bar_update) : gnome_canvas_group_child_bounds is a deprecated
      	  useless call.
      	* src/item-edit.c : fix the item-debug grab/ungrab messages.
      	(recalc_spans) : gnome_canvas_group_child_bounds is a deprecated
      	  useless call.
      	* src/item-grid.c : fix the item-debug grab/ungrab messages.
      	(item_grid_update) : gnome_canvas_group_child_bounds is a deprecated
      	  useless call.
      	(item_grid_button_1) : If we are going to start selecting a range have
      	  the grid to a grab on button down.  This should fix the pseudo-race
      	  condition that was irritating the ExprEntry.
      	* src/preview-grid.c (preview_grid_update) :
      	  gnome_canvas_group_child_bounds is a deprecated useless call.
      	* src/item-cursor.c : fix the item-debug grab/ungrab messages.
      	(item_cursor_point) : animated cursors should never receive events.
      	* src/cell-draw.c (cell_draw) : It is perfectly reasonable for
      	  narrow/short cols/rows to produce cells that have negative sizes
      	  with the margins removed.  exit silently.
  20. 23 Apr, 2001 2 commits
    • Morten Welinder's avatar
      Read styles right for V1. · 0e514f5c
      Morten Welinder authored
    • Almer S. Tigelaar's avatar
      Give focus to the edit line when an error is encountered. Don't store the · 78d888e3
      Almer S. Tigelaar authored
      2001-04-23  Almer S. Tigelaar  <almer@gnome.org>
      	* src/workbook-edit.c (workbook_finish_editing): Give focus
      	to the edit line when an error is encountered.
      	* src/workbook-control-gui.c
      	(wbcg_close_control) : Don't store the partially entered expression
      	when we are going to close.
      	(cb_file_quit) : Idem.
      	(cb_notebook_switch_page) : Idem, for switching between tabs
      	when we are _not_ in a subexpression.
      	* src/parser.y : Correct off-by-one glitches and strtod exponent
      	out of range error problem.
      	* src/expr.[ch] (expr_parse_string): Use a ParseError struct
      	instead of an error string.
      	* src/commands.c (cmd_area_set_text_redo): Use expr_parse_string
      	in the newly corrected fashion.
      	* src/expr-name.c (expr_name_create): Idem, require a ParseError
      	struct to be passed instead of a char** aswell.
      	* src/parse-util.c (parse_text_value_or_expr): Idem.
      	* src/sheet-object-widget.c (cb_checkbox_config_clicked): Idem.
      	* src/test-parser.c (main): Idem.
      	* src/xml-io.c (xml_cell_set_array_expr): Idem.
      	* src/sheet.c (sheet_clone_names): Use expr_name_create which now
      	uses ParseError instead of char **.
      	* src/xml-io.c (xml_read_names): Idem.
      2001-04-23  Almer S. Tigelaar  <almer@gnome.org>
      	* dialog-define-names.c (cb_name_guru_add):
      	Correct use of expr_parse_string.
  21. 13 Apr, 2001 1 commit
    • Jody Goldberg's avatar
      rename gnumeric.xml GNOME_Gnumeric.xml. · e15d0a2c
      Jody Goldberg authored
      2001-04-12  Jody Goldberg <jgoldberg@home.com>
      	* src/Makefile.am : rename gnumeric.xml GNOME_Gnumeric.xml.
      	* src/sheet.c (sheet_col_add) : update the max outline_level.
      	(sheet_row_add) : ditto.
      	* src/xml-io.c (xml_read_colrow_info) : restore the col/row outline
      	  level data.
      	(xml_write_colrow_info) : store it here.
  22. 17 Mar, 2001 1 commit
    • Jody Goldberg's avatar
      Handle outline mode. (ms_excel_read_colinfo) : ditto. (ms_excel_read_guts) · e1a87d5f
      Jody Goldberg authored
      2001-03-15  Jody Goldberg <jgoldberg@home.com>
      	* ms-excel-read.c (ms_excel_read_row) : Handle outline mode.
      	(ms_excel_read_colinfo) : ditto.
      	(ms_excel_read_guts) : ditto.
      2001-03-16  Jody Goldberg <jgoldberg@home.com>
      	* src/item-bar.c (item_bar_calc_size) : rename from
      	* src/sheet-control-gui.c (scg_set_zoom_factor) : prepare for panes by
      	  zooming the col/row header canvases.  We need this as we transition
      	  to using gnumeric-sheets instead of canvases to hold the item-bars.
      2001-03-15  Jody Goldberg <jgoldberg@home.com>
      	* src/colrow.c (colrow_equal) : handle outline&collapse.
      	(colrow_copy) : ditto.
      	* src/item-bar.c (outline_button_press) : new function.
      	(item_bar_event) : used here.
      2001-03-15  Jody Goldberg <jgoldberg@home.com>
      	* src/item-bar.c (compute_pixels_from_pts) : new function.
      	(item_bar_fonts_init) : resize the indent gutters based on the zoom.
      	(item_bar_realize) : add another gc for outline drawing.
      	(item_bar_unrealize) : ditto.
      	(item_bar_draw) : implement drawing for groupings.
      	(set_cursor) : handle cursor in the presence of groupings.
      2001-03-14  Jody Goldberg <jgoldberg@home.com>
      	* Makefile.am : update the handling of the oaf file.
      	* src/sheet.c (sheet_col_row_default_calc) : rename from
      2001-03-13  Jody Goldberg <jgoldberg@home.com>
      	* src/xml-io.c (xml_write_print_repeat_range) : PrintRepeatRange now
      	  uses a simple Range.
      	(xml_read_print_repeat_range) : ditto.
      	* src/print-info.c (print_info_new) : ditto.
      	(save_range) : Ditto.
      	* src/dialogs/dialog-printer-setup.c (do_fetch_page_info) : ditto.
      	* src/print.c (print_range_used_units) : ditto.
      	(print_range_right_then_down) : ditto.
      	(print_range_down_then_right) : ditto.
      	(print_page_repeated_intersect) : ditto.
      	(print_page_repeated_cols) : ditto.
      	(print_page_repeated_rows) : ditto.
      	(print_page) : ditto.
      	* src/sheet-control-gui.c (scg_set_zoom_factor) : The sizing has moved
      	  into the itembar.
      	* src/item-bar.c : s/orientation/is_col_header/
      	(item_bar_fonts_init) : Init the ideal cell size.
      	(item_bar_update) : Begin to support grouping.
      	(item_bar_draw) : ditto.
      	(item_bar_init) : init the new members.
      	* src/print-cell.c (print_cell) : re-enable halign FILL.
      	* src/cell-draw.c (cell_draw) : ditto.
  23. 09 Mar, 2001 1 commit
  24. 08 Mar, 2001 1 commit
    • Jody Goldberg's avatar
      make units case sensitive. · 21c220c2
      Jody Goldberg authored
      2001-03-08  Jody Goldberg <jgoldberg@home.com>
      	* src/xml-io.c (xml_get_print_unit) : make units case sensitive.
  25. 24 Feb, 2001 1 commit
    • Chyla Zbigniew's avatar
      Added files: plugin-service.[ch], plugin-loader.[ch], · a924975e
      Chyla Zbigniew authored
      * src/Makefile.am: Added files:  plugin-service.[ch],
      plugin-loader.[ch], plugin-loader-module.[ch], module-plugin-defs.h.
      * src/error-info.[ch] (error_info_new_from_errno): New function.
      * src/file.c
      (struct _FileOpener, struct _FileSaver): Moved from file.h
      (file_opener_get_format_description, file_opener_has_probe,
      file_saver_get_extension,  file_saver_get_format_description):
      New accessor functions.
      (file_opener_probe, file_opener_open, file_saver_save,
      file_opener_set_user_data, file_opener_get_user_data,
      file_saver_set_user_data, file_saver_get_user_data): New
      (get_file_opener_by_id, get_file_saver_by_id): Removed
      Now using FileOpener*/FileSaver* instead of FileOpenerId/FileSaverId
      * src/file.h
      (struct _FileOpener, struct _FileSaver): Moved to file.c.
      Adjusted to file.c.
      * src/gui-file.c: Adjusted to file.[ch], now FileSaver.extension
      field should contain real extension (without a dot).
      * src/func.[ch]
      (enum FunctionFlags, struct _FunctionDefinition): Moved from func.h
      to func.c.
      (struct _FunctionCategory): Added "internal_name" and "display_name"
      in place of "name" field.
      function_category_remove_func, func_get_ref_count, function_remove,
      function_add_name_only): New functions.
      Now it's possible to load function implementation on demand (after
      registering function using function_add_name_only() and providing
      function of type FunctionGetFullInfoCallback).
      Rename fd and fndef to fn_def for consistency.
      * src/functions/fn-database.c (database_functions_init),
      src/functions/fn-date.c (date_functions_init),
      src/functions/fn-eng.c (eng_functions_init),
      src/functions/fn-financial.c (finance_functions_init),
      src/functions/fn-information.c (information_functions_init),
      src/functions/fn-logical.c (logical_functions_init),
      src/functions/fn-lookup.c (lookup_functions_init),
      src/functions/fn-math.c (math_functions_init),
      src/functions/fn-sheet.c (sheet_functions_init),
      src/functions/fn-stat.c (stat_functions_init),
      src/functions/fn-string.c (string_functions_init):
      Use function_get_category_with_translation, instead of
      * src/plugin.[ch]
      (struct _PluginInfo): Removed many fields.
      Just call gnumeric_plugin_loader_get_extra_info_list.
      (plugin_info_peek_services_data, plugin_info_peek_loader_type_str):
      New accessor functions.
      (plugin_info_read_service_list, plugin_info_read_loader,
      Read services and loader info, use functions from
      gal/util/e-xml-utils.h everywhere.
      (activate_plugin, deactivate_plugin): Just activate/deactivate all
      plugin services.
      (plugin_can_deactivate): Ask plugin services.
      (plugin_load_service, plugin_unload_service,
      plugin_loader_register_type, plugin_loader_register_id_only,
      plugin_loader_get_by_id, plugin_loader_is_available_by_id,
      New functions.
      (plugin_db_activate_plugin_list): Activate plugins in correct order,
      using plugin_list_sort_by_dependency function.
      (plugin_info_print): Removed.
      (module_plugin_print_info, module_plugin_info_get_extra_info_list,
      module_plugin_free, module_plugin_info_read, module_plugin_activate,
      module_plugin_deactivate, module_plugin_can_deactivate): Removed,
      most code  moved to plugin-loader.c and plugin-loader-module.c.
      * src/plugin-service.[ch]: New files, support for plugin services
      (five types of these so far).
      * src/plugin-loader.[ch]: New files, base class for plugin loaders.
      * src/plugin-loader-module.[ch]: New files, support for "g_module"
      * src/plugin-util.[ch] (gnumeric_fopen_error_info,
      gnumeric_open_error_info, gnumeric_mmap_error_info): New functions.
      * src/gutils.[ch] (g_list_free_custom, g_slist_free_custom,
      gnumeric_time_counter_push, gnumeric_time_counter_pop):
      New functions.
      * src/io-context-priv.h (struct _IOContext): Added error_info field.
      * src/io-context.[ch] (gnumeric_io_context_new,
      gnumeric_io_context_free, gnumeric_io_error_info_set,
      gnumeric_io_error_info_push, gnumeric_io_error_info_pop,
      gnumeric_io_error_info_clear, gnumeric_io_error_info_display,
      gnumeric_io_has_error_info): New functions, quick hack to add
      support for ErrorInfo.
      * src/module-plugin-defs.h: New file, should be included be every
      g_module plugin.
      * src/auto-format.c: Use accessor function from func.h.
      * src/bonobo-io.c (gnumeric_bonobo_write_workbook,
      gnumeric_bonobo_read_workbook, gnumeric_bonobo_io_probe),
      src/stf.c (stf_read_workbook, stf_write_workbook),
      src/xml-io.[ch] (xml_probe, gnumeric_xml_read_workbook,
      Signature changes.
      * src/workbook.c: Adjusted to
      workbook_load_from/gnumeric_xml_write_workbook signature change.
      * src/dialogs/dialog-function-select.c: Adjust to func.[ch].
      * src/dialogs/dialog-plugin-manager.c
      Adjust to plugin.[ch].
      (cb_pm_button_activate_plugin_clicked): Check if loader for current
      plugin is available, suggest activating loader plugin otherwise.
  26. 20 Feb, 2001 2 commits
    • Jody Goldberg's avatar
      I/O for indent. · 5a5c1c75
      Jody Goldberg authored
      2001-02-20  Jody Goldberg <jgoldberg@home.com>
      	* src/xml-io.c (xml_write_style) : store indent.
      	(xml_read_style) : restore indent.
    • Jon K Hellan's avatar
      Add level FILE_FL_MANUAL_REMEMBER. Fix typos: FILE_SAVER_ID_INVAID -> · caa620c4
      Jon K Hellan authored
      2001-02-19  Jon K Hellan  <hellan@acm.org>
      	* src/file.h: Add level FILE_FL_MANUAL_REMEMBER. Fix typos:
      	* src/file.c (file_format_register_open): Fix typo:
      	(file_format_register_save): Fix typo: FILE_OPENER_ID_INVAID ->
      	(cb_unregister_save, workbook_save): Fix
      	* src/workbook.c (workbook_destroy): Only include in history is
      	file_format_level >= FILE_FL_MANUAL_REMEMBER.
      	(workbook_new, workbook_set_saveinfo): Fix typo:
      	* src/xml-io.c: Fix typos: FILE_SAVER_ID_INVAID ->
      	* plugins/applix/boot.c (applix_load): Change file format level to
      	* plugins/excel/boot.c (excel_load, excel_init): Change file
      	format level to FILE_FL_MANUAL_REMEMBER.
      	* plugins/lotus/boot.c (lotus_load): Change file format level to
      	* plugins/oleo/boot.c (oleo_load): Change file format level to
      	* plugins/plan-perfect/pln.c (pln_read_workbook): Fix typo:
      	* plugins/sc/sc.c (sc_read_workbook): Fix typo:
      	* plugins/sylk/sylk.c (sylk_read_workbook): Change file format
      	* plugins/xbase/boot.c (xbase_load): Change file format level to
      	* plugins/xml2/xml2.c (xml2_open): Change file format level to
  27. 18 Feb, 2001 2 commits
    • Jody Goldberg's avatar
      s/display_zero/hide_zero/ + necessary logic inversions · a8dc5b30
      Jody Goldberg authored
      2001-02-18  Jody Goldberg <jgoldberg@home.com>
      	s/display_zero/hide_zero/		+ necessary logic inversions
      	s/show_grid/hide_grid/			+ necessary logic inversions
      	s/show_col_header/hide_col_header/	+ necessary logic inversions
      	s/show_row_header/hide_row_header/	+ necessary logic inversions
      	* src/workbook-format-toolbar.c (workbook_format_toolbutton_update) :
      	  Simplfy and use wbcg::updating_ui.
      	(workbook_format_halign_feedback_set) : use simplified interface.
      	(workbook_feedback_set) : Ditto.
      	(set_selection_halign) : If the current alignment is already set to
      	  the target type revert to general.
      	* src/preview-grid.c (preview_grid_draw) : cell_draw::h_center
      	  will default to width / 2.
      	* src/item-grid.c (item_grid_draw_merged_range) : Ditto.
      	(item_grid_draw) : Ditto.
      	* src/print-cell.c (print_cell) : print_cell::h_center
      	  will default to width / 2.
      	(print_merged_range) : Ditto.
      	(print_cell_range) : Ditto.
      	* src/sheet.c (sheet_adjust_preferences) : Update the menus to reflect
      	  changes in prefs.  Take a flag to control redraw requests.
      	(sheet_menu_state_enable_insert) : new function.
      	* src/workbook-control-gui.c (wbcg_menu_state_enable_insert) : Merge
      	  all the insert col/row/cell menu updates into here.
      	(wbcg_menu_state_sheet_prefs) : new function.
      	(cb_sheet_pref_display_formulas) : reentrancy protection and use
      	(cb_sheet_pref_hide_zeros) : ditto.
      	(cb_sheet_pref_hide_grid_lines) : ditto.
      	(cb_sheet_pref_hide_col_header) : ditto.
      	(cb_sheet_pref_hide_row_header) : ditto.
      	(workbook_control_gui_init) : add the new menu items.
      	(workbook_control_gui_ctor_class) : reorg a bit.
      	src/workbook-control.c : reorg a bit.
      2001-02-18  Jody Goldberg <jgoldberg@home.com>
      	* configure.in : Make python plugin optional.
      2001-02-18  Jody Goldberg <jgoldberg@home.com>
      	* src/workbook-control.c (wb_control_sheet_add) : update menus here.
      	* src/print-cell.c (print_cell) : fix the display zero logic.
      	* src/cell-draw.c (cell_draw) : ditto.  And fix the comment.
      2001-02-18  Jody Goldberg <jgoldberg@home.com>
      	* src/cell.c (cell_default_halign) : Handle alignment of numbers
      	  correctly when displaying formulas.
      	* src/embeddable-grid.c (set_header_visibility) : start using our
      	  native MVC.
      	(Grid_set_header_visibility) : ditto.
      	(embeddable_grid_set_header_visibility) : delete.
      	* src/sheet-control-gui.c (scg_set_header_visibility) : delete.
      	(scg_adjust_preferences) : Make this contingent on having a wbcg.
      	* src/selection.c (sheet_selection_set_internal) : Use
      	(sheet_selection_reset) : ditto.
    • Jody Goldberg's avatar
      Save and restore sheet preference flags. · 0f28b58e
      Jody Goldberg authored
      This has demonstrated that the MVC code has not extented to these flags yet.
      2001-02-17  Jody Goldberg <jgoldberg@home.com>
      	* src/xml-io.c (xml_sheet_write) : Store some flags about the sheet.
      	(xml_sheet_read) : Restore them.
  28. 17 Feb, 2001 2 commits
    • Jody Goldberg's avatar
      fix typo. · 520b0a41
      Jody Goldberg authored
      2001-02-17  Jody Goldberg <jgoldberg@home.com>
      	* src/print.c (print_page) : fix typo.
      	* src/xml-io.c (xml_read_style) : Before version 1 and after version 6
      	  we stored full styles.  Be sure the create a default style as a
      	  backward compatibility measure incase we add elements to styles in
      	  the future.
    • Jody Goldberg's avatar
      Use some code from expr.c to simplify binary/unary output and to add · e0f71b51
      Jody Goldberg authored
      2001-02-16  Jody Goldberg <jgoldberg@home.com>
      	* ms-formula-write.c (write_node) : Use some code from expr.c
      	  to simplify binary/unary output and to add parens when necessary.
      	* ms-excel-write.c (write_formula) : Start at paren level 0.
      	(write_names) : ditto.
      2001-02-16  Jody Goldberg <jgoldberg@home.com>
      	* src/dialogs/dialog-cell-format.c (fmt_dialog_init_align_page) :
      	  begin support for indenting.
      	* src/workbook-format-toolbar.c : ditto.
      2001-02-16  Jody Goldberg <jgoldberg@home.com>
      	* configure.in : post release version bump
      2001-02-15  Jody Goldberg <jgoldberg@home.com>
      	* s/fit_in_cell/wrap_text/
      	rename this in preparation for supporting shrink_to_fit
  29. 16 Feb, 2001 1 commit
    • Jody Goldberg's avatar
      Use even_if_only_styles. (print_page) : Ditto. (print_sheet) : Ditto. · f5b71727
      Jody Goldberg authored
      2001-02-15  Jody Goldberg <jgoldberg@home.com>
      	* src/print.c (compute_sheet_pages) : Use even_if_only_styles.
      	(print_page) : Ditto.
      	(print_sheet) : Ditto.
      	* src/xml-io.c (xml_write_print_info) : Support 'even_if_only_styles'
      	(xml_read_print_info) : Ditto.
      	* src/dialogs/dialog-printer-setup.c (do_fetch_page_info) : ditto.
      	(do_setup_page_info) : Ditto.
      	* src/print-info.c (print_info_copy) : ditto.
      	(print_info_new) : ditto.
      	(print_info_save) : ditto.
  30. 15 Feb, 2001 1 commit
    • Jody Goldberg's avatar
      off by one error. Ditto. (xml_read_style_border) : ditto. · 34d9ed4b
      Jody Goldberg authored
      2001-02-15  Jody Goldberg <jgoldberg@home.com>
      	* src/mstyle.c (mstyle_visible_in_blank) : off by one error.
      	* src/xml-io.c (xml_write_style_border) : Ditto.
      	(xml_read_style_border) : ditto.
      	* src/rendered-value.c (rendered_value_calc_size_ext) : calculate the
      	  indent offsets.
  31. 14 Feb, 2001 1 commit
  32. 10 Feb, 2001 1 commit
    • Jon Kåre Hellan's avatar
      Illustrate margin definitions. (print_headers): Header, not top margin, · 9c2b76bc
      Jon Kåre Hellan authored
      * src/print.c: Illustrate margin definitions.
      (print_headers): Header, not top margin, should be top of header
      (print_footers): Footer, not bottom margin, should be top of
      footer area.
      * src/xml-io.c (xml_print_info_fix_margins): New function fix up
      incorrectly stored margins.
      (xml_read_print_margins): Use it.
      * src/dialogs/dialog-printer-setup.c (do_fetch_margins,
      do_setup_margin): Header, not top margin, should be top of header area
      and footer, not bottom margin, should be top of footer area.
      * plugins/excel/ms-excel-read.c (ms_excel_init_margins): New
      function. Initialize margins to Excel defaults.  (ms_excel_sheet_new):
      Call ms_excel_init_margins.
      * plugins/excel/ms-excel-write.c (write_sheet_bools): Write margins
      also for biff 7 (which is what we actually use).
  33. 04 Feb, 2001 1 commit
    • Jody Goldberg's avatar
      Fix some typos · 870c9d3e
      Jody Goldberg authored
      2001-02-03  Jody Goldberg <jgoldberg@home.com>
      	* src/xml-io.c (xml_workbook_read) : bump xml version to 6.
      	(xml_read_style_region) : V6 uses set_range rather than the older
      	  apply_range.  We now save/restore fully qualified styles.
  34. 02 Feb, 2001 1 commit
    • Jody Goldberg's avatar
      Init CellRegion::merged. Ditto. Ditto. · 96291ef4
      Jody Goldberg authored
      2001-02-02  Jody Goldberg <jgoldberg@home.com>
      	* src/gui-clipboard.c (x_selection_to_cell_region) : Init
      	* src/stf-parse.c (stf_parse_region) : Ditto.
      	* src/xml-io.c (xml_read_selection_clipboard) : Ditto.