GitLab

2001-04-16  Jody Goldberg <jgoldberg@home.com>

	* configure.in : bump GAL version reqs.

	* src/workbook-format-toolbar.c (workbook_create_format_toolbar) :
	  Jump to updated interface.  Partially fix the shared group problems.

2001-04-15  Almer S. Tigelaar  <almer@gnome.org>

        * src/item-grid.c : Within all functions
        where the ItemGrid is a variable, s/item_grid/ig,
        s/grid/ig.

2001-04-15  Jody Goldberg <jgoldberg@home.com>

	* src/item-grid.c (item_grid_draw) : Hide merged cells.
	(item_grid_draw_merged_range) : calculate the size the same way we do
	  it in cell_draw.

2001-04-15  Jody Goldberg <jgoldberg@home.com>

	* src/workbook-control-gui.c (wbcg_finish_editing) : new virtual
	(workbook_control_gui_ctor_class) : connect it here.
	(wbcg_sheet_remove_all) : be sure we are no longer editing.

	* src/workbook-control-priv.h : new virtual.
	* src/workbook-control.c : ditto.
	* src/workbook-control.h : ditto.

	* src/colrow.c (colrow_visibility) : One last potential NULL.

	* src/graph-vector.c : some portability fixes.

2001-04-15  Almer S. Tigelaar  <almer@gnome.org>

	* src/parser.y : Add detailed parser error messages.

	* src/workbook-edit.c (workbook_finish_editing) : Abort
	if the expression is invalid and return a boolean indicating
	success or failure.

	* src/expr.c (expr_parse_string): Set error message to the
	result of gnumeric_expr_parser.

	* src/parse-util.c (parse_error_init) : Properly initialize
	begin and end character.

	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet): Don't
	change the cursor position if workbook_finish_editing failed.
	(move_cursor): Idem.

	* src/item-grid.c (item_grid_button_1): Idem.

2001-04-15  Almer S. Tigelaar  <almer@gnome.org>

	* src/preview-grid.c
	(preview_grid_realize) : Remove grid gc.
	(preview_grid_unrealize) : Idem.

	* src/item-grid.c
	(item_grid_realize) : Use gc.fill, gc.cell
	and gc.empty instead of fill_gc, etc.
	(item_grid_unrealize) : Idem.
	(item_grid_draw_merged_range) : Idem.
	(item_grid_draw_background) : Idem.
	(item_grid_draw) : Idem.

2001-04-15  Almer S. Tigelaar  <almer@gnome.org>

	* src/preview-grid-controller.c,
	src/preview-grid-controller.h : Remove entirely, the
	preview-grid-controller abstraction is no longer
	needed.

2001-04-15  Almer S. Tigelaar  <almer@gnome.org>

	* src/preview-grid.c (pgrid_get_style) : Calls upon
	cb_cell_get_style, if NULL use default.
	(pg_get_row_height) : Retrieve row height.
	(pg_get_col_width) : Retrieve col width.
	(pg_get_row_offset) : Get offset of row.
	(pg_get_col_offset) : Get offset of column.
	(pg_construct_cell) : Construct a cell from a value.
	(pg_destruct_cell) : Destruct a cell.
	(preview_grid_realize) : Initialize default mstyle.
	(preview_grid_unrealize) : Free default mstyle.
	(preview_grid_set_arg) : Add support for row height and col
	width.
	(pg_style_get_row) : Use pg_* routines.
	(preview_grid_draw) : Idem.

2001-04-14  Almer S. Tigelaar  <almer@gnome.org>

	Reverted this

	* src/commands.c (cmd_paste_cut) : Init saved_sizes.
	(cmd_paste_cut_destroy) : Free saved_sizes.
	(cmd_paste_cut_redo) : Store saved_sizes and don't allow
	shrinking when autofitting row heights.
	(cmd_paste_cut_undo) : Restore saved_sizes.
	(cmd_paste_copy_undo) : Store/Restore saved_sizes, don't
	set PASTE_UPDATE_ROW_HEIGHT flag. It's been removed. Also,
	don't allow shrinking when autofitting row heights.
	(cmd_paste_copy_destroy) : Free saved_sizes.
	(cmd_paste_copy) : Init saved_sizes.
	(cmd_format_undo) : Allow shrink when autofitting row heights.
	(cmd_autoformat_undo) : Idem.

	* src/sheet.c (sheet_apply_style) : Allow shrink when autofitting
	row heights.
	(sheet_clear_region) : Idem.

	* src/clipboard.c (clipboard_paste_region) : Remove the
	PASTE_UPDATE_ROW_HEIGHT flag.

	* src/colrow.c :
	(rows_height_update) : Add an extra flag allow_shrink, if set rows
	will be autofitted even if this means that the size of the row must
	be reduced.
	(cb_autofit_height) : Add support for allow_shrink.

2001-04-14  Almer S. Tigelaar  <almer@gnome.org>

	* src/commands.c (cmd_paste_cut) : Init saved_sizes.
	(cmd_paste_cut_destroy) : Free saved_sizes.
	(cmd_paste_cut_redo) : Store saved_sizes and don't allow
	shrinking when autofitting row heights.
	(cmd_paste_cut_undo) : Restore saved_sizes.
	(cmd_paste_copy_undo) : Store/Restore saved_sizes, don't
	set PASTE_UPDATE_ROW_HEIGHT flag. It's been removed. Also,
	don't allow shrinking when autofitting row heights.
	(cmd_paste_copy_destroy) : Free saved_sizes.
	(cmd_paste_copy) : Init saved_sizes.
	(cmd_format_undo) : Allow shrink when autofitting row heights.
	(cmd_autoformat_undo) : Idem.

	* src/sheet.c (sheet_apply_style) : Allow shrink when autofitting
	row heights.
	(sheet_clear_region) : Idem.

	* src/clipboard.c (clipboard_paste_region) : Remove the
	PASTE_UPDATE_ROW_HEIGHT flag.

	* src/colrow.c :
	(rows_height_update) : Add an extra flag allow_shrink, if set rows
	will be autofitted even if this means that the size of the row must
	be reduced.
	(cb_autofit_height) : Add support for allow_shrink.

2001-04-13  Jody Goldberg <jgoldberg@home.com>

	* idl/Makefile.am (dist-hook) : automate removing the generated files.

	* src/workbook-control-gui.c (workbook_menu_data_outline) : new menu.

2001-04-13  Jon K Hellan  <hellan@acm.org>

	* src/workbook-control-gui.c (workbook_control_gui_init): Use
	gtk_idle_add to postpone clipboard setup. For mysterious reasons,
	connecting callbacks to the table doesn't work. Toplevel does
	work, but we must wait until we live inside a toplevel.

	* src/gui-clipboard.c (x_selection_received,
	x_clipboard_bind_workbook): Use wb_control_gui_toplevel to
	determine toplevel.

	* src/gui-clipboard.[ch] (x_clipboard_bind_workbook): Change
	signature to make it callable as an idle function. Make it
	determine the toplevel from

2001-04-13  Jody Goldberg <jgoldberg@home.com>

	* src/style.c (font_init) : rename fontmap -> fontmap2 for newer
	  versions of gnome-print.

2001-04-12  Jody Goldberg <jgoldberg@home.com>

	* src/Makefile.am : rename gnumeric.xml GNOME_Gnumeric.xml.

	* src/sheet.c (sheet_col_add) : update the max outline_level.
	(sheet_row_add) : ditto.

	* src/xml-io.c (xml_read_colrow_info) : restore the col/row outline
	  level data.
	(xml_write_colrow_info) : store it here.

2001-04-12  Jody Goldberg <jgoldberg@home.com>

	* src/colrow.c (colrow_set_visibility) : don't collapse things unless
	  they are at the end of the region.  Always uncollapse things.

2001-04-11  Jody Goldberg <jgoldberg@home.com>

	* src/item-bar.c (item_bar_draw) : tweak the redraw a bit to match
	  event handling

	* src/mstyle.c (mstyle_elements_equal) : remove pointless asserts and
	  correct the logic.
	(mstyle_element_equal) : Stop passing structs.
	(mstyle_elements_equal) : adjust here.
	(mstyle_elements_compare) : and here.

2001-04-12  Jody Goldberg <jgoldberg@home.com>

	* src/colrow.c (colrow_set_visibility) : collapse state changes can
	  occur more than once within a range.

	* src/sheet.c (sheet_col_row_gutter_pts) : simplify, no need to store
	  sizes in pts.  Outline level is enough.
	  s/sheet_col_row_gutter_pts/sheet_col_row_gutter/

2001-04-12  Jody Goldberg <jgoldberg@home.com>

	* src/commands.c (cmd_paste_copy_undo) : Make the corner of the
	  restored region visible.
	(cmd_autofill_undo) : Ditto.
	(cmd_autofill_redo) : Ditto.

2001-04-10  Jody Goldberg <jgoldberg@home.com>

	* src/cellspan.c (cell_calc_span) : fix chema's spanning problem.

	* src/workbook-control-gui.c (workbook_menu_data) : Add an icon for
	  the sort menu item.

2001-04-9  Jody Goldberg <jgoldberg@home.com>

	s/cmd_hide_selection_colrow/cmd_colrow_hide_selection/

	* src/commands.c (cmd_colrow_outline_change) : new wrapper for
	  colrow_hide that handled outline changes.

	* src/workbook-control-gui.c (cb_insert_{cols,rows}) : cancel edit.
	(cb_select_auto_expr) : return a value.

	* src/colrow.c (cb_col_row_visibility) : Use get rather than fetch.
	(colrow_find_outline_bound) : new function.
	(cb_colrow_visibility) : turn this into a wrapper for.
	(colrow_visibility) : this, and add honour_collapse flag.
	  invert the search to go fro mthe end to the start in preparation for
	  supporting the honour_collapse flag.  Insert the items into a sorted
	  list in case we want to merge them some day.
	(colrow_get_outline_toggle) : use new routine here too.

2001-04-05  Jody Goldberg <jgoldberg@home.com>

	* src/item-bar.c (item_bar_event) : Doh!  The outline events are
	  controled by the minor coordinate.

2001-04-01  Jody Goldberg <jgoldberg@home.com>

	* src/main.c (gnumeric_main) : shut plugins down first.

2001-04-04  Morten Welinder  <terra@diku.dk>

	* src/style.c (font_init): Improve error message.  Constify.

2001-04-04  Morten Welinder  <terra@diku.dk>

	* src/style.c (font_init): Refer to bugzilla, not bugs.

2001-04-04  Morten Welinder  <terra@diku.dk>

	* authors.sgml: refer to bugzilla, not bugs.

* src/plugin.c
(plugin_db_activate_saved_active_plugins): Don't update saved active
plugin ids if PLUGIN_DEBUG is defined.
(plugins_shutdown): Update saved active plugin ids only if needed.

2001-04-01  Almer S. Tigelaar  <almer@gnome.org>

	* src/commands.c
	(cmd_ins_del_colrow_redo): Don't mirror the size of the
	selected cols/rows, instead look at the next visible col/row
	to the top/left for the size.
	(cmd_hide_colrow_correct_selection): Pass extra "forward" parameter
	value to colrow_find_adjacent_visible.

	* src/colrow.h, src/colrow.c
	(colrow_find_adjacent_visible): Add optional "forward" parameter.
	If unset it will seek to the right/bottom otherwise to the left/top.

* src/plugin.[ch]: Replaced PLUGIN_MESSAGE macro with plugin_message
function to avoid portability problems (some compilers don't support
vararg macros), added "level" argument.

* src/plugin-loader.c (gnumeric_plugin_loader_load,
gnumeric_plugin_loader_unload): Adjusted to plugin.h.

and some tuning that greatly improves startup time.

2001-03-30  Jody Goldberg <jgoldberg@home.com>

	* ms-container.c (ms_container_init) : Take a parent container.
	(ms_container_finalize) : handle NULL blips smoothly.
	(ms_container_get_blip) : check the container if we are empty.

	* ms-escher.c (ms_escher_read_Blip) : always register a blip, even if
	  it is NULL, otherwise the index gets confused.  Move the
	  registration here.
	(ms_escher_blip_new) : from here.
	(ms_escher_read_ClientData) : replace blips we can't understand with
	  rectangles.

	* ms-chart.c (ms_excel_chart) : Pass in the charts container.

	* ms-excel-read.c (ms_excel_workbook_new) : workbook have no parents.
	(ms_excel_sheet_new) : Sheets are contained by workbooks.

2001-03-30  Jody Goldberg <jgoldberg@home.com>

	* src/workbook-control-gui.c (wbcg_sheet_remove_all) : clear the
	  notebook BEFORE deleting it to avoid updating during destuction.

	* src/cellspan.c (cell_calc_span) : Cells in hidden columns can not
	  have spans.

	* src/file.c (file_finish_load) : no need to manually respan this will
	  happen via sheet_update.  This gives us a nice speed up.

	* src/sheet.c (sheet_cell_calc_span) : don't reregister spans that
	  have not changed.
	(sheet_new) : init all flags to true to ensure things get updated.

2001-03-30  Jody Goldberg <jgoldberg@home.com>

	* src/main.c : remove style_debug option tha was unused.
	* src/mstyle.c (mstyle_elements_equal) : It was only mostly unused :-)

	* src/workbook-control-gui.c (wbcg_menu_state_sheet_count) : fix.

	* src/item-bar.c (is_pointer_on_division) : robustify in the face of
	  clicking out of bounds.
	(item_bar_event) : ditto, also simplfy a bit.

* src/plugin.h: Commented out PLUGIN_DEBUG and PLUGIN_ALWAYS_LOAD
macros.

2001-03-29  Morten Welinder  <terra@diku.dk>

	* configure.in (try_python): Fix redirections and don't use the
	non-standard "grep -q".

2001-03-29  Morten Welinder  <terra@diku.dk>

	Responding to lots of bug reports from drk@sgi.com:

	* src/application.c (application_display_dpi_get): Don't
 	explicitly inline.  (The compiler hopefully will by itself.)

	* src/sheet-object-widget.c (DEP_TO_CHECKBOX): Avoid pointer
 	arithmetic on void pointers.

	* src/item-bar.c: Don't use zero-sized array.

* src/plugin-service.c (plugin_service_file_opener_probe_func):
Print an error on terminal before ignoring it.

* sheet-priv.h (struct _SheetPrivate): Added auto_expr_idle_id
field.

* sheet.c
(sheet_update): Register idle function to update "auto_expression"
instead of doing this immediately. Calculating a sum of many values
may take a looong time.
(sheet_update_auto_expr_idle_func): New function (code moved from
sheet_update) updating "auto_expression" in idle loop.

 	missing cells with comments.

2001-03-26  Morten Welinder  <terra@diku.dk>

	* src/workbook.c (workbook_cells): New function, extracted from
 	cmd_search_replace_do.

	* src/sheet.c (sheet_cells): New function, extracted from
 	cmd_search_replace_do.

	* src/cell.c (cell_has_comment_pos): New function for those cells
 	that aren't really there.

	* src/commands.c (cmd_search_replace_do): Use workbook_cells and
 	sheet_cells.
	(cmd_search_replace_do_cell): Change to take position instead of
 	cell.  Handle missing cells without crashing.

2001-03-25  Almer S. Tigelaar  <almer@gnome.org>

	* src/commands.c
	(cmd_ins_del_colrow_redo): Resize inserted columns/rows
	to have the same size of the columns/rows that previously
	occupied the same space.

2001-03-25  Almer S. Tigelaar  <almer@gnome.org>

	* src/commands.c
	(cmd_ins_del_colrow_undo): Re-ant the original cut selection.
	(cmd_ins_del_colrow_redo): Re-ant accounting for the shift in
	columns/rows.
	(cmd_ins_del_colrow_destroy): Free stored cut range.
	(cmd_ins_del_colrow): Store the cut range if any.

2001-03-23  Almer S. Tigelaar  <almer@gnome.org>

	* src/about.c : Make some small changes and add Zbigniew.

+
+       * src/gnumeric-util.c (gnumeric_glade_group_value): Function moved
+       from dialog-search-replace.c.
+

* src/gutils.h (g_vector_free_custom macro): Fixed stupid bug.

Moved XL support from Gnumeric binary into real plugin.

* src/Makefile.am
(gnumeric_libs): Removed ../plugins/excel/libexcel.a

* src/main.c:
Removed:
- include "../plugins/excel/boot.h"
- xxx_debug variables
- (gnumeric_popt_options) excel debugging options
- excel_init() and excel_shutdown() calls