1. 06 May, 2001 10 commits
    • Almer S. Tigelaar's avatar
      Define ColRowRLESizeList. · 62ec24c9
      Almer S. Tigelaar authored
      2001-05-06  Almer S. Tigelaar  <almer@gnome.org>
      
      	* src/gnumeric.h: Define ColRowRLESizeList.
      
       	* src/commands.c (cmd_ins_del_colrow_*) : For saving
       	and restoring the col/row sizes we now use a
      	ColRowRLESizeList instead of a double *.
      
       	* src/colrow.[ch] (colrow_save_sizes) : Rebuild to return
       	a Run-Length encoded list of sizes.
       	(colrow_restore_sizes): Idem, but as parameter.
       	(colrow_size_list_destroy): Use colrow_rle_size_list_destroy.
      	(colrow_rle_size_list_destroy): Free SavedSize's.
      62ec24c9
    • Ole Laursen's avatar
      Updated Danish translation · 2e83b7dd
      Ole Laursen authored
      2e83b7dd
    • Jon Kåre Hellan's avatar
    • Jon K Hellan's avatar
      Change item cursor if expr entry changed the range. · 5305cde2
      Jon K Hellan authored
      2001-05-06  Jon K Hellan  <hellan@acm.org>
      
      	* src/sheet-control-gui.c (scg_range_selection_changed): Change
      	item cursor if expr entry changed the range.
      
      	* src/widgets/gnumeric-expr-entry.c (range_really_changed):
      	Remove.
              (make_display_range): New function. Makes a range, possibly
      	 expanded to contain full rows/columns.
      	(make_rangesel_text): Use make_display_range.
      	(gnumeric_expr_entry_set_rangesel_from_range): Return true if
      	displayed range is different from input range. Save the range
      	passed in without change. Use range_equal + sheet equality
      	test instead of range_really_changed.
      	(gnumeric_expr_entry_get_rangesel): Get range and/or sheet set
      	in widget.
      5305cde2
    • Jon K Hellan's avatar
      We don't need guru_cursor. · 39cb8040
      Jon K Hellan authored
      2001-05-06  Jon K Hellan  <hellan@acm.org>
      
      	* src/item-bar.h:  We don't need guru_cursor.
      
      	* src/item-bar.c (item_bar_realize, item_bar_unrealize,
      	set_cursor): Ditto
      39cb8040
    • Jody Goldberg's avatar
      Read the XL docs to see what it wants. · fd377e52
      Jody Goldberg authored
      fd377e52
    • Jody Goldberg's avatar
      I have no idea what this code is doing. However, this appears to make · 8a6c94e1
      Jody Goldberg authored
      
      2001-05-06  Jody Goldberg <jgoldberg@home.com>
      
      	* fn-stat.c (gnumeric_chitest) : I have no idea what this code is
      	  doing.  However, this appears to make things tie out again.
      8a6c94e1
    • Jody Goldberg's avatar
      support multiple rows. (ms_excel_read_row) : use here. · b95740f5
      Jody Goldberg authored
      
      2001-05-05  Jody Goldberg <jgoldberg@home.com>
      
      	* ms-excel-read.c (ms_excel_set_xf_segment) : support multiple rows.
      	(ms_excel_read_row) : use here.
      	(ms_excel_read_cell) : and here.
      	(ms_excel_read_colinfo) : start using it here too.
      	(ms_sheet_obj_create) : Add a place holder for a spinner.
      b95740f5
    • Jody Goldberg's avatar
      I'd forgotten that we were already collecting styles. Adding this · 0e25d62c
      Jody Goldberg authored
      functionality was easy in that context.
      
      bug 53180
      
      2001-05-05  Jody Goldberg <jgoldberg@home.com>
      
      	* ms-excel-write.c (pre_cell) : XL does not differentiate between
      	  parse and display formats.  When exporting a cell with General that
      	  has a parse format create a new XF with the parse format as the
      	  display format.
      0e25d62c
    • Jody Goldberg's avatar
      update the edit_pos if necessary. · ba8c408f
      Jody Goldberg authored
      
      2001-05-05  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet-merge.c (sheet_merge_add) : update the edit_pos if
      	  necessary.
      
      	* src/sheet.c (sheet_update_only_grid) : fix typo.
      ba8c408f
  2. 05 May, 2001 4 commits
    • Almer S. Tigelaar's avatar
      Initialize item_bar->shade and tidy to be more correct. · 8cadb36c
      Almer S. Tigelaar authored
      2001-05-05  Almer S. Tigelaar  <almer@gnome.org>
      
        	* src/item-bar.[ch]:
       	(item_bar_realize): Initialize item_bar->shade and tidy to be
       	more correct.
       	(item_bar_unrealize): Unref item_bar->shade.
       	(item_bar_draw): Use item_bar->shade.
      8cadb36c
    • Jon K Hellan's avatar
      Add guru_cursor member. · 91b38061
      Jon K Hellan authored
      2001-05-05  Jon K Hellan  <hellan@acm.org>
      
      	* src/item-bar.h (struct _ItemBar): Add guru_cursor member.
      
      	* src/item-bar.c (item_bar_realize): Initialize guru_cursor.
      	(item_bar_unrealize): Destroy guru_cursor.
      	(is_pointer_on_division): Handle uninitialized case.
      	(set_cursor): Do not show resize cursor in guru mode.
      	(item_bar_event): Allow gurus to do range selection. Do nothing if
      	guru is up but no range selector active. Do not post context menu
      	when guru is up.
      91b38061
    • Jon K Hellan's avatar
      Add comment · 7604fddd
      Jon K Hellan authored
      2001-05-05  Jon K Hellan  <hellan@acm.org>
      
      	* dialog-workbook-attr.c (attr_dialog_impl): Add comment
      7604fddd
    • Jody Goldberg's avatar
      Make the displaying the warning optional. (sheet_range_splits_region) : · 48d59bf8
      Jody Goldberg authored
      
      2001-05-04  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_range_splits_array) : Make the displaying the
      	  warning optional.
      	(sheet_range_splits_region) : ditto.
      	(sheet_range_contains_region) : implement.
      
      	* src/workbook-control-gui.c (sort_cmd) : no need to check for merges
      	  or arrays here.
      	* src/dialogs/dialog-cell-sort.c (dialog_cell_sort) : or here.
      
      	* src/commands.c (cmd_sort) : it belongs here.
      
      	* src/print.c (print_page) : in the case of grid lines we were off by
      	  a point.  In the case without gridlines we need not display the
      	  leading cell margins.
      48d59bf8
  3. 04 May, 2001 19 commits
    • Jody Goldberg's avatar
      signature change to selection_first_range. · 86bc8c6d
      Jody Goldberg authored
      
      2001-05-03  Jody Goldberg <jgoldberg@home.com>
      
      	* excel-gb-selection.c (excel_gb_selection_interior) : signature
      	  change to selection_first_range.
      86bc8c6d
    • Jody Goldberg's avatar
      s/clipboard_release/cellregion_free/ s/range_copy/range_dup/ · 32bde6ee
      Jody Goldberg authored
      
      2001-05-04  Jody Goldberg <jgoldberg@home.com>
      
      	s/clipboard_release/cellregion_free/
      	s/range_copy/range_dup/
      	s/cell_region_render_ascii/cellregion_to_string/
      	s/clipboard_release/cellregion_free/
      
      	* src/commands.c (cmd_autofill) : Use sheet_range_contains_region.
      	(cmd_autofill_redo) : no need to test here.
      	(cmd_paste_cut) : test destination for validity and ensure that it
      	  does not slice up any merged regions or arrays.  Make the descriptor
      	  an argument so that other commands can use this one.
      	(cmd_ins_del_colrow_redo) : use colrow_max.
      	(cmd_area_set_text_redo) : use sheet_ranges_split_region.
      	(cmd_colrow_outline_change) : suppress warning.
      
      	* src/gui-clipboard.c (x_selection_to_cell_region) : simplify by using
      	  some of the convenience routines.
      
      	* src/gutils.c (gnumeric_sys_data_dir) : warning suppression.
      	(gnumeric_sys_lib_dir) : ditto.
      
      	* src/item-bar.c (item_bar_draw) : add missing warning.
      
      	* src/item-cursor.c (item_cursor_drag_event) : Don't assume the
      	  release came from the button that started the grab (think about
      	  multiple simultaneous button downs.
      	(item_cursor_selection_event) : ditto.
      	(item_cursor_do_drop) : changes to selection_first_range.
      
      	* src/parse-util.c (col_name_internal) : new routine split from
      	  col_name with better buffer handling.
      	(col_name) : used here.
      	(cols_name) : and in this new function.
      
      	* src/print.c (sheet_print_selection) : changes to
      	  selection_first_range.
      
      	* src/print-info.c (print_info_new) : default even_if_only_styles to
      	  false.  This is probably what most people want.
      
      	* src/ranges.c (range_translate) : don't invert.
      	(range_height) : new util.  could probably be #define.
      	(range_width) : new util.  could probably be #define.
      	(range_is_infinite) : use range_is_full.
      	(range_is_full) : new util.
      
      	* src/search.c (calculate_replacement) : warning suppression.
      
      	* src/selection.c (sheet_selection_cut) : Use
      	  sheet_range_splits_region and selection_first_range.
      	(sheet_selection_copy) : Use selection_first_range and remove TODO
      	  about supporting not paste by content for partial arrays.
      	(selection_first_range) : Add optional error reporting if there are
      	  multiple selection ranges.
      
      	* src/format.c (format_get_currency) : diddle the logic to get
      	  undefined to work the way people expect for locale C.
      
      	* src/sheet-merge.c (sheet_merge_relocate) : remove some dead code.
      	(sheet_merge_add) : changes to sheet_range_splits_array.
      
      	* src/sheet-object-widget.c (sheet_widget_checkbox_construct) :
      	  changes to selection_first_range.
      
      	* src/sheet.c (sheet_delete_{cols,rows}) : changes to
      	  sheet_range_splits_array.
      	(sheet_insert_{cols,rows}) : use sheet_range_splits_array.
      	(avoid_dividing_array_vertical) : delete.
      	(avoid_dividing_array_horizontal) : delete.
      	(sheet_is_pristine) : constness.
      	(sheet_mark_clean) : delete.
      	(sheet_clear_region) : changes to sheet_range_splits_array.
      	(sheet_ranges_split_region) : renamed from selection_check_for_array.
      	(sheet_range_splits_region) : new routine to check arrays and merged
      	  regions.
      	(sheet_range_splits_array) : improve and add hooks to be used for
      	  overlapping checks.
      	(cb_check_array_vertical) : report the array being split.
      	(cb_check_array_horizontal) : report the array being split.
      
      	* src/stf-parse.c (stf_parse_region) : use cellregion_new.
      	(stf_parse_is_valid_data) : simplify.
      
      	* src/value-sheet.c (value_area_get_width) : warning suppression.
      	(value_area_get_height) : warning suppression.
      	(value_area_fetch_x_y : signedness.
      	(value_area_get_x_y) : signedness.
      
      	* src/value.c (value_array_resize) : signedness.
      	(value_array_set) : signedness.
      
      	* src/workbook-control-gui.c (wbcg_error_splits_array) : signature
      	  change.
      	(cb_insert_rows) : use selection_first_range
      	(cb_insert_cols) : ditto.
      	(sort_cmd) : ditto.
      	(cb_workbook_debug_info) : clean out some deadwood.
      
      	* src/workbook-edit.c (auto_complete_matches) : warning suppression.
      
      	* src/workbook.c (workbook_sheet_detach) : warning suppression.
      	(g_ptr_array_insert) : warning suppression, moved to gutils.
      
      	* src/xml-io.c (xml_write_attributes) : warning suppression.
      	(xml_read_selection_clipboard) : use cellregion_new and tidyup.
      
      	* src/clipboard.c (paste_link) : Only make the link sheet specific if
      	  we need to.
      	(clipboard_paste_region) : constness, support being able to paste
      	  content only as link or value.
      	(clipboard_prepend_cell) : check for arrays.
      	(clipboard_copy_range) : use cellregion_new
      	(cellregion_new) : new function
      	(cellregion_free) : renamed from clipboard_release.
      	(cellregion_to_string) : moved here from render-ascii.
      
      	src/cmd-edit.c (cmd_paste) : more protection. Merge in
      	  application_paste.
      	(cmd_paste_to_selection) : handle changes to selection_is_simple and
      	  use selection_first_range
      	(cmd_shift_rows) : changes to cmd_paste_cut.
      	(cmd_shift_cols) : ditto.
      
      	* src/command-context-priv.h : change signature of splits array.
      	* src/command-context.h : ditto.
      	* src/command-context.c (gnumeric_error_splits_array) : ditto.
      
      	* src/application.c (application_clipboard_clear) :
      	(application_set_selected_sheet) : remove #warning, it is not portable.
      
      	* src/commands.c
      	* src/Makefile.am : remove render-ascii.[ch]  Move their content into
      	  clipboard.
      
      2001-05-01  Jody Goldberg <jgoldberg@home.com>
      
      	* src/clipboard.c (clipboard_prepend_cell) : remove ugly
      	  implementation.
      
      	* src/workbook-edit.c (auto_complete_matches) : remove warning.
      
      	* src/xml-io.c (xml_write_attributes) : remove warning.
      32bde6ee
    • Jon K Hellan's avatar
      Set this one invisible, too. · 8888acdd
      Jon K Hellan authored
      2001-05-04  Jon K Hellan  <hellan@acm.org>
      
      	* hf-config.glade: Set this one invisible, too.
      8888acdd
    • Morten Welinder's avatar
      New tool. · e0dd826b
      Morten Welinder authored
      e0dd826b
    • Morten Welinder's avatar
      Plug leak. · db2d2fa5
      Morten Welinder authored
      2001-05-04  Morten Welinder  <terra@diku.dk>
      
      	* src/expr.c (expr_parse_string): Plug leak.
      db2d2fa5
    • Jon K Hellan's avatar
      Set invisible to avoid flicker when popping up. · adbee59a
      Jon K Hellan authored
      2001-05-04  Jon K Hellan  <hellan@acm.org>
      
      	* src/dialogs/dialog-stf-export.glade: Set invisible to avoid
              flicker when popping up.
      adbee59a
    • Morten Welinder's avatar
      Sort problem. · c5b02a4d
      Morten Welinder authored
      c5b02a4d
    • Morten Welinder's avatar
      a700c6ae
    • Jon K Hellan's avatar
      Add ExprEntry widgets. (do_setup_page_info): Add ExprEntry widgets on the · 65fe852a
      Jon K Hellan authored
      2001-05-04  Jon K Hellan  <hellan@acm.org>
      
       	* src/dialogs/dialog-printer-setup.c (struct
       	PrinterSetupState) : Add ExprEntry widgets.
       	(do_setup_page_info): Add ExprEntry widgets on the fly.
       	(do_print_cb): Close print setup dialog before displaying print
       	dialog. FIXME.
       	(do_print_preview_cb): No longer close the dialog.
       	(do_print_cancel_cb): New function. Close the dialog.
       	(do_print_ok_cb): New function. Save info and close the dialog.
       	(do_print_set_focus_cb): New function. Enable range selection when
       	an ExprEntry acquires focus.
       	(do_setup_main_dialog): Clean up dead code. Attach callbacks to
       	"ok", "cancel", "set-focus" and "destroy". Attach guru.
       	(printer_setup_state_free): Move just after
       	printer_setup_state_new. Set conversion_listeners member to NULL
       	after freeing list.
       	(do_fetch_page_info): top_entry and left_entry widgets are now
       	taken from state rather than glade_xml_get_widget.
       	(dialog_printer_setup): Eliminate recursive mainloop.
      
      2001-05-04  Jon K Hellan  <hellan@acm.org>
      
      	* src/widgets/gnumeric-expr-entry.h: GnumericExprEntryPrivate is
      	unused. Remove.
      
      	* src/widgets/gnumeric-expr-entry.c
      	(gnumeric_expr_entry_set_rangesel_from_range):  Make sure that pos
      	>= 0. Implement full column and full row flags.
      	(gnumeric_expr_entry_toggle_absolute): Call update_reangesel_text
      	with pos = 0.
      65fe852a
    • Jon K Hellan's avatar
      Don't set title here after all. It has no effect. · ce9f006b
      Jon K Hellan authored
      2001-05-04  Jon K Hellan  <hellan@acm.org>
      
      	* workbook-attr.glade: Don't set title here after all. It has no
      	effect.
      
      	(Only checked in dialog-workbook-attr.c last time I tried to
      	do this.)
      ce9f006b
    • Jon K Hellan's avatar
      Back out change below. Looks like <title> in glade file doesn't work for · a6bddc00
      Jon K Hellan authored
      2001-05-04  Jon K Hellan  <hellan@acm.org>
      
      	* dialog-workbook-attr.c (attr_dialog_impl): Back out change
      	below. Looks like <title> in glade file doesn't work for property
      	dialogs.
      
      	* workbook-attr.glade: Don't set title here after all. It has no
      	effect.
      a6bddc00
    • Morten Welinder's avatar
      Make public. · 87eb4c0b
      Morten Welinder authored
      2001-05-04  Morten Welinder  <terra@diku.dk>
      
      	* src/analysis-tools.c (set_cell_value): Make public.
      
      	* src/solver-lp.c (solver_sensitivity_report,
       	solver_answer_report): Use set_cell_value.
      
      	* src/value.c (value_peek_string): New function.
      
      	* src/expr.c (eval_expr_real): Simplify CONCAT case using
       	value_peek_string.
      
      	* src/datetime.c (datetime_value_to_serial_raw): Simplify using
       	value_peek_string.
      
      	* src/workbook-view.c (wb_view_auto_expr_recalc): Ditto.
      
      	* src/graph-vector.c (graph_vector_seq_string): Ditto.
      
      	* src/solver-lp.c (find_name): Ditto.
      
      2001-05-04  Morten Welinder  <terra@diku.dk>
      
      	* fn-string.c (gnumeric_exact, gnumeric_len, gnumeric_rept,
       	gnumeric_find): Ditto.
      
      	* fn-eng.c (value_get_as_complex): Simplify using
       	value_peek_string.
      87eb4c0b
    • Morten Welinder's avatar
      Cleanup. (gnumeric_rept): Un-suckify. · 6557b2b7
      Morten Welinder authored
      2001-05-04  Morten Welinder  <terra@diku.dk>
      
      	* fn-string.c (gnumeric_len, gnumeric_exact, gnumeric_trim):
       	Cleanup.
      	(gnumeric_rept): Un-suckify.
      6557b2b7
    • Almer S. Tigelaar's avatar
      Correct InsertComment pixmap, add pixmap for Sort and add separators on · aa36c8c1
      Almer S. Tigelaar authored
      2001-05-04  Almer S. Tigelaar  <almer@gnome.org>
      
       	* src/GNOME_Gnumeric.xml: Correct InsertComment
       	pixmap, add pixmap for Sort and add separators
       	on the right places.
      
       	* src/pixmaps: Split sort ascending into 16x16 and
       	24x24 versions.
      
       	* src/application.c: Account for the split. This
       	will make the menu item show up with a correct
       	icon in Bonobo.
      
      	* src/workbook-control-gui.c: Idem. Use the 16x16
      	icon for the menu.
      aa36c8c1
    • Almer S. Tigelaar's avatar
      Set window title. Idem. Idem. · 8240b16c
      Almer S. Tigelaar authored
      2001-05-04  Almer S. Tigelaar  <almer@gnome.org>
      
      	* hf-config.glade: Set window title.
      	* search-replace.glade: Idem.
      	* workbook-attr.glade: Idem.
      
      	* autoformat.glade: Correct window title.
      	* dialog-stf-export.glade: Idem.
      	* validate.glade: Idem.
      	* solver.glade: Idem and some minor polishing.
      
      	* dialog-workbook-attr.c: Don't set the window title
      	with gtk_window_set_title, it's in the glade file anyway.
      8240b16c
    • Almer S. Tigelaar's avatar
      Correct minor typo. (cmd_merge_cells): Idem. · 0f670d40
      Almer S. Tigelaar authored
      2001-05-04  Almer S. Tigelaar  <almer@gnome.org>
      
      	* src/commands.c (cmd_unmerge_cells): Correct minor typo.
      	(cmd_merge_cells): Idem.
      
      2001-05-04  Almer S. Tigelaar  <almer@gnome.org>
      
      	* names.glade: Set window title.
      0f670d40
    • Jody Goldberg's avatar
      suppress warnings. · bc2d9ac7
      Jody Goldberg authored
      
      2001-05-01  Jody Goldberg <jgoldberg@home.com>
      
      	* applix-read.c : suppress warnings.
      bc2d9ac7
    • Jody Goldberg's avatar
      This is prettier · 9d5e7fa0
      Jody Goldberg authored
      9d5e7fa0
    • Jody Goldberg's avatar
      update · 6e670ada
      Jody Goldberg authored
      6e670ada
  4. 03 May, 2001 2 commits
    • Jon K Hellan's avatar
      New callback function. Removes object data from wbcg when dialog is · ccb86658
      Jon K Hellan authored
      2001-05-03  Jon K Hellan  <hellan@acm.org>
      
      	* src/gnumeric-util.c (cb_remove_object_data): New callback
      	function. Removes object data from wbcg when dialog is destroyed.
      	(gnumeric_keyed_dialog): New function. Make dialog a transient
      	child of wbcg, attaching to wbcg object data to identify the
      	dialog.
      	(gnumeric_dialog_raise_if_exists): New function: Raise the dialog
      	identified by key if it is registered on the wbcg.
      
      	* src/gnumeric-util.h (gnumeric_dialog_make_unique,
      	gnumeric_dialog_raise_if_exists): Declare.
      
       	* src/about.c (dialog_about): Use gnumeric_keyed_dialog.
      	Use gnumeric_dialog_raise_if_exists to ensure that only one sheet
      	object config dialog at a time can be displayed for a wbcg.
      
       	* src/sheet-object-widget.c (sheet_widget_checkbox_user_config):
      	Ditto.
      
      2001-05-03  Jon K Hellan  <hellan@acm.org>
      
      	* src/dialogs/dialog-define-names.c (name_guru_init): Use
      	gnumeric_keyed_dialog rather than gnumeric_non_modal_dialog.
      	(dialog_define_names): Use (gnumeric_dialog_raise_if_exists to
      	ensure that only one instance at a time can be displayed for a
      	wbcg.
      ccb86658
    • Michael Meeks's avatar
      make it more demoable. · 19f217c5
      Michael Meeks authored
      19f217c5
  5. 02 May, 2001 1 commit
    • Almer S. Tigelaar's avatar
      Callback timer routine, re-enables the toolbars. · 1a5a3140
      Almer S. Tigelaar authored
      2001-05-02  Almer S. Tigelaar  <almer@gnome.org>
      
      	* src/workbook-edit.c (cb_thaw_ui_toolbar): Callback timer
      	routine, re-enables the toolbars.
      	(workbook_edit_set_sensitive): Add a ui timer to eliminate
      	toolbar flickering.
      
      	* src/sheet.c (sheet_menu_state_enable_insert): Clean-up.
      1a5a3140
  6. 01 May, 2001 4 commits
    • Morten Welinder's avatar
      Cleanups. · 63eff1d1
      Morten Welinder authored
      63eff1d1
    • Morten Welinder's avatar
      CHITEST. · 62ea9136
      Morten Welinder authored
      62ea9136
    • Almer S. Tigelaar's avatar
      Seek for matching )'s for ('s and vice versa. (find_bracket): The meat for · e45a0e6b
      Almer S. Tigelaar authored
      2001-05-01  Almer S. Tigelaar  <almer@gnome.org>
      
       	* src/parser.y (yylex): Seek for matching )'s for ('s and
       	vice versa.
       	(find_bracket): The meat for the above functionality
       	(find_char): Split out from yylex, might be useful in other
       	places. Currently used to scan for matching quotes.
      	(gnumeric_expr_parser): If the ExprTree is null, assume that
      	an error has occurred, set a general "invalid expression" and
      	mark the whole expression. Also display more detail when both
      	the expression and error message are non-null.
      e45a0e6b
    • Morten Welinder's avatar
      Un-suckify. (wildcards_and_question_marks, parse_search_string): Constify. · 401c3250
      Morten Welinder authored
      2001-05-01  Morten Welinder  <terra@diku.dk>
      
      	* fn-string.c (gnumeric_left, gnumeric_right, gnumeric_lower,
       	gnumeric_upper, gnumeric_clean, gnumeric_proper): Un-suckify.
      	(wildcards_and_question_marks, parse_search_string): Constify.
      401c3250