1. 15 Apr, 2001 1 commit
    • Almer S. Tigelaar's avatar
      Add detailed parser error messages. · fa7e253a
      Almer S. Tigelaar authored
      2001-04-15  Almer S. Tigelaar  <almer@gnome.org>
      	* src/parser.y : Add detailed parser error messages.
      	* src/workbook-edit.c (workbook_finish_editing) : Abort
      	if the expression is invalid and return a boolean indicating
      	success or failure.
      	* src/expr.c (expr_parse_string): Set error message to the
      	result of gnumeric_expr_parser.
      	* src/parse-util.c (parse_error_init) : Properly initialize
      	begin and end character.
      	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet): Don't
      	change the cursor position if workbook_finish_editing failed.
      	(move_cursor): Idem.
      	* src/item-grid.c (item_grid_button_1): Idem.
  2. 24 Feb, 2001 1 commit
    • Jody Goldberg's avatar
      reorder to handle unmerging directly. (cmd_merge_cells_undo) : ditto. · ab441bef
      Jody Goldberg authored
      2001-02-23  Jody Goldberg <jgoldberg@home.com>
       	* src/commands.c (cmd_merge_cells_redo) : reorder to handle unmerging
       	(cmd_merge_cells_undo) : ditto.
       	(CmdMergeCells) : no need to inherit from CmdUnmergeCells.
       	(cmd_unmerge_cells_redo) : merge the 'internal' versions.
       	(cmd_unmerge_cells_undo) : merge the 'internal' versions.
      2001-02-22  Jody Goldberg <jgoldberg@home.com>
      	* src/style-border.c (style_border_vmargins) : remove unnecessary
      	  reference to next_sr.  sr.bottom == next_sr.top
      	  For normal borders horizontal always dominates vertical.
      	(style_border_hmargins) : Only cut corners for doubles if the corner
      	  is a double.
      	* src/sheet.c (sheet_cursor_set_full) : new function.
      	* src/selection.c (sheet_selection_set_internal) : Use it here.
      	  The trick is that when extending a selection to include merged cells
      	  it is possible that the edit cell is neither the base nor the move
      	  col/row.  When you then shrink the selection to the pre-extended
      	  state, without the merged region, you have lost track of the corner
      	  and can easily loose the edit_position.
      	* src/workbook-format-toolbar.c (toggled_from_toolbar) : delete this
      	  ugliness.  We don't need it anymore.
      2001-02-20  Jody Goldberg <jgoldberg@home.com>
      	* src/workbook-control-gui.c (wbcg_ui_update_begin) : new utility
      	(wbcg_ui_update_end) : new utility
      	* src/workbook-format-toolbar.c (workbook_feedback_set) : Use them
      	(workbook_format_halign_feedback_set) : update center-across-selection
      	  in the bonobo case.
      	(do_modify_format) : rewrite to use the format from the edit cell and
      	  to support undo.
      	* src/format.c (format_toggle_thousands) : delete.
      2001-02-23  Jody Goldberg <jgoldberg@home.com>
      	* configure.in : post release version bump to 0.64.
  3. 22 Feb, 2001 1 commit
    • Jody Goldberg's avatar
      fix old typo. · 78ab04fc
      Jody Goldberg authored
      2001-02-22  Jody Goldberg <jgoldberg@home.com>
      	* src/expr.c (eval_expr_real) : fix old typo.
  4. 17 Feb, 2001 1 commit
    • Jody Goldberg's avatar
      Use some code from expr.c to simplify binary/unary output and to add · e0f71b51
      Jody Goldberg authored
      2001-02-16  Jody Goldberg <jgoldberg@home.com>
      	* ms-formula-write.c (write_node) : Use some code from expr.c
      	  to simplify binary/unary output and to add parens when necessary.
      	* ms-excel-write.c (write_formula) : Start at paren level 0.
      	(write_names) : ditto.
      2001-02-16  Jody Goldberg <jgoldberg@home.com>
      	* src/dialogs/dialog-cell-format.c (fmt_dialog_init_align_page) :
      	  begin support for indenting.
      	* src/workbook-format-toolbar.c : ditto.
      2001-02-16  Jody Goldberg <jgoldberg@home.com>
      	* configure.in : post release version bump
      2001-02-15  Jody Goldberg <jgoldberg@home.com>
      	* s/fit_in_cell/wrap_text/
      	rename this in preparation for supporting shrink_to_fit
  5. 11 Feb, 2001 1 commit
  6. 09 Feb, 2001 1 commit
    • Jeffrey Stedfast's avatar
      include ranges.h · 445f43a2
      Jeffrey Stedfast authored
      2001-02-09  Jeffrey Stedfast  <fejj@ximian.com>
      	* src/print.c: include ranges.h
      	* src/expr.c: include gutils.h
  7. 08 Feb, 2001 1 commit
    • Morten Welinder's avatar
      Improve quoting using gnumeric_strescape. · 1beae0a3
      Morten Welinder authored
      2001-02-07  Morten Welinder  <terra@diku.dk>
      	* src/commands.c (cmd_search_replace_do_cell): Improve quoting
       	using gnumeric_strescape.
      	* src/gutils.c (gnumeric_strescape): Imported from src/expr.c.
        	Constified and changed to add the quotes.
      	* src/expr.c (strescape): Moved to gutils.
      	(do_expr_tree_to_string): Use gnumeric_strescape.
  8. 31 Jan, 2001 1 commit
    • Jody Goldberg's avatar
      s/float_t/gnum_float/ s/int_t/gnum_int/ · 9eaf277a
      Jody Goldberg authored
      2001-01-30  Jody Goldberg <jgoldberg@home.com>
      	* src/sheet-style.c (sheet_style_get_uniform) : implement.
      	* src/parse-util.c (parse_text_value_or_expr) : dont loose the entered
      	* src/history.c (history_menu_insert_separator) : keep case
      	* src/workbook-control-gui.c (workbook_menu_file) : ditto.
      	* configure.in : update GAL req.
      	* README : ditto.
      	* gnumeric.spec.in : ditto.
      2001-01-29  Jody Goldberg <jgoldberg@home.com>
      	* src/sheet-style.h : decl for StyleRow.
      	* src/xml-io.c : Use the Child and Root aliases to ease ease
      	  transition from xml1 -> xml2.
      	(xml_sheet_create) : default name for sheets that fail to specify one.
      	* src/workbook.c (workbook_sheet_by_index) : improve safety.
  9. 12 Jan, 2001 1 commit
    • Jody Goldberg's avatar
      Rework the style engine. Mostly functional. see BUGS for remaining details. · 9e615b65
      Jody Goldberg authored
      NOTE : I have not tested persistance.
      2001-01-11  Jody Goldberg <jgoldberg@home.com>
      	* src/mstyle.c (mstyle_ref_multiple) : new function.
      	(mstyle_copy_merge) : new function.
      	(mstyle_new_default) : Do not cache the result.  That is done at the
      	  sheet level.
      	(mstyle_do_merge) : delete.
      	(mstyle_get_format) : constness.
      	* src/format-template.c (cb_format_sheet_border) : delete.
      	(format_template_apply_to_sheet_regions) : borders are no longer special.
      	* src/expr.c (expr_tree_array_formula_corner) : do not store the
      	  corner anymore.
      	(expr_tree_new_array) : ditto.
      	(do_expr_tree_unref) : ditto.
      	* src/cell.c (cell_relocate) : Arrays are simplified.  No need to keep
      	  a pointer to the corner.  It made the system too brittle.
      	(cell_set_mstyle) : delete.
      	* src/Makefile.am : remove test.[ch]
      	* src/gnumeric-sheet.c (gnumeric_sheet_find_{col,row}) : There is no
      	  1 pixel border.
      2001-01-09  Jody Goldberg <jgoldberg@home.com>
      	* src/mstyle.h : Change order of borders to match BorderLocation
      2001-01-08  Jody Goldberg <jgoldberg@home.com>
      	* src/ranges.c (range_has_header) : avoid leaking styles.
      	* src/cell.c (cell_get_mstyle) : Use sheet_style_get, and do not bump
      	  the ref count.
      	(cell_render_value) : Adjust.
      	(cell_get_format : Adjust.
      	(cell_set_text) : Adjust.
      	* src/functions/fn-information.c (gnumeric_cell) : sheet_style_get
      	  does not make a reference. Use it.
      	* src/workbook-format-toolbar.c (modify_cell_format) :  Ditto.
      	(change_selection_font) : Ditto.
      	* src/sheet-autofill.c (fill_item_new) : ditto.
      	* src/print-cell.c (print_cell_range) : ditto.
      	* src/cellspan.c (cell_calc_span) : ditto.
      	* src/sheet.c (sheet_cell_set_text) : ditto.
      	* src/rendered-value.c (rendered_value_calc_size) : ditto.
      	* src/workbook-view.c (wb_view_format_feedback) : ditto.
      2001-01-07  Jody Goldberg <jgoldberg@home.com>
      	* src/dialogs/dialog-cell-format.c (dialog_cell_format) :
      	  init initial style to NULL.
      	(fmt_dialog_selection_type) : call sheet_style_get_uniform here.
      	* src/commands.c (cmd_format_redo) : Now that apply_border is not
      	  doing a redraw we need to if there is no style applied.
      	* src/selection.c (sheet_selection_extend_to) : Add support akin to
      	  gnumeric_sheet_rangesel_cursor_extend to extend to full col/row.
      	* src/sheet-control-gui.c (scg_colrow_select) : extend to full col/row
      	  if necessary.
      	* src/item-bar.c (item_bar_event) : Set the selection, not extend it.
  10. 25 Dec, 2000 1 commit
    • Jody Goldberg's avatar
      clean up includes. · 0ae4c759
      Jody Goldberg authored
      2000-12-25  Jody Goldberg <jgoldberg@home.com>
      	* src/ranges.h : clean up includes.
  11. 10 Dec, 2000 1 commit
    • Jody Goldberg's avatar
      comment out the warning. These the life cycles of names are too fluid to · e605d42e
      Jody Goldberg authored
      2000-12-10  Jody Goldberg <jgoldberg@home.com>
      	* src/expr-name.c (expr_name_invalidate_refs_sheet) : comment out the
      	  warning.  These the life cycles of names are too fluid to scare
      	  users yet.
      	(expr_name_invalidate_refs_wb) : Ditto.
      2000-12-10  Jody Goldberg <jgoldberg@home.com>
      	* src/cell.c (cell_set_text) : send the current format to the
      	  number matcher..
      	* src/sheet.c (sheet_cell_set_text) : Ditto.
      	* src/parse-util.c (parse_text_value_or_expr) : send the curent
      	  format to the number matcher.
      	* src/number-match.c (format_match) : take the current format as a
      	  parameter.  Begin using it to handle cells formated as text.
      	* src/format.c (style_format_is_text)  utility routine.
      2000-12-09  Jody Goldberg <jgoldberg@home.com>
      	* src/selection.c (sheet_selection_set_internal) : rename from
      	  sheet_selection_set and add the 'just_add_it' flag to indicate that
      	  we don't need to do anything fancy.
  12. 07 Dec, 2000 1 commit
  13. 03 Dec, 2000 1 commit
  14. 02 Dec, 2000 1 commit
    • Jody Goldberg's avatar
      Change image viewers. The eog/bonobo viewer is no longer built or · 3916b17f
      Jody Goldberg authored
      2000-12-02  Jody Goldberg <jgoldberg@home.com>
      	* ms-escher.c (ms_escher_read_Blip) : Change image viewers.  The
      	  eog/bonobo viewer is no longer built or installed.
      	* ms-excel-read.c (ms_excel_read_sheet) : XL docs do not mention that
      	  the PROTECT record can sometimes be of size 0.
      	(ms_excel_read_workbook) : Ditto.
      	(ms_excel_read_PROTECT) : new function.
      	(ms_excel_read_mergecells) : Correct.
      	(biff_xf_data_new) : remove the warnings about merged cells.
      2000-12-02  Jody Goldberg <jgoldberg@home.com>
      	* src/expr.c (cellrange_relocate) : fix the logic that was broken when
      	  supporting the partial ranges.
      	(cellref_relocate) : move some of the code here, to decrease
  15. 24 Nov, 2000 1 commit
    • Jody Goldberg's avatar
      bubble the sizing code further up. src/cell-draw.c (cell_draw) : ditto. · d473caa4
      Jody Goldberg authored
      2000-11-24  Jody Goldberg <jgoldberg@home.com>
      	* src/print-cell.c (print_cell) : bubble the sizing code further up.
      	  src/cell-draw.c (cell_draw) : ditto.  Move towards a better api that
      	  will pass in the bounding box rather than all the parameters needed
      	  to generate it in different circumstances.
      2000-11-23  Jody Goldberg <jgoldberg@home.com>
      	* src/print-cell.c (print_cell) : until printing of the grid is synced
      	  with drawing a grid, disable the tests for width, height.
      	* src/expr.c (cellrange_relocate) : Use simple heuristic to help
      	  diffentiate the 'expected' behavior of  moving expressions with
      	  range references that are partially contained.
  16. 02 Nov, 2000 1 commit
    • Jody Goldberg's avatar
      inside is always calculatd based on the source sheet. eg Sheet1:A1 = '=A2' · c5883e7c
      Jody Goldberg authored
      2000-11-01  Jody Goldberg <jgoldberg@home.com>
      	* src/expr.c (cellref_relocate) : inside is always calculatd based on
      	  the source sheet.  eg  Sheet1:A1 = '=A2' and we are moving A1:A2
      	  from Sheet1 -> Sheet2.  The reference to A2 should be considered
      	  'inside'.  References to Sheet2!A2 have already been #REF!ed.
      	* src/commands.c (cmd_paste_cut_redo) : Use range_check_sanity.
      	* src/sheet.c (sheet_cell_insert) : Render if necessary.
      	(sheet_move_range) : Extra care is only necessary if the source and
      	  target sheets are the same.  When they are different we should just
      	  invalidate all references to the target range.
  17. 20 Sep, 2000 1 commit
    • Jody Goldberg's avatar
      We always create an in canvas edit item, but sometimes we jump the focus · 9fc2db80
      Jody Goldberg authored
      2000-09-20  Jody Goldberg <jgoldberg@home.com>
      	* src/workbook-edit.c (workbook_start_editing_at_cursor) : We always
      	  create an in canvas edit item, but sometimes we jump the focus to
      	  the status line.
      	* src/value.c (value_new_cellrange_r) : set the sheet for both
      	* src/sheet-object-widget.c (checkbox_set_expr) : Fix.
      	* src/graph-series.c (graph_series_seq_scalar) : No need to handle
      	  headers here.
      	(graph_series_seq_date) : or here.
      	(graph_series_seq_string) : or here.
      	(graph_series_eval) : Handle idl rename.
      	(series_get_name) : No need to do this here.
      	(impl_vector_scalar_value) : No need to calculate label.
      	(impl_vector_date_value) : Ditto.
      	(impl_vector_string_value) : Ditto.
      	(graph_series_set_expr) : Correctly register and un register deps.
      	(graph_series_new) : series names are handled at a higher level.
      	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) : Restore the
      	  behaviour of F2.
      	* src/expr.c (cellrange_relocate) : BE smarter about checking for
      	  potential 3d references.
      	* idl/gnumeric-graphs.idl : Rename routines using lowercase underscore
      	  rather than StuddyCaps.
      	* src/workbook.c (workbook_expr_relocate) : Handle dependents.
      	* src/position.c (eval_pos_init_dep) : new function.
      	* configure.in : Prepare for release.
      	  Update req for gnome-print to 0.23
      	  Update req for libglade to 0.14
      	  Comment out pspell.
      	  Leave perl disabled.
      	* gnumeric.spec.in : Ditto.
      	* README : Ditto.
      2000-09-19  Jody Goldberg <jgoldberg@home.com>
      	* src/xml-io.c (natural_order_cm) : Using col_info and row_info is
  18. 14 Sep, 2000 1 commit
    • Jody Goldberg's avatar
      Use sheet_selection_full_rows and workbook_cmd_format_row_height. · 01af4e73
      Jody Goldberg authored
      2000-09-14  Jody Goldberg <jgoldberg@home.com>
      	* src/sheet-view.c (sheet_view_row_size_changed) : Use
      	  sheet_selection_full_rows and workbook_cmd_format_row_height.
      	(sheet_view_col_size_changed) : Use
      	  sheet_selection_full_cols and workbook_cmd_format_column_width.
      	* src/item-grid.c (context_row_height) : Use sheet_dialog_set_row_height.
      	(context_col_width) : Use sheet_dialog_set_column_width.
      	* src/workbook-cmd-format.c (sheet_dialog_set_column_width) : Split
      	  the gui into here.
      	(workbook_cmd_format_column_width) : And the action into here.  Use
      	  the appropriate commands to get undo support.
      	(workbook_cmd_format_column_auto_fit) : Use workbook_cmd_format_column_width.
      	(sheet_dialog_set_row_height) : Split the gui into here.
      	(workbook_cmd_format_row_height) : And the action into here.  Use
      	  the appropriate commands to get undo support.
      	(workbook_cmd_format_row_auto_fit) : Use workbook_cmd_format_row_height.
      	* src/selection.c (sheet_row_selection_type) : moved from sheet.c
      	(sheet_col_selection_type) : moved from sheet.c
      	(sheet_selection_full_cols) : new routine.
      	(sheet_selection_full_rows) : new routine.
      	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) : Don't jump
      	  directly to the edit line with F2.  Start editing in sheet first.
      	* src/selection.c (selection_foreach_range) : Add the option of
      	  iterating the list backwards.
      	* src/workbook-cmd-format.c (cb_colrow_collect) : New function.
      	* src/workbook-cmd-format.c (workbook_cmd_format_column_width) : Fix.
      	(workbook_cmd_format_row_height) : Fix.
      	* src/sheet-object-graphic.c (sheet_object_graphic_update_bounds) :
      	  new function.
      	(sheet_object_filled_new_view) : Set the bounds when a new view is
      	  constructed.  DO NOT rely on the realized list, new objects are not
      	  added until AFTER construction.
      	* src/sheet-object.c (sheet_object_update_bounds) : delete.
      2000-09-13  Jody Goldberg <jgoldberg@home.com>
      	* src/expr.c (cellref_relocate) : Return more information so that we
      	  can differentiate relocating rows, cols, or both.
      	(cellrange_relocate) : Use the new information to extend the
      	  heuristic for when to relocate a range.  In the past we assumed that
      	  unless both ends of the range were moving we should not do the
      	  relocation.  It seems that there are other cases which will also
      	  relocate.  When inserting/deleting rows/cols or cutting a region
      	  that includes an entire side of the source region we should
      	  Sadly this patch is incomplete.  It relocates too much now.
      	  If you cut B2 and paste it into B3 the source region A1:B2 will
      	  resize to A1:B3 even though it should not.  At least ins/del row/col
      	  will now work.
      2000-09-12  Jody Goldberg <jgoldberg@home.com>
      	* src/workbook.c (create_bonobo_object) : Fixed.
      	* src/sheet-object-bonobo.c (sheet_object_bonobo_new_from_oid) :
      	  Delete duplicate function.
      2000-09-11  Jody Goldberg <jgoldberg@home.com>
      	* src/commands.c (cmd_ins_del_row_col_{undo,redo}) : Insert/delete
      	  rows/cols clears the cut buffer.  Copies are preserved.
      	* src/sheet-object.c (cb_obj_create_button_release) :  remove the
      	  bonobo specific file handling.  That is to be done earlier
      	  or in a different place.  This routine is strictly for placement,
      	  not content.
      	(sheet_mode_clear) : Move the deactivation here for now.  Hopefully
      	  move it to a virtual.
      	* src/about.c (dialog_about) : suppress warning.
  19. 06 Sep, 2000 1 commit
    • Jody Goldberg's avatar
      Remainder of patch to handle non-cell dependents. · 01a95234
      Jody Goldberg authored
      2000-09-05  Jody Goldberg <jgoldberg@home.com>
      	* configure.in : Add test for pspell.
      	* acconfig.h : Ditto.
      	* s/cell.u.expression/cell.base.expression/
      	* s/cell.generation/cell.base.generation/
      	* s/cell.u.entered_text/cell.entered_text/  <- deprecated
      	* s/workbook.formula_cell_list/workbook.dependents/
      	* s/sheet_cell_expr_link/dependent_expr_link/
      	* s/sheet_cell_expr_unlink/dependent_expr_unlink/
      	* s/eval_queue_cell/dependent_queue_recalc/
      	* s/eval_queue_list/dependent_queue_recalc_list/
      	* s/eval_unqueue_cell/dependent_unqueue_recalc/
      	* s/eval_unqueue_sheet/dependent_unqueue_recalc_sheet/
      	* s/cell_add_dependencies/dependent_add_dependencies
      	* s/cell_drop_dependencies/dependent_drop_dependencies
      	* s/cell_formula_changed/dependent_changed/
      	* s/sheet_cell_expr_link/dependent_link/
      	* src/cell.c (cell_eval_content) : moved from eval.c
      	* src/eval.c (sheet_region_get_deps) : Take a Range rather than 4 int.
      	(drop_range_dep) : Use dependent_debug_name.
      	(dependency_range_ctor) : Take a CellPos as an arg rather than a Cell.
      	(handle_cell_single_dep) : Take an optional CellPos and a Dependent.
      	(handle_cell_range_deps) : Ditto. Do not check for singletons here.
      	(handle_tree_deps) : Ditto.  Call handle_cell_single_dep directly.
      	(cell_add_explicit_dependency) : Delete.
      	(get_single_dependencies) : Some const.
      	* src/cmd-edit.c (cmd_select_cur_depends) : Use dependent_list_filter
      	  to only show cell dependencies for now.
      	* src/dependent.c (dependent_list_filter) : new function.
      	(dependent_debug_name) : new function.
      	* src/history.c : Add a comment about File/Print Preview for
      	* src/workbook.c (cb_cell_rerender) : Only cells need this.
  20. 31 Aug, 2000 1 commit
    • Jody Goldberg's avatar
      New base class for Cells. Convert everything to access the elements that · 8b5866fb
      Jody Goldberg authored
      2000-08-30  Jody Goldberg <jgoldberg@home.com>
      	* dependent.[ch] : New base class for Cells.
      	  Convert everything to access the elements that are now
      	  in the cell's base.
      	* Makefile.am : Because of XL we need to build plugins before src.
      	  That will need changing.
      	* src/func.c (function_marshal_arg) : Use expr_array_intersection.
      	* src/expr.c (eval_expr_real) : Do implicit conversions from strings
      	  to numbers if possible.
      	  Access the first element of an array.  NOTE : This is WRONG
      	  We need to implement array expression behavior some day.
      	(expr_array_intersection) : New routine.
  21. 21 Aug, 2000 1 commit
    • Jody Goldberg's avatar
      Improve regexps. · 9ad38a63
      Jody Goldberg authored
      2000-08-21  Jody Goldberg <jgoldberg@home.com>
      	* src/number-match.c (format_create_regexp) : Improve regexps.
      	* src/formats.c (cell_format_is_number) : Format always uses standard
      	  decimal chars.
      	* src/format.c (gnumeric_setlocale) : New routine that clears cached
      	  locale info.
      	(format_get_decimal) : Improve use mon_decimal.
      	(format_get_thousand) : Improve use mon_thousands_sep.
      	(format_get_arg_sep) : New func.
      	(format_get_col_sep) : New func.
      	(format_destroy) : Use GPtrArray.
      	(render_number) : Improve localization.
      	(format_add_thousand) : rename format_toggle_thousands. De-localize.
      	(find_decimal_char) : De-localize.
      	(format_remove_decimal) : Ditto.
      	(format_add_decimal) : Ditto.
      	(format_number) : Ditto.
      	* src/expr.c (do_expr_tree_to_string) : Use format_get_arg_sep.
      	* src/cell.c (cell_get_format) : Update for the changes to StyleFormat.
      	* src/auto-format.c (auto_style_format_suggest) :
      	  style_format_new -> style_format_new_XL
      	* src/mstyle.c (mstyle_element_dump) : There is no direct access to
      	  the format string anymore.
      	(mstyle_set_format_text) : Add a warning.
      	* src/gutils.[ch] (float_get_from_range) : Delete.
      	(int_get_from_range) : Ditto.
      	* src/parser.y : Revamp lexer to use strtol, and strtod for number
      	  parsing.  Begin hooks for supporting row & col selection. (3:4 or A:B)
      	* src/print-info.c (render_value_with_format) : Changes to StyleFormat.
      	* src/sheet.h : Move SpanCalcFlags.
      	* src/gnumeric.h : here.
      	* src/style.[ch] : Privatize StyleFormat, move it to format.[ch]
      	* src/value.c (value_get_as_string) : Correctly localize things for
      	* src/workbook-format-toolbar.c (modify_cell_format) : format
      	  modification callback modifies the StyleFormat.
      	* src/workbook.c (workbook_set_auto_expr) : Use gnumeric_setlocale.
      	* src/xml-io.c (xml_workbook_read) : Use gnumeric_setlocale.
      	(xml_workbook_write) : Ditto.
      	(xml_read_cell) : Use style_format_new_XL.
      	(xml_write_cell_and_position) : Store the number formats in non localized XL form.
      	(xml_write_style) : Ditto.
      	* src/dialogs/dialog-cell-format.c (fmt_dialog_init_format_page) :
      	  Display localized number formats.
      	(fillin_negative_samples) : Not need to localize generated number
      	* src/dialogs/dialog-function-wizard.c (formula_guru_set_expr) : Use
      	* src/dialogs/dialog-stf-format-page.c
      	  (stf_dialog_format_page_prepare) : StyleFormats are now explicitly
      	  stored in a locale neutral format.
      	* src/functions/fn-string.c (gnumeric_text) : changes to
      	* src/functions/fn-financial.c (coupdayb) : Silence some warnings.
      	* src/functions/fn-information.c (translate_cell_format) : This should
      	  now work for different locales.
      2000-08-18  Jody Goldberg <jgoldberg@home.com>
      	* src/number-match.c (compute_value) : Extend the match algorithms to
      	  handle the new regexps.
      	* src/format.c (format_get_thousand) : provide a better default for
      	  countries using ',' as a decimal point.
  22. 11 Aug, 2000 1 commit
  23. 17 Jul, 2000 1 commit
    • Jody Goldberg's avatar
      Improve the look of diagonal double borders. They still handle · a4ba034b
      Jody Goldberg authored
      2000-07-16  Jody Goldberg <jgoldberg@home.com>
      	* src/border.c (style_border_draw) : Improve the look of diagonal double
      	  borders.  They still handle intersections poorly, but this improves
      	  things a bit.
      	(style_border_print) : Ditto.
      2000-07-16  Jody Goldberg <jgoldberg@home.com>
      	For : Matt Bissiri <bissiri@eecs.umich.edu>
      	* src/clipboard.c: Implemented 'paste link' and 'skip blanks' for paste special.
      	(paste_link): New function.
      	(paste_cell): Do not clear the target cells if PASTE_SKIP_BLANKS is specified.
      	Call paste_link if PASTE_LINK is specified.
      	* src/clipboard.h:
      	Added PASTE_LINK and PASTE_SKIP_BLANKS flags.
      	* src/dialogs/dialog-paste-special.c:
      	(transpose_cb): Rename transpose_cb -> checkbutton_toggled.
      	(dialog_destroy): New function.
      	(paste_link_set_sensitive): New function.
      	(dialog_paste_special): Add 'paste link' and 'skip blanks' to the dialog.
  24. 09 Jul, 2000 1 commit
    • Jody Goldberg's avatar
      Take units in pixels or points. (sheet_{col,row}_set_default_size_pixels) · b519fbd3
      Jody Goldberg authored
      2000-07-09  Jody Goldberg <jgoldberg@home.com>
      	* src/sheet.c (sheet_col_row_default_init) : Take units in pixels or
      	(sheet_{col,row}_set_default_size_pixels) : new functions.  This
      	  interface sucks.  Clean it up.
      	* src/parser.y : Optionally insert a place holder when an
      	  unknown function is found.
      	* src/func.c (function_add_placeholder) : New function, moved from the
      	  XL import code.
      	* src/expr.c (expr_parse_string) : gnumeric_expr_parser signature
      	* src/workbook.c (workbook_set_auto_expr) : Ditto.
      	* src/application.c (application_dpi_to_pixels) : New function.
      	* src/item-bar.c (item_bar_fonts_init) : Use it here.
      	* src/sheet-view.c (sheet_view_get_style_font) : And here.
      	* src/style.c (font_init) : and here.
      2000-07-08  Jody Goldberg <jgoldberg@home.com>
      	* src/parse-util.c (cellref_r1c1_get) : Make stricter.
      	(r1c1_get_item) : Ditto.
      2000-07-08  Jody Goldberg <jgoldberg@home.com>
      	* plugins/Makefile.am (SUBDIRS) : Enable applix.
      2000-07-08  Jody Goldberg <jgoldberg@home.com>
      	* src/parse-util.c (col_from_name) : Add optional arg to indicate
      	  where parsing stoped.  Similar to strtod.
      2000-07-07  Jody Goldberg <jgoldberg@home.com>
      	* src/xml-io.c (xml_write_style_border) : Trivial optimization.  No
      	  need to save colour for STYLE_BORDER_NONE.
      	(xml_read_style_border) : Ditto.
  25. 03 Jul, 2000 1 commit
    • Jody Goldberg's avatar
      Begin the Name menu. · 672ded42
      Jody Goldberg authored
      2000-07-03  Jody Goldberg <jgoldberg@home.com>
      	* src/workbook.c : Begin the Name menu.
      	* src/workbook-edit.c (workbook_edit_set_sensitive) : New function.
      	(workbook_finish_editing) : Use here.
      	(workbook_start_editing_at_cursor) : And here.
      	(workbook_edit_attach_guru) : And here.
      	(workbook_edit_detach_guru) : And here.
      	(workbook_edit_entry_redirect_p) : New function.
      	* src/item-grid.c (item_grid_button_1) : If we have a guru up, but are
      	  not selecting a region ignore clicks.
      	(item_grid_event) : Ditto.
      	* src/gnumeric-sheet.c (gnumeric_sheet_can_select_expr_range) : It is
      	  possible to have a guru up without selecting regions.
      	* src/expr-name.c (expr_name_list) : Doh!
      2000-07-02  Jody Goldberg <jgoldberg@home.com>
      	* src/expr.c (expr_rewrite) : Names can contain relative references,
      	  we need to check them too.
      	* src/parser.y (exp) : Add production for sheet specific names.
      	  eg Sheet2!name
      2000-07-01  Jody Goldberg <jgoldberg@home.com>
      	* src/functions/fn-string.c (parse_search_strin) : Use g_strdup.
  26. 28 Jun, 2000 2 commits
    • Jody Goldberg's avatar
      Ref the function here. · c3de6cfe
      Jody Goldberg authored
      2000-06-28  Jody Goldberg <jgoldberg@home.com>
      	* src/expr.c (expr_tree_new_funcall) : Ref the function here.
    • Jody Goldberg's avatar
      new function. · 93f11589
      Jody Goldberg authored
      2000-06-28  Jody Goldberg <jgoldberg@home.com>
      	* src/functions/fn-sheet.c (GNUMERIC_VERSION) : new function.
      	* src/workbook.c (workbook_do_destroy) : No need to release the
      	  clipboard here.  The Sheet does it for us.
      	* src/workbook-format-toolbar.c : Add Fill to the default money
      	* src/symbol.c : The only symbols are functions.  The global table
      	  should not be world visible.
      	* src/sheet.c (sheet_flag_status_update_cell) : Take a CellPos.
      	(sheet_get_extent_cb) : Use Cell::pos rather than adding an
      	(cb_set_cell_content) : Use StyleFormat.
      	(sheet_cell_set_value) : Call sheet_flag_status_update_cell.
      	(sheet_cell_set_value) : Ditto.
      	(sheet_destroy) : Prepare to clear out named expressions.
      	(colrow_move) : Handle changes in cell_relocate signature.
      	(sheet_move_range) : Ditto.
      	* src/sheet-autofill.c : Use StyleFormats.
      	* src/position.c (parse_pos_init) : Global position are permitted.
      	* src/parser.y : Large change.  Do not automaticlly look for function
      	  names or named expressions in the lexer.  The lexer returns STRING
      	  and QUOTED_STRING.  The parser then does the appropriate lookups to
      	  potentially convert to something else.  This allows us to have sheet
      	  names that are the same as functions.
      	* src/parse-util.c (cellref_name) : Add flag to optionally disable the
      	  addition of the sheet name.  This is useful when printing
      	  Sheet2!A1:A3 rather than Sheet2!A1:Sheet2!A3.
      	* src/number-match.c (format_create_regexp) : Handle fill formats.
      	* src/mstyle.c (mstyle_get_border) : Fix constness.
      	* src/mathfunc.c (combin, fact) : Moved these here from
      	* src/main.c (gnumeric_main) : No more constants_init, or
      	* src/func.c () : Reorg.  Remove some dead code.  Begin adding
      	  workbook local function support, Begin adding volatile, and
      	  semi-volatile functions.  Move the use of SymbolTable internal
      	  in preparation for eliminating it.
      	* src/format.c (format_number) : Improve support for pound, yen, and euro.
      	  Remember to produce a number when we hit spacing.
      	* src/expr.c : Have ExprFunc refer directly to the FunctionDefinition
      	  We still use a SymbolTable internally, but that will be merged out
      	* src/expr-name.c : Major reorg.  Not complete.
      	* src/corba-sheet.c (fill_corba_value) : Adjust to changes in
      	  cellref_name signature.
      	* src/commands.c (cmd_set_date_time_undo) : No need to manually call
      	  update_cell_flag.  cell_remove, and cell_set_text do that for us.
      	(cmd_set_date_time_redo) : Ditto.
      	  Use StyleFormat.
      	* src/clipboard.c (paste_cell) : Take the ExprRewriteInfo as an
      	(clipboard_paste_region) : Init the ExprRewriteInfo.  We need to do
      	  this here rather than in cell_relocate because we may be moving a
      	  region, not just a single cell, and references within the region
      	  should not be changed.
      	* src/cell.c (cell_relocate) : Take the relocation info as an
      	  argument.  Non NULL indicates a request to check bounds.  We can not
      	  do this at the cell level. becuase we may be moving a block rather
      	  than just a single cell, and references into the block should NOT be
      	(cell_set_text_and_value) : Take a StyleFormat.
      	(cell_assign_value) : Ditto.
      	(cell_set_value) : Ditto.
      	(cell_set_expr_internal) : Ditto.
      	(cell_set_expr_unsafe) : Ditto.
      	(cell_set_expr) : Ditto.
      	* src/auto-format.c (do_af_suggest) : Expression now refers directly
      	  to functionDef.
  27. 15 Jun, 2000 2 commits
    • Jody Goldberg's avatar
      Renamed from expr_decode_tree. (expr_tree_get_func_def) : new function. · 97623fb0
      Jody Goldberg authored
      2000-06-15  Jody Goldberg <jgoldberg@home.com>
      	* src/expr.c (expr_tree_as_string) : Renamed from expr_decode_tree.
      	(expr_tree_get_func_def) : new function.
      	(expr_tree_first_func) : New function.
      	* src/expr-name.c (expr_name_value) : Rename expr_decode_tree ->
    • JP Rosevear's avatar
      Use new value_compare API · 3dda226a
      JP Rosevear authored
      2000-06-15  JP Rosevear  <jpr@arcavia.com>
      	* src/expr.c (eval_expr_real): Use new value_compare API
      2000-06-14  JP Rosevear  <jpr@arcavia.com>
      	* src/value.h: Update value_compare prototype.
      	* src/value.c (value_compare): Make it take a new case
      	sensitive flag for string comparisons.
      	* src/sort.c (sort_compare_cells): Use value_compare to do the
      	comparisons.  Handle the special cases of blanks (always at
      	bottom, whether asc or desc) and errors (after booleans).
      2000-06-15  JP Rosevear  <jpr@arcavia.com>
      	* cell-sort.glade: Tidy the UI
      	* dialog-cell-sort.c (order_box_new): Make the clause boxes look
      	a little nicer.
  28. 08 Jun, 2000 1 commit
    • Jody Goldberg's avatar
      Do not make the edge visible, the scroll time will take care of that. · f4b6302b
      Jody Goldberg authored
      2000-06-08  Jody Goldberg <jgoldberg@home.com>
      	* src/sheet-view.c (sheet_view_{col,row}_selection_changed) :
      	  Do not make the edge visible, the scroll time will take care of
      	(sheet_view_{col,row}_size_changed) : Use the new undo wrappers.
      	(cb_colrow_resize) : Use the new undo wrappers.
      	(sheet_view_init) : Init the scroll timers.
      	(sheet_view_stop_sliding) : Based on the version from item_grid.
      	(sheet_view_start_sliding) : Ditto.
      	(sheet_view_sliding_callback) : Ditto.  Added callback support.
      	  tuned scroll parameters.
      	* src/number.h : Clear out unused cruft.
      	* src/item-grid.c : Move support for scroll timers into sheet-view.
      	* src/item-bar.c (get_element_from_pixel) : Renamed from
      	(cb_extend_selection) : New function.
      	(item_bar_event) : Use the sliding scroll mechanism in sheet_view.
      	* src/item-cursor.c (item_cursor_selection_event) : Adapt to changes in
      	(item_cursor_drag_event) : Ditto.
      	* src/sheet.c (sheet_foreach_colrow) : renamed and moved to.
      	* src/colrow.c (col_row_foreach) here.
      	* src/gnumeric-sheet.c (gnumeric_sheet_find_{col,row}) : Moved here
      	  and renamed from.
      	* src/item-grid.c (item_grid_find_{col,row}) : here.
      	* src/value.c (value_equal) : deleted.
      	(value_compare) : Moved and renamed from
      	* src/expr.c (compare) : here.
      	(expr_dump_tree) : Delete replicated function.
      	* src/colrow.c (col_row_size_list_destroy) :
      	(col_row_index_list_destroy) : New function.
      	(col_row_get_index_list) : New function.
      	(col_row_set_sizes) : New function.
      	(col_row_restore_sizes_group) : New function.
      	(col_row_save_sizes) : Moved from sheet.c
      	col_row_restore_sizes : Ditto.
      	cb_set_row_height : Ditto.
      	rows_height_update : Ditto.
      	src/commands.c (cmd_resize_row_col*) : Implement.
  29. 05 Jun, 2000 1 commit
    • Jody Goldberg's avatar
      renamed from sheet_cell_formula_{link,unlink}. · 7f94ba9e
      Jody Goldberg authored
      2000-06-05  Jody Goldberg <jgoldberg@home.com>
      	* src/sheet.c (sheet_cell_expr_{link,unlink}) : renamed from
      	* src/cell.c (cell_relocate) : Doh! use the offset flags now that they
      	  are being passed.
      	* src/clipboard.c (paste_cell) : Renamed from paste_cell_flags.
      	* src/expr.c (compare) : value_is_empty_cell -> VALUE_IS_EMPTY.
      	* src/value.c (VALUE_IS_EMPTY) : rename from value_is_empty_cell.
      	* src/sheet-private.h : Add resize_scrollbar.
      	* src/sheet.c (sheet_{col,row}_add) : Use resize_scrollbar flag rather
      	  than manually updating the scrolling bar.
      	(sheet_update) : Handle resize_scrollbar.
      	(sheet_cell_expr_link) : renamed from sheet_cell_formula_link.
      	(sheet_cell_expr_unlink) : renamed from sheet_cell_formula_unlink.
  30. 04 Jun, 2000 1 commit
    • Jody Goldberg's avatar
      str == "" is not empty · 112af83f
      Jody Goldberg authored
      2000-06-04  Jody Goldberg <jgoldberg@home.com>
      	* src/value.c (value_is_empty_cell) : str == "" is not empty
      	* src/expr.c (compare) : comparisons between "" and empty are special.
  31. 29 May, 2000 1 commit
  32. 24 May, 2000 1 commit
    • Morten Welinder's avatar
      Style now needs to be initialised before formats. · 169f4952
      Morten Welinder authored
      2000-05-24  Morten Welinder  <terra@diku.dk>
      	* src/main.c (gnumeric_main): Style now needs to be initialised
       	before formats.
      	* src/number-match.c (format_match): Take a StyleFormat ** instead
       	of a char ** for the suggested format.  All callers changed.
      	(format_parse_t): rename member format to format_str and
       	introduce new member format, a StyleFormat *.
      	(format_match_define): Get a style at this point.
      	* src/datetime.c (datetime_value_to_serial_raw): Don't supply a
       	format return variable to format_match since we aren't interested
       	in the result.
      	* src/parse-util.c (parse_text_value_or_expr): Return a
       	StyleFormat * instead of a char *.  All callers changed.
      	* src/expr.c (expr_parse_string): Take a StyleFormat ** instead of
       	a char ** for the suggested format.  All callers changed.
      	* src/parser.y (make_string_return): Turn parser_desired_format
       	into a StyleFormat **.
      	(gnumeric_expr_parser): Take a StyleFormat ** instead of a char **
       	for the suggested format.  All callers changed.
      	* src/auto-format.c (auto_style_format_suggest): New function.
      	* src/sheet-style.c (sheet_style_optimize): Include adjacent
       	ranges in the list of styles to consider.  Handle intervening
       	styles better.  Don't stop searching for matching pairs just
       	because we merge -- only when the merge kills the slave.
      	* src/ranges.c (range_dump): Don't print "\n".  All callers
       	changed as needed.
      	* src/sheet-style.c (sheet_style_optimize, sheet_styles_dump):
       	Send all debugging output to stderr.  (As opposed to half stderr
       	and half stdout.)
  33. 21 May, 2000 1 commit
    • Jody Goldberg's avatar
      A few delayed patches. · 2779b474
      Jody Goldberg authored
      These optimize paste, exit, sheet deletetion,
      and start the process for fixing a few things.
      2000-05-17  Jody Goldberg <jgoldberg@home.com>
      	* src/clipboard.c (clipboard_copy_cell_range) : Adjust signature to
      	  take a range.
      	(sheet_paste_selection) : Export in preparation for adding undo.
      	* src/commands.c (cmd_paste_copy) : Some initial work.  Not used or
      	* src/parse-util.c (parse_text_value_or_expr) : Start passing in the
      	  current format so that we can eventually attempt to match it before
      	  trying all the others.
      	* src/sheet.c (sheet_formulas_unlink) : New function.
      	(sheet_destroy_contents) : Optimize.
      	* src/dialogs/dialog-plugin-manager.c : Make a bit prettier.
      	* src/dialogs/plugin-manager.glade : Ditto.
      2000-05-16  Jody Goldberg <jgoldberg@home.com>
      	* plugins/*/*.c : Rationalize the naming scheme.
      2000-05-15  Jody Goldberg <jgoldberg@home.com>
      	* src/eval.[ch] : Rename
      	  cell_queue_recalc      -> eval_queue_cell
      	  cell_queue_recalc_list -> eval_queue_list
      	  cell_unqueue_recalc    -> eval_unqueue_cell
      	(eval_unqueue_sheet) : New function.
      	* src/sheet.c (sheet_cell_remove_simple) : Add precautionary removal
      	  of cells from recalc list.  We should not need this in most
      	  instances, but the check is inexpensive so I'll play it safe.
      	(sheet_destroy_contents) : Batch cleanups rather than doing it cell by
      	* src/cell.c (cell_make_value) : Fill in the implementation.
      	* src/clipboard.c (paste_cell_flags) : Remove some dead code.
      	  Merged in paste_cell and fixed handling of paste by value.
      2000-05-14  Jody Goldberg <jgoldberg@home.com>
      	* src/clipboard.c (paste_cell) : No need to call cell_content_changed
      	  we can queue the recalc for the entire region later.  It is
      	  sufficent to make the cell as changed with sheet_cell_changed.
      	(paste_cell) : It is premature to redraw, we have no yet calculated
      	  spans.  Redraw and respan at the range level, not the cell.
  34. 06 May, 2000 1 commit
    • Michael Meeks's avatar
      Add 3D dependency support. (cb_single_hash_to_list, · 479bddb8
      Michael Meeks authored
      2000-05-06  Michael Meeks  <michael@helixcode.com>
      	* src/eval.c (handle_cell_range_deps): Add 3D dependency support.
      	(cb_single_hash_to_list, cb_range_hash_to_list): Re-arrange handling of
      	where the list is collated. (do_deps_destroy): update.
      	(cell_drop_dependencies): remove cretinism here.
      	(drop_cell_range_dep, handle_cell_single_dep): return on NULL deps structure.
      	* src/sheet-style.c (sheet_style_attach): enable cache trash avoidance code.
      	* src/sheet.c (sheet_cell_remove_internal): short circuit for NULL
      	* src/expr.c (expr_rewrite): update to handle workbook case.
      	* src/eval.c (workbook_deps_destroy): update for speed.
      	(sheet_deps_destroy): split body into (do_deps_destroy): here.
      	* src/workbook.c (workbook_delete_sheet): destroy the sheet's
      	dependencies here as well; very silly. (workbook_do_destroy): destroy
      	deps of all sheets up front.
  35. 04 May, 2000 1 commit
    • Jody Goldberg's avatar
      Desensitize the '=' during editing. · 786d336b
      Jody Goldberg authored
      Fix typ in toolbar init.
      Fix typo in sheet deletion.
      2000-05-04  Jody Goldberg <jgoldberg@home.com>
      	* src/workbook.c : Fix typo that was calling undo for redo toolbar.
      	({redo,undo}_cmd) : Use workbook_finish_editing directly.
      	(cb_auto{function,sum}) : If we are already editing do not start.
      	  When the wizard is in place bring it up.
      	(workbook_start_editing_at_cursor) : Make the '=' insensitive while
      	(workbook_finish_editing) : Make the '=' sensitive.
      	(sheet_action_delete_sheet) : Fix typo and rename parm
      	  'current_sheet' -> 'sheet' to avoid confision with
  36. 03 May, 2000 2 commits
    • Jody Goldberg's avatar
      Begin to rationalize support for inverted and 3D references. · de62dd3a
      Jody Goldberg authored
      More renaming and movement name rationalization.
      Some minor improvements in the function wizard.
      2000-05-03  Jody Goldberg <jgoldberg@home.com>
      	* EvalPosition -> EvalPos
      	  ParsePosition -> ParsePos
      	  new struct RangeRef used in ValueRange
      	  eval_pos_init* -> position.[ch]
      	* src/workbook.c : Reorder the toolbar a bit.
      	(workbook_foreach_cell_in_range) : New function.
      	(cb_autofunction) : New routine.
      	(workbook_set_auto_expr) : DO NOT put real code into pre/post
      	  conditions.  It will be removed when debugging is eventually
      	* src/position.c (range_ref_normalize) : New function.
      	* src/ranges.c (range_normalize) : New function.
      	* src/expr.c (expr_implicit_intersection) : Use range_ref_normalize.
      	* src/eval.c (cell_eval_content) : No need to release the value.
      	  cell_assign_value already does that.
      	(dependency_range_ctor) : Use range_normalize.
      	* src/auto-format.c (do_af_suggest) : Use workbook_foreach_cell_in_range.
      	* src/cell.c (cell_set_expr_and_value) : link the new expression but
      	  do not queue it for recalc.
      	(cell_assign_value) : Release the old value.
      	(cell_copy) : Init the value to empty.
      	* src/func.c (function_iterate_do_value) : Use
      	* src/dialogs/dialog-function-wizard.c (create_description) : Use
      	  a label rather than a text entry widget.  It looks better.
      	* src/functions/fn-string.c (gnumeric_expression) : range is already
      	* src/functions/fn-stat.c (gnumeric_linest) : Handle inverted ranges.
      	(gnumeric_logest) : Ditto.
      	* src/functions/fn-information.c (gnumeric_countblank) : Use
      	(gnumeric_{row,column}) : Handle inversions.
      	* src/functions/fn-lookup.c (gnumeric_offset) : No need to make
      	  absolute.  The marshaller already did that.
      2000-05-02  Jody Goldberg <jgoldberg@home.com>
      	* src/eval.c (dependency_range_ctor) : normalize the range.
      	* src/xml-io.c (xml_write_cell_and_position) : Suppress warning.
      	* src/pixmaps.h : Add function wizard and equal sign.
    • Almer. S. Tigelaar's avatar
      s/strcasecmp/g_strcasecmp/ · 4741a7a5
      Almer. S. Tigelaar authored
      2000-05-03  Almer. S. Tigelaar.  <almer1@dds.nl>
      	* *.c: s/strcasecmp/g_strcasecmp/
  37. 02 May, 2000 1 commit
    • Jody Goldberg's avatar
      New function. · b2198f30
      Jody Goldberg authored
      2000-05-01  Jody Goldberg <jgoldberg@home.com>
      	* src/expr.c (expr_tree_shared) : New function.
      	* src/xml-io.c (gnumeric_xml_write_selection_clipboard) : Init and
      	  destroy the expression hash.
      	(gnumeric_xml_read_selection_clipboard) : Ditto.
      	(gnumeric_xml_read_workbook) : Ditto.
      	(gnumeric_xml_write_workbook) : Ditto.
      	(xml_write_cell_and_position) : When saving cells that have expression
      	  assign and store an ID for shared expressions.
      	(xml_read_cell) : Use the ID to restore shared expressions.