GitLab

2001-04-30  Almer S. Tigelaar  <almer@gnome.org>

	* src/parser.y (gnumeric_expr_parser) : Give a warning
	when both the resulting ExprTree and error message is non-null.
	This should never happen.

2001-04-29  Jody Goldberg <jgoldberg@home.com>

	* ms-excel-write.c (write_window2) : Headers are in default style.
	  And grid colour is auto, not black.

2001-04-29  Jody Goldberg <jgoldberg@home.com>

	* src/parser.y (yylex) : return INVALID_TOKEN rather than EOF when a
	  lexical error is found.

2001-04-29  Almer S. Tigelaar  <almer@gnome.org>

	* fn-information.c (gnumeric_cell): Implement remaining
	information types for the CELL function.
	(retrieve_format_info): A helper function for gnumeric_cell
	for gathering format characteristics.

2001-04-29  Almer S. Tigelaar  <almer@gnome.org>

	* src/commands.c (cmd_zoom) : Implement zoom undo/redo
	(cmd_zoom_destroy) : Idem.
	(cmd_zoom_redo): Idem.
	(cmd_zoom_undo): Idem.

	* src/workbook-control-gui.c (cb_change_zoom):
	Use cmd_zoom here.

intersections of double lines.  However, nothing significant.

2001-04-28  Jody Goldberg <jgoldberg@home.com>

	* src/style-border.c (print_hline) : handle offset of screen coords vs
	  printer coords.
	(print_vline) : ditto.
	(style_borders_row_print) : sync with style_borders_row_draw and pass
	  width to the line drawing to handle different coordinate types.

	* src/ranges.c (range_translate) : warn if clipped not just if
	  removed.

	* src/clipboard.c (clipboard_prepend_cell) : store the source sheet if
	  possible.
	(paste_link) : Use the right sheets.
	(clipboard_paste_region) : send enough information into paste_link.

2001-04-27  Jody Goldberg <jgoldberg@home.com>

	* src/format.c (pre_parse_format) : Catch fractions too.
	(render_number) : don't pass in so many copies of flags.  Just use the
	  info struct.  Add a 'has_fraction' flag to disable rounding.
	(do_render_number) : ditto.
	(stern_brocot) : simple stern brocot tree.  Should really use an
	  adaptive precision but I am lazy.
	(format_number) : add fractions.

	* src/commands.c (cmd_autofill_redo) : changing visiblity can triger a
	  draw which requiresthat things be rendered and spanned.  Be sure to
	  complete the action BEFORE changing visibility.

2001-04-27  Chema Celorio  <chema@celorio.com>

	* src/sheet-object.h: add the header for clone_sheet

	* src/sheet-object.c (sheet_object_clone): implement
	(sheet_object_clone_sheet): implemnt.

	* src/sheet-object-widget.c (SOW_MAKE_TYPE): add read_xml, write_xml
	and clone methods to macro
	(sheet_object_widget_clone): implement.
	Implement for X in label, frame, button, checkbox
	(sheet_widget_x_construct_with_label):
	(sheet_widget_x_destroy):
	(sheet_widget_x_clone):
	(sheet_widget_x_write_xml):
	(sheet_widget_x_read_xml):

	(sheet_object_widget_register): implement

	* src/sheet-object-impl.h: add the clone method

	* src/sheet-object-graphic.c (sheet_object_graphic_clone): implement.
	(sheet_object_filled_clone): implement.

	* src/sheet-object-cell-comment.c (cell_comment_clone): implement

2001-04-26  Jon K Hellan  <hellan@acm.org>

	* src/item-grid.c (item_grid_button_1): Invoke
	scg_start_range_selection rather than
	gnumeric_sheet_start_range_selection.

	* src/sheet-control-gui.[ch] (scg_start_range_selection): New function.
	Start range selection in gsheet and notify expr entry.

2001-04-26  Jody Goldberg <jgoldberg@home.com>

	* ms-excel-write.c (write_colinfos) : Rework to simplify and use
	  colrow_equal.
	(write_colinfo) : extract the info from the ColRowInfo directly and
	  fill in the visibility, outline, and collapse states.
	(write_rowinfo) : export visibility, collapse and outline.
	(write_guts) : new function.
	(new_sheet) : Include blank cols/rows with outline properties in
	  extent calculation.

	* ms-excel-write.h (Excel{Col,Row}) : Delete unnecessary structures.

2001-04-26  Jody Goldberg <jgoldberg@home.com>

	* configure.in : Add configure checks for finite and isfinite

	* src/mathfunc.h (FINITE) : Move the #define wrapper out here.

2001-04-26  Jody Goldberg <jgoldberg@home.com>

	* src/mathfunc.h (FINITE) : Move the #define wrapper out here.

	* src/cell.c : prune some includes
	(cell_default_halign) : rename to
	* src/style.c (style_default_halign) : to simplify headers for systems
	  that do not support fwd declarations of enums. H - cough - PUX

2001-04-26  Jody Goldberg <jgoldberg@home.com>

	* ms-excel-write.c (write_mergecells) : new routine to save merged
	  regions.
	(write_sheet_tail) : called from here.

2001-04-26  Jody Goldberg <jgoldberg@home.com>

	* xml-sax-read.c (xml_cell_set_array_expr) : oops accidentally backed
	  out a patch.

2001-04-26  Morten Welinder  <terra@diku.dk>

	* src/stf-parse.c: Put a decisive end to the signed-vs-unsigned
	problems in here.  It's all glib's fault, really.

2001-04-26  Morten Welinder  <terra@diku.dk>

	* src/stf-parse.c (stf_parse_options_fixed_autodiscover): Fix a
 	signed vs. unsigned error.  (We underflowed from 0 to
 	0xffff...ff.)

2001-04-26  Morten Welinder  <terra@diku.dk>

	* dialog-solver.c (dialog_solver): Plug leak.

2001-04-26  Jody Goldberg <jgoldberg@home.com>

	* src/item-grid.c (item_grid_class_init) : Drat part of a canceled
	  patch slipped in.

2001-04-26  Jon K Hellan  <Jon.Hellan@clustra.com>

	* POTFILES.in: Change from gnumeric.xml to GNOME_Gnumeric.xml

2001-04-26  Jon K Hellan  <hellan@acm.org>

	* src/item-grid.c (item_grid_draw_background): Fix typo.

	* src/gnumeric-util.c (gnumeric_dialog_run): Fix silly mistake

2001-04-26  Jon K Hellan  <hellan@acm.org>

	* src/gnumeric-util.c (gnumeric_wb_dialog_run): Eliminate attempt
	to handle parent being closed underneath dialog running a
	recursive mainloop. That can't happen since GTK 1.2.7. Move what
	remains of the function into gnumeric_dialog_run.
	(gnumeric_dialog_run): See above.
	(gnumeric_set_transient): Place dialog according to user's
	placement policy.
	(gnumeric_non_modal_dialog): Use gnumeric_set_transient to get
	placement right.

	* src/gui-file.c (gui_file_save_as, dialog_query_load_file):
	No longer place at mouse, since gnumeric_set_transient now
	honours user's dialog placement policy.

2001-04-25  Jody Goldberg <jgoldberg@home.com>

	* src/sheet-style.c (sheet_style_get_list) : Add a horizontal merge
	  before dumping to a list.
	(cb_hash_to_list) : free elements that have been merged in the
	  horizonal step, but have not yet been removed.
	(cb_hash_merge_horiz) : new function. merge when possible, after a
	  merge either free the useless bit or mark it as useless for later
	  removal.
	(cb_style_list_add_node) : Use mstyle_equal for now to remerge
	  different instances of the same logical style.  This is necessary
	  until I finish the per sheet style index.
	(sheet_style_init) : add some sanity checks incase some bright boy
	  decides to up the size of sheet and forgets here.

	* src/xml-io.c (xml_sheet_write) : Add the properties for the
	  outline mode preferences.
	(xml_sheet_read) : ditto.

	* src/item-debug.h : fix the messages to include the module
	* src/item-bar.c : fix the item-debug grab/ungrab messages.
	(item_bar_update) : gnome_canvas_group_child_bounds is a deprecated
	  useless call.
	* src/item-edit.c : fix the item-debug grab/ungrab messages.
	(recalc_spans) : gnome_canvas_group_child_bounds is a deprecated
	  useless call.
	* src/item-grid.c : fix the item-debug grab/ungrab messages.
	(item_grid_update) : gnome_canvas_group_child_bounds is a deprecated
	  useless call.
	(item_grid_button_1) : If we are going to start selecting a range have
	  the grid to a grab on button down.  This should fix the pseudo-race
	  condition that was irritating the ExprEntry.

	* src/preview-grid.c (preview_grid_update) :
	  gnome_canvas_group_child_bounds is a deprecated useless call.
	* src/item-cursor.c : fix the item-debug grab/ungrab messages.
	(item_cursor_point) : animated cursors should never receive events.

	* src/cell-draw.c (cell_draw) : It is perfectly reasonable for
	  narrow/short cols/rows to produce cells that have negative sizes
	  with the margins removed.  exit silently.

2001-04-25  Jody Goldberg <jgoldberg@home.com>

	* xml-sax-read.c (xmlSaxParseSheet) : Add flags for the outline
	  preferences.

2001-04-25  Almer S. Tigelaar  <almer@gnome.org>

	* src/stf-parse.c (stf_parse_options_fixed_autodiscover):
	Fix ugly discovering error that can cause a non-existant column
	to be discovered if there are leading spaces and avoid skipping
	over columns that should be checked for emptyness. Fixes Bug #53499

2001-04-24  Almer S. Tigelaar  <almer@gnome.org>

	* src/number-match.c : We are using the fabs function, so
	include math.h

2001-04-24  Morten Welinder  <terra@diku.dk>

	* src/parse-util.c (gnumeric_char_start_expr_p): Make sure lines
 	like "-----------" are not considered expressions.  (Even though
 	XL does.)

2001-04-23  Jon K Hellan  <hellan@acm.org>

	* src/sheet-control-gui.c (scg_stop_range_selection): Stop
	sliding. This was a race condition. The slide handler would think
	we were still range selecting.

2001-04-23  Jon K Hellan  <hellan@acm.org>

	* ms-biff.c (ms_biff_query_next, ms_biff_query_next,
	ms_biff_query_destroy, ms_biff_put_new, ms_biff_put_commit,
	ms_biff_put_len_next): Make sure that bp->data = 0 when
	bp->data_malloced = 0 & v.v. This helps heap debugging.
	(ms_biff_put_len_next): Assert that data pointer is null. If it
	weren't the old code would have been leaking.

2001-04-23  Morten Welinder  <terra@diku.dk>

	* src/number-match.c (compute_value): Handle negative numbers(!).
  	Handle overflow better.

2001-04-23  Morten Welinder  <terra@diku.dk>

	* src/gui-clipboard.c (x_selection_to_cell_region): Plug leak.

2001-04-23  Almer S. Tigelaar  <almer@gnome.org>

	* src/workbook-edit.c (workbook_finish_editing): Give focus
	to the edit line when an error is encountered.
	* src/workbook-control-gui.c
	(wbcg_close_control) : Don't store the partially entered expression
	when we are going to close.
	(cb_file_quit) : Idem.
	(cb_notebook_switch_page) : Idem, for switching between tabs
	when we are _not_ in a subexpression.

	* src/parser.y : Correct off-by-one glitches and strtod exponent
	out of range error problem.

	* src/expr.[ch] (expr_parse_string): Use a ParseError struct
	instead of an error string.

	* src/commands.c (cmd_area_set_text_redo): Use expr_parse_string
	in the newly corrected fashion.
	* src/expr-name.c (expr_name_create): Idem, require a ParseError
	struct to be passed instead of a char** aswell.
	* src/parse-util.c (parse_text_value_or_expr): Idem.
	* src/sheet-object-widget.c (cb_checkbox_config_clicked): Idem.
	* src/test-parser.c (main): Idem.
	* src/xml-io.c (xml_cell_set_array_expr): Idem.

	* src/sheet.c (sheet_clone_names): Use expr_name_create which now
	uses ParseError instead of char **.
	* src/xml-io.c (xml_read_names): Idem.

2001-04-23  Almer S. Tigelaar  <almer@gnome.org>

	* dialog-define-names.c (cb_name_guru_add):
	Correct use of expr_parse_string.