1. 24 May, 2000 2 commits
  2. 22 May, 2000 4 commits
    • Jody Goldberg's avatar
      typo · 913554e0
      Jody Goldberg authored
      913554e0
    • Jody Goldberg's avatar
      New files. · 77d84d6c
      Jody Goldberg authored
      
      2000-05-21  Jody Goldberg <jgoldberg@home.com>
      
      	* src/cmd-edit.[ch] : New files.
      
      	* src/workbook.c (cb_edit_select_*) : Use the cmd-edit utilities.
      	Make a 'select' sub menu of edit.
      
      	* src/sheet.c : Use the newly added CellPos in each Cell rather than
      	  mallocing a seperate struct.
      
      	* src/selection.c (sheet_select_all) : Move.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) : Make the
      	  selection commands accelerators.
      77d84d6c
    • Jon K Hellan's avatar
      New functions. Pack widget in eventbox and add eventbox to toolbar. This · c56a9a92
      Jon K Hellan authored
      2000-05-21  Jon K Hellan  <hellan@acm.org>
      
      	* src/gnumeric-util.[ch] (gnumeric_toolbar_insert_with_eventbox):
      	(gnumeric_toolbar_append_with_eventbox): New functions. Pack
      	widget in eventbox and add eventbox to toolbar. This lets a
      	windowless widget (e.g. combo box) have tooltips.
      
      	* src/workbook-format-toolbar.c (workbook_create_format_toolbar):
      	Enable tooltips for combo boxes. We do this by using
      	gnumeric_toolbar_{insert|append}_with_eventbox instead of
      	gtk_toolbar_{insert|append}_widget.
      
      	* src/workbook.c (workbook_create_standard_toobar): Ditto
      c56a9a92
    • Jon K Hellan's avatar
      Disconnect list_unselect_cb, otherwise we get warnings during list · e700a091
      Jon K Hellan authored
      2000-05-21  Jon K Hellan  <hellan@acm.org>
      
      	* gtk-combo-text.c (gtk_combo_text_destroy): Disconnect
      	list_unselect_cb, otherwise we get warnings during list shutdown.
      	(list_select_cb): Change it to handle list::select_child instead
      	of listitem::select. Change signature accordingly.
      	(list_select_cb): Invalidate cached state if selecting cached
      	widget.
      	(list_unselect_cb): New callback. Handles unselect by re-selecting
      	if list is visible. This makes it impossible to deselect
      	interactively.
      	(cb_toggle): New callback. Handle <Ret> which by default toggles
      	the list item, and make it select instead.
      	(gtk_combo_text_add_item): Don't connect list_select_cb, that's
      	now done in gtk_combo_text_construct. Connect cb_toggle.
      	(gtk_combo_text_construct): Connect list_select_cb and
      	list_unselect_cb.
      e700a091
  3. 21 May, 2000 4 commits
    • Jon K Hellan's avatar
      Remove label from invisible column title. · 6edf3f80
      Jon K Hellan authored
      2000-05-21  Jon K Hellan  <hellan@acm.org>
      
      	* src/dialogs/dialog-zoom.glade: Remove label from invisible
      	column title.
      
      	* src/dialogs/plugin-manager.glade(.h?): Add accelerators to
      	notebook tabs.
      
      	* src/dialogs/autocorrect-exceptions.glade(.h?): Add accelerators to
      	buttons on notebook pages.
      
      	* src/dialogs/workbook-attr.glade(.h?): Ditto.
      6edf3f80
    • Jody Goldberg's avatar
      A few delayed patches. · 2779b474
      Jody Goldberg authored
      These optimize paste, exit, sheet deletetion,
      and start the process for fixing a few things.
      
      2000-05-17  Jody Goldberg <jgoldberg@home.com>
      
      	* src/clipboard.c (clipboard_copy_cell_range) : Adjust signature to
      	  take a range.
      	(sheet_paste_selection) : Export in preparation for adding undo.
      
      	* src/commands.c (cmd_paste_copy) : Some initial work.  Not used or
      	  complete.
      
      	* src/parse-util.c (parse_text_value_or_expr) : Start passing in the
      	  current format so that we can eventually attempt to match it before
      	  trying all the others.
      
      	* src/sheet.c (sheet_formulas_unlink) : New function.
      	(sheet_destroy_contents) : Optimize.
      
      	* src/dialogs/dialog-plugin-manager.c : Make a bit prettier.
      	* src/dialogs/plugin-manager.glade : Ditto.
      
      2000-05-16  Jody Goldberg <jgoldberg@home.com>
      
      	* plugins/*/*.c : Rationalize the naming scheme.
      
      2000-05-15  Jody Goldberg <jgoldberg@home.com>
      
      	* src/eval.[ch] : Rename
      	  cell_queue_recalc      -> eval_queue_cell
      	  cell_queue_recalc_list -> eval_queue_list
      	  cell_unqueue_recalc    -> eval_unqueue_cell
      	(eval_unqueue_sheet) : New function.
      
      	* src/sheet.c (sheet_cell_remove_simple) : Add precautionary removal
      	  of cells from recalc list.  We should not need this in most
      	  instances, but the check is inexpensive so I'll play it safe.
      	(sheet_destroy_contents) : Batch cleanups rather than doing it cell by
      	  cell.
      
      	* src/cell.c (cell_make_value) : Fill in the implementation.
      
      	* src/clipboard.c (paste_cell_flags) : Remove some dead code.
      	  Merged in paste_cell and fixed handling of paste by value.
      
      2000-05-14  Jody Goldberg <jgoldberg@home.com>
      
      	* src/clipboard.c (paste_cell) : No need to call cell_content_changed
      	  we can queue the recalc for the entire region later.  It is
      	  sufficent to make the cell as changed with sheet_cell_changed.
      	(paste_cell) : It is premature to redraw, we have no yet calculated
      	  spans.  Redraw and respan at the range level, not the cell.
      2779b474
    • Jody Goldberg's avatar
      Release 0.54 · f3beffbe
      Jody Goldberg authored
      f3beffbe
    • Jody Goldberg's avatar
      remove some debugging that snuck in. · 09c9d5f0
      Jody Goldberg authored
      09c9d5f0
  4. 20 May, 2000 9 commits
    • Jody Goldberg's avatar
      Bump reqs. libglade >= .13, gnome-print .20 · e14a5378
      Jody Goldberg authored
      
      2000-05-20  Jody Goldberg <jgoldberg@home.com>
      
      	* configure.in : Bump reqs.  libglade >= .13, gnome-print .20
      
      	* src/cellspan.c (cell_calc_span) : Do not overlap spans when using
      	  center across selection.
      e14a5378
    • Jody Goldberg's avatar
      Add strikethrough. ({bold,italic,underline}_cmd) : Handle accelerators · 95a55b89
      Jody Goldberg authored
      
      2000-05-20  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook-format-toolbar.c (change_selection_font) : Add strikethrough.
      	({bold,italic,underline}_cmd) : Handle accelerators too.
      95a55b89
    • Jody Goldberg's avatar
      We still need to partially clear the clipboard when short circuiting. · 48952473
      Jody Goldberg authored
      
      2000-05-20  Jody Goldberg <jgoldberg@home.com>
      
      	* src/application.c (application_set_selected_sheet) : We still need
      	  to partially clear the clipboard when short circuiting.
      48952473
    • Jody Goldberg's avatar
      Chema bug 4 - undo unhide broken. · 55f23f4f
      Jody Goldberg authored
      Chema bug 6 - Clearing cell immediately beside a blocked span do not respan.
      Chema bug 7 - contents of spanning hidden rows/cols still visible.
      
      2000-05-20  Jody Goldberg <jgoldberg@home.com>
      
      	* src/item-grid.c (item_grid_draw) : Do not draw the contents of
      	  hidden spanning rows/cols.
      	* src/print-cell.c (print_cell_range) : Ditto.
      
      	* src/colrow.c (cb_row_col_visibility) : Be careful not to compare
      	  TRUE for equality.
      
      	* src/sheet.c
      	(sheet_update_cursor_pos) : warning suppression.
      	(sheet_row_col_visible) : Be careful not to compare TRUE for equality.
      	(sheet_clear_region) : respan both sides of a singleton row/col.
      	  Check for cells to either side even if there is no span,  if we are
      	  directly adjacent to a cell it would have no span even if it wanted
      	  one.
      55f23f4f
    • Jody Goldberg's avatar
      Still more Chema discovery. · 7355ba25
      Jody Goldberg authored
      2000-05-19  Jody Goldberg <jgoldberg@home.com>
      
      	* src/cell.c (cell_set_format) : Apply the format to a NEW style, not the current
      	   style which may be say .... the DEFAULT!!!
      7355ba25
    • Jody Goldberg's avatar
      Fix a few Chema bugs. · 6166dda7
      Jody Goldberg authored
      The cursor border was not being resized when rows/cols were hidden.
      Cell contents were not being re-rendered/sized when the format was
          cleared.
      
      2000-05-19  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_update) : Update cursor positions when visibility
      	  changes.
      	(sheet_clear_region) : When clearing formats we need to update the
      	  spans and sizes of the contents.
      	(sheet_update_cursor_pos) : New function.
      	(sheet_row_col_visible) : changing the status of a row/col changes visibility.
      
      	* src/sheet-view.c (sheet_view_update_cursor_pos) : New function split
      	  out from sheet_view_set_zoom_factor.
      	(sheet_view_set_zoom_factor) : Use sheet_view_update_cursor_pos.
      6166dda7
    • Jody Goldberg's avatar
      Doh! Fix the rest of the paste crashes. · 451b2fd3
      Jody Goldberg authored
      Doh!
      Fix the rest of the paste crashes.
      
      2000-05-19  Jody Goldberg <jgoldberg@home.com>
      
      	* src/cell.c (cell_copy) : Ref the format if one exists.
      451b2fd3
    • Jody Goldberg's avatar
      Fix warning when attempting to auto size rows after a font change · 56f885ff
      Jody Goldberg authored
      2000-05-19  Jody Goldberg <jgoldberg@home.com>
      
      	* src/colrow.c (cb_set_row_height) : Only set the height if it
      	  changed.
      56f885ff
    • Jody Goldberg's avatar
      Bug 11572 · 7c57a4f3
      Jody Goldberg authored
      2000-05-19  Jody Goldberg <jgoldberg@home.com>
      
      	* src/application.c (application_set_selected_sheet) : No need to
      	  clear the X selection if we already own it.
      7c57a4f3
  5. 19 May, 2000 5 commits
  6. 18 May, 2000 5 commits
    • Jody Goldberg's avatar
      Correct double negative that was breaking printing for cells with multiple · 69c8a60d
      Jody Goldberg authored
      
      2000-05-18  Jody Goldberg <jgoldberg@home.com>
      
      	* src/print-cell.c (print_cell) : Correct double negative that was
      	  breaking printing for cells with multiple lines that were bottom
      	  or center aligned.
      69c8a60d
    • Jon K Hellan's avatar
      Do nothing if no selection. · 55ce9234
      Jon K Hellan authored
      2000-05-18  Jon K Hellan  <hellan@acm.org>
      
      	* gtk-combo-text.c (cb_list_mapped): Do nothing if no selection.
      55ce9234
    • Jody Goldberg's avatar
      Adjust includes to remove warning. · bc2364e9
      Jody Goldberg authored
      
      2000-05-18  Jody Goldberg <jgoldberg@home.com>
      
      	* src/normal-args.c : Adjust includes to remove warning.
      bc2364e9
    • Jon K Hellan's avatar
      New callback function. Sets focus to selected item, which also happens to · e409a9ec
      Jon K Hellan authored
      2000-05-18  Jon K Hellan  <hellan@acm.org>
      
      	* gtk-combo-text.c (cb_list_mapped): New callback function. Sets
      	focus to selected item, which also happens to make it visible.
      	(gtk_combo_text_construct): Call
      	gtk_container_set_focus_hadjustment - this enables autoscroll and
      	keyboard scrolling. Connect cb_list_mapped.
      
      2000-05-15  Jon K Hellan  <hellan@acm.org>
      
      	* gtk-combo-box.h: Declare gtk_combo_box_set_display. It was
      	declared global in gtk-combo-box.c - apparently on purpose.
      
      	* gtk-combo-box.c: Make behaviour more like tearoff menus for
      	consistency: Make it possible to popup the original combo while
      	the tearoff menu is up.
      	(deactivate_arrow): New function. Set arrow button visual to
      	inactive. Code moved from gtk_combo_box_popup_hide_unconditional.
      	(gtk_combo_box_popup_hide_unconditional): See above.
      	(gtk_combo_box_popup_hide): Handle case where popup is hidden
      	while tearoff menu is up.
      	(gtk_combo_box_popup_display): Remove !torn_off assertion and
      	handle torn_off case.
      	(gtk_combo_popup_tear_off): Add set_position parameter, true if
      	tearoff window wasn't already up. Queue a resize to fix confusion
      	about size.
      	(gtk_combo_set_tearoff_state): Deactivate arrow button when
      	tearing off - because button now works as usual in torn off state.
      	(gtk_combo_tearoff_bg_copy): Remove #if 0 around it. Make comment
      	short and clear now that I understand what it's for. More info in
      	comment at point it is called from. Use allocation geometry
      	instead of requisition, in case tearoff window has been resized.
      	(cb_tearable_button_release): Remove some unnecessary
      	conditionals. Too much cut and paste?
      e409a9ec
    • Michael Meeks's avatar
      Re-tool for built-in libole2, requires a re-checkout. · db5283b2
      Michael Meeks authored
      2000-05-16  Michael Meeks  <michael@helixcode.com>
      
      	* configure.in: Kill libole2 path check, add CONFIG_SUBDIRS
      	(EXTRA_GNOME_*): remove libole2.
      db5283b2
  7. 17 May, 2000 5 commits
    • Jody Goldberg's avatar
      Free the args. · 47ae1f61
      Jody Goldberg authored
      2000-05-17  Jody Goldberg <jgoldberg@home.com>
      
      	* src/xml-io.c (xml_workbook_write) : Free the args.
      47ae1f61
    • Jody Goldberg's avatar
      Fix more memory errors. · 98e8cf26
      Jody Goldberg authored
          creating rows/cols when resizing empties.
      
      2000-05-17  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c
      	(sheet_{col,row}_size_fit_pixels) : Return 0 if there are no cells.
      
      	* src/summary.c (summary_item_as_text) : Be careful to strdup all strings.
      	(g_str_case_equal) : Delete duplicate.
      	(g_str_case_hash) : Delete duplicate.
      	(summary_info_new) : Use gnumeric_strcase_hash & gnumeric_strcase_equal.
      
      	* src/workbook-cmd-format.c (workbook_cmd_format_{column,row}_auto_fit) :
      	  Only mark the sheet as dirty if something was changed.
      
      	* src/stf.c (stf_read_workbook) :  Bring up to date.
      
      	* src/xml-io.c (xml_write_attributes) : Do not use freed memory.
      
      	* src/item-bar.c (item_bar_event) : Autosizing an empty row/col
      	  returns 0.
      98e8cf26
    • Jody Goldberg's avatar
      Fix - bug 9984, fix embedded bonobo objects a starting size > 0,0 - · e934a82d
      Jody Goldberg authored
      Fix
          - bug 9984, fix embedded bonobo objects a starting size > 0,0
          - vertical justification was broken
          - a few warnings.
      
      2000-05-17  Jody Goldberg <jgoldberg@home.com>
      
      	* src/cell-draw.c (cell_draw) : Cache the vertical alignment, and
      	  ensure that verticaly justified lines do not overlap.
      	* src/print-cell.c (print_cell) : Ditto.
      
      	* src/sheet-object.c (sheet_set_mode_type_full) : Add a prototype to
      	  avoid warnings.
      
      	* src/sheet-object.c (create_object) : Ugly workaround for bug 9984.
      	  Ensure that objects do not start with size 0,0.
      e934a82d
    • Jody Goldberg's avatar
      Fixes UMR on ins/del row/col · 18e98f9a
      Jody Goldberg authored
      Fixes import to display numbers.
      
      2000-05-17  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook.c (workbook_expr_relocate) : Add missing
      	  initialization.
      
      	* src/file.c (file_finish_load) : New function to finish loading after
      	  a read or import.
      	(workbook_read) : Use here.
      	(workbook_import) : And here.
      18e98f9a
    • Jody Goldberg's avatar
      Fix bugs 10705 10775 11159 Morten's autofill UMR Han's crash on sheet · efd376c0
      Jody Goldberg authored
      Fix bugs
          10705
          10775
          11159
          Morten's autofill UMR
          Han's crash on sheet deletion.
      
      2000-05-17  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_get_extent) : Disable the use of
      	  sheet_style_get_extent until it is more intelligent.
      
      	* configure.in : Produce a Using OAF message in the non-bonobo case
      	  too.  Limit xml to version 1.x for now.
      
      	* src/cell.c (cell_set_text_and_value) : Set the entered_text BEFORE
      	  the value so that cells with format = text render correctly.
      efd376c0
  8. 15 May, 2000 2 commits
    • Jody Goldberg's avatar
      Revert BUGS and regess.gnumeric entries · c48ba606
      Jody Goldberg authored
      INT and FLOOR are correct.
      
      Document a more serious problem.  Names appear to be written in
      the wrong locale.
      c48ba606
    • Jody Goldberg's avatar
      Fix typo breaking row/col ins/del breakage :-( · a5e04f49
      Jody Goldberg authored
      Make some minor improvements in status display for row/col selection.
      
      2000-05-14  Jody Goldberg <jgoldberg@home.com>
      
      	* src/commands.h : Reformat.
      
      	* src/commands.c (cmd_ins_del_row_col_{undo,redo}) : unant the
      	  selection when the topology changes.
      
      	* src/workbook.c (workbook_expr_relocate) : Fix typo.
      
      	* src/sheet-view.c (sheet_view_{col,row}_selection_changed) : Call
      	  sheet_update after a change.
      a5e04f49
  9. 13 May, 2000 1 commit
    • Michael Meeks's avatar
      Fix a load of evil embeddable-grid bugs, fix oaf activation. · 67608b01
      Michael Meeks authored
      
      Fix a load of evil embeddable-grid bugs, fix oaf activation.
      
      2000-05-11  Michael Meeks  <michael@helixcode.com>
      
      	* src/embeddable-grid.c (grid_view_activate): grab widget focus.
      
      	* src/workbook-format-toolbar.c (workbook_feedback_set): make it
      	cope with no format toolbar.
      
      	* src/workbook.c (workbook_init): g_new0 for safety and to blank
      	edit_line.
      
      	* src/embeddable-grid.c (grid_view_new): set a sensible default
      	size so we actually see something. (grid_view_activate): Fix with
      	state boolean. (set_header_visibility): implement.
      	(embeddable_grid_set_header_visibility): update.
      	(grid_view_destroy): kill. (grid_view_new): kill evil private list
      	of views.
      
      	* gnumeric.oafinfo: another fix, evil bug from oaf conversion script.
      67608b01
  10. 11 May, 2000 1 commit
  11. 10 May, 2000 2 commits
    • Michael Meeks's avatar
      Depend on a separate libole2; · 777d750e
      Michael Meeks authored
      2000-05-11  Michael Meeks  <michael@helixcode.com>
      
      	* src/Makefile.am (gnumeric_libs): kill libole2 libs kludge.
      
      2000-05-10  Michael Meeks  <michael@helixcode.com>
      
      	* configure.in: Add check for libole2 and add to gnome-config.
      777d750e
    • Jody Goldberg's avatar
      Make accelerators possible in gnumeric_toolbars. · 897c7caf
      Jody Goldberg authored
      
      Make accelerators possible in gnumeric_toolbars.
      
      Enable the workbook close optimization that clears the formula list before
      removing the cells.
      
      Add some (currently broken) accelerators for font attributes.
      897c7caf