1. 08 Apr, 2000 2 commits
    • Almer. S. Tigelaar's avatar
      Result of gtk_editable_get_chars was not freed. (2x) · 41906667
      Almer. S. Tigelaar authored
      2000-04-08  Almer. S. Tigelaar.  <almer1@dds.nl>
      
      	* src/dialogs/dialog-stf-csv-page.c
      	(csv_page_global_change) : Result of gtk_editable_get_chars was not
      	freed. (2x)
      
      	* src/stf-parse.c
      	(stf_parse_region) : Only the last item of the GSList's would be
      	freed
      	(stf_parse_sheet) : ditto
      41906667
    • Jon K Hellan's avatar
      Remove unused variable. · 51fb4350
      Jon K Hellan authored
      2000-04-08  Jon K Hellan  <hellan@acm.org>
      
      	* src/sheet.c (cellref_name): Remove unused variable.
      51fb4350
  2. 07 Apr, 2000 13 commits
    • Jon K Hellan's avatar
      Replace member name with name_quoted and name_unquoted. In name_quoted, · 699e8bf7
      Jon K Hellan authored
      2000-04-08  Jon K Hellan  <hellan@acm.org>
      
              * src/sheet.h (struct _Sheet): Replace member name with
      	name_quoted and name_unquoted. In name_quoted, names with spaces
      	or quote characters are protected with quotes.
      
      	* src/analysis-tools.c (prepare_output): Use
      	workbook_sheet_get_free_name to ensure that we don't create more
      	than one sheet with the same name.
      
      	* src/eval.c (dump_cell_list, sheet_dump_dependencies): Dump
      	sheet->name_unquoted instead of sheet->name.
      
      	* src/expr-name.c (name_sheet_title): Make value from
      	sheet->name_quoted instead of sheet->name. FIXME: Is this correct?
      
      	* src/gnumeric-sheet.c (selection_insert_selection_string): Make
      	selection string from sheet->name_quoted instead of quoting
      	sheet->name here.
      
      	* src/print-info.c (render_tab): Render sheet->name_unquoted
      	instead of sheet->name.
      
      	* src/print-preview.c (create_toplevel): Use sheet->name_unquoted
      	instead of sheet->name in window title.
      
      	* src/selection.c (sheet_selection_to_string, range_to_string):
      	Make reference string from sheet->name_quoted instead of quoting
      	sheet->name here.
      
      	* src/sheet.[ch] (sheet_quote_name): Rename to
      	sheet_name_quote. Take name_unquoted parameter, not a sheet.
      
      	* src/sheet.c (sheet_rename, sheet_new): Set both
      	sheet->name_quoted and sheet->name_unquoted.
      	(sheet_destroy): Free both sheet->name_quoted and
      	name_unquoted.
      	(cellref_name): Make reference from sheet->name_quoted instead of
      	quoting sheet->name here.
      
      	* src/test.c (thrash_sheet): Use sheet->name_unquoted instead of
      	sheet->name in debug output.
      
      	* src/value-sheet.c (value_dump): Dump sheet->name_quoted instead
      	of quoting sheet->name here.
      	(encode_cellref): Use sheet->name_quoted instead of quoting
      	sheet->name here.
      
      	* src/workbook.[ch] (workbook_sheet_get_free_name): Make it more
      	generally useful: Add "base" and "always_suffix" parameters. The
      	caller should now select the base to make the name from
      	(e.g. "Sheet"), and specify whether or not a suffix should be
      	added when the name "base" is not in use.
      
      	* src/workbook.c (insert_sheet_cmd): Use new signature of
      	workbook_sheet_get_free_name.
      	(workbook_rename_sheet): Insert unquoted name in hash table.
      	(sheet_label_text_changed_signal): Remove test for quote
      	characters in sheet name.
      	(sheet_action_delete_sheet): Prompt with name_unquoted instead of
      	name.
      	(sheet_action_rename_sheet, workbook_attach_sheet): Use
      	name_unquoted instead on name.
      	(workbook_detach_sheet): Use sheet->name_unquoted as hash key
      	instead of sheet->name.
      
      	* src/workbook-cmd-format.c
      	(workbook_cmd_format_sheet_change_name): Use name_unquoted instead
      	on name.
      
      	* src/xml-io.c (xml_sheet_write): Output sheet->name_unquoted
      	instead of sheet->name.
      
      	* src/dialogs/dialog-sheet-order.c (dialog_sheet_order_impl): Make
      	list header passive.
      	(add_to_sheet_clist, delete_cb): Substitute sheet->name_unquoted
      	for sheet->name.
      
      	* src/dialogs/dialog-zoom.c (dialog_zoom_impl): Ditto.
      
      2000-04-08  Jon K Hellan  <hellan@acm.org>
      
      	* graphic-context.c (graphic_wizard_guess_series): Substitute
      	sheet->name_quoted for sheet->name.
      
      2000-04-08  Jon K Hellan  <hellan@acm.org>
      
      	* ms-excel-read.c (ms_excel_set_xf, ms_excel_read_formula,
      	ms_excel_read_sheet):  Use
      	gnum_sheet->name_unquoted instead of gnum_sheet->name in debug
      	output.
      	(ms_excel_read_workbook): Remove unused variable to silence
      	warning.
      
      	* ms-excel-write.c (write_externsheets): Output
      	gnum_sheet->name_quoted instead of gnum_sheet->name. FIXME: Is
      	this correct?
      	(write_sheet): Use gnum_sheet->name_unquoted instead of
      	gnum_sheet->name in debug output.
      	(write_workbook): Output gnum_sheet->name_unquoted instead of
      	gnum_sheet->name.
      
      	* ms-formula-read.c (ms_excel_parse_formula): Use
      	gnum_sheet->name_unquoted instead of gnum_sheet->name in debug
      	output.
      
      	* ms-obj.c (object_anchor_to_position): Ditto.
      
      2000-04-08  Jon K Hellan  <hellan@acm.org>
      
      	* html.c (html_write_wb_html32, html_write_wb_html40): Output
      	sheet->name_unquoted instead of sheet->name.
      	(html_read): Gettextize sheet name template.
      
      	* latex.c (html_write_wb_latex, html_write_wb_latex2e):  Output
      	sheet->name_unquoted instead of sheet->name.
      
      	* roff.c (write_wb_roff): Ditto
      
      2000-04-08  Jon K Hellan  <hellan@acm.org>
      
      	* lotus.c (attach_sheet): Remove \n from sheet name. Gettextize
      	sheet name template.
      
      2000-04-08  Jon K Hellan  <hellan@acm.org>
      
      	* oleo.c (attach_sheet): Remove \n from sheet name. Gettextize
      	sheet name template.
      
      2000-04-08  Jon K Hellan  <hellan@acm.org>
      
      	* pln.c (pln_read_workbook): Use workbook_set_saveinfo instead of
      	workbook_set_filename.
      
      2000-04-08  Jon K Hellan  <hellan@acm.org>
      
      	* text-io.c (writeTextSheet): Output sheet->name_unquoted instead of
      	sheet->name.
      	(readTextWorkbook): Ungettextize name of sheet to
      	create. text_parse_file is supposed to rename it.
      699e8bf7
    • Jon K Hellan's avatar
      Use gladified random dialog: changed most members. (struct · 99790b18
      Jon K Hellan authored
      2000-04-08  Jon K Hellan  <hellan@acm.org>
      
      	* src/dialogs/dialog-analysis-tools.c (struct
      	random_tool_callback_t): Use gladified random dialog: changed most
      	members.
      	(struct DistributionStrs): New struct to hold name to show in list
      	and parameter labels for a random distribution.
      	(distribution_strs): Change to a DistributionStrs struct.
      	(output_range_selected): New callback function. This is part of a
      	change which selects the corresponding toggle button when the
      	output range field is entered. This works for all gladified
      	dialogs in this file.
      	(set_output_option_signals): Set up output_range_selected callback
      	on output range field. The widget is retrieved by name, so widget
      	names in analysis-tools.glade had to be changed.
      	(dialog_correlation_tool, dialog_covariance_tool,
      	dialog_ttest_paired_tool, dialog_ttest_eq_tool,
      	dialog_ttest_neq_tool, dialog_ftest_tool, dialog_average_tool,
      	dialog_ranking_tool, dialog_anova_single_factor_tool,
      	dialog_anova_two_factor_without_r_tool): New widget name for
      	output range field.
      	(dialog_correlation_tool, dialog_covariance_tool,
      	dialog_ttest_paired_tool, dialog_ttest_eq_tool,
      	dialog_ttest_neq_tool, dialog_ftest_tool, dialog_average_tool,
      	dialog_ranking_tool, dialog_anova_single_factor_tool,
      	dialog_anova_two_factor_without_r_tool): Make <Enter> in entry
      	fields activate default button.
      	(distribution_strs_find, distribution_parbox_config,
      	combo_get_distribution, dialog_random_realized): These new
      	functions are helpers for gladified random generation dialog.
      	(distribution_strs_find): Find strings record, given distribution
      	enum.
      	(distribution_parbox_config): Configure parameter widgets given
      	random distribution.
      	(combo_get_distribution): Find from combo the distribution the
      	user selected.
      	(distribution_callback): Configure parameter widgets for the
      	distribution which was selected.
      	(dialog_random_realized): Make initial geometry of distribution
      	table permanent.
      	(dialog_random_tool): Libgladify. This is a complete
      	rewrite. Other changes: Make the "distribution" variable function
      	static instead of file static. Rebuild the dialog each time it is
      	displayed. This is like the other libglade dialogs in this file.
      	Make <Enter> in entry fields activate default button. Get random
      	distribution name and parameter label strings from
      	distribution_strs struct. Use a "realized" callback to make
      	initial geometry permanent. Unref accel group for distribution
      	parameter widgets when dialog is destroyed.
      
      	* src/dialogs/analysis-tools.glade (All dialogs): Remove ':' from
      	frame labels. Add accelerators. Rename output range entry widgets
      	to xxx_output_range_entry. Minor output options tweaks.
      	(FTest dialog, TTest1 dialog, TTest2 dialog, TTest3 dialog): Use
      	alignment and fill instead of spaces to place label strings.
      	(Anova2 dialog, MovingAverage dialog): Use table in input frame so
      	that entry fields are aligned.
      	(Random dialog:) New dialog.
      99790b18
    • Morten Welinder's avatar
      Unref, not destroy. · d73b7bd1
      Morten Welinder authored
      2000-04-07  Morten Welinder  <terra@diku.dk>
      
      	* widget-pixmap-combo.c (pixmap_combo_destroy): Unref, not destroy.
      d73b7bd1
    • Miguel de Icaza's avatar
      Replace ::finalize with ::destroy. · 89b87726
      Miguel de Icaza authored
      2000-04-07  Miguel de Icaza  <miguel@gnu.org>
      
      	* widget-pixmap-combo.c (pixmap_combo_class_init): Replace
      	::finalize with ::destroy.
      89b87726
    • Morten Welinder's avatar
      Leaks. · 7760802e
      Morten Welinder authored
      2000-04-07  Morten Welinder  <terra@diku.dk>
      
      	* src/selection.c (sheet_selection_reset_only): Free the right list.
      	(sheet_is_range_selected): Avoid double assignment.
      	(sheet_is_cell_selected): Ditto.
      
      	* src/history.c (history_menu_remove_items): Plug leak.
      7760802e
    • Miguel de Icaza's avatar
      Fix leak. · d24709ac
      Miguel de Icaza authored
      2000-04-07  Miguel de Icaza  <miguel@gnu.org>
      
      	* widget-pixmap-combo.c (pixmap_combo_finalize): Fix leak.
      d24709ac
    • Jody Goldberg's avatar
      Fix typo, did this ever work ? · cf3f1e00
      Jody Goldberg authored
      
      2000-04-07  Jody Goldberg <jgoldberg@home.com>
      
      	* src/embeddable-grid.h (GridViewClass) : Fix typo, did this ever work ?
      
      	* src/workbook.c (workbook_move_sheet) : Mark the book as dirty when a
      	  sheet moved.
      	(insert_sheet_cmd) : Mark book as dirty when sheet is added.
      	(workbook_attach_sheet) : Add a precondition to avoid failing in the
      	  bonobo case.
      cf3f1e00
    • Morten Welinder's avatar
      Get rid of COLLECT_IGNORE_POSITIVE and COLLECT_IGNORE_NEGATIVE. · 6b3ee7b5
      Morten Welinder authored
      2000-04-07  Morten Welinder  <terra@diku.dk>
      
      	* src/collect.h (CollectFlags): Get rid of COLLECT_IGNORE_POSITIVE
       	and COLLECT_IGNORE_NEGATIVE.
      
      	* src/collect.c (callback_function_collect): Don't have the above
       	flags.
      
      	* src/functions/fn-financial.c (irr_npv_df): New function.
      	(gnumeric_irr): Use irr_npv_df for better results.
      	(gnumeric_ipmt, gnumeric_ppmt): Fix order of arguments!  (It works
       	so much better that way.)
      	(gnumeric_mirr): Fix formula.
      
      	* src/goal-seek.c (update_data): Spelling fix.
      
      	* src/functions/fn-financial.c (gnumeric_rate, gnumeirc_irr,
       	gnumeric_xirr): Use the supplied guess.
      6b3ee7b5
    • Jody Goldberg's avatar
      Fix minor thinko in eval_expr. · 0f4097ca
      Jody Goldberg authored
      Improve status update after load.
      
      2000-04-06  Jody Goldberg <jgoldberg@home.com>
      
      	* src/xml-io.c (gnumeric_xml_read_workbook) : No need to recalc, the
      	  loader handles it.
      
      	* src/file.c (workbook_read) : Do a recalc and sheet_update after loading.
      	  Wrap entire process in deep_{freeze,thaw}.
      
      	* src/expr.c (eval_expr) : Fix thinko.
      0f4097ca
    • Jody Goldberg's avatar
      Fix thinko. · f4bd1b61
      Jody Goldberg authored
      
      2000-04-06  Jody Goldberg <jgoldberg@home.com>
      
      	* src/expr.c (eval_expr) : Fix thinko.
      f4bd1b61
    • Jody Goldberg's avatar
      A small stabilization patch. Hopefully this will not conflict. · 0edb562f
      Jody Goldberg authored
      2000-04-06  Jody Goldberg <jgoldberg@home.com>
      
      	* graph.c (graph_compute_scatter_dimensions) : Minor patch to avoid
      	  crashing on empty selection.
      	* graph-view-scatter.c (graph_view_scatter_plot) : Ditto.
      	(graph_view_line_plot) : Ditto.
      0edb562f
    • Jody Goldberg's avatar
      Fix http://bugs.gnome.org/db/85/8506.html · 18e5debc
      Jody Goldberg authored
      Mixed mode references are evil.
      
      A bit of interface improvement for gtk-combo-text
      
      2000-04-06  Jody Goldberg <jgoldberg@home.com>
      
      	* src/functions/fn-string.c : Add func 'expression' to return text of
      	  formula.
      
      	* src/parser.y : It is illegal to write A1:Sheet2!A3.
      
      	* src/value.c (value_new_cellrange) : Take the eval pos so that we can
      	  correctly invert mixed mode references when necessary.
      
      	* src/expr.c (cell_ref_make_abs) : New routine.
      	(expr_relocate) : Handle changes in value_new_cellrange.
      	* src/func.c (function_marshal_arg) : Ditto.
      	* src/ranges.c (range_parse) : Ditto.
      
      	* src/corba-sheet.c (Sheet_cell_set_value) : No need to check these
      	  references.  They seem to be hard coded to be relative.
      
      	* src/functions/fn-lookup.c (gnumeric_offset) : Begin to handle
      	  relative references.
      
      	* src/sheet.c (cellref_get) : Simplify the logic a smidge.
      
      	* src/workbook.c (workbook_finish_editing) : Restore the edit area
      	  manually for now.  We may need to make the update flags finer grain.
      18e5debc
    • Miguel de Icaza's avatar
      Rename graph component name · 237ff618
      Miguel de Icaza authored
      237ff618
  3. 06 Apr, 2000 11 commits
    • Jody Goldberg's avatar
      Restore the edit area manually for now. We may need to make the update · 8ce52a88
      Jody Goldberg authored
      
      2000-04-06  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook.c (workbook_finish_editing) : Restore the edit area
      	  manually for now.  We may need to make the update flags finer grain.
      8ce52a88
    • Jody Goldberg's avatar
      update · 1e90d26f
      Jody Goldberg authored
      1e90d26f
    • Jody Goldberg's avatar
      unref the tooltip too. · 0404880a
      Jody Goldberg authored
      0404880a
    • Jody Goldberg's avatar
      Minor patch · c985018c
      Jody Goldberg authored
      c985018c
    • Morten Welinder's avatar
      I think we got it this time. · f0b3f683
      Morten Welinder authored
      f0b3f683
    • Jody Goldberg's avatar
      Init oldsplitpositions. Init format_run_parseoptions. · 7d3bc444
      Jody Goldberg authored
      
      2000-04-05  Jody Goldberg <jgoldberg@home.com>
      
      	* src/stf-parse.c (stf_parse_options_new) : Init oldsplitpositions.
      	* src/dialogs/dialog-stf-format-page.c (stf_dialog_format_page_init) :
      	  Init format_run_parseoptions.
      7d3bc444
    • Jody Goldberg's avatar
      New routine. (gtk_combo_test_finalize) : Ditto. · ba109cf0
      Jody Goldberg authored
      
      2000-04-05  Jody Goldberg <jgoldberg@home.com>
      
      	* gtk-combo-text.c (elements_free) : New routine.
      	(gtk_combo_test_finalize) : Ditto.
      	(gtk_combo_text_class_init) : Install a destructor.
      ba109cf0
    • Jody Goldberg's avatar
      Cache the Sheet* before freeing the closure. · a84d5411
      Jody Goldberg authored
      
      2000-04-05  Jody Goldberg <jgoldberg@home.com>
      
      	* src/clipboard.c (x_selection_received) : Cache the Sheet* before
      	  freeing the closure.
      
      	* src/workbook-format-toolbar.c (workbook_feedback_set) : Disable
      	  callbacks when setting the font status.  This avoids applying a
      	  spurious format.
      a84d5411
    • Morten Welinder's avatar
      Leak. · 9aac13d3
      Morten Welinder authored
      9aac13d3
    • Jody Goldberg's avatar
      merge eval_expr, eval_expr_nonempty, eval_expr_empty. · 8a1a4e5a
      Jody Goldberg authored
      
      2000-04-05  Jody Goldberg <jgoldberg@home.com>
      
      	* (*.[ch]) : merge eval_expr, eval_expr_nonempty, eval_expr_empty.
      
      	* src/xml-io.c (xml_write_attributes) : remove unused variable.
      	(xml_read_attribute) : Fix warning.
      8a1a4e5a
    • Miguel de Icaza's avatar
      Fix #8326 · 0b2c14fb
      Miguel de Icaza authored
      2000-04-05  Miguel de Icaza  <miguel@gnu.org>
      
      	Fix #8326
      
      	* src/print-info.c (print_info_new): Test was reversed here, so we
      	were actually flipping the orientation for printing.
      
      	* src/print.c (print_sheet_range): Now the routine returns the
      	number of pages printed, and can be directed not to generate
      	actual output.
      	(print_sheet_range): Do column/row fitting for the other printing
      	order as well.
      	(compute_sheet_pages): Support both empty-page printing, and non
      	empty-page printing.
      	(print_page): Can now print and detect if there is anything to
      	print.
      0b2c14fb
  4. 05 Apr, 2000 6 commits
    • Jody Goldberg's avatar
      Continue slow progress towards correctly updating the status region. · ac07ca90
      Jody Goldberg authored
      2000-04-05  Jody Goldberg <jgoldberg@home.com>
      
      	* src/commands.c (cmd_paste_cut_undo) : Use sheet_update and force a
      	  status update.
      	(cmd_paste_cut_redo) : Ditto. Change the selection here.
      
      	* src/sheet.c (sheet_flag_status_update_range) : Handle NULL ranges.
      
      	* src/selection.c (sheet_selection_add_range) : Use
      	  sheet_flag_status_update_range rather than an immediate call
      	  to selection_changed_hook (that is deprecated).
      	(sheet_selection_move) : Delete.
      	(sheet_selection_paste) : Use sheet_update.
      
      	* src/clipboard.c (clipboard_paste_region) : Remove unnecessary and
      	  incorrect code to do status updates.  The selection mechanism
      	  handles it already.
      	(x_selection_received) : Use sheet_update.
      
      	* src/about.c (dialog_about) : Add Almer.
      ac07ca90
    • Michael Meeks's avatar
      stupid typo. · 75737e98
      Michael Meeks authored
      75737e98
    • Michael Meeks's avatar
      kill leak. (sheet_destroy_styles): destroy hash. · c843f8c1
      Michael Meeks authored
      2000-04-05  Michael Meeks  <michael@helixcode.com>
      
      	* src/sheet-style.c (sheet_style_compute): kill leak.
      	(sheet_destroy_styles): destroy hash.
      
      2000-03-25  Michael Meeks  <michael@helixcode.com>
      
      	* src/sheet-object-bonobo.c (sheet_object_bonobo_load): Add
      	warnings and fixup.
      c843f8c1
    • Morten Welinder's avatar
      Sort. · f6082a64
      Morten Welinder authored
      f6082a64
    • Jody Goldberg's avatar
      Fix some updates. Be more paranoid when printing. Big speedup for implicit · a447415c
      Jody Goldberg authored
      Fix some updates.
      Be more paranoid when printing.
      Big speedup for implicit intersection.
      
      2000-04-05  Jody Goldberg <jgoldberg@home.com>
      
      	* src/functions/fn-logical.c (gnumeric_if) : Use eval_expr_nonempty
      	  and permit non-scalars.
      	* src/functions/fn-lookup.c (gnumeric_choose) : Ditto.
      	* src/functions/fn-math.c (gnumeric_sumproduct) : Ditto.
      
      	* src/functions/fn-information.c (get_value_class) : Use
      	  eval_expr_empty, and permit non-scalars.
      
      	* src/func.c (function_iterate_argument_values) : Permit non-scalar
      	  values.
      	(function_marshal_arg) : Be more specific about what types of argument
      	  must be scalar.
      
      2000-04-04  Jody Goldberg <jgoldberg@home.com>
      
      	* src/functions/fn-math.c (gnumeric_sumproduct) : eval_expr_nonempty
      	  and permit non-scalars.
      	* src/functions/fn-lookup.c (gnumeric_choose) : Ditto.
      
      	* src/expr-name.c (eval_expr_name) : Accept 'as_scalar' as an
      	  argument use eval_expr_empty.
      
      	* src/expr.c (eval_expr_real) : Push the common cases for implicit
      	  intersection further down for a big speed improvement.
      	(eval_expr_nonempty) : New routine.
      	(eval_expr_empty) : Accept as_scalar.
      
      2000-04-04  Jody Goldberg <jgoldberg@home.com>
      
      	* src/item-grid.c (item_grid_button_1) : sheet_update after button
      	  press that changes selection.
      
      2000-04-04  Jody Goldberg <jgoldberg@home.com>
      
      	* src/print.c (print_hf) : Add precautions in an attempt to address
      	  http://bugs.gnome.org/db/82/8200.html
      	  I can not replicate it, but it can't hurt to be more careful just in
      	  case.
      a447415c
    • Miguel de Icaza's avatar
      Flush the canvas updates · ddebc71f
      Miguel de Icaza authored
      2000-04-04  Miguel de Icaza  <miguel@gnu.org>
      
      	* src/item-cursor.c (item_cursor_autofill_event): Flush the canvas updates
      ddebc71f
  5. 04 Apr, 2000 4 commits
    • Kjartan Maraas's avatar
      Updated Norwegian translation. · 90d8ed64
      Kjartan Maraas authored
      2000-04-04  Kjartan Maraas  <kmaraas@online.no>
      
      	* no.po: Updated Norwegian translation.
      90d8ed64
    • Jody Goldberg's avatar
      Improve status update. · 56a9e1f0
      Jody Goldberg authored
      Simplify a few command paths in preparation for registration.
      Hopefully fix bug 3961
      
      2000-04-04  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook.c (workbook_class_init) : Remove CELL_CHANGED.
      	(workbook_finish_editing) : At LAST! cmd_set_text is responsible for
      	  setting the text directly :-)
      
      	* src/workbook-format-toolbar.c (change_font_size_in_selection_cmd) :
      	  cmd_format takes care of the height adjustments.
      	* src/dialogs/dialog-cell-format.c (cb_fmt_dialog_dialog_apply) : Ditto.
      
      	* src/sheet.c (Sheet): Add flags edit_pos_changed, selection_content_changed.
      	(sheet_new) : init them.
      	(sheet_flag_status_update_cell) : New function that sets the flags.
      	(sheet_flag_status_update_range) : Ditto.
      	(sheet_update) : Fix typo. Add support for new flags.
      	(sheet_update_auto_expr) : Const correctness.
      	(sheet_update_controls) : Ditto.
      	(sheet_load_cell_val) : Ditto. Delete unused signal.
      	(sheet_set_text) : Use sheet_flag_status_update_range.
      	(sheet_set_edit_pos) : New routine.
      	(sheet_cursor_move) : Delete.
      	(sheet_fill_selection_with) : Remove.
      
      	* src/selection.c (sheet_selection_changed_hook) : const correctness.
      	(sheet_selection_change) : merge into sheet_selection_set.
      	(sheet_selection_extend_to) : Use sheet_selection_set.
      	(sheet_selection_set) : Merge with sheet_selection_change and use the
      	  sheet_cursor accessors rather than changing things directly.
      	(sheet_selection_walk_step) : Use sheet_selection_set, and sheet_set_edit_pos.
      
      	(sheet_is_all_selected) : const correctness.
      	(sheet_is_cell_selected) : New routine.
      	(sheet_is_range_selected) : New routine.
      
      	* src/item-grid.c (item_grid_draw_background) : Adjust to rename of
      	* sheet_selection_is_cell_selected -> sheet_is_cell_selected.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) : Cleanup the
      	  logic for creating fills and arrays so that it can have undo
      	  support.
      	  - Change the heuristic for selecting what type of characters can start
      	    an edit session.  Rather than using fixed Latin1 centric codes,
      	    guess that the 'length' field of the event is >0 if the character is
      	    printable.  Be more careful NOT to forward characters to the entry
      	    if we are not editing.
      	  - Use sheet_update.
      
      	* src/commands.c (command_pop_list_top) : Delete.
      	(cmd_format_redo) : Apply the height adjustment here.
      	(cmd_set_area_*) : Implement.
      	(*) : Use sheet_update.
      
      	* src/colrow.c (rows_height_update) : Moved here and generalized from
      	  sheet_selection_height_update.
      
      	* src/clipboard.c (sheet_paste_selection) : No need to call
      	  sheet_cursor_set.  sheet_selection_add_range already does that.
      	(clipboard_paste_region) : Flag updates to the status display if
      	  something changes.
      56a9e1f0
    • Jon K Hellan's avatar
      Call gnumeric_sheet_make_visible only if sheet widget is realized. · affafc8a
      Jon K Hellan authored
      2000-04-04  Jon K Hellan  <hellan@acm.org>
      
      	* src/sheet-view.c (sheet_view_set_zoom_factor): Call
      	gnumeric_sheet_make_visible only if sheet widget is realized.
      	(sheet_view_make_edit_pos_visible): New function: Make cell at
      	edit position visible.
      	(sheet_view_size_allocate): Add call to
      	sheet_view_make_edit_pos_visible.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_make_cell_visible): Add
      	comment.
      
      	* src/xml-io.c (xml_sheet_read): Read zoom into a local variable
      	before calling sheet_set_zoom_factor. Otherwise,
      	sheet_set_zoom_factor would assume that it had already initialized
      	this factor.
      
      	* src/workbook.c (change_zoom_in_current_sheet_cb): No longer call
      	change_displayed_zoom_cb, sheet_set_zoom_factor will call it
      	indirectly.
      
      	* src/workbook.[ch] (workbook_class_init,
      	workbook_focus_current_sheet, workbook_create_standard_toobar):
      	Rename "sheet_changed" signal to "sheet_entered".  Remove
      	"cell_changed" signal.
      	(workbook_focus_current_sheet): Rename "sheet_changed" signal to
      	"sheet_entered".
      	(workbook_zoom_feedback_set): New function: Update zoom combo in
      	toolbar when zoom changes.
      
      	* src/sheet.c (sheet_update_zoom_controls): New function: Update
      	zoom controls when zoom changes.
      	(sheet_set_zoom_factor): Use it.
      	(sheet_load_cell_val): Do not emit "cell_changed".
      
      	* src/dialogs/dialog-cell-format.c (cb_fmt_dialog_dialog_apply):
      	Call sheet_update_controls to update toolbar controls.
      
      	* src/history.c (file_history_cmd): Remove pristine workbook when
      	a new one is read in. For consistency with File/Open, File/Import
      	and Bonobo File/History.
      
      	* src/dialogs/dialog-workbook-attr.c
      	(cb_attr_dialog_dialog_apply): Include workbook-view.h to get
      	prototype for workbook_view_pref_visibility.
      
      	* src/border.h (style_border_print): Remove bogus const in  prototype.
      	Reported by Aron Griffis.
      affafc8a
    • Jody Goldberg's avatar
      Bug 8315 · b7c58c38
      Jody Goldberg authored
      2000-04-04  Jody Goldberg <jgoldberg@home.com>
      
      	* ms-obj.c (ms_obj_read_biff8_obj) : Be more careful about when to
      	  dump debug info when the stated record size disagrees with the
      	  actual.
      b7c58c38
  6. 03 Apr, 2000 1 commit
  7. 02 Apr, 2000 3 commits
    • Jody Goldberg's avatar
      update · d04d91e7
      Jody Goldberg authored
      d04d91e7
    • Jody Goldberg's avatar
      Chris is 'Da Man' (tm) ! · 7fad990a
      Jody Goldberg authored
      After much wasted thought effort and hair pulling the problem boiled
      down to me not realizing that it was bad to request and update for a
      canvas item from an update routine even for a different canvas item.
      
      2000-04-02  Jody Goldberg <jgoldberg@home.com>
      
      	* src/item-edit.c (entry_changed) : Call scan_for_range here.
      	(item_edit_set_arg) : And here.
      	(recalc_spans) : But NOT here.  Calling request_update while updating
      	  any other canvas item is bad.
      
      	* src/item-cursor.c (item_cursor_set_bounds) : remove ugly hack.
      7fad990a
    • Jody Goldberg's avatar
      Add description of double quote handling. Init indicator_2x_is_single and · 527ca0cf
      Jody Goldberg authored
      
      2000-04-02  Jody Goldberg <jgoldberg@home.com>
      
      	* doc/stf-parser.txt : Add description of double quote handling.
              * src/stf-parse.c (stf_parse_options_new) : Init
      	  indicator_2x_is_single and duplicates.
      	(stf_parse_options_csv_set_indicator_2x_is_single) : New function.
      	(stf_parse_csv_cell) : Add logic to optionaly treat double quotes as a
      	  single escaped quote.
      	* src/dialogs/dialog-stf-csv-page.c : Add the double quote checkbox.
      	* src/dialogs/dialog-stf.glade : Ditto.
      527ca0cf