GitLab

  fix a redraw bug.  Things are faster but not fixed.

- Fix the real problem.  More cleanup of the cursor/selection code is required.
  There is too much incest in there.  We are redoing 75% of the necessary operations
  at several level in an attempt to get all the requisite pieces.

2000-02-20  Jody Goldberg <jgoldberg@home.com>

	* src/item-cursor.c : Switch to a quartic approved delayed update
	  model.  Do not change the bounding box while drawing.

	* src/selection.c (sheet_selection_add_range) : Do NOT directly change
	  the edit/move/base characteristics of the sheet sheet_cursor_set handles
	  that.

	* src/gnumeric-sheet.c (gnumeric_sheet_compute_visible_ranges) : Use
	  item_cursor_reposition rather than pretending that the cursor moved.

	* src/item-grid.c (item_grid_button_1) : Don't call both
	  sheet_cursor_move and sheet_selection_add.  The former was moving
	  the edit cursor without redrawing it.

This is not the RIGHT fix, but it is A fix.  When this is developed we
can solve it properly.

2000-02-19  Jody Goldberg <jgoldberg@home.com>

	* src/selection.c (sheet_selection_extend) : Don't store the results
	  of the move directly into sheet::cursor::move_corner.  That makes
	  sheet_selection_extend_to think there is nothing to be done.

Modified Files:
 	gnome-applets/po/da.po gnome-core/po/da.po gnome-libs/po/da.po
 	gnumeric/po/da.po

2000-02-19  Jukka-Pekka Iivonen  <iivonen@iki.fi>

	* src/dialogs/dialog-analysis-tools.c: Made the cancel operation
	of a tool to return the tool selection.

2000-02-20  Jukka-Pekka Iivonen  <iivonen@iki.fi>

	* src/dialogs/analysis-tools.glade,
	src/dialogs/dialog-analysis-tools.c: Implemented Glade dialogs for
	Anova two-single factor and Moving average tools.

2000-02-18 Almer. S. Tigelaar.  <almer1@dds.nl>

	* /src/dialogs/dialog-stf.glade :
	Corrected a minor spelling error on the first page of
	the druid.

2000-02-18 Almer. S. Tigelaar. <almer1@dds.nl>

	* /src/dialogs/dialog-stf.glade :
	Corrected a minor spelling error on the first page of
	the druid.

2000-02-18 Almer. S. Tigelaar.  <almer1@dds.nl>

	* /src/dialogs/dialog-stf.glade :
	Corrected a minor spelling error on the first page of
	the druid.

2000-02-19  Jukka-Pekka Iivonen  <iivonen@iki.fi>

	* src/dialogs/dialog-autosave.c: Added a few checks for the
	correctness of autosave.glade file.

	* src/dialogs/analysis-tools.glade,
	src/dialogs/dialog-analysis-tools.c: Implemented Glade dialog for
	Anova single factor tool.

2000-02-18 Almer. S. Tigelaar.  <almer1@dds.nl>

	What follows is the Changelog entry for the new STF that miguel
	commited.

	The original STF Plug-in has been removed and is now merged
	with the Gnumeric main sources.
	Numerous bug fixes have been made, the major ones :

	* stf-util.c, stf-util.h :
	Obsoleted, merged with dialog_stf.[ch]

	* stf-fixed.c, stf-separated.c, stf-fixed.h, stf-separated.h :
	Obsoleted, replace with stf-parse.[ch], a new interface.

	* stf-parse.h, stf-parse.c :
	Two new units which are a re-make of the stf-separated.c and
	stf-fixed.c. These supersede those two units.

	* dialog-stf.c, dialog-stf.h, dialog-stf-csv-page.c, dialog-stf-fixed-page.c :
	Altered so they use the new stf-parse.[ch] instead of stf-separated.c
	and stf-fixed.c.

	* dialog-stf-main-page.c
	Now allows you to select both the line to start _and_ the line to stop
	importing.

	* dialog-stf-fixed-page.c :
	Apart from some minor bug fixes you can now also use the mouse
	to interactively create, delete and resize columns.

	* dialog-stf-format-page.c :
	Now allows you to click in the preview to select a column.
	Also fixed minor errors

	* dialog-stf-preview.c, dialog-stf-preview.h :
	Completely revised preview rendering, lots of changes.

	* dialog-stf.glade :
	More descriptive hints on each page

	Now some integration changes :

	* main.c
	Modified to also initialize the stf-plugin

	* stf.c, stf.h
	Now uses the new dialog-stf.[ch] and stf-parse.[ch] interfaces.

	* clipboard.c
	modified (x_selection_to_cell_region) to use the STF stuff instead
	of the previous 'based-on-assumptions' approach.
	->by request from Jody Goldberg

- Simplify and enhance the cursor and selection code.
  Its not as pretty as I'd like, but its getting better.
- Fix a display glitch in the item-bar.  canvas redraw excludes
  the far coordinate.  That will teach me to read docs.

2000-02-18  Jody Goldberg <jgoldberg@home.com>

	* src/widgets/widget-color-combo.c (color_combo_construct) : typo.
	(color_combo_new) : Disable the charting colours for now.  They are
	  mostly duplicates.

2000-02-16 Dom Lachowicz <dominicl@seas.upenn.edu>

	* src/widgets/widget-color-combo.[ch]
	Changed the code some to enable tooltips
	Minor api changes

2000-02-18  Jody Goldberg <jgoldberg@home.com>

	* src/workbook-view.c : Add history.h.

2000-02-18  Jody Goldberg <jgoldberg@home.com>

	* src/sheet.c (sheet_redraw_selection) : Delete.

	* src/selection.c (sheet_selection_extend_to) : Short circuit when
	  there would be no change to the selection.
	(sheet_selection_change) : The sheet already has the correct edit,
	  move, base positions.  Use them.

	* src/sheet-view.c (sheet_view_redraw_headers) : gnome_canvas_request_redraw
	  EXCLUDES the far coordinates.  Add 1 so that the last pixel get
	  redrawn too.

2000-02-18  Jody Goldberg <jgoldberg@home.com>

	* src/history.c (history_menu_item_create) : typo.

2000-02-18  Jody Goldberg <jgoldberg@home.com>

	* src/dialogs/dialog-goal-seek.c (dialog_goal_seek) : Use edit_pos.
	* src/dialogs/dialog-solver.c (dialog_solver) : Ditto.

	* src/xml-io.c (xml_read_selection_info) : Use edit_pos.
	(xml_write_selection_info) : Ditto.

	* src/workbook.c (cb_sheet_check_dirty) : Use edit_pos.
	(paste_cmd) : Ditto.
	(paste_special_cmd) : Ditto.
	(insert_current_date_cmd) : Ditto.
	(insert_current_time_cmd) : Ditto.
	(workbook_edit_comment) : Ditto.

	* src/sheet.c (sheet_new) : sheet_selection_append -> sheet_selection_add.
	(sheet_accept_pending_input) : Use edit_pos.
	(sheet_load_cell_val) : Ditto.
	(sheet_start_editing_at_cursor) : Ditto.
	(sheet_update_controls) : Ditto.
	(sheet_{col,row}_selection_type) : Fix cut-paste-o.
	(walk_boundaries) : Move to selection.c.
	(walk_boundaries_wrapped) : Ditto.
	(sheet_selection_walk_step) : Reworked and moved to selection.c.
	(sheet_cursor_move) : Switch to new framework.
	(sheet_cursor_set) : Ditto.
	(sheet_set_selection) : Delete.

	* src/sheet.h : (SheetSlection) : Remove base member.
	(Sheet) : adjsut notion of cursor to differentiate between,
	edit, base, and movement.  (see comments).
	* src/sheet-view.c (sheet_view_set_zoom_factor) : Use edit_pos.
	(sheet_view_scrollbar_config) : Switch to new scheme.
	(sheet_view_{col,row}_selection_changed) : Make the Top/Left visible
	  cell the edit cursor when things are out of range.

	* src/sheet-style.c (sheet_style_attach) : Use sheet_redraw_range directly.
	(sheet_range_apply_style) : Ditto.
	(sheet_range_set_border) : Ditto.

	* src/selection.c (sheet_selection_add_range) : Renamed from,
	  sheet_selection_append.  Document.  Switch to new edit, base, move
	  scheme.  Directly call sheet_cursor_set rather than the confusingly
	  named sheet_set_selection.
	(sheet_selection_add) : Renamed from sheet_selection_append.
	(sheet_selection_change) : Adjsut parm name from 'new' -> 'new_sel' to
	  enable test compiles from C++.
	(sheet_selection_extend_to) : Switch to new edit, base, move scheme.
	(sheet_selection_extend) : Just call sheet_selection_extend_to for the
	  main work.  Document.
	(sheet_select_all) : sheet_selection_append_range -> sheet_selection_add_range.
	(sheet_selection_extend_{horizontal, vertical} : Merge in to
	  sheet_seletion_extend and fix.
	(sheet_selection_set) : Switch to the new scheme.
	(sheet_selection_reset) : sheet_selection_append -> sheet_selection_add.
	  Use edit_pos.
	(walk_boundaries) : Moved from sheet.c, merged with
	  walk_boundaries_wrap, and change signature.
	(sheet_selection_walk_step) : Moved from sheet.c and switched to the
	  new method.  Do not change the selected region while iterating.

	* src/item-grid.c (item_grid_paint_empty_cell) : Use edit_pos.
	(item_grid_draw_cell) : Ditto.
	(item_grid_event) : Ditto.
	(context_paste_cmd) : Use the base and move cursors.
	(context_paste_special_cmd) : Ditto.
	(item_grid_button_1) : sheet_selection_append -> sheet_selection_add.

	* src/item-cursor.c (item_cursor_autofill_event) : Use
	  sheet_selection_add_range rather than the two step select extend.

	* src/clipboard.c (sheet_paste_selection) : Use
	  sheet_selection_add_range rather than the 2 step process
	  of setting the corner and extending.

	* plugins/excel/ms-excel-read.c (ms_excel_read_selection) :
	    sheet_selection_append_range -> sheet_selection_add_range
	* src/corba-sheet.c (Sheet_selection_append) : Ditto.
	(Sheet_selection_append_range) : Ditto.

	* src/gnumeric-sheet.c (move_cursor) : Ditto.
	(gnumeric_sheet_key_mode_sheet) : Ditto.  Use edit_pos.
          sheet_selection_walk_step now handles the cursor and selection
	  changes.
	(gnumeric_sheet_set_selection) : Delete this was unnecessary.
	(gnumeric_sheet_set_cursor_bounds) : Add preconditions.
	(move_cursor_horizontal) : Use the edit_pos for movement.
	(move_cursor_vertical) : Ditto.
	(gnumeric_sheet_create_editing_cursor) : Ditto.
	(start_cell_selection) : Ditto.
	(move_horizontal_selection) : Use sheet_selection_extend.
	(move_vertical_selection) : Ditto.
	(gnumeric_sheet_compute_visible_ranges) : Force a redraw of the
	  item-cursor when the visible region changes.  FIXME : This should be
	  an update not a redraw.

2000-02-18  Miguel de Icaza  <miguel@gnu.org>

	* configure.in (EXTRA_GNOME_CFLAGS): Remove stf plugin from here.
	* plugins/Makefile.am (SUBDIRS): And from here.

	* src/stf.c (stf_open_and_read): Use malloc instead of g_malloc0
	because g_malloc aborts execution if the buffer is too large
	(which it might likely be).
	(stf_read_workbook): Release using free, not g_free here.
	(stf_read_workbook): Fix sheet object memory leak.
	(stf_init): Kill old and unused code.

Modified Files:
 	gnome-applets/asclock/asclock_applet.desktop
 	gnome-core/desktop-links/Settings.directory
 	gnome-libs/po/da.po gnumeric/po/da.po

2000-02-18  Michael Meeks  <michael@helixcode.com>

	* src/workbook.c (workbook_new): setup view history.
	(workbook_do_destroy): add workbook to view history and write config.

	* src/history.c (history_item_label): substantialy alter.
	(history_remove_menu_item): kill translation on non bonobo case.

2000-02-18  Mike Kestner  <mkestner@ameritech.net>

	* src/application.c (application_history_get_list): add
	(application_history_update_list, application_history_list_shrink),
	(application_history_write_config): ditto.

	* src/workbook-view.c (workbook_view_history_setup): create.
	(workbook_view_history_update, workbook_view_history_shrink): ditto.

	* src/Makefile.am: add history.[ch].

	* src/history.[ch]: Added.

2000-02-18  Jukka-Pekka Iivonen  <iivonen@iki.fi>

	* src/dialogs/analysis-tools.glade,
 	src/dialogs/dialog-analysis-tools.c: Implemented Glade dialogs for
 	T-Test tools.

	* src/dialogs/dialog-autosave.c: Fixed a few bugs in
 	dialog_autosave (cancel caused segmentation fault at the next
 	run).  Made the prompt button unsensitive if the autosave is
 	turned off.

	* src/analysis-tools.c: Made the titles to be printed in italic
 	style for Correlation, Covariance, F-Test, and T-Test tools.  In
 	addition, the columns are autosized.

Modified Files:
 	balsa/balsa.desktop gnome-applets/po/da.po
 	gnome-core/desktop-links/Internet.directory
 	gnome-core/gnome-terminal/gnome-terminal.desktop
 	gnome-core/gnome-terminal/da/gnome-terminal.sgml
 	gnome-core/po/da.po gnome-network/girc/girc.desktop
 	gnome-network/gmailman/gmailman.desktop
 	gnome-network/gnome-ppp/gnome-ppp.desktop
 	gnome-network/gnome-ppp/gnome-ppp-applet/ppp-applet.desktop
 	gnome-network/gnometalk/gtalk.desktop
 	gnome-network/network-utilities/itools.desktop
 	gnome-network/sync/gnome-sync.desktop gnumeric/po/da.po

2000-02-16  Miguel de Icaza  <miguel@gnu.org>

	* src/widgets/widget-pixmap-combo.c (pixmap_combo_select_pixmap):
	Changed the code to use gnoem_pixmaps here.
	(pixmap_combo_construct): and here.

2000-02-15  Jody Goldberg <jgoldberg@home.com>

	* *.[ch] : More header cleanup.  Remove value.h and sheet.h
	  from expr.h.  Remove sheet.h from cell.h.

2000-02-16  Dom Lachowicz <dominicl@seas.upenn.edu>

	* src/plugin-manager.c : Move functionality.
	* src/dialogs/dialog-plugin-manager.c : here.  and move to libglade.

	* src/workbook.c (plugins_cmd) : Use dialog_plugin_manager instead
	  of plugin_manager_new.

2000-02-16  Jukka-Pekka Iivonen  <iivonen@iki.fi>

	* src/dialogs/analysis-tools.glade, src/analysis-tools.c,
 	src/dialogs/dialog-analysis-tools.c: Implemented Glade dialog for
 	Rank and Percentile tool.

every time we set the width/height of a col/row.

2000-02-15  Jody Goldberg <jgoldberg@home.com>

	* src/workbook-cmd-format.c (workbook_cmd_format_{column,row}_auto_fit) :
	  Handle repositioning and redrawing here in preparation to adding undo.
	(workbook_cmd_format_column_width) : Ditto.
	(workbook_cmd_format_row_height) : Ditto.

	* src/sheet.c (sheet_reposition_comments_from_{row,col}) : publicize.
	(sheet_recompute_spans_for_col) : Ditto.
	(sheet_save_row_col_sizes) : Store cols/rows of 'default' size as 0.
	(sheet_restore_row_col_sizes) : Restore cols/rows to true default state.
	(sheet_{col,row}_set_size_pts) : document, and REMOVE calls to reposition
	  and redraw.

2000-02-16  Jon K Hellan  <hellan@acm.org>

	* src/sheet.c (col_row_info_init): Fix typo

Modified Files:
 	gnumeric/po/da.po

2000-02-15  Jon K Hellan  <hellan@acm.org>

	* pln.c: include cell.h, workbook.h
	(pln_parse_sheet): Update from using to sheet_col_set_width to
	sheet_col_set_size_pixels.

2000-02-14  Jon K Hellan  <hellan@acm.org>

        * src/dialogs/import.glade: Add scrolled window

	* src/file.c (workbook_read, workbook_import, workbook_save_as,
	workbook_save): Use error message template.

	* src/command-context.h (struct _CommandContext): Add
	template_list member.
	(struct CommandContextClass): Call message parameter to methods
	"message".
	(command_context_push_template, command_context_pop_template):
	Declare.

	* src/command-context.c (command_context_push_template): New
	function. Push a printf template for error messages to stack.
	(command_context_pop_template): New function. Pop current template
	from stack.
	(format_message): New function. Format a message using template on
	stack.
	(gnumeric_error_plugin_problem, gnumeric_error_read,
	gnumeric_error_save): Use format_message.

	* src/command-context-corba.c (ccc_error_plugin_problem,
	ccc_error_read, ccc_error_save): Call message parameter
	"message".

	* src/command-context-gui.c (ccg_error_plugin_problem,
	ccg_error_read, ccg_error_save): Ditto.

2000-02-14  Jody Goldberg <jgoldberg@home.com>

	* src/cell-draw.c (cell_draw) : Cells can span in either direction.

should match exactly now.

2000-02-14  Jody Goldberg <jgoldberg@home.com>

	* src/format.c (format_value) : Empty formats produce empty cells.

	* src/workbook.c (workbook_menu_tools) : Move the plugins menu item to
	  the Tools menu.

2000-02-14  Jukka-Pekka Iivonen  <iivonen@iki.fi>

	* src/dialogs/analysis-tools.glade, src/analysis-tools.c,
 	src/dialogs/dialog-analysis-tools.c: Implemented Glade dialogs for
 	Correlation, Covariance, and F-Test tools.